profile
viewpoint
Joel Gallant joelgallant Calgary, AB joelgallant.me Polyglot with a strong FOSS interest. Fly-by contributor in my free time.

joelgallant/aglio 0

An API Blueprint renderer with theme support that outputs static HTML

joelgallant/api-fields 0

Class decorator to trim object fields in API responses

joelgallant/api-fields-middleware 0

API Fields, as composable koa middleware

joelgallant/app-config 0

Simple, strongly typed configuration loader for JavaScript and TypeScript

joelgallant/app-config-plugin 0

Webpack plugin for loading app-config files

joelgallant/arewewebyet 0

Are we web yet? A simple reckoning of Rust’s readiness for Web-related things.

joelgallant/automated-scout16 0

2016 FRC season automated power rankings, prediction, etc.

joelgallant/balena-request 0

Balena HTTP client.

pull request commentchakra-ui/chakra-ui

Uses `keyof JSX.IntrinsicElements` for 'As' type used in PropsOf

Test failure looks unrelated?

joelgallant

comment created time in 2 days

create barnchjoelgallant/chakra-ui

branch : ts-props-of

created branch time in 2 days

fork joelgallant/chakra-ui

⚡️ Simple, Modular & Accessible UI Components for your React Applications

https://chakra-ui.com

fork in 2 days

issue commentchakra-ui/chakra-ui

TypeScript build error in rc.{3-5}

I think so, working on it now.

joelgallant

comment created time in 2 days

issue commentchakra-ui/chakra-ui

TypeScript build error in rc.{3-5}

Actually, even better. It looks like chakra-ui actually ships this code:

// @ts-expect-error
type PropsOf<T extends As> = React.PropsWithRef<React.ComponentProps<T>>

That's in forward-ref.tsx of the system package. It shouldn't end up in production builds, presumably, but it is.

joelgallant

comment created time in 2 days

issue commentchakra-ui/chakra-ui

TypeScript build error in rc.{3-5}

Yup, full reinstall without a lockfile. I noticed in the sandbox that "skipLibCheck" is on - that'll hide this problem. It happens before any of my TS is compiled (skipLibCheck "fixes" this problem in my repo). I'll take a quick shot at reproducing it, though I'll probably just make a PR with a fix here since it looks simple.

joelgallant

comment created time in 2 days

issue commentchakra-ui/chakra-ui

TypeScript build error in rc.{3-5}

Thanks for the quick response. I am using react types 16.9.53, which it looks like is the latest. Tried reinstalling but no luck. Is that the same as https://github.com/chakra-ui/chakra-ui/issues/2274? They look on surface level to be different problems.

joelgallant

comment created time in 2 days

issue openedchakra-ui/chakra-ui

TypeScript build error in rc.{3-5}

Bug report

Describe the bug

Using TypeScript with strict mode on, this internal error comes up.

node_modules/@chakra-ui/system/dist/types/forward-ref.d.ts:10:186 - error TS2344: Type 'T' does not satisfy the constraint '"symbol" | "object" | "button" | "meter" | "textarea" | "style" | "progress" | "text" | "ruby" | "table" | "small" | "sub" | "circle" | "embed" | "pre" | "caption" | "menu" | "menuitem" | ... 158 more ... | (new (props: any) => Component<...>)'.
  Type 'As' is not assignable to type '"symbol" | "object" | "button" | "meter" | "textarea" | "style" | "progress" | "text" | "ruby" | "table" | "small" | "sub" | "circle" | "embed" | "pre" | "caption" | "menu" | "menuitem" | ... 158 more ... | (new (props: any) => Component<...>)'.
    Type 'string' is not assignable to type '"symbol" | "object" | "button" | "meter" | "textarea" | "style" | "progress" | "text" | "ruby" | "table" | "small" | "sub" | "circle" | "embed" | "pre" | "caption" | "menu" | "menuitem" | ... 158 more ... | (new (props: any) => Component<...>)'.
      Type 'T' is not assignable to type '"view"'.
        Type 'As' is not assignable to type '"view"'.
          Type 'string' is not assignable to type '"view"'.

10 declare type PropsOf<T extends As> = T extends React.ComponentClass<infer P> ? React.PropsWithoutRef<P> & React.RefAttributes<InstanceType<T>> : React.PropsWithRef<React.ComponentProps<T>>;

Minimal reproduction

<!-- Please provide a codesandbox link or GitHub repo with a minimal reproduction of the bug.

Official Chakra CodeSandbox templates:

created time in 2 days

startedjmesmon/rust-systemd

started time in 6 days

startedtokio-rs/async-stream

started time in 9 days

startedkamranahmedse/developer-roadmap

started time in 10 days

push eventmehcode/config-rs

Matthias Beyer

commit sha ff18cc0d1fa55791daffc744d8c69ec272bc6af3

Update version in usage example

view details

Joel Gallant

commit sha bf09a730d44cb72f483dab04163dd75f2b9d1746

Merge pull request #154 from matthiasbeyer/patch-1 Update version in usage example

view details

push time in 14 days

PR merged mehcode/config-rs

Update version in usage example

Related to #153

+1 -1

0 comment

1 changed file

matthiasbeyer

pr closed time in 14 days

PullRequestReviewEvent

push eventmehcode/config-rs

Matthias Beyer

commit sha d1d8959804b372953db08a66488acbd10cafa26d

travis: Ensure format Signed-off-by: Matthias Beyer <mail@beyermatthias.de>

view details

Joel Gallant

commit sha f8445e5bfd5676eecb758f26465b42f82cb9d765

Merge pull request #156 from matthiasbeyer/ensure-format Ensure format

view details

push time in 14 days

PR merged mehcode/config-rs

Ensure format

Based on #155 , this PR makes travis enforce the format.

+167 -144

0 comment

18 changed files

matthiasbeyer

pr closed time in 14 days

push eventmehcode/config-rs

Matthias Beyer

commit sha 1eb140881b26328ed1b17615fee32427baafadf6

Run cargo-fmt Signed-off-by: Matthias Beyer <mail@beyermatthias.de>

view details

Joel Gallant

commit sha d9fc453c7b77bfbb7d0b0c8fb2be886b3c1508ff

Merge pull request #155 from matthiasbeyer/format Run cargo-fmt

view details

push time in 14 days

PR merged mehcode/config-rs

Run cargo-fmt
+163 -144

0 comment

17 changed files

matthiasbeyer

pr closed time in 14 days

PullRequestReviewEvent
PullRequestReviewEvent

PR closed typeorm/typeorm

Hotfix: entity cloning with new non-emurable properties can be closed?

I unfortunately don't have the testing setup on my machine at the moment, but making this fix in node_modules of the failing test (https://github.com/P4sca1/typeorm-problem) works as intended.

+2 -2

8 comments

2 changed files

joelgallant

pr closed time in 17 days

pull request commenttypeorm/typeorm

Hotfix: entity cloning with new non-emurable properties

I don't think so

joelgallant

comment created time in 17 days

startedrancher/rancher

started time in 18 days

startedRich-Harris/object-cull

started time in 19 days

startedDataDog/scipio

started time in 20 days

startedogham/exa

started time in 20 days

push eventjoelgallant/dotfiles

Joel Gallant

commit sha f31f1f0353aa2ee9781ac029e870532f4d7b6dc6

audio

view details

push time in 22 days

startedairbnb/visx

started time in 22 days

push eventjoelgallant/dotfiles

Joel Gallant

commit sha d9b7aa69d5427f6d78ef8055b637a4709509fea8

docker-compose PATH

view details

push time in 23 days

startedlensapp/lens

started time in 23 days

PullRequestReviewEvent

startedelsaland/elsa

started time in 25 days

startedrylev/squote

started time in 25 days

push eventjoelgallant/dotfiles

Joel Gallant

commit sha ac518c7291a5e245be5a363eebde9679c76c984a

tmux intsall

view details

push time in a month

push eventjoelgallant/dotfiles

Joel Gallant

commit sha 0eb1647734344e1c4f96685a2adf1df66d964c09

fix: grep quiet

view details

push time in a month

push eventjoelgallant/dotfiles

Joel Gallant

commit sha cc1d7d3cc8d1f8b5c8b31d8ff5a2c96ba4bab5db

source bashrc for redos

view details

push time in a month

push eventjoelgallant/dotfiles

Joel Gallant

commit sha b2b562c3033ec97e4431200579594bc03bc94544

setup_opt

view details

push time in a month

push eventjoelgallant/dotfiles

Joel Gallant

commit sha c8cd212bcf0a0e960947366183dc3a62670d1d96

xrandr

view details

push time in a month

push eventjoelgallant/dotfiles

Joel Gallant

commit sha 205e46a01e4d27b42be00a8909cb455a5536faae

arandr

view details

push time in a month

push eventjoelgallant/dotfiles

Joel Gallant

commit sha ead8f19f10f44eb81627029a73a04532f5a1d17a

go and elm

view details

push time in a month

push eventjoelgallant/dotfiles

Joel Gallant

commit sha 4320103c8428a7917dd38eaffa6b129760dfc678

swift

view details

push time in a month

push eventjoelgallant/dotfiles

Joel Gallant

commit sha 55c3956623a07d5a5ace2fa0d2daca3705f424d7

kotlin

view details

push time in a month

push eventjoelgallant/dotfiles

Joel Gallant

commit sha d2bd579e9f04372f310208d42ebbebf7530101d4

java openjdk

view details

push time in a month

push eventjoelgallant/dotfiles

Joel Gallant

commit sha a6ead69e6020456d8a79cd0b2cbf37547c486f46

spotify

view details

push time in a month

push eventjoelgallant/dotfiles

Joel Gallant

commit sha 5c2df68278cfaee22f72591ffd38aca836f56a19

nmapplet

view details

push time in a month

push eventjoelgallant/dotfiles

Joel Gallant

commit sha 54afa6517b0c2a3b34ad16fe8b717548fe43a50e

install volta components

view details

push time in a month

startedtypestack/routing-controllers

started time in a month

push eventjoelgallant/dotfiles

Joel Gallant

commit sha 3cdf4c6ada50bfc3f7c58b973d58586236422ad6

fish last

view details

push time in a month

push eventjoelgallant/dotfiles

Joel Gallant

commit sha 06e4a58f6922dfdb0f9634df11f70dc58303c3f8

remove rr

view details

push time in a month

push eventjoelgallant/dotfiles

Joel Gallant

commit sha cc397eb3c0a3282686a1a9ad00ed7f0c2727fb01

try volta setup

view details

push time in a month

push eventjoelgallant/dotfiles

Joel Gallant

commit sha eebd67390d38f460882a9d04a2f7e7991cffa5e7

temp

view details

push time in a month

push eventjoelgallant/dotfiles

Joel Gallant

commit sha 80758ab1508391be097def6a2aec7d75b8662da6

Update README.md

view details

push time in a month

startedgodaddy/terminus

started time in a month

delete branch joelgallant/dotfiles

delete branch : master

delete time in a month

delete branch joelgallant/dotfiles

delete branch : openbox

delete time in a month

delete branch joelgallant/dotfiles

delete branch : i3

delete time in a month

delete branch joelgallant/dotfiles

delete branch : desktop

delete time in a month

delete branch joelgallant/dotfiles

delete branch : laptop-work

delete time in a month

create barnchjoelgallant/dotfiles

branch : old

created branch time in a month

startedzesterer/flume

started time in a month

startedcli/cli

started time in a month

startedpheki/rudano

started time in a month

startedcssivision/awak

started time in a month

startedstjepang/polling

started time in a month

startedblitz-js/superjson

started time in a month

push eventmehcode/config-rs

rdkt13

commit sha 53b8bf74381dc292834a356e4a760755d64fc60e

Fix paths in tests expectations for all platforms

view details

rdkt13

commit sha 79f5254c3926431063d0b2d6ffbd8154984a22ef

Use `display` method on PathBuf in tests

view details

Joel Gallant

commit sha 6c51d3b6b2dbe49d1b40fd0f0326b73f16357f72

Merge pull request #151 from szarykott/win_tests Fix paths in tests expectations for all platforms

view details

push time in a month

PR merged mehcode/config-rs

Fix paths in tests expectations for all platforms

This is first thing I came across while trying to do some changes in code. I started tests and they failed due to different way paths are structured on Linux and on Windows, which is my development platform.

Here I did some changes so that expectations should work correctly on all the platforms.

+28 -11

0 comment

6 changed files

szarykott

pr closed time in a month

PullRequestReviewEvent

startedreact-hook-form/react-hook-form

started time in a month

startedziglang/zig

started time in a month

startedrails/rails

started time in a month

startedlaunchcodedev/fetch

started time in a month

push eventlaunchcodedev/mapper

Joel Gallant

commit sha 53349f6d7f23c453d7b0b6ae433151a4e6314786

chore: github url

view details

push time in a month

created taglaunchcodedev/fetch

tagv0.1.8

Wrapper for DOM fetch

created time in a month

push eventlaunchcodedev/fetch

Joel Gallant

commit sha ab96ab6abf762bac598a0c49799f0eb12b8ceabe

v0.1.8

view details

Joel Gallant

commit sha 7150ccc5fa223d2e36d6010c5b710e1b4b2b14f1

fix: removes node 8

view details

push time in a month

push eventlaunchcodedev/fetch

Joel Gallant

commit sha 3b4baa4fbc9d41f51b3f59da5c5544659133a283

chore: ci in github

view details

Joel Gallant

commit sha b740b24cd91bd42b3b2f04edf00d1d0118847b13

fix: applySerializationOptions with object

view details

push time in a month

create barnchlaunchcodedev/fetch

branch : master

created branch time in a month

created repositorylaunchcodedev/fetch

Wrapper for DOM fetch

created time in a month

startedLukasKalbertodt/bunt

started time in a month

startedKDAB/hotspot

started time in a month

startedsushiswap/sushiswap-frontend

started time in 2 months

startedcoredns/coredns

started time in 2 months

startedreact-spring/jotai

started time in 2 months

startedserde-rs/serde

started time in 2 months

startedkbrsh/moon

started time in 2 months

Pull request review commentmehcode/config-rs

Fix paths in tests expectations for all platforms

 fn test_error_parse() {     let mut c = Config::default();     let res = c.merge(File::new("tests/Settings-invalid", FileFormat::Toml)); +    let path : PathBuf = ["tests", "Settings-invalid.toml"].iter().collect();+     assert!(res.is_err());     assert_eq!(         res.unwrap_err().to_string(),-        "failed to parse datetime for key `error` at line 2 column 9 in tests/Settings-invalid.toml".to_string()+        format!("failed to parse datetime for key `error` at line 2 column 9 in {}", path.to_str().unwrap())

nit: paths have a .display() to avoid unwraps like this

szarykott

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentmehcode/config-rs

Adds 'try_parsing' option for Environment

 fn test_empty_value_is_ignored() {      env::remove_var("C_A_B"); }++#[test]+fn test_parse_numbers() {+    env::set_var("INT_VAL", "42");+    env::set_var("FLOAT_VAL", "42.2");+    env::set_var("BOOL_VAL", "true");++    let environment = Environment::new().try_parsing(true);++    let values = environment.collect().unwrap();++    assert_eq!(

Yeah, on the surface it looks like that for sure. Only reason I had to do this is that tests in the crate don't expose the int directly, at least as far as I understand it. Seems to be because the Value type exposed doesn't allow access to it's ValueKind. It's possible I could make a test that does deserialization with struct using serde instead?

Not that it's any consolation, but I have used this patch for projects of my own with success.

joelgallant

comment created time in 2 months

PullRequestReviewEvent

startedproject-oak/rust-verification-tools

started time in 2 months

startedbikeshaving/crank

started time in 2 months

issue commentmehcode/config-rs

Is the project maintained?

#111 is certainly relevant here

LukeMathWalker

comment created time in 2 months

issue commentmehcode/config-rs

Is the project maintained?

I'll start/have started looking through the backlog here for easy wins to start with. If there's some strategy or direction others want to take with this, I'd love to help.

LukeMathWalker

comment created time in 2 months

push eventmehcode/config-rs

Igor Gnatenko

commit sha 03849da99ce981f91ca8978ddd1a405da4c3967d

chore: Update float-cmp to 0.6

view details

Joel Gallant

commit sha 05f6d42512ed3adcb64da26d33fee7643ea5ed1b

Merge pull request #131 from ignatenkobrain/patch-2 chore: Update float-cmp to 0.6

view details

push time in 2 months

PullRequestReviewEvent

PR closed mehcode/config-rs

Rust idoms and clippy warnings

I didn't notice https://github.com/mehcode/config-rs/pull/134/files until now, so feel free to close this

+185 -202

1 comment

21 changed files

joelgallant

pr closed time in 2 months

more