profile
viewpoint

jkristell/infrared 17

Infrared remote control library for embedded Rust

jkristell/nucleo-f401re 9

Rust BSP crate for the STM Nucleo-F401RE development board

noeddl/ukebox 2

A ukulele chord finder in Rust

jkristell/atdf2svd 0

Converter from Atmel's atdf format to CMSIS SVD

jkristell/avr-device 0

Register access crate for AVR microcontrollers

jkristell/avr-hal 0

embedded-hal abstractions for AVR microcontrollers

release danielsaidi/KeyboardKit

3.2.0

released time in 20 minutes

push eventdanielsaidi/KeyboardKit

Daniel Saidi

commit sha b75d688ec4ad8d6d93459beeea5695d3847ceb18

Update demo dependencies

view details

Daniel Saidi

commit sha da8070351a9a68b6f955b185d566cbd1657fedd6

Bump to 3.2.0

view details

push time in 22 minutes

created tagdanielsaidi/KeyboardKit

tag3.2.0

KeyboardKit is a Swift library that helps you create iOS keyboard extensions.

created time in 22 minutes

push eventdanielsaidi/KeyboardKit

Daniel Saidi

commit sha 009f60d3927b340462bd8792523e0accb2f8c1f4

Improve the shift button appearance in the UIKit demo

view details

Daniel Saidi

commit sha 47d1c3c02cee9d0aee4b0531706a2989a59da938

Improve demo documentation

view details

Daniel Saidi

commit sha 293e9b640d3c83fbafdbd0c9ed3a3e62ba8a1b0f

Remove user defaults from standard context

view details

Daniel Saidi

commit sha e0354cce518fdfa755133cafa6adaf59ccae8899

Fix failing mock

view details

Daniel Saidi

commit sha 7d2f15c94a637d877a3634a31e7423d29d9d1705

Add new dimension properties to keyboard stack view component

view details

Daniel Saidi

commit sha 741e860a399b0018e1fa142f530346608107c65e

Apply calculated padding to demo button

view details

Daniel Saidi

commit sha 5652f39617f36200af817dd2e60182741bbac7e9

Move all inset logic to KeyboardButtonRowComponent

view details

Daniel Saidi

commit sha 8716079800a516cef63670953299c1fbdc984b8d

Make standard phone button height and padding for UIKit pixel perfect

view details

Daniel Saidi

commit sha b005323a1c2bad175e6869aedeeddb522f94d68f

Make standard pad button height and padding for UIKit pixel perfect

view details

Daniel Saidi

commit sha d227fbbc38eb2a783c14faf6df0c4ca34bd6cbe2

Improve UIKit emoji keyboard design

view details

Daniel Saidi

commit sha 9b3b1400b1f4180df7ecf81cd9a651fc96b70ede

Use callout font for system buttons

view details

Daniel Saidi

commit sha a526b43cd929f30144aaa4d2b34df75aff6c8dd8

Add new input sets

view details

Daniel Saidi

commit sha 14111d5feb65528d417241d826275577bf7c5851

Refactor action namespace and improve documentation

view details

Daniel Saidi

commit sha 0c04f043a5f9c3f66725b3bec922d7df2bdecef6

Add input set provider

view details

Daniel Saidi

commit sha 51fab2ca143a5e39bee9c16384fb84d94ae12e18

Add more input sets

view details

Daniel Saidi

commit sha 50be7226aeb242fe03e1b07c58bf6173d6c5c96f

Add input set provider to context

view details

Daniel Saidi

commit sha 7e77c2dc29bc5a519769e5de5b4319dcaaa6c8e0

Add a static input set provider

view details

Daniel Saidi

commit sha 72a382947825bf1b74ff35c3fab2494f9c3e1c59

Use new input set provider in UIKit demo

view details

Daniel Saidi

commit sha 3521bde0aa5625f163c4597bbea4f4a63d36720c

Use new input set provider in the SwiftUI demo

view details

Daniel Saidi

commit sha 800ddd1bb06161d62d1af0a7a260edddaba70664

Add readme for locales

view details

push time in 32 minutes

push eventdanielsaidi/KeyboardKit

Daniel Saidi

commit sha a7496b2b6f223b7684a9f33d80cea439df736254

Revert memory leak fix

view details

push time in 33 minutes

issue commentdanielsaidi/KeyboardKit

Possible Memory Leak On Keyboard Kit

I was hoping to find the leak and include it in 3.2, but I think it'll have to be in another version.

albilaga

comment created time in 34 minutes

issue commentdanielsaidi/KeyboardKit

Possible Memory Leak On Keyboard Kit

Ok, I have sat with this for an hour now and can reproduce the exakt behavior that @albilaga reports.

In UIKit, instruments point out DemoButton and RepeatingGestureRecognizer when I check for memory leaks. That doesn't mean that the gesture must be the one containing the leak, only that it's not released since the button it not released.

However, I cannot find the problem. I see no obvious missing weak selves or potential locks, except the gesture recognizer which refers to itself, but the delegate is weal.

In SwiftUI, the memory leak graph is a lot more noisy. I haven't been able to sit more with it, though.

albilaga

comment created time in 35 minutes

push eventdanielsaidi/KeyboardKit

Daniel Saidi

commit sha 94c3dfd389ca7ce3620770fe6e6a7df8b505d1b1

Make members private

view details

Daniel Saidi

commit sha 66b9c138495d56109f206a8998e28622b1c5d8e8

Try to fix memory leak

view details

push time in an hour

issue commentdanielsaidi/KeyboardKit

Landscape UI issue

I'll keep this issue around to keep the inset problems top of mind.

TonnyToobler

comment created time in an hour

IssuesEvent

issue closeddanielsaidi/KeyboardKit

SwiftUI keyboard should resize when keyboard type changes

Today, SwiftUI keyboards don't automatically change height if their keyboard type changes to a keyboard with another size than the current one. This makes the new keyboard adapt to the old height.

Instead, the SwiftUI setup should also setup the view controller to listen for changes in the keyboard type, and setup itself for the new keyboard.

closed time in an hour

danielsaidi

issue openedstm32-rs/stm32-rs

stm32f4::stm32f405::flash::cr is missing field variants

Enums like stm32f4::stm32f401::flash::cr::PSIZE_A are missing from the stm32f405 version

created time in an hour

issue openeddanielsaidi/KeyboardKit

SwiftUI keyboard should resize when keyboard type changes

Today, SwiftUI keyboards don't automatically change height if their keyboard type changes to a keyboard with another size than the current one. This makes the new keyboard adapt to the old height.

Instead, the SwiftUI setup should also setup the view controller to listen for changes in the keyboard type, and setup itself for the new keyboard.

created time in 2 hours

issue closeddanielsaidi/KeyboardKit

Make SwiftUI demo use new default height and insets

With the new UIKit height and inset adjustments, the SwiftUI app should use them too.

closed time in 2 hours

danielsaidi

issue closeddanielsaidi/KeyboardKit

Make SwiftUI iPad demo use correct button layout

The iPad keyboard in SwiftUI demo does not position the system buttons correctly. The correct layout has system buttons rightmost on all rows, but the demo uses the phone layout.

closed time in 2 hours

danielsaidi

push eventdanielsaidi/KeyboardKit

Daniel Saidi

commit sha 3f98bd0bd4df5fb6fa0561e479a778fcf1317cf4

Make SwiftUI demo look great

view details

push time in 2 hours

pull request commentRahix/avr-hal

Quickfix broken SPI config for atmega328pb

Hmm, not really a fan of this approach. I'd rather fix the macro directly, to emit differently named CS pin structs. Eg. change the invocation to look like

		avr_hal_generic::impl_spi! {
            pub struct Spi0 {
                peripheral: crate::pac::SPI0,
                pins: {
                    sclk: portb::PB5,
                    mosi: portb::PB3,
                    miso: portb::PB4,
                    cs: portb::PB2,
                }
            }

            pub struct ChipSelectPin0;
        }

and use that name in the macro.

fneddy

comment created time in 5 hours

PR opened seed-rs/seed

Have a working example with trunk

Closes issue #535.

Created an example that uses trunk instead of the cargo make setup.

Some questions... Is it worth making or replacing examples to use trunk?

Things that should still be done... Update documentation for users to use trunk if that is a direction that is chosen.

+245 -0

0 comment

7 changed files

pr created time in 5 hours

push eventdanielsaidi/KeyboardKit

Daniel Saidi

commit sha a7a8dd3f74ee87af5592787e94c385b80dc8a10a

Update SwiftUI demo to use style-less keyboard

view details

Daniel Saidi

commit sha 2421c143b4a42c0ad61132a2511adae9dc961716

Update SwiftUI demo to use new dimensions

view details

push time in 6 hours

pull request commentstm32-rs/stm32-rs

H7: CRC IDR allows 32-bit usage

I think removing the IDR from crc_basic and defining it separately per chip as 8-bit or 32-bit might work, I'll try that tomorrow or so.

AlyoshaVasilieva

comment created time in 7 hours

pull request commentstm32-rs/stm32-rs

H7: CRC IDR allows 32-bit usage

It looks like your modify is running first, and then the IDR write constraint from crc_basic.yaml is being added afterwards, resulting in two write constraints in the file (which is what the linter rejects). Not sure what the best way to fix that is. By the way, you can use 0xFFFFFFFF as the constant, it's a bit more obvious/easier to check.

AlyoshaVasilieva

comment created time in 7 hours

pull request commentstm32-rs/stm32-rs

H7: CRC IDR allows 32-bit usage

Apparently this fails the linting step, which I didn't realize existed. It builds successfully, though. Beyond splitting out the definition of IDR from crc_basic.yaml and manually setting it to 8-bit or 32-bit on each chip I'm not sure how to write this patch properly. Will attempt to figure it out.

AlyoshaVasilieva

comment created time in 7 hours

PR opened stm32-rs/stm32-rs

H7: CRC IDR allows 32-bit usage

The CRC peripheral's independent data register only allows 8 bits to be used on most chips. On all H7 chips (RM0399, RM0433, RM0455, RM0468) it allows all 32 bits to be used. As an example, RM0433 page 797.

H7 chips are not the only chips that have a 32-bit IDR, but I don't have any of the others: the G4 series, G0 series, L5 series, and the STM32F334. Probably others, I didn't check every reference manual. Since I can't test them at all I haven't included them here, but I'll add this patch to the G0/G4 chips if desired.

I can't determine any pattern for which chips support it, as chips with the advanced peripheral + configurable polynomials do not necessarily have a 32-bit IDR (eg F373).

Tested on an STM32H743VIT6.

+15 -0

0 comment

8 changed files

pr created time in 7 hours

issue commentdanielsaidi/KeyboardKit

Possible Memory Leak On Keyboard Kit

Thanks @fukuru - I really appreciate it!

Unfortunately, memory still seems to grow with ~1Mb every time I recreate the extension, so I guess it's still there.

I will aim to solve this in the next minor version.

albilaga

comment created time in 7 hours

push eventdanielsaidi/KeyboardKit

Daniel Saidi

commit sha a7f51a80a5dfbaad480cd203effae139a14cf8ec

Update SwiftUI demo to use the new system tools

view details

push time in 8 hours

pull request commentrust-embedded/cortex-m

Deprecate msp::write

I think we're good to merge this now. Could you add a changelog entry please?

jonas-schievink

comment created time in 8 hours

Pull request review commentrust-embedded/cortex-m

Deprecate msp::write

 pub fn read() -> u32 {  /// Writes `bits` to the CPU register #[inline]+#[deprecated = "calling this function invokes Undefined Behavior"]
#[deprecated = "calling this function invokes Undefined Behavior, consider asm::bootstrap as an alternative"]
jonas-schievink

comment created time in 8 hours

delete branch rust-embedded/cortex-m

delete branch : new-asm

delete time in 9 hours

more