profile
viewpoint
John Gozde jgoz @implydata Calgary, Canada

andreypopp/typescript-loader 83

[DEPRECATED] TypeScript Webpack Plugin

jgoz/crossroads-net 14

Crossroads I/O bindings for .NET and Mono

cbaxter/InfinityMQ 5

A .NET Message Transport on Steroids

jgoz/beeline 3

Attribute-based routing library for ASP.NET MVC.

jgoz/ClyphXActions 1

My custom user actions for ClyphX Pro

jgoz/dotfiles 1

My personal configuration files

jgoz/headjs 1

The only script in your <HEAD>

jgoz/libgit2sharp 1

.NET bindings for libgit2

jgoz/ast-types 0

Esprima-compatible implementation of the Mozilla JS Parser API

jgoz/CodeHub-Push 0

Push notification server built in Node.js for the iOS application CodeHub

issue openedtesting-library/jest-dom

Matchers (except toHaveTextContent) should support any Element

<!--

  • Please fill out this template with all the relevant information so we can understand what's going on and fix the issue. We appreciate bugs filed and PRs submitted!

  • Please make sure that you are familiar with and follow the Code of Conduct for this project (found in the CODE_OF_CONDUCT.md file).

We'll probably ask you to submit the fix (after giving some direction). If you've never done that before, that's great! Check this free short video tutorial to learn how: http://kcd.im/pull-request

-->

<!--

  • dom-testing-library version: (if applicable)
  • react-testing-library version: (if applicable) -->

Relevant code or config:

expect(svgElement).toBeVisible();

What happened:

<!-- Please provide the full error message/screenshots/anything --> received value must be an HTMLElement or an SVGElement.

Problem description:

<!-- Please describe why the current behavior is a problem --> Several Testing Libraries are having their TypeScript types updated to take Element rather than HTMLElement as arguments so other element types like SVGElement are allowed. However, Jest DOM performs runtime checks against HTMLElement and SVGElement, so that any other element type would fail.

Suggested solution:

<!-- It's ok if you don't have a suggested solution, but it really helps if you could do a little digging to come up with some suggestion of how to improve things. -->

We should update our typechecking to check instanceof Element for consistency with #306 and https://github.com/testing-library/react-testing-library/pull/833.

created time in 9 hours

pull request commenttesting-library/jest-dom

fix: check for any Node in toHaveTextContent

That's an issue with DOM Testing Library, not Jest DOM. However we may still want to do that for consistency and to prefer other issues with Jest DOM's types.

nickmccurdy

comment created time in 9 hours

push eventimplydata/druid-query-toolkit

Vadim Ogievetsky

commit sha 2c4b9c8846e5c17d2f5aada9f1876c1261c2ac50

0.10.4

view details

push time in 12 hours

created tagimplydata/druid-query-toolkit

tagv0.10.4

A collection of utilities for working with Druid queries

created time in 12 hours

push eventimplydata/druid-query-toolkit

Vadim Ogievetsky

commit sha e309dc3f4d4a7fb12a3a36ee82b09defb8647e19

fix ref quotes

view details

push time in 12 hours

push eventtesting-library/jest-dom

Matan Borenkraout

commit sha 2927c9526204c272602400d1efce752283bfaf95

ci: Add validate workflow instead of travis (#311) * ci: add validate workflow based on yo kcd-oss * chore: remove travis file * chore: force enabling colors for validate script * chore: use master branch * chore: update Code of Conduct email address Co-authored-by: Nick McCurdy <nick@nickmccurdy.com>

view details

push time in 2 days

delete branch testing-library/jest-dom

delete branch : pr/add-validate-workflow

delete time in 2 days

PR merged testing-library/jest-dom

Reviewers
ci: Add validate workflow instead of travis

<!-- Thanks for your interest in the project. Bugs filed and PRs submitted are appreciated!

Please make sure that you are familiar with and follow the Code of Conduct for this project (found in the CODE_OF_CONDUCT.md file).

Also, please make sure you're familiar with and follow the instructions in the contributing guidelines (found in the CONTRIBUTING.md file).

If you're new to contributing to open source projects, you might find this free video course helpful: http://kcd.im/pull-request

Please fill out the information below to expedite the review and (hopefully) merge of your pull request! -->

What:

Add validate workflow by using yo kcd-oss

Why:

Because travis no more

How:

using yo kcd-oss

Checklist:

<!-- Have you done all of these things? -->

<!-- add "N/A" to the end of each line that's irrelevant to your changes -->

<!-- to check an item, place an "x" in the box like so: "- [x] Documentation" -->

  • [ ] Documentation
  • [ ] Tests
  • [ ] Updated Type Definitions
  • [ ] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->

<!-- feel free to add additional comments --> I guess we can reduce the number of node versions in the metrics, but I kept it as is for now..

+214 -94

4 comments

6 changed files

MatanBobi

pr closed time in 2 days

Pull request review commenttesting-library/jest-dom

ci: Add validate workflow instead of travis

  ## Our Pledge -In the interest of fostering an open and welcoming environment, we as-contributors and maintainers pledge to making participation in our project and-our community a harassment-free experience for everyone, regardless of age, body-size, disability, ethnicity, gender identity and expression, level of-experience, nationality, personal appearance, race, religion, or sexual identity-and orientation.+We as members, contributors, and leaders pledge to make participation in our+community a harassment-free experience for everyone, regardless of age, body+size, visible or invisible disability, ethnicity, sex characteristics, gender+identity and expression, level of experience, education, socio-economic status,+nationality, personal appearance, race, religion, or sexual identity and+orientation.++We pledge to act and interact in ways that contribute to an open, welcoming,+diverse, inclusive, and healthy community.  ## Our Standards -Examples of behavior that contributes to creating a positive environment-include:+Examples of behavior that contributes to a positive environment for our+community include: -- Using welcoming and inclusive language-- Being respectful of differing viewpoints and experiences-- Gracefully accepting constructive criticism-- Focusing on what is best for the community-- Showing empathy towards other community members+- Demonstrating empathy and kindness toward other people+- Being respectful of differing opinions, viewpoints, and experiences+- Giving and gracefully accepting constructive feedback+- Accepting responsibility and apologizing to those affected by our mistakes,+  and learning from the experience+- Focusing on what is best not just for us as individuals, but for the overall+  community -Examples of unacceptable behavior by participants include:+Examples of unacceptable behavior include: -- The use of sexualized language or imagery and unwelcome sexual attention or-  advances-- Trolling, insulting/derogatory comments, and personal or political attacks+- The use of sexualized language or imagery, and sexual attention or advances of+  any kind+- Trolling, insulting or derogatory comments, and personal or political attacks - Public or private harassment-- Publishing others' private information, such as a physical or electronic-  address, without explicit permission+- Publishing others' private information, such as a physical or email address,+  without their explicit permission - Other conduct which could reasonably be considered inappropriate in a   professional setting -## Our Responsibilities+## Enforcement Responsibilities -Project maintainers are responsible for clarifying the standards of acceptable-behavior and are expected to take appropriate and fair corrective action in-response to any instances of unacceptable behavior.+Community leaders are responsible for clarifying and enforcing our standards of+acceptable behavior and will take appropriate and fair corrective action in+response to any behavior that they deem inappropriate, threatening, offensive,+or harmful. -Project maintainers have the right and responsibility to remove, edit, or reject+Community leaders have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are-not aligned to this Code of Conduct, or to ban temporarily or permanently any-contributor for other behaviors that they deem inappropriate, threatening,-offensive, or harmful.+not aligned to this Code of Conduct, and will communicate reasons for moderation+decisions when appropriate.  ## Scope -This Code of Conduct applies both within project spaces and in public spaces-when an individual is representing the project or its community. Examples of-representing a project or community include using an official project e-mail-address, posting via an official social media account, or acting as an appointed-representative at an online or offline event. Representation of a project may be-further defined and clarified by project maintainers.+This Code of Conduct applies within all community spaces, and also applies when+an individual is officially representing the community in public spaces.+Examples of representing our community include using an official e-mail address,+posting via an official social media account, or acting as an appointed+representative at an online or offline event.  ## Enforcement  Instances of abusive, harassing, or otherwise unacceptable behavior may be-reported by contacting the project team at kent+coc@doddsfamily.us. All-complaints will be reviewed and investigated and will result in a response that-is deemed necessary and appropriate to the circumstances. The project team is-obligated to maintain confidentiality with regard to the reporter of an-incident. Further details of specific enforcement policies may be posted-separately.+reported to the community leaders responsible for enforcement at+me+coc@kentcdodds.com. All complaints will be reviewed and investigated promptly

No, I imagine that if we got a report we could talk it over together in discord (private maintainer channel) or on GitHub and then one of us could continue the conversation when we decide what to do. I don't think anything more sophisticated is necessary because it's not something we'll need to do often.

MatanBobi

comment created time in 2 days

push eventtesting-library/jest-dom

Nick McCurdy

commit sha 8a566be45a37ced1e9e54a058ae5aa46445b8e95

chore: update Code of Conduct email address

view details

push time in 2 days

Pull request review commenttesting-library/jest-dom

ci: Add validate workflow instead of travis

  ## Our Pledge -In the interest of fostering an open and welcoming environment, we as-contributors and maintainers pledge to making participation in our project and-our community a harassment-free experience for everyone, regardless of age, body-size, disability, ethnicity, gender identity and expression, level of-experience, nationality, personal appearance, race, religion, or sexual identity-and orientation.+We as members, contributors, and leaders pledge to make participation in our+community a harassment-free experience for everyone, regardless of age, body+size, visible or invisible disability, ethnicity, sex characteristics, gender+identity and expression, level of experience, education, socio-economic status,+nationality, personal appearance, race, religion, or sexual identity and+orientation.++We pledge to act and interact in ways that contribute to an open, welcoming,+diverse, inclusive, and healthy community.  ## Our Standards -Examples of behavior that contributes to creating a positive environment-include:+Examples of behavior that contributes to a positive environment for our+community include: -- Using welcoming and inclusive language-- Being respectful of differing viewpoints and experiences-- Gracefully accepting constructive criticism-- Focusing on what is best for the community-- Showing empathy towards other community members+- Demonstrating empathy and kindness toward other people+- Being respectful of differing opinions, viewpoints, and experiences+- Giving and gracefully accepting constructive feedback+- Accepting responsibility and apologizing to those affected by our mistakes,+  and learning from the experience+- Focusing on what is best not just for us as individuals, but for the overall+  community -Examples of unacceptable behavior by participants include:+Examples of unacceptable behavior include: -- The use of sexualized language or imagery and unwelcome sexual attention or-  advances-- Trolling, insulting/derogatory comments, and personal or political attacks+- The use of sexualized language or imagery, and sexual attention or advances of+  any kind+- Trolling, insulting or derogatory comments, and personal or political attacks - Public or private harassment-- Publishing others' private information, such as a physical or electronic-  address, without explicit permission+- Publishing others' private information, such as a physical or email address,+  without their explicit permission - Other conduct which could reasonably be considered inappropriate in a   professional setting -## Our Responsibilities+## Enforcement Responsibilities -Project maintainers are responsible for clarifying the standards of acceptable-behavior and are expected to take appropriate and fair corrective action in-response to any instances of unacceptable behavior.+Community leaders are responsible for clarifying and enforcing our standards of+acceptable behavior and will take appropriate and fair corrective action in+response to any behavior that they deem inappropriate, threatening, offensive,+or harmful. -Project maintainers have the right and responsibility to remove, edit, or reject+Community leaders have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are-not aligned to this Code of Conduct, or to ban temporarily or permanently any-contributor for other behaviors that they deem inappropriate, threatening,-offensive, or harmful.+not aligned to this Code of Conduct, and will communicate reasons for moderation+decisions when appropriate.  ## Scope -This Code of Conduct applies both within project spaces and in public spaces-when an individual is representing the project or its community. Examples of-representing a project or community include using an official project e-mail-address, posting via an official social media account, or acting as an appointed-representative at an online or offline event. Representation of a project may be-further defined and clarified by project maintainers.+This Code of Conduct applies within all community spaces, and also applies when+an individual is officially representing the community in public spaces.+Examples of representing our community include using an official e-mail address,+posting via an official social media account, or acting as an appointed+representative at an online or offline event.  ## Enforcement  Instances of abusive, harassing, or otherwise unacceptable behavior may be-reported by contacting the project team at kent+coc@doddsfamily.us. All-complaints will be reviewed and investigated and will result in a response that-is deemed necessary and appropriate to the circumstances. The project team is-obligated to maintain confidentiality with regard to the reporter of an-incident. Further details of specific enforcement policies may be posted-separately.+reported to the community leaders responsible for enforcement at+me+coc@kentcdodds.com. All complaints will be reviewed and investigated promptly

Sure, you can forward that to me. Can we still reply all with this forwarding though?

MatanBobi

comment created time in 2 days

Pull request review commenttesting-library/jest-dom

ci: Add validate workflow instead of travis

  ## Our Pledge -In the interest of fostering an open and welcoming environment, we as-contributors and maintainers pledge to making participation in our project and-our community a harassment-free experience for everyone, regardless of age, body-size, disability, ethnicity, gender identity and expression, level of-experience, nationality, personal appearance, race, religion, or sexual identity-and orientation.+We as members, contributors, and leaders pledge to make participation in our+community a harassment-free experience for everyone, regardless of age, body+size, visible or invisible disability, ethnicity, sex characteristics, gender+identity and expression, level of experience, education, socio-economic status,+nationality, personal appearance, race, religion, or sexual identity and+orientation.++We pledge to act and interact in ways that contribute to an open, welcoming,+diverse, inclusive, and healthy community.  ## Our Standards -Examples of behavior that contributes to creating a positive environment-include:+Examples of behavior that contributes to a positive environment for our+community include: -- Using welcoming and inclusive language-- Being respectful of differing viewpoints and experiences-- Gracefully accepting constructive criticism-- Focusing on what is best for the community-- Showing empathy towards other community members+- Demonstrating empathy and kindness toward other people+- Being respectful of differing opinions, viewpoints, and experiences+- Giving and gracefully accepting constructive feedback+- Accepting responsibility and apologizing to those affected by our mistakes,+  and learning from the experience+- Focusing on what is best not just for us as individuals, but for the overall+  community -Examples of unacceptable behavior by participants include:+Examples of unacceptable behavior include: -- The use of sexualized language or imagery and unwelcome sexual attention or-  advances-- Trolling, insulting/derogatory comments, and personal or political attacks+- The use of sexualized language or imagery, and sexual attention or advances of+  any kind+- Trolling, insulting or derogatory comments, and personal or political attacks - Public or private harassment-- Publishing others' private information, such as a physical or electronic-  address, without explicit permission+- Publishing others' private information, such as a physical or email address,+  without their explicit permission - Other conduct which could reasonably be considered inappropriate in a   professional setting -## Our Responsibilities+## Enforcement Responsibilities -Project maintainers are responsible for clarifying the standards of acceptable-behavior and are expected to take appropriate and fair corrective action in-response to any instances of unacceptable behavior.+Community leaders are responsible for clarifying and enforcing our standards of+acceptable behavior and will take appropriate and fair corrective action in+response to any behavior that they deem inappropriate, threatening, offensive,+or harmful. -Project maintainers have the right and responsibility to remove, edit, or reject+Community leaders have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are-not aligned to this Code of Conduct, or to ban temporarily or permanently any-contributor for other behaviors that they deem inappropriate, threatening,-offensive, or harmful.+not aligned to this Code of Conduct, and will communicate reasons for moderation+decisions when appropriate.  ## Scope -This Code of Conduct applies both within project spaces and in public spaces-when an individual is representing the project or its community. Examples of-representing a project or community include using an official project e-mail-address, posting via an official social media account, or acting as an appointed-representative at an online or offline event. Representation of a project may be-further defined and clarified by project maintainers.+This Code of Conduct applies within all community spaces, and also applies when+an individual is officially representing the community in public spaces.+Examples of representing our community include using an official e-mail address,+posting via an official social media account, or acting as an appointed+representative at an online or offline event.  ## Enforcement  Instances of abusive, harassing, or otherwise unacceptable behavior may be-reported by contacting the project team at kent+coc@doddsfamily.us. All-complaints will be reviewed and investigated and will result in a response that-is deemed necessary and appropriate to the circumstances. The project team is-obligated to maintain confidentiality with regard to the reporter of an-incident. Further details of specific enforcement policies may be posted-separately.+reported to the community leaders responsible for enforcement at+me+coc@kentcdodds.com. All complaints will be reviewed and investigated promptly

We could use TestingLibraryOSS@gmail.com which everyone has access to. I've got that address forwarding to me and others can do the same. I know a lot of people wouldn't feel comfortable chatting a COC violation on a public place like discord.

MatanBobi

comment created time in 2 days

pull request commenttesting-library/jest-dom

ci: Add validate workflow instead of travis

We can merge this if you want. If Kent doesn't want Testing Library emails sent to him directly, he can forward anything important to us and we can discuss updating our Code of Conduct on Discord.

MatanBobi

comment created time in 3 days

issue commenttesting-library/jest-dom

Argument of type 'Element' is not assignable to parameter of type 'HTMLElement'.

They do have definitions: npmjs.com/package/@types/testing-library__jest-dom

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/testing-library__jest-dom/index.d.ts

Semigradsky

comment created time in 5 days

issue commenttesting-library/jest-dom

Argument of type 'Element' is not assignable to parameter of type 'HTMLElement'.

but jest-dom doesn't have any type definitions as far as I can see

Argh, I pasted the wrong link previously. They do have definitions: https://www.npmjs.com/package/@types/testing-library__jest-dom

Semigradsky

comment created time in 5 days

pull request commenttesting-library/jest-dom

ci: Add validate workflow instead of travis

Looks like it failed on snapshots that actually passed on my local env.. any ideas?

Fixed, we were missing the FORCE_COLOR environment variable from the Travis config.

Thanks @nickmccurdy! missed that..

MatanBobi

comment created time in 5 days

issue commenttesting-library/jest-dom

Argument of type 'Element' is not assignable to parameter of type 'HTMLElement'.

I read the issue description again and don't understand how this would mean a runtime error. The wording doesn't match the runtime errors, sounds like a type error and matches exactly what TypeScript's type-checker says right now.

I agree on this one, but jest-dom doesn't have any type definitions as far as I can see so I thought it's related to the types defined in testing-library-dom here: https://github.com/testing-library/dom-testing-library/blob/c6e7a83948ef0d1822c5df1980b133ceb7e70dca/types/queries.d.ts#L57

Semigradsky

comment created time in 5 days

pull request commenttesting-library/jest-dom

ci: Add validate workflow instead of travis

Looks like it failed on snapshots that actually passed on my local env.. any ideas?

Fixed, we were missing the FORCE_COLOR environment variable from the Travis config.

MatanBobi

comment created time in 5 days

push eventtesting-library/jest-dom

Nick McCurdy

commit sha f43e65a2a0b55913c48d3ccb7d32a018cf85573d

chore: use master branch

view details

push time in 5 days

pull request commenttesting-library/jest-dom

ci: Add validate workflow instead of travis

Codecov Report

Merging #311 (a66edca) into master (8298015) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #311    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           23        23            
  Lines          315       533   +218     
  Branches        72       194   +122     
==========================================
+ Hits           315       533   +218     
Impacted Files Coverage Δ
src/utils.js 100.00% <0.00%> (ø)
src/to-be-empty.js 100.00% <0.00%> (ø)
src/to-be-checked.js 100.00% <0.00%> (ø)
src/to-be-invalid.js 100.00% <0.00%> (ø)
src/to-be-visible.js 100.00% <0.00%> (ø)
src/to-have-class.js 100.00% <0.00%> (ø)
src/to-have-focus.js 100.00% <0.00%> (ø)
src/to-have-style.js 100.00% <0.00%> (ø)
src/to-have-value.js 100.00% <0.00%> (ø)
src/to-be-disabled.js 100.00% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8298015...a66edca. Read the comment docs.

MatanBobi

comment created time in 5 days

push eventtesting-library/jest-dom

Nick McCurdy

commit sha a66edca3309d796200136621fd40f45304aeabd9

chore: force enabling colors for validate script

view details

push time in 5 days

Pull request review commenttesting-library/jest-dom

ci: Add validate workflow instead of travis

+name: validate+on:+  push:+    branches:+      - '+([0-9])?(.{+([0-9]),x}).x'+      - 'main'+      - 'next'+      - 'next-major'+      - 'beta'+      - 'alpha'+      - '!all-contributors/**'+  pull_request: {}+jobs:+  main:+    # ignore all-contributors PRs+    if: ${{ !contains(github.head_ref, 'all-contributors') }}+    strategy:+      matrix:+        node: [10.14, 12, 14, 15]+    runs-on: ubuntu-latest+    steps:+      - name: ⬇️ Checkout repo+        uses: actions/checkout@v2++      - name: ⎔ Setup node+        uses: actions/setup-node@v1+        with:+          node-version: ${{ matrix.node }}++      - name: 📥 Download deps+        uses: bahmutov/npm-install@v1+        with:+          useLockFile: false++      - name: ▶️ Run validate script+        run: npm run validate++      - name: ⬆️ Upload coverage report+        uses: codecov/codecov-action@v1++  release:+    needs: main+    runs-on: ubuntu-latest+    if:+      ${{ github.repository == 'testing-library/jest-dom' &&+      contains('refs/heads/main,refs/heads/beta,refs/heads/next,refs/heads/alpha',
      contains('refs/heads/master,refs/heads/beta,refs/heads/next,refs/heads/alpha',
MatanBobi

comment created time in 5 days

Pull request review commenttesting-library/jest-dom

ci: Add validate workflow instead of travis

  ## Our Pledge -In the interest of fostering an open and welcoming environment, we as-contributors and maintainers pledge to making participation in our project and-our community a harassment-free experience for everyone, regardless of age, body-size, disability, ethnicity, gender identity and expression, level of-experience, nationality, personal appearance, race, religion, or sexual identity-and orientation.+We as members, contributors, and leaders pledge to make participation in our+community a harassment-free experience for everyone, regardless of age, body+size, visible or invisible disability, ethnicity, sex characteristics, gender+identity and expression, level of experience, education, socio-economic status,+nationality, personal appearance, race, religion, or sexual identity and+orientation.++We pledge to act and interact in ways that contribute to an open, welcoming,+diverse, inclusive, and healthy community.  ## Our Standards -Examples of behavior that contributes to creating a positive environment-include:+Examples of behavior that contributes to a positive environment for our+community include: -- Using welcoming and inclusive language-- Being respectful of differing viewpoints and experiences-- Gracefully accepting constructive criticism-- Focusing on what is best for the community-- Showing empathy towards other community members+- Demonstrating empathy and kindness toward other people+- Being respectful of differing opinions, viewpoints, and experiences+- Giving and gracefully accepting constructive feedback+- Accepting responsibility and apologizing to those affected by our mistakes,+  and learning from the experience+- Focusing on what is best not just for us as individuals, but for the overall+  community -Examples of unacceptable behavior by participants include:+Examples of unacceptable behavior include: -- The use of sexualized language or imagery and unwelcome sexual attention or-  advances-- Trolling, insulting/derogatory comments, and personal or political attacks+- The use of sexualized language or imagery, and sexual attention or advances of+  any kind+- Trolling, insulting or derogatory comments, and personal or political attacks - Public or private harassment-- Publishing others' private information, such as a physical or electronic-  address, without explicit permission+- Publishing others' private information, such as a physical or email address,+  without their explicit permission - Other conduct which could reasonably be considered inappropriate in a   professional setting -## Our Responsibilities+## Enforcement Responsibilities -Project maintainers are responsible for clarifying the standards of acceptable-behavior and are expected to take appropriate and fair corrective action in-response to any instances of unacceptable behavior.+Community leaders are responsible for clarifying and enforcing our standards of+acceptable behavior and will take appropriate and fair corrective action in+response to any behavior that they deem inappropriate, threatening, offensive,+or harmful. -Project maintainers have the right and responsibility to remove, edit, or reject+Community leaders have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are-not aligned to this Code of Conduct, or to ban temporarily or permanently any-contributor for other behaviors that they deem inappropriate, threatening,-offensive, or harmful.+not aligned to this Code of Conduct, and will communicate reasons for moderation+decisions when appropriate.  ## Scope -This Code of Conduct applies both within project spaces and in public spaces-when an individual is representing the project or its community. Examples of-representing a project or community include using an official project e-mail-address, posting via an official social media account, or acting as an appointed-representative at an online or offline event. Representation of a project may be-further defined and clarified by project maintainers.+This Code of Conduct applies within all community spaces, and also applies when+an individual is officially representing the community in public spaces.+Examples of representing our community include using an official e-mail address,+posting via an official social media account, or acting as an appointed+representative at an online or offline event.  ## Enforcement  Instances of abusive, harassing, or otherwise unacceptable behavior may be-reported by contacting the project team at kent+coc@doddsfamily.us. All-complaints will be reviewed and investigated and will result in a response that-is deemed necessary and appropriate to the circumstances. The project team is-obligated to maintain confidentiality with regard to the reporter of an-incident. Further details of specific enforcement policies may be posted-separately.+reported to the community leaders responsible for enforcement at+me+coc@kentcdodds.com. All complaints will be reviewed and investigated promptly

@kentcdodds Do you want Testing Library moderation issues to be handled via your email or should we have a contact method for all community moderators (such as a shared email account, a form on Netlify, or a channel on Discord)?

MatanBobi

comment created time in 5 days

Pull request review commenttesting-library/jest-dom

ci: Add validate workflow instead of travis

+name: validate+on:+  push:+    branches:+      - '+([0-9])?(.{+([0-9]),x}).x'+      - 'main'
      - 'master'
MatanBobi

comment created time in 5 days

Pull request review commenttesting-library/jest-dom

ci: Add validate workflow instead of travis

+name: validate+on:+  push:+    branches:+      - '+([0-9])?(.{+([0-9]),x}).x'+      - 'main'+      - 'next'+      - 'next-major'+      - 'beta'+      - 'alpha'+      - '!all-contributors/**'+  pull_request: {}+jobs:+  main:+    # ignore all-contributors PRs+    if: ${{ !contains(github.head_ref, 'all-contributors') }}+    strategy:+      matrix:+        node: [10.14, 12, 14, 15]+    runs-on: ubuntu-latest+    steps:+      - name: ⬇️ Checkout repo+        uses: actions/checkout@v2++      - name: ⎔ Setup node+        uses: actions/setup-node@v1+        with:+          node-version: ${{ matrix.node }}++      - name: 📥 Download deps+        uses: bahmutov/npm-install@v1+        with:+          useLockFile: false++      - name: ▶️ Run validate script+        run: npm run validate++      - name: ⬆️ Upload coverage report+        uses: codecov/codecov-action@v1++  release:+    needs: main+    runs-on: ubuntu-latest+    if:+      ${{ github.repository == 'testing-library/jest-dom' &&+      contains('refs/heads/main,refs/heads/beta,refs/heads/next,refs/heads/alpha',+      github.ref) && github.event_name == 'push' }}+    steps:+      - name: ⬇️ Checkout repo+        uses: actions/checkout@v2++      - name: ⎔ Setup node+        uses: actions/setup-node@v1+        with:+          node-version: 14++      - name: 📥 Download deps+        uses: bahmutov/npm-install@v1+        with:+          useLockFile: false++      - name: 🏗 Run build script+        run: npm run build++      - name: 🚀 Release+        uses: cycjimmy/semantic-release-action@v2+        with:+          semantic_version: 17+          branches: |+            [+              '+([0-9])?(.{+([0-9]),x}).x',+              'main',
              'master',
MatanBobi

comment created time in 5 days

pull request commenttesting-library/jest-dom

ci: Add validate workflow instead of travis

Is this perhaps disabling coloring because it's in a test environment (but the tests assert that the output is colored)?

MatanBobi

comment created time in 5 days

issue commenttesting-library/jest-dom

Argument of type 'Element' is not assignable to parameter of type 'HTMLElement'.

I read the issue description again and don't understand how this would mean a runtime error. The wording doesn't match the runtime errors, sounds like a type error and matches exactly what TypeScript's type-checker says right now.

Semigradsky

comment created time in 5 days

pull request commenttesting-library/jest-dom

fix: check for any Node in toHaveTextContent

#312 reveals that this may not be the only custom matcher that has to allow any node and not HTML elements. It may be worth checking all our matchers to see which other ones make sense to have this change done. Although a quick look at our list of custom matchers makes me think these may be the only two exceptions, but I may be wrong.

nickmccurdy

comment created time in 5 days

issue commenttesting-library/jest-dom

Argument of type 'Element' is not assignable to parameter of type 'HTMLElement'.

I took the liberty to transfer this issue to jest-dom where it belongs. Seems that this needs a fix similar to that in #307.

Semigradsky

comment created time in 5 days

issue openedtesting-library/jest-dom

Argument of type 'Element' is not assignable to parameter of type 'HTMLElement'.

  • @testing-library/react version: 11.2.2

Relevant code or config:

	const { container } = render( // container is `Element` here
		<MyComponent/>,
	)

	expect(getByText(container, someText)).toBeInTheDocument() // Error: Argument of type 'Element' is not assignable to parameter of type 'HTMLElement'.
	expect(getByTestId(container, 'test-id')).toBeInTheDocument() // Error: Argument of type 'Element' is not assignable to parameter of type 'HTMLElement'.

Problem description:

After testing-library/react-testing-library#833 I get type errors because container no more HTMLElement.

container as HTMLElement doesn't seem like a good solution.

created time in 5 days

more