profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/jeffret-b/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Jeff Thompson jeffret-b BillGO Fort Collins, CO Senior software engineer at BillGO

jeffret-b/acceptance-test-harness 0

Acceptance tests cases for Jenkins and its plug-ins based on selenium and docker.

jeffret-b/access-modifier 0

Enforce access restrictions to deprecated code

jeffret-b/active-directory-plugin 0

Jenkins active-directory plugin

jeffret-b/ant 0

Apache Ant is a Java-based build tool.

jeffret-b/apache-httpcomponents-client-4-api-plugin 0

Apache HttpClient 4.x API Plugin for Jenkins

jeffret-b/args4j 0

args4j

jeffret-b/artifact-manager-s3-plugin 0

Artifact manager implementation for Amazon S3

jeffret-b/audit-log-plugin 0

Audit logging plugin for Jenkins based on Apache Log4j Audit

pull request commentjenkinsci/remoting

Logging should be of `Request` which has a `toString`, not some anonymous `Runnable`

We may merge it in 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process

jglick

comment created time in 2 days

PR opened jenkinsci/remoting

Logging should be of `Request` which has a `toString`, not some anonymous `Runnable`

Fixes log messages which failed to convey useful information. Also see #274.

+3 -2

0 comment

1 changed file

pr created time in 2 days

PR opened jenkinsci/remoting

Bump commons-io from 2.9.0 to 2.10.0

Bumps commons-io from 2.9.0 to 2.10.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+1 -1

0 comment

1 changed file

pr created time in 11 days

create barnchjenkinsci/remoting

branch : dependabot/maven/bc-version-1.69

created branch time in 15 days

PR opened jenkinsci/remoting

Bump bc-version from 1.68 to 1.69

Bumps bc-version from 1.68 to 1.69. Updates bcprov-jdk15on from 1.68 to 1.69 <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/bcgit/bc-java/blob/master/docs/releasenotes.html">bcprov-jdk15on's changelog</a>.</em></p> <blockquote> <!-- raw HTML omitted --> <!-- raw HTML omitted --> <!-- raw HTML omitted --> <p><!-- raw HTML omitted --><!-- raw HTML omitted -->2.1.1 Version<!-- raw HTML omitted --><!-- raw HTML omitted --> Release: 1.70<!-- raw HTML omitted --> Date:      TBD</p> <!-- raw HTML omitted --> <p><!-- raw HTML omitted --><!-- raw HTML omitted -->2.2.1 Version<!-- raw HTML omitted --><!-- raw HTML omitted --> Release: 1.69<!-- raw HTML omitted --> Date:      2021, June 7th.</p> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/bcgit/bc-java/commits">compare view</a></li> </ul> </details> <br />

Updates bcpkix-jdk15on from 1.68 to 1.69 <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/bcgit/bc-java/blob/master/docs/releasenotes.html">bcpkix-jdk15on's changelog</a>.</em></p> <blockquote> <!-- raw HTML omitted --> <!-- raw HTML omitted --> <!-- raw HTML omitted --> <p><!-- raw HTML omitted --><!-- raw HTML omitted -->2.1.1 Version<!-- raw HTML omitted --><!-- raw HTML omitted --> Release: 1.70<!-- raw HTML omitted --> Date:      TBD</p> <!-- raw HTML omitted --> <p><!-- raw HTML omitted --><!-- raw HTML omitted -->2.2.1 Version<!-- raw HTML omitted --><!-- raw HTML omitted --> Release: 1.69<!-- raw HTML omitted --> Date:      2021, June 7th.</p> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/bcgit/bc-java/commits">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+1 -1

0 comment

1 changed file

pr created time in 15 days

delete branch jenkinsci/remoting

delete branch : dependabot/maven/org.jenkins-ci-jenkins-1.64

delete time in 15 days

delete branch jenkinsci/remoting

delete branch : dependabot/maven/commons-io-commons-io-2.9.0

delete time in 15 days

delete branch jenkinsci/remoting

delete branch : dependabot/maven/org.jenkins-ci-jenkins-1.64

delete time in 21 days

pull request commentjenkinsci/remoting

Bump jenkins from 1.63 to 1.64

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

dependabot[bot]

comment created time in 21 days

push eventjenkinsci/remoting

Steve Arch

commit sha 0d080a5ac3349b2780aae4fff9049ec61caa8e75

feat: custom websocket headers Add the -webSocketHeaders flag to add additional custom headers to the websocket request. This can be useful when connecting to a reverse proxy that requires additional headers.

view details

Jesse Glick

commit sha c022fbb96460d034206ba2198097c56369137a47

Define `hudsonUrl` in WebSocket mode

view details

Steve Arch

commit sha 8f98ede8df44bc89671ce3144e7ad9f0ee1d6114

chore: add javadoc for setWebsocketHeaders

view details

Oleg Nenashev

commit sha e9136d8a44fdaa1fc7b07cddb20962c9954c54f4

Merge pull request #458 from agentgonzo/websocket-headers Allow setting of custom websocket headers

view details

Oleg Nenashev

commit sha 20e49948a63cd36ef4a20482575e123bc5f67635

Merge pull request #454 from jglick/hudsonUrl Define `hudsonUrl` in WebSocket mode to fix agent installers

view details

Jenkins Release Bot

commit sha 6ddebb0283633bcf1d037307433f4dd3d75d2d7e

[maven-release-plugin] prepare release remoting-4.9

view details

Jenkins Release Bot

commit sha 83d16d8a9157e00187fca9e8c67fa340b303f9c4

[maven-release-plugin] prepare for next development iteration

view details

dependabot[bot]

commit sha aae61ea7a3d122395f2dd45ddcd75025e89d9656

Bump commons-io from 2.8.0 to 2.9.0 Bumps commons-io from 2.8.0 to 2.9.0. Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 21 days

delete branch jenkinsci/remoting

delete branch : dependabot/maven/commons-io-commons-io-2.9.0

delete time in 21 days

pull request commentjenkinsci/remoting

Bump commons-io from 2.8.0 to 2.9.0

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

dependabot[bot]

comment created time in 21 days

PR opened jenkinsci/remoting

Bump jenkins from 1.63 to 1.64

Bumps jenkins from 1.63 to 1.64. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/jenkinsci/pom/commit/ec4cd0028654ff9ed069fb2952fa8bf6a2516fa3"><code>ec4cd00</code></a> [maven-release-plugin] prepare release jenkins-1.64</li> <li><a href="https://github.com/jenkinsci/pom/commit/cfd64703aa8d147ed03180851bf0e908073c2d67"><code>cfd6470</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/jenkinsci/pom/issues/171">#171</a> from basil/parameters</li> <li><a href="https://github.com/jenkinsci/pom/commit/22a45890b65e7b9cf51e50cc930edbfe7b277c69"><code>22a4589</code></a> Generate metadata for reflection on method parameters</li> <li><a href="https://github.com/jenkinsci/pom/commit/35b1f15e360219bd5dd789f25055b6e3c6c37031"><code>35b1f15</code></a> Bump maven-javadoc-plugin from 3.2.0 to 3.3.0</li> <li><a href="https://github.com/jenkinsci/pom/commit/b6ab99e1125edb3bd86bc7b8cd3985e7e79343c8"><code>b6ab99e</code></a> Bump maven-gpg-plugin from 1.6 to 3.0.1</li> <li><a href="https://github.com/jenkinsci/pom/commit/11b57c57694649605801e024f8fff3426721ca16"><code>11b57c5</code></a> Bump maven-project-info-reports-plugin from 3.1.1 to 3.1.2</li> <li><a href="https://github.com/jenkinsci/pom/commit/9ce2547cf42a7a9e10ff9b2f7915ea9369a28449"><code>9ce2547</code></a> Bump maven-jxr-plugin from 3.0.0 to 3.1.1</li> <li><a href="https://github.com/jenkinsci/pom/commit/f920b7705eb1d1804cf364d9912c5d0db936aff3"><code>f920b77</code></a> Bump spotbugs-maven-plugin from 4.2.2 to 4.2.3</li> <li><a href="https://github.com/jenkinsci/pom/commit/e5a567f2cfd81552ad493eebe0e962fee0c27642"><code>e5a567f</code></a> Bump spotbugs-annotations from 4.2.2 to 4.2.3</li> <li><a href="https://github.com/jenkinsci/pom/commit/1dbf34b80b32c15ddb5e7f5e370126184b7b4c32"><code>1dbf34b</code></a> Bump spotbugs-maven-plugin from 4.2.0 to 4.2.2</li> <li>Additional commits viewable in <a href="https://github.com/jenkinsci/pom/compare/jenkins-1.63...jenkins-1.64">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+1 -1

0 comment

1 changed file

pr created time in 24 days

push eventjenkinsci/remoting

Jenkins Release Bot

commit sha 6ddebb0283633bcf1d037307433f4dd3d75d2d7e

[maven-release-plugin] prepare release remoting-4.9

view details

Jenkins Release Bot

commit sha 83d16d8a9157e00187fca9e8c67fa340b303f9c4

[maven-release-plugin] prepare for next development iteration

view details

push time in a month

created tagjenkinsci/remoting

tagremoting-4.9

Jenkins Remoting module

created time in a month

push eventjenkinsci/remoting

Jesse Glick

commit sha c022fbb96460d034206ba2198097c56369137a47

Define `hudsonUrl` in WebSocket mode

view details

Oleg Nenashev

commit sha 20e49948a63cd36ef4a20482575e123bc5f67635

Merge pull request #454 from jglick/hudsonUrl Define `hudsonUrl` in WebSocket mode to fix agent installers

view details

push time in a month

PR merged jenkinsci/remoting

Define `hudsonUrl` in WebSocket mode to fix agent installers bug ready-to-merge

I noticed in CloudBees CI trying to launch a shared agent in WebSocket mode from the Java Web Start button an error indicating that the equivalent of https://github.com/jenkinsci/slave-installer-module/blob/8ab32a0616d147adef0d27fb51a359796e069eeb/src/main/java/org/jenkinsci/modules/slave_installer/impl/InstallerGui.java#L78 was throwing an NPE, despite the Jenkins root URL being configured. I could not reproduce a similar stack trace using an OSS agent connection, though the installer menu was not created either, so maybe the exception was just swallowed somewhere, or printed to the agent log which I forgot to check. Anyway, it seems clear from code that this getHudsonUrl method would have worked in TCP but not WebSocket mode.

Also cleaning up a trailing slash check introduced in #391.

Tested in context by building Jenkins core with this, then building CBCI operations center & connected controller with that, running both, hooking them up, and going through two scenarios:

  • static agent on the CC
  • shared agent on the OC

In both cases, used the JWS launch button and got a File from the agent installer (systemd in my case) as expected.

+19 -7

1 comment

2 changed files

jglick

pr closed time in a month

push eventjenkinsci/remoting

Steve Arch

commit sha 0d080a5ac3349b2780aae4fff9049ec61caa8e75

feat: custom websocket headers Add the -webSocketHeaders flag to add additional custom headers to the websocket request. This can be useful when connecting to a reverse proxy that requires additional headers.

view details

Steve Arch

commit sha 8f98ede8df44bc89671ce3144e7ad9f0ee1d6114

chore: add javadoc for setWebsocketHeaders

view details

Oleg Nenashev

commit sha e9136d8a44fdaa1fc7b07cddb20962c9954c54f4

Merge pull request #458 from agentgonzo/websocket-headers Allow setting of custom websocket headers

view details

push time in a month

PR merged jenkinsci/remoting

Allow setting of custom websocket headers enhancement ready-to-merge

Add the -websocketHeader flag to add additional custom headers to the connection request.

These additional headers are then used when connecting to jenkins via websockets.

Use-case: You have a reverse proxy in front of jenkins that requires custom headers to authenticate/route correctly.

Supercedes #455

<!-- Please describe your pull request here. -->

  • [x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • [x] Ensure that the pull request title represents the desired changelog entry
  • [x] Please describe what you did
  • [x] Link to relevant issues in GitHub or Jira
  • [x] Link to relevant pull requests, esp. upstream and downstream changes
  • [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

<!-- Put an x into the [ ] to show you have filled the information -->

+24 -0

9 comments

2 changed files

agentgonzo

pr closed time in a month

PR opened jenkinsci/remoting

Bump commons-io from 2.8.0 to 2.9.0

Bumps commons-io from 2.8.0 to 2.9.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+1 -1

0 comment

1 changed file

pr created time in a month

pull request commentjenkinsci/remoting

Allow setting of custom websocket headers

I can also confirm from manual testing that the headers get added to the websocket connection and it works as expected.

agentgonzo

comment created time in a month

pull request commentjenkinsci/remoting

Allow setting of custom websocket headers

Great, thanks @abayer. Definitely worth getting a green build before merging.

agentgonzo

comment created time in a month

pull request commentjenkinsci/remoting

Allow setting of custom websocket headers

(I also reran the build and that worked, so woo)

agentgonzo

comment created time in a month

pull request commentjenkinsci/remoting

Allow setting of custom websocket headers

I've tested this manually and it works - the headers get added to the websocket connection properly.

agentgonzo

comment created time in a month

pull request commentjenkinsci/remoting

[JENKINS-37566] - Always run setAccessible and classloader constructors in the privileged blocks

No objections

On Wed, May 19, 2021, 03:00 'Jeff Thompson' via engineering-code-reviews < ***@***.***> wrote:

@oleg-nenashev https://github.com/oleg-nenashev , I'm going to close this, based on the various comments and how outdated it is. If you still want to do something with it you can reopen it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jenkinsci/remoting/pull/118#issuecomment-843667080, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQGUVHNQXNK3GDPNAPT2ELTOMESPANCNFSM4CSF7DLA .

-- You received this message because you are subscribed to the Google Groups "engineering-code-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to @***. To view this discussion on the web visit https://groups.google.com/a/cloudbees.com/d/msgid/engineering-code-reviews/jenkinsci/remoting/pull/118/c843667080%40github.com https://groups.google.com/a/cloudbees.com/d/msgid/engineering-code-reviews/jenkinsci/remoting/pull/118/c843667080%40github.com?utm_medium=email&utm_source=footer .

oleg-nenashev

comment created time in a month

pull request commentjenkinsci/remoting

Allow setting of custom websocket headers

Right. Let's wait for the infra to repair itself first.

agentgonzo

comment created time in a month

pull request commentjenkinsci/remoting

Allow setting of custom websocket headers

That looks like an infra issue of some sort. It's a maven error.

agentgonzo

comment created time in a month