profile
viewpoint
Sheng Chen jdneo @Microsoft Shanghai

issue commentjumattos/lsif-util

Improve the way to use this tool

@arjun27 Yes, that's exactly what I'm thinking about. Thanks!

jdneo

comment created time in 3 hours

issue commentjdneo/vscode-leetcode

ico on side bar disappeared after vscode updated

Have you tried this? https://github.com/jdneo/vscode-leetcode/wiki/%E7%96%91%E9%9A%BE%E8%A7%A3%E7%AD%94#thinking-%E6%8F%90%E7%A4%BA%E9%94%99%E8%AF%AF-command-leetcodexxx-not-found

Wanger-SJTU

comment created time in 15 hours

issue commentjdneo/vscode-leetcode

ico on side bar disappeared after vscode updated

Could not repro on my side image

Have you tried restarting your VS Code?

Wanger-SJTU

comment created time in 19 hours

issue closedjdneo/vscode-leetcode

Error: Cannot find module 'underscore'

运行报错,查看不了题目,提示当前没有课提供的视图数据的提供来源注册

closed time in 20 hours

chenyuhu

issue commentjdneo/vscode-leetcode

Error: Cannot find module 'underscore'

Close the issue since it seems having been resolved.

chenyuhu

comment created time in 20 hours

issue commentjdneo/vscode-leetcode

Error: Cannot find module 'underscore'

@zhouchenzc0824 Could you please try to remove the entire directory: /Users/<your user name>/.vscode/extensions/shengchen.vscode-leetcode-0.xx.x/ and reinstall the extension again?

Assume you are windows user

chenyuhu

comment created time in 21 hours

delete branch microsoft/vscode-java-test

delete branch : cs/0.17.0

delete time in a day

push eventmicrosoft/vscode-java-test

Sheng Chen

commit sha c0ecc6591e82ef493b75366e78c32eff8a64cc00

chore: Prepare for 0.17.0 (#703)

view details

push time in a day

PR merged microsoft/vscode-java-test

Reviewers
chore: Prepare for 0.17.0

This is a draft PR

+18 -8

0 comment

8 changed files

jdneo

pr closed time in a day

push eventmicrosoft/vscode-java-test

Sheng Chen

commit sha 245c09b59bdbc1f9f6482e64cf9693f1e085839a

Add release date

view details

push time in a day

push eventmicrosoft/vscode-java-test

Sheng Chen

commit sha e375778b664dd9c34935cdc7189bf7ff2dc29218

docs: Add the build resource step in contributing page (#705)

view details

Sheng Chen

commit sha 9c4c5f25d0ace6b71dcdfd444c5a26475e0e9363

fix: Update package-lock.json for vulnerability issues (#704)

view details

Sheng Chen

commit sha 7ff7a3243c616634d218f79aa231810412a2fe7d

fix: Parse the project in path correctly (#708)

view details

Sheng Chen

commit sha 885e15f74a7af00ae568fac52f721819c3061b79

Merge branch 'master' into cs/0.17.0

view details

push time in a day

delete branch microsoft/vscode-java-test

delete branch : cs/path-issue

delete time in a day

push eventmicrosoft/vscode-java-test

Sheng Chen

commit sha 7ff7a3243c616634d218f79aa231810412a2fe7d

fix: Parse the project in path correctly (#708)

view details

push time in a day

issue closedmicrosoft/vscode-java-test

Unable to setup in development mode

I am not able to setup Codelens and the Test explorer view in debug extension mode.

57842370-f56a9900-77e9-11e9-8d0e-3754c28d11d6

To Reproduce:

  1. follow instruction for development setup on Contributing page (follow instruction only till step 5)
  2. create a new project with spring initializr
  3. import this project inside the Extension Development VSCode (after launch the task)

Note: I do not have any other dependency installed locally (ex: eclipse, etc) unless install by the project internally)

closed time in a day

rohinwork

issue commentmicrosoft/java-debug

Cannot stop the debugging process automatically

This can be reproduced in attach mode

bsaby

comment created time in a day

issue commentmicrosoft/vscode-java-test

Unable to setup in development mode

Nothing special. Just:

  • npm install
  • npm run build-plugin
  • vsce package
rohinwork

comment created time in a day

issue closedmicrosoft/vscode-java-test

No stacktrace/message in code-server

When you run a test case with vscode-java-test within code-server the message and stacktrace does not show up for the test case. However the report says wether the test case passed/failed. (Gradle with JUnit5)

Note: To install vscode-java-test in code-server; the regular installation through GUI seems to broken; you will have to follow instructions from this dockerfile to download the java pack manually before opening code-server.

closed time in a day

rohinwork

issue commentmicrosoft/vscode-java-test

No stacktrace/message in code-server

Closing this one and watch on the upstream issue.

rohinwork

comment created time in a day

PR opened microsoft/vscode-java-test

Reviewers
fix: Parse the project in path correctly

Fix #706

+19 -3

0 comment

2 changed files

pr created time in a day

Pull request review commentmicrosoft/vscode-maven

Allow to specify whether to auto-update EffectivePOM

 export class MavenProject implements ITreeItem {     }      public async calculateEffectivePom(force?: boolean): Promise<string | undefined> {-        if (!force && this._effectivePom.raw) {+        if (!force && this._effectivePom.upToDate) {

No need to check null for raw?

Eskibear

comment created time in a day

issue closedjdneo/vscode-leetcode

装了node.js 还是会报leetcode.xxx 错误

🐛 Bug Report

装了node.js 还是会报leetcode.xxx 错误

To Reproduce

我按照安装文档里的要求装了vscode 1.33.1 和 node.js 10.15.3 ,但是仍然会出现leetcode.xxx错误,我仔细查看了PATH和leet设置里的node.js路径,确信都无误。看了之前的issue,发现装上leetcode 0.12.0版本就不会出现这个情况。但是又会经常出现 Failed to submit the solution. Please open the output channel for details. 这个错误。

Your Environment

  • os: win10
  • extension settings:按照文档要求设定
  • nodejs version: 10.15.3
  • vscode version: 1.33.1
  • extension version: 0.14.2

closed time in 2 days

seanxuu

delete branch jdneo/vscode-leetcode

delete branch : cs/0.14.3

delete time in 3 days

push eventjdneo/vscode-leetcode

Sheng Chen

commit sha 650244ea031059a10181687ea4b8cb9c561fead2

chore: Prepare for 0.14.3 (#329)

view details

push time in 3 days

PR merged jdneo/vscode-leetcode

Reviewers
chore: Prepare for 0.14.3
+31 -24

0 comment

4 changed files

jdneo

pr closed time in 3 days

PR opened jdneo/vscode-leetcode

Reviewers
chore: Prepare for 0.14.3
+31 -24

0 comment

4 changed files

pr created time in 3 days

create barnchjdneo/vscode-leetcode

branch : cs/0.14.3

created branch time in 3 days

delete branch jdneo/vscode-leetcode

delete branch : cs/outputFolder

delete time in 3 days

push eventjdneo/vscode-leetcode

Sheng Chen

commit sha fc80f68aa2751cb58846ea033e808d649afaf9f7

feat: Support interpolation for outputFolder settings (#323)

view details

push time in 3 days

PR merged jdneo/vscode-leetcode

Reviewers
feat: Support interpolation for outputFolder settings

Resolve #151

+39 -29

0 comment

3 changed files

jdneo

pr closed time in 3 days

issue closedjdneo/vscode-leetcode

Support interpolation in output folder settings

see: https://github.com/jdneo/vscode-leetcode/issues/119#issuecomment-466778120

@jdneo Thanks for your great work, and I am wondering if it's possible to use preserved value for interpolation, like something-${tag}-${language}-something.

closed time in 3 days

wangjunwei87

issue commentmicrosoft/vscode-java-test

JUnit tests not found on symlinked project folder

I see. I'll run it in Fedora 29 in a VM later when I have time. Please also feel free to comment if you find anything.

Thanks.

mweirauch

comment created time in 3 days

issue commentjdneo/vscode-leetcode

装了node.js 还是会报leetcode.xxx 错误

If your path has Node.js executable, there is no need to set the setting leetcode.nodePath. I think your problem is very similar to this one: https://github.com/jdneo/vscode-leetcode/issues/322#issuecomment-492614709

Please do remember that the path environment variable won't be automatically updated in the same session. You need to close the VS Code entirely and restart it from a new session.

seanxuu

comment created time in 3 days

issue commentmicrosoft/vscode-java-test

Unable to setup in development mode

Just pushed a fix commit under: https://github.com/microsoft/vscode-java-test/tree/cs/path-issue

Feel free to have a try if you would like to.

Thanks.

rohinwork

comment created time in 4 days

create barnchmicrosoft/vscode-java-test

branch : cs/path-issue

created branch time in 4 days

issue commentmicrosoft/vscode-java-test

Unable to setup in development mode

Ok now I can repro this. The root cause seems lie in here https://github.com/microsoft/vscode-java-test/blob/master/java-extension/com.microsoft.java.test.plugin/src/main/java/com/microsoft/java/test/plugin/util/ProjectTestUtils.java#L79

I'll send a PR to fix it later.

rohinwork

comment created time in 4 days

push eventjdneo/vscode-leetcode

Sheng Chen

commit sha d01a8f0e30b39a79bb7d4eddd5cb69cce9020e50

fix: Correct the prompt message when signing in (#327)

view details

Sheng Chen

commit sha 66acddd0e3bc8b13ffeb6bb0ea639374f049d3b7

Merge branch 'master' into cs/outputFolder

view details

push time in 4 days

delete branch jdneo/vscode-leetcode

delete branch : cs/wording

delete time in 4 days

push eventjdneo/vscode-leetcode

Sheng Chen

commit sha d01a8f0e30b39a79bb7d4eddd5cb69cce9020e50

fix: Correct the prompt message when signing in (#327)

view details

push time in 4 days

PR merged jdneo/vscode-leetcode

Reviewers
refactor: Correct the prompt message when signing in

resolve #325

+2 -2

0 comment

1 changed file

jdneo

pr closed time in 4 days

issue closedjdneo/vscode-leetcode

登陆时是不是描述错误

Before you submit an question we recommend you to check out the DOCUMENT first.

You can also find more information in:

💬 Questions and Help

Please outline the questions. 提示输入user name ,但是实际应该输入的是邮箱

closed time in 4 days

asurance

issue commentmicrosoft/vscode-java-test

org.openqa.selenium.WebDriverException: Driver isn't initialized. This extension can only be used in combination with the DriverParameterResolver

Hi @fabb

Is that possible for you to share a sample project which can repro the issue?

fabb

comment created time in 4 days

issue commentmicrosoft/vscode-java-test

Unable to setup in development mode

@rohinwork Is your local repo updated with the latest commit?

rohinwork

comment created time in 4 days

issue commentmicrosoft/vscode-java-test

JUnit tests not found on symlinked project folder

Hi @mweirauch

Do you mean by this?

demo1

mweirauch

comment created time in 4 days

issue commentmicrosoft/vscode-java-test

Unable to setup in development mode

Hmm, that's wired. I cannot repro this on my side. Do you encounter this issue only in dev mode?

rohinwork

comment created time in 4 days

issue commentmicrosoft/vscode-java-test

Unable to setup in development mode

Could you provide more information about your project generated by spring initializr?

rohinwork

comment created time in 4 days

PR opened jdneo/vscode-leetcode

Reviewers
refactor: Correct the prompt message when signing in

resolve #325

+2 -2

0 comment

1 changed file

pr created time in 4 days

create barnchjdneo/vscode-leetcode

branch : cs/wording

created branch time in 4 days

issue openedjdneo/vscode-leetcode

Refine the error handling logic

created time in 4 days

delete branch jdneo/vscode-java

delete branch : cs/issue-612

delete time in 4 days

issue closedmicrosoft/vscode-java-test

Chinese Language Support

We have lots of Chinese developers. It would be great if we can provide a localized interface. This issue is to track the effort of building the localization story. Supporting Chinese is a start. Once the solution is working, we can expand the support to other languages.

closed time in 4 days

akaroml

issue commentmicrosoft/vscode-java-test

Chinese Language Support

Closing this for now since we have package.nls.zh.json now.

Will reopen this it turns out that we have other more works to do.

akaroml

comment created time in 4 days

issue commentmicrosoft/vscode-java-test

No stacktrace/message in code-server

Hi @sridherj,

We are embracing the open-source world 😃. Nice to meet you!

rohinwork

comment created time in 4 days

delete branch microsoft/vscode-java-test

delete branch : cs/vulnerability

delete time in 4 days

push eventmicrosoft/vscode-java-test

Sheng Chen

commit sha 9c4c5f25d0ace6b71dcdfd444c5a26475e0e9363

fix: Update package-lock.json for vulnerability issues (#704)

view details

push time in 4 days

PR opened angelozerr/lsp4xml

remove unused settings for testing

Just found out that there are some deprecated/invalid configs for testing. So I remove them

Signed-off-by: Sheng Chen sheche@microsoft.com

+0 -89

0 comment

3 changed files

pr created time in 4 days

create barnchjdneo/lsp4xml

branch : cs/test

created branch time in 4 days

fork jdneo/lsp4xml

XML Language Server

fork in 4 days

push eventmicrosoft/vscode-java-test

Sheng Chen

commit sha e375778b664dd9c34935cdc7189bf7ff2dc29218

docs: Add the build resource step in contributing page (#705)

view details

Sheng Chen

commit sha 109d6b8e4f1df344ac9e7c6511f4448f25bf22f8

Merge branch 'master' into cs/vulnerability

view details

push time in 4 days

delete branch microsoft/vscode-java-test

delete branch : cs/contributing

delete time in 4 days

push eventmicrosoft/vscode-java-test

Sheng Chen

commit sha e375778b664dd9c34935cdc7189bf7ff2dc29218

docs: Add the build resource step in contributing page (#705)

view details

push time in 4 days

issue commentmicrosoft/vscode-java-test

No stacktrace/message in code-server

info is only to show the application's output. For example. in your code, you write system.out.printlin("hi").

I think the problem is that code server has some problem for rendering the webview, causing that the test report cannot be expanded.

rohinwork

comment created time in 4 days

issue commentjdneo/vscode-leetcode

登陆时是不是描述错误

Thanks. A better description should be Username or E-mail image

asurance

comment created time in 4 days

push eventmicrosoft/vscode-java-test

sheche@microsoft.com

commit sha 2e941d082a2d472219098c56cd3e36b94c25110d

Update script

view details

push time in 4 days

issue commentmicrosoft/vscode-java-test

No stacktrace/message in code-server

Thank you for reporting this. I have to apologize for that there is a step missing in the contributing page.

I have updated the docs in this PR: https://github.com/microsoft/vscode-java-test/pull/705

rohinwork

comment created time in 4 days

create barnchmicrosoft/vscode-java-test

branch : cs/contributing

created branch time in 4 days

create barnchmicrosoft/vscode-java-test

branch : cs/vulnerability

created branch time in 4 days

create barnchmicrosoft/vscode-java-test

branch : cs/0.17.0

created branch time in 4 days

issue commentmicrosoft/vscode-java-test

Test working directory not set correctly for multi-module Maven projects

Hi @jaydee864,

I guess there might be some misunderstanding here. The ${workspaceFolder} is a variable which will always point to the path of the workspace folder. Here the difference between single-root and multi-root is:

  • single-root: when you directly open multi-module-test-repro in VS Code, your workspace only contains one folder, in that case, the ${workspaceFolder} will point to multi-module-test-repro
  • multi-root: when you add both multi-module-test-repro/first and multi-module-test-repro/second into VS Code. now your workspace has two workspace folders. And now, the ${workspaceFolder} in the different folders has different meanings. So you can just change your settings as follow:
"java.test.defaultConfig": "first",
  "java.test.config": {
    "name": "first",
    "projectName": "multi-module-test-repro",
    "workingDirectory": "${workspaceFolder}",
    "args": [],
    "vmargs": [],
    "env": {
      "SOME_INTEGER": "10"
    },
  }

You were getting the ENOENT error is because ${workspaceFolder}\\first is equal to <some path>\\multi-module-test-repro\\first\\first. And there is no such folder actually.

jaydee864

comment created time in 4 days

issue commentmicrosoft/vscode-java-test

No stacktrace/message in code-server

Have you run npm run build-plugin?

rohinwork

comment created time in 4 days

pull request commentmicrosoft/azure-maven-archetypes

Kotlin Archetype: Update versions. Remove unnecessary dependencyManagement

@Flanker32 please help take a look. Thank you.

brunoborges

comment created time in 4 days

issue commentjdneo/vscode-leetcode

Could not fetch correct tag for output folder

@jjeejj This PR is addressing your problem

wangjunwei87

comment created time in 4 days

issue commentmicrosoft/vscode-java-test

No stacktrace/message in code-server

However logs are visible without this setting on my local machine. This is because the setting has the default value: info

For the two questions, you asked. I guess your project is neither a Maven project nor Gradle project. Am I right?

rohinwork

comment created time in 5 days

issue commentmicrosoft/vscode-java-test

Could not recognize different test set

Thank you @jbrandli for your feedback. I'll take a look.

quoccuongngo

comment created time in 5 days

issue closedmicrosoft/vscode-java-test

Adopt extension for no reload on install

Hi, I am a developer from VS Code and in the last release 1.31, we added a new feature - no reload is required on installing an extension - https://code.visualstudio.com/updates/v1_31#_no-reload-on-install

But there are some exceptions to it as mentioned in the doc. If the extension is contributing to external contribution points, then the extension requires reload after installing. Hence, we added a new listener API for the owners of the external contribution point to listen to extension addition/removal and can update its state - https://code.visualstudio.com/updates/v1_31#_extensions-change-event.

Our plan is to give extensions one milestone/month for adopting to the above API and make the other extensions consuming their contribution points ready for no reload. It means that from next release, above exception will be removed and all extensions are added to VS Code window immediately after installation and no reload is shown.

We scanned the extensions in the marketplace and found out that this extension uses an external contribution point javaExtensions and requires reload on install. Found out that https://github.com/redhat-developer/vscode-java extension owns this contribution point. I have already filed an issue against that extension https://github.com/redhat-developer/vscode-java/issues/794 for adoption. Filing the issue also here as this extension is impacted and can use other issue for follow up.

Thanks

closed time in 5 days

sandy081

issue commentmicrosoft/vscode-java-test

Adopt extension for no reload on install

The issue is handled on the vscode java side. Thanks.

sandy081

comment created time in 5 days

IssuesEvent

issue commentmicrosoft/vscode-java-test

Test working directory not set correctly for multi-module Maven projects

Hi all,

Sorry for my late reply and thank you @jaydee864 for providing the source code to help me repro.

To solve this problem, you can import your projects in the multi-root way, which means:

  1. First Open the folder \multi-module-test-repro\first in your VS Code.
  2. In the File Explorer, right click on a blank area, and you can find an option named Add Folder to Workspace...: image
  3. Select the folder \multi-module-test-repro\second
  4. Now you have imported the two folders as multi-root mode in VS Code, just as the following screenshot: image

By doing this, your workspace will have two workspace folders, and thus, the ${workspaceFolder} will point to \multi-module-test-repro\first and \multi-module-test-repro\second separately. And you will find all the test cases work fine.

image

jaydee864

comment created time in 5 days

issue commentmicrosoft/vscode-java-debug

Adopt extension for no reload on install

The issue is handled on the vscode java side. Thanks.

sandy081

comment created time in 5 days

issue closedmicrosoft/vscode-java-debug

Adopt extension for no reload on install

Hi, I am a developer from VS Code and in the last release 1.31, we added a new feature - no reload is required on installing an extension - https://code.visualstudio.com/updates/v1_31#_no-reload-on-install

But there are some exceptions to it as mentioned in the doc. If the extension is contributing to external contribution points, then the extension requires reload after installing. Hence, we added a new listener API for the owners of the external contribution point to listen to extension addition/removal and can update its state - https://code.visualstudio.com/updates/v1_31#_extensions-change-event.

Our plan is to give extensions one milestone/month for adopting to the above API and make the other extensions consuming their contribution points ready for no reload. It means that from next release, above exception will be removed and all extensions are added to VS Code window immediately after installation and no reload is shown.

We scanned the extensions in the marketplace and found out that this extension uses an external contribution point javaExtensions and requires reload on install. Found out that https://github.com/redhat-developer/vscode-java extension owns this contribution point. I have already filed an issue against that extension https://github.com/redhat-developer/vscode-java/issues/794 for adoption. Filing the issue also here as this extension is impacted and can use other issue for follow up.

Thanks

closed time in 5 days

sandy081

delete branch microsoft/vscode-java-test

delete branch : cs/testfactory

delete time in 5 days

push eventmicrosoft/vscode-java-test

Sheng Chen

commit sha b4b66d0c2e1644f89fb69ea6b9237a1a835190bb

feat: Support @TestFactory in JUnit 5 (#699)

view details

push time in 5 days

PR merged microsoft/vscode-java-test

feat: Support @TestFactory in JUnit 5

Resolve #644

This change overrides the isTestMethod() in the child class. It's because different test frameworks have different restrictions about the method signature. And it's hard to differentiate them in just one method.

demo

+73 -27

0 comment

5 changed files

jdneo

pr closed time in 5 days

issue closedmicrosoft/vscode-java-test

Support JUnit 5 TestFactory annotation

As mentioned by @Justas-S in https://github.com/Microsoft/vscode-java-test/issues/594#issuecomment-465169798:

Support for @TestFactory would also be nice.

closed time in 5 days

jdneo
GollumEvent
GollumEvent
GollumEvent

issue commentmicrosoft/vscode-java-test

Run/Debug code lenses don't appear

Here is the final solution for this issue:

For Maven projects

The user can use <testSourceDirectory/> to configure the test source paths.

For Gradle projects

The user can use sourceSets to configure the test source paths.

For Eclipse & Invisible projects

All the source files are treated as testable files

What's an invisible project?

For Default (single file) project

It will be ignored.

This is for those files that do not belong to the current workspace, for example, you drop(open) a file into the VS Code from another place.

joshmanderson

comment created time in 5 days

delete branch microsoft/vscode-java-test

delete branch : cs/mark-test-folder

delete time in 5 days

push eventmicrosoft/vscode-java-test

Sheng Chen

commit sha ec740b40f795409603440f6102a1bb03e9cb4129

fix: better resolve test scope for invisible project (#697)

view details

push time in 5 days

PR merged microsoft/vscode-java-test

fix: better resolve test scope for invisible project

Resolve #470

Now if the project is a General Java project, which means it's a Java project but is not built by Maven/Gradle, Test Runner will always treat the classpaths as test classpaths.

For Maven projects, the user should use <testSourceDirectory/> to configure the test source paths.

For Gradle projects, the user should use sourceSets to configure the test source paths.

For Eclipse & Invisible projects, all the source files are treated as testable files

For Default (single file) project, it will be ignored.

+63 -110

0 comment

11 changed files

jdneo

pr closed time in 5 days

issue closedmicrosoft/vscode-java-test

Run/Debug code lenses don't appear

Starting about a week ago, code lenses for each test, as well as the lens for the test class as a whole, have stopped appearing. Also, no tests appear in the test explorer panel, though this may have been a pre-existing issue – I've never used the test explorer before so I can't say for sure.

Restarting or reloading vscode does not fix the problem, nor does restarting the computer, nor disabling and re-enabling the test runner code lens – or the root vscode code lens – setting (also tried disable+restart and re-enable+restart).

Project is using gradle and tests use junit. Gradle version was upgraded from 2.14.1 to 3.5.1 17 days ago, but the issue has only started occurring in the last week, so I'm not sure that the gradle upgrade is relevant to the problem.

Has anyone else experienced similar issues recently and does anyone have any ideas as to what might be causing the issue?

closed time in 5 days

joshmanderson

issue commentmicrosoft/vscode-java-test

No stacktrace/message in code-server

I see. What's the setting java.test.log.level in your code server?

rohinwork

comment created time in 5 days

issue commentmicrosoft/vscode-java-test

No stacktrace/message in code-server

Thank you @rohinwork.

The test report is actually an HTML page and gets rendered by VS Code's webview. And I guess what you are encountering is that the report cannot be expanded.

If that is the case, then I think this should be a bug/issue of Code Server. What we can do from the extension side is really limited since we are just using the API provided by VS Code itself.

rohinwork

comment created time in 5 days

more