profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/jcoux/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

camptocamp/docker-odoo-nginx 10

Configure nginx for Odoo projects

camptocamp/account-analytic 1

Odoo Account Analytic Related Addons

camptocamp/account-closing 1

Odoo Accountant closing tools

camptocamp/account-financial-tools 1

Odoo Accountant Financial Tools and Utils

camptocamp/account-invoicing 1

Odoo Invoicing Extension Addons

camptocamp/account-reconcile 1

Odoo Bank Statements Tasks (reconciliation, completion,...)

camptocamp/AIS.py 1

Python interface for the Swisscom All-in Signing Service

create barnchcamptocamp/sale-workflow

branch : merge-branch-2842-14.0.0.10.0

created branch time in 15 days

create barnchcamptocamp/account-invoicing

branch : merge-branch-2842-14.0.0.10.0

created branch time in 15 days

create barnchcamptocamp/account-reconcile

branch : merge-branch-2842-14.0.0.10.0

created branch time in 15 days

create barnchcamptocamp/search-engine

branch : merge-branch-2842-14.0.0.10.0

created branch time in 15 days

create barnchcamptocamp/server-tools

branch : merge-branch-2842-14.0.0.10.0

created branch time in 15 days

create barnchcamptocamp/odoo

branch : merge-branch-2842-14.0.0.10.0

created branch time in 15 days

create barnchcamptocamp/delivery-carrier

branch : merge-branch-2842-14.0.0.10.0

created branch time in 15 days

create barnchcamptocamp/account-analytic

branch : merge-branch-2842-14.0.0.10.0

created branch time in 15 days

create barnchcamptocamp/product-attribute

branch : merge-branch-2842-14.0.0.10.0

created branch time in 15 days

create barnchcamptocamp/odoo-shopinvader

branch : merge-branch-2828-13.0.1.16.0

created branch time in 15 days

create barnchcamptocamp/account-reconcile

branch : merge-branch-2828-13.0.1.16.0

created branch time in 15 days

create barnchcamptocamp/server-tools

branch : merge-branch-2828-13.0.1.16.0

created branch time in 15 days

create barnchcamptocamp/odoo

branch : merge-branch-2828-13.0.1.16.0

created branch time in 15 days

create barnchcamptocamp/delivery-carrier

branch : merge-branch-2828-13.0.1.16.0

created branch time in 15 days

PullRequestReviewEvent

Pull request review commentshopinvader/odoo-shopinvader

[14.0][ADD] shopinvader_sale_amount_by_group

+# Copyright 2021 Camptocamp SA+# @author Iván Todorovich <ivan.todorovich@gmail.com>+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).++from odoo.addons.shopinvader.tests.test_cart import CommonConnectedCartCase+++class TestCart(CommonConnectedCartCase):+    def setUp(self):+        super().setUp()+        # TODO: This should be in setUpClass, but that should be changed+        # in shopinvader's CommonConnectedCartCase first+        # Configure multiple taxes on a sale order+        self.tax_10 = self.env.ref("shopinvader_sale_amount_by_group.tax_10")+        self.tax_20 = self.env.ref("shopinvader_sale_amount_by_group.tax_20")+        self.cart.order_line[0].tax_id = [(6, 0, self.tax_10.ids)]+        self.cart.order_line[1].tax_id = [(6, 0, self.tax_20.ids)]++    def test_cart(self):+        data = self.service.dispatch("update", params=dict())["data"]+        groups = [g["name"] for g in data["amount"]["amount_by_group"]]+        self.assertEqual(+            groups, (self.tax_10 | self.tax_20).mapped("tax_group_id.name")

I would have also base and amount in unit test.

ivantodorovich

comment created time in 16 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentshopinvader/odoo-shopinvader

[14.0] Add shopinvader_product_seasonality

+# Copyright 2021 Camptocamp SA+# @author: Simone Orsi <simone.orsi@camptocamp.com>+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).++from odoo.addons.product_seasonality.tests.common import CommonCaseWithLines+from odoo.addons.shopinvader.tests.common import UtilsMixin++# Reminders for lines' data (from CommonCaseWithLines):+#+# line_values = [+#     {+#         "date_start": "2021-05-10",+#         "date_end": "2021-05-16",+#         "monday": True,+#         "tuesday": True,+#         "wednesday": True,+#         "thursday": False,+#         "friday": False,+#         "saturday": False,+#         "sunday": False,+#         "product_id": cls.prod1.id,+#     },+#     {+#         "date_start": "2021-05-12",+#         "date_end": "2021-05-23",+#         "monday": False,+#         "tuesday": False,+#         "wednesday": False,+#         "thursday": True,+#         "friday": True,+#         "saturday": True,+#         "sunday": True,+#         "product_id": cls.prod2.id,

https://github.com/OCA/product-attribute/blob/14.0/product_seasonality/tests/common.py#L52

simahawk

comment created time in 17 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentshopinvader/odoo-shopinvader

[14.0] Add shopinvader_product_seasonality

+# Copyright 2021 Camptocamp SA+# @author: Simone Orsi <simone.orsi@camptocamp.com>+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).+from odoo.addons.component.core import Component+from odoo.addons.component_event import skip_if+++class SeasonalConfigLineEventListener(Component):+    _name = "seasonal.config.line.event.listener"+    _inherit = "base.event.listener"++    _apply_on = ["seasonal.config.line"]++    @skip_if(lambda self, record, **kw: self._check_product_bindings(record, **kw))+    def on_record_create(self, record, fields=None):+        self._create_config_line_bindings_if_missing(record)++    def _check_product_bindings(self, record, **kw):+        return not any(+            (+                record.product_id.shopinvader_bind_ids,+                record.product_template_id.shopinvader_bind_ids,+            )+        )

Hum: immediately more clear with the explanation :) A little comment maybe to the future? ;)

simahawk

comment created time in 19 days

PullRequestReviewEvent

Pull request review commentshopinvader/odoo-shopinvader

[14.0] Add shopinvader_product_seasonality

+# Copyright 2021 Camptocamp SA+# @author: Simone Orsi <simone.orsi@camptocamp.com>+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).+from odoo.addons.component.core import Component+from odoo.addons.component_event import skip_if+++class SeasonalConfigLineEventListener(Component):+    _name = "seasonal.config.line.event.listener"+    _inherit = "base.event.listener"++    _apply_on = ["seasonal.config.line"]++    @skip_if(lambda self, record, **kw: self._check_product_bindings(record, **kw))+    def on_record_create(self, record, fields=None):+        self._create_config_line_bindings_if_missing(record)++    def _check_product_bindings(self, record, **kw):+        return not any(+            (+                record.product_id.shopinvader_bind_ids,+                record.product_template_id.shopinvader_bind_ids,+            )+        )
    @skip_if(lambda self, record, **kw: self._check_product_bindings(record, **kw))
    def on_record_create(self, record, fields=None):
        self._create_config_line_bindings_if_missing(record)

    def _check_product_bindings(self, record, **kw):
        return any(
            (
                record.product_id.shopinvader_bind_ids,
                record.product_template_id.shopinvader_bind_ids,
            )
        )

Maybe I'm still wrong, but That I read is: "Skip binding creation if we don't have an existing binding."

I would have: "Skip binding creation if we have an existing binding."

simahawk

comment created time in 19 days

Pull request review commentshopinvader/odoo-shopinvader

[14.0] Add shopinvader_product_seasonality

+# Copyright 2021 Camptocamp SA+# @author: Simone Orsi <simone.orsi@camptocamp.com>+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).++from odoo.addons.component.tests.common import ComponentRegistryCase+from odoo.addons.product_seasonality.tests.common import CommonCaseWithLines+from odoo.addons.shopinvader.tests.common import UtilsMixin++# Reminders for lines' data (from CommonCaseWithLines):+#+# line_values = [+#     {+#         "date_start": "2021-05-10",+#         "date_end": "2021-05-16",+#         "monday": True,+#         "tuesday": True,+#         "wednesday": True,+#         "thursday": False,+#         "friday": False,+#         "saturday": False,+#         "sunday": False,+#         "product_template_id": cls.prod1.product_tmpl_id.id,+#         "product_id": cls.prod1.id,+#     },+#     {+#         "date_start": "2021-05-12",+#         "date_end": "2021-05-23",+#         "monday": False,+#         "tuesday": False,+#         "wednesday": False,+#         "thursday": True,+#         "friday": True,+#         "saturday": True,+#         "sunday": True,+#         "product_template_id": cls.prod2.product_tmpl_id.id,+#         "product_id": cls.prod2.id,+#     },

Second line is just defined by template in the original module:

#         "product_template_id": cls.prod2.product_tmpl_id.id,
#     },
simahawk

comment created time in 19 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent