profile
viewpoint

jcmorrow/chess-heatmap 5

See territorial control of any chess position

dhanur/Sunible-Beta 1

Fresno trial

jcmorrow/capturing_the_future_by_replaying_the_past 1

Ruby implementation of a paper on delimited continuations: http://gallium.inria.fr/~scherer/research/replay/replay-icfp18.pdf

jcmorrow/flask-template 1

A flask template for engineers coming from rails.

jcmorrow/advent2019 0

Advent of Code 2019 in Rust

push eventjcmorrow/dotfiles

Josh Morrow

commit sha 6f11b9345e5dffaae22a93c8ccc159e55b65591e

Gcloud stuff and cloud dev stuff

view details

push time in 10 days

create barnchjcmorrow/devtools

branch : jm-billing-settings-backend

created branch time in 10 days

pull request commentRecordReplay/devtools

Defensively check local nags

@jaril I can't tell if this case should return true or false. I'll leave this PR in your hands!

jcmorrow

comment created time in 10 days

PR opened RecordReplay/devtools

Defensively check local nags

I can't tell if this is happening in prod, but it happened in this E2E test: https://app.replay.io/recording/9febd9f5-11b4-477a-8af8-24250b22c259?point=29855706938421465504100931554249690&time=61856&hasFrames=false

+1 -1

0 comment

1 changed file

pr created time in 10 days

push eventjcmorrow/devtools

Josh Morrow

commit sha fa47aaf99cb6fae341b46fa4c2c3f02aafa48c0f

Defensively check local nags I can't tell if this is happening in prod, but it happened in this E2E test: https://app.replay.io/recording/9febd9f5-11b4-477a-8af8-24250b22c259?point=29855706938421465504100931554249690&time=61856&hasFrames=false

view details

push time in 10 days

create barnchjcmorrow/devtools

branch : jm-be-defensive

created branch time in 10 days

issue openedRecordReplay/devtools

Make sure that our GraphQL queries will use exponential backoff during an outage

Based on my limited experience with our cloud dev environments, it seems like if the GraphQL server is failing to respond altogether, the Apollo exponential backoff retry won't kick in. This means that the client will just start constantly retrying requests, seemingly without much delay or any limit to the number of attempts made. I'm guessing this is because, as the docs say, the retryLink from Apollo handles cases "if [they fail] due to network or server errors". At least in cloud dev, when the GraphQL server goes down, it doesn't even return a 500, it just doesn't accept the incoming connection at all. I'm not sure how well this mimics our production setup, but if that happened during a real outage it could create a thundering herd scenario, which could compound an already stressful outage.

created time in 10 days

pull request commentRecordReplay/devtools

Add a General settings panel which includes a lot of org options

It might take a bit of finagling to conditionally add the menu item, but then we can land this darkly with app.features.generalSetting

True! Maybe a good plan would be to implement the Name and Logo fields (which can stay on for everyone) first, and feature-flag the org stuff until the rest of the backend changes are in?

jcmorrow

comment created time in 11 days

PR opened RecordReplay/devtools

Add a General settings panel which includes a lot of org options

This is decently on the way to lining up with the designs in https://github.com/RecordReplay/devtools/issues/4575. It's not actually hooked up to the backend yet though 😅

CleanShot 2021-11-23 at 20 21 18

+132 -5

0 comment

3 changed files

pr created time in 11 days

push eventjcmorrow/devtools

Josh Morrow

commit sha c6a44e2411c1132e13f0ccffaefb7e898a4b6505

Gray out based on org or not org

view details

push time in 11 days

create barnchjcmorrow/devtools

branch : jm-billing-settings

created branch time in 11 days

push eventjcmorrow/devtools

Josh Morrow

commit sha 6611ab9e4d705186a6bb7715c07d8235c3934492

Fix typecheck

view details

push time in 11 days

push eventjcmorrow/devtools

Josh Morrow

commit sha 554c5c4e60dd85d1dda7094347c45bfc3fa4891e

Add some storybook

view details

push time in 11 days

PR opened RecordReplay/devtools

Make the plan detail page dynamic

Our billing is starting to get more varied. This tries to adapt the PlanDetails page so that it looks more reasonable for Teams, Beta Testers, and Organization Plan folks. It also lays the groundwork for adding annual billing, someday. It also adds storybook stories for this panel, but since the panel isn't contained inside of the settings modal in storybook (and since doing this would involve hashing out all of the Apollo mock stuff) it's of limited use right now (though not useless).

+226 -43

0 comment

10 changed files

pr created time in 11 days

push eventjcmorrow/devtools

Josh Morrow

commit sha d4d6fbbf8458283c916a3fb51320bdc5f6d4bed1

Add some storybook

view details

push time in 11 days

PullRequestReviewEvent
PullRequestReviewEvent

delete branch jcmorrow/devtools

delete branch : jm-fix-fonts

delete time in 12 days

PR merged RecordReplay/devtools

Host our own fonts
  • Add the font assets for Inter and the Material Icon set to /public
  • Load the font-face declarations for those in _app.tsx
  • Delete everything relating to font-loading, fontface observer, etc. All of that should "just work" now. I've looked, and fonts still aren't loaded in E2E tests, but the tests pass anyways. I'm not digging any further in there.

I'm experiencing a brief flash of unstyled sans-serif before Inter loads on the Library page. I have no freaking clue why this is happening. I must have read the first 3 pages of search results about next.js and font-loading, and I still can't figure it out. It also never happens on production, which is currently using Google Fonts, and again I have no idea why. It makes no sense that loading from Google Fonts would be any different than loading the exact same thing from our own server. If anything, it should be less-prone to timing issues like this (I would think). Next.js says that they do some js-build-time-optimization of fonts loaded from Google Fonts, but I don't see any evidence of that happening, so I don't think that's it. Anyways, this solves the "fonts not loading sometimes" issue, so that's good enough for now.

Closes #3814

+3361 -59

1 comment

60 changed files

jcmorrow

pr closed time in 12 days

push eventRecordReplay/devtools

Josh Morrow

commit sha c2a325fb7b9c5a25d960685cdda9ee9691401e52

Host our own fonts - Add the font assets for Inter and the Material Icon set to `/public` - Load the font-face declarations for those in `_app.tsx` - Delete everything relating to font-loading, fontface observer, etc. All of that should "just work" now. I've looked, and fonts still aren't loaded in E2E tests, but the tests pass anyways. I'm not digging any further in there. I'm experiencing a brief flash of unstyled sans-serif before Inter loads on the Library page. I have *no freaking clue* why this is happening. I must have read the first 3 pages of search results about next.js and font-loading, and I still can't figure it out. It also *never* happens on production, which is currently using Google Fonts, and again I have no idea why. It makes no sense that loading from Google Fonts would be any different than loading the exact same thing from our own server. If anything, it should be less-prone to timing issues like this (I would think). Next.js says that they do some js-build-time-optimization of fonts loaded from Google Fonts, but I don't see any evidence of that happening, so I don't think that's it. Anyways, this solves the "fonts not loading sometimes" issue, so that's good enough for now. Closes #3814

view details

push time in 12 days

push eventjcmorrow/devtools

Josh Morrow

commit sha c2a325fb7b9c5a25d960685cdda9ee9691401e52

Host our own fonts - Add the font assets for Inter and the Material Icon set to `/public` - Load the font-face declarations for those in `_app.tsx` - Delete everything relating to font-loading, fontface observer, etc. All of that should "just work" now. I've looked, and fonts still aren't loaded in E2E tests, but the tests pass anyways. I'm not digging any further in there. I'm experiencing a brief flash of unstyled sans-serif before Inter loads on the Library page. I have *no freaking clue* why this is happening. I must have read the first 3 pages of search results about next.js and font-loading, and I still can't figure it out. It also *never* happens on production, which is currently using Google Fonts, and again I have no idea why. It makes no sense that loading from Google Fonts would be any different than loading the exact same thing from our own server. If anything, it should be less-prone to timing issues like this (I would think). Next.js says that they do some js-build-time-optimization of fonts loaded from Google Fonts, but I don't see any evidence of that happening, so I don't think that's it. Anyways, this solves the "fonts not loading sometimes" issue, so that's good enough for now. Closes #3814

view details

push time in 12 days

push eventjcmorrow/devtools

Josh Morrow

commit sha 91a8e277a725392bc4c35676adb2c89b5acd8bb0

Most of the way there There was definitely a smaller change in here somewhere, but I think this sets us up for some more changes down the road here.

view details

push time in 12 days

create barnchjcmorrow/devtools

branch : jm-dynamic-pricing

created branch time in 12 days

push eventjcmorrow/devtools

Josh Morrow

commit sha a8675c29c2b817523c9ec9326a9771116e173c3c

Host our own fonts - Add the font assets for Inter and the Material Icon set to `/public` - Load the font-face declarations for those in `_app.tsx` - Change the font-face observer to work without the redux store. This is actually my theory for the culprit of the non-loading fonts. Routing things like this through redux doesn't really make sense IMO, so I've tried to simplify this as much as possible. I'm experiencing a brief flash of unstyled sans-serif before Inter loads on the Library page. I have *no freaking clue* why this is happening. I must have read the first 3 pages of search results about next.js and font-loading, and I still can't figure it out. It also *never* happens on production, which is currently using Google Fonts, and again I have no idea why. It makes no sense that loading from Google Fonts would be any different than loading the exact same thing from our own server. If anything, it should be less-prone to timing issues like this (I would think). Next.js says that they do some js-build-time-optimization of fonts loaded from Google Fonts, but I don't see any evidence of that happening, so I don't think that's it. Anyways, this solves the "fonts not loading sometimes" issue, so that's good enough for now. Closes #3814 Add brief hiding back in, but take it out of redux

view details

push time in 12 days

push eventjcmorrow/devtools

Josh Morrow

commit sha 9b6f79e1fb7faeabd5ec0a9b72718df27cd21da5

Add brief hiding back in, but take it out of redux

view details

push time in 12 days

Pull request review commentRecordReplay/devtools

Host our own fonts

+@font-face {+  font-family: "Material Icons";+  font-style: normal;+  font-weight: 400;+  src: local("Material Icons"), local("MaterialIcons-Regular"),+    url(/fonts/material_icons/MaterialIcons-Regular.woff2) format("woff2"),+    url(/fonts/material_icons/MaterialIcons-Regular.ttf) format("truetype");+}++@font-face {+  font-family: "Material Icons Outlined";+  font-style: normal;+  font-weight: 400;+  src: url(/fonts/material_icons/MaterialIconsOutlined-Regular.woff2) format("woff2"),+    url(/fonts/material_icons/MaterialIconsOutlined-Regular.otf) format("opentype");+}++.material-icons,+.material-icons-outlined {

Was missing this class last time!

jcmorrow

comment created time in 12 days

PullRequestReviewEvent

push eventjcmorrow/devtools

Josh Morrow

commit sha ee27dbf3f68d4805c06edd99ecb948b90b76e5e0

Host our own fonts - Add the font assets for Inter and the Material Icon set to `/public` - Load the font-face declarations for those in `_app.tsx` - Delete everything relating to font-loading, fontface observer, etc. All of that should "just work" now. I've looked, and fonts still aren't loaded in E2E tests, but the tests pass anyways. I'm not digging any further in there. I'm experiencing a brief flash of unstyled sans-serif before Inter loads on the Library page. I have *no freaking clue* why this is happening. I must have read the first 3 pages of search results about next.js and font-loading, and I still can't figure it out. It also *never* happens on production, which is currently using Google Fonts, and again I have no idea why. It makes no sense that loading from Google Fonts would be any different than loading the exact same thing from our own server. If anything, it should be less-prone to timing issues like this (I would think). Next.js says that they do some js-build-time-optimization of fonts loaded from Google Fonts, but I don't see any evidence of that happening, so I don't think that's it. Anyways, this solves the "fonts not loading sometimes" issue, so that's good enough for now. Closes #3814

view details

push time in 12 days

Pull request review commentRecordReplay/devtools

Host our own fonts

+@font-face {+  font-family: "Material Icons";+  font-style: normal;+  font-weight: 400;+  src: local("Material Icons"), local("MaterialIcons-Regular"),+    url(/fonts/material_icons/MaterialIcons-Regular.woff2) format("woff2"),+    url(/fonts/material_icons/MaterialIcons-Regular.ttf) format("truetype");+}++@font-face {+  font-family: "Material Icons Outlined";+  font-style: normal;+  font-weight: 400;+  src: url(/fonts/material_icons/MaterialIconsOutlined-Regular.woff2) format("woff2"),+    url(/fonts/material_icons/MaterialIconsOutlined-Regular.otf) format("opentype");+}++.material-icons {+  font-family: "Material Icons";+  font-weight: normal;+  font-style: normal;+  font-size: 24px; /* Preferred icon size */+  display: inline-block;+  line-height: 1;+  text-transform: none;+  letter-spacing: normal;+  word-wrap: normal;+  white-space: nowrap;+  direction: ltr;++  /* Support for all WebKit browsers. */+  -webkit-font-smoothing: antialiased;+  /* Support for Safari and Chrome. */+  text-rendering: optimizeLegibility;++  /* Support for Firefox. */+  -moz-osx-font-smoothing: grayscale;++  /* Support for IE. */+  font-feature-settings: "liga";+}++.material-icons-outlined {

This class was missing last time.

jcmorrow

comment created time in 12 days

PullRequestReviewEvent
more