profile
viewpoint
Jimmy Cao jcao219 Walmart Labs SF/TX/Bentonville/NYC/LA

jcao219/astra 0

CS 5152

jcao219/brainwallet-check 0

Generates a bitcoin address and private key according to a 'brainwallet' string, then checks to see if the wallet is active

jcao219/cfssl 0

CFSSL: Cloudflare's PKI and TLS toolkit

push eventjcao219/incubator-airflow

snyk-bot

commit sha f2a4c9eb24195feff8fa1815eb0b57c4493c432d

fix: airflow/www_rbac/package.json, airflow/www_rbac/package-lock.json & airflow/www_rbac/.snyk to reduce vulnerabilities The following vulnerabilities are fixed with a Snyk patch: - https://snyk.io/vuln/SNYK-JS-LODASH-567746

view details

push time in a month

push eventjcao219/incubator-airflow

snyk-bot

commit sha a228ac524a13e0d6983a262b13cfe03e712645a9

fix: airflow/www_rbac/package.json, airflow/www_rbac/package-lock.json & airflow/www_rbac/.snyk to reduce vulnerabilities The following vulnerabilities are fixed with a Snyk patch: - https://snyk.io/vuln/SNYK-JS-LODASH-567746

view details

push time in a month

push eventjcao219/incubator-airflow

snyk-bot

commit sha d147205cf9b1ac4efa624463920d0485febbe348

fix: airflow/www_rbac/package.json, airflow/www_rbac/package-lock.json & airflow/www_rbac/.snyk to reduce vulnerabilities The following vulnerabilities are fixed with a Snyk patch: - https://snyk.io/vuln/SNYK-JS-LODASH-567746

view details

push time in a month

pull request commentdenoland/deno

Make Deno.Buffer implement only sync I/O

You bet. Good call!

On Wed, Apr 29, 2020, 3:53 PM Bartek Iwańczuk notifications@github.com wrote:

@jcao219 https://github.com/jcao219 thanks once again for the patch! We've decided to keep async interfaces for Deno.copy() compatibility.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/denoland/deno/pull/4960#issuecomment-621457891, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABQUEJWKV45KODIE5MRYZLRPCHT7ANCNFSM4MSRAK6Q .

jcao219

comment created time in a month

pull request commentdenoland/deno

Make Deno.Buffer implement only sync I/O

No worries! I'm glad I got to take another look at the codebase and see how much it's improved.

On Tue, Apr 28, 2020, 6:04 PM Ryan Dahl notifications@github.com wrote:

@jcao219 https://github.com/jcao219 Thanks - please hold off on continuing this one. We've had some discussions regarding buffer and we're not sure if we want to remove these methods anymore. Sorry for the confusion - I'll update later.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/denoland/deno/pull/4960#issuecomment-620899911, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABQUEJA5OEYZNJ7OGJSCMLRO5OG3ANCNFSM4MSRAK6Q .

jcao219

comment created time in a month

pull request commentdenoland/deno

Make Deno.Buffer implement only sync I/O

Thanks ryan and bart, tonight i'll continue

jcao219

comment created time in a month

Pull request review commentdenoland/deno

Make Deno.Buffer implement only sync I/O

 export class ConnImpl implements Conn {     return read(this.rid, p);   } +  readSync(p: Uint8Array): number | EOF {+    // TODO(jcao219): Verify that readSync op works for all conn rids.

I looked at the rust code and it seems clear that it doesn't

jcao219

comment created time in a month

Pull request review commentdenoland/deno

Make Deno.Buffer implement only sync I/O

 class Body implements domTypes.Body, ReadableStream<Uint8Array>, io.ReadCloser {     return read(this.#rid, p);   } +  readSync(p: Uint8Array): number | io.EOF {

revert this

jcao219

comment created time in a month

push eventjcao219/deno

Jimmy Cao

commit sha d2d018536386eab37c526fdf79972fc55d00148f

Allow tests to start running Deno.copyFile should be added! Followup bug?

view details

push time in a month

push eventjcao219/deno

Jimmy Cao

commit sha f86ae593355b5d4f4fbdeddbf179f47f727da936

Should update declaration file too

view details

push time in a month

pull request commentdenoland/deno

Make Deno.Buffer implement only sync I/O

Tests can be dealt with tomorrow

jcao219

comment created time in a month

push eventjcao219/deno

Jimmy Cao

commit sha f1709cbcc7e9daa0febdcaf1af5dd701f37d6d5b

formatting

view details

push time in a month

pull request commentdenoland/deno

Make Deno.Buffer implement only sync I/O

image

Well, looks like I'll need to open a command line after all...

jcao219

comment created time in a month

pull request commentdenoland/deno

Make Deno.Buffer implement only sync I/O

So I went ahead and removed Deno.readFrom -- I can add it back in if that makes sense -- but from reading the source code it seems that it doesn't make sense to me.

jcao219

comment created time in a month

push eventjcao219/deno

Jimmy Cao

commit sha 3208e9a3a9f4a7fcbcd79ce00b2211bf1a0af2bd

Update fetch.ts This may seem like it's taking a long time, which is true However I am also using my other browser tabs to browse the internet and learn more about 5G networks

view details

push time in a month

push eventjcao219/deno

Jimmy Cao

commit sha 90422fcb3f8d7609471a299c8de7e7f49ebe6fdf

Update fetch.ts

view details

push time in a month

push eventjcao219/deno

Jimmy Cao

commit sha a264accff52efb420daf93388ddebb4e07ceac17

Fix tsc errors I wish Github integrated with a nicer editor with full ts language server support

view details

push time in a month

push eventjcao219/deno

Jimmy Cao

commit sha 357f750b57292db208f54c52406a4a573a21f608

add disable require-await i will create a followup bug to maybe refactor this

view details

push time in a month

push eventjcao219/deno

Jimmy Cao

commit sha a21949723cb7b0ce1d6825f92adc218e165f18a8

Update fetch.ts hoping that readSync is a valid op for this rid Todo: maybe bodyBuffer can become sync too check that this rid is compatible with readSync!

view details

push time in a month

push eventjcao219/deno

Jimmy Cao

commit sha e5e51ed1311229fed684609897fd071da4a2be2e

Update read_text_file.ts

view details

push time in a month

push eventjcao219/deno

Jimmy Cao

commit sha cc0ec89cf9846a1265c10700cb316ae728a62248

Update read_file.ts

view details

push time in a month

push eventjcao219/deno

Jimmy Cao

commit sha ce68e6ab0fe2c02042a7486c03305360642ae87a

change two methods' colors https://journal.stuffwithstuff.com/2015/02/01/what-color-is-your-function/

view details

push time in a month

push eventjcao219/deno

Jimmy Cao

commit sha 3443d85a3468e5d66696d4697cd99e058843092c

Update process.ts Remember to create followup issue: process shouldn't return promises for output and stderrOutput()?

view details

push time in a month

push eventjcao219/deno

Jimmy Cao

commit sha 7f326dc396267c1a46520cd99f450d91cff0f3c7

Update deno.ts to reflect readAll removal

view details

push time in a month

push eventjcao219/deno

Jimmy Cao

commit sha 2a99c7b9e5639bd32c23cfc872f93edc39bef77d

Remove async export Deno.Buffer.readAll Not needed

view details

push time in a month

push eventjcao219/deno

Jimmy Cao

commit sha da327dd2f4eccc49cedca90f6dde64780a0694e0

Add type imports of Reader and Writer back in

view details

push time in a month

pull request commentdenoland/deno

Make Deno.Buffer implement only sync I/O

Tests can be fixed after CI run

jcao219

comment created time in a month

PR opened denoland/deno

Make Deno.Buffer implement only sync I/O

Deno.Buffer shouldn't implement async read and write

https://github.com/denoland/deno/issues/4933

+2 -12

0 comment

1 changed file

pr created time in a month

push eventjcao219/deno

Jimmy Cao

commit sha 649c78081f0dd51eea46f772fe892d061702dba0

Make Deno.Buffer implement only sync I/O Deno.Buffer shouldn't implement async read and write https://github.com/denoland/deno/issues/4933

view details

push time in a month

issue commentthen/is-promise

ERR_INVALID_PACKAGE_TARGET

https://deno.land/ piling on the bandwagon

Sorunome

comment created time in a month

startedchaos-lang/chaos

started time in a month

issue commentmicrosoft/TypeScript

Narrowing of `instanceof` inconsistent with that of`typeof` for Function types

I see! I've always suspected that Function is a special code path.

You should never, ever, ever write a type like T | (() => T). We don't have any way to prevent this, but it's always going to create problems to write any type of the formT | SomeOtherForm<T>.

Does that mean T | Array<T> is a problematic type?

jcao219

comment created time in a month

issue commentmicrosoft/TypeScript

Narrowing of `instanceof` inconsistent with that of`typeof` for Function types

Hi Ryan, thanks for your rapid response.

@jgbpercy is right, the playground link should show an error on line 2.

Is the difference in typeof and instanceof intentional?

jcao219

comment created time in a month

issue openedmicrosoft/TypeScript

Narrowing of `instanceof` inconsistent with that of`typeof` for Function types

https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes#narrowing-functions-now-intersects--object-and-unconstrained-generic-type-parameters

TypeScript Version: 3.8.3

<!-- Search terms you tried before logging this (so others can find this issue more easily) --> Search Terms: narrowing instanceof narrowing functions

Expected behavior:

instanceof should match typeof

Actual behavior:

divergence

<!-- Did you find other bugs that looked similar? --> Related Issues:

Code

function callOrNot1<T>(valOrFunc: T | (() => T)): T {
  return typeof valOrFunc === "function" ? valOrFunc() : valOrFunc;
}

function callOrNot2<T>(valOrFunc: T | (() => T)): T {
  return valOrFunc instanceof Function ? valOrFunc() : valOrFunc;
}

callOrNot2<() => string>(() => "")() // compiles, fails at runtime

<details><summary><b>Output</b></summary>

"use strict";
function callOrNot1(valOrFunc) {
    return typeof valOrFunc === "function" ? valOrFunc() : valOrFunc;
}
function callOrNot2(valOrFunc) {
    return valOrFunc instanceof Function ? valOrFunc() : valOrFunc;
}
callOrNot2(() => "")();

</details>

<details><summary><b>Compiler Options</b></summary>

{
  "compilerOptions": {
    "noImplicitAny": true,
    "strictNullChecks": true,
    "strictFunctionTypes": true,
    "strictPropertyInitialization": true,
    "strictBindCallApply": true,
    "noImplicitThis": true,
    "noImplicitReturns": true,
    "alwaysStrict": true,
    "esModuleInterop": true,
    "declaration": true,
    "experimentalDecorators": true,
    "emitDecoratorMetadata": true,
    "moduleResolution": 2,
    "target": "ES2017",
    "jsx": "React",
    "module": "ESNext"
  }
}

</details>

Playground Link: Provided

created time in 2 months

fork jcao219/electrode-server

Electrode's configurable web server using Hapi.js atop Node.js

fork in 3 months

issue closedShougo/deoplete.nvim

The PyPI package msgpack has updated -- deoplete is broken on the latest version

Old version: https://pypi.org/project/msgpack-python/ (deoplete works) (deprecated)

New version: https://pypi.org/project/msgpack/ (deoplete breaks)

closed time in 3 months

jcao219

issue openedShougo/deoplete.nvim

The PyPI package msgpack has updated -- deoplete is broken on the latest version

Old version: https://pypi.org/project/msgpack-python/ (deoplete works) (deprecated)

New version: https://pypi.org/project/msgpack/ (deoplete breaks)

created time in 3 months

issue openedShougo/deoplete.nvim

support for msgpack new major version

Warning: I will close the issue without the minimal init.vim and the reproduction instructions.

Problems summary

  • msgpack is now the pip package name, not msgpack-python

Expected

Environment Information

  • deoplete version (SHA1):

  • OS:

  • neovim/Vim :version output:

  • :checkhealth or :CheckHealth result(neovim only):

Provide a minimal init.vim/vimrc with less than 50 lines (Required!)

" Your minimal init.vim/vimrc
set runtimepath+=~/path/to/deoplete.nvim/
let g:deoplete#enable_at_startup = 1

" For Vim only
"set runtimepath+=~/path/to/nvim-yarp/
"set runtimepath+=~/path/to/vim-hug-neovim-rpc/

How to reproduce the problem from neovim/Vim startup (Required!)

  1. foo
  2. bar
  3. baz

Generate a logfile if appropriate

  1. export NVIM_PYTHON_LOG_FILE=/tmp/log
  2. export NVIM_PYTHON_LOG_LEVEL=DEBUG
  3. nvim -u minimal.vimrc
  4. some works
  5. cat /tmp/log_{PID}

Screenshot (if possible)

Upload the log file

created time in 3 months

more