Joshua Chaitin-Pollak jbcpollak @6RiverSystems Boston Area http://code.joshpollak.com/

PR opened WeAllJS/wheelie-slack-app

Fix missing channels

On our private instance we discovered that some channels were missing when we used /list-private.

After digging in I found that the groups api was deprecated in favor of conversations. I fixed it to make it work, but for my own familiarity I bumped the node dependency version up to 10.x and used async/await. I hope that’s ok, or at least this can be a template for fixing the problem as you desire.

+930 -14

0 comment

3 changed files

pr created time in a day

create barnchjbcpollak/wheelie-slack-app

branch : fix-missing-channels

created branch time in a day

fork jbcpollak/wheelie-slack-app

Helper app for the WeAllJS slack

fork in a day

push eventjbcpollak/KeyV2

Joshua Chaitin-Pollak

commit sha daf38c5ca10b8fcf98caf84b4c933173f91d9bb4

Added some initial UHK keys

view details

push time in 8 days

fork jbcpollak/KeyV2

KeyV2: A Parametric Mechanical Keycap Library

fork in 10 days

delete branch 6RiverSystems/blueshell

delete branch : chore/docs

delete time in 20 days

push event6RiverSystems/blueshell

Shockolate

commit sha 21196ddfe9344c96a0d2153bb497cc7150722bed

fix: updates readme with new nodes Lints readme

view details

Joshua Chaitin-Pollak

commit sha 22f620691e5269d6cade68a576b064772be7f979

fix: updates readme with new nodes

view details

push time in 20 days

PR merged 6RiverSystems/blueshell

Reviewers
fix: updates readme with new nodes

Lints readme

+73 -49

1 comment

1 changed file

Shockolate

pr closed time in 20 days

issue commentInsanityAutomation/Marlin

Creality_DWIN baby stepping limitation

I've seen a similar issue but the values were something like -1.04 and -1.05, so incase anyone else stumbles on this, it is not the actual values that are the problem.

The only work around I've found is to reboot the printer.

trouch

comment created time in 22 days

issue closedros-planning/moveit_tutorials

Internal Compiler Error on Clean System install

Description

I have a brand new Ubuntu 18.04 system with Ros Melodic installed. Trying to follow the MoveIt! tutorial here (https://ros-planning.github.io/moveit_tutorials/doc/getting_started/getting_started.html) I get a GCC internal compiler error when running catkin build

Your environment

  • ROS Distro: Melodic
  • OS Version: Ubuntu 18.04
  • Binaries
  • If binary, which release version?

Looks like most moveit binary packages have the version 1.0.1-0bionic.20190320.191310 amd64

  • If source, which git commit or tag? The tutorial is at: git https://github.com/ros-planning/moveit_tutorials.git#adccd9ebf5f06b1de207310000501c54881b97b8

Steps to reproduce

Tell us how to reproduce this issue. Attempt to provide a working demo, perhaps using Docker.

Expected behaviour

Should build cleanly with catkin build

Backtrace or Console output

Scanning dependencies of target robot_model_and_robot_state_tutorial
Scanning dependencies of target ros_api_tutorial
[  3%] Building CXX object doc/kinematics/CMakeFiles/ros_api_tutorial.dir/src/ros_api_tutorial.cpp.o
[  7%] Building CXX object doc/robot_model_and_robot_state/CMakeFiles/robot_model_and_robot_state_tutorial.dir/src/robot_model_and_robot_state_tutorial.cpp.o
[ 10%] Linking CXX executable /home/parallels/src/moveit/devel/.private/moveit_tutorials/lib/moveit_tutorials/robot_model_and_robot_state_tutorial
[ 10%] Built target robot_model_and_robot_state_tutorial
Scanning dependencies of target planning_scene_tutorial
[ 14%] Building CXX object doc/planning_scene/CMakeFiles/planning_scene_tutorial.dir/src/planning_scene_tutorial.cpp.o
[ 17%] Linking CXX executable /home/parallels/src/moveit/devel/.private/moveit_tutorials/lib/moveit_tutorials/ros_api_tutorial
[ 17%] Built target ros_api_tutorial
Scanning dependencies of target planning_scene_ros_api_tutorial
[ 21%] Building CXX object doc/planning_scene_ros_api/CMakeFiles/planning_scene_ros_api_tutorial.dir/src/planning_scene_ros_api_tutorial.cpp.o
[ 25%] Linking CXX executable /home/parallels/src/moveit/devel/.private/moveit_tutorials/lib/moveit_tutorials/planning_scene_tutorial
[ 25%] Built target planning_scene_tutorial
Scanning dependencies of target motion_planning_api_tutorial
[ 28%] Building CXX object doc/motion_planning_api/CMakeFiles/motion_planning_api_tutorial.dir/src/motion_planning_api_tutorial.cpp.o
c++: internal compiler error: Killed (program cc1plus)
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-7/README.Bugs> for instructions.
doc/planning_scene_ros_api/CMakeFiles/planning_scene_ros_api_tutorial.dir/build.make:62: recipe for target 'doc/planning_scene_ros_api/CMakeFiles/planning_scene_ros_api_tutorial.dir/src/planning_scene_ros_api_tutorial.cpp.o' failed
make[2]: *** [doc/planning_scene_ros_api/CMakeFiles/planning_scene_ros_api_tutorial.dir/src/planning_scene_ros_api_tutorial.cpp.o] Error 4
CMakeFiles/Makefile2:4325: recipe for target 'doc/planning_scene_ros_api/CMakeFiles/planning_scene_ros_api_tutorial.dir/all' failed
make[1]: *** [doc/planning_scene_ros_api/CMakeFiles/planning_scene_ros_api_tutorial.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 32%] Linking CXX executable /home/parallels/src/moveit/devel/.private/moveit_tutorials/lib/moveit_tutorials/motion_planning_api_tutorial
[ 32%] Built target motion_planning_api_tutorial
Makefile:140: recipe for target 'all' failed
make: *** [all] Error 2

closed time in 23 days

jbcpollak

issue commentros-planning/moveit_tutorials

Internal Compiler Error on Clean System install

I tried building moveit from source as well, and got the same error on a different package:

output from catkin build:

...............................................................................
Finished  <<< moveit_simple_controller_manager                 [ 28.0 seconds ]
Starting  >>> moveit_chomp_optimizer_adapter                                   
_______________________________________________________________________________
Warnings   << moveit_chomp_optimizer_adapter:symlink /home/parallels/src/moveit/logs/moveit_chomp_optimizer_adapter/build.symlink.000.log
Warning: Cannot symlink from /home/parallels/src/moveit/devel/.private/moveit_chomp_optimizer_adapter/local_setup.sh to existing file /home/parallels/src/moveit/devel/./local_setup.sh
Warning: Source hash: 7e8e77bcf3aef589bf3accfd5e5b37b4
Warning: Dest hash: 9cb63592d776bb163f426a8bb307ca01
...............................................................................
Finished  <<< moveit_chomp_optimizer_adapter                   [ 17.4 seconds ]
Starting  >>> moveit_ros_planning                                              
_______________________________________________________________________________
Errors     << moveit_ros_planning:make /home/parallels/src/moveit/logs/moveit_ros_planning/build.make.000.log
c++: internal compiler error: Killed (program cc1plus)
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-7/README.Bugs> for instructions.
make[2]: *** [planning_scene_monitor/CMakeFiles/demo_scene.dir/demos/demo_scene.cpp.o] Error 4
make[1]: *** [planning_scene_monitor/CMakeFiles/demo_scene.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [all] Error 2
cd /home/parallels/src/moveit/build/moveit_ros_planning; catkin build --get-env moveit_ros_planning | catkin env -si  /usr/bin/make --jobserver-fds=6,7 -j; cd -
...............................................................................
Failed     << moveit_ros_planning:make                         [ Exited with code 2 ]
Failed    <<< moveit_ros_planning                              [ 7 minutes and 7.3 seconds ]

and the log file:

Scanning dependencies of target moveit_kinematics_speed_and_validity_evaluator
[ 56%] Building CXX object planning_components_tools/CMakeFiles/moveit_kinematics_speed_and_validity_evaluator.dir/src/kinematics_speed_and_validity_evaluator.cpp.o
[ 58%] Linking CXX executable /home/parallels/src/moveit/devel/.private/moveit_ros_planning/lib/moveit_ros_planning/moveit_kinematics_speed_and_validity_evaluator
[ 58%] Built target moveit_kinematics_speed_and_validity_evaluator
[ 60%] Building CXX object planning_scene_monitor/CMakeFiles/moveit_planning_scene_monitor.dir/src/current_state_monitor.cpp.o
[ 62%] Building CXX object planning_scene_monitor/CMakeFiles/moveit_planning_scene_monitor.dir/src/trajectory_monitor.cpp.o
[ 63%] Linking CXX shared library /home/parallels/src/moveit/devel/.private/moveit_ros_planning/lib/libmoveit_planning_scene_monitor.so
[ 63%] Built target moveit_planning_scene_monitor
Scanning dependencies of target demo_scene
Scanning dependencies of target moveit_print_planning_scene_info
[ 67%] Building CXX object planning_scene_monitor/CMakeFiles/demo_scene.dir/demos/demo_scene.cpp.o
[ 67%] Building CXX object planning_components_tools/CMakeFiles/moveit_print_planning_scene_info.dir/src/print_planning_scene_info.cpp.o
c++: internal compiler error: Killed (program cc1plus)
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-7/README.Bugs> for instructions.
make[2]: *** [planning_scene_monitor/CMakeFiles/demo_scene.dir/demos/demo_scene.cpp.o] Error 4
planning_scene_monitor/CMakeFiles/demo_scene.dir/build.make:62: recipe for target 'planning_scene_monitor/CMakeFiles/demo_scene.dir/demos/demo_scene.cpp.o' failed
CMakeFiles/Makefile2:3362: recipe for target 'planning_scene_monitor/CMakeFiles/demo_scene.dir/all' failed
make[1]: *** [planning_scene_monitor/CMakeFiles/demo_scene.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
jbcpollak

comment created time in 23 days

issue openedros-planning/moveit_tutorials

Internal Compiler Error on Clean System install

Description

I have a brand new Ubuntu 18.04 system with Ros Melodic installed. Trying to follow the MoveIt! tutorial here (https://ros-planning.github.io/moveit_tutorials/doc/getting_started/getting_started.html) I get a GCC internal compiler error when running catkin build

Your environment

  • ROS Distro: Melodic
  • OS Version: Ubuntu 18.04
  • Binaries
  • If binary, which release version?

Looks like most moveit binary packages have the version 1.0.1-0bionic.20190320.191310 amd64

  • If source, which git commit or tag? The tutorial is at: git https://github.com/ros-planning/moveit_tutorials.git#adccd9ebf5f06b1de207310000501c54881b97b8

Steps to reproduce

Tell us how to reproduce this issue. Attempt to provide a working demo, perhaps using Docker.

Expected behaviour

Should build cleanly with catkin build

Backtrace or Console output

Scanning dependencies of target robot_model_and_robot_state_tutorial
Scanning dependencies of target ros_api_tutorial
[  3%] Building CXX object doc/kinematics/CMakeFiles/ros_api_tutorial.dir/src/ros_api_tutorial.cpp.o
[  7%] Building CXX object doc/robot_model_and_robot_state/CMakeFiles/robot_model_and_robot_state_tutorial.dir/src/robot_model_and_robot_state_tutorial.cpp.o
[ 10%] Linking CXX executable /home/parallels/src/moveit/devel/.private/moveit_tutorials/lib/moveit_tutorials/robot_model_and_robot_state_tutorial
[ 10%] Built target robot_model_and_robot_state_tutorial
Scanning dependencies of target planning_scene_tutorial
[ 14%] Building CXX object doc/planning_scene/CMakeFiles/planning_scene_tutorial.dir/src/planning_scene_tutorial.cpp.o
[ 17%] Linking CXX executable /home/parallels/src/moveit/devel/.private/moveit_tutorials/lib/moveit_tutorials/ros_api_tutorial
[ 17%] Built target ros_api_tutorial
Scanning dependencies of target planning_scene_ros_api_tutorial
[ 21%] Building CXX object doc/planning_scene_ros_api/CMakeFiles/planning_scene_ros_api_tutorial.dir/src/planning_scene_ros_api_tutorial.cpp.o
[ 25%] Linking CXX executable /home/parallels/src/moveit/devel/.private/moveit_tutorials/lib/moveit_tutorials/planning_scene_tutorial
[ 25%] Built target planning_scene_tutorial
Scanning dependencies of target motion_planning_api_tutorial
[ 28%] Building CXX object doc/motion_planning_api/CMakeFiles/motion_planning_api_tutorial.dir/src/motion_planning_api_tutorial.cpp.o
c++: internal compiler error: Killed (program cc1plus)
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-7/README.Bugs> for instructions.
doc/planning_scene_ros_api/CMakeFiles/planning_scene_ros_api_tutorial.dir/build.make:62: recipe for target 'doc/planning_scene_ros_api/CMakeFiles/planning_scene_ros_api_tutorial.dir/src/planning_scene_ros_api_tutorial.cpp.o' failed
make[2]: *** [doc/planning_scene_ros_api/CMakeFiles/planning_scene_ros_api_tutorial.dir/src/planning_scene_ros_api_tutorial.cpp.o] Error 4
CMakeFiles/Makefile2:4325: recipe for target 'doc/planning_scene_ros_api/CMakeFiles/planning_scene_ros_api_tutorial.dir/all' failed
make[1]: *** [doc/planning_scene_ros_api/CMakeFiles/planning_scene_ros_api_tutorial.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 32%] Linking CXX executable /home/parallels/src/moveit/devel/.private/moveit_tutorials/lib/moveit_tutorials/motion_planning_api_tutorial
[ 32%] Built target motion_planning_api_tutorial
Makefile:140: recipe for target 'all' failed
make: *** [all] Error 2

created time in 23 days

issue openedrsheldiii/KeyV2

Create a separate STL of just the text, for a double-shot color effect?

I was just wondering if it would be possible to generate a "positive" version of the inset text labels, in the exact same location as they negative/inset versions are. If that was possible, I think it would allow an FDM printer to create a two-color "double shot" effect keycap.

created time in a month

startedrsheldiii/KeyV2

started time in a month

push event6RiverSystems/blackboard

Joshua Chaitin-Pollak

commit sha e285ccab3e86139473b27a71f120d6e7b9a3b9f3

fix: OMG duh, changed the context

view details

push time in a month

push event6RiverSystems/blackboard

Joshua Chaitin-Pollak

commit sha 99d188ffa1d616aae9d6d85fc891c866206298a5

fix: removed ci_scripts

view details

push time in a month

Pull request review comment6RiverSystems/blackboard

Continued attempts to get new features to build in PR

 jobs:       - run:           name: Set NPM auth token           command: |-            npm config set //registry.npmjs.org/:_authToken "${NPM_TOKEN}"+            echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > ~/.npmrc

I think this is "less right" than the previous version, but I know both should work so it doesn't matter too much. I suspect _authToken is deprecated in npm, but it should still work for now.

ddurschlag6river

comment created time in a month

push event6RiverSystems/blackboard

Joshua Chaitin-Pollak

commit sha 596b81d2a9de8035ed41fddbe740e66b62451a41

fix: remove the submodule

view details

push time in a month

push event6RiverSystems/blackboard

Joshua Chaitin-Pollak

commit sha 9ca55c051d68323d6f6fd5104d6a82fba252dd42

fix: updated license

view details

push time in a month

push event6RiverSystems/blackboard

Joshua Chaitin-Pollak

commit sha eee9b45490f833f1b05e64c0370f800d2e67ea93

fix: set a license and allow public

view details

push time in a month

push event6RiverSystems/blackboard

Joshua Chaitin-Pollak

commit sha cdc7b8524693a4dce3a1346e056c8e1ea9a9e411

fix: try a different auth method

view details

push time in a month

push event6RiverSystems/blackboard

Joshua Chaitin-Pollak

commit sha 81b59f8398f1f02b423e77ad8cb7d8166bf3cdd6

Fix: try to get npmjs.com deployment working

view details

push time in a month

push event6RiverSystems/blackboard

Joshua Chaitin-Pollak

commit sha a968fb3d045519309b41d0f61fd57b4505d1924e

Publish to public repo

view details

push time in a month

issue commentkey-networks/ztncui-containerized

Cannot run without HTTPS errors (Error: ENOENT: no such file or directory, open 'etc/tls/fullchain.pem')

Hello, I got this working with a few tweaks as described above (changes here https://github.com/jbcpollak/ztncui-containerized) and I needed to manually setup the /etc directory with the needed storage and tls directories, and the passwd file.

Is it possible to use the zerotier-one instance running inside the container to get the docker host onto the ZT network?

jbcpollak

comment created time in a month

created tagjbcpollak/ztncui-containerized

tag1.2.8

A Docker image that contains ZeroTier One and ztncui to set up a standalone ZeroTier network controller with a web user interface in a container.

created time in a month

push eventjbcpollak/ztncui-containerized

Joshua Chaitin-Pollak

commit sha 52e55811ca8d60d7358f7ac0aa5e2fb8c0016424

version 1.2.8

view details

push time in a month

created tagjbcpollak/ztncui-containerized

tag1.2.7

A Docker image that contains ZeroTier One and ztncui to set up a standalone ZeroTier network controller with a web user interface in a container.

created time in a month

push eventjbcpollak/ztncui-containerized

Joshua Chaitin-Pollak

commit sha 15a4188014208a170d69394152b97e4f76041359

version 1.2.7

view details

push time in a month

created tagjbcpollak/ztncui-containerized

tag1.2.6

A Docker image that contains ZeroTier One and ztncui to set up a standalone ZeroTier network controller with a web user interface in a container.

created time in a month

push eventjbcpollak/ztncui-containerized

Joshua Chaitin-Pollak

commit sha da4e99623e6a801a32905a9586084bfa0b387e69

version 1.2.6

view details

push time in a month

created tagjbcpollak/ztncui-containerized

tag1.2.5

A Docker image that contains ZeroTier One and ztncui to set up a standalone ZeroTier network controller with a web user interface in a container.

created time in a month

push eventjbcpollak/ztncui-containerized

Joshua Chaitin-Pollak

commit sha 13acf25c795437b37ecaafd456ef425c294d40a2

version 1.2.5

view details

push time in a month

created tagjbcpollak/ztncui-containerized

tag1.2.4

A Docker image that contains ZeroTier One and ztncui to set up a standalone ZeroTier network controller with a web user interface in a container.

created time in a month

push eventjbcpollak/ztncui-containerized

Joshua Chaitin-Pollak

commit sha 1884190a17817679fe836789b01f3865b1b764f3

version 1.2.4

view details

push time in a month

created tagjbcpollak/ztncui-containerized

tag1.2.3

A Docker image that contains ZeroTier One and ztncui to set up a standalone ZeroTier network controller with a web user interface in a container.

created time in a month

push eventjbcpollak/ztncui-containerized

Joshua Chaitin-Pollak

commit sha ef5c42c03aa62208c47e761d45a349ada4b943ab

version 1.2.3

view details

push time in a month

fork jbcpollak/ztncui-containerized

A Docker image that contains ZeroTier One and ztncui to set up a standalone ZeroTier network controller with a web user interface in a container.

fork in a month

issue commentkey-networks/ztncui-containerized

Cannot run without HTTPS errors (Error: ENOENT: no such file or directory, open 'etc/tls/fullchain.pem')

@key-networks - sorry, I wasn't expecting you had a Synology, I was more wondering if there was a way to configure the docker container to disable HTTPS entirely so it wouldn't try and listen with encryption.

IE, I didn't see a way to do (effectively) HTTPS_ENABLED=false via the container.

That should solve my problem.

About sudo, could the shell script be extended to sudo/or not based on an environment variable?

jbcpollak

comment created time in a month

issue openedkey-networks/ztncui-containerized

Cannot run without HTTPS errors (Error: ENOENT: no such file or directory, open 'etc/tls/fullchain.pem')

Hello,

I'm trying to run the container on an Intel-based Synology with Docker installed. When I try and run it I originally was getting errors about not having permissions to write to the mapped ztncui directory, until I gave that directory read/write permissions for everyone. I think this is because the docker images executes sudo -u ztncui but that user doesn't exist on the host system. I'm not even sure what that user id should be.

After I granted global write permissions, I got the error Error: ENOENT: no such file or directory, open 'etc/tls/fullchain.pem'. I want to run HTTP-only in the container, and then use the Synology to do HTTPS reverse proxy, but it seems like the container can't support that?

created time in 2 months

Pull request review comment6RiverSystems/blueshell

feat: new nodes -- Predicate, SideEffect, and Success

+import {BlueshellState} from './BlueshellState';+import {Base} from './Base';+import {resultCodes as rc} from '../utils/resultCodes';++export class Success<S extends BlueshellState, E> extends Base<S, E> {+	constructor(+		name = `Success`

Why are there backticks here?

ddurschlag6river

comment created time in 2 months

delete tag 6RiverSystems/blueshell

delete tag : v2.0.0

delete time in 2 months

delete tag 6RiverSystems/blueshell

delete tag : v1.5.1

delete time in 2 months

delete branch 6RiverSystems/blueshell

delete branch : async_and_ResultCode

delete time in 2 months

push event6RiverSystems/blueshell

Joshua Chaitin-Pollak

commit sha ee7da7f323d1dd4639d2e5b9b4a6957361dabd16

fix: hey its in Typescript now.

view details

push time in 2 months

created tag6RiverSystems/blueshell

tagv2.0.0

Blueshell is a Promise-based Behavior Tree implementation using modern ES6 syntax.

created time in 2 months

push event6RiverSystems/blueshell

Joshua Chaitin-Pollak

commit sha 939610865c4105ecc05734416becfc0d2c5c418c

BREAKING CHANGE: Blueshell is now synchronous

view details

Joshua Chaitin-Pollak

commit sha d95e68c4825a8cd598a82e2ab49d6fbd34039f7f

BREAKING CHANGE: Blueshell is now synchronous BREAKING CHANGE: Blueshell is now synchronous

view details

push time in 2 months

create barnch6RiverSystems/blueshell

branch : force-bc

created branch time in 2 months

push event6RiverSystems/blueshell

Joshua Chaitin-Pollak

commit sha bf68ad3501fc683df3d883fafe176f5a3fd40aa8

feat: BREAKING CHANGES: Removed all usage of Promises to make completely synchronous

view details

Joshua Chaitin-Pollak

commit sha 652205bedaa0f1c275b815b7d6eb9f07ff7c2be4

Merge remote-tracking branch 'origin/develop' into feat/synchronous * origin/develop: (21 commits) chore: adds assertion for valid DOT generation FS-4407 fix: fixes parsing bugs of DOT FS-4407 fix: changes output of mochafile fix: kick build pt II fix: uses fix, resets location of .npmrc chore: changes location of .npmrc chore: kick build chore: adds command to set npm authtoken in publish step chore: migrate to circleci version 2 FS-4878 fix: build fix: pr feedback chore: updates node_version to match wfm fix: renaming of variables FS-4407 fix: removes unused lodash dep. fix: node id implementation. pulls out default settings to reduce total size. feat: refactors unicode symbol into classes. feat: reduces number of Node Shapes. Utilizes Symbols for types. feat: Completes Dot serialization. Refactors render tree, moves Archy to own file. Adds tests. TODO(TCA): Live visualization of the serialized output. feat: outputs nodes into Dot language. TODO: add verticies. feat: Adds JSDocs. ... # Conflicts: # lib/nodes/Base.ts # lib/nodes/Composite.ts # lib/nodes/Decorator.ts # lib/nodes/Selector.ts # lib/nodes/Sequence.ts # lib/nodes/decorators/Not.ts # lib/nodes/decorators/RepeatWhen.ts # test/utils/renderTree.test.ts

view details

Joshua Chaitin-Pollak

commit sha a46976e6ecb17b39ef53927f3eaa0710adfd0252

Merge remote-tracking branch 'origin/master' into feat/synchronous * origin/master: fix: code review feedback fix: update TS version for Required<T> and other goodies fix: re-order and rename tests fix: remove leaked debugging code feat: new optional contextDepth for archy renderer # Conflicts: # lib/utils/archyTree.ts # package-lock.json # package.json

view details

Joshua Chaitin-Pollak

commit sha b485bf55de4708d1b6c0fa3873f2959d0796b554

fix: Removed useless undefined

view details

Joshua Chaitin-Pollak

commit sha 4a86a1de562dc5d82003750b3a4be92b14a07bce

Fix: applied David’s ResultCode type safety to the synchronous implementation Also updated commitment rules

view details

Joshua Chaitin-Pollak

commit sha 0b7d17de5bd129c1cf76743668134a1a0ff4a5df

fix: export result codes

view details

Joshua Chaitin-Pollak

commit sha 6443c911f700007c5cffda08951d4e085cac1d73

fix: explicitly disable latching to be safe

view details

Joshua Chaitin-Pollak

commit sha b0135f886282a02a9739f4140f586b13669e3721

BREAKING CHANGE: Blueshell is now synchronous

view details

push time in 2 months

delete branch 6RiverSystems/blueshell

delete branch : feat/synchronous

delete time in 2 months

push event6RiverSystems/blueshell

Joshua Chaitin-Pollak

commit sha 6443c911f700007c5cffda08951d4e085cac1d73

fix: explicitly disable latching to be safe

view details

push time in 2 months

Pull request review comment6RiverSystems/blueshell

BREAKING CHANGE: Blueshell is now synchronous

 export class Decorator<S extends BlueshellState, E> extends Composite<S, E> { 	 * @param state 	 * @param event 	 */-	onEvent(state: S, event: E): string|Promise<string> {+	handleChild(state: S, event: E): ResultCode {

Decorators aren't latched, so I think this is a pretty safe change. If it would make you feel better, we can explicitly set latched = false in Decorator.ts

jbcpollak

comment created time in 2 months

pull request comment6RiverSystems/blueshell

BREAKING CHANGE: Blueshell is now synchronous

Do we want to tackle the base/decorator/composite/sequence etc. issues in this as well?

Short answer: No.

I want to get the BS tree to synchronous ASAP because that is a source of major bugs. I'm happy to iterate and continue to improve, but I want this epic done and closed.

jbcpollak

comment created time in 2 months

pull request comment6RiverSystems/blueshell

fix: updates node version in circle.yml to match .node-version

this was for circleci 1, but we've upgraded to 2.

Shockolate

comment created time in 2 months

pull request comment6RiverSystems/blueshell

Async and result code

I recommend closing the PR in favor of https://github.com/6RiverSystems/blueshell/pull/94, I pulled the ResultCode changes into that PR.

ddurschlag6river

comment created time in 2 months

push event6RiverSystems/blueshell

Joshua Chaitin-Pollak

commit sha 0b7d17de5bd129c1cf76743668134a1a0ff4a5df

fix: export result codes

view details

push time in 2 months

push event6RiverSystems/blueshell

Joshua Chaitin-Pollak

commit sha 4a86a1de562dc5d82003750b3a4be92b14a07bce

Fix: applied David’s ResultCode type safety to the synchronous implementation Also updated commitment rules

view details

push time in 2 months

push event6RiverSystems/blueshell

Joshua Chaitin-Pollak

commit sha b485bf55de4708d1b6c0fa3873f2959d0796b554

fix: Removed useless undefined

view details

push time in 2 months

push event6RiverSystems/blueshell

Joshua Chaitin-Pollak

commit sha 8a6a7e39d0401b8d5daf4a81cc03d54327a62827

Merge pull request #17 from 6RiverSystems/develop build status, readme fix

view details

Joshua Chaitin-Pollak

commit sha 3780bf80038b5debdb1176d282969ed6ed2d6427

Merge pull request #24 from 6RiverSystems/develop Release 0.2.0

view details

Joshua Chaitin-Pollak

commit sha f1412397f2e8133254f4a4ed564626bae12600a2

Merge pull request #26 from 6RiverSystems/develop Release renderTree.toConsole() and coverage tests

view details

Joshua Chaitin-Pollak

commit sha 2e6daac308573aca3e22fe472c7013fb2a8d681d

Merge pull request #28 from 6RiverSystems/develop release v0.2.2

view details

Joshua Chaitin-Pollak

commit sha f98eb065cfd7eb53f3f0722c3eadafb5a20afc87

Merge pull request #43 from 6RiverSystems/develop Release 1.0.0-beta.1

view details

Joshua Chaitin-Pollak

commit sha e75638a7a9e8f703db2d52164db4f0100fdfff8c

Merge pull request #68 from 6RiverSystems/develop major update

view details

Joshua Chaitin-Pollak

commit sha 90a46e5923436abe0f90654b478102cdbdabdf97

feat: result swap name now included child name as portion

view details

Joshua Chaitin-Pollak

commit sha 06f4dac995f12d04f045ab539d41557e26a2895f

bc: Release Typescript Port

view details

Ted Armstrong

commit sha c0fdd666b844466e1d9a08912399ea813ba74cef

Merge pull request #83 from 6RiverSystems/develop 1 October 2018 Release

view details

Tony Gaetani

commit sha 2ddda1084cf0cd767dea2073ce209b5d2f4ef817

fix: nothing (#85) Merge pull request #85 from 6RiverSystems/develop

view details

Ted Armstrong

commit sha 44fdf3a1993d998b971f8bbf5840d24488f4e479

Merge pull request #89 from 6RiverSystems/develop 2018-10-10 Release

view details

David Durschlag

commit sha 002ccb55792cae6d03d6d285e0101aec933d0795

feat: new optional contextDepth for archy renderer

view details

David Durschlag

commit sha 77095fb3f488068470fda1d49815097631304792

fix: remove leaked debugging code

view details

David Durschlag

commit sha e6c0647ebec77a78cd40c56009265cdac9c585ca

fix: re-order and rename tests

view details

David Durschlag

commit sha 165cbc3e8885568a7765da102b4644ed136eb0bc

fix: update TS version for Required<T> and other goodies

view details

David Durschlag

commit sha b6b162f39d04943248049f6720411fb8f3f86a66

fix: code review feedback

view details

David Durschlag

commit sha 56e91ce6324aa55f3b58b5af7df0ba03c5af1409

Merge pull request #92 from 6RiverSystems/archyContextDepth feat: new optional contextDepth for archy renderer

view details

David Durschlag

commit sha 0f8489e09b5263b2507e71bf9550d7aad8cd1eac

Merge pull request #93 from 6RiverSystems/develop Do the release!

view details

Joshua Chaitin-Pollak

commit sha a46976e6ecb17b39ef53927f3eaa0710adfd0252

Merge remote-tracking branch 'origin/master' into feat/synchronous * origin/master: fix: code review feedback fix: update TS version for Required<T> and other goodies fix: re-order and rename tests fix: remove leaked debugging code feat: new optional contextDepth for archy renderer # Conflicts: # lib/utils/archyTree.ts # package-lock.json # package.json

view details

push time in 2 months

push event6RiverSystems/blueshell

kolach

commit sha f879273b64819c4306b8c01d45901666d0ffbfbb

feat: add sources to the package

view details

Joshua Chaitin-Pollak

commit sha 8faf02e726eb79397fc3e08aa7465d474a6ce1d3

feat: add sources to the package

view details

Shockolate

commit sha a96020227bc08cafbdeac21fdaa199cfcad56239

feat: Adds JSDocs.

view details

Joshua Chaitin-Pollak

commit sha 17d23f8ba95a3b89cc66bd5dc4bcc0f281d0c961

feat: Adds JSDocs.

view details

Ted Armstrong

commit sha b0fd77e9add775c80fd0bd78e8f4444a654922eb

feat: outputs nodes into Dot language. TODO: add verticies.

view details

Shockolate

commit sha 87c464da394b210db45b21e76a592708fdd9d10b

feat: Completes Dot serialization. Refactors render tree, moves Archy to own file. Adds tests. TODO(TCA): Live visualization of the serialized output.

view details

Shockolate

commit sha 7d063df81c62ec7c3a6987424600ec6b656d844c

feat: reduces number of Node Shapes. Utilizes Symbols for types.

view details

Shockolate

commit sha 295fa5e72c38fa296faf101cfd6ea8828ca5ab9c

feat: refactors unicode symbol into classes.

view details

Shockolate

commit sha a87a20cbd0a922de2e6679a134ac81396418b951

fix: node id implementation. pulls out default settings to reduce total size.

view details

Shockolate

commit sha 5bba31f6ca8bb788928f7e75fb089e072d25c9e1

fix: removes unused lodash dep.

view details

Joshua Chaitin-Pollak

commit sha 0aecddf4b4d2e9972e0b0634c148d91dbab45441

Feat: graphviz tree view

view details

Shockolate

commit sha ba6c747050be4ee88d6a7ab378da68deb8482907

fix: renaming of variables FS-4407

view details

Shockolate

commit sha 84e03d96cc766b5c7939548b52fe7bdb764734d9

chore: updates node_version to match wfm

view details

Shockolate

commit sha 2e01f3119bd9ea4f7ae841b106d03c2c3d52468c

fix: pr feedback

view details

Ted Armstrong

commit sha c41e87ad5415954f68e1d74aca6371377ad6c7c5

Merge pull request #82 from 6RiverSystems/feat/graphviz Feat/graphviz

view details

Tony Gaetani

commit sha 439575bc2a9d719aeacef9083d8a0b9c95400a5c

fix: build

view details

Ted Armstrong

commit sha b1391305a47b95e026cb6e1ede4eb03eacfc27d2

Merge pull request #84 from 6RiverSystems/fix/nothing fix: build

view details

Shockolate

commit sha da6d313abe94f4ca5cceec4ca12446399bb9720b

chore: migrate to circleci version 2 FS-4878

view details

Shockolate

commit sha dcead24441248abe8f200103de32b59a515c42f4

chore: adds command to set npm authtoken in publish step

view details

Shockolate

commit sha 9400928eccbe1d80a4af2f1420aecc6d7bbcae8c

chore: kick build

view details

push time in 2 months

delete tag 6RiverSystems/blueshell

delete tag : v1.5.0-archyContextDepth.1

delete time in 2 months

Pull request review comment6RiverSystems/blueshell

feat: new optional contextDepth for archy renderer

 import {BlueshellState} from '../nodes/BlueshellState'; import {serializeArchyTree} from './archyTree'; import {serializeDotTree} from './dotTree'; -export function toString<S extends BlueshellState, E>(tree: Base<S, E>, state?: S): string {-	return serializeArchyTree(tree, state);+export function toString<S extends BlueshellState, E>(+	tree: Base<S, E>, state?: S, contextDepth = Number.MAX_SAFE_INTEGER

what about using contextDepth?: number so that the default only needs to be set in one place?

ddurschlag6river

comment created time in 2 months

Pull request review comment6RiverSystems/blueshell

feat: new optional contextDepth for archy renderer

 import {BlueshellState} from '../nodes/BlueshellState'; import * as archy from 'archy'; import {Data} from 'archy'; -function buildArchyTree<S extends BlueshellState, E>(node: Base<S, E>, state?: S): Data {+function buildArchyTree<S extends BlueshellState, E>(+	node: Base<S, E>, state?: S, contextDepth = Number.MAX_SAFE_INTEGER+): Required<Data>|undefined {+	let label = node.name; -	let nodeLabel = node.name;--	if (nodeLabel !== node.constructor.name) {-		nodeLabel += ' (' + node.constructor.name + ')';+	if (label !== node.constructor.name) {+		label += ' (' + node.constructor.name + ')'; 	} +	let onPath = false;+ 	if (state) {-		let eventCounter = node.getTreeEventCounter(state);-		let lastEventSeen = node.getLastEventSeen(state);-		let lastResult = node.getLastResult(state);+		const eventCounter = node.getTreeEventCounter(state);+		const lastEventSeen = node.getLastEventSeen(state);+		const lastResult = node.getLastResult(state);  		if (lastEventSeen === eventCounter && lastResult) {-			nodeLabel += ' => ' + lastResult;+			label += ' => ' + lastResult;+			onPath = true;+		}+	}++	if (!onPath) {+		if (contextDepth < 0) {+			return undefined; 		} +		if (contextDepth === 0) {+			return {+				label: '...',+				nodes: [],+			};+		} 	} -	const archyTree = {-		label: nodeLabel,-		nodes: new Array<Data | string>(),-	};+	const nodes = [];  	if ((<any>node).children) {-		for (let child of (<any>node).children) {-			archyTree.nodes.push(buildArchyTree(<Base<S,E>>child, state));+		for (const child of (<any>node).children) {+			const subTree = buildArchyTree(<Base<S, E>>child, state, contextDepth - (onPath ? 0 : 1));+			if (subTree) {+				nodes.push(subTree);+			} 		} 	} -	return archyTree;+	return {+		label,+		nodes,+	}; } -export function serializeArchyTree<S extends BlueshellState, E>(tree: Base<S, E>, state?: S): string {-	const archyTree = buildArchyTree(tree, state);-	return archy(archyTree);+export function serializeArchyTree<S extends BlueshellState, E>(+	tree: Base<S, E>, state?: S, contextDepth = Number.MAX_SAFE_INTEGER+): string {+	const archyTree = buildArchyTree(tree, state, contextDepth);+	if ( archyTree ) {

shouldn't have spaces here, did the linter not catch that?

ddurschlag6river

comment created time in 2 months

Pull request review comment6RiverSystems/blueshell

feat: new optional contextDepth for archy renderer

 import {BlueshellState} from '../nodes/BlueshellState'; import * as archy from 'archy'; import {Data} from 'archy'; -function buildArchyTree<S extends BlueshellState, E>(node: Base<S, E>, state?: S): Data {+function buildArchyTree<S extends BlueshellState, E>(+	node: Base<S, E>, state?: S, contextDepth = Number.MAX_SAFE_INTEGER+): Required<Data>|undefined {+	let label = node.name; -	let nodeLabel = node.name;--	if (nodeLabel !== node.constructor.name) {-		nodeLabel += ' (' + node.constructor.name + ')';+	if (label !== node.constructor.name) {+		label += ' (' + node.constructor.name + ')'; 	} +	let onPath = false;+ 	if (state) {-		let eventCounter = node.getTreeEventCounter(state);-		let lastEventSeen = node.getLastEventSeen(state);-		let lastResult = node.getLastResult(state);+		const eventCounter = node.getTreeEventCounter(state);+		const lastEventSeen = node.getLastEventSeen(state);+		const lastResult = node.getLastResult(state);  		if (lastEventSeen === eventCounter && lastResult) {-			nodeLabel += ' => ' + lastResult;+			label += ' => ' + lastResult;+			onPath = true;+		}+	}++	if (!onPath) {+		if (contextDepth < 0) {+			return undefined; 		} +		if (contextDepth === 0) {+			return {+				label: '...',+				nodes: [],+			};+		} 	} -	const archyTree = {-		label: nodeLabel,-		nodes: new Array<Data | string>(),-	};+	const nodes = [];  	if ((<any>node).children) {-		for (let child of (<any>node).children) {-			archyTree.nodes.push(buildArchyTree(<Base<S,E>>child, state));+		for (const child of (<any>node).children) {+			const subTree = buildArchyTree(<Base<S, E>>child, state, contextDepth - (onPath ? 0 : 1));

I would split the contextDepth calculation in't its own const declaration for clarity and to add a comment to describe the logic.

ddurschlag6river

comment created time in 2 months

Pull request review comment6RiverSystems/blueshell

feat: new optional contextDepth for archy renderer

 import {BlueshellState} from '../nodes/BlueshellState'; import * as archy from 'archy'; import {Data} from 'archy'; -function buildArchyTree<S extends BlueshellState, E>(node: Base<S, E>, state?: S): Data {+function buildArchyTree<S extends BlueshellState, E>(+	node: Base<S, E>, state?: S, contextDepth = Number.MAX_SAFE_INTEGER

does this function need a default contextDepth? Its not exported and is only accessed by serializeArchyTree()

ddurschlag6river

comment created time in 2 months

pull request comment6RiverSystems/blueshell

Async and result code

@ddurschlag6river - I'm all for the ResultCode change - I wouldn't bother with the async since async operation is deprecated - see feat/synchronous - we are probably pretty close to merging that (and making a breaking change to the API) - as soon as the WFM is done with promises, which it should be by now.

ddurschlag6river

comment created time in 2 months

delete branch 6RiverSystems/eslint-config-6river

delete branch : develop

delete time in 2 months

startedResilient-Labs/Alumni-Learning-Plan

started time in 3 months

pull request commentRizelBobb/Clock

Update README.md

👍 I was going to propose the same PR.

mlncn

comment created time in 3 months

more