profile
viewpoint
Jarvis Luong jarvisluong Helsinki, Finland https://www.techynovice.com/ Obsessed with new technologies.

jarvisluong/react-native-picker-js 8

React Native Picker (Pure JS variation), suitable for expo and CRNA apps

jarvisluong/react-native 1

A framework for building native apps with React.

18yolol/UInglish 0

Cách học tiếng Anh nào phù hợp với bạn nhất?

jarvisluong/android-use-libev 0

use libev library in android jni

jarvisluong/animated-switch 0

A switch navigator but with transitions between screens powered by the react-native-reanimated Transitions API

jarvisluong/coding-interview-university 0

A complete computer science study plan to become a software engineer.

jarvisluong/data-structure-and-algorithm-projects 0

This is my university projects in the course Data Structure and Algorithm.

issue openedish-app/ish

Cannot install oh-my-fish

curl -L https://get.oh-my.fish | fish % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 0 0 0 0 0 0 100 194 100 194 0 0 219 0 --:--:-- --:--:-- --:--:-- 219 0 0 0 0 0 0 0 100 19035 100 19035 0 0 9781 0 0:00:01 0:00:01 --:--:-- 43758 Checking for a sane environment... Failed to execute process '/usr/bin/env'. Reason: exec: unknown error (errno was 22) Install aborted: /bin/busybox is not a sane 'head' implementation

When I run dmesg I got this:

dmesg | tail 8 stub syscall 375 51 stub syscall 375

created time in a day

startedBearer/Pizzly

started time in 3 days

startedzhlynn/zsign

started time in 9 days

startedfastai/fastmac

started time in 12 days

startedFLEXTool/FLEX

started time in 12 days

startedwulkano/Kap

started time in 15 days

startedosamaq/reactnative-fastlane-appcenter

started time in 17 days

startedmicrosoft/fastlane-plugin-appcenter

started time in 17 days

starteduna/CSSgram

started time in 17 days

startediyegoroff/react-native-image-filter-kit

started time in 17 days

issue closedexpo/expo

[expo-media-library] properly handle iOS's slow motion videos

🐛 Bug Report

Currently when calling MediaLibrary.getAssetInfoAsync with a slow motion video from iOS will crash with this message:

-[AVComposition URL]: unrecognized selector sent to instance

This is because we are force casting this line:

https://github.com/expo/expo/blob/8fa0b005b391412fd4ee6e429646dd7a45892e71/packages/expo-media-library/ios/EXMediaLibrary/EXMediaLibrary.m#L425

while requestAVAssetForVideo: can also return an AVComposition (as both AVURLAsset and AVComposition is subclasses of AVAsset). AVComposition will need a special care to get the local uri.

One such solution can be found here: https://overflow.buffer.com/2016/02/29/slow-motion-video-ios/

Will make a PR for this soon!

closed time in 21 days

jarvisluong

startednpalm/terraform-aws-gitlab-runner

started time in 22 days

create barnchjarvisluong/luxidoor-bot

branch : master

created branch time in 24 days

created repositoryjarvisluong/luxidoor-bot

created time in 24 days

push eventreactrondev/demo-react-native-debugger

Jarvis Luong

commit sha eecd7fd545da4b25b636205f40066d0fa492bbbf

add .data

view details

push time in a month

push eventreactrondev/demo-react-native-debugger

Jarvis Luong

commit sha 8ca51816640ac46812b229161c0461067117971e

show more prominent error

view details

push time in a month

push eventreactrondev/demo-react-native-debugger

Jarvis Luong

commit sha b49de6be31ebaec4600dce95af5b5df8373a88fc

better display stuff

view details

push time in a month

push eventreactrondev/demo-react-native-debugger

Jarvis Luong

commit sha 3e586b083d2ad545092a08cb2fb898a3f426aec8

correct path

view details

push time in a month

create barnchreactrondev/demo-react-native-debugger

branch : network-call-better

created branch time in a month

push eventreactrondev/demo-react-native-debugger

Jarvis Luong

commit sha dfd9ce674fd0b690db063079ddc15b406d28baf4

add more variables to inspect

view details

push time in a month

push eventreactrondev/demo-react-native-debugger

Jarvis Luong

commit sha 43cf2300d60c9dcc1e38a40a0323a6cada918103

use broken network call

view details

push time in a month

delete branch reactrondev/demo-react-native-debugger

delete branch : master

delete time in a month

create barnchreactrondev/demo-react-native-debugger

branch : network-call

created branch time in a month

create barnchreactrondev/demo-react-native-debugger

branch : master

created branch time in a month

create barnchreactrondev/demo-react-native-debugger

branch : callstack

created branch time in a month

created repositoryreactrondev/demo-react-native-debugger

created time in a month

startedapproov/react-native-cert-pinner

started time in a month

startedmultiarch/crossbuild

started time in a month

startedmstorsjo/xcode-cross

started time in a month

startedgodotengine/build-containers

started time in a month

startedtpoechtrager/osxcross

started time in a month

startedkholia/OSX-KVM

started time in a month

startedraspberrypi/noobs

started time in a month

startedreact-native-community/voice

started time in a month

startedalias-rahil/handwritten.js

started time in a month

startedutmapp/UTM

started time in a month

push eventreactrondev/docker-gmsaas

Jarvis Luong

commit sha 50c664321195ee5d42453f70f181fc22a7ec50e4

update readme

view details

push time in a month

startedismaeldcom/react-native-build-config

started time in a month

startedksensehq/eventnative

started time in a month

issue closedreactrondev/react-native-web-swiper

When used with react-navigation undefineds createMaterialTopTabNavigator

When used with react-navigation undefineds createMaterialTopTabNavigator. there is a strange phenomenon when sliding, which first responds to TopTabNavigator, and causes the sliding page to be stuck in half.

closed time in 2 months

afeichuanqi

issue commentreactrondev/react-native-web-swiper

When used with react-navigation undefineds createMaterialTopTabNavigator

It seems that the issue is stale so I will close this one

afeichuanqi

comment created time in 2 months

pull request commentexpo/expo

[expo-keep-awake] Add web implementation for expo-keep-awake

@EvanBacon Hi! Any updates on this PR? (Sorry for disturbing 😬)

jarvisluong

comment created time in 2 months

starteddavesters/rn-native-mqtt

started time in 2 months

pull request commentexpo/expo

[expo-gl-cpp] Rewrite of expo-gl-cpp

Does this mean now on master branch, expo-gl should work with Hermes engine?

wkozyra95

comment created time in 2 months

startedCiphey/Ciphey

started time in 2 months

startedfelixrieseberg/macintosh.js

started time in 2 months

issue commentwix/Detox

Using @react-native-community/masked-view will prevent Detox to run tests

Just ran into this one as well. @jarvisluong did you manage to find any temporary workaround? I see you're a few weeks ahead of me :)

Basically I'm having a dummy implementation for masked view and during the test phase, the original MaskedView is replaced with the dummy implementation 😄

jarvisluong

comment created time in 2 months

startedcallstack/haul

started time in 2 months

startedcallstack/react-native-brownfield

started time in 2 months

push eventjarvisluong/expo

Jarvis Luong

commit sha 7d024cd0500c8701b0491cb7d31f524c9dfb9d43

add remaining build output

view details

push time in 2 months

push eventjarvisluong/expo

Jarvis Luong

commit sha 1f4341aa38add735d15ff4456e6081e07debe010

push js build output

view details

push time in 2 months

push eventjarvisluong/expo

Jarvis Luong

commit sha 56dafa877f5dcc1feaa243e62ced1ba0d862ff7a

update changelog

view details

push time in 2 months

push eventjarvisluong/expo

Jarvis Luong

commit sha f8cf1e3ecb442acb4399453e24d894ee3133bdea

update docs for keep-awake

view details

push time in 2 months

push eventjarvisluong/expo

Jarvis Luong

commit sha 570a29c6ad21385afd7028345522dd6919716920

[expo-keep-awake] export isAvailableAsync

view details

push time in 2 months

push eventjarvisluong/expo

Jarvis Luong

commit sha 83ae18c384b89ae61ae187a2e4306fd5a42531c6

[expo-keep-awake] reorder exported items

view details

push time in 2 months

push eventjarvisluong/expo

Michał Czernek

commit sha b5532de34bff7377f457da11e4f39871bb2e5402

[expo-module-template] Add unit tests in android module template.

view details

Tomasz Sapeta

commit sha d56ff1c899b2114190616f8506433e74cd082098

[et] Move UpdateVersions from xdl to expotools (#9336) # Why Part of https://github.com/expo/expo-cli/issues/2282 # How Moved some functionality of xdl's UpdateVersions to expotools and refactored `et client-build` command a little bit. # Test Plan Tested with `et client-build -p ios --release --skip-upload`, will test Android soon

view details

Hein Rutjes

commit sha 9cc1201b7b2011791c36aaaebe917eaa8a7695be

[expo-av] Fix onReadyForDisplay not emitted for HLS streams/m3u8 files on iOS (#9443) * [test] Add onReadyForDisplay test for HLS streams * [expo-av] Fix onReadyForDisplay not emitted on HSL streams * [test] Update onReadyForDisplay test for HSL streams * [ncl] Revert test changes * [expo-av] Update changelog

view details

Jarvis Luong

commit sha b326bbef3d1eee2f492bbb94821d88470f78c477

[media-library] add options for getAssetInfoAsync (#9405) # Why This is an enhanced PR from #8800 # How I added `options` as the optional second parameter to `MediaLibrary.getAssetInfoAsync`. # Test Plan Currently I modified `MediaDetailsScreen` in bare-expo app with payload of `shouldDownloadFromNetwork` to `false` so that the response payload also contains the field `isNetworkAsset`. # Open question Since this changes the public API of `MediaLibrary`, I wonder how should I update the bare-expo app to reflect this option?

view details

Tomasz Sapeta

commit sha f91c6bb8b27798f6adc2747b536a9974e413b3a2

[location] Improve and refactor Geocoding API (#9444) # Why Messy code. # How - `geocodeAsync` and `reverseGeocodeAsync` now always use native implementations by default and don't fall back to Google Maps API (it's been causing some mess and inconsistent results on Android). - Since we still need Google Maps API implementation (for Web) I added such possibility to use it on other platforms as well with the new `useGoogleMaps` option. - Added `district`, `subregion` and `timezone` fields to geocoded address object. - Fixed `LocationGeocodedAddress` type to reflect the possibility of receiving `null` values. - Added more TSDoc comments. - Refactored `GeocodingScreen` in NCL. # Test Plan Tested NCL examples in the new Geocoding screen on iOS and Android ✅ Went through test-suite tests ✅

view details

Tomasz Sapeta

commit sha 72de77b94403abba70dff9ac720991b2c522a9a0

Publish packages expo-av@8.4.1 expo-linear-gradient@8.2.2 expo-media-library@8.5.0 expo-notifications@0.6.0 expo-speech@8.3.0 expo-sqlite@8.3.0 expo-web-browser@8.4.0

view details

Cedric van Putten

commit sha c364d88df6fce80abca47c6166d25bd6cb50d068

[docs] Reuse versioned path when switching versions (#9397) * [docs] Reuse versioned path when switching versions * [docs] Fix supported versions and redirect to root api reference * [docs] Update comment about not checking page when switching versions * [docs] Fix typo in error handling comment Co-authored-by: Brent Vatne <brentvatne@gmail.com> * [docs] Add message when switching versions fails to reuse same page * [docs] Simplify failed versioned redirect notification Co-authored-by: Brent Vatne <brentvatne@gmail.com>

view details

Cedric van Putten

commit sha 63f388bed1978890a2e57dab03c0871c6643c706

[docs] Add babel cache to workflow cache (#9449) * [docs] Add babel cache to workflow cache * [docs] Fix cache paths in workflow * [docs] Use proper path when calculating cache hashes * [docs] Only cache babel for same dependencies and common files

view details

Cedric van Putten

commit sha 90372a082b3930e6f0352063dfa25d24230fd203

[docs] Fix removed version from render method (#9479)

view details

Brent Vatne

commit sha 58785f00ed7a479a5fc2c94261eb25f187e19b7f

[docs] Add new "unlisted" section for preview features (#9480)

view details

Evan Bacon

commit sha 58d4e7835d67476638fdcd6b181e059e786070e2

Use community async storage and fix tests (#9481)

view details

Evan Bacon

commit sha 5d3a41b56c524f2f6a42ab7de57f2f8bb2b61144

Use UIKit header transition (#9483)

view details

Brent Vatne

commit sha 2bd9458ded3893664c883b238df44f8d9dee60f1

[templates] Add xcworkspace and build directories to .npmignore

view details

Evan Bacon

commit sha 8b9cba7eb598574e587abbab58f500436db9996d

[home][chore] Convert redux to TypeScript (#9465) * Convert redux to TypeScript * Update Hooks.ts * Update Hooks.ts * fix IRecord * Updated types * Migrate App root component to TypeScript + hooks * Improve typing * Fix test mocking * default to no-preference theme

view details

Michał Czernek

commit sha d40fb974f9c6310011e69e0bcf375725362c2458

@mczernek/notifications suspended after 5 minutes (#9287)

view details

Łukasz Kosmaty

commit sha ae0f22724dd171ce1037b68a341fb05c1db5e56b

[expo-notifications] Remove deprecated GCM (#9475) # Why Maybe fixes https://github.com/expo/expo/issues/8250. # How According to the https://developers.google.com/cloud-messaging/android/android-migrate-fcm, Google Cloud Messaging was removed. For some, reason if you send notification via FCM API when your app is closed and you send a remote message with the `notification` key. # Test Plan - send notification using FCM ✅

view details

Rodolfo

commit sha 39c02457e6324b5a00b2d572a8062bbb28cbd3e8

[expo-splash-screen] Fix crash while re-adding splash view (#9451) Remove splashScreenView from parentView if it's already added.

view details

Hein Rutjes

commit sha 8c836cb1d1b1cb732a71e705e5217670f6331884

[tools] Add `bundler install` instruction for expotools (#9388)

view details

Cedric van Putten

commit sha 869a5e77ecb70e330a3c6f700528901a3413e0f0

[docs] Fix double trailing slash when switching versions multiple times (#9488)

view details

Kewal Shah

commit sha c8a4e3a1be428b5561c9a06575a907f070e188af

[docs] typo in share.md (#9470) Fix grammar. "a" should be used instead of "an" before URL because the U here is a consonant sound. (e.g. a Uniform)

view details

push time in 2 months

startedveeral-patel/how-to-secure-anything

started time in 2 months

startedreact-hook-form/react-hook-form

started time in 2 months

push eventjarvisluong/machibot

Jarvis Luong

commit sha 1ec6fbbbd8db1ae43a366e627858dc1aed4fc47c

add details to about command

view details

Jarvis Luong

commit sha 8cf9fb40d39042b049c844b9a8829f2df62c7f54

add help command

view details

push time in 2 months

push eventjarvisluong/machibot

Jarvis Luong

commit sha 5fce16fba5f5a0d10ddbfbd3f31eaafc2302d1f8

add stub for about and help

view details

push time in 2 months

push eventjarvisluong/tf-free-compute-engine

Jarvis Luong

commit sha 47c79c6bc9a7f9add72e0a36271334765b78ce0d

allow ssh access

view details

push time in 2 months

push eventjarvisluong/tf-free-compute-engine

Jarvis Luong

commit sha 33f2cdf3d2d1b32ba224b83483784dd039fc46f9

update readme

view details

push time in 2 months

push eventjarvisluong/tf-free-compute-engine

Jarvis Luong

commit sha 0821e1777d760330d94ae81c888b4b2dce136f99

add readme

view details

push time in 2 months

create barnchjarvisluong/tf-free-compute-engine

branch : master

created branch time in 2 months

created repositoryjarvisluong/tf-free-compute-engine

Terraform script to create free compute engine on GCP

created time in 2 months

startedBluezoneGlobal/bluezone-app

started time in 2 months

pull request commentexpo/expo

[expo-keep-awake] Add web implementation for expo-keep-awake

There are some core API changes that need to be changed in order to match the ecosystem.

could you elaborate which core API should be changed. By "ecosystem" do you mean this particular package?

jarvisluong

comment created time in 2 months

issue closedexpo/expo

[expo-media-library] [ios] show if an asset is an icloud asset

So I've been building an app which need to create a media picker. The problem is when user's phone has images or videos stored on icloud (and not yet locally). In order to display those icloud asset properly I would need to wait until the asset is downloaded (as already defined in here: https://github.com/expo/expo/blob/e166a8d8b72263a5ab75f04871e7a5d2da9729e9/packages/expo-media-library/ios/EXMediaLibrary/EXMediaLibrary.m#L407

To listen for download updates, it is also already possible since expo-media-library has a delegated method:

https://github.com/expo/expo/blob/e166a8d8b72263a5ab75f04871e7a5d2da9729e9/packages/expo-media-library/ios/EXMediaLibrary/EXMediaLibrary.m#L567

My suggestion would be to add this key isIcloudAsset: boolean to the return value of MediaLibrary.getAssetInfoAsync(asset), so that the user of this library know that this asset needs to wait for download before showing it. In order to do this, we can check this key (PHImageResultIsInCloudKey) inside the info object of this callback:

https://github.com/expo/expo/blob/e166a8d8b72263a5ab75f04871e7a5d2da9729e9/packages/expo-media-library/ios/EXMediaLibrary/EXMediaLibrary.m#L422

I'm happy to include a PR to about this issue as well.

Reference: https://www.swiftjectivec.com/icloud-photo-handling/

closed time in 2 months

jarvisluong

pull request commentexpo/expo

[media-library] add options for getAssetInfoAsync

Awesome!

jarvisluong

comment created time in 2 months

delete branch jarvisluong/expo

delete branch : feature/media-library-advanced-options

delete time in 2 months

push eventjarvisluong/expo

Jarvis Luong

commit sha f59507e41442be8b7a1d08d171578382458c0541

update build output

view details

push time in 2 months

push eventjarvisluong/expo

Jarvis Luong

commit sha c6e060354a3dabf1651404a0dbcdb6ed478f9d5e

fix linting error

view details

push time in 2 months

pull request commentexpo/expo

[expo-keep-awake] Add web implementation for expo-keep-awake

I will update the docs and change log as well if we are okay with the public API changes.

jarvisluong

comment created time in 2 months

push eventjarvisluong/expo

Jarvis Luong

commit sha 3ce12e0b3d6a09de8e23d811431b38bd1383b129

Update packages/expo-media-library/ios/EXMediaLibrary/EXMediaLibrary.m Co-authored-by: Łukasz Kosmaty <lukasz.kosmaty@student.uj.edu.pl>

view details

push time in 2 months

Pull request review commentexpo/expo

[media-library] add options for getAssetInfoAsync

 - (NSDictionary *)constantsToExport   }      PHAsset *asset = [EXMediaLibrary _getAssetById:assetId];+    +  BOOL shouldDownloadFromNetwork = [[options objectForKey:EXMediaLibraryShouldDownloadFromNetworkKey] boolValue] ?: @YES;

No problemo 😄

jarvisluong

comment created time in 2 months

PR opened expo/expo

Reviewers
[expo-keep-awake] Add web implementation for expo-keep-awake

Why

As mentioned in https://github.com/expo/expo/issues/6889

How

I implemented as the implementation guide of https://web.dev/wakelock/

Since the wake lock request in web will return a Promise, I changed the public API of expo-keep-awake to reflect that also.

Test Plan

To be updated

+72 -8

0 comment

4 changed files

pr created time in 2 months

create barnchjarvisluong/expo

branch : feature/keeo-awake-web

created branch time in 2 months

pull request commentexpo/expo

[media-library] add options for getAssetInfoAsync

Perfect, thank you for fixing my suggestions! 🙂 One more thing — looks like there are two conflicts with master, could you resolve them?

Done 👍

jarvisluong

comment created time in 2 months

push eventjarvisluong/expo

Tomasz Sapeta

commit sha d468822f2dde56ed75d08ef8dca9b6c4cb42168c

[bare-expo] Add app icon for bare-expo on iOS It's just nicer and I'll need it for the dev menu anyway

view details

Tomasz Sapeta

commit sha 1bf7e487c9ef2569c105578edcf935a3e1caad6b

Publish packages expo-contacts@8.3.0 expo-document-picker@8.3.0 expo-file-system@9.1.0 expo-font@8.2.2 expo-image-picker@8.4.0 expo-mail-composer@8.3.0 expo-media-library@8.4.0 expo-notifications@0.5.0 expo-permissions@9.1.0 expo-print@9.0.2 expo-secure-store@9.1.0 expo-sharing@8.3.0 expo-store-review@2.1.3

view details

Bartłomiej Klocek

commit sha 3f499a0997088c2e9a7d4aef74cd2109c14b7df5

[docs][media-library] Clarify docs (#9376) * [docs][media-library] Clarified MediaLibrary docs * [docs][media-library] Fixed table spacing * [docs][media-library] Fixed info about permissions

view details

Bartłomiej Klocek

commit sha 699af9f2f78c1803e9212d71c0165cb1de20cccb

[test-suite] Fix selection when test name includes another name (#9421) # Why Fixes #9312 where `ImagePicker` test name included `Image` string, which is another test name. # How Since https://github.com/expo/expo/commit/91d99453c83711e7fd8455305a96bf8f432e9e67 test names are no longer passed between screens as `Set`, but as one space-separated string. This causes problems when I select e.g. `Permissions` and `ImagePicker`. The string then looks like this: `Permissions ImagePicker` and this line: https://github.com/expo/expo/blob/3f499a0997088c2e9a7d4aef74cd2109c14b7df5/apps/test-suite/screens/TestScreen.js#L34 There are 3 modules passing this condition: `Permissions`, `Image` and `ImagePicker`. Splitting the string back into array solved the issue. # Test Plan Ran _test-suite_ with several selection combinations and `console.log`'ged selected modules.

view details

Łukasz Kosmaty

commit sha abfa127e40706ce5b234e219ecc27ed8e7531f23

[expo-permissions] Add support for limited CAMERA_ROLL permission (#9423) # Why Fixes https://github.com/expo/expo/issues/9027. # How Returns `scope` value on iOS - see https://developer.apple.com/documentation/photokit/phauthorizationstatus/phauthorizationstatuslimited?language=objc. # Test Plan - simple demo ✅ - test-suite ✅

view details

Hein Rutjes

commit sha 39570fbddd5320549b6fa72669a3e12ffdfee718

[expo-av] Removed unused and potentionally unsafe call (#9436) * [expo-av] Removed unused and unsafe call * [expo-av] Update changelog

view details

Łukasz Kosmaty

commit sha d5ee39b5067a6826024f80cfbd6b0e13513a31c1

[unimodules-adapter] Fix `unregisterActivityEventListener` (#9207) # Why Fixes `unregisterActivityEventListener` method not working in `expo-client`. # Test Plan - tested using `expo-image-picker` ✅

view details

Bartłomiej Bukowski

commit sha 9ef743bc4ab1ba21e8e9c810aef2381bba8c49d7

[LoadingView][managed] Extract loading bar from LoadingView (#9324) LoadingProgressView was integrated into LoadingView that has to be mostly rewritten, because of expo-splash-screen integration. As expo-splash-screen has no knowledge about any loading progress and this very same loading progress has to be presented above all application content I decided to go with the approach that is proposed in ReactNative repo for their version of loading progress bar (that means using separate UIWindow on iOS and PopupWindow on Android).

view details

Hein Rutjes

commit sha 8524116e5d55537f80e1be43998e636b3f4c2f2b

[expo-av] Refactor to use WEAKIFY macros (#9437)

view details

Łukasz Kosmaty

commit sha 3c2be64e298776b62f49b450d29d13c9a5d40538

[expo-image-picker][android] Clean `onActivityResult` (#9349) # Why To fix https://github.com/expo/expo/issues/7946 we need to clean the Android code. # How - created separate async tasks for different result flow. - unregistered from the activity lifecycle method. # Test Plan - NCL ✅ - test-suite ✅

view details

Cedric van Putten

commit sha 6e51b43ec419df49483b989227287aaaff0e2d37

[device] Remove default request install package to make it opt-in (#8969) * [device] Remove default request install package to make it opt-in * [docs] Add note about additional permission required for device sideloading enabled * [device] Add changelog message to opt-in permission * [docs] Fix typo in side loading enabled example * [device] Remove duplicate changelog item * [device] Emphasize the removed permission in changelog Co-authored-by: James Ide <ide@users.noreply.github.com> Co-authored-by: James Ide <ide@users.noreply.github.com>

view details

Bartłomiej Klocek

commit sha 5649cd74e2ecd77c8c4e823464724cb2e77ea755

[expo-sensors] Fix barometer resolution on iOS (#9441) # Why Fixes #9427 # How `NSNumber` pressure value was truncated to integer, which gave resolution of 1kPa (10hPa). Changed `intValue` to `doubleValue`. # Test Plan Tested on iPhone XS

view details

Łukasz Kosmaty

commit sha e85002f92a930babf61030cfd095cc43c6b9ce05

[expo-notifications] Add support for channels to local notifications (#9385) # Why Fixes https://github.com/expo/expo/issues/9303. Fixes https://github.com/expo/expo/issues/9155. # How Users now can change channel id for a local notification. # Test Plan - https://snack.expo.io/@lukaszkosmaty/expo-notifications---local-channels-demo ✅

view details

Charlie Cruzan

commit sha f6562485da2a3be0f199eb699d4ee577a6112ae5

[expo-notifications] feat: add notification categories (interactive notifications) (#9015) * ios implementation * add getCategoriesAsync method * change type and method names based on architecture proposal * add android boilerplate code * Correct typescript layer according to architecture proposal * first pass at tests * return category after creating it, and clean up parsing code * get iOS tests passing * [ios] add remaining native options functionality * finalize tests for iOS * beginning of android implementation * [android] implement action button feature * fix remote notification category handling * support 'options' argument for notification action * make some changes to follow new additions to architecture proposal * [android] add functionality for actions that don't foreground the app * serialize options so they are returned in an object * change doNotOpenInForeground to opensAppToForeground * [android] text reply actions functionality * [android] pass along user text response with notification * clean up categoryAwareBuilder * rebase master, re-'yarn build' * cleanup iOS * [android] fix test suite tests * docs and changelog * fix typescript typo and rebuild * update readme * reformat java code * rename some java variables * address iOS feedback * address remaining pieces of android feedback * fix client build * docs, readme, and changelog updates * improve tests, test feedback * extract interface, create .native and .web files, and the rest of TS feedback * optimize all java imports * [ios] add scoped notification categories * [ios] remove scope prefix from serialized notification in client * [ios] left this out of previous commit * serialize category identifer on android * [android] scope notification categories in android expo client * fix spelling mistake * [expo client] run pod install * Apply suggestions from code review Co-authored-by: Łukasz Kosmaty <lukasz.kosmaty@swmansion.com> * add andraid NonNull handling * [ios] scope notification serializer * Apply suggestions from code review fix name of category prefix remover method; spacing fixes Co-authored-by: Łukasz Kosmaty <lukasz.kosmaty@swmansion.com> * fix reversed emitted events on iOS, and re- yarn build * fix iOS client build * rebuild JS Co-authored-by: Łukasz Kosmaty <lukasz.kosmaty@swmansion.com>

view details

Cedric van Putten

commit sha 4a998e276e0c3a246bb13b104956491710874ec7

[docs] Fallback to preinstalled aws cli in workflow (#9448)

view details

Tommy Bruzzese

commit sha b8f1aa67f1e8ee5f8f792daf879145c61ed48fa7

[docs] sticky mobile navbar, header updates (#9389) * [docs] sticky nav bar, header updates * css refactor * border bottom fix

view details

Charlie Cruzan

commit sha 12a8c0dda8ee2c1e45bedc4b51a819e37e84c9d0

[docs] remove reference to Updates.reload()

view details

Evan Bacon

commit sha 3b86c274229a416ebe44a02c8e000bd6698ff30f

Tree-shake react-native-paper on iOS (#9458)

view details

Evan Bacon

commit sha 17d855ed828f293332f3ac2dacef51aa84b1e681

Convert ProjectTools to TypeScript (#9456)

view details

Evan Bacon

commit sha 880c239235b2cfe879589f8024917b74c8e7333f

Added react-native-bundle-visualizer to home (#9457)

view details

push time in 2 months

issue commentexpo/expo

[Web] expo-keep-awake support

This sounds interesting, can I take this one? @EvanBacon

EvanBacon

comment created time in 2 months

delete branch jarvisluong/expo

delete branch : feature/network-asset-flag

delete time in 2 months

push eventjarvisluong/expo

Jarvis Luong

commit sha ca82dedb5a362e3f1637e3269c318537a23300da

typo in MediaLibraryAssetInfoQueryOptions

view details

push time in 2 months

push eventjarvisluong/expo

Jarvis Luong

commit sha e854e8ad45183d14c89f64af239ce0c559a3fca7

rename to MediaLibraryAssetInfoQueryOptions

view details

push time in 2 months

push eventjarvisluong/expo

Jarvis Luong

commit sha 7ea7c6d3698e8f5d573702b8be75189108528343

Apply suggestions from code review Co-authored-by: Tomasz Sapeta <1714764+tsapeta@users.noreply.github.com>

view details

push time in 2 months

Pull request review commentexpo/expo

[media-library] add options for getAssetInfoAsync

 export async function getAssetInfoAsync(asset: AssetRef): Promise<AssetInfo> {    checkAssetIds([assetId]); -  const assetInfo = await MediaLibrary.getAssetInfoAsync(assetId);+  const assetInfo = await MediaLibrary.getAssetInfoAsync(assetId, options ?? {});

This definitely looks more explicit. So yes 👍

jarvisluong

comment created time in 2 months

push eventjarvisluong/machibot

Jarvis Luong

commit sha 560e6292ad7ac6583335e4e690e1aa21c6f10ada

add prefix to the bot

view details

push time in 2 months

push eventjarvisluong/machibot

Jarvis Luong

commit sha ab6e53311f3b1c175015b9ecb64eae25797e402f

firsr version: ping pong 😂

view details

push time in 2 months

pull request commentexpo/expo

[media-library] add options for getAssetInfoAsync

LGTM 💪 Thanks for contributing 🎉🎉🎉 Awesome work 🏅

There is still one thing left which is the bare-expo app. I wonder how should we update the demo screen for this API to reflect the possibility of changing the options? Right now, the screen just call getAssetInfoAsync directly.

jarvisluong

comment created time in 2 months

Pull request review commentexpo/expo

[media-library] add options for getAssetInfoAsync

 export type AssetInfo = Asset & {   location?: Location;   exif?: object;   isFavorite?: boolean; //iOS only+  isNetworkAsset?: boolean; //iOS only }; +export interface AssetInfoQueryOptions {+  shouldDownloadFromNetwork?: boolean;+}++export interface AssetChangeEvent {+  insertedAssets: Asset[];+  deletedAssets: Asset[];+  updatedAssets: Asset[];

Android platform itself does not have this event at all 🤔

jarvisluong

comment created time in 2 months

pull request commentexpo/expo

[media-library] add options for getAssetInfoAsync

Please add an entry to the changelog :D

Done

jarvisluong

comment created time in 2 months

push eventjarvisluong/expo

Jarvis Luong

commit sha 17e6759bac0c0520b05d92c9a3f65ee02b91584a

[media-library] update change log

view details

push time in 2 months

push eventjarvisluong/expo

Jarvis Luong

commit sha 125014f78c61885c4bdcf02a4e2080738f5e0c62

[media-library] add asset change event to listener

view details

Jarvis Luong

commit sha 582fd647fde083b7409b2480a356027ae789b289

[media-library] better derivation of shouldDownloadFromNetwork

view details

push time in 2 months

Pull request review commentexpo/expo

[media-library] add options for getAssetInfoAsync

 - (NSDictionary *)constantsToExport   }      PHAsset *asset = [EXMediaLibrary _getAssetById:assetId];+    +  NSNumber* shouldDownloadFromNetwork = [options valueForKey:EXMediaLibraryShouldDownloadFromNetworkKey] ? : @1;

Oh nice 😄 , TIL

jarvisluong

comment created time in 2 months

Pull request review commentexpo/expo

[media-library] add options for getAssetInfoAsync

 export type AssetInfo = Asset & {   location?: Location;   exif?: object;   isFavorite?: boolean; //iOS only+  isNetworkAsset?: boolean; //iOS only }; +export interface AssetInfoQueryOptions {+  shouldDownloadFromNetwork?: boolean;+}++export interface AssetChangeEvent {

That's true, somehow I forgot to update this 😄

jarvisluong

comment created time in 2 months

Pull request review commentexpo/expo

[media-library] add options for getAssetInfoAsync

 - (NSDictionary *)constantsToExport   }      PHAsset *asset = [EXMediaLibrary _getAssetById:assetId];+    +  NSNumber* shouldDownloadFromNetwork = [options valueForKey:EXMediaLibraryShouldDownloadFromNetworkKey] ? : @1;

hmm if the value is nil then [boolValue] will crash, won't it? 🤔

jarvisluong

comment created time in 2 months

created tagreactrondev/react-native-web-swiper

tagv2.1.7

Swiper-Slider for React-Native and React-Native-Web

created time in 2 months

push eventreactrondev/react-native-web-swiper

Jarvis Luong

commit sha 1553daaf4cbcacc3ce79e668aa429eab38bdd2b8

ignore babel config file

view details

Jarvis Luong

commit sha ebe7fc5d92fea309272c0b9d2450d3ef0b385f4b

v2.1.7

view details

push time in 2 months

created tagreactrondev/react-native-web-swiper

tagv2.1.6

Swiper-Slider for React-Native and React-Native-Web

created time in 2 months

push eventreactrondev/react-native-web-swiper

Jarvis Luong

commit sha 92e234a0c5e6bdab544b5c9782e4546e5962c05e

v2.1.6

view details

Jarvis Luong

commit sha 604ed431dd9bbab110c84b6cbff2d2cc8631150f

add npmignore and update change log for 2.1.6

view details

push time in 2 months

created tagreactrondev/react-native-web-swiper

tagv2.1.5

Swiper-Slider for React-Native and React-Native-Web

created time in 2 months

more