profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/jankeromnes/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

christkv/node-git 239

A node.js git implementation modeled on ruby-git

JanitorTechnology/janitor 121

The fastest development system in the world.

gitpod-io/contribute.dev 55

A list of cool open-source projects that you can contribute to with one click

JanitorTechnology/dockerfiles 50

popular development environments as containers

espadrine/sc 13

Node.js Web server framework, emphasized distinction between serving pages and XHR

JanitorTechnology/selfapi 9

Simple, self-documenting and self-testing API helper for Node.js.

espadrine/badukjs 3

Library for Go primitives: SGF parsing, board edition, bots

jankeromnes/Bien-Mec 1

Oh bien mec?

jankeromnes/booklet 1

Page printing sequence helper to print booklets.

pull request commentgitpod-io/workspace-images

feat: add chrome and electron support

Cool, many thanks!

Notes (mostly for myself when I'll review better next week): :

  • It would be cool to expand full-vnc's README.md to explain what the image is about (and not just talk about Electron)
  • We should confirm whether installing Chrome installs a graphical stack (X server) in full, which we don't want because it uses a lot of disk space
gengjiawen

comment created time in a day

pull request commentgitpod-io/gitpod

[dashboard] Fix feedback when triggering prebuilds

Thanks for the new spinner @gtsiolis! Happy that it works equally well on light and dark, thus we can remove the extra theme-switching logic 😌

LIGHT DARK
Screenshot 2021-09-17 at 16 07 38 Screenshot 2021-09-17 at 16 07 58
jankeromnes

comment created time in 2 days

push eventgitpod-io/gitpod

Anton Kosyakov

commit sha 132f47c1e9a5f515b5497f106aa7146ce48ed929

[gitpod-api] guard against unsupported notifications

view details

Anton Kosyakov

commit sha 724e72c5b2dfab04494bb5fed6129e8711126b7f

[code] upgrade latest to update to latest gitpod-protocol

view details

Anton Kosyakov

commit sha afd2cb3a2a7da004412fd45742609daa16019105

fix #5699: fix parisng of tasks env vars in go

view details

roboquat

commit sha 27c09cef1b7414ffbabee47a84dedb026554a0fa

[changelog] updated changelog

view details

Anton Kosyakov

commit sha 42d75a72d2ea09210df97eddfe1dd10e4c69e630

[code] show open in desktop notificaiton

view details

Christian Weichel

commit sha d60599cd956f1e4a404c83e3746108b5c17cbd03

[common-go] Support client side gRPC metrics

view details

Jan Koehnlein

commit sha 353ddc20fb8703147903de0c1240a128fcc3c5a3

[server] Add gRPC client side metrics for image-builder and ws-manager

view details

Christian Weichel

commit sha 734fee64747c6dbf79e1d8190392d0e4860df6df

[ws-proxy] Enable kube-rbac-proxy

view details

Christian Weichel

commit sha bda4e215934184d219dd3c7fd15680ab04c4c927

[image-builder] Add additional metrics

view details

Christian Weichel

commit sha 4e59ceeb9f0aebeb28394801c86f9ea25b8837f3

[ws-manager-bridge] Add kube-rbac-proxy

view details

Christian Weichel

commit sha 0add786e81b1e4e0948c0c2e6340a57a6ff4011f

[ws-manager-bridge] Add registered cluster metrics

view details

Jan Koehnlein

commit sha ebadf1ad663f2d40db173502b7be063a0caec1f6

[grpc] assimilated Typescript metrics to Go ones

view details

Jan Keromnes

commit sha b9789c95290972b12749002db9ea0573f47240e5

[dashboard] Remove duplicate status header in Prebuild page Implements B from https://github.com/gitpod-io/gitpod/issues/5526

view details

ArthurSens

commit sha b338a87f84956b1b945eb7004b31517d7bafa6ee

Add Gitpod version info metric Signed-off-by: ArthurSens <arthursens2005@gmail.com>

view details

Jan Keromnes

commit sha 838e415d244b77eb80cc319a0a7748ae224cf8e3

[dashboard] Fix spinner

view details

push time in 2 days

issue commentgitpod-io/gitpod

Allow users to cancel pending or running prebuilds for projects

Happy to take a look at this again next week 👍

gtsiolis

comment created time in 2 days

push eventgitpod-io/workspace-images

Jan Keromnes

commit sha 1bfb9d254e130d005d7f0198add61a68cba3c065

Merge the two issue template contact links and fix the build

view details

push time in 2 days

PR opened gitpod-io/workspace-images

[full] Force Homebrew layer rebuild

An attempt to work around https://github.com/gitpod-io/gitpod/issues/5280

Description

<!-- Describe your changes in detail -->

Related Issue(s)

<!-- List the issue(s) this PR solves --> Fixes #

How to test

<!-- Provide steps to test this PR -->

Release Notes

<!-- Add entries for the CHANGELOG.md or "NONE" if there aren't any user facing changes. Each line becomes a separate entry. Format: [!<optional for breaking>] <description> Example: !basic auth is no longer supported See https://www.notion.so/gitpod/Release-Notes-513a74fdd23b4cb1b3b3aefb1d34a3e0 -->

+1 -1

0 comment

1 changed file

pr created time in 2 days

create barnchgitpod-io/workspace-images

branch : jx/update-brew-1

created branch time in 2 days

issue commentgitpod-io/gitpod

Running brew update causes environment to stop

A potential workaround could be to update brew in gitpod/workspace-full. That way, there is no need to run brew update for a while, and installing the Stripe CLI might work again.

To do this, we can commit one change to the HomeBrew image layer in order to invalidate the Dazzle cache and force a rebuild of the HomeBrew layer (looking at the "Blame", it seems that our current brew installation is at least 23 days old).

I'll make a PR.

shafy

comment created time in 2 days

issue closedgitpod-io/gitpod

Number of team members don't match on the billing

Bug description

When I go to the team settings it says that we have 322 members but we deleted (disabled) some of them and the number should be 192 instead.

I'm afraid the billing will also match the 322 instead of 192.

Teams-—-Gitpod

Steps to reproduce

  1. go to team settings
  2. Open the team details
  3. count the number of items on the list

Expected behavior

The number of team members should match the number of items in the list.

Example repository

No response

Anything else?

No response

closed time in 2 days

alesanchezr

issue commentgitpod-io/gitpod

Number of team members don't match on the billing

The fix was deployed on July 13th and we've successfully issued refunds where applicable, so this issue can now be closed.

alesanchezr

comment created time in 2 days

Pull request review commentgitpod-io/gitpod

[projects] enable New Workspace button in all cases

 export default function () {         <div className="h-20 px-6 bg-gray-50 dark:bg-gray-800 border-t border-gray-200 dark:border-gray-600 flex space-x-2">           {prebuildWasTriggered && <PrebuildInstanceStatus prebuildInstance={prebuildInstance} isDark={isDark} />}           <div className="flex-grow" />-          {(prebuildInstance?.status.phase === "stopped" && !prebuildInstance?.status.conditions.failed)-              ? <a className="my-auto" href={`/#${project?.cloneUrl}`}><button className="secondary">New Workspace</button></a>-              : <button disabled={true} className="secondary">New Workspace</button>}+          <a className="my-auto" href={`/#${project?.cloneUrl}`}><button className="secondary">New Workspace</button></a>

Instead of always enabling New Workspace, I propose to only enable it when:

  • There was a Git-based config (new with this PR, requested by https://github.com/gitpod-io/gitpod/issues/5591)
  • User ran a Prebuild, which had no errors, and stopped successfully (previous code)

I think we don't want to enable the New Workspace button when:

  • User ran a Prebuild, but it's not quite finished yet (so starting a workspace wouldn't have the config)
  • User ran a Prebuild, but it had an error (starting a workspace would not use any prebuild)
  • User didn't run a Prebuild yet, and config was auto-detected (what you see in the editor isn't saved yet, and starting a new workspace would give you an unconfigured workspace)
                    {((!isDetecting && isEditorDisabled) || (prebuildInstance?.status.phase === "stopped" && !prebuildInstance?.status.conditions.failed))
              ? <a className="my-auto" href={`/#${project?.cloneUrl}`}><button className="secondary">New Workspace</button></a>
              : <button disabled={true} className="secondary">New Workspace</button>}
AlexTugarev

comment created time in 2 days

PullRequestReviewEvent

pull request commentgitpod-io/gitpod

[projects] enable New Workspace button in all cases

⚠️ There are a few problems with always enabling the New Workspace button:

  1. It only actually uses the configuration visible on the left when: a. You ran a prebuild, and it stopped successfully b. You already had a Git-based config
  2. However, it might use something totally different if: a. You ran a prebuild, but it didn't finish yet b. You ran a prebuild, but it had an error c. You didn't run a prebuild, and there was no Git-based config

I don't think it's a good idea to enable all of 1. and 2. Maybe it's safer to enable just 1.a. (previous code) and 1.b. (new request from https://github.com/gitpod-io/gitpod/issues/5591)?

AlexTugarev

comment created time in 2 days

issue commentgitpod-io/gitpod

No feedback when triggering prebuilds

Many thanks @gtsiolis!

However, the SVG is not square, so adding a spin animation to it makes it look like a misaligned wheel 😅 I've tried fixing the SVG coordinates manually, but didn't succeed.

Could you please provide another spinner SVG with transparent background and the same height & width? (So that rotating it around its center creates a perfect circle)

atduarte

comment created time in 2 days

pull request commentgitpod-io/gitpod

[dashboard] Remove duplicate status header in Prebuild page

BEFORE AFTER
Screenshot 2021-09-17 at 09 59 09 Screenshot 2021-09-17 at 09 56 36
jankeromnes

comment created time in 2 days

push eventgitpod-io/gitpod

Jan Keromnes

commit sha 7ea057a4bf39fd40fd3f5ac9e5b0f99780a07800

[dashboard] Remove duplicate status header in Prebuild page Implements B from https://github.com/gitpod-io/gitpod/issues/5526

view details

push time in 2 days

PR opened gitpod-io/gitpod

[dashboard] Fix feedback when triggering prebuilds approved

Description

<!-- Describe your changes in detail -->

Related Issue(s)

<!-- List the issue(s) this PR solves --> Fixes https://github.com/gitpod-io/gitpod/issues/5374

How to test

<!-- Provide steps to test this PR -->

Release Notes

<!-- Add entries for the CHANGELOG.md or "NONE" if there aren't any user facing changes. Each line becomes a separate entry. Format: [!<optional for breaking>] <description> Example: !basic auth is no longer supported See https://www.notion.so/gitpod/Release-Notes-513a74fdd23b4cb1b3b3aefb1d34a3e0 -->

NONE

/uncc

+7 -12

0 comment

5 changed files

pr created time in 2 days

PR opened gitpod-io/gitpod

[dashboard] Remove duplicate status header in Prebuild page

Implements B from https://github.com/gitpod-io/gitpod/issues/5526

Description

<!-- Describe your changes in detail -->

Related Issue(s)

<!-- List the issue(s) this PR solves --> Fixes https://github.com/gitpod-io/gitpod/issues/5526

How to test

<!-- Provide steps to test this PR -->

Release Notes

<!-- Add entries for the CHANGELOG.md or "NONE" if there aren't any user facing changes. Each line becomes a separate entry. Format: [!<optional for breaking>] <description> Example: !basic auth is no longer supported See https://www.notion.so/gitpod/Release-Notes-513a74fdd23b4cb1b3b3aefb1d34a3e0 -->

NONE
+1 -7

0 comment

1 changed file

pr created time in 2 days

create barnchgitpod-io/gitpod

branch : jx/remove-duplicate-prebuild-status

created branch time in 2 days

create barnchgitpod-io/gitpod

branch : jx/trigger-prebuild-feedback

created branch time in 2 days

issue commentgitpod-io/workspace-images

Upgrade from Ubuntu Disco 19.04 (end-of-life) to Ubuntu Eoan 19.10 or Ubuntu Focal 20.04 LTS

Hi @Utopiah! Oh, good catch. I think the reason is that in Gitpod's R example repository, the .gitpod.Dockerfile hasn't been modified in 2 years.

Gitpod (currently) caches custom workspace images based on a hash of the custom Dockerfile. So, if the Dockerfile isn't modified in 2 years, the workspace image will be 2 years old, even for brand new workspaces 😕 (which I agree is bad and surprising).

The workaround is to force a rebuild of the workspace image, e.g. by:

  • Committing a change to the custom Dockerfile (any change)
  • Forking the example repository (Gitpod will see the custom Dockerfile as new in a new repository)
jankeromnes

comment created time in 2 days

startedgitpod-io/openvscode-server

started time in 3 days

issue commentgitpod-io/gitpod

Gitpod Singapore (sg) region

FYI, one more data point from @tnir in https://community.gitpod.io/t/cannot-open-ide/3633/8?u=jan (from Japan, I believe) :

asia-northeast1, asia-northeast2, asia-east1, asia-east2, asia-southeast1 are my top 5 (15-91ms). us-west1 (169ms) is coming next.

<img alt="gcping com_" width="300" src="https://user-images.githubusercontent.com/599268/133566791-d8556db1-4f29-43ae-a75d-603e6b829ca1.png" />

ghuntley

comment created time in 3 days

issue commentgitpod-io/gitpod

Automatically chose workspace-cluster based on lowest latency.

Prior Art

FYI, that proposal is to temporarily gather ping times to all possible GCP regions, in order to decide "where should we create a brand new cluster next?"

The proposal was not to collect ping times in order to decide "which workspace cluster should be used right now?" -- doesn't GCP's load balancer already do that automatically? How does the US vs EU selection work right now? (I assume it's not some custom code we wrote, but GCP selecting a reasonable cluster automatically -- I would hope this would also work with 3 or more clusters without requiring us to write custom code for this)

meysholdt

comment created time in 3 days

issue commentgitpod-io/gitpod

Add option to drop some Gitpod layer metadata

FYI, the problematic Gitpod layer has been entirely removed in https://github.com/gitpod-io/gitpod/pull/4923

RDIL

comment created time in 3 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentgitpod-io/workspace-images

[full]: share env path better between users

 RUN for i in $(ls /var/lib/apt/dazzle-marks/*.gpg); do apt-key add "$i"; done # copy tests to enable the self-test of this image COPY tests /var/lib/dazzle/tests +# share env see https://github.com/gitpod-io/workspace-images/issues/472+USER gitpod+RUN echo "PATH="${PATH}"" > /tmp/env.txt+USER root+RUN cat /tmp/env.txt >> /etc/environment && npx envinfo

Many thanks for implementing this fix! This is awesome.

Nit: I'd prefer not switching to USER root (it's not necessary), and not running npx envinfo in our build if possible.

RUN echo "PATH="${PATH}"" | sudo tee -a /etc/environment
gengjiawen

comment created time in 16 days

PullRequestReviewEvent