profile
viewpoint
Jeremy Soller jackpot51 http://www.redox-os.org System76 Engineering Manager and Redox OS BDFL

fwupd/fwupd 1035

A simple daemon to allow session software to update firmware

elementary/installer 106

Installer front-end for Linux-based OSes

jackpot51/puccinia 14

A self-hosted solution for accounting. Known to infect Mint with Rust.

jackpot51/friar 9

Free Rust Implementation of Augmented Reality (WIP)

jackpot51/emulition 7

Emulator Frontend

jackpot51/frontier 4

Starship Simulator in Rust

jackpot51/solleros 3

Automatically exported from code.google.com/p/solleros

jackpot51/physics 2

Extremely WIP Physics Simulations in Rust

jackpot51/artifact-data 1

the sub-crate for artifact for processing data (serialization and deserialization)

PullRequestReviewEvent

push eventsystem76/ec

Jeremy Soller

commit sha 05f946d8f704f4b5d3be9387febb91037489ea7b

Merge changes between galp5 and lemp10, set RSTDMMC

view details

push time in 8 hours

push eventsystem76/qmk_firmware

Jeremy Soller

commit sha cde13a53dd46bbbda23b040330a869cf07151e71

Update Jeremy layout

view details

push time in 9 hours

pull request commentpop-os/system76-acpi-dkms

Add hwmon and input interface

If you want this feature, you will need to use the DKMS module. Upstream Linux has not accepted the change yet.

jackpot51

comment created time in 10 hours

push eventpop-os/linux

Jeremy Soller

commit sha f6b125f36ac15b1e18538a6aec59b91bdad873fe

Disable docs package, it requires a newer version of sphinx

view details

push time in 10 hours

push eventpop-os/linux

push time in 10 hours

push eventpop-os/linux

Jeremy Soller

commit sha fb5da5a0b7b82ade7d2af671746f7820aa8dbd36

Attempt to fix build on Pop!_OS

view details

push time in 10 hours

created tagpop-os/system76-driver

tag20.04.15

System76 Driver for Pop!_OS

created time in 13 hours

push eventpop-os/system76-driver

Jeremy Soller

commit sha 1d7bb55d789033bb6b664f1bb6c57af0bb8e3dbd

Release 20.04.15

view details

push time in 13 hours

push eventpop-os/system76-driver

Jeremy Soller

commit sha 388d144b69bbd12fdfefcfc7eb6f96699a24b354

Bump version to 20.04.15~~alpha

view details

Jeremy Soller

commit sha 9b37e75c30d6a568b01cd523d1357cb6b7391739

Update NVIDIA driver to 455

view details

push time in 13 hours

push eventpop-os/system76-driver

Jeremy Soller

commit sha 9b37e75c30d6a568b01cd523d1357cb6b7391739

Update NVIDIA driver to 455

view details

push time in 13 hours

push eventpop-os/system76-driver

Jeremy Soller

commit sha 388d144b69bbd12fdfefcfc7eb6f96699a24b354

Bump version to 20.04.15~~alpha

view details

push time in 13 hours

push eventpop-os/system76-driver

push time in 13 hours

push eventpop-os/virtualbox

Jeremy Soller

commit sha 69211f0792a2c0ccd4d2d278df7e8da3f7ce0a8b

Only build for amd64

view details

push time in 13 hours

push eventsystem76/firmware-open

Jeremy Soller

commit sha 5e61271a10c8cb4c48b0bbca22a0971f3db2cd4e

Set PCIE_BASE from MMCONF_BASE_ADDRESS

view details

Jeremy Soller

commit sha 3395aea75aa8f5faddbf59ad74afda0940794422

WIP

view details

push time in 13 hours

push eventsystem76/ec

Jeremy Soller

commit sha 7bef2ccf5722a0f61f42bf2bdbc927c8dbc96f2a

WIP

view details

push time in 13 hours

push eventsystem76/ecsim

Jeremy Soller

commit sha 19e16b1ce3e175b14665073a47ef8a446cb988d6

Reorder eSPI general caps and configs registers

view details

push time in 13 hours

push eventpop-os/virtualbox

Jeremy Soller

commit sha b7b36eb2e083a2e47d2849a76ae7954c5a7800a0

Move liblzf in-tree, as done by focal package

view details

push time in 14 hours

create barnchpop-os/virtualbox

branch : groovy_focal

created branch time in a day

push eventpop-os/pop

Jeremy Soller

commit sha 99a835fc17f625042da2bc59c05c8a7df5cc44bd

Add virtualbox repo

view details

push time in a day

created repositorypop-os/virtualbox

Pop!_OS fork of https://salsa.debian.org/pkg-virtualbox-team/virtualbox.git

created time in a day

push eventpop-os/keyboard-configurator

Jeremy Soller

commit sha 1e6c9d6b1e41b6c7980eba54cbece6f0bf85f71b

Add launch_beta_1

view details

Jeremy Soller

commit sha bb675c561c3d6e91b7824b320002312dd9438f92

Ignore failure to read color

view details

push time in a day

push eventsystem76/qmk_firmware

Jeremy Soller

commit sha 677de37754d3264305613ac30ae932727da6d90d

Fix RGB matrix

view details

push time in a day

delete branch pop-os/linux

delete branch : groovy_focal

delete time in a day

push eventpop-os/linux

Evgeny Novikov

commit sha 1d7040dd847771a2a101250f3c26cbdd5dfdb2c9

USB: lvtest: return proper error code in probe BugLink: https://bugs.launchpad.net/bugs/1894956 commit 531412492ce93ea29b9ca3b4eb5e3ed771f851dd upstream. lvs_rh_probe() can return some nonnegative value from usb_control_msg() when it is less than "USB_DT_HUB_NONVAR_SIZE + 2" that is considered as a failure. Make lvs_rh_probe() return -EINVAL in this case. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Evgeny Novikov <novikov@ispras.ru> Cc: stable <stable@vger.kernel.org> Link: https://lore.kernel.org/r/20200805090643.3432-1-novikov@ispras.ru Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

view details

Tetsuo Handa

commit sha 2bedde16237972a17ea706ba89d0ec0b7d3fd9ae

vt: defer kfree() of vc_screenbuf in vc_do_resize() BugLink: https://bugs.launchpad.net/bugs/1894956 commit f8d1653daec02315e06d30246cff4af72e76e54e upstream. syzbot is reporting UAF bug in set_origin() from vc_do_resize() [1], for vc_do_resize() calls kfree(vc->vc_screenbuf) before calling set_origin(). Unfortunately, in set_origin(), vc->vc_sw->con_set_origin() might access vc->vc_pos when scroll is involved in order to manipulate cursor, but vc->vc_pos refers already released vc->vc_screenbuf until vc->vc_pos gets updated based on the result of vc->vc_sw->con_set_origin(). Preserving old buffer and tolerating outdated vc members until set_origin() completes would be easier than preventing vc->vc_sw->con_set_origin() from accessing outdated vc members. [1] https://syzkaller.appspot.com/bug?id=6649da2081e2ebdc65c0642c214b27fe91099db3 Reported-by: syzbot <syzbot+9116ecc1978ca3a12f43@syzkaller.appspotmail.com> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Cc: stable <stable@vger.kernel.org> Link: https://lore.kernel.org/r/1596034621-4714-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

view details

George Kennedy

commit sha 134ca7bb0c4658c4e00579688ae9265e76894106

vt_ioctl: change VT_RESIZEX ioctl to check for error return from vc_resize() BugLink: https://bugs.launchpad.net/bugs/1894956 commit bc5269ca765057a1b762e79a1cfd267cd7bf1c46 upstream. vc_resize() can return with an error after failure. Change VT_RESIZEX ioctl to save struct vc_data values that are modified and restore the original values in case of error. Signed-off-by: George Kennedy <george.kennedy@oracle.com> Cc: stable <stable@vger.kernel.org> Reported-by: syzbot+38a3699c7eaf165b97a6@syzkaller.appspotmail.com Link: https://lore.kernel.org/r/1596213192-6635-2-git-send-email-george.kennedy@oracle.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

view details

Tamseel Shams

commit sha f9e0937c2faa56a620e5d3e60da9508e92d1e8c9

serial: samsung: Removes the IRQ not found warning BugLink: https://bugs.launchpad.net/bugs/1894956 commit 8c6c378b0cbe0c9f1390986b5f8ffb5f6ff7593b upstream. In few older Samsung SoCs like s3c2410, s3c2412 and s3c2440, UART IP is having 2 interrupt lines. However, in other SoCs like s3c6400, s5pv210, exynos5433, and exynos4210 UART is having only 1 interrupt line. Due to this, "platform_get_irq(platdev, 1)" call in the driver gives the following false-positive error: "IRQ index 1 not found" on newer SoC's. This patch adds the condition to check for Tx interrupt only for the those SoC's which have 2 interrupt lines. Tested-by: Alim Akhtar <alim.akhtar@samsung.com> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> Signed-off-by: Tamseel Shams <m.shams@samsung.com> Cc: stable <stable@vger.kernel.org> Link: https://lore.kernel.org/r/20200810030021.45348-1-m.shams@samsung.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

view details

Lukas Wunner

commit sha 2e76b96b110cc2bbebbf14d3071c97a404702904

serial: pl011: Fix oops on -EPROBE_DEFER BugLink: https://bugs.launchpad.net/bugs/1894956 commit 27afac93e3bd7fa89749cf11da5d86ac9cde4dba upstream. If probing of a pl011 gets deferred until after free_initmem(), an oops ensues because pl011_console_match() is called which has been freed. Fix by removing the __init attribute from the function and those it calls. Commit 10879ae5f12e ("serial: pl011: add console matching function") introduced pl011_console_match() not just for early consoles but regular preferred consoles, such as those added by acpi_parse_spcr(). Regular consoles may be registered after free_initmem() for various reasons, one being deferred probing, another being dynamic enablement of serial ports using a DeviceTree overlay. Thus, pl011_console_match() must not be declared __init and the functions it calls mustn't either. Stack trace for posterity: Unable to handle kernel paging request at virtual address 80c38b58 Internal error: Oops: 8000000d [#1] PREEMPT SMP ARM PC is at pl011_console_match+0x0/0xfc LR is at register_console+0x150/0x468 [<80187004>] (register_console) [<805a8184>] (uart_add_one_port) [<805b2b68>] (pl011_register_port) [<805b3ce4>] (pl011_probe) [<80569214>] (amba_probe) [<805ca088>] (really_probe) [<805ca2ec>] (driver_probe_device) [<805ca5b0>] (__device_attach_driver) [<805c8060>] (bus_for_each_drv) [<805c9dfc>] (__device_attach) [<805ca630>] (device_initial_probe) [<805c90a8>] (bus_probe_device) [<805c95a8>] (deferred_probe_work_func) Fixes: 10879ae5f12e ("serial: pl011: add console matching function") Signed-off-by: Lukas Wunner <lukas@wunner.de> Cc: stable@vger.kernel.org # v4.10+ Cc: Aleksey Makarov <amakarov@marvell.com> Cc: Peter Hurley <peter@hurleysoftware.com> Cc: Russell King <linux@armlinux.org.uk> Cc: Christopher Covington <cov@codeaurora.org> Link: https://lore.kernel.org/r/f827ff09da55b8c57d316a1b008a137677b58921.1597315557.git.lukas@wunner.de Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

view details

Lukas Wunner

commit sha 6d71bc754864b711b28e80dec84cfdd6108ff739

serial: pl011: Don't leak amba_ports entry on driver register error BugLink: https://bugs.launchpad.net/bugs/1894956 commit 89efbe70b27dd325d8a8c177743a26b885f7faec upstream. pl011_probe() calls pl011_setup_port() to reserve an amba_ports[] entry, then calls pl011_register_port() to register the uart driver with the tty layer. If registration of the uart driver fails, the amba_ports[] entry is not released. If this happens 14 times (value of UART_NR macro), then all amba_ports[] entries will have been leaked and driver probing is no longer possible. (To be fair, that can only happen if the DeviceTree doesn't contain alias IDs since they cause the same entry to be used for a given port.) Fix it. Fixes: ef2889f7ffee ("serial: pl011: Move uart_register_driver call to device") Signed-off-by: Lukas Wunner <lukas@wunner.de> Cc: stable@vger.kernel.org # v3.15+ Cc: Tushar Behera <tushar.behera@linaro.org> Link: https://lore.kernel.org/r/138f8c15afb2f184d8102583f8301575566064a6.1597316167.git.lukas@wunner.de Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

view details

Holger Assmann

commit sha 23c660eb874d2027ef0e05b88c743e797775a493

serial: stm32: avoid kernel warning on absence of optional IRQ BugLink: https://bugs.launchpad.net/bugs/1894956 commit fdf16d78941b4f380753053d229955baddd00712 upstream. stm32_init_port() of the stm32-usart may trigger a warning in platform_get_irq() when the device tree specifies no wakeup interrupt. The wakeup interrupt is usually a board-specific GPIO and the driver functions correctly in its absence. The mainline stm32mp151.dtsi does not specify it, so all mainline device trees trigger an unnecessary kernel warning. Use of platform_get_irq_optional() avoids this. Fixes: 2c58e56096dd ("serial: stm32: fix the get_irq error case") Signed-off-by: Holger Assmann <h.assmann@pengutronix.de> Cc: stable <stable@vger.kernel.org> Link: https://lore.kernel.org/r/20200813152757.32751-1-h.assmann@pengutronix.de Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

view details

Valmer Huhn

commit sha 3dd664cf8cdba4ac5b02ff5c0339985477a6f1b7

serial: 8250_exar: Fix number of ports for Commtech PCIe cards BugLink: https://bugs.launchpad.net/bugs/1894956 commit c6b9e95dde7b54e6a53c47241201ab5a4035c320 upstream. The following in 8250_exar.c line 589 is used to determine the number of ports for each Exar board: nr_ports = board->num_ports ? board->num_ports : pcidev->device & 0x0f; If the number of ports a card has is not explicitly specified, it defaults to the rightmost 4 bits of the PCI device ID. This is prone to error since not all PCI device IDs contain a number which corresponds to the number of ports that card provides. This particular case involves COMMTECH_4222PCIE, COMMTECH_4224PCIE and COMMTECH_4228PCIE cards with device IDs 0x0022, 0x0020 and 0x0021. Currently the multiport cards receive 2, 0 and 1 port instead of 2, 4 and 8 ports respectively. To fix this, each Commtech Fastcom PCIe card is given a struct where the number of ports is explicitly specified. This ensures 'board->num_ports' is used instead of the default 'pcidev->device & 0x0f'. Fixes: d0aeaa83f0b0 ("serial: exar: split out the exar code from 8250_pci") Signed-off-by: Valmer Huhn <valmer.huhn@concurrent-rt.com> Tested-by: Valmer Huhn <valmer.huhn@concurrent-rt.com> Cc: stable <stable@vger.kernel.org> Link: https://lore.kernel.org/r/20200813165255.GC345440@icarus.concurrent-rt.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

view details

Sergey Senozhatsky

commit sha 5745ccf76537dfc8fc5448238ec4bf7c48a095e2

serial: 8250: change lock order in serial8250_do_startup() BugLink: https://bugs.launchpad.net/bugs/1894956 commit 205d300aea75623e1ae4aa43e0d265ab9cf195fd upstream. We have a number of "uart.port->desc.lock vs desc.lock->uart.port" lockdep reports coming from 8250 driver; this causes a bit of trouble to people, so let's fix it. The problem is reverse lock order in two different call paths: chain #1: serial8250_do_startup() spin_lock_irqsave(&port->lock); disable_irq_nosync(port->irq); raw_spin_lock_irqsave(&desc->lock) chain #2: __report_bad_irq() raw_spin_lock_irqsave(&desc->lock) for_each_action_of_desc() printk() spin_lock_irqsave(&port->lock); Fix this by changing the order of locks in serial8250_do_startup(): do disable_irq_nosync() first, which grabs desc->lock, and grab uart->port after that, so that chain #1 and chain #2 have same lock order. Full lockdep splat: ====================================================== WARNING: possible circular locking dependency detected 5.4.39 #55 Not tainted ====================================================== swapper/0/0 is trying to acquire lock: ffffffffab65b6c0 (console_owner){-...}, at: console_lock_spinning_enable+0x31/0x57 but task is already holding lock: ffff88810a8e34c0 (&irq_desc_lock_class){-.-.}, at: __report_bad_irq+0x5b/0xba which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&irq_desc_lock_class){-.-.}: _raw_spin_lock_irqsave+0x61/0x8d __irq_get_desc_lock+0x65/0x89 __disable_irq_nosync+0x3b/0x93 serial8250_do_startup+0x451/0x75c uart_startup+0x1b4/0x2ff uart_port_activate+0x73/0xa0 tty_port_open+0xae/0x10a uart_open+0x1b/0x26 tty_open+0x24d/0x3a0 chrdev_open+0xd5/0x1cc do_dentry_open+0x299/0x3c8 path_openat+0x434/0x1100 do_filp_open+0x9b/0x10a do_sys_open+0x15f/0x3d7 kernel_init_freeable+0x157/0x1dd kernel_init+0xe/0x105 ret_from_fork+0x27/0x50 -> #1 (&port_lock_key){-.-.}: _raw_spin_lock_irqsave+0x61/0x8d serial8250_console_write+0xa7/0x2a0 console_unlock+0x3b7/0x528 vprintk_emit+0x111/0x17f printk+0x59/0x73 register_console+0x336/0x3a4 uart_add_one_port+0x51b/0x5be serial8250_register_8250_port+0x454/0x55e dw8250_probe+0x4dc/0x5b9 platform_drv_probe+0x67/0x8b really_probe+0x14a/0x422 driver_probe_device+0x66/0x130 device_driver_attach+0x42/0x5b __driver_attach+0xca/0x139 bus_for_each_dev+0x97/0xc9 bus_add_driver+0x12b/0x228 driver_register+0x64/0xed do_one_initcall+0x20c/0x4a6 do_initcall_level+0xb5/0xc5 do_basic_setup+0x4c/0x58 kernel_init_freeable+0x13f/0x1dd kernel_init+0xe/0x105 ret_from_fork+0x27/0x50 -> #0 (console_owner){-...}: __lock_acquire+0x118d/0x2714 lock_acquire+0x203/0x258 console_lock_spinning_enable+0x51/0x57 console_unlock+0x25d/0x528 vprintk_emit+0x111/0x17f printk+0x59/0x73 __report_bad_irq+0xa3/0xba note_interrupt+0x19a/0x1d6 handle_irq_event_percpu+0x57/0x79 handle_irq_event+0x36/0x55 handle_fasteoi_irq+0xc2/0x18a do_IRQ+0xb3/0x157 ret_from_intr+0x0/0x1d cpuidle_enter_state+0x12f/0x1fd cpuidle_enter+0x2e/0x3d do_idle+0x1ce/0x2ce cpu_startup_entry+0x1d/0x1f start_kernel+0x406/0x46a secondary_startup_64+0xa4/0xb0 other info that might help us debug this: Chain exists of: console_owner --> &port_lock_key --> &irq_desc_lock_class Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&irq_desc_lock_class); lock(&port_lock_key); lock(&irq_desc_lock_class); lock(console_owner); *** DEADLOCK *** 2 locks held by swapper/0/0: #0: ffff88810a8e34c0 (&irq_desc_lock_class){-.-.}, at: __report_bad_irq+0x5b/0xba #1: ffffffffab65b5c0 (console_lock){+.+.}, at: console_trylock_spinning+0x20/0x181 stack backtrace: CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.4.39 #55 Hardware name: XXXXXX Call Trace: <IRQ> dump_stack+0xbf/0x133 ? print_circular_bug+0xd6/0xe9 check_noncircular+0x1b9/0x1c3 __lock_acquire+0x118d/0x2714 lock_acquire+0x203/0x258 ? console_lock_spinning_enable+0x31/0x57 console_lock_spinning_enable+0x51/0x57 ? console_lock_spinning_enable+0x31/0x57 console_unlock+0x25d/0x528 ? console_trylock+0x18/0x4e vprintk_emit+0x111/0x17f ? lock_acquire+0x203/0x258 printk+0x59/0x73 __report_bad_irq+0xa3/0xba note_interrupt+0x19a/0x1d6 handle_irq_event_percpu+0x57/0x79 handle_irq_event+0x36/0x55 handle_fasteoi_irq+0xc2/0x18a do_IRQ+0xb3/0x157 common_interrupt+0xf/0xf </IRQ> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> Fixes: 768aec0b5bcc ("serial: 8250: fix shared interrupts issues with SMP and RT kernels") Reported-by: Guenter Roeck <linux@roeck-us.net> Reported-by: Raul Rangel <rrangel@google.com> BugLink: https://bugs.chromium.org/p/chromium/issues/detail?id=1114800 Link: https://lore.kernel.org/lkml/CAHQZ30BnfX+gxjPm1DUd5psOTqbyDh4EJE=2=VAMW_VDafctkA@mail.gmail.com/T/#u Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> Tested-by: Guenter Roeck <linux@roeck-us.net> Cc: stable <stable@vger.kernel.org> Link: https://lore.kernel.org/r/20200817022646.1484638-1-sergey.senozhatsky@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

view details

Jens Axboe

commit sha 29dba673dd31eb6e719794cfe96bd1247c11f27c

io_uring: clear req->result on IOPOLL re-issue BugLink: https://bugs.launchpad.net/bugs/1894956 commit 56450c20fe10d4d93f58019109aa4e06fc0b9206 upstream. Make sure we clear req->result, which was set to -EAGAIN for retry purposes, when moving it to the reissue list. Otherwise we can end up retrying a request more than once, which leads to weird results in the io-wq handling (and other spots). Cc: stable@vger.kernel.org Reported-by: Andres Freund <andres@anarazel.de> Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

view details

Jan Kara

commit sha 016abed4e3394266aa345ff0f7968453ca613b26

writeback: Protect inode->i_io_list with inode->i_lock BugLink: https://bugs.launchpad.net/bugs/1894956 commit b35250c0816c7cf7d0a8de92f5fafb6a7508a708 upstream. Currently, operations on inode->i_io_list are protected by wb->list_lock. In the following patches we'll need to maintain consistency between inode->i_state and inode->i_io_list so change the code so that inode->i_lock protects also all inode's i_io_list handling. Reviewed-by: Martijn Coenen <maco@android.com> Reviewed-by: Christoph Hellwig <hch@lst.de> CC: stable@vger.kernel.org # Prerequisite for "writeback: Avoid skipping inode writeback" Signed-off-by: Jan Kara <jack@suse.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

view details

Jan Kara

commit sha 8ee735ded4cb241ea7d8d44219ba36656c28d01f

writeback: Avoid skipping inode writeback BugLink: https://bugs.launchpad.net/bugs/1894956 commit 5afced3bf28100d81fb2fe7e98918632a08feaf5 upstream. Inode's i_io_list list head is used to attach inode to several different lists - wb->{b_dirty, b_dirty_time, b_io, b_more_io}. When flush worker prepares a list of inodes to writeback e.g. for sync(2), it moves inodes to b_io list. Thus it is critical for sync(2) data integrity guarantees that inode is not requeued to any other writeback list when inode is queued for processing by flush worker. That's the reason why writeback_single_inode() does not touch i_io_list (unless the inode is completely clean) and why __mark_inode_dirty() does not touch i_io_list if I_SYNC flag is set. However there are two flaws in the current logic: 1) When inode has only I_DIRTY_TIME set but it is already queued in b_io list due to sync(2), concurrent __mark_inode_dirty(inode, I_DIRTY_SYNC) can still move inode back to b_dirty list resulting in skipping writeback of inode time stamps during sync(2). 2) When inode is on b_dirty_time list and writeback_single_inode() races with __mark_inode_dirty() like: writeback_single_inode() __mark_inode_dirty(inode, I_DIRTY_PAGES) inode->i_state |= I_SYNC __writeback_single_inode() inode->i_state |= I_DIRTY_PAGES; if (inode->i_state & I_SYNC) bail if (!(inode->i_state & I_DIRTY_ALL)) - not true so nothing done We end up with I_DIRTY_PAGES inode on b_dirty_time list and thus standard background writeback will not writeback this inode leading to possible dirty throttling stalls etc. (thanks to Martijn Coenen for this analysis). Fix these problems by tracking whether inode is queued in b_io or b_more_io lists in a new I_SYNC_QUEUED flag. When this flag is set, we know flush worker has queued inode and we should not touch i_io_list. On the other hand we also know that once flush worker is done with the inode it will requeue the inode to appropriate dirty list. When I_SYNC_QUEUED is not set, __mark_inode_dirty() can (and must) move inode to appropriate dirty list. Reported-by: Martijn Coenen <maco@android.com> Reviewed-by: Martijn Coenen <maco@android.com> Tested-by: Martijn Coenen <maco@android.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Fixes: 0ae45f63d4ef ("vfs: add support for a lazytime mount option") CC: stable@vger.kernel.org Signed-off-by: Jan Kara <jack@suse.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

view details

Jan Kara

commit sha 26b837de8a7f75a527734eb0c3d20a7f0ee4a21d

writeback: Fix sync livelock due to b_dirty_time processing BugLink: https://bugs.launchpad.net/bugs/1894956 commit f9cae926f35e8230330f28c7b743ad088611a8de upstream. When we are processing writeback for sync(2), move_expired_inodes() didn't set any inode expiry value (older_than_this). This can result in writeback never completing if there's steady stream of inodes added to b_dirty_time list as writeback rechecks dirty lists after each writeback round whether there's more work to be done. Fix the problem by using sync(2) start time is inode expiry value when processing b_dirty_time list similarly as for ordinarily dirtied inodes. This requires some refactoring of older_than_this handling which simplifies the code noticeably as a bonus. Fixes: 0ae45f63d4ef ("vfs: add support for a lazytime mount option") CC: stable@vger.kernel.org Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Jan Kara <jack@suse.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

view details

Thomas Gleixner

commit sha 442be804d9b7b62d8d7e52465c4fe2b49ddb274e

XEN uses irqdesc::irq_data_common::handler_data to store a per interrupt XEN data pointer which contains XEN specific information. BugLink: https://bugs.launchpad.net/bugs/1894956 commit c330fb1ddc0a922f044989492b7fcca77ee1db46 upstream. handler data is meant for interrupt handlers and not for storing irq chip specific information as some devices require handler data to store internal per interrupt information, e.g. pinctrl/GPIO chained interrupt handlers. This obviously creates a conflict of interests and crashes the machine because the XEN pointer is overwritten by the driver pointer. As the XEN data is not handler specific it should be stored in irqdesc::irq_data::chip_data instead. A simple sed s/irq_[sg]et_handler_data/irq_[sg]et_chip_data/ cures that. Cc: stable@vger.kernel.org Reported-by: Roman Shaposhnik <roman@zededa.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Tested-by: Roman Shaposhnik <roman@zededa.com> Reviewed-by: Juergen Gross <jgross@suse.com> Link: https://lore.kernel.org/r/87lfi2yckt.fsf@nanos.tec.linutronix.de Signed-off-by: Juergen Gross <jgross@suse.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

view details

Vinod Koul

commit sha 28dfa367f7118dbd662fc670a93394f1cd3578c0

usb: renesas-xhci: remove version check BugLink: https://bugs.launchpad.net/bugs/1894956 commit d66a57be2f9a315fc10d0f524f670fec903e0fb4 upstream. Some devices in wild are reporting bunch of firmware versions, so remove the check for versions in driver Reported by: Anastasios Vacharakis <vacharakis@gmail.com> Reported by: Glen Journeay <journeay@gmail.com> Fixes: 2478be82de44 ("usb: renesas-xhci: Add ROM loader for uPD720201") Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=208911 Signed-off-by: Vinod Koul <vkoul@kernel.org> Cc: stable <stable@vger.kernel.org> Link: https://lore.kernel.org/r/20200818071739.789720-1-vkoul@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

view details

JC Kuo

commit sha 3b267f17c8f5c0eb7d118a43dfc411466d95c963

usb: host: xhci-tegra: otg usb2/usb3 port init BugLink: https://bugs.launchpad.net/bugs/1894956 commit 316a2868bc269be8c6e69ccc3a1f902a3f518eb9 upstream. tegra_xusb_init_usb_phy() should initialize "otg_usb2_port" and "otg_usb3_port" with -EINVAL because "0" is a valid value represents usb2 port 0 or usb3 port 0. Signed-off-by: JC Kuo <jckuo@nvidia.com> Cc: stable <stable@vger.kernel.org> Link: https://lore.kernel.org/r/20200811093143.699541-1-jckuo@nvidia.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

view details

JC Kuo

commit sha 6da153eeeaa7a4078373362743f6294e6df4903c

usb: host: xhci-tegra: fix tegra_xusb_get_phy() BugLink: https://bugs.launchpad.net/bugs/1894956 commit d54343a87732726b04ac5af873916b5ed4f52932 upstream. tegra_xusb_get_phy() should take input argument "name". Signed-off-by: JC Kuo <jckuo@nvidia.com> Cc: stable <stable@vger.kernel.org> Link: https://lore.kernel.org/r/20200811092553.657762-1-jckuo@nvidia.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

view details

Li Jun

commit sha 2725879020b58ba88183580cb5c01146febb9543

usb: host: xhci: fix ep context print mismatch in debugfs BugLink: https://bugs.launchpad.net/bugs/1894956 commit 0077b1b2c8d9ad5f7a08b62fb8524cdb9938388f upstream. dci is 0 based and xhci_get_ep_ctx() will do ep index increment to get the ep context. [rename dci to ep_index -Mathias] Cc: stable <stable@vger.kernel.org> # v4.15+ Fixes: 02b6fdc2a153 ("usb: xhci: Add debugfs interface for xHCI driver") Signed-off-by: Li Jun <jun.li@nxp.com> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com> Link: https://lore.kernel.org/r/20200821091549.20556-2-mathias.nyman@linux.intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

view details

Ding Hui

commit sha 963c34bd1ae296547d04bf792e3d4c71c3c70a83

xhci: Always restore EP_SOFT_CLEAR_TOGGLE even if ep reset failed BugLink: https://bugs.launchpad.net/bugs/1894956 commit f1ec7ae6c9f8c016db320e204cb519a1da1581b8 upstream. Some device drivers call libusb_clear_halt when target ep queue is not empty. (eg. spice client connected to qemu for usb redir) Before commit f5249461b504 ("xhci: Clear the host side toggle manually when endpoint is soft reset"), that works well. But now, we got the error log: EP not empty, refuse reset xhci_endpoint_reset failed and left ep_state's EP_SOFT_CLEAR_TOGGLE bit still set So all the subsequent urb sumbits to the ep will fail with the warn log: Can't enqueue URB while manually clearing toggle We need to clear ep_state EP_SOFT_CLEAR_TOGGLE bit after xhci_endpoint_reset, even if it failed. Fixes: f5249461b504 ("xhci: Clear the host side toggle manually when endpoint is soft reset") Cc: stable <stable@vger.kernel.org> # v4.17+ Signed-off-by: Ding Hui <dinghui@sangfor.com.cn> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com> Link: https://lore.kernel.org/r/20200821091549.20556-4-mathias.nyman@linux.intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

view details

Pavel Begunkov

commit sha 6f6b0766186ef41a8b8175d78e83b9ccdb265f59

io-wq: fix hang after cancelling pending hashed work BugLink: https://bugs.launchpad.net/bugs/1894956 commit 204361a77f4018627addd4a06877448f088ddfc0 upstream. Don't forget to update wqe->hash_tail after cancelling a pending work item, if it was hashed. Cc: stable@vger.kernel.org # 5.7+ Reported-by: Dmitry Shulyak <yashulyak@gmail.com> Fixes: 86f3cd1b589a1 ("io-wq: handle hashed writes in chains") Signed-off-by: Pavel Begunkov <asml.silence@gmail.com> Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

view details

push time in a day

PR merged pop-os/linux

Groovy kernel for focal

This will be integrated into a new master branch servicing both releases when approved. Make sure to test VirtualBox support, and the NVIDIA driver.

https://github.com/pop-os/dwarves is required, it is a backport of that package from groovy to focal to allow the kernel to build

+0 -0

0 comment

0 changed file

jackpot51

pr closed time in a day

PR closed pop-os/session

Reviewers
remove always show workspaces extension as GNOME does this by default

I believe this feature was added in GNOME 3.36 so we shouldn't need the extension any more for both 20.04 LTS or 20.10.

+0 -1

3 comments

1 changed file

ahoneybun

pr closed time in a day

push eventsystem76/qmk_firmware

Jeremy Soller

commit sha 0d55d047e332ba5968a661c4275b5644082a6e3c

Add RGB matrix support

view details

push time in a day

push eventsystem76/qmk_firmware

Jeremy Soller

commit sha 00ea663a1a82081dfd08f70bd719d1096e312110

Refactor

view details

push time in a day

pull request commentpop-os/session

remove always show workspaces extension as GNOME does this by default

I believe that even with 3.36 there were cases where the workspace switcher would disappear

ahoneybun

comment created time in a day

PullRequestReviewEvent
PullRequestReviewEvent

delete branch pop-os/mutter

delete branch : scaling_groovy

delete time in a day

push eventpop-os/mutter

Ian Douglas Scott

commit sha 2aea4b7c03074644c2f77632accbd59379ee1ee4

Enable x11-Add-support-for-fractional-scaling-using-Randr.patch This matches Ubuntu: https://salsa.debian.org/gnome-team/mutter/-/tree/ubuntu/master/debian/patches

view details

push time in a day

PR merged pop-os/mutter

groovy: Enable x11-Add-support-for-fractional-scaling-using-Randr.patch

Meant to address https://github.com/pop-os/mutter/issues/11.

+1 -1

0 comment

1 changed file

ids1024

pr closed time in a day

PullRequestReviewEvent

delete branch pop-os/gnome-control-center

delete branch : scaling_groovy

delete time in a day

push eventpop-os/gnome-control-center

Michael Aaron Murphy

commit sha 5394fbaf9793f40050a5ebefe85c983012ecd743

fix: Re-enable scaling patches on groovy Cherry-pick of 4494407 added to focal by #110.

view details

push time in a day

PR merged pop-os/gnome-control-center

groovy: Fractional scaling

Meant to address https://github.com/pop-os/mutter/issues/11.

Depends on Mutter change (https://github.com/pop-os/mutter/pull/12). This is just a cherry-pick to Groovy of the change added to Focal in https://github.com/pop-os/gnome-control-center/pull/110.

Testing in a VM, I fractional scaling controls appear, but I get some kind of funny behavior. Selecting 125% and applying, it seems to scale up correctly, but it still shows 100% selected...

+95 -96

3 comments

3 changed files

ids1024

pr closed time in a day

PullRequestReviewEvent

push eventsystem76/qmk_firmware

Jeremy Soller

commit sha 6397b6b8b8f3b961dfb359719411f588cc1633e4

Add fuse information

view details

push time in a day

push eventsystem76/qmk_firmware

Jeremy Soller

commit sha adacefed1fd1d0f8a549fc8e6280d77992c8d972

Add ISP instructions

view details

push time in a day

issue closedpop-os/pop

Evaluate packages that do not have groovy branches

Create master_groovy branches:

  • [x] gdm3
  • [x] gnome-control-center
  • [x] gnome-online-accounts
  • [x] gnome-settings-daemon
  • [x] gnome-shell
  • [x] gnome-shell-extension-system76-power
  • [x] gnome-terminal
  • [x] libhandy
  • [x] linux
  • [x] meta-python
  • [x] mutter
  • [x] pyflatpak
  • [x] python-apt
  • [x] shell
  • [x] shell-shortcuts
  • [x] steam
  • [x] systemd
  • [x] tensorman
  • [x] transition
  • [x] ubuntu-drivers-common

Verify package built on groovy:

  • [x] gdm3
  • [x] gnome-control-center
  • [x] gnome-online-accounts
  • [x] gnome-settings-daemon
  • [x] gnome-shell
  • [x] gnome-shell-extension-system76-power
  • [x] gnome-terminal
  • [x] libhandy
  • [x] linux
  • [x] meta-python
  • [x] mutter
  • [x] pyflatpak
  • [ ] python-apt
  • [x] shell
  • [x] shell-shortcuts
  • [x] steam
  • [x] systemd
  • [x] tensorman
  • [x] transition
  • [x] ubuntu-drivers-common

Ensure package is up to date with Ubuntu:

  • [x] gdm3
  • [x] gnome-control-center
  • [x] gnome-online-accounts
  • [x] gnome-settings-daemon
  • [x] gnome-shell
  • [x] gnome-terminal
  • [x] libhandy
  • [x] linux
  • [x] mutter
  • [ ] python-apt
  • [x] shell
  • [x] shell-shortcuts
  • [x] steam
  • [x] systemd
  • [x] ubuntu-drivers-common

closed time in 2 days

jackpot51

delete branch pop-os/repoman

delete branch : system-mirror-entry

delete time in 2 days

PullRequestReviewEvent

push eventpop-os/repoman

Ian Santopietro

commit sha bac40e2a6e2b0805d00833bcfd7bebd633710150

fix(settings): clean up this class a bit Use f-strings where we can, and split long strings over multiple lines.

view details

Ian Santopietro

commit sha b2e74c555b7f80bbba12d4623cb1577762bc4efb

feat(mirrors): add mirror entry on Settings page Allows users to change to a different mirror, or to use multiple mirrors. Fixes #23

view details

Ian Santopietro

commit sha 2383ab85b515417b6b8b3f0d3db667ab0fc84122

fix(settings): refresh UI only if there is a valid system_repo object

view details

Ian Santopietro

commit sha 41b17c9de804d3608b71cf3d3dba53b751511d55

feat(updates): add file monitor to updates page to allow feature-parity with Settings page

view details

Ian Santopietro

commit sha 7755da2dca2409233277d27c24c65b05c1e61a8e

fix(settings): remove errant debugging statement

view details

Ian Santopietro

commit sha c3594d8e20bb58f09b3821e00f1eec24d68d3390

fix: update pages to add/remove switches for new/removed components, where applicable

view details

Ian Santopietro

commit sha 18981709950b5d906c17138f99abec120655decf

bump: version 2.0.0 → 2.1.0

view details

Ian Santopietro

commit sha ea84441c621f9691db37fb5ef7675f2403cf9a75

fix(reset): add button to reset mirrors to default if there is a default set

view details

Ian Santopietro

commit sha 1555cb3e968282b8495855e6379b862b09f25712

feat(uri-validation): add uri validation to mirror input field

view details

push time in 2 days

issue closedpop-os/repoman

Feature request: Add an option to change the repos to the ones hosted in your country.

I really like the OS but downloading packages from the US servers is slow. It could use an option to check for repos that have the lowest ping to the user and set them. It would really improve the user experience for users from other countries.

closed time in 2 days

ghost

PR merged pop-os/repoman

feat: System mirror entry APT enhancement

Allows users to change to a different mirror, or to use multiple mirrors.

DeepinScreenshot_icon-library_20201013145847

Fixes #23

+251 -33

11 comments

4 changed files

isantop

pr closed time in 2 days

PullRequestReviewEvent

push eventsystem76/qmk_firmware

Jeremy Soller

commit sha 75f6c27763874dc9144c1e52d9ac1bd4969d1ccc

Fix extra start in i2c_set

view details

push time in 2 days

push eventsystem76/qmk_firmware

Jeremy Soller

commit sha ab571da499f1ec6443dee43335e6d7ec0fdac0b9

Fix when i2c read ack condition happens

view details

push time in 2 days

push eventsystem76/qmk_firmware

Jeremy Soller

commit sha 4b16b738f9864468bc9d6805b137440c99e8672d

Improve documentation

view details

push time in 2 days

issue commentsystem76/firmware-open

Beta test darp6 open EC firmware with MTRR allocation fix

Hi I am not sure if this is the right place to report this issue, but I have not been able to figure out a solution. Since the firmware upgrade to 904cee4, I have been experiencing the system not being able to charge to 100 percent, it reaches 98% and the machine starts emitting a high frequency buzzing sound, until I unplug the charging cable. The machine also gets very hot when charging, reaching 76C. I am not sure if this related to the firmware upgrade, but I have only begun to experience this following the upgrade. The only time I have been able to get it to charge to 100% is only when the system is in suspend mode. Thank you for reading.

Which model is this? Can you revert to proprietary EC?

jackpot51

comment created time in 2 days

PullRequestReviewEvent

push eventsystem76/qmk_firmware

Jeremy Soller

commit sha b8dc165074a78dbf746abf43d568398ab18eed96

Ensure bit shifts are correct

view details

push time in 2 days

push eventsystem76/qmk_firmware

Jeremy Soller

commit sha f9a05c49978bfcce7369d709826ac1a0ac8c9d29

Fix register write size for programmable function control

view details

push time in 2 days

push eventsystem76/qmk_firmware

Jeremy Soller

commit sha ce87dce512ceab65405de7125460d227e3467859

Allow repeat start

view details

Jeremy Soller

commit sha 562d06536fb7d0d7e18a63fd458147d2b58577c5

Do USB MUX init before bootmagic

view details

Jeremy Soller

commit sha 3d219ce2bdcb13426f4585b545725f09710fb51a

Fixes for mux init

view details

push time in 2 days

push eventsystem76/qmk_firmware

Jeremy Soller

commit sha 98ee802e3c559550820b43a237c426939625931e

Limit backlight brightness

view details

Jeremy Soller

commit sha 095533fcd3b5f0b5097708bc570fbc216d57d93d

USB mux handling

view details

push time in 2 days

delete branch pop-os/nvidia-graphics-drivers

delete branch : groovy

delete time in 2 days

push eventpop-os/nvidia-graphics-drivers

Jeremy Soller

commit sha 21eb2ec44de035dbece555f5cad9999325930898

Sync with Ubuntu packaging from groovy

view details

push time in 2 days

PR merged pop-os/nvidia-graphics-drivers

Sync with Ubuntu packaging from groovy

Changes between our packaging and Ubuntu's are minimized, version is incremented to supersede Ubuntu's

+166 -219

0 comment

12 changed files

jackpot51

pr closed time in 2 days

push eventsystem76/qmk_firmware

Jeremy Soller

commit sha f4b03b7e34613cb9f39b7a586c32a383c9bb552a

Fix building production hex file with atmel-dfu bootloader

view details

push time in 2 days

push eventsystem76/qmk_firmware

Jeremy Soller

commit sha 085106093cf696a0ddb5d1023550039c29540bfc

Add launch_beta_1

view details

push time in 2 days

PullRequestReviewEvent

push eventpop-os/gnome-shell

Jeremy Soller

commit sha f2c8ac6d433d7ced65679738d4fa9f810e7812f0

DROP ON REBASE: update changelog, again

view details

push time in 3 days

delete branch system76/thelio

delete branch : mega

delete time in 3 days

push eventsystem76/thelio

lindsey-system76

commit sha 3b485679f6ddf2d574468fdb62ec17248a5cbd15

Mega (#17) * Add Thelio Mega * Production Launch Update files to match production launch * Fix Errors fixed some naming errors on step file Co-authored-by: shpurk <benjamin@system76.com>

view details

push time in 3 days

PR merged system76/thelio

Reviewers
Mega

Updates to Mega to reflect changes for production

+81 -0

0 comment

59 changed files

lindsey-system76

pr closed time in 3 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventpop-os/linux

Jeremy Soller

commit sha 290028ef0805a5b5cd4d3d69f5e3ae22adb3d48d

DROP ON REBASE: 5.8.0-7625.26 based on 5.8.0-25.26 Signed-off-by: Jeremy Soller <jeremy@system76.com>

view details

push time in 3 days

issue commentpop-os/gnome-control-center

20.10: Fractional scaling switch not present

I think this is a mutter thing, we still have the patch commented out

leviport

comment created time in 3 days

PullRequestReviewEvent

push eventpop-os/dwarves

Jeremy Soller

commit sha d576fd11f80a31b313c12969a510d2d2086ad39e

DROP ON REBASE: copy lib/bpf from submodule

view details

push time in 3 days

push eventsystem76/ec

Jeremy Soller

commit sha 4225c937983c81dd5aa59d80b2e5b07580fc1482

Include common/macro.h in gpio.c

view details

Jeremy Soller

commit sha 1a46fc52a071538c08f3c442b905740b3eebeffa

Add lemp10 espi and update galp5 espi

view details

push time in 3 days

push eventsystem76/ec

Jeremy Soller

commit sha 93f3e93c79288732f75d1f0f9058a13d702feaf8

Update lemp10 GPIOs

view details

push time in 3 days

push eventpop-os/pop

Jeremy Soller

commit sha 6997d644b4b30e30f1ed1060f80ff716b6b26407

Upload dwarves to system76-dev

view details

push time in 3 days

create barnchpop-os/dwarves

branch : master_focal

created branch time in 3 days

push eventpop-os/pop

Jeremy Soller

commit sha d55a6cd687bcd24813a8e28bf9cbe002fb67275e

Update repos

view details

push time in 3 days

created repositorypop-os/dwarves

Pop!_OS fork of https://salsa.debian.org/debian/dwarves.git

created time in 3 days

PR opened pop-os/nvidia-graphics-drivers

Sync with Ubuntu packaging from groovy

Changes between our packaging and Ubuntu's are minimized, version is incremented to supersede Ubuntu's

+166 -219

0 comment

12 changed files

pr created time in 3 days

create barnchpop-os/nvidia-graphics-drivers

branch : groovy

created branch time in 3 days

delete branch pop-os/keyboard-configurator

delete branch : design_focal

delete time in 3 days

push eventpop-os/keyboard-configurator

Ian Douglas Scott

commit sha 044a2aa49d775daeb6114c7cac4b41c05151f390

improv: Define Page enum instead of just using strings Slightly more efficient, allows exhaustive matching, etc.

view details

Ian Douglas Scott

commit sha 73376a3bd749c859cb0aad3486d1789cd946bfbd

improv: Center main vbox I think it previously looked pretty bad full screen on a large display. This is an improvement, anyway.

view details

Ian Douglas Scott

commit sha a3427da30c1c71110c221e4b32637fde307a4ca8

fix: Margin in vbox instead of border on window

view details

Ian Douglas Scott

commit sha dce02a7838e9a842c8534ef7eb795e9cef48b6fc

improv: Wrap label onto two lines depending on length

view details

Ian Douglas Scott

commit sha e5f40ff88b5608329dd230f50f17f83c0baf2812

improv: Make ColorCircle a gtk widget

view details

Ian Douglas Scott

commit sha d388abf37e3ce33e86bdbd76a46758f1ba9fcdc7

improv: Make KeyboardColorButton a GTK widget This makes it possible to remove a `@strong` reference, preventing a reference cycle. Previously there was a reference cycle because the GTK widget needed a reference to `KeyboardColorButtonInner` for callbacks, and likewise that struct contained a reference to `KeyboardColorButtonInner`. The reference in the callback couldn't be weak, because in some uses it is expected that `KeyboardColorButton` may be dropped by code using the type, to just use the GTK widget. This adds a bit of boilerplate, but it's probably the cleanest way to avoid reference cycles. The cycle here prevented the `DaemonClient`'s drop from being called.

view details

Ian Douglas Scott

commit sha 911b89e415f74d55c64818632e2738e6db8d5b91

improv: Wait for child process in DaemonClient::drop This avoids the ugly main loop code, and prevents some error messages that was causing.

view details

Ian Douglas Scott

commit sha df9a1c2981c8d6bf56eb70d8aaee09b08ad974a1

improv: Add margins to buttons It will no longer allow the label text to press right against the border. Usually, this means word-wrapping is applied.

view details

Ian Douglas Scott

commit sha 48547f1ce6030869a2bf0fdc18f01180288a3e38

improv: Use `Page` struct for `Keyboard.page` There's some ugly use of `get_data()` here... If we had a GTK widget inheriting `gtk::Fixed` to use in it's place... GTK is a pain.

view details

Ian Douglas Scott

commit sha 20d2ec1baba0c77e3c3702876421ccde64ba6050

improv: Use gtk::Stack, gtk::StackSwitcher instead of gtk::Notebook This way we can place the `gtk::StackSwitcher` anywhere. For instance, in the headerbar as the mockup shows.

view details

Ian Douglas Scott

commit sha 90cc73a9962982957a9c77e315ae62ae4071c17f

fix: Use non-breaking switch for layer keys in picker.csv This seems to be the easiest way to prevent these keys from taking three lines. I don't necessarily like dealing with issues using unicode magic like this, but I guess it makes sense that the space in something like "layer 1" would be non-breaking.

view details

push time in 3 days

PR merged pop-os/keyboard-configurator

Reviewers
Several design changes
  • Center contents in a large window
  • Instead of specifying which key names have a newline, automatically line wrap based on size
  • Use gtk::Stack and gtk::StackSwitcher instead of gtk::Notebook
  • Fix a couple issues related to the main loop and properly exiting

The mockup seems to show a gtk::StackSwitcher in the headerbar. https://github.com/pop-os/keyboard-configurator/pull/7 is for using gtk::HeaderBar, but that may require a couple additional changes and testing for Windows and macOS.

+324 -190

3 comments

10 changed files

ids1024

pr closed time in 3 days

delete branch system76/edk2

delete branch : 9elements-sync

delete time in 3 days

push eventsystem76/edk2

Patrick Rudolph

commit sha e88dc61df6564ec7a4d6fae94c0f018a08a1b670

UefiPayloadPkg: Do not use made up UART defaults Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>

view details

Patrick Rudolph

commit sha 876c1d36b3d5298abea6dab404cd9bc2aeefd897

UefiPayloadPkg: Make TerminalDxe build time configurable As the TerminalDxe significantly slows down the boot menu rendering, disable it but default and add the option SERIAL_TERMINAL to enabled it for headless platforms. Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>

view details

Patrick Rudolph

commit sha d90d84a4f7417e5caa3d0616dba52e463aa687e0

UefipayloadPkg: Protect coreboot tables Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>

view details

Patrick Rudolph

commit sha 599f4a4ddd6979218479e8ca2ea4dac0b4a8c8e5

UefiPayloadPkg/Library/PciHostBridgeLib: Add warning for coreboot/EDK2 incompability EDK2 expects PCI bars to be continously be allocated without "gaps" of reserverd memory in between. coreboot places PCI bars anyware in the PCI MMIO space, interleaved with MMCONF and reserved I/O MMIO space. Warn about this behaviour and refuse to add the BAR to the PCI aperature as it would cause the PciHostBridgeDxe fo fail. Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>

view details

Patrick Rudolph

commit sha 83c68bbe1d4818dd933c5d835a5937240fde8051

UefiCpuPkg: Disable MTRR programming for UefiPayloadPkg The MTRRs have already been programmed by FSB. Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>

view details

Patrick Rudolph

commit sha 37ec7ab62f4d571f44d00d6c41db445342a744ea

UefiPayloadPkg: Fix TPM1.2 detection Check the actual TPM1.2 command response to prevent a false positive when talking to a TPM2.0. Tested using a ST33TPHF TPM 2.0. Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>

view details

Patrick Rudolph

commit sha 6ad3ee1be8b57313fb21791dc764c4de8f910eb3

UefiPayloadPkg: Fix build with TPM enabled Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>

view details

push time in 3 days

PR merged system76/edk2

Cherry-pick changes from 9elements

Cherry-pick small set of changes to reduce our diff to 9elements.

Should be no observable changes to users.

+141 -12

0 comment

11 changed files

crawfxrd

pr closed time in 3 days

delete branch pop-os/nvidia-graphics-drivers

delete branch : supported-gpus

delete time in 3 days

push eventpop-os/nvidia-graphics-drivers

Tim Crawford

commit sha e2c7bf860fb22ff434e9c8ece6f1a8b4e2095b49

Install supported-gpus.json Add the new doc file used to query GPU features and leave it uncompressed. gpu-manager 0.8.6 uses this to configure run-time power management.

view details

push time in 3 days

PR merged pop-os/nvidia-graphics-drivers

Install supported-gpus.json

Add the new doc file used to query GPU features. gpu-manager 0.8.6 uses this to configure run-time power management.

+5 -0

0 comment

3 changed files

crawfxrd

pr closed time in 3 days

push eventsystem76/firmware-open

Fabian Topfstedt

commit sha e00d08af3bae088235adb31f9fba11308f5d5847

Added libudev-dev for Pop!_OS My build failed on a Pop!_OS-Live-Stick until I installed `libudev-dev`. I don't remember if it was the firmware-open or the ec build that failed, but ec references deps.sh.

view details

Fabian Topfstedt

commit sha 3df8580f37b84b4b955a8c1d0cbbe9fb0ee2d1c9

adding systemd-devel (which provides libudev-devel) for Fedora/RedHat

view details

push time in 3 days

PR merged system76/firmware-open

Added libudev-dev for Pop!_OS

My build failed on a Pop!_OS-Live-Stick until I installed libudev-dev. I don't remember if it was the firmware-open or the ec build that failed, but ec references deps.sh.

+2 -0

2 comments

1 changed file

fabiant7t

pr closed time in 3 days

delete branch system76/firmware-open

delete branch : bump-toolchain

delete time in 3 days

push eventsystem76/firmware-open

Tim Crawford

commit sha e5abb6529bb301bc481d688840860d4665b14714

Update rust-toolchain to 2020-07-27

view details

push time in 3 days

PR merged system76/firmware-open

Update rust-toolchain to 2020-07-27

All submodules now build on 2020-07-27.

+8 -8

0 comment

6 changed files

crawfxrd

pr closed time in 3 days

PullRequestReviewEvent

push eventsystem76/ec

Jeremy Soller

commit sha 942d588666159ee6f8a4929812d4831656b94fe1

Add charger abstraction

view details

push time in 3 days

push eventsystem76/ec

Jeremy Soller

commit sha 5247838944e1632a0a0a636cea16a9061da0afd7

Copy lemp9 to lemp10

view details

push time in 3 days

more