issue commentgaearon/overreacted.io

Web site blocked for Cuba.

cc @rauchg — is there anything you can do to unblock Now in Cuba?

apenab

comment created time in 8 hours

issue closedfreeCodeCamp/devdocs

Wiki link points nowhere

<!-- Please read the contributing guidelines before opening an issue: https://github.com/freeCodeCamp/devdocs/blob/master/.github/CONTRIBUTING.md

To request a new documentation, or an update of an existing documentation, go here: https://trello.com/b/6BmTulfx/devdocs-documentation --> Hello, I was trying to look into the scraping tools documentation, the ReadMe file pointed to wiki and wiki ...is nowhere to be found?

closed time in 8 hours

al3xxx

issue commentfreeCodeCamp/devdocs

Wiki link points nowhere

Fixed by https://github.com/freeCodeCamp/devdocs/commit/122b7586e17175ae3007bbfd7e275f4440ed183e.

al3xxx

comment created time in 8 hours

push eventfreeCodeCamp/devdocs

Jed Fox

commit sha 122b7586e17175ae3007bbfd7e275f4440ed183e

Fix references to the wiki in README

view details

push time in 8 hours

push eventquip/prettier

Jed Fox

commit sha 9a22ed2ada777df196495029febaaa5aa2c65945

Fix formatting

view details

push time in 11 hours

issue commentprettier/prettier

[bug] Parameter names dropped in URLs with HTML entries

-[](http://example.com/path?a=1&b=2&=3)
+[](http://example.com/path?a=1&b=2&c=3)
TechQuery

comment created time in 13 hours

issue commentprettier/prettier

Please add a CLI argument that shows me what the changes are

because respectfully, it's pretty clear that you haven't actually read what I said yet

I did read everything you said. I’m sorry I wasn’t able to be more helpful.

StoneCypher

comment created time in 3 days

issue commentprettier/prettier

Please add a CLI argument that shows me what the changes are

i already explained that in great detail

I did a quick search of this page, and I don’t see you mentioning prettylint. Can you link me to that comment?

it's really weird that you've now proposed two alternate tools as surrogates for just making this one do what people actually need from it

Prettier tries to follow the UNIX philosophy of doing one thing well. In this case, that’s taking some code and formatting it. That means that instead of adding lots of different features to the core Prettier project (thereby making it slower and larger for everyone), we instead make it easy for tools like prettylint to integrate with Prettier and add useful features.

StoneCypher

comment created time in 3 days

issue commentprettier/prettier

Please add a CLI argument that shows me what the changes are

None of what you just said would have faced the example problem that I gave, or almost any of the others

How does prettylint not solve your problem?

StoneCypher

comment created time in 3 days

issue commentprettier/prettier

Please add a CLI argument that shows me what the changes are

Thank you for giving us more detail!

I think your teammate might be misunderstanding how Prettier integrates with ESLint. When you use eslint-config-prettier, all it does is disable all ESLint rules that check formatting. eslint-plugin-prettier runs Prettier directly, then does a diff between the input and the output and reports any differences (running ESLint with --fix will fix them automatically).

That should work if you’re only or primarily using Prettier for JavaScript/TypeScript. However, if you frequently use Prettier for other kinds of files, check out @ikatyang’s prettylint.

Another thing I’ll say is that many cases of Prettier apparently breaking code are actually Prettier showing that the code won’t do what it seems to do by pointing out syntax mistakes and correctly interpreting it.

Finally, once you get more used to using Prettier, I highly recommend installing an integration for whatever editor you use. This will allow Prettier to format your code when you save, which completely changes the coding experience. Instead of trying to conform to a style, you can just write your code out on one line, copy-paste without properly indenting, and more. Then, when you save, all the code will snap into the proper format. If it doesn’t, you’ll know there’s a syntax error somewhere even before you run a linter or tests.

StoneCypher

comment created time in 4 days

startedsw-yx/prettierpicker

started time in 4 days

issue commentprettier/prettier

React hooks array destructuring

Here’s an analysis of several popular styles, of which none recommend adding spaces there: https://github.com/prettier/prettier/issues/296#issuecomment-274840112

gnordhielm

comment created time in 4 days

startednate-parrott/aamoji

started time in 4 days

issue commentdesktop/desktop

Improve workflows with uncommitted changes

How about doing the same thing as the default clone directory — remember what was selected last time and preserve that choice?

billygriffin

comment created time in 4 days

issue commentprettier/prettier

Please add a CLI argument that shows me what the changes are

The reason we don’t provide descriptions of what needs to be changed is that’s not how Prettier works. Instead of having a bunch of rules and making sure the code follows them, we basically throw away your original formatting and replace it with our own.

StoneCypher

comment created time in 4 days

issue commentprettier/prettier

Please add a CLI argument that shows me what the changes are

Prettier has already introduced several bugs.

If you can make a reproducible example for these cases, we’d love to hear about and fix them. You can also run Prettier with the --debug-check argument, which will verify that the meaning of your code hasn’t been changed.

StoneCypher

comment created time in 4 days

Pull request review commentdenoland/deno

Add fetch local file

 export async function fetch(     headers = input.headers;   } +  // Fetching a local file+  // See RFC8089 : https://tools.ietf.org/html/rfc8089+  const m = url.match(/file:\/{1,5}(.*)/i);+  if (m && m[0]) {+    try {+      const f = await open(m[1]);+      const headers: [string, string][] = [];+      // TODO : Add return type. Using Deno_std media_types module+      const response = new Response(200, headers, f.rid);+      return response;+    } catch (e) {+      if (+        e instanceof DenoError &&+        (e as DenoError<ErrorKind.NotFound>).kind === ErrorKind.NotFound+      ) {+        return new Response(404, [], 0);+      } else {+        return new Response(500, [], 0);

Is there any metadata associated with this error? If so, would it make sense to JSON-encode it and put it as the body of this response?

zekth

comment created time in 4 days

issue commentdenoland/deno

Add style guide for commit messages

If you’re mainly committing via PRs, I’d suggest instead linting PR titles using a GitHub App instead, since those are much easier to edit and the “squash and merge” feature pretty much obliterates the commit messages anyway. This could work hand-in-hand with requiring CI to pass before merging, effectively blocking commits from being pushed to master directly.

ry

comment created time in 4 days

pull request commentprettier/prettier

Improved multiline closure comment detection

Looks like the changelog didn’t get updated. Can you add an entry for this change?

yangsu

comment created time in 4 days

issue commentprettier/prettier

[JSX] Remove braces around expressions of only elements

This is a good idea, but I’m not sure if it’s OK to change this here. We try not to alter the AST where possible, and changing this definitely changes the AST, so :shrug:

andrejewski

comment created time in 4 days

pull request commentprettier/prettier

Improved multiline closure comment detection

Restarted the CI.

yangsu

comment created time in 6 days

issue commentdenoland/deno_std

Snapshot testing

Here’s another proposal: eschew the JS format altogether

Deno snapshot v1, https://deno.land/std/testing/snapshot/v1.md

snapshot `test name here` [`foo`, `
  foo bar
`]

sh7dm

comment created time in 6 days

issue commentdenoland/deno_std

Snapshot testing

Jest uses this format:

// Jest Snapshot v1, https://goo.gl/fbAQLP

[ if the snapshot is single-line ]
exports[`test name here 1`] = `foo`

[ if the snapshot is multiline ]
exports[`test name here 2`] = `
foo
bar
`

My two snapshot proposals alter this in a few ways:

  1. Instead of using an implict comment, an explicit import is used.
  2. Instead of creating multiple snapshots for each test with repetitions of the test name, I use an array.
  3. ESM is used instead of CommonJS
sh7dm

comment created time in 6 days

issue commentprettier/prettier

YAML support for shared configurations

Why not use JS instead?

astorije

comment created time in 6 days

issue commentdenoland/deno_install

Install via npm

Here’s npm’s dispute resolution process which allows the takeover of a squatted package name: https://www.npmjs.com/policies/disputes

MarkTiedemann

comment created time in 6 days

issue commentdenoland/deno_install

Install via npm

This would also be nice since npx has a automatic fallback feature that lets you run a command like node@4 foo.js to download/install the relevant node version, then run it.

MarkTiedemann

comment created time in 6 days

issue commentdenoland/deno

during tools/lint.py the following warning happens

@typescript-eslint/parser has a warnOnUnsupportedTypeScriptVersion option which, if set to false, will disable this warning.

ry

comment created time in 6 days

issue commentprettier/prettier

--quote-props=consistent unexpectedly amends class method names

Reported to TypeScript too: https://github.com/Microsoft/TypeScript/issues/31020

kachkaev

comment created time in 6 days

issue openedMicrosoft/TypeScript

TypeScript doesn’t properly handle a constructor with a quoted name

<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨

Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a bug, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!

Please help us by doing the following steps before logging an issue:

  • Search: https://github.com/Microsoft/TypeScript/search?type=Issues
  • Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ

Please fill in the entire template below. -->

<!-- Please try to reproduce the issue with typescript@next. It may have already been fixed. --> TypeScript Version: 3.5.0-dev.20190418

<!-- Search terms you tried before logging this (so others can find this issue more easily) --> Search Terms: typescript quoted constructor

Code

class Foo {
    constructor(name: string) {
      this.name = name
    }
}
class Bar {
    "constructor"(name: string) {
      this.name = name
    }
}

new Foo("hello")
new Bar("hello")

Expected behavior: Compiles without error

Actual behavior: The new Foo call compiles properly, but the new Bar call produces a type checking error:

test.ts:9:9 - error TS2554: Expected 0 arguments, but got 1.

9 new Bar("hello")
          ~~~~~~~

Note that running the code (with the type assertions stripped) results in both constructors being called, but TypeScript’s ES5 transpilation instead sets the second constructor as a method named constructor, which causes it not to be run.

Playground Link: Open playground ↗️

Related Issues: Encountered in https://github.com/prettier/prettier/issues/6063.

created time in 6 days

issue commentprettier/

--quote-props=consistent doesn't add quotes around number but it is required for consistency

This is because the properties of an ObjectLiteral expression allow an identifier, string literal, or numeric literal as the property key. We currently convert literal strings to identifiers (and vice versa), but this doesn’t seem to apply to numeric literals.

wincent

comment created time in 6 days

issue commentprettier/

--quote-props=consistent doesn't add quotes around number but it is required for consistency

This is because the properties of an ObjectLiteral expression allow an identifier, string literal, or numeric literal as the property key. We currently convert literal strings to identifiers (and vice versa), but this doesn’t seem to apply to numeric literals.

wincent

comment created time in 6 days

issue commentprettier/prettier

No line breaks for very long arrays?

This is because the second array probably goes past the printWidth, so it’s broken onto multiple lines.

cangoektas

comment created time in 6 days

issue closedfreeCodeCamp/devdocs

Angular 7?

What about adding the documentation of angular 7?

closed time in 7 days

SixiCat

issue commentfreeCodeCamp/devdocs

Angular 7?

Please use the Trello board (there’s a link in the issue template) to suggest new docs. The issue tracker is only for bugs/feature requests for the app itself.

SixiCat

comment created time in 7 days

issue commentdenoland/deno_std

Snapshot testing

What should the format be? Jest uses a CommonJS-inspired format, so here’s a few suggestions:

// test code
test(function doThingA() {
  assertMatchesSnaphot(foo)
})
test({
  name: 'do thing B',
  fn() {
    assertMatchesSnaphot(foo)
  }
})

// option 1
import 'https://deno.land/std/testing/snapshot_v1.ts'
export default {
  doThingA: [`
    blah blah
  `],
  'do thing B': [`
    blah blah
  `]
}

// option 2
import 'https://deno.land/std/testing/snapshot_v1.ts' 

export const doThingA = [`
  blah blah
`]
export const do__thing__B = [`
  blah blah
`]
sh7dm

comment created time in 7 days

issue commentgaearon/overreacted.io

Web site blocked for Cuba.

Does https://carbon.now.sh work for you? It runs on the same hosting platform.

apenab

comment created time in 8 days

fork j-f1/deno_std

deno standard modules

https://deno.land/x/

fork in 9 days

Pull request review commentdenoland/deno_std

fs utils getFileInfoType() return undefined when not found

 import * as path from "./path/mod.ts";  * @param src src file path  * @param dest dest file path  * @param sep path separator+ * @returns boolean

This line should be inferred by TypeScript. If you want to document the return value, you don’t need to provide a type here.

axetroy

comment created time in 9 days

pull request commentprettier/prettier

Add exit code information to cli docs

Thanks for contributing to Prettier!

jamesgeorge007

comment created time in 9 days

push eventprettier/prettier

James George

commit sha ed15b6d04e60a75d81c406ee899a86690187d44e

Add exit code information to cli docs (#6049) * Update docs :+1: Add information regarding exit codes to the cli docs * Markdown fix :construction: Docs linting fixes * Remove extraneous whitespace

view details

push time in 9 days

PR merged prettier/prettier

Add exit code information to cli docs

Closes #5896

Add CLI existing status information the the docs.

<!-- Please provide a brief summary of your changes: -->

<!-- Please ensure you’ve done all of these things (if applicable). --> <!-- You can replace the [ ] with [x] to mark each task as done. -->

  • [ ] I’ve added tests to confirm my change works.
  • [ ] (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • [ ] (If the change is user-facing) I’ve added my changes to the CHANGELOG.unreleased.md file following the template.
  • [x] I’ve read the contributing guidelines.
+8 -0

3 comments

1 changed file

jamesgeorge007

pr closed time in 9 days

issue closedprettier/prettier

CLI exit status not documented

Apparently, prettier can terminate with exit status 0, 1 and 2. However, I found no documentation specifying what differs between exit status 1 and 2.

closed time in 9 days

Eeemil

delete branch j-f1/forked-ghost-lang

delete branch : more-symbol-syntax

delete time in 9 days

delete branch j-f1/forked-ghost-lang

delete branch : less-than-greater-than

delete time in 9 days

issue commentprettier/prettier

JSDoc Plugin

See #5659

arv

comment created time in 10 days

issue commentprettier/prettier

JSON without comment should print as `json-stringify`

The json-stringify parser is used for files that are automatically altered, like package-lock.json. Why do you want the newlines removed?

fisker

comment created time in 10 days

issue commentjhipster/prettier-java

JSDoc Plugin

I don’t think there’s a way to do this as a plugin, but I’d appreciate having it as part of Prettier core.

cc @prettier/core what do you think?

arv

comment created time in 10 days

issue commentprettier/prettier

Unsafe Eval Causing Problems in Prettier-Atom After 1.17

Looks like it’s an issue with our TOML parser, which runs this:

eval(`require('util').inspect`)
robwise

comment created time in 11 days

Pull request review commentgithub/site-policy

Updates to the Corporate Terms of Service - Winter 2019

 In some situations, third parties' terms may apply to your use of GitHub. For ex  If you are a government User or otherwise accessing or using any GitHub Service in a government capacity, this [Government Amendment to GitHub Terms of Service](/articles/amendment-to-github-terms-of-service-applicable-to-u-s-federal-government-users/) applies to you, and you agree to its provisions. -If you have signed up for GitHub Business Cloud, the [Business Cloud Addendum](/articles/github-business-cloud-addendum/) applies to you, and you agree to its provisions.+If you have signed up for GitHub Enterprise Cloud, the [Enterprise Cloud Addendum](/articles/github-enterprise-cloud-addendum/) applies to you, and you agree to its provisions.  ### C. Acceptable Use **Short version:** *GitHub hosts a wide variety of collaborative projects from all over the world, and that collaboration only works when our users are able to work together in good faith. While using the service, you must follow this Acceptable Use Policy, which includes some restrictions on content you can post, conduct on the service, and other limitations. In short, be excellent to each other.*  #### 1. Compliance with Laws and Regulations-Your use of the Website and Service must not violate any applicable laws, including copyright or trademark laws, export control laws, or other laws in your jurisdiction. You are responsible for making sure that your and your Users' use of the Service is in compliance with laws and any applicable regulations.+Your use of the Website and Service must not violate any applicable laws, including copyright or trademark laws, export control or sanctions laws, or other laws in your jurisdiction. You are responsible for making sure that your and your Users' use of the Service is in compliance with laws and any applicable regulations.

Ok, that makes more sense. Thanks for responding!

vollmera

comment created time in 12 days

Pull request review commenttypescript-eslint/typescript-eslint

feat: Move shared types into their own package

 export default util.createRule({      return {       AwaitExpression(node) {-        const originalNode = parserServices.esTreeNodeToTSNodeMap.get(-          node,-        ) as ts.AwaitExpression;+        const originalNode = parserServices.esTreeNodeToTSNodeMap.get<+          ts.AwaitExpression+        >(node);

Is this explicit cast still necessary? Is it possible to more strongly type this map? Should we instead provide an accessor function that is more type-safe (by converting the type of the passed-in node to the type of the returned node)?

bradzacher

comment created time in 12 days

push eventduailibe/prettier

Jed Fox

commit sha 53029ab5ed4ff153b614c38dfa5a91f46d155512

Copy edit

view details

push time in 12 days

push eventjamesgeorge007/prettier

Jed Fox

commit sha 0ec0e210ef272bbf03435ea8af015d4cdc0b3492

Remove extraneous whitespace

view details

push time in 12 days

Pull request review commentgithub/site-policy

Updates to the Corporate Terms of Service - Winter 2019

 In some situations, third parties' terms may apply to your use of GitHub. For ex  If you are a government User or otherwise accessing or using any GitHub Service in a government capacity, this [Government Amendment to GitHub Terms of Service](/articles/amendment-to-github-terms-of-service-applicable-to-u-s-federal-government-users/) applies to you, and you agree to its provisions. -If you have signed up for GitHub Business Cloud, the [Business Cloud Addendum](/articles/github-business-cloud-addendum/) applies to you, and you agree to its provisions.+If you have signed up for GitHub Enterprise Cloud, the [Enterprise Cloud Addendum](/articles/github-enterprise-cloud-addendum/) applies to you, and you agree to its provisions.  ### C. Acceptable Use **Short version:** *GitHub hosts a wide variety of collaborative projects from all over the world, and that collaboration only works when our users are able to work together in good faith. While using the service, you must follow this Acceptable Use Policy, which includes some restrictions on content you can post, conduct on the service, and other limitations. In short, be excellent to each other.*  #### 1. Compliance with Laws and Regulations-Your use of the Website and Service must not violate any applicable laws, including copyright or trademark laws, export control laws, or other laws in your jurisdiction. You are responsible for making sure that your and your Users' use of the Service is in compliance with laws and any applicable regulations.+Your use of the Website and Service must not violate any applicable laws, including copyright or trademark laws, export control or sanctions laws, or other laws in your jurisdiction. You are responsible for making sure that your and your Users' use of the Service is in compliance with laws and any applicable regulations.

The reason I proposed this change is that “sanctions laws” seemed like a strange phrasing and Google ngrams confirms that “sanctions laws” is much rarer than just “sanctions” alone.

vollmera

comment created time in 12 days

issue commentprettier/prettier

Feature Request: breakBeforeElse

@jhildenbiddle How often does that kind of code come up though?

vishnevskiy

comment created time in 13 days

push eventtypescript-eslint/typescript-eslint

Matt Kantor

commit sha 12d47ae500f3618123e24d2717709c51ad813919

docs(eslint-plugin): `as const` with no-object-literal-type-assertion (#419) This doc change was overlooked when the feature was added in b70c283.

view details

Jed Fox

commit sha 9d0a5bbf9b5d1b78a2a1a3577a4e92c196a0da87

Merge branch 'master' into no-unused-vars-roadmap

view details

push time in 15 days

issue commentdesktop/desktop

Format the ahead/behind count in a locale-aware manner

I think it’s not too urgent because (a) commits don’t come in fractions and (b) it’s likely users from countries that use commas as decimal points will have some familiarity with the use of periods, so they’d get the message. Another alternative is to switch to spaces (“61 083”) although I’m not sure how familiar the general population is with that format.

joshaber

comment created time in 15 days

Pull request review commentgithub/site-policy

Updates to the Corporate Terms of Service - Winter 2019

 Thank you for choosing GitHub for your company's business needs. Please read our | [O. Disclaimer of Warranties](#o-disclaimer-of-warranties) | We provide our service as is, and we make no promises or guarantees about this service. **Please read this section carefully; you should understand what to expect.** | | [P. Limitation of Liability](#p-limitation-of-liability) | Situations where either of us will be liable to the other for damages or losses arising from your use or inability to use the service or otherwise arising under this agreement are limited. **Please read this section carefully; it limits our obligations to you.** | | [Q. Release and Indemnification](#q-release-and-indemnification) | You are fully responsible for your and your Users' use of the service. |-| [R. Changes to these Terms of Service](#r-changes-to-these-terms) | We may modify this agreement, but we will give you 30 days' notice of changes that affect your rights. |-| [S. Miscellaneous](#s-miscellaneous) | Please see this section for legal details including our choice of law. |+| [R. Confidentiality](#r-confidentiality) | We each have some responsibility to protect each other’s Confidential Information |+| [S. Professional Services](#s-professional-services) | You may purchase Professional Services in connection with your use of the Website or Service. . |+| [T. Changes to these Terms of Service](#t-changes-to-these-terms) | We may modify this agreement, but we will give you 30 days' notice of changes that affect your rights. |+| [U. Miscellaneous](#u-miscellaneous) | Please see this section for legal details including our choice of law. |  ### The GitHub Corporate Terms of Service-Effective date: May 25, 2018+Effective date: April 19, 2019  ### A. Definitions **Short version:** *We use these basic terms throughout the agreement, and they have specific meanings. You should know what we mean when we use each of the terms. There's not going to be a test on it, but it's still useful information.* -1. The “Agreement” refers, collectively, to all the terms, conditions, notices contained or referenced in this document (the “Corporate Terms of Service” or the "Terms") and all other operating rules, policies (including the GitHub Privacy Statement, available at [github.com/site/privacy](https://github.com/site/privacy)) and procedures that we may publish from time to time on the Website. Most of our site policies are available at [help.github.com/categories/site-policy](/categories/site-policy/).-2. The “Service” refers to the applications, software, products, and services provided by GitHub.-3. The “Website” refers to GitHub’s website located at [github.com](https://github.com/), and all content, services, and products provided by GitHub at or through the Website. It also refers to GitHub-owned subdomains of github.com, such as [education.github.com](https://education.github.com/) and [pages.github.com](https://pages.github.com/). These Terms also govern GitHub’s conference websites, such as [githubuniverse.com](https://githubuniverse.com/), and product websites, such as [atom.io](https://atom.io/). Occasionally, websites owned by GitHub may provide different or additional terms of service. If those additional terms conflict with this Agreement, the more specific terms apply to the relevant page or service.-4. "Customer", “You,” and “Your” refer to the company, or organization that has visited or is using the Website or Service; that accesses or uses any part of the account; or that directs the use of the account in the performance of its functions. Special terms may apply for business or government accounts (See [Section B(7): Additional Terms](#7-additional-terms)).-5. "User" refers to the individual who has visited or is using the Website or Service on your behalf; that accesses or uses any part of the account on your behalf; or that directs the use of the account in the performance of their functions on your behalf. All Users must be at least 13 years of age. "Other Users" refers to the individuals, not including your Users, who visit or use the Website or Service. “Users” and “Other Users” are collectively referred to as “All Users”.-6. “GitHub,” “We,” and “Us” refer to GitHub, Inc., as well as our affiliates, directors, subsidiaries, contractors, licensors, officers, agents, and employees.-7. An "Account" represents your legal relationship with GitHub. A “User Account” represents an individual User’s authorization to log in to and use the Service and serves as a User’s identity on GitHub. A "Corporate Account" refers to an Account created by a User on behalf of an entity, such as a company, non-profit organization, or group. A Corporate Account may include a Business Cloud subscription or a Team plan. “Organizations” are shared workspaces that may be associated with a single entity or with one or more Users where multiple Users can collaborate across many projects at once. A User Account can be a member of any number of Organizations.-8. “Content” refers to content featured or displayed through the Website, including without limitation text, data, articles, images, photographs, graphics, software, applications, designs, features, and other materials that are available on the Website or otherwise available through the Service. "Content" also includes Services. “User-Generated Content” is Content, written or otherwise, created or uploaded by All Users. "Your Content" is Content that you create, own, or to which you are the rights holder.+1. “Affiliate” refers to any entity that directly or indirectly controls, is controlled by, or is under common control with a party where "control" means having more than fifty percent (50%) ownership or the right to direct the management of the entity.+2. The “Agreement” refers, collectively, to all the terms, conditions, notices contained or referenced in this document (the “Corporate Terms of Service” or these "Terms") and all other operating rules, policies (including the GitHub Privacy Statement, available at [github.com/site/privacy](https://github.com/site/privacy)) and procedures that we may publish from time to time on the Website. Most of our site policies are available at [help.github.com/categories/site-policy](/categories/site-policy/).+3. The “Service” refers to the applications, software, products, and services provided by GitHub.+4. The “Website” refers to GitHub’s website located at [github.com](https://github.com/), and all content, services, and products provided by GitHub at or through the Website. It also refers to GitHub-owned subdomains of github.com, such as [education.github.com](https://education.github.com/) and [pages.github.com](https://pages.github.com/). These Terms also govern GitHub’s conference websites, such as [githubuniverse.com](https://githubuniverse.com/), and product websites, such as [atom.io](https://atom.io/). Occasionally, websites owned by GitHub may provide different or additional terms of service. If those additional terms conflict with this Agreement, the more specific terms apply to the relevant page or service.+5. "Customer", “You,” and “Your” refer to the company, or organization that has visited or is using the Website or Service; that accesses or uses any part of the Account; or that directs the use of the account in the performance of its functions. Special terms may apply for business or government accounts (See [Section B(7): Additional Terms](#7-additional-terms)).+6. "User" refers to the individual who has visited or is using the Website or Service on your behalf; that accesses or uses any part of the account on your behalf; or that directs the use of the account in the performance of their functions on your behalf. All Users must be at least 13 years of age. "Other Users" refers to the individuals, not including your Users, who visit or use the Website or Service. “Users” and “Other Users” are collectively referred to as “All Users”.+7. “GitHub,” “We,” and “Us” refer to GitHub, Inc., as well as our affiliates, directors, subsidiaries, contractors, licensors, officers, agents, and employees.+8. An "Account" represents your legal relationship with GitHub. A “User Account” represents an individual User’s authorization to log in to and use the Service and serves as a User’s identity on GitHub. A "Corporate Account" refers to an Account created by a User on behalf of an entity, such as a company, non-profit organization, or group. A Corporate Account may include an Enterprise Cloud subscription or a Team plan. “Organizations” are shared workspaces that may be associated with a single entity or with one or more Users where multiple Users can collaborate across many projects at once. A User Account can be a member of any number of Organizations.+9. “Content” refers to content featured or displayed through the Website, including without limitation text, data, articles, images, photographs, graphics, software, applications, designs, features, and other materials that are available on the Website or otherwise available through the Service. “User-Generated Content” is Content, written or otherwise, created or uploaded by All Users. "Your Content" is Content that you create, own, or to which you are the rights holder.+10. "Professional Services" means training, consulting, or implementation services that GitHub provides to you pursuant to a mutually executed SOW. Professional Services do not include Support.+11. "SOW" means a mutually executed statement of work detailing the Professional Services GitHub will perform for you, any related Fees, and each party's related obligations.

Looks like it’s rendered to me: https://help.github.com/en/articles/github-corporate-terms-of-service

vollmera

comment created time in 15 days

issue commentprettier/eslint-plugin-prettier

README: simplify instructions to integrate eslint-config-prettier

I like it because it also adds the prettier/prettier rule.

lunelson

comment created time in 15 days

issue commentprettier/prettier

CLI exit status not documented

You could put it in a new section of the CLI docs.

Eeemil

comment created time in 15 days

Pull request review commentdenoland/deno_std

add json type for readJson/writeJson

 // Copyright 2018-2019 the Deno authors. All rights reserved. MIT license. +export type JSONPrimitive = string | number | boolean | null;+export type JSONValue = JSONPrimitive | JSONObject | JSONArray;+export interface JSONObject {+  [member: string]: JSONValue;+}+// eslint-disable-next-line @typescript-eslint/no-empty-interface+export interface JSONArray extends Array<JSONValue> {}

Why can’t this use a type instead of an interface?

axetroy

comment created time in 17 days

pull request commentshiftkey/desktop

use the app menu bar for Linux instead of the default chrome

How does this interact with themes with custom title bar layouts?

shiftkey

comment created time in 17 days

issue commentprettier/prettier

Markdown: `--prose-wrap never` is giving extra line-break when using >- for multiline frontmatter

Also reproduces with the plain YAML parser:

Prettier 1.16.4 Playground link

--html-whitespace-sensitivity ignore
--parser yaml
--prose-wrap never

Input:

title: 'Testing 123'
author: jimbo
tags:
  - some
  - tag
teaser1: |-
  Starting a blog is great
teaser2: >-
  Starting a blog is great
tester1:
  - test: |-
      Lorizzle ipsizzle dolizzle pot amizzle  
  - test: |-
      Lorizzle ipsizzle dolizzle pot amizzle
  - test: |-
      Lorizzle ipsizzle dolizzle pot amizzle
  
  - test: |-
      Lorizzle ipsizzle dolizzle pot amizzle
tester2:
  - test: >-
      Lorizzle ipsizzle dolizzle pot amizzle  
  - test: >-
      Lorizzle ipsizzle dolizzle pot amizzle
  - test: >-
      Lorizzle ipsizzle dolizzle pot amizzle

  - test: >-
      Lorizzle ipsizzle dolizzle pot amizzle

Output:

title: "Testing 123"
author: jimbo
tags:
  - some
  - tag
teaser1: |-
  Starting a blog is great
teaser2: >-
  Starting a blog is great

tester1:
  - test: |-
      Lorizzle ipsizzle dolizzle pot amizzle
  - test: |-
      Lorizzle ipsizzle dolizzle pot amizzle
  - test: |-
      Lorizzle ipsizzle dolizzle pot amizzle

  - test: |-
      Lorizzle ipsizzle dolizzle pot amizzle
tester2:
  - test: >-
      Lorizzle ipsizzle dolizzle pot amizzle  

  - test: >-
      Lorizzle ipsizzle dolizzle pot amizzle

  - test: >-
      Lorizzle ipsizzle dolizzle pot amizzle
      

  - test: >-
      Lorizzle ipsizzle dolizzle pot amizzle

sanscheese

comment created time in 19 days

issue commentschohariedemocrats/schohariedemocrats.github.io

Does the National Party have an official platform?

The party platform is available as HTML or as a PDF, and it’s updatedi every presidential election year.

ironwallaby

comment created time in 19 days

startedwashingtonpost/data-school-shootings

started time in 20 days

CommitCommentEvent

issue openedsindresorhus/refined-github

Remove the edit button from the issue comment dropdown menu

Refined GitHub now adds an edit button ✏️ to issue comments that you’re able to edit. Shouldn’t it remove the “Edit” menu item from the “⋯” menu (and one of the separators if needed) to reduce duplication?

image

created time in 20 days

issue commentdesktop/desktop

Chrome OS Support

Check out https://GitHub.com/shiftkey/desktop/releases @jatin-cbs.

justingolden21

comment created time in 21 days

issue commentdenoland/deno_std

Testing: mock functions

Looks like it requires porting since it doesn’t use extensions in its imports.

sh7dm

comment created time in 21 days

issue commentCharcoal-SE/SmokeDetector

Need a way for SD increase the rate it reports posts in chat (e.g. multiple posts in one message?)

Moving socketscience to Stack Overflow would remove that as an issue.

How about creating “SmokeDetector 2” and “SmokeDetector 3” accounts? This would allow for the running instance to automatically switch accounts when it gets close to being rate limited.

makyen

comment created time in 21 days

issue commentfkling/astexplorer

Flow typecast works with AST but causes error in jscodeshift

This is because you can’t currently change the parser used by the transformer. Changing the parser just changes the AST tree view.

Daniel15

comment created time in 21 days

pull request commentprettier/prettier

Teach prettier/graphql about formatting fragment variables.

@duailibe referring to your previous comment above about supporting experimental features. I was wondering if we should have a policy that we’ll stay up to date with breaking changes to proposals for JS in minor versions.

adek05

comment created time in 22 days

issue commenttypescript-eslint/typescript-eslint

Documentation: Getting Started Guide and User Journeys

That’s intentional behavior @deser. We recommend you run TypeScript directly to catch type errors like that and run ESLint to catch other types of issues.

JamesHenry

comment created time in 23 days

issue commentprettier/prettier

Don’t multi-line imports (let them take less space) / Conflict with VSCode’s organizeImports

That’s actually a good idea @lydell!

DmitryKoterov

comment created time in 23 days

issue commentEbenSorkin/Merriweather-Sans

Lining numbers

Thanks for getting back to me! When I’ve seen this happen in the past, the original repo is usually transferred to the organization. As long as you don’t fork it back to your account, all links will redirect to the new repo and you won’t have to worry about having multiple copies.

AmiciA

comment created time in 23 days

pull request commenttypescript-eslint/typescript-eslint

docs(eslint-plugin): fix markdown format

Thanks for contributing!

teppeis

comment created time in 23 days

push eventtypescript-eslint/typescript-eslint

Teppei Sato

commit sha 5d81f8c88aea0413ab04a5040ad4fb99a2313b8b

docs(eslint-plugin): fix markdown format (#394)

view details

push time in 23 days

pull request commentprettier/prettier

Teach prettier/graphql about formatting fragment variables.

Should we have a policy that semver doesn’t apply to stage-x JS features?

adek05

comment created time in 23 days

issue commentEbenSorkin/Merriweather-Sans

Lining numbers

Why the fork @EbenSorkin?

AmiciA

comment created time in 23 days

pull request commentprettier/prettier

Teach prettier/graphql about formatting fragment variables.

Sorry to not have asked for all these things at once. How are the fragment variables specified when using the fragment? Does there need to be printing support for that too?

adek05

comment created time in 24 days

pull request commentprettier/prettier

Upgrade graphql-js to 14.2.0

I want to wait until tomorrow so maintainers from different time zones or who don’t do OSS on weekends can take a look at it.

adek05

comment created time in 24 days

issue commentdesktop/dugite

replace request dependency with got to install the right native package

When I need to do HTTP requests in Node, I use node-fetch or isomorphic-fetch since the fetch API is pretty easy to use and it’s supported in the browser too.

shiftkey

comment created time in 24 days

pull request commentprettier/prettier

Teach prettier/graphql about formatting fragment variables.

Can you add a test with multiple fragment variables so the variable section is forced to break onto multiple lines?

adek05

comment created time in 25 days

issue commentprettier/prettier-atom

Different config options for CSS vs JS

I don’t think so.

keithjgrant

comment created time in 25 days

issue commentskulpt/skulpt

Minimum JavaScript version?

#719

LeszekSwirski

comment created time in 25 days

pull request commentprettier/prettier

Teach prettier/graphql about formatting fragment variables.

In the JS parser, we support (I believe) all the syntax proposals Babel does, so I think we should do the same here.

adek05

comment created time in 25 days

pull request commentfreeCodeCamp/devdocs

Add Enzyme documentation

The freeCodeCamp folks are working on something to do with their main product, but they’ll be putting more time into this once that’s done.

jmerle

comment created time in 25 days

pull request commenttc39/proposal-realms

Move Shim

Would it be possible to rewrite the tests in such a way that they can be run on either a native JS Realm implementation of the shim? If so, you could keep the test code here and import it into the shim repo to ensure compliance.

katelynsills

comment created time in 25 days

issue commenttypescript-eslint/typescript-eslint

[restrict-plus-operands] Allowing any for summands

Shouldn’t any + any be allowed though?

kachkaev

comment created time in a month

pull request commentfreeCodeCamp/devdocs

Add WordPress documentation

We’re still working on the process Thibaut mentioned. Also looks like @jukefr left some suggested changes above.

LeGaS

comment created time in a month

pull request commentfacebook/jsx

Adding Contributing file

Should this say “JSX” instead of “jsx”?

facebook-github-bot

comment created time in a month

pull request commentdenoland/deno

Expose deno.exit() and add test.

Just noticed this API and I’m wondering if it would make sense to instead have a throw-based API:

throw Deno.exit(0)

A downside of this is that it can be caught, but it works with TypeScript’s type checker better since it realizes that throw breaks out of the current function.

ry

comment created time in a month

issue commentprettier/prettier

Don’t multi-line imports (let them take less space) / Conflict with VSCode’s organizeImports

We probably won’t add an option for this, but I recommend:

  • opening a bug report in the VS Code repo (if there isn’t one already) about the comment issue
  • forking this repo (https://github.com/prettier/prettier/fork) so you can publish your branch for others to use

I’d also encourage you to use your forked version — we’re perfectly fine with that if you can’t use the official version of Prettier.

Finally, have you considered authoring types for the non-typed modules you have? It would fix your whole problem.

DmitryKoterov

comment created time in a month

pull request commentprettier/prettier

Add parentheses for immediately-constructed fn/class

@bakkot I typically merge if there are several approvals, nobody’s commented disapprovingly, and it’s been at least 24 hours.

bakkot

comment created time in a month

startedtc39/proposal-decorators

started time in a month

delete branch j-f1/forked-octicons

delete branch : add-types

delete time in a month

issue commentprettier/prettier

prettier-cli not error in terminal

👍 as long as a prettier-ignore before the embed will suppress the error.

isoftninja

comment created time in a month

pull request commentprettier/prettier

Add doc build

Yep, it’s available as require('prettier').doc.

rattrayalex

comment created time in a month

pull request commentprettier/prettier

Add doc build

Isn’t this already part of the public API @lydell?

rattrayalex

comment created time in a month

pull request commentdenoland/deno_std

Added path library.

You should be able to use it:

import * as path from "https://deno.land/std/fs/path.ts";
lisniuse

comment created time in a month

more