profile
viewpoint
Jed Fox j-f1 student @ Brown University Providence, RI https://j-f1.github.io 🗣 he/him

push eventj-f1/read262

Jed Fox

commit sha 41a0491a7ef4f6da23d2645951f9f280346e8739

Update node version

view details

Jed Fox

commit sha 92f2d993c64e3dc4551c8728325e52ca5f3c47d6

Create .nvmrc

view details

push time in a day

push eventj-f1/read262

Jed Fox

commit sha c873f761bb6060efd81a8ab6db372608f19871e4

Fix site

view details

push time in a day

startedRedHatBrand/Overpass

started time in a day

issue commentprettier/prettier

The return statement has double parentheses if having jsdoc head

This is still a bug which should be fixed though:

Prettier 1.18.2 Playground link

--parser babylon

Input:

/**
 * @type {object}
 */
() => (
  <div>
    sajdfpoiasdjfpoiasdjfpoiasdjfpoiadsjfpaoisdjfapsdiofjapioisadfaskfaspiofjp
  </div>
);

Output:

/**
 * @type {object}
 */
() => ((
  <div>
    sajdfpoiasdjfpoiasdjfpoiasdjfpoiadsjfpaoisdjfapsdiofjapioisadfaskfaspiofjp
  </div>
));

debuggy

comment created time in 2 days

pull request commentdenoland/registry

Extract the embedded HTML/CSS out of the code render page

No worries!

j-f1

comment created time in 4 days

delete branch j-f1/forked-denoland-registry

delete branch : static-files

delete time in 4 days

push eventj-f1/forked-denoland-registry

Jed Fox

commit sha 75137f1f459ff14f63a9348a2fcbc7bb885695b4

Fix

view details

push time in 4 days

pull request commentdenoland/registry

Extract the embedded HTML/CSS out of the code render page

Rebased 👍

j-f1

comment created time in 4 days

push eventj-f1/forked-denoland-registry

Yoshiya Hinosawa

commit sha 720aa48e735cbb91c14d2b55eb39f5dc5b165990

feat: add ms (#155)

view details

syumai

commit sha 0e4c83c5847fe5b727a875d68d4bcada253c109a

Added syumai/dem (#156)

view details

chiefbiiko

commit sha 7499940046310a5b451b92dd22728a1655440728

add bwt (#157)

view details

Balou9

commit sha 85f4ad3c447d6fa3ca6c75cb7c5ebede19dc3d28

remove jsonschema (#158)

view details

Mark

commit sha a7fd311faa24e16f70689927abdc8c2c3b54249b

Allow emojis to be rendered (#160)

view details

Jed Fox

commit sha 2c52c7b22beec7bdc975375bbf78588d126aeba8

Add support for directory listing (#151)

view details

Ryan Dahl

commit sha 87a7b605bb60d28b6e247e9759fdf7b071b3cfe6

Revert "Add support for directory listing (#151)" This reverts commit 2c52c7b22beec7bdc975375bbf78588d126aeba8.

view details

Elias

commit sha 95acda04bc724c58b24aadb3f90450b6ecf50892

Added tokenizer

view details

Jed Fox

commit sha fcc1461fc122fb674523d0fe007c68080ef90c33

Directory listing (take 2) (#165)

view details

Ryan Dahl

commit sha f8120315a4cf5592226717d7d262046c3c499cfe

Add keroxp/deno-redis (#166)

view details

Alex J Burke

commit sha e9d69794268f5b98f9f6ec47d023e806b4ab8c98

Add support for serving esm files directly from unpkg (#152) The following changes have been made: * utils getEntry() allow a ${v} placeholder which supports passing the version to unpkg and converts a "master" branch name to the "latest" version * render support an "esm" type that serves the files directly * render_code bypass typescript file annotation for raw files (implied by "esm")

view details

Jed Fox

commit sha ce8b90da29d2a4163854394fe05316df52fe5697

Fix some bugs (#167) This fixes a bunch of issues with the code analyzer and adds a few tests. I ran through all of deno.land/std and the only files that still throw errors are the Prettier vendor files. Fixes #162.

view details

Jed Fox

commit sha ae442fc1a0523468f2acbd8f842918d3b09d66b1

Extract the embedded HTML/CSS out of the code render page

view details

Jed Fox

commit sha 90c43f6a47f8b032d8f6d780466ab9ee8ec36aa0

Fix logging in the dev server

view details

Jed Fox

commit sha aae2eccf806e1be12b554d441d830a8f81df5576

Don’t try to proxy non-text MIME types

view details

Jed Fox

commit sha 18454000f132fde03087cb36ed8530748b33ca27

Fix rebase

view details

Jed Fox

commit sha 4b513f67deae5c35856c7b213c36e8159b8454a0

Use the `html` template tag

view details

Jed Fox

commit sha f0b1c4b96d1b093d332f71023bb8b12685f2e5e2

Extract CSS to separate files

view details

push time in 4 days

delete branch j-f1/forked-denoland-registry

delete branch : fixing-bugs

delete time in 4 days

PR opened signmeup/signmeup

Improve queue page title for students

Currently, the queue page shows the total number of tickets in the queue for both TAs and students. While useful for TAs who are there to help all the students, the most pressing concern for a typical student — like me! — is “when will the TA help me?” This PR attempts to answer this question for students by showing them the number of tickets that are in line ahead of them, and hiding the number icon when the student doesn’t have any tickets waiting so they aren’t distracted while working.

This is my first time contributing to either this project or a Meteor project in general, so any feedback would be appreciated.

+22 -3

0 comment

1 changed file

pr created time in 4 days

create barnchj-f1/forked-signmeup

branch : student-queue-title

created branch time in 4 days

issue commenttonsky/FiraCode

Make pipe | shorter

Actually now I’m thinking that I can detect that specific case and alter the height in that case only

What about when the bar isn’t all the way full?

 |████████████████████████        | 102kB 4.6MB/s 
tonsky

comment created time in 4 days

fork j-f1/signmeup

Real-time application to sign up for and manage TA hours.

https://signmeup.cs.brown.edu

fork in 4 days

Pull request review commentdenoland/deno

Add support for passing a key to Deno.env()

 function setEnv(key: string, value: string): void {  * the process. The environment object will only accept `string`s  * as values.  *+ *       console.log(Deno.env("SHELL"));  *       const myEnv = Deno.env();  *       console.log(myEnv.SHELL);  *       myEnv.TEST_VAR = "HELLO";  *       const newEnv = Deno.env();  *       console.log(myEnv.TEST_VAR == newEnv.TEST_VAR);  */-export function env(): { [index: string]: string } {+export function env(): { [index: string]: string };+export function env(key: string): string | undefined;+export function env(+  key?: string+): { [index: string]: string } | string | undefined {   const env = sendSync(dispatch.OP_ENV);+  if (key) {+    return env[key];

Should this only happen on Windows or should it be on Mac/Linux too?

j-f1

comment created time in 5 days

push eventj-f1/forked-deno

Jed Fox

commit sha 68c8f17a566e5dfa2ab3c77bc07aa53413d51916

Add overload to deno_runtime.d.ts

view details

push time in 5 days

Pull request review commentdenoland/deno

Add support for passing a key to Deno.env()

 function setEnv(key: string, value: string): void {  * the process. The environment object will only accept `string`s  * as values.  *+ *       console.log(Deno.env("SHELL"));  *       const myEnv = Deno.env();  *       console.log(myEnv.SHELL);  *       myEnv.TEST_VAR = "HELLO";  *       const newEnv = Deno.env();  *       console.log(myEnv.TEST_VAR == newEnv.TEST_VAR);  */-export function env(): { [index: string]: string } {+export function env(): { [index: string]: string };+export function env(key: string): string | undefined;+export function env(

The last overload is special because it isn’t part of the function’s type signature, and its type must match all of the overloads.

j-f1

comment created time in 6 days

PR opened denoland/deno

Add support for passing a key to Deno.env()

<!-- Before submitting a PR read https://deno.land/manual.html#contributing -->

Fixes #2951. I was unable to test it on my machine; hopefully Travis will work better.

+10 -1

0 comment

2 changed files

pr created time in 6 days

push eventj-f1/forked-deno

Bartek Iwańczuk

commit sha 77a00aef4cef31e1e76549b3fcef25f389c0ab84

feat: upgrade installer and add docs (#2551)

view details

Matt Harrison

commit sha 20f41e719d2cb5add8e9168d00f239843fd56d31

Fix comment (#2555)

view details

andy finch

commit sha eb93dc58a11d9e9a295eff31f9c2c6a3a4c5170b

add encodeInto to TextEncoder (#2558)

view details

Bartek Iwańczuk

commit sha 642eaf97c67c6070935a2977014c743ba59deff8

feat: redirect process stdio to file (#2554)

view details

Yoshiya Hinosawa

commit sha 201ddd29a7908d457ed43b030476707d32848868

fmt_test: resolve old absolute path issue (#2562)

view details

Yoshiya Hinosawa

commit sha 988bcbb8842d12202f278808698a6b546718e764

fetch: make body async iterable (#2563)

view details

Bartek Iwańczuk

commit sha b9fbd552149c1fe61b662c9b1a1ed1b42e5487ae

feat: log permission access (#2518) Replaces -D/--log-debug flag with --log-level=debug --log-level=info displays permission access

view details

Gurwinder Singh

commit sha 6fa6828e5f0f7abac20ec342ee5ec57654a425d0

Minor tweaks (#2569) 1. Separate Snapshot and Script StartupData functions based on cfg "no-snapshot-init" 2. Replace deprecated Once::ONCE_INIT with Once::new (https://github.com/rust-lang/rust/pull/61757) 3. Elide lifetime 4. Fix typos

view details

JaePil Jung

commit sha d82089ca358b7fa4d5e2b7a357f651364643de7a

Update manual.md (#2571)

view details

Long(Tony) Lian

commit sha 1d0d54247c0a5a69207f8e0b948d3b60287467eb

feat: fetch() now handles redirects (#2561)

view details

Bartek Iwańczuk

commit sha 3c81cca0374c96ff4759ec9305eb5529dd29a4d8

fix: prevent multiple downloads of modules (#2477)

view details

Bartek Iwańczuk

commit sha 70a9859adce478180a15d43877fe239a44379556

refactor: use Path/PathBuf in deno dir (#2559)

view details

Ryan Dahl

commit sha d1482c6b8abfdd8201f8d1845a5de75105f3cbc4

Upgrade deno_std (#2565)

view details

Ryan Dahl

commit sha 046cbef4f0f11e37d6ffb8b01c6362c8ce0b750d

simplify check_net test

view details

Bert Belder

commit sha 89216c7baaab8ade3daf9103572647addeb404f3

third_party: add rust crate 'termcolor'

view details

Ryan Dahl

commit sha 3a4d88475b40a17f2ce17b775a3f07c78be83d79

Port code from Cargo and use for progress A lot of its functionality is unused still, but the goal it to slowly migrate logging functionality to it. There is also a useful progress bar which can be ported over later - it depends on this module. https://github.com/rust-lang/cargo/blob/4c1fa54d10f58d69ac9ff55be68e1b1c25ecb816/src/cargo/util/progress.rs

view details

Ryan Dahl

commit sha c56df45355c8e68eabbfa62021e7ca7484115c0b

v0.10.0

view details

Evgeniy Karagodin

commit sha d089f9797830a2729cbd45cb4ea6312eb43a28de

Add homeDir to Deno namespace (#2578)

view details

Bartek Iwańczuk

commit sha 6906a2f75e428221f8b9bfa28b2c6821eb3ebe30

feat: deno completions command (#2577)

view details

Jimmy Cao

commit sha fb6d57a28172aeaaa5fdb31d5775e190bdfaa1c1

fix: run blocking function on a different task (#2570) This avoids freezing the current task if the fn blocks indefinitely

view details

push time in 6 days

create barnchj-f1/forked-deno

branch : add-env-shorthand

created branch time in 6 days

IssuesEvent

issue closeddenoland/deno

Shorthand for env variables

I was reading through the deno_std codebase and noticed this pattern:

const token = env()["GIST_TOKEN"]

http://deno.land/std/examples/gist.ts#L13

What do you think about making a shorthand for this?

const token = env("GIST_TOKEN")

I’d be willing to open a PR to add this. However, if you feel like this pattern shouldn’t be encouraged, feel free to close this issue.

closed time in 6 days

j-f1

issue openeddenoland/deno

Shorthand for env variables

I was reading through the deno_std codebase and noticed this pattern:

const token = env()["GIST_TOKEN"]

http://deno.land/std/examples/gist.ts#L13

What do you think about making a shorthand for this?

const token = env("GIST_TOKEN")

I’d be willing to open a PR to add this. However, if you feel like this pattern shouldn’t be encouraged, feel free to close this issue.

created time in 6 days

PR opened denoland/registry

Fix some bugs

This fixes a bunch of issues with the code analyzer and adds a few tests.

I ran through all of deno.land/std and the only files that still throw errors are the Prettier vendor files.

+134 -39

0 comment

9 changed files

pr created time in 6 days

create barnchj-f1/forked-denoland-registry

branch : fixing-bugs

created branch time in 6 days

issue commenttonsky/FiraCode

Old style nums variant prevents lot of ligatures

This change means that you’ll be able to use old-style numbers along with ligatures that appear directly next to numbers. Here’s a screenshot showing the difference between normal and old-style numbers:

Screen Shot 2019-09-13 at 16 18 48

paradoxxxzero

comment created time in 7 days

issue closedmicrosoft/TypeScript

Type Checker creation fails when declare global is present

<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨

Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a bug, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!

Please help us by doing the following steps before logging an issue:

  • Search: https://github.com/Microsoft/TypeScript/search?type=Issues
  • Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ

Please fill in the entire template below. -->

<!-- Please try to reproduce the issue with typescript@next. It may have already been fixed. --> TypeScript Version: typescript@3.7.0-dev.20190910

<!-- Search terms you tried before logging this (so others can find this issue more easily) --> Search Terms: declare global false expression

Code

// example.js
const ts = require('typescript')
const sourceFile = ts.createSourceFile("foo.ts", "declare global {}", ts.ScriptTarget.ESNext)
const program = ts.createProgram({
  rootNames: ["foo.ts"],
  options: { module: "esnext" },
  host: {
    getSourceFile: () => sourceFile,
    getDefaultLibFileName: () => "lib.esnext.d.ts",
    getCurrentDirectory: () => "/",
    getCanonicalFileName: f => f,
    useCaseSensitiveFileNames: () => true,
    fileExists: name => name === pathname,
  },
})
const typeChecker = program.getTypeChecker()
$ mkdir example
$ cd example
$ npm init -y
$ npm i typescript@3.7.0-dev.20190910
$ node example.js

Expected behavior:

A TypeChecker is successfully created.

Actual behavior:

Error: Debug Failure. False expression.
    at mergeSymbol (.../node_modules/typescript/lib/typescript.js:32889:26)
    at .../node_modules/typescript/lib/typescript.js:33000:47
    at Map.forEach (<anonymous>)
    at mergeSymbolTable (.../node_modules/typescript/lib/typescript.js:32998:20)
    at initializeTypeChecker (.../node_modules/typescript/lib/typescript.js:61476:21)
    at Object.createTypeChecker (.../node_modules/typescript/lib/typescript.js:32736:9)
    at Object.getTypeChecker (.../node_modules/typescript/lib/typescript.js:92289:79)

Playground Link: N/A Related Issues: <!-- Did you find other bugs that looked similar? -→ I did not find any similar bugs.

closed time in 7 days

j-f1

issue commentmicrosoft/TypeScript

Type Checker creation fails when declare global is present

Thanks, that worked!

const ts = require('typescript')
const esNextLibPath = require.resolve('typescript/lib/lib.esnext.d.ts')
const esNextLib = require('fs').readFileSync(esNextLibPath, 'utf8')
const sourceFile = ts.createSourceFile("foo.ts", "declare global {}", ts.ScriptTarget.ESNext)
const sourceFiles = {
  "foo.ts": sourceFile,
  "lib.esnext.d.ts": ts.createSourceFile("lib.esnext.d.ts", esNextLib, ts.ScriptTarget.ESNext),
}
const program = ts.createProgram({
  rootNames: ["foo.ts"],
  options: { module: "esnext" },
  host: {
    getSourceFile: name => sourceFiles[name],
    getDefaultLibFileName: () => "lib.esnext.d.ts",
    getCurrentDirectory: () => "/",
    getCanonicalFileName: f => f,
    useCaseSensitiveFileNames: () => true,
    fileExists: name => name === "foo.ts",
  },
})
const typeChecker = program.getTypeChecker()
j-f1

comment created time in 7 days

issue commenttonsky/FiraCode

Ligature proposal: Ceylon string interpolation delimiter (``)

(ps. To put backticks in backticks, use more backticks for delimiting; typing ``` `` ``` will put the entire thing in inline code. Unfortunately this starts and ends the inline code block with a space, but I still think it looks nicer than not.)

You can also do just ` `` `: ``. Markdown also trims the extra leading and trailing spaces so everything is formatted properly.

formicant

comment created time in 9 days

pull request commentfreeCodeCamp/devdocs

Add support for prefers-color-scheme media query

like, use prefers-color-scheme in CSS only if body has class _theme-automatic or something alike

@media (prefers-color-scheme: dark) {
  html._theme-auto {
    /* ... dark vars */
  }
}
simon04

comment created time in 9 days

Pull request review commentdenoland/deno_std

bump prettier to 1.18.2

 function isSimpleFlowType(node) {   return node && flowTypeAnnotations.indexOf(node.type) !== -1 && !(node.type === "GenericTypeAnnotation" && node.typeParameters); } +function isJestEachTemplateLiteral(node, parentNode) {+  /**+   * describe.each`table`(name, fn)+   * describe.only.each`table`(name, fn)+   * describe.skip.each`table`(name, fn)+   * test.each`table`(name, fn)+   * test.only.each`table`(name, fn)+   * test.skip.each`table`(name, fn)+   *+   * Ref: https://github.com/facebook/jest/pull/6102+   */+  var jestEachTriggerRegex = /^[xf]?(describe|it|test)$/;+  return parentNode.type === "TaggedTemplateExpression" && parentNode.quasi === node && parentNode.tag.type === "MemberExpression" && parentNode.tag.property.type === "Identifier" && parentNode.tag.property.name === "each" && (parentNode.tag.object.type === "Identifier" && jestEachTriggerRegex.test(parentNode.tag.object.name) || parentNode.tag.object.type === "MemberExpression" && parentNode.tag.object.property.type === "Identifier" && (parentNode.tag.object.property.name === "only" || parentNode.tag.object.property.name === "skip") && parentNode.tag.object.object.type === "Identifier" && jestEachTriggerRegex.test(parentNode.tag.object.object.name));+}++function printJestEachTemplateLiteral(node, expressions, options) {+  /**+   * a    | b    | expected+   * ${1} | ${1} | ${2}+   * ${1} | ${2} | ${3}+   * ${2} | ${1} | ${3}+   */+  var headerNames = node.quasis[0].value.raw.trim().split(/\s*\|\s*/);++  if (headerNames.length > 1 || headerNames.some(function (headerName) {+    return headerName.length !== 0;+  })) {+    var parts = [];+    var stringifiedExpressions = expressions.map(function (doc$$2) {+      return "${" + printDocToString$1(doc$$2, Object.assign({}, options, {+        printWidth: Infinity,+        endOfLine: "lf"+      })).formatted + "}";+    });+    var tableBody = [{+      hasLineBreak: false,+      cells: []+    }];++    for (var i = 1; i < node.quasis.length; i++) {+      var row = tableBody[tableBody.length - 1];+      var correspondingExpression = stringifiedExpressions[i - 1];+      row.cells.push(correspondingExpression);++      if (correspondingExpression.indexOf("\n") !== -1) {+        row.hasLineBreak = true;+      }++      if (node.quasis[i].value.raw.indexOf("\n") !== -1) {+        tableBody.push({+          hasLineBreak: false,+          cells: []+        });+      }+    }++    var maxColumnCount = tableBody.reduce(function (maxColumnCount, row) {+      return Math.max(maxColumnCount, row.cells.length);+    }, headerNames.length);+    var maxColumnWidths = Array.from(new Array(maxColumnCount), function () {+      return 0;+    });+    var table = [{+      cells: headerNames+    }].concat(tableBody.filter(function (row) {+      return row.cells.length !== 0;+    }));+    table.filter(function (row) {+      return !row.hasLineBreak;+    }).forEach(function (row) {+      row.cells.forEach(function (cell, index) {+        maxColumnWidths[index] = Math.max(maxColumnWidths[index], getStringWidth$2(cell));+      });+    });+    parts.push("`", indent$6(concat$11([hardline$8, join$7(hardline$8, table.map(function (row) {+      return join$7(" | ", row.cells.map(function (cell, index) {+        return row.hasLineBreak ? cell : cell + " ".repeat(maxColumnWidths[index] - getStringWidth$2(cell));+      }));+    }))])), hardline$8, "`");+    return concat$11(parts);+  }+}+/** @param node {import("estree").TemplateLiteral} */

Could that error be caused by this line?

axetroy

comment created time in 9 days

pull request commenttc39/ecma262

Editorial: Add Automatic Semicolon Insertion hazard clause

At least https://github.com/tc39/ecma262/pull/1062#discussion_r167341720. Also, the text was reworded to avoid the word “hazard,” which I appreciate, but using “interesting“ instead makes the wording awkward.

bmeck

comment created time in 9 days

issue commenttonsky/FiraCode

SCSS #{ bug?

This is because in the second case, the # and the { are different colors, so Fira Code is not able to apply the ligature.

burtek

comment created time in 10 days

issue commentdenoland/registry

503 errors in registry

Figured out a MCVE:

declare global {}

⏩ https://github.com/microsoft/TypeScript/issues/33348

ry

comment created time in 10 days

issue openedmicrosoft/TypeScript

Type Checker creation fails when declare global is present

<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨

Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a bug, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!

Please help us by doing the following steps before logging an issue:

  • Search: https://github.com/Microsoft/TypeScript/search?type=Issues
  • Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ

Please fill in the entire template below. -->

<!-- Please try to reproduce the issue with typescript@next. It may have already been fixed. --> TypeScript Version: typescript@3.7.0-dev.20190910

<!-- Search terms you tried before logging this (so others can find this issue more easily) --> Search Terms: declare global false expression

Code

// example.js
const ts = require('typescript')
const sourceFile = ts.createSourceFile("foo.ts", "declare global {}", ts.ScriptTarget.ESNext)
const program = ts.createProgram({
  rootNames: ["foo.ts"],
  options: { module: "esnext" },
  host: {
    getSourceFile: () => sourceFile,
    getDefaultLibFileName: () => "lib.esnext.d.ts",
    getCurrentDirectory: () => "/",
    getCanonicalFileName: f => f,
    useCaseSensitiveFileNames: () => true,
    fileExists: name => name === pathname,
  },
})
const typeChecker = program.getTypeChecker()
$ mkdir example
$ cd example
$ npm init -y
$ npm i typescript@3.7.0-dev.20190910
$ node example.js

Expected behavior:

A TypeChecker is successfully created.

Actual behavior:

Error: Debug Failure. False expression.
    at mergeSymbol (.../node_modules/typescript/lib/typescript.js:32889:26)
    at .../node_modules/typescript/lib/typescript.js:33000:47
    at Map.forEach (<anonymous>)
    at mergeSymbolTable (.../node_modules/typescript/lib/typescript.js:32998:20)
    at initializeTypeChecker (.../node_modules/typescript/lib/typescript.js:61476:21)
    at Object.createTypeChecker (.../node_modules/typescript/lib/typescript.js:32736:9)
    at Object.getTypeChecker (.../node_modules/typescript/lib/typescript.js:92289:79)

Playground Link: N/A Related Issues: <!-- Did you find other bugs that looked similar? -→ I did not find any similar bugs.

created time in 10 days

issue commentniieani/hashids.js

How to import hashids v2 in Angular/Typescript?

It seems like you don’t have the appropriate lib set to enable TypeScript support for BigInt. Maybe your TS version is out of date?

anisabboud

comment created time in 11 days

issue commentprettier/eslint-config-prettier

the rule ‘function-paren-newline’ is not effect?

We don’t support rules like that, unfortunately. You have to use the style Prettier suggests.

dale426

comment created time in 11 days

issue commentprettier/prettier

Prettier 2.0

I don’t think that would be a good idea since you could unintentionally break complex syntax; however, if you really want to, you could run a regex replace over your code after running Prettier.

azz

comment created time in 11 days

push eventj-f1/forked-denoland-registry

Elias

commit sha 95acda04bc724c58b24aadb3f90450b6ecf50892

Added tokenizer

view details

Jed Fox

commit sha fcc1461fc122fb674523d0fe007c68080ef90c33

Directory listing (take 2) (#165)

view details

push time in 11 days

delete branch j-f1/forked-denoland-registry

delete branch : directory-listing-take-ii

delete time in 11 days

GollumEvent
GollumEvent
GollumEvent

PR opened denoland/registry

Directory listing (take 2)

This reverts #163 and ameliorates #162 by skipping the annotation phase if an error is thrown.

+817 -240

0 comment

18 changed files

pr created time in 11 days

create barnchj-f1/forked-denoland-registry

branch : directory-listing-take-ii

created branch time in 11 days

startedmeefik/dtmf.js

started time in 13 days

issue commentniieani/hashids.js

Using for react-native

@brentonhouse try require('hashids/cjs').

alien3d

comment created time in 15 days

issue commentdenoland/registry

503 errors in registry

It seems to be independent of #151 since it’s still occurring

ry

comment created time in 15 days

issue commentdenoland/registry

503 errors in registry

The error seems to be caused in the getTypeChecker method. I’m not sure why it’s throwing, but it seems to be caused by an attempt to override Window in the global namespace.

ry

comment created time in 15 days

push eventj-f1/forked-denoland-registry

迷渡

commit sha 06c78420cefa67d4c2bf3a5725058833f213b869

add deno-is (#153)

view details

迷渡

commit sha 1f206e74a7ea793d63c6a5a125e1bf45980b329e

add date-fns (#154)

view details

Yoshiya Hinosawa

commit sha 720aa48e735cbb91c14d2b55eb39f5dc5b165990

feat: add ms (#155)

view details

syumai

commit sha 0e4c83c5847fe5b727a875d68d4bcada253c109a

Added syumai/dem (#156)

view details

chiefbiiko

commit sha 7499940046310a5b451b92dd22728a1655440728

add bwt (#157)

view details

Balou9

commit sha 85f4ad3c447d6fa3ca6c75cb7c5ebede19dc3d28

remove jsonschema (#158)

view details

Mark

commit sha a7fd311faa24e16f70689927abdc8c2c3b54249b

Allow emojis to be rendered (#160)

view details

Jed Fox

commit sha 2c52c7b22beec7bdc975375bbf78588d126aeba8

Add support for directory listing (#151)

view details

Ryan Dahl

commit sha 87a7b605bb60d28b6e247e9759fdf7b071b3cfe6

Revert "Add support for directory listing (#151)" This reverts commit 2c52c7b22beec7bdc975375bbf78588d126aeba8.

view details

push time in 15 days

issue commentprettier/prettier

Support setext headings in Markdown

Looking at this again, I think an option would be unnecessary, but it would be OK if we preserved the style used in the original code.

ExE-Boss

comment created time in 15 days

issue commentprettier/prettier

Bad formatting for multiple concatenated shorthand if

Duplicate of #5814

lppedd

comment created time in 15 days

issue closedprettier/prettier

JavaScript: CallExpression on right of assignment is printed in a different way from similar MembarExpression.

<!--

BEFORE SUBMITTING AN ISSUE:

  1. Search for your issue on GitHub: https://github.com/prettier/prettier/issues A large number of opened issues are duplicates of existing issues. If someone has already opened an issue for what you are experiencing, you do not need to open a new issue — please add a 👍 reaction to the existing issue instead.

  2. We get a lot of requests for adding options, but Prettier is built on the principle of being opinionated about code formatting. This means we have a very high bar for adding new options. Find out more: https://prettier.io/docs/en/option-philosophy.html

Tip! Don't write this stuff manually.

  1. Go to https://prettier.io/playground
  2. Paste your code and set options
  3. Press the "Report issue" button in the lower right

-->

Prettier 1.18.2 Playground link

# Options (if any):
--print-width=10

Input:

const bar = long.long;
const foo = long.long();

Output:

const bar =
  long.long;
const foo = long.long();

Expected behavior:

const bar =
  long.long;
const foo =
  long.long();

closed time in 15 days

sosukesuzuki
IssuesEvent

issue commentprettier/prettier

Adding character before and/or after mustaches gives ugly output

This is what @AnthonyLenglet is referring to @evilebottnawi:

Prettier 1.18.2 Playground link

--parser angular

Input:

<span class="mr-1">{{ 'should_outdate_translation' | i18n: 'Should outdate translations on save' | async }}:</span>
<span class="mr-1">{{ 'should_outdate_translation' | i18n: 'Should outdate translations on save' | async }}</span>

Output:

<span class="mr-1"
  >{{
    "should_outdate_translation"
      | i18n: "Should outdate translations on save"
      | async
  }}:</span
>
<span class="mr-1">{{
  "should_outdate_translation"
    | i18n: "Should outdate translations on save"
    | async
}}</span>

AnthonyLenglet

comment created time in 15 days

issue commentdenoland/registry

Display directories contents

This is done!

ry

comment created time in 17 days

issue closedstreamich/react-use

TypeScript build fails

I’ve enabled the strict option in my tsconfig.json, and installing this package results in an error because it can’t find types for the useCallbag hook, even though I don’t use that hook. It seems to be trying to import the types for the use-callbag package, which don’t exist. Can you fix this error?

closed time in 17 days

j-f1

pull request commentfreeCodeCamp/devdocs

Run `optipng -o7` on all PNG files

OptiPNG is a PNG optimizer that recompresses image files to a smaller size, without losing any information.

Maybe this should be run programmatically on the generated sprite sheet instead?

simon04

comment created time in 17 days

issue commenttonsky/FiraCode

$, & and @ (and maybe <= and >=)

I believe it’s the former.

Vampire

comment created time in 17 days

issue commenttonsky/FiraCode

Backslashes became very hard to see (almost invisible)

Could this be a stylistic set @tonsky?

realnc

comment created time in 18 days

delete branch j-f1/forked-denoland-registry

delete branch : directory-listing

delete time in 18 days

issue commentbasarat/typescript-book

What are Microsoft's "TypeScript StyleGuide and Coding Conventions" based on?

As I understand it, that is the style with C# but many TS developers don’t use the prefix. Additionally, the style guide included in this repo is not official.

akopchinskiy

comment created time in 18 days

push eventj-f1/forked-denoland-registry

Jed Fox

commit sha aad129df79788e14e46e2cdc7ae580cdb81621e3

Fix breadcrumb style

view details

push time in 18 days

pull request commentdenoland/registry

Directory listing

The tests should work if you upload a GitHub token into Travis as the GH_TOKEN environment variable.

Turns out this is wrong since for security, Travis doesn’t give env vars to builds triggered by commits from forks. The tests should pass if run locally though.

j-f1

comment created time in 18 days

pull request commentdenoland/registry

Directory listing

can you update the links at /x/ to link to the directory instead of the README?

Yep! I’d already done that but forgot to push. I also did https://github.com/denoland/registry/pull/151/commits/2e87a6f37e7baee4f2621d110a38ad2b5ed62094.

j-f1

comment created time in 18 days

Pull request review commentdenoland/registry

Directory listing

+const fetch = require("node-fetch");+ const response = require("./response");+const renderListing = require("./dir_listing");++module.exports = async function renderDir(pathname, entry, path) {+  if (entry.raw.type === "github") {+    const res = await fetch(+      `https://api.github.com/repos/${entry.raw.owner}/${entry.raw.repo}/contents/${path}`,+      {+        headers: {+          authorization:+            process.env.GH_TOKEN && "token " + process.env.GH_TOKEN,+          accept: "application/vnd.github.v3.object"+        }+      }+    );

I figured we could do this once we have more than one provider: https://kcd.im/aha

j-f1

comment created time in 18 days

push eventj-f1/forked-denoland-registry

Jed Fox

commit sha a991ca357b1e163651c80c464d4d05bff2654196

Update the homepage to link to the directory listing for each package

view details

Jed Fox

commit sha 2e87a6f37e7baee4f2621d110a38ad2b5ed62094

Add a GitHub button to the breadcrumb bar so there’s no need to have a separate repo link.

view details

Jed Fox

commit sha 4998b13fc57fece6c826c7719b75e1d557bb2a40

Remove debug log

view details

push time in 18 days

Pull request review commentdenoland/registry

Directory listing

+const { escapeHtml, html } = require("./utils");+const prettyBytes = require("pretty-bytes");+const { breakpoint } = require("./code_styles");+const renderBreadcrumbs = require("./breadcrumbs");++const icons = {+  file: "📄",+  dir: "📁",+  symlink: "📑"+};++/** @type {import('showdown').Converter} */+let _converter = null;+function renderMarkdown(source) {+  if (!_converter) {+    const { Converter } = require("showdown");+    _converter = new Converter({ tables: true });+  }+  return _converter.makeHtml(source);+}++// adapted from serve’s directory listing implementation:+// https://github.com/zeit/serve-handler/blob/6ece2015/src/directory.jst+module.exports = function renderListing(+  pathname,+  entry,+  path,+  contents,+  readme+) {+  const url = `https://deno.land${pathname}`;+  const moduleRoot = pathname.replace(path, "");+  return html`

I think it’d be overkill for this situation since we don’t need state and everything is static. The current method of composing HTML strings is working fine now.

j-f1

comment created time in 18 days

pull request commentdenoland/registry

Add support for serving esm files directly from unpkg.

LGTM except for my comment above.

alexjeffburke

comment created time in 18 days

pull request commentdenoland/registry

Directory listing

I’m thinking about adding a tab bar in mobile mode so people don’t have to scroll down to see the README. Worth it or not?

j-f1

comment created time in 19 days

push eventj-f1/forked-denoland-registry

迷渡

commit sha 06c78420cefa67d4c2bf3a5725058833f213b869

add deno-is (#153)

view details

迷渡

commit sha 1f206e74a7ea793d63c6a5a125e1bf45980b329e

add date-fns (#154)

view details

Jed Fox

commit sha 4c78a63cc533b662bc90f93bf7cc1113815e68aa

Merge branch 'master' into static-files

view details

push time in 19 days

push eventj-f1/forked-denoland-registry

Jed Fox

commit sha ca008bd684874c5105d481c87a6299e717b885e1

Allow running dev server on alternate port

view details

Jed Fox

commit sha 8a8900610978e65bb2c94084012e44d3c290adeb

Update parent directory link

view details

push time in 19 days

pull request commentprettier/prettier

handle empty object patterns with type annotations in function parameters

IMO this should behave the same way as a named parameter:

Prettier pr-6438 Playground link

--parser babylon

Input:

const f = ({}: MyVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongType) => {};
const g = (AB: MyVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongType) => {};

Output:

const f = ({}: MyVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongType) => {};
const g = (
  AB: MyVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongType
) => {};

bakkot

comment created time in 19 days

pull request commentdenoland/registry

Directory listing

The “Parent directory” seems redundant since e.g. the std is clickable above it.

However, GitHub has both the .. button and a breadcrumb list. ¯\_(ツ)_/¯

j-f1

comment created time in 20 days

pull request commentdenoland/registry

Add support for serving esm files directly from unpkg.

It should be, but I’m not able to land it myself — only @ry can do that AFAIK.

alexjeffburke

comment created time in 20 days

issue commentstevegrunwell/asimov

vendor and node_module still exist in time machine

I don’t think so. Time Machine simply won’t add the updated directories to the backup, but they’ll continue to exist in old backups.

tanthammar

comment created time in 20 days

issue commentmjackson/unpkg

Access to .idea directory blocked

Here’s a ray ID if it helps debug: 50f2ce36efc85a36

sonicdoe

comment created time in 20 days

issue commentbasarat/typescript-book

What are Microsoft's "TypeScript StyleGuide and Coding Conventions" based on?

You typically wouldn’t have a class, interface, and type with the same name, and such a pattern is probably a code smell anyway.

akopchinskiy

comment created time in 20 days

issue commentdenoland/deno_std

console.log(headers) doesn't print useful info

It looks like Headers is a global type. How could I contribute the custom inspector so it’s used by Deno by default?

FrediLehmann

comment created time in 20 days

pull request commentdenoland/registry

Add ms

Do you happen to know why the module uses a named export instead of a default export?

kt3k

comment created time in 20 days

pull request commentdenoland/registry

Directory listing

One thing I’m interested in is how you feel about using ⏏️ as the icon for “Parent directory.”

j-f1

comment created time in 20 days

push eventj-f1/forked-denoland-registry

Jed Fox

commit sha 0b70a3be461b9449f278149302bd5127b6c16d5c

Update database.json

view details

push time in 20 days

push eventj-f1/forked-denoland-registry

Jed Fox

commit sha e8b88878b96556b0793b5b2efe12ac4fe1eb4c79

Update database.json

view details

push time in 20 days

issue openeddenoland/deno

Add a _ global to the REPL

This is something present in the Node.js REPL. It stores the result of the last expression run:

$ node
> 1 + 2
3
> _
3

Would it be possible to add something like this to the Deno REPL?

created time in 21 days

issue commentdenoland/deno_std

console.log(headers) doesn't print useful info

Here’s an option:

function renderHeaders(headers) {
  console.log('Headers {')
  for (const [header, value] of headers.entries()) {
    console.log(`  ${header}: ${value}`)
  }
  console.log('}')
}

Should I make a PR to the Deno repo?

FrediLehmann

comment created time in 21 days

issue commentdenoland/deno_std

console.log(headers) doesn't print useful info

Here’s a possible implementation:

function renderHeaders(headers: Headers) {
    console.log('Headers {')
    for (const [header, value] of headers.entries()) {
      console.log(`  ${header}: ${value}`)
    }
    console.log('}')
  }

Should I open a PR in Deno core?

FrediLehmann

comment created time in 21 days

issue openeddesktop/desktop

Add support for the Touch Bar

<!-- First and foremost, we’d like to thank you for taking the time to contribute to our project. Before submitting your issue, please follow these steps:

  1. Familiarize yourself with our contributing guide:
    • https://github.com/desktop/desktop/blob/development/.github/CONTRIBUTING.md#contributing-to-github-desktop
  2. Make sure your issue isn’t a duplicate of another issue
  3. If you have made it to this step, go ahead and fill out the template below -->

Please describe the problem you think should be solved

When using GitHub Desktop on a Mac with a touch bar, nothing is shown in the application area. One thing the touch bar is used for in other applications is displaying the buttons of dialog boxes so that you don’t have to move your hand to the trackpad to take action:

Touch Bar showing Cancel and Save buttons

Additionally, when there isn’t a dialog being shown, there are typically several buttons in the touch bar to perform various common actions.

[Optional] Do you have any potential solutions in mind?

  • Update the Dialog component to display its action buttons in the Touch Bar using Electron’s Touch Bar APIs.
  • When a dialog is not visible, display a set of common actions. Here are some options:
    • Commit
    • Switch Repo → search button, list of recent repos
    • Switch Branch → search button, list of recent branches
    • Switch to PR → search button, list of recent PRs
    • Push/Pull/Fetch
    • Compare to Branch
    • Open in → GitHub, editor, terminal, file browser

The buttons marked with a could be displayed as popups, allowing the user to either tap them, then tap another option, or press and hold on the button, then drag their finger to the appropriate option and release to activate it.

Additionally, when typing the summary and description fields, as well as the co-author field, the autocomplete options could be displayed in the touch bar for easy access.

created time in 21 days

issue commentprettier/prettier

Keep multi-line formatting for destructuring assignment

That’s not possible @gkatsanos — Prettier’s core algorithm depends on a defined printWidth.

Brian-Gaffney

comment created time in 21 days

pull request commentdenoland/registry

Directory listing

ping @ry

j-f1

comment created time in 22 days

pull request commentdenoland/registry

Add support for serving esm files directly from unpkg.

from what I understood the annotation machinery relies of the typescript compiler generating an AST

That’s correct. However, that doesn’t mean you need to use TypeScript to actually transpile the module. Also, TypeScript works OK on JS, especially for the jump-to-definition stuff we’re doing now

Also, the current pretty line numbering stuff when used with very large builds was causing the browser to really struggle so I’m not sure the added weight of links wouldn’t gain much.

How about instead checking the size of the source file and skipping the pretty-rendering pipeline if it exceeds a certain value?

alexjeffburke

comment created time in 22 days

issue openedfacebook-atom/nuclide-prebuilt-libs

Doesn’t work on Atom 1.14

When I try to open the terminal on Atom 1.14.0, I get this error message instead of a functioning terminal:

For more info check out the docs: https://nuclide.io/docs/features/terminal
Error starting process:
Error: Cannot find module '/Users/jed/.atom/packages/atom-ide-ui/node_modules/nuclide-prebuilt-libs/pty/build/pty-node-v64-darwin-x64/pty.node'

Could you rebuild these libraries for the latest version of Node?

created time in 22 days

delete branch j-f1/forked-hotelier

delete branch : add-cask

delete time in 22 days

push eventj-f1/dotfiles

Jed Fox

commit sha feaf4a5c7b286293ae09bad202bf63cb2919e75f

Update Brewfile

view details

push time in 22 days

push eventj-f1/dotfiles

Jed Fox

commit sha 2e7fce167e3b9e2d3385dcfd6972f9da9e02873a

Update Brewfile

view details

push time in 22 days

PR opened macav/hotelier

Add support for installing with Homebrew

I would’ve submitted this to the main Cask repo instead, but they require repos to have 50 stars.

+19 -1

0 comment

2 changed files

pr created time in 22 days

create barnchj-f1/forked-hotelier

branch : add-cask

created branch time in 22 days

Pull request review commentfreeCodeCamp/devdocs

Add GnuCOBOL documentation

+module Docs+  class GnuCobol+    class CleanHtmlFilter < Filter+      def call+        # Replace the title+        at_css('.settitle').content = 'GnuCOBOL'++        # Remove the Table of Contents+        # It's huge and the DevDocs sidebar is basically a direct copy+        css('.contents, .contents-heading').remove++        # Remove the changelog+        at_css('p').remove+        at_css('ol').remove++        # Remove horizontal lines+        css('hr').remove++        # Remove everything after Appendix B+        # This includes the license text, the document changelog, the compiler changelog and the footnote+        start_element = at_css('a[name="Appendix-C-_002d-GNU-Free-Documentation-License"]').previous_element+        next_element = start_element.next_element+        until start_element.nil?+          start_element.remove+          start_element = next_element+          next_element = start_element.nil? ? nil : start_element.next_element+        end

This seems to remove the content of Appendix B, too. However, appendix B is just a list of all the reserved words, so it might be reasonable to remove it too.

jmerle

comment created time in 22 days

fork j-f1/hotelier

Tray App for Hotel Process Manager

fork in 22 days

startedmacav/hotelier

started time in 22 days

more