profile
viewpoint

CircleCI-Public/circleci-dockerfiles 357

Dockerfiles for CircleCI's convenience images, built via https://github.com/circleci/circleci-images

CircleCI-Public/dockerfile-wizard 91

Use CircleCI to build custom Docker images with combinations of common languages/dependencies

iynere/compare-url 31

CircleCI 2.1 pipelines disable the CIRCLE_COMPARE_URL environment variable, useful when working with monorepo projects. This orb manually recreates (and improves!) it.

CircleCI-Public/example-images 22

CircleCI convenience image examples, generated by https://github.com/circleci/circleci-images, for sending READMEs and example Dockerfiles to Docker Hub via automated builds

CircleCI-Public/circleci-docker-examples 2

different ways to use Docker on CircleCI

iynere/crossfad.er 2

simple youtube crossfader

CircleCI-Public/cimg-template 0

Template repository to ease creation of new `cimg` image repos

iynere/a-t 0

secret thing

startedsantiq/bulletproof-nodejs

started time in 9 hours

issue closedCircleCI-Public/slack-orb

Slack notification error on build failure only delivered when event set to always

Orb version: 4.1.2

Slack notification snippet from config.yml:

jobs:
  build-and-test:
    executor: python/default
    steps:
      - checkout
      - python/install-packages:
          pkg-manager: poetry
      - run:
          command: |
            poetry run pytest test/test.py
          name: Test it
      - slack/notify:
          branch_pattern: develop,master
          event: fail
          template: basic_fail_1

What happened:

On CircleCI build failure, Slack notification only appears when event: always is set, and does not appear on build failure when event: fail is set. The following error appears in CircleCI when event: fail and build fails:

Screen Shot 2020-11-26 at 4 09 46 PM

Expected behavior:

On CircleCI build failure, Slack notification of build failure should appear when event: fail is set.

It appears as though the issue may be fixed in https://github.com/CircleCI-Public/slack-orb/commit/d362258c47bcf02a2a62b6da56b95111233c48d6 <!--- what should happen, ideally? -->

Additional Information:

closed time in 13 hours

adamhartley

issue commentCircleCI-Public/slack-orb

Slack notification error on build failure only delivered when event set to always

Confirmed issue has been fixed by https://github.com/CircleCI-Public/slack-orb/commit/d362258c47bcf02a2a62b6da56b95111233c48d6 in 4.1.3

adamhartley

comment created time in 13 hours

issue commentCircleCI-Public/node-orb

Please consider using several partial keys in restore_cache

I would just add the {{ arch }} template, inside the key, as it's recommended in some parts of the docs and would help people with builds on different architectures, at no cost for those who don't.

julienw

comment created time in 14 hours

issue commentCircleCI-Public/node-orb

Yarn install does not use the cache-path parameter

Yeah that's right. I wonder what is the use case for this though :-)

I don't have any specific use case in mind 🤔 , but since the Orb allows changing the cache path, it should use it in the yarn install. Otherwise it's inconsistent IMO. If the intent of the cache-path parameter was just to cache the default cache path instead of the node_modules directory, then a boolean parameter would have been better.

Update: filed #63

Thank you.

patatepartie

comment created time in 14 hours

pull request commentCircleCI-Public/helm-orb

Add helm update with chart version [semver:patch]

@joosangkim Your changes are available in version 1.1.1 of the orb 🎉

joosangkim

comment created time in 19 hours

created tagCircleCI-Public/helm-orb

tagpatch-release-v1.1.1

A CircleCI Orb to simplify deployments to Kubernetes using Helm.

created time in 20 hours

release CircleCI-Public/helm-orb

patch-release-v1.1.1

released time in 20 hours

created tagCircleCI-Public/helm-orb

tagmaster-patch-master-025f09d

A CircleCI Orb to simplify deployments to Kubernetes using Helm.

created time in 21 hours

push eventCircleCI-Public/helm-orb

jeff.kim

commit sha 66c0465c7d12389375a26666a044dd288821c581

Add helm update with chart version

view details

Stella Lok

commit sha 39c9246ec0f1d9eb63c6e01e2f89582fa1f4085b

Merge branch 'master' into enhance-chart-install

view details

Stella Lok

commit sha 025f09d883092d91b892b5cd0f954fc28defffc9

Merge pull request #31 from joosangkim/enhance-chart-install [semver:patch] Add helm update with chart version [semver:patch]

view details

push time in 21 hours

PR merged CircleCI-Public/helm-orb

Add helm update with chart version [semver:patch]

Checklist

<!-- thank you for contributing to CircleCI Orbs! before submitting your a request, please go through the following items and place an x in the [ ] if they have been completed -->

  • [x] All new jobs, commands, executors, parameters have descriptions
  • [x] Examples have been added for any significant new features
  • [x] README has been updated, if necessary

Motivation, issues

upgrade-helm-chart feature always upgrade latest version of the assgined chart. The orb official document says upgrading to specific version can be possible(https://circleci.com/developer/orbs/orb/circleci/helm#commands-upgrade-helm-chart). <!--- why is this change required? what problem does it solve? paste links to any relevant GitHub issues filed against this repository that this pull request addresses -->

Description

Added ${VERSION} value to end of upgrade-helm-chart.yaml. This values will be set to --version YOUR_VERSION if version parameter specified. <!--- Describe your changes in detail, preferably in an imperative mood, i.e., "add commandA to jobB" -->

+3 -0

0 comment

1 changed file

joosangkim

pr closed time in 21 hours

created tagCircleCI-Public/helm-orb

tagintegration-patch-pr-31-39c9246

A CircleCI Orb to simplify deployments to Kubernetes using Helm.

created time in a day

create barnchCircleCI-Public/helm-orb

branch : pr-31

created branch time in a day

created tagCircleCI-Public/helm-orb

tagminor-release-v1.1.0

A CircleCI Orb to simplify deployments to Kubernetes using Helm.

created time in a day

release CircleCI-Public/helm-orb

minor-release-v1.1.0

released time in a day

created tagCircleCI-Public/helm-orb

tagmaster-patch-master-02c7dea

A CircleCI Orb to simplify deployments to Kubernetes using Helm.

created time in a day

push eventCircleCI-Public/helm-orb

jeff.kim

commit sha cd1ff20087a3338ca0c62c96b8fab47b77d3bc07

Add helm3 url

view details

Stella Lok

commit sha 31e6edbed749fe121168513e9b68a027a7b74372

fix integration test

view details

Stella Lok

commit sha 59f0109fc48fc7c626c90c88e40f60aaa2d9cad2

fix test

view details

Stella Lok

commit sha 18d9b0b643eb5725f3eaf9d0c257343da4033577

update readme and example

view details

Stella Lok

commit sha 02c7dea792792a9552080f251f37797b59d1d782

Merge pull request #29 from joosangkim/add-helm3-url [semver:minor] Add helm3 client download url

view details

push time in a day

PR merged CircleCI-Public/helm-orb

Add helm3 client download url

Checklist

<!-- thank you for contributing to CircleCI Orbs! before submitting your a request, please go through the following items and place an x in the [ ] if they have been completed -->

  • [ x ] All new jobs, commands, executors, parameters have descriptions
  • [ x ] Examples have been added for any significant new features
  • [ x ] README has been updated, if necessary

Motivation, issues

Helm3 uses https://github.com/helm/helm/blob/master/scripts/get-helm-3 url for getting helm v3 client. However current helm orb is using https://github.com/helm/helm/blob/master/scripts/get for getting both v2 and v3 client version. <!--- why is this change required? what problem does it solve? paste links to any relevant GitHub issues filed against this repository that this pull request addresses -->

Description

I added helm3 donwload url if ${IS_VERSION_2}is false. <!--- Describe your changes in detail, preferably in an imperative mood, i.e., "add commandA to jobB" -->

+46 -81

4 comments

4 changed files

joosangkim

pr closed time in a day

created tagCircleCI-Public/helm-orb

tagintegration-patch-pr-29-18d9b0b

A CircleCI Orb to simplify deployments to Kubernetes using Helm.

created time in a day

pull request commentCircleCI-Public/helm-orb

Add helm3 client download url

@joosangkim Just an update that I have fixed the integration test and will be able to get this merged soon 🙂

joosangkim

comment created time in a day

push eventCircleCI-Public/helm-orb

Stella Lok

commit sha 18d9b0b643eb5725f3eaf9d0c257343da4033577

update readme and example

view details

push time in a day

issue openedCircleCI-Public/os-detect-orb

Detect amd64 vs arm64

created time in a day

pull request commentCircleCI-Public/cimg-node

Fix yaml typos

@DIRECTcut Thank you for this PR. The text in that page comes from this readme. It gets synced across.

DIRECTcut

comment created time in a day

issue openedCircleCI-Public/slack-orb

Slack notification on failure only delivered when event set to always

Orb version: 4.1.2

Slack notification snippet from config.yml:

      - slack/notify:
          branch_pattern: develop,master
          event: fail
          template: basic_fail_1

What happened:

On CircleCI build failure, Slack notification only appears when event: always is set, and does not appear on build failure when event: fail is set.

Expected behavior:

On CircleCI build failure, Slack notification of build failure should appear when event: fail is set. <!--- what should happen, ideally? -->

Additional Information:

created time in a day

issue openedCircleCI-Public/aws-cli-orb

[Question] Why is node needed?

The default cimg python version in the executor is 3.8-node: https://github.com/CircleCI-Public/aws-cli-orb/blob/v1.3.1/src/executors/default.yml#L8

Why?

Thanks 🙏

created time in a day

created tagCircleCI-Public/helm-orb

tagintegration-patch-pr-29-59f0109

A CircleCI Orb to simplify deployments to Kubernetes using Helm.

created time in a day

push eventCircleCI-Public/helm-orb

Stella Lok

commit sha 59f0109fc48fc7c626c90c88e40f60aaa2d9cad2

fix test

view details

push time in a day

issue openedCircleCI-Public/node-orb

Please consider using several partial keys in restore_cache

Describe Request:

It is very common, and actually recommended in the CircleCI documentation, that we specify several keys in restore_cache, so that the cache can be reused and primed even if the underlying lock files change.

For example, Here is a real-life configuration from my project:

Saving is:

      - save_cache:
          paths:
            - node_modules
          key: v2-dependencies-{{ checksum "package.json" }}-{{ checksum "yarn.lock" }}

Restoring is:

      - restore_cache:
          keys:
            - v2-dependencies-{{ checksum "package.json" }}-{{ checksum "yarn.lock" }}
            - v2-dependencies-{{ checksum "package.json" }}-
            - v2-dependencies-

But this isn't what the orb is doing: https://github.com/CircleCI-Public/node-orb/blob/a8e41866cd2f9680992719851ec38533db6281cb/src/commands/install-packages.yml#L62-L67 https://github.com/CircleCI-Public/node-orb/blob/a8e41866cd2f9680992719851ec38533db6281cb/src/commands/install-packages.yml#L100-L105

Is there a drawback to always doing this? Or should we make this a configuration option?

I'd be happy looking at this if there is consensus about it.

Thanks!

created time in 2 days

issue commentCircleCI-Public/node-orb

Yarn install does not use the cache-path parameter

If I specify a cache-path different from yarn's default cache dir (~/.other-cache/yarn, for instance), it won't work anymore, however, since the default install command will use yarn's default cache location (~/.cache/yarn).

Yeah that's right. I wonder what is the use case for this though :-)

Regarding the node_modules comment: indeed, if it's already present in the job cache (by not having specified cache-path in a previous job, for instance), and is up-to-date with the lock file, the yarn cache will not be used and save_cache will be skipped.

This is even a bit more subtle: if you try to save with the same key as an existing cache (because same lock / same branch), then the save will be skipped altogether, even if there are files to be saved.

So there were actually 2 problems here, if the cache already exists: 1/ no new file in .cache/yarn because node_modules is uptodate, and 2/ even with some files, we'd need a different key name anyway.

One thing I just noticed and which could indicate this Orb's purpose doesn't match my use case, is that restore_cache will only restore on the exact same cache key. The circleci doc (and my previous "manual" implementation) use multiple cache keys for sharing caches, at least partially, between jobs on different branches, in addition to jobs on the same branch. This is a whole different issue from this one (and deserve its own ticket), though.

Yeah, actually this is the issue I wanted to file initially and that's why I looked at other issues and found this one first :D I was planning to file this issue indeed.

patatepartie

comment created time in 2 days

more