profile
viewpoint
Iuri de Silvio iurisilvio São José dos Campos, Brazil

iurisilvio/bottle-sqlalchemy 126

Bottle SQLAlchemy plugin

iurisilvio/bottle-chat 61

Asynchronous webchat using Bottle and gevent

iurisilvio/Flask-SQLAlchemy-Cache 33

A CachingQuery implementation to Flask using Flask-SQLAlchemy and Flask-Cache

aleborba/packtrack 9

API Python para obter informações de encomendas.

iurisilvio/Flask-Pusher 8

Flask extension for Pusher

iurisilvio/bottle-pystache 6

Bottle Pystache template wrappers

iurisilvio/FunBlocker 2

Hide ALL Facebook funny posts

iurisilvio/mandrill-smtp.NET 2

A .NET wrapper to use Mandrill SMTP headers customization

iurisilvio/dbip2mmdb 1

Loading db-ip.com database to MaxMind mmdb format.

pull request commentbottlepy/bottle

Add a max_size parameter to save and _copy_file

Further possible points of critique may be (in no prioritizing order):

  • Performance: The difference to the version so far would be the line if max_size is not None per every chunk. That is not nothing, but is probably rather negligeable – if there are a lot of chunks, the time should depend on IO anyway, I guess. A compromise is to have no comparatively costly function call in this line – otherwise if isinstance(max_size, int) comes to mind.
  • if isinstance(max_size, int) instead of if max_size is not None? See above. Or is it significantly more robust.
  • If max_size is exceeded, an IOError is thrown – that is also the error for the “File exists”-case. The errors are distinguished by their message each; but it might be better to have a stronger distinction. I am not sure, however, which other Error could or maybe should be used for exceeding the maximum size.
06180339

comment created time in 16 hours

pull request commentbottlepy/bottle

Add a max_size parameter to save and _copy_file

Thank you. That is a good point – the function signature of a private method can be controlled within this library. OTOH, if max_size in _copy_file is made an arg instead of a kwarg, …

  • either it has to come before chunk_size
  • or chunk_size itself is also made an arg instead of a kwarg (which it is now).

The former has the downside that then the order in the signature differs from the order in the signature of save. And save itself should probably not be changed.

The latter might have the downside that then the default value of 2 ** 16 has to go – that may be insignificant, but maybe the creator of this method preferred to have a default value ingrained here also, not only in save itself.

So, I am obviously fine with anything that seems acceptable to the maintainers.

06180339

comment created time in 16 hours

fork renzon/moto

A library that allows you to easily mock out tests based on AWS infrastructure.

http://docs.getmoto.org/en/latest/

fork in 20 hours

fork kennethreitz42/flask-common

A Flask extension with lots of common time-savers (file-serving, favicons, etc).

fork in 21 hours

fork kennethreitz42/background

Runs things in the background.

fork in 21 hours

pull request commentbottlepy/bottle

Add a max_size parameter to save and _copy_file

I like this idea.

It's super minor, but why use a keyword argument on a private method? It certainly doesn't hurt though and, like I said, this is minor.

06180339

comment created time in a day

PR opened bottlepy/bottle

Add a max_size parameter to save and _copy_file

This is a proposal inspired by a requirement I had myself and by the following comment on Stack Overflow: “Bottle stores file uploads in request.files as FileUpload instances, along with some metadata about the upload. FileUpload has a very handy save method that perform the "file slurping" for you. It does not check the maximum file upload though, but IMHO it's better to have nginx in front to perform this kind of limitation check.”

If you don’t use nginx or so and want to have an upper limit for the file size, it would be nice if the save method had an additional parameter max_size to set a maximum size beyond which the writing is stopped.

The changes in this branch hopefully enable that and I wanna propose to merge them.

+11 -4

0 comment

1 changed file

pr created time in a day

pull request commentback4app/parse-dashboard

Check User Session when opening Settings

Voce acha que precisa esperar o pr do back4app ou da para subir esse sozinho?

nataliaconde

comment created time in a day

startedcommunitybridge/easycla

started time in 2 days

startedksheumaker/homeassistant-aerogarden

started time in 2 days

fork jnewland/puppeteer-screenshot-action

A GitHub Action to run a puppeteer script and generate a screenshot

fork in 3 days

startedBetterThanTomorrow/calva

started time in 5 days

startedwilkerlucio/pathom

started time in 5 days

push eventback4app/parse-dashboard

Natália Condê

commit sha d18b5d4107b4be0531126cb538c72a877d9b8c53

fix job list - map function

view details

Rafael Santos

commit sha 0914c3a123cc8f6515e7e2c4ffe59a7073271e24

Merge pull request #232 from back4app/fixJobList fix job list - map function

view details

push time in 5 days

create barnchback4app/parse-dashboard

branch : fixJobList

created branch time in 5 days

Pull request review commentRunscope/healthcheck

align EnvironmentDump add_url_rule implementation with HealthCheck

 def check(self):             message = "OK"             if self.success_handler:                 message = self.success_handler(results)--            return message, self.success_status, self.success_headers+            headers = self.success_headers() if callable(self.success_headers) else self.success_headers+            +            return message, self.success_status, headers         else:             message = "NOT OK"             if self.failed_handler:                 message = self.failed_handler(results)+            headers = self.success_headers() if callable(self.success_headers) else self.success_headers

you are correct, thanks. it's fixed now.

wangsha

comment created time in 5 days

Pull request review commentRunscope/healthcheck

align EnvironmentDump add_url_rule implementation with HealthCheck

 import traceback import platform from flask import current_app+from datetime import datetime

reordered with this tool: https://pycqa.github.io/isort/docs/quick_start/0.-try/

wangsha

comment created time in 5 days

created repositoryreplit/example-repltweet

An example of using replit-py for exploring the world of web applications! 🗺

created time in 6 days

created repositoryreplit/example-repltweet

An example application for using replit-py for building web apps! 👩🏻‍💻

created time in 6 days

push eventback4app/parse-dashboard

Natália Condê

commit sha e00cd19cf2609845726bc353a5f774d28bbb5076

fix job list (merge)

view details

Rafael Santos

commit sha 263b8d9a200dd59cca39266214e9af50676d08bb

Merge pull request #231 from back4app/fixJobList-merge fix job list (merge)

view details

push time in 6 days

PR opened back4app/parse-dashboard

fix job list (merge)
+1 -1

0 comment

1 changed file

pr created time in 6 days

create barnchback4app/parse-dashboard

branch : fixJobList-merge

created branch time in 6 days

fork PauloLuan/conteudo-gratuito

📌 Conteúdos gratuitos compartilhados pela comunidade.

fork in 6 days

startedleafo/pgmoon

started time in 7 days

starteddigitalocean/gta

started time in 7 days

more