profile
viewpoint

Ask questionsNot detecting reviews?

Describe the bug Hi again @squalrus, sorry to bombard you with PR's and issues 😅

Seeing a weird behaviour and was hoping you could help me figure out what is happening? I had this PR where reviewers were auto assigned from CODEOWNERS, but once all the conditions were met the auto merge didn't happen.

Before approvals it said Waiting on code owner review from limejump/platform and/or limejump/sig-kubernetes.

After approvals I see this in the logs:

pull: {"labels":["automerge","ready"],"owner":"limejump","pull_number":1375,"reviews":[],"ref":"heads/automerge-fixes","repo":"k8s-gitops","requested_reviewers":[],"checks":{}}

Notice how reviews and requested_reviewers are just an empty list! So all the jobs passed, but it didn't merge.

Screenshot 2020-09-03 at 14 21 04

Any ideas / extra things to check?

squalrus/merge-bot

Answer questions aaron-trout

Yeah, I've been having a poke about in the Github API as well. Seems in this specific flow where the reviewers are automatically assigned by CODEOWNERS and it happens to be a group, then when this event happens:

Screenshot 2020-09-03 at 14 49 09

Seem to end up with no "requested" reviewers:

Screenshot 2020-09-03 at 14 48 19

But if you call the endpoint to list the reviews:

Screenshot 2020-09-03 at 14 50 10

So maybe it is because they were not explicitly "requested" as reviewers?

useful!

Related questions

No questions were found.
source:https://uonfu.com/
Github User Rank List