Ask questionsretainReplicas failed
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!-->
What happened: When retainReplicas is set to true, the replicas of the member cluster deployment is still overrided by federatred sync controller.
What you expected to happen: When retainReplicas is set to true, the replicas of the member cluster deployment cannot be change by modify the rsp.
How to reproduce it (as minimally and precisely as possible): set the retainReplicas to true, and then change the totalReplicas of rsp.
Anything else we need to know?: the order of these two functions mybe wrong, the RetainClusterFields should be affer ApplyOverrides. https://github.com/kubernetes-sigs/kubefed/blob/57a1852ce9db67cdca440687998c026bf878f142/pkg/controller/sync/dispatch/managed.go#L203 https://github.com/kubernetes-sigs/kubefed/blob/57a1852ce9db67cdca440687998c026bf878f142/pkg/controller/sync/dispatch/managed.go#L209
<!-- DO NOT EDIT BELOW THIS LINE --> /kind bug
Answer questions fejta-bot
Issues go stale after 90d of inactivity.
Mark the issue as fresh with
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with
Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale