Ask questionsInvestigate bors for testing merge commits
As I wrote in #526:
One important limitation I just noticed: the CircleCI build only runs on the commit of a PR's branch (what GH Actions labels the
push), it does not automatically run on the merge commit (what Actions calls
This raises the possibility that if a PR is not up to date with
master, all of the CI might go green for a PR, we'll press the big green button, and the resulting merge commit into
masterwill fail. The silver lining is that it will fail, since CircleCI runs on all commits by default.
It looks like there's an open (and popular) feature request to add testing on synthetic merge commits to CircleCI directly: https://ideas.circleci.com/ideas/CCI-I-926
This is also another case where using bors would help, since bors creates staging commits that are never behind
master. Maybe it's time to set up bors for this repo?
I have only lightly interacted with bors when submitting patches to rust-lang projects. Let's investigate further to see whether we'd like to enable bors for this repo.
Answer questions aturon
I will reach out to relevant folks on the Rust side to check in on their current experience around bors and any pitfalls we should be aware of.
Related questionsNo questions were found.