profile
viewpoint
Isidor Nikolic isidorn Microsoft Zurich VSCode

issue commentmicrosoft/vscode

Problems to delete file or folder in Visual Studio Code

Will not fix this week, moving out to June to investigate into a fix then. Thanks

HiddenBehindTheKeyBoard

comment created time in 8 hours

issue commentmicrosoft/vscode

Adding folder to empty explorer: Data tree node not found

Assigning to may to investigate.

bpasero

comment created time in 8 hours

issue commentmicrosoft/vscode

List of targets should be positioned close to targets

Yeah I agree this is a bit strange. The flyout menu would be different but we do a seperate menu due to the implemenation, in more details we fetch the targets in an async way and only want to do it lazily once a user executes the command. If we were to use a submenu we would need to know the targets in advance, thus we would not do it lazily.

So I will not change the menu to menu design. However for the location, we can change to always show the second menu close to the target. Downside of this is that the first and second menu can be far apart. Though assigning to May to investigate.

stevencl

comment created time in 8 hours

issue commentmicrosoft/vscode

List of targets doesn't disappear after taking another action

Hmm agree that it should auto close, however on Mac we use a native context menu, and thus users can not even execute Step Over with F10, since VS Code is blocked while a context menu is shown.

It is a bit strange that when custom context menus are shown we allow commands to be executed via global keybindings.

fyi @sbatten

stevencl

comment created time in 8 hours

issue closedmicrosoft/vscode

A11y_VSCode_Debug Console_Keyboard: Clear console button is not accessible through keyboard as the data is not cleared from debug console pane when screenreader is on

Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”

GitHubTags:#A11y_VSCode;#A11ySev2;#A11yTCS;#A11yMAS;#Benchmark;#DesktopApp;#MAS2.1.1;#Win10;#Visual Studio Code;#NVDA;#JAWS;#Keyboard; #CAITestPass_May2020;#FTP;#STP;

Environment Details: Application Name: Visual Studio Code Windows Version: Windows10 Screenreader version:NVDA[2020.1], JAWS 2020.2001.70.400 Repro Steps:

  1. Open Visual studio code editor
  2. Press ctrl+shift+y 3)Validate it's possible to clear the debug console output when NVDA is ON.

Actual: While navigating through keyboard,Clear console button is not accessible through keyboard as the data is not cleared from debug console pane when screenreader is on. This issue is reproduced with NVDA and Jaws.

Expected: Clear console button should be accessible through keyboard when screenreader is on.

Attachment link for Reference: https://microsoft-my.sharepoint.com/:v:/p/v-nisaho/EUoxdD7KrexEp__yZ6UkEUcBpI0YvKJKteLO172v34W7OA?e=D84KCJ

closed time in 8 hours

nirmalsahoo

issue commentmicrosoft/vscode

A11y_VSCode_Debug Console_Keyboard: Clear console button is not accessible through keyboard as the data is not cleared from debug console pane when screenreader is on

You can focus the clear console by Ctrl + Shift + Y, press shit + Tab a couple of times and the focus is on the action. You might need to first F1 > tab key to move focus, but that is expected since you are in the editor. You can also F1 > clear debug console, you can aslo assign a custom keybinding to it to make it faster.

Thus closing as designed

nirmalsahoo

comment created time in 8 hours

issue commentmicrosoft/vscode

Restart while extension host debugging doesn't do anything anymore

@connor4312 Ok since you fixed it on the Extensions side, moving this out of June since I do not plan to push anything on the vscode side then this week.

eamodio

comment created time in 9 hours

issue commentmicrosoft/vscode

Statusbar: VoiceOver reads current item and entire line when receiving focus

I actually think that behavior you are seeing is just fine. Previously I was seeing what I mentioned - though I can no longer repro that. So I would probably just close this as designed.

chrmarti

comment created time in 9 hours

issue commentmicrosoft/vscode

Setting `debug.console.closeOnEnd` does not work after debug console was moved

I acklowedge this bug and we can look into it. Code pointer https://github.com/microsoft/vscode/blob/05e851b52978f08a7d7780feeff26a121e31c0d1/src/vs/workbench/contrib/debug/browser/debugService.ts#L600

Fell

comment created time in 9 hours

issue commentmicrosoft/vscode

Statusbar: VoiceOver reads current item and entire line when receiving focus

Ideally VoiceOver would only read the currently focused item in the status bar. However this is VoiceOver behavior and we can not really control this. Wish there was a place where we could file issues against VoiceOver

@cookiecrook VoiceOver reads the content of the whole status element even though the focus changes from one of it's child elements to another.

chrmarti

comment created time in 9 hours

issue commentmicrosoft/vscode

Terminal output div container should be more accessible for screen readers

All good feedback, Though let's wait for @Tyriar to hear his thoughts.

@jooyoungseo you would basically like a command that gives focus directly to the terminal output

jooyoungseo

comment created time in 9 hours

issue commentmicrosoft/vscode

Screen readers cannot update caret offset in code editor

@joanmarie great, thanks for trying it out. I would just remove the check to allow it for all platforms as long as Chrome Though let's do it start of next week June so we catch potential issues, since we are wrapping up our release now.

joanmarie

comment created time in 9 hours

issue closedmicrosoft/vscode

Keyboard shortcut for scrolling activity bar icons

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. --> The Activity Bar contains 7 or more icons to be selected (Explorer, Search, Source Control, Run, Extensions, Test, Manage, or more). For keyboard A11y and those too lazy to use the mouse or forgetful of their specific keyboard shortcuts, I propose a keyboard shortcut command to scroll up and down the activity bar (i.e. Ctrl+Shift+Down, Ctrl+Shift+Up). Now Instead of memorizing 5 or more distinct shortcuts, I could bring that down to two for navigating the Activity Bar. activity_bar

closed time in 9 hours

doubleUTF

issue commentmicrosoft/vscode

Keyboard shortcut for scrolling activity bar icons

Thanks for feedback however dup of https://github.com/microsoft/vscode/issues/97610

doubleUTF

comment created time in 9 hours

issue commentmicrosoft/vscode

Folders that are added to workspace close when selecting file

Yes please file new issues with minimal repro steps. Thanks

genbod

comment created time in 10 hours

issue commentmicrosoft/vscode

Step into targets command not shown

@weinand great thanks! @stevencl can you try it out now.

stevencl

comment created time in 10 hours

issue commentmicrosoft/vscode

Remember anchor position across editors

@aeschli thanks for feedback, makes perfect sense. Adding label bug so I look into it tomorrow :)

aeschli

comment created time in 10 hours

issue commentmicrosoft/vscode

"Restart Frame" button is misaligned for frames with long names

@DanTup thanks for filling this. I acknowledge this issue. We are open for PRs that fix this Code pointer https://github.com/microsoft/vscode/blob/05e851b52978f08a7d7780feeff26a121e31c0d1/src/vs/workbench/contrib/debug/browser/media/debugViewlet.css#L138

DanTup

comment created time in 11 hours

issue commentmicrosoft/vscode

Step into targets command not shown

@stevencl thanks a lot for trying this out! @weinand did we release a new mock debug version that has a "step into targets" support?

stevencl

comment created time in 11 hours

issue commentmicrosoft/vscode

Screen reader reads "link" for status entries

Good catch and makes sense. We will change the role of items in the statusbar to button. fyi @marcozehe @jvesouza

bpasero

comment created time in 12 hours

issue commentmicrosoft/vscode

Switching to simple full screen produces a jump

@bpasero for some strange reason I was not using it for a couple of weeks. Before that I could not reproduce. I also can not reproduce with VS Code stable.

isidorn

comment created time in 12 hours

issue openedmicrosoft/vscode

Capabilities for vscode.markdown.preview.editor already set

Got this in the developer console while using vscode insiders. I do not have exact steps but I hope the stack trace is useful enough.

 ERR Capabilities for vscode.markdown.preview.editor already set: Error: Capabilities for vscode.markdown.preview.editor already set
    at e.registerCustomEditorCapabilities (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5578:391)
    at e.registerEditorProvider (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6369:566)
    at e.$registerTextEditorProvider (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6369:248)
    at e._doInvokeHandler (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:4532:683)
    at e._invokeHandler (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:4532:375)
    at e._receiveRequest (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:4531:14)
    at e._receiveOneMessage (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:4529:832)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:4528:34
    at e.fire (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:95:801)
    at v.fire (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:433:97)
    at t.PersistentProtocol._receiveMessage (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:437:451)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:434:635
    at e.fire (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:95:801)
    at g.acceptChunk (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:430:532)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:429:832
    at Socket.t (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:439:12)
    at Socket.emit (events.js:203:13)
    at addChunk (_stream_readable.js:295:12)
    at readableAddChunk (_stream_readable.js:276:11)
    at Socket.Readable.push (_stream_readable.js:210:10)
    at Pipe.onStreamRead (internal/stream_base_commons.js:166:17)

created time in 14 hours

issue commentmicrosoft/vscode

Adding folder to empty explorer: Data tree node not found

Ah the good old data tree node not found error. After you get this error does everything work or all is broken?

I can not reproduce this. My steps. Have an empty workspace with no folders, File > add folder to workspace and choose a folder -> all good.

bpasero

comment created time in 14 hours

issue commentmicrosoft/vscode

CSS language features in safari do not work

Opening the safari dev tools I see some unrelated errors and one which might be related ReferenceError: Can't find variable: Worker

Might it be that all of the css things are computed in a Worker and this does not work as expected in Safari.

isidorn

comment created time in 14 hours

issue commentmicrosoft/vscode

Test 'CSS Language Features extension' in web

@aeschli I am sort of blocked for testing this on Safari, since nothing seems to work https://github.com/microsoft/vscode/issues/99049

aeschli

comment created time in 14 hours

issue openedmicrosoft/vscode

CSS language features in safari do not work

Testing #98900

yarn web open Safari Create a simple test.css file. And notice that none of the CSS language features work

  1. Code completions do not work
  2. inline color decoraitons do not work
  3. Hover for properties
  4. Validation

All of those things work when I do the same in Chrome.

created time in 14 hours

issue commentmicrosoft/vscode

Terminal output div container should be more accessible for screen readers

@chrisnorman7 aha. Then we would not change the F6 behavior, since the point of F6 is to give a birds view navigation over the workbench components. Once you are close to something you want you should tab into it. Since moving from the entry of the terminal to the output should be easy (if it is not we should fix) I would not change F6 behavior.

jooyoungseo

comment created time in 14 hours

issue closedmicrosoft/vscode

Test: Git abort rebase

Ref - #72576

  • [x] anyOS @isidorn
  • [x] anyOS @bpasero

Complexity: 2

Authors: @lszomoru, @joaomoreno

Create Issue


We have added a new command into the command palette to abort an in-progress rebase operation:

  • Create a new git repository
  • Add a new text file to the repository
  • Add a new file to the master branch
  • Create a new topic branch from master
  • Update the file in the master branch. Commit.
  • Update the file in the topic branch. Commit.
  • Rebase topic branch on top of master. You should get a conflict.
  • From the command palette choose the Git: Abort Rebase command.

Expected: In progress rebase operation should be cancelled.

closed time in 14 hours

lszomoru

issue commentmicrosoft/vscode

Test: Git abort rebase

Works niceyl 👏 I tested on macOS.

lszomoru

comment created time in 14 hours

issue commentmicrosoft/vscode

Git: abort rebase command should only be available while I am rebasing

Since triggering it outside of a rebase produces this expected error. Do we polish the message, since it looks a bit strange with the double : Screenshot 2020-06-02 at 12 18 51

isidorn

comment created time in 14 hours

issue openedmicrosoft/vscode

Git: abort rebase command should only be available while I am rebasing

Testing #99015

Currently the command is always in the command palette. I would expect it to appear only when I am in the middle of a rebase.

created time in 14 hours

push eventmicrosoft/vscode

isidor

commit sha f48cb619ba9f1d7e8a0d1b150cbdfa42577ec6a8

diffReview: clarify nls strings #98584

view details

push time in 14 hours

issue commentmicrosoft/vscode

[loc][Query][VSCODE] Localizability of strings in vscode-editor

@alexdima just did via f48cb619ba Thanks

PDostalek

comment created time in 14 hours

issue closedmicrosoft/vscode

show eplorer keyboard shortcut not working on ubuntu 20.04

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->

  • VSCode Version: 1.45.1
  • OS Version: Ubuntu 20.04 Steps to Reproduce:
  1. Open a new file in vscode
  2. Press ctrl+shift+e

<!-- Launch with code --disable-extensions to check. --> Does this issue occur when all extensions are disabled?: Yes

Keyboard shortcut for view: show explorer is not working on ubuntu 20.04. Pressing ctrl+shift+e displays the letter "e" with an underscore and no further input from keyboard is taken until escape is pressed. See the attached gif demonstrating the issue. Also, I have the same issue on Debian testing on another machine as well.

Peek 2020-05-29 18-43

closed time in 14 hours

dhrunia

issue commentmicrosoft/vscode

show eplorer keyboard shortcut not working on ubuntu 20.04

You can change the default keybinding of vscode or you can do what @yunielrc proposed. Thus closing this. Thanks

dhrunia

comment created time in 14 hours

issue commentmicrosoft/vscode

Restart while extension host debugging doesn't do anything anymore

@eamodio thanks a lot for filling this issue. I can reproduce only with new js-debug. The problem is the following, for pwa-extensionhost a session has a parent session and when we match the session ids on the renderer recieving end there is not match, since we send the child id and the extensino host expects a parent id.

Two potential fixes (which I verified work).

  1. For pwa-extensionhost sessions we should return the session.parentSession here
  2. When launching the new vscode window we should pass the debugId of the child session, so the matching done here matches

Forwarding to @connor4312 and assigning to May since this is a regression fyi @weinand

eamodio

comment created time in 14 hours

issue commentmicrosoft/vscode

A11y_VSCode_Version Control_Screenreader: Screenreader does not read the error message while creating new file or folder with empty name

@nirmalsahoo so the issue seems to be "Input box error message not read". Can you please file a new concise issue with minimal steps and we can continue the discussion there. Thanks

nirmalsahoo

comment created time in 15 hours

issue openedmicrosoft/vscode

Switching to simple full screen produces a jump

macOS catalina, VS Code insiders

Have "window.nativeFullScreen": false Turn on full screen. Notice how the whole top part of window jumps

recording

created time in 15 hours

issue commentmicrosoft/vscode

Terminal output div container should be more accessible for screen readers

@MarcoZehe makes sense @Tyriar we could put the role: document on the terminal xterm div element which is an ancestor of the list role and it should be good.

jooyoungseo

comment created time in 15 hours

issue closedmicrosoft/vscode

A11y_VSCode_Version Control_Screenreader: Screenreader does not read the error message while creating new file or folder with empty name

Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”

GitHubTags:#A11y_VSCode;#A11ySev2;#A11yTCS;#A11yMAS;#Benchmark;#DesktopApp;#MAS1.3.1;#MAS3.3.1;#Win10;#Visual Studio Code;#NVDA;#JAWS; #CAITestPass_May2020;#FTP;#STP;

Environment Details: Application Name: Visual Studio Code Windows Version: Windows10 Screenreader version:NVDA[2020.1], JAWS 2020.2001.70.400 Repro Steps: 1.Open Visual studio code editor 2.Using F1 key navigate to the palette, type "git branch" and select "Create Branch" 3. Enter the branch name in the edit field and hit enter. Observe the change in branch name at the bottom left corner 4. Publish branch to the remote Git repository by navigating to the bottom left pane, arriving at the cloud button next to the git branch and hit ENTER 5.Make changes to the code by refactoring, adding/deleting new lines ; using assistive technologies, observe if SRs will alert user the to blue/green/red indicators suggesting if code has been changed/new line added/line has been removed 6.Compare the changes between the HEAD and current file by navigating to View Bar ---> Git ; Navigate to changes and hit ENTER to activate "Diff View" ; use SR to parse code and observe behavior 7. Stage and commit the changes under View Bar ---> Git ; Navigate to the "Commit Staged" button and hit ENTER to make a commit 8. Undo the commit by navigating to the toggle button (same row as commit staged), hit ENTER and use down ARROW to choose "Undo Last Commit" option ; Push a commit following the same process 9. Navigate Git commands under Git output under the "toggle button" in step 7 10.Navigate to New folder or New file button and click on that. Actual: While navigating through keyboard,Screenreader does not read the error message while creating new file or folder with empty name. This issue is reproduced with NVDA and Jaws.

Expected: Screenreader should read the error message while creating new file or folder with empty name.

Attachment link for Reference:

https://microsoft-my.sharepoint.com/:v:/p/v-nisaho/EVHF_7m6NC5MhlIlK9TLRfkBp291YzQ84EzxYffOQ-kCGw?e=AcFFVI

closed time in 15 hours

nirmalsahoo

issue commentmicrosoft/vscode

A11y_VSCode_Version Control_Screenreader: Screenreader does not read the error message while creating new file or folder with empty name

Please follow these recommendations when filling issues for VS Code:

  • First try to find duplicates. Before filling any issue be aware of all the issues tagged with accessibility. It is not a long list, please read through it in detail!
  • Always test on VS Code insiders
  • Attach gifs inline in the issue. Do not give a link to a 20 MB ppt video
  • Do not write User Impact section, it is not useful
  • Be responsive, if an issue requires more information please respond in a timely manner

Here’s an example of a good concise user filled issue https://github.com/microsoft/vscode/issues/96987 Here’s an example of a not a concise issue with too many details https://github.com/microsoft/vscode/issues/62033

The moto should be quality not quantity.

Since this issue does not follow the recommendations I am closing it. Feel free to create a new concise issue. Thanks

nirmalsahoo

comment created time in 15 hours

issue commentmicrosoft/vscode

Terminal output div container should be more accessible for screen readers

@jooyoungseo thanks for feedback.

  1. I believe @Tyriar decided to use the role list because the terminal consistes of multiple lines with each being a listitem. We can experiment changing to document but let's also try to get feedback from the community
  2. This makes sense, however it might be controlled by the shell, @Tyriar will know more
  3. It is included in the F6 keycicle. Can you provide more details what is not working here?
jooyoungseo

comment created time in 17 hours

issue commentmicrosoft/vscode

Hitting enter on results in the find all references tree should move focus to the corresponding line in the editor

@Neurrone they should probably be in the debug console in the first window. F1 > view: debug console should show it.

Neurrone

comment created time in 17 hours

issue commentmicrosoft/vscode

Screen readers cannot update caret offset in code editor

@alexdima great pointer, thanks a lot! @joanmarie so I can produce a build with that if statment changed, or if you have time you can just change that line at textAreaInput:409 and run vscode out of source. Let me know what works for you.

joanmarie

comment created time in 17 hours

issue commentmicrosoft/vscode

Custom modal dialog information not accessible

@sbatten Thanks for fixing, let's add a bug label so we get this verified.

bpasero

comment created time in 17 hours

pull request commentmicrosoft/vscode

explorer: support for dnd remote resources

@bpasero did some googling and the only thing found is what you are already using for web dnd here. What I do not fully understand is why don't we take the same approach as we do for the web in the remote case? When we start dragging can't we fill in the same data as being done nativly when DnD from desktop starts? Or that is somehow magically done and we can not replicate it in the remote case?

isidorn

comment created time in 4 days

pull request commentmicrosoft/vscode

explorer: support for dnd remote resources

@bpasero thanks for the quick response. Yeah, I can explore putting the stream in the drag and drop data. Let me start googling...

isidorn

comment created time in 4 days

issue commentmicrosoft/vscode

Can't drag files from a remote vscode window to a local window

Created this PR as work in progress so we sketch out a solution https://github.com/microsoft/vscode/pull/98817

roblourens

comment created time in 4 days

PR opened microsoft/vscode

explorer: support for dnd remote resources

Fixes https://github.com/microsoft/vscode/issues/93599

This PR:

  • Introduces a new remote type transfer CodeRemoteFiles
  • Handles this on the Explorer side

What is missing: as @bpasero pointed out "local window needs to use some service (we probably have to add it) to resolve the content. This service could broadcast to windows (via electron-main) and ask the remote window to provide the contents".

Currently the explorer simply uses the workingCopyService which forwards everything to the fileService and the explorer simply passes the correct remote URIs. So where would be the best place to live for this service that communicates to the other window? Could this be done as part of the fileService?

@bpasero let me know what you think fyi @steven166

+31 -3

0 comment

2 changed files

pr created time in 4 days

create barnchmicrosoft/vscode

branch : isidorn/remoteToLocalDnD

created branch time in 4 days

issue commentmicrosoft/vscode

CallStack: set inline context key on hover not on context menu

@connor4312 I was thinking more about this. And what you want is context key that would be set on hover to be exactly the id of the session. That is a bit funky and we do not do it in other places in VS Code. We usualy set context keys based on the type, not the id. So for example "we are hovering over a session" would be one. But that is not enough for your use case.

The current callStackItemType should only be used by the context menu. For inline actions you can just push your actions there always since we only render the inline actions for sessions.

So what we are missing is specifying on what sessions you want your action to appear. Is there something special about these sessions? Can vscode somehow see that they can be profilied by looking at some flag? And then we can introduce a context key on the vscode side in the sense of callStackHoveredSessionCanBeProfiled

I just want to try to simplify this since our latest approach is a bit too complex imho...

isidorn

comment created time in 4 days

issue commentmicrosoft/vscode

Accessibility: Put Status Line Information In a Footer Tag

Assigning to June so we can experiment with this then.

jhomme

comment created time in 4 days

issue commentmicrosoft/vscode

Consider to show dynamic launch configs in Welcome view

I do not plan to push further changes here for May since we code freeze today. Thus moving out of the milestone and we can fine tune this next milestone.

weinand

comment created time in 5 days

pull request commentmicrosoft/vscode

Use new debug colour contributions in built-in themes

Pushing this out of May, so we merge when we tackle the color contrast issues.

robertrossmann

comment created time in 5 days

issue closedmicrosoft/vscode

Collapse all button not working in C++ debugging

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->

  • VSCode Version: 1.44.1
  • OS Version: Ubuntu 18

Steps to Reproduce:

  1. Write a program in C++.
  2. Debug it and try collapse all button.

<!-- Launch with code --disable-extensions to check. --> Does this issue occur when all extensions are disabled?: Yes/No

Screenshot from 2020-05-29 10-53-46

closed time in 5 days

gurrrung

issue commentmicrosoft/vscode

Collapse all button not working in C++ debugging

If you can not reproduce with vscode insdiers taht means it is fixed. Thus closing

gurrrung

comment created time in 5 days

issue commentmicrosoft/vscode

Folders not ordered alphabetically

Please search for order and file-explorer tag to find duplicates

Dispersia

comment created time in 5 days

issue commentmicrosoft/vscode

Collapse all button not working in C++ debugging

Thanks for filling this issue. I can not reproduce this. Can you reproduce using Visual Studio Code Insiders https://code.visualstudio.com/insiders/

gurrrung

comment created time in 5 days

issue commentmicrosoft/vscode

Accessibility: Put Status Line Information In a Footer Tag

Yes, but what would be gain by it. @joanmarie does Orca handle footer tags in any special way?

jhomme

comment created time in 5 days

issue commentmicrosoft/vscode

Local variables are collapsed in annoying ways

@connor4312 that's what we do currently. We always expand the first scope if not expensive.

jrieken

comment created time in 5 days

issue openedmicrosoft/vscode

Hex editor should be accessible

Hey Logan, just kreating this so we keep it in mind. The hex editor should be accessible, that means that all fields should be navigalbe by keyboard and that when you navigate the screen reader always reads the correct content.

For more details we can also sync. Feel free to ping me

created time in 6 days

issue commentmicrosoft/vscode

Local variables are collapsed in annoying ways

I can change our heuristic that we expand all non expansive scopes. However I would only do that start of milestone to have a long time to gather feedback since I am not optimistic about that change. Thus pushing to June when I will change that.

jrieken

comment created time in 6 days

issue commentmicrosoft/vscode

Suggestion. Highlight unsaved files in explorer.

This is a fair feature request, however we do not have it on our immediate plan. Thus assigning to backlog and we might add this in the future. Thanks

AlexPritchin

comment created time in 6 days

pull request commentmicrosoft/vscode

editor use contenteditable instead of textarea

Feedback from Alex

I did a quick look last week and it makes total sense what you are doing. The very difficult thing is that in order to actually merge this in we need a lot of testing. The input of the editor depends on browser, OS, and keyboard layout / IME. So there is a huge test matrix and IMHO we would need to do a whole lot of testing to have this be the default, because maybe on Safari/iOS the contenteditable behaves slightly different than a textarea, etc. Some of the input ways we know about are documented here -- https://github.com/microsoft/vscode/wiki/IME-Test -- but there might be many more ways which work today and are just not documented there...

An approach would be to have a setting and have both code paths (with contenteditable or with the textarea based on the setting). I am a bit defensive to merge this unless it is behind a setting because we might break some huge population doing some kind of user input which we don't know about. There are other factors, where I heard in the past that in the content editable it is possible to drag&drop images and I see you now use .textContent to replace the textarea.value, but I don't know if that always works OK.

TL;DR: Looks good for exploring, but maybe it needs to be implemented (at least initially) behind a setting since I'm so worried with wide user input breakage which cannot be covered by unit tests... This is a surprisingly deep topic -- look at the amount of bugs we get in this area -- https://github.com/microsoft/vscode/issues?q=is%3Aopen+is%3Aissue+label%3Aeditor-input-IME

isidorn

comment created time in 7 days

issue commentmicrosoft/vscode

Empty notifications area should have focus on the action toolbar

@ChrisPapp thanks for offering, however @bpasero and me just discussed this and came up with a very practical solution. Executing commands from the status bar no longer focuses the editor, this was some old behavior.

isidorn

comment created time in 7 days

push eventmicrosoft/vscode

isidor

commit sha a73cc731a4806299b1891248ce63ab561848124b

statusBar: do not focus editor when executing commands fixes #97513

view details

push time in 7 days

issue closedmicrosoft/vscode

Empty notifications area should have focus on the action toolbar

Found by @jvesouza

  1. Have no notifications, focus in editor, press F6
  2. Move focus via arrows until notifications area is focused
  3. Press space - focus is moved to the editor 🐛

Focus should be in the notifications area, not in the editor. Focus jumping to the editor is a bit sudden imho

closed time in 7 days

isidorn

issue commentmicrosoft/vscode

[FR] Small screens: Debug toolbar docking location outside of side bar

This is a fair feature request, however we do not have it on our immediate plan. Thus assigning to backlog and we might add this in the future. Thanks

lukepighetti

comment created time in 7 days

issue commentmicrosoft/vscode

Allow customizing hover details for debug sessions

I think this makes session. However what would you have it say? Just duplicating the name does not make sense. Maybe "Order Portal Debug Session"?

connor4312

comment created time in 7 days

issue commentmicrosoft/vscode

👁 Explorer focus mode to hide hidden files

This is a fair feature request, however we do not have it on our immediate plan. Thus assigning to backlog and we might add this in the future. Thanks

aaronadamsCA

comment created time in 7 days

push eventmicrosoft/vscode

isidor

commit sha 5575473244abeb32a537ba5fe52d10d0d0a8817e

#98584

view details

push time in 7 days

issue commentmicrosoft/vscode

[loc][Query][VSCODE] Localizability of strings in vscode-editor

@bpasero thanks. Tackled that

PDostalek

comment created time in 7 days

issue commentmicrosoft/vscode

Improve settings editor accessibility

@roblourens do we plan to look into this in May? I think we should push it out to June?

roblourens

comment created time in 7 days

push eventmicrosoft/vscode

isidor

commit sha 9a2062ff5df3cf05c763b7ed6dadff26ddce00c4

translation clarifications #98576

view details

push time in 7 days

issue commentmicrosoft/vscode

[loc][Query][VSCODE] Localizability of strings in vs_workbench

I have pushed a commit which adds comments for all 4 of my localization strings, thus unassigning myself.

PDostalek

comment created time in 7 days

issue commentmicrosoft/vscode

Search for directory and reveal in explorer

This could be done by an extension, thus closing as extension candidate. The extension could contribute a command which uses quick pick and then call revealInExplorer command As for filter in the explorer for searching inside collapsed there is already a feature request for this.

CallMeBW

comment created time in 8 days

issue commentmicrosoft/vscode

Hitting enter on results in the find all references tree should move focus to the corresponding line in the editor

@Neurrone nope you do not have to run vscode out of source, you could just run regular vs code insiders or vscode stable. If pressing F5 when debugging the extension does not work then I am not sure what is the cause. I would guess that the extension can not be build for some reason. I would try opening it in the terminal and trying to build it via yarn or some other script which might be specified in package.json

I can also look into creating this PR if you continue to hit this issue.

Neurrone

comment created time in 8 days

issue commentmicrosoft/vscode

explorerResourceIsFolder combine with listDoubleSelection

This is a fair feature request, however those context keys are designed for internal use and we would not change anything there at the moment. However leaving this request open as we might tackle it in the future.

moshfeu

comment created time in 8 days

issue commentmicrosoft/vscode

Create a difference between Open Editors and Tabs

What you want is a working sets view, duplicate of already opened issues which you can find if you search for issue tagged with file-exporer and feature-request.

heliocarbex

comment created time in 8 days

issue commentmicrosoft/vscode

Accessibility: Put Status Line Information In a Footer Tag

Status line information is already captured by the role status. Thus your screen reader should read when you tell it to read status bar inforamtion. Though note there is an issue on the nvda side https://github.com/nvaccess/nvda/issues/11064

Can you elaborate what you mean by the "Footer Tag"

jhomme

comment created time in 8 days

issue commentmicrosoft/vscode

Screen readers cannot update caret offset in code editor

@joanmarie yes this seems to be due to the fact that we are using a textArea. So the gist is Orca updates caret position in the textArea and the Editor does not reflect that.

Idealy we would listen on cursor change events in the textArea somewhere here and update the cursor location in the real editor. Googled a bit and I could not find an event for "caret updated". Though i migtht be missing something.

fyi @alexdima

joanmarie

comment created time in 8 days

issue closedmicrosoft/vscode

Can't create file or directory with keyboard directly.

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> create file or directory must with mouse. <!-- Describe the feature you'd like. --> create file or directory easy as bash.

closed time in 8 days

MicroJes

issue commentmicrosoft/vscode

Can't create file or directory with keyboard directly.

You can create it with a keyboard F1 > new file, you can also assign a custom keybinding to it

MicroJes

comment created time in 8 days

issue commentmicrosoft/vscode

Cannot add folder to workspace

Oh my! Sorry for that. I should have just copied.

AGiantSquid

comment created time in 8 days

issue commentmicrosoft/vscode

Make it possible to inactivate folders within a workspace

Should be covered by this idea https://github.com/microsoft/vscode/pull/87666

mojoaxel

comment created time in 8 days

issue commentmicrosoft/vscode

File copy+paste no longer works within Explorer pane

I can reproduce this on Ubuntu 18. On macOS all works fine. The error is coming from the workingCopyFileService thus forwarding to @bpasero to also inveistigate fyi @deepak1556 since we upgraded to latest Electron and this is probably the root cause Code pointer where we throw https://github.com/microsoft/vscode/blob/66ef23d401b24444d1465aa4bd6db369c1632de2/src/vs/workbench/contrib/files/browser/fileActions.ts#L1174

The file to paste has been deleted or moved since you copied it. Error: ENAMETOOLONG: name too long, stat '/102,105,108,101,58,47,47,47,104,111,109,101,47,112,97,114,97,108,108,101,108,115,47,68,101,118,101,108,111,112,109,101,110,116,47,118,115,99,111,100,101,47,115,114,99,47,118,115,47,119,111,114,107,98,101,110,99,104,47,98,114,111,119,115,101,114,47,112,97,114,116,115,47,109,101,100,105,97,47,99,111,109,112,111,115,105,116,101,112,97,114,116,46,99,115,115'
nickcoad

comment created time in 8 days

issue commentmicrosoft/vscode

many selected file, Finder display, only selected a file

Yeah, Open In Finder does not support selecting multiple files in the native finder for now. Though this is a fair feature request, thus assigning to backlog and we might look into it in the future.

fjqingyou

comment created time in 8 days

issue commentmicrosoft/vscode

TS Server takes 100% cpu

@aeschli I am trying it now. We will see tomorrow, since this for some reasons happens once per day.

isidorn

comment created time in 8 days

issue commentmicrosoft/vscode

Add possibility to copy text selected with ctrl-A from a debug hover

Copy all selection is simply not implemented in the debug hvoer. Nad yeah we show the native selection and the tree selection. We have a similar issue in the debug console. For now leaving this open as a feature request and assigning to backlog. Thanks

wonkoRT

comment created time in 8 days

issue closedmicrosoft/vscode

Make it possible to inactivate folders within a workspace

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. -->

I like the idea of workspaces where you can work on multible projects/libraries/folders within a given context. 💓

The idea:

Mark folders within a workspace "inactive" or "active". ☑️

Description

If a folder in a workspace was marked "inactive":

  • It is closed/collapsed and can not be reopend untill marked "active" again.
  • It is excluded from the global search
  • Changes are not shown in the source-control panel

Why?

I often work on a project that consist of multible libraries. These libraries belong to the same "project" and I like them in one place/workspace. But it happens often that a search returns files from a sub-library that I'm not currently interested in (I know I can tweak the search but this again is work, I don't want to do every time). Also the source control gets easily cluttered with git infos I'm not interested in. And why vscode is still missing a task-focused-ui-plugin I would like a way to reduce (the always growing) amount of "noise" in the workspace. ⁉️

Work around / current state

At the moment I remove folders from the workspace and than add them again if I need to work on them again. This makes the whole concept of a workspace useless. 💔

closed time in 8 days

mojoaxel

issue commentmicrosoft/vscode

Make it possible to inactivate folders within a workspace

You basically working sets, thus duplicate of https://github.com/microsoft/vscode/issues/9498

mojoaxel

comment created time in 8 days

issue commentmicrosoft/vscode

When Windows is in High Contrast theme, VSCode starts in High Contrast theme and then immediately switches to the right one

This is a theme issue, not an accessibility issue, thus removing tag and myself. I am not sure where we apply the High Contrast theme automaticallt. @aeschli might know more and provide a code pointer.

p10tr3k

comment created time in 8 days

issue closedmicrosoft/vscode

Zen Mode Git-Compare breaks single editor

Issue Type: <b>Bug</b>

  1. open 3 editors side by side
  2. enter zen
  3. open Source control and compare any file.
  4. exit zen
  5. close 2 editors, so that only one remains open
  6. Result

I can't get it unstuck. Restart of code & system didn't help. Whenever it's in more than 1 editor mode it works like expected.

VS Code version: Code - OSS 1.44.2 (ff915844119ce9485abfe8aa9076ec76b5300ddd, 2020-04-23T19:32:05.786Z) OS version: Linux x64 5.4.40-1-MANJARO

<details> <summary>System Info</summary>

Item Value
CPUs AMD Ryzen 7 1800X Eight-Core Processor (16 x 3699)
GPU Status 2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>protected_video_decode: unavailable_off<br>rasterization: disabled_software<br>skia_renderer: disabled_off_ok<br>video_decode: unavailable_off<br>viz_display_compositor: enabled_on<br>viz_hit_test_surface_layer: disabled_off_ok<br>webgl: enabled<br>webgl2: enabled
Load (avg) 1, 1, 1
Memory (System) 15.65GB (9.13GB free)
Process Argv --no-sandbox --unity-launch --no-sandbox
Screen Reader no
VM 0%

</details> <!-- generated by issue reporter -->

closed time in 8 days

Twiggeh

issue commentmicrosoft/vscode

Zen Mode Git-Compare breaks single editor

Please use this setting if you want to disable this behavior "zenMode.centerLayout": false,

Twiggeh

comment created time in 8 days

issue commentmicrosoft/vscode

${relativeFile} not relative to workspace folder when symlinked

As this is configuration resovling assigning also to @alexr00 and unassigning myself.

Xunnamius

comment created time in 8 days

issue commentmicrosoft/vscode

Ability to set context keys per item in the call stack view

@joaomoreno yeah I should do it on my elements, thanks. We can do it with a small timeout, and only once hovered element changes. So I think it will not be a performace problem in the end. I can measure.

@connor4312 bottom line, I need to fix that the context key is set per hovered item, not per context menu. I have created this issue to track this https://github.com/microsoft/vscode/issues/98570 I will try to look into it this week.

connor4312

comment created time in 8 days

issue openedmicrosoft/vscode

CallStack: set inline context key on hover not on context menu

Spinoff from https://github.com/microsoft/vscode/issues/97633

I need to fix that the context key is set per hovered item, not per context menu in the call stack view

created time in 8 days

issue commentmicrosoft/vscode

Accessibility: Keyboard shortcuts to set start and end selection

@Neurrone yeah, we only show the command when it is applicable - when an anchor was set.

zersiax

comment created time in 8 days

issue commentmicrosoft/vscode

Code insiders helper - renderer 100% cpu

Might it be TS semantic highlighthing that causes 100% cput? fyi @aeschli

isidorn

comment created time in 8 days

more