profile
viewpoint
Isidor Nikolic isidorn Microsoft Zurich VSCode

issue closedmicrosoft/vscode

Layout error when renaming long filenames

Issue Type: <b>Bug</b>

批注 2019-07-10 190621

批注 2019-07-10 190744

When I rename the long filename, the scrollbar is misplaced and the file icon is missing.

VS Code version: Code 1.36.1 (2213894ea0415ee8c85c5eea0d0ff81ecc191529, 2019-07-08T22:59:35.033Z) OS version: Windows_NT x64 10.0.18362

<details> <summary>System Info</summary>

Item Value
CPUs Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz (8 x 1992)
GPU Status 2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>native_gpu_memory_buffers: disabled_software<br>oop_rasterization: disabled_off<br>protected_video_decode: enabled<br>rasterization: enabled<br>skia_deferred_display_list: disabled_off<br>skia_renderer: disabled_off<br>surface_synchronization: enabled_on<br>video_decode: enabled<br>viz_display_compositor: disabled_off<br>webgl: enabled<br>webgl2: enabled
Load (avg) undefined
Memory (System) 7.85GB (1.25GB free)
Process Argv
Screen Reader no
VM 0%

</details><details><summary>Extensions (28)</summary>

Extension Author (truncated) Version
TabOut alb 0.1.6
pascal ale 8.0.2
pascal-formatter ale 2.2.0
language-gas-x86 bas 0.0.1
doxdocgen csc 0.5.0
disasexpl dse 0.0.5
gitlens eam 9.8.3
vsc-material-theme Equ 29.2.0
vsc-material-theme-icons equ 1.0.6
todo-tree Gru 0.0.138
output-colorizer IBM 0.1.2
path-autocomplete ion 1.13.3
vscode-kanban mkl 1.25.0
vscode-filesize mkx 2.1.3
vscode-language-pack-zh-hans MS- 1.36.2
python ms- 2019.6.24221
cpptools ms- 0.24.0
Go ms- 0.11.4
java red 0.46.0
markdown-preview-enhanced shd 0.4.3
code-spell-checker str 1.7.17
language-stylus sys 1.11.0
vscodeintellicode Vis 1.1.7
vscode-java-debug vsc 0.20.0
vscode-java-dependency vsc 0.5.1
vscode-java-pack vsc 0.7.1
vscode-java-test vsc 0.18.1
vscode-maven vsc 0.18.0

(4 theme extensions excluded)

</details> <!-- generated by issue reporter -->

closed time in 6 days

mxdh

issue commentmicrosoft/vscode

Layout error when renaming long filenames

Dup of https://github.com/microsoft/vscode/issues/71291

mxdh

comment created time in 6 days

issue commentmicrosoft/vscode

Reveal Active File in Side Bar command is unreliable

@mgabeler-lee-6rs Thanks for reporting this. When you get this, if you F1 > developer tools > debug console > Do you see some error?

Can you try to get exact reproducable steps, we are very interested in hunting this bug down? fyi @joaomoreno

mgabeler-lee-6rs

comment created time in 6 days

issue closedmicrosoft/vscode

A11y_VSCode_DebugConsole_ScreenReader: Voice over does not announce the pop up title as 'Debug console' when it is opened using ctrl+shift+y.

Environment Details: VSCode Version : 1.36.1 (user setup) OS Version : MacOS Mojave 10.14.5

Additional Details: MAS Violated : MAS 1.3.1 Screen Reader Versions : Voice over

Repro Steps:

  1. Open Visual studio code editor
  2. Press ctrl+shift+y
  3. Validate that debugging messages show-up in Debug console
  4. Start voice over

Actual: Voice over does not announce the pop up title as 'Debug console' when it is opened using ctrl+shift+y.

This issue is observed in Mac + voice over

Expected: Screen reader should announce the pop up title as 'debug console' when it is opened using ctrl+shift+y.

Recommendations: Refer below link which is repository of bug fixes code snippets: https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx

User Impact: Screen reader users will not get that on which page it is being redirected.

MAS Reference: MAS 1.3.1 - https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4}

Attachment for Reference: A11y_VSCode_DebugConsole_ScreenReader.pptx

closed time in 6 days

bhagwatshelke1047

PR opened microsoft/vscode

Reviewers
List select expands selection

This PR:

  1. Changes the list.select command such that it expands the selection, and not to set the selection to 1 element like before
  2. Changes that the list fires the open event for all the newly selected elements (not just one)
  3. Adopts the explorer to react to this, thus fixing #42573

fixes #42573

+19 -14

0 comment

2 changed files

pr created time in 6 days

create barnchmicrosoft/vscode

branch : isidorn/listSelect

created branch time in 6 days

push eventmicrosoft/vscode

isidor

commit sha 2bcc197d6f81a5dcc526497efddc8a1bd82cccf8

folding: introduce foldingEnabled context

view details

Isidor Nikolic

commit sha 759ac9fef484e2cb4796909c6f76649faed0b5c9

Merge pull request #76979 from microsoft/isidorn/foldingContext folding: introduce foldingEnabled context

view details

push time in 6 days

delete branch microsoft/vscode

delete branch : isidorn/foldingContext

delete time in 6 days

PR merged microsoft/vscode

Reviewers
folding: introduce foldingEnabled context

Fixes https://github.com/microsoft/vscode/issues/17257

This pr introduces a context foldingEnabled which is true when folding is enabled, and false otherwise. Now all the folding actions are using this context as a precondition. Which results in the fact that they are not present in the command palette when fodling is disabled. I have tested this and it seems to work nicely.

+20 -12

1 comment

1 changed file

isidorn

pr closed time in 6 days

issue closedmicrosoft/vscode

Folding / unfolding is not being read out by screen reader

VS Code Version: 1.6.1 OS Version:1607 NVDA version:-2016.2.1

Steps to Reproduce: 1.Open VS code editor. 2.Navigate to one of the editor. 3. Navigate to a Bracket present in the file and see the matched bracket highlighted and observe NVDA announcement. 4. Navigate to the Name which you want to change and Press Options button or Right Click and select Change all Occurrences and Hit Enter and change the Name to Desired Name and observe NVDA announcement. (Note- Options key is available only in Personal Computer and Not on Laptops) 5. Press f1 and type "Fold" or "Unfold "command in command pallet and Hit Enter and observe NVDA announcement.

Expected result: NVDA should provide information when two brackets are matched or after changing multiple occurrence or after folding/unfolding

Actual Result: NVDA is not reciting any information when two brackets are matched or after changing multiple occurrence or after folding/unfolding. Observation: NVDA announces the command written ">fold" in command pallet when Keyboard focus goes to the options Displayed by Command Pallet

User Impact: Screen Reader user doesn't get to know when two brackets are matched or after changing multiple occurrence or after folding/unfolding.

Attachments: nvda announces the command in the command pallete for all options displayed by command pallete nvda is not reciting any information after changing multiple occurance nvda is not reciting any information after folding a file nvda is not reciting any information after unfolding a file nvda is not reciting any information when two brackets are matched

closed time in 6 days

WiproPSAccTest

pull request commentmicrosoft/vscode

folding: introduce foldingEnabled context

@aeschli approved via chat, thus merging in

isidorn

comment created time in 6 days

issue commentmicrosoft/vscode

Autocomplete accessibility glitch

The textarea of the editor must dynamically change aria-haspopup, aria-autocomplete and aria-activedescendant attributes based on the suggestion widget state. For this we will need to add editor api setAria(options)

Assigning to next milestone so I invest time then to fix this properly.

zersiax

comment created time in 6 days

push eventmicrosoft/vscode

isidor

commit sha 07d0c6f39c1256f41d9ad232bce02cf49d03fc8c

do not assign to me while i am on vacation

view details

push time in 6 days

issue commentmicrosoft/vscode

Screen reader does not announce the expand state of select box

@RohitJadhav-TCS thanks for commenting here. Yes they both use the same underlying component, thus if we fix this in the underlying select box compoentn it will be fixed everywhere. Due to that having one issue is best.

RohitJadhav-TCS

comment created time in 6 days

issue commentmicrosoft/vscode

Add ARIA info to dialogs

Removing help-wanted since I provided a PR for this

sbatten

comment created time in 6 days

PR opened microsoft/vscode

Reviewers
dialog box add aria-label

fixes #70981

This PR adds the aria-label to the custom dialog box. I have tested this on my Mac and works nicely.

If you think this is ok please merge since next two weeks I am out.

+1 -0

0 comment

1 changed file

pr created time in 6 days

create barnchmicrosoft/vscode

branch : isidorn/dialogLabel

created branch time in 6 days

issue openedmicrosoft/vscode

No folder: simple file dilaog should show home directory as default

  1. Open vscode with no folder (purple status bar)
  2. Have "files.simpleDialog.enable": true,
  3. New untitled file, save as file
  4. Notice how the simple dialog offers me the root path. This is wrong imho, you should offer the home directory, or at least something wich I choose the last time

created time in 6 days

issue closedmicrosoft/vscode

A11y_VSCode_VersionControl_ScreenReader_ Screen reader does not announce about green blue red line indicator

Environment Details: VSCode Version : 1.36.0 OS Version : Win10 Additional Details: MAS Violated : MAS 1.3.1

Repro Steps: 1.Open Visual studio code editor 2.Using F1 key navigate to the palette, type "git branch" and select "Create Branch" 3. Enter the branch name in the edit field and hit enter. Observe the change in branch name at the bottom left corner 4. Publish branch to the remote Git repository by navigating to the bottom left pane, arriving at the cloud button next to the git branch and hit ENTER 5.Make changes to the code by refactoring, adding/deleting new lines ; using assistive technologies, observe if SRs will alert user the to blue/green/red indicators suggesting if code has been changed/new line added/line has been removed 6.Start Screen reader. 7. Observe screen reader announcement while navigating through each line in code editor. Actual: screen reader does not announce about new line is added on modified or deleted .

Expected: screen reader should announce about new line is added on modified or deleted . Recommendations: Refer below link which is repository of bug fixes code snippets: https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx User Impact: Keyboard and screen reader user will face difficulty to access this controls. MAS Reference: MAS 2.1.1 - https://microsoft.sharepoint.com/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4} Attachment For Reference: A11y_VSCode_VersionControl_ScreenReader_Screen reader does not announce about the green blue and red line indicator.pptx

Does this issue occur when all extensions are disabled?: Yes

closed time in 6 days

prasadaps

issue commentmicrosoft/vscode

A11y_VSCode_VersionControl_ScreenReader_ Screen reader does not announce about green blue red line indicator

This is simply not how this experience is designed. User can press F7 and shift+F7 to go through the changes while in the diff view And alt + F3 , alt + shit + F3 to go through the changes via zone widget - this nicely reads out all the changes in an acccessible way. Closing as designed / will not support this

prasadaps

comment created time in 6 days

issue commentmicrosoft/vscode

Menu: Proper role and state is not announced to the screen reader users.

I see that we are assinging the role here However we never set the aria-expanded @sbatten Can you please look into adding that and check if the role is properly set

MayuriNaik

comment created time in 6 days

issue closedmicrosoft/vscode

A11y_VSCode_Keyboardshortcuts_Keyboard:While Voice over is on the Keyboard shortcut list is not accessible through keyboard.

Environment Details: VSCode Version : 1.36.1 (user setup) OS Version : MacOS Mojave 10.14.5

Additional Details: MAS Violated : MAS 2.1.1 Screen Reader Versions : Voice over

Repro Steps: 1.Open Visual studio code editor. 2.Naviagte to setting icon 3)Select "Keyboard shortcuts options" 4)Start voice over

Actual: While Voice over is on the Keyboard shortcut list is not accessible through keyboard.

This issue is observed in Mac + Voice over

Expected: While Voice over is on the Keyboard shortcut list should be accessible through keyboard.

Recommendations: Refer below link which is repository of bug fixes code snippets: https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx

User Impact: Screen reader users will face difficulty to access the proper information.

MAS Reference: MAS 2.1.1 - https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={8492c4eb-c179-40ae-8777-cd044ed725a2}

Attachment for Reference: A11y_VSCode_Keyboardshortcuts_Keyboard.pptx

closed time in 6 days

bhagwatshelke1047

push eventmicrosoft/vscode

isidor

commit sha f06db31fcc7c0534014937b6e10316e65969a4e4

Debug: save view state when it changes and not on shutdown fixes #77060

view details

push time in 6 days

issue closedmicrosoft/vscode

Debug: save view state when it changes and not on shutdown

In debugService#saveState we collect various UI state to persist. I would like to move away from this model towards a version that persists the state when it actually changes. The reason is:

  • this will help for cases where you loose state because of a crash or OS restart (https://github.com/microsoft/vscode/issues/12058)
  • this will help in the web where we do not have an easy async shutdown sequence

It should be relatively easy here to change to a model where you persist the state once it changes.

closed time in 6 days

bpasero

issue closedmicrosoft/vscode

A11y_VSCode_SidebarBarOptions_AccessingTheExplorersidebaroptionsandCreatinga newfile_ScreenReader: Inappropriate name is announced for the “Open Editors”, “PRE.REQ” and “Outline” toolbar.

Environment Details: VSCode Version : 1.35.6 (user setup) OS Version : Win10

Additional Details: MAS Violated : MAS 1.3.1, MAS 4.1.2 ScreenReader Versions : NVDA2019.1.1, JAWS 2019

Repro Steps:

  1. Pre-req: Create an empty folder on desktop
  2. Open Visual studio code editor.
  3. Using "Ctrl+Shift+E" key navigate to the Explorer side view bar option.
  4. Using "Tab" key navigate to explorer side bar options.
  5. Arrive at the "Open Folder" button and hit "Enter".
  6. Select the folder created under "Pre-req".
  7. Using "Tab" key navigate to and select "New File" option using "Enter" key.
  8. Start screen reader
  9. Using "Tab" key navigate to extension side bar options.

Actual: When screen reader users navigate through the “Open Editors”, “PRE.REQ” and “Outline” toolbar inappropriate name is announced to the users which is incorrect.

Expected: The “Open Editors”, “PRE.REQ” and “Outline” toolbar should be announced with the specific name and their state of either expand/collapsed accordingly.

Recommendations: Refer below link which is repository of bug fixes code snippets: https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx

User Impact: If the name of the controls is not announced properly to the screen reader user then they will get confused.

MAS Reference: MAS 4.1.2 - https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={248054a6-5e68-4771-9e1e-242fb5025730}

Attachment for Reference: VSCode_SidebarBarOptions_AccessingTheExplorersidebaroptionsandCreatinga newfile_ScreenReader Inappropriate name for toolbar

closed time in 6 days

MayuriNaik

issue commentmicrosoft/vscode

A11y_VSCode_SidebarBarOptions_AccessingTheExplorersidebaroptionsandCreatinga newfile_ScreenReader: Inappropriate name is announced for the “Open Editors”, “PRE.REQ” and “Outline” toolbar.

This works for me and also works for you (check your screen shot it nicely says Open Editors Section tool bar expanded). We properly set the aria-expanded attribute. Thus closing as invalid

MayuriNaik

comment created time in 6 days

issue commentmicrosoft/vscode

Git: announce when git operations get completed

@joaomoreno it is correct that you are not annoucning anything for git operations. Leaving this open and assigning to you so you decide if you would like to announce something once a git opertion is completed. Might make sense. Also not sure if you already have an issue for this

prasadaps

comment created time in 6 days

issue closedmicrosoft/vscode

A11y_VSCode_SidebarBarOptions_AccessingTheDebugsidebaroptions_ScreenReader: Identical names provided for the “Collapse all” buttons for “Variables” and “Watch” toolbar.

Environment Details: VSCode Version : 1.35.6 (user setup) OS Version : Win10

Additional Details: MAS Violated : MAS 4.1.2 ScreenReader Versions : NVDA2019.1.1, JAWS 2019

Repro Steps:

  1. Open Visual studio code editor.
  2. Using "Ctrl+Shift+D" key navigate to the debug side view bar option.
  3. Using "Tab" key navigate to Debug side bar options.
  4. Start screen reader.
  5. Navigate to the “Collapse all” buttons for “Variables” and “Watch” toolbar.
  6. Listen to how it is announced.

Actual: If the more than one interactive element is provided with the same name for the controls in two different toolbars then the screen reader users will find it hard in knowing which control is for which section.

Expected: The name provided for each of the controls should be unique so the screen reader users can differentiate the two controls from the two different toolbar.

Recommendations: The “Collapse all” button in “Variables” toolbar should be announced as “Collapse all Variables” and for “Collapse all” button in “Watch” toolbar as “Collapse all Watch”.

Refer below link which is repository of bug fixes code snippets: https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx

User Impact: If the interactive elements are not provided with unique different names then the screen reader users might not be able to differentiate between them.

MAS Reference: MAS 4.1.2 - https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={248054a6-5e68-4771-9e1e-242fb5025730}

Attachment for Reference: VSCode_SidebarBarOptions_AccessingTheExtensionbaroptions_ScreenReader Identical names for “Collapse all” buttons

closed time in 6 days

MayuriNaik

issue closedmicrosoft/vscode

A11y_VSCode_VersionControl_Screenreader_screen reader does not announce information about operation.

Environment Details: VSCode Version : 1.36.0 OS Version : Win10 Additional Details: MAS Violated : MAS 1.3.1

Repro Steps: 1.Open Visual studio code editor 2.Using F1 key navigate to the palette, type "git branch" and select "Create Branch" 3. Enter the branch name in the edit field and hit enter. Observe the change in branch name at the bottom left corner 4. Publish branch to the remote Git repository by navigating to the bottom left pane, arriving at the cloud button next to the git branch and hit ENTER 5.Start Screen reader. 6. Observe screen reader announcement when click on publish button.

Actual: when user click on Commit all option or on the undo last commit option or on the publish button the screen reader does not announce status message of performed action i.e. committing action undoing the last action or publishing the to git.

Expected: screen reader should announce status message of whatever operation is performing in background

Recommendations: Refer below link which is repository of bug fixes code snippets: https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx

User Impact: Screen reader user will not get informed with the action performed.

MAS Reference: MAS 4.1.3- https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/Doc.aspx?sourcedoc=%7B684573A7-B089-4131-9B39-0009054125D3%7D&file=MAS%204.1.3%20%E2%80%93%20Status%20Messages.docx&action=default&mobileredirect=true&cid=1f363df4-1eaa-4680-9e0a-c63b09081427

Attachment For Reference: nOT ANNOUNCING ANY THING.pptx

Does this issue occur when all extensions are disabled?: Yes

closed time in 6 days

prasadaps

issue commentmicrosoft/vscode

A11y_VSCode_VersionControl_Screenreader_screen reader does not announce information about operation.

Dup of https://github.com/microsoft/vscode/issues/76977

prasadaps

comment created time in 6 days

issue closedmicrosoft/vscode

A11y_VSCode_VersionControl_Keyboard_Keyboard focus is not going on the publish button

Environment Details: VSCode Version : 1.36.0 OS Version : Win10 Additional Details: MAS Violated : MAS 2.4.3

Repro Steps: 1.Open Visual studio code editor 2.Using F1 key navigate to the palette, type "git branch" and select "Create Branch" 3. Enter the branch name in the edit field and hit enter. Observe the change in branch name at the bottom left corner 4. Publish branch to the remote Git repository by navigating to the bottom left pane, arriving at the cloud button next to the git branch and hit ENTER 5. Observe the focus is going on the publish button.

Actual: Focus is not going on the publish button which are at bottom of the application . The same issue is observed on all the button which are present at bottom of the application image

Expected: Focus should be go on this button's

Recommendations: Refer below link which is repository of bug fixes code snippets: https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx User Impact: Keyboard and screen reader user will face difficulty to access this controls.

MAS Reference: MAS 2.4.3 -https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={0de7fbe1-ad7e-48e5-bcbb-8d986691e2b9} Attachment For Reference: BOTTON BUTTON ARE NOT ACCESSIBLE.pptx

Does this issue occur when all extensions are disabled?: Yes

closed time in 6 days

prasadaps

issue commentmicrosoft/vscode

A11y_VSCode_VersionControl_Keyboard_Keyboard focus is not going on the publish button

This is by design, we do not focu sthe status bar because that would bring too many hops for the user to naviagte through our workbench. Also none of the status bar items have unique information, that is all duplicated and is simply designed to not be accessed by tab navigation

prasadaps

comment created time in 6 days

issue closedmicrosoft/vscode

A11y_VSCode_ChangingtheUsersettings_ScreenReader: Screen reader does not announce expanded, collapsed state of 'Editor: Accessibility Support' combo box when we expand or collapse it.

Environment Details: VSCode Version : 1.36.1 (user setup) OS Version : MacOS Mojave 10.14.5

Additional Details: MAS Violated : MAS 1.3.1 Screen Reader Versions : Voice over

Repro Steps: 1.Open Visual studio code editor. 2.Open the command Pallet by pressing "F1" key and type "setting". 3.Using down-arrow key select user setting. 4.Type the word "Auto " and select one of the suggestion given by the vs code editor. 5.Type the "Tab size" and select the option from the auto suggestion. 6.Start screen reader

Actual: Screen reader does not announce expanded, collapsed state of 'Editor: Accessibility Support' combo box when we expand or collapse it.

This issue is observed in Mac + Voice over

Expected: Screen reader should announce the expanded, collapsed state when we expand or collapse the 'Editor: Accessibility Support' combo box

Recommendations: Refer below link which is repository of bug fixes code snippets: https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx

User Impact: Screen reader users will not understand the combo box is actually expanded or not.

MAS Reference: MAS 1.3.1 - https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4}

Attachment for Reference: A11y_VSCode_ChangingtheUsersettings_ScreenReader_Mac.pptx

closed time in 6 days

bhagwatshelke1047

issue closedmicrosoft/vscode

A11y_VSCode_SidebarBarOptions_AccessingTheExplorersidebaroptionsandCreatinganewfile_ScreenReader: The “New File”, “New Folder”, etc. buttons are announced with the state as selected in MAC.

Environment Details: VSCode Version : 1.35.6 (user setup) OS Version : MAC OS Mojave, V 10.14.5, Mac Mini Late2012

Additional Details: MAS Violated : MAS 1.3.1 ScreenReader Versions : Voiceover

Repro Steps:

  1. Pre-req: Create an empty folder on desktop
  2. Open Visual studio code editor.
  3. Using "Ctrl+Shift+E" key navigate to the Explorer side view bar option.
  4. Using "Tab" key navigate to explorer side bar options.
  5. Arrive at the "Open Folder" button and hit "Enter".
  6. Select the folder created under "Pre-req".
  7. Start screen reader.
  8. Using "Tab" key navigate to and select "New File" option.
  9. Listen if the state announced is correct or not just on navigating through the controls.

Actual: In MAC when screen reader users navigate to the “New file” “New Folder”, etc. button the state as selected is announced which in incorrect as the selected state should be announced when the user activates the button not on navigation.

Expected: The “New File”, “New Folder”, etc. buttons should not be announced with the selected state when screen reader users are navigating through these controls.

Recommendations: Refer below link which is repository of bug fixes code snippets: https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx

User Impact: If the state of the interactive elements are not announced properly to the screen reader users then the users might not know how to interact with them.

MAS Reference: MAS 1.3.1 - https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4}

Attachment for Reference: VSCode_SidebarBarOptions_AccessingTheExplorersidebaroptionsandCreatinganewfile_ScreenReader Incorrect state announced in MAC..pptx

closed time in 6 days

MayuriNaik

issue closedmicrosoft/vscode

A11y_VSCode_SidebarBarOptions_AccessingTheExtensionbaroptions_ScreenReader: On activating any of the extension under “Popular” and “Recommended” the content in the main content get updated but the same is not notified to the screen reader users.

Environment Details: VSCode Version : 1.35.6 (user setup) OS Version : Win10

Additional Details: MAS Violated : MAS 4.1.2 ScreenReader Versions : NVDA2019.1.1, JAWS 2019

Repro Steps:

  1. Open Visual studio code editor.
  2. Using "Ctrl+Shift+X" key navigate to the extension side view bar option.
  3. Using "Tab" key navigate to extension side bar options.
  4. Start screen reader.
  5. Navigate to the available extensions under “Popular” and “Recommended” and activate any one of them.
  6. Content in the main content get updated listen if it is announced to the screen reader users.

Actual: When screen reader users navigate and activate the extensions some content in the main content get updated but the same is not notified to the screen reader users.

Expected: The screen reader user should be notified about the updated content on activating any of the extension.

Recommendations: Refer below link which is repository of bug fixes code snippets: https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx

User Impact: If the screen reader user are not notified about the updated content then the user might not understand what actually happened on activating the extension.

MAS Reference: MAS 1.3.1 - https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4}

Attachment for Reference: VSCode_SidebarBarOptions_AccessingTheExtensionbaroptions_ScreenReader No notification for extension content update.pptx

closed time in 6 days

MayuriNaik

issue closedmicrosoft/vscode

A11y_VSCode_SidebarBarOptions_AccessingTheExtensionbaroptions_ScreenReader: On selecting any of the extension under “Popular” and “Recommended” it’s state is not announced to the users.

Environment Details: VSCode Version : 1.35.6 (user setup) OS Version : Win10

Additional Details: MAS Violated : MAS 4.1.2 ScreenReader Versions : NVDA2019.1.1, JAWS 2019

Repro Steps:

  1. Open Visual studio code editor.
  2. Using "Ctrl+Shift+X" key navigate to the extension side view bar option.
  3. Using "Tab" key navigate to extension side bar options.
  4. Start screen reader.
  5. Navigate to the available extensions under “Popular” and “Recommended” and activate any one of them.
  6. Listen if its state is announced or not.

Actual: When screen reader users navigate and activate the extensions available under “Popular” and “Recommended” the selected state is not announced to the screen reader users.

Expected: When user selects any of the extension the selection state should be announced to the screen reader users.

Recommendations: Refer below link which is repository of bug fixes code snippets: https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx

User Impact: If the selection state of the interactive elements is not announced to the screen reader users then they will not know which element they have selected.

MAS Reference: MAS 1.3.1 - https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4}

Attachment for Reference: VSCode_SidebarBarOptions_AccessingTheExtensionbaroptions_ScreenReader Selection state of the extension is not announced.pptx

closed time in 6 days

MayuriNaik

issue closedmicrosoft/vscode

A11y_VSCode_SidebarBarOptions_AccessingTheDebugsidebaroptions_ScreenReader: Identical names provided for the “Collapse all” buttons for “Variables” and “Watch” toolbar.

Environment Details: VSCode Version : 1.35.6 (user setup) OS Version : MAC OS Mojave, V 10.14.5, Mac Mini Late2012

Additional Details: MAS Violated : MAS 4.1.2 ScreenReader Versions : Voiceover

Repro Steps:

  1. Open Visual studio code editor.
  2. Using "Ctrl+Shift+X" key navigate to the extension side view bar option.
  3. Using "Tab" key navigate to extension side bar options.
  4. Start screen reader.
  5. Navigate to the “Collapse all” buttons for “Variables” and “Watch” toolbar.
  6. Listen to how it is announced.

Actual: If the more than one interactive element is provided with the same name for the controls in two different toolbars then the screen reader users will find it hard in knowing which control is for which section.

Expected: The name provided for each of the controls should be unique so the screen reader users can differentiate the two controls from the two different toolbar.

Recommendations: The “Collapse all” button in “Variables” toolbar should be announced as “Collapse all Variables” and for “Collapse all” button in “Watch” toolbar as “Collapse all Watch”.

Refer below link which is repository of bug fixes code snippets: https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx

User Impact: If the interactive elements are not provided with unique different names then the screen reader users might not be able to differentiate between them.

MAS Reference: MAS 4.1.2 - https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={248054a6-5e68-4771-9e1e-242fb5025730}

Attachment for Reference: VSCode_SidebarBarOptions_AccessingTheDebugsidebaroptions_ScreenReader Identical names for “Collapse all” buttons.pptx

closed time in 6 days

MayuriNaik

issue commentmicrosoft/vscode

A11y_VSCode_SidebarBarOptions_AccessingTheDebugsidebaroptions_ScreenReader: Identical names provided for the “Collapse all” buttons for “Variables” and “Watch” toolbar.

Disagree. We reuse components all over vscode and we announce the same names since they behave the same. The user will know where he is by actually navigating to the neighboring elements. Closing as designed

MayuriNaik

comment created time in 6 days

pull request commentmicrosoft/vscode

search-widget(aria-live) status for results found

@georgebatalinski thank you very much for you PR. I have added comments in the PR which should be addressed. Did you test this works nicely?

@rebornix can you please take this over, since from tommorow I am on a 15 day vacation. I just did an initial review.

georgebatalinski

comment created time in 6 days

Pull request review commentmicrosoft/vscode

search-widget(aria-live) status for results found

 export class FindWidget extends Widget implements IOverlayWidget, IHorizontalSas  		this._matchesCount = document.createElement('div'); 		this._matchesCount.className = 'matchesCount';++		this._matchesCount.setAttribute('role', 'alert');

role: alert and aria-live: assertive should be equivalelnt based on the W3 spec Does it still work if we use only one of these?

georgebatalinski

comment created time in 6 days

Pull request review commentmicrosoft/vscode

search-widget(aria-live) status for results found

 export class FindWidget extends Widget implements IOverlayWidget, IHorizontalSas 		} else { 			label = NLS_NO_RESULTS; 		}-		this._matchesCount.appendChild(document.createTextNode(label));+		let myAlert = document.createElement('div');

Also if we decide this this is need myAlert should be a const not a let

georgebatalinski

comment created time in 6 days

Pull request review commentmicrosoft/vscode

search-widget(aria-live) status for results found

 export class FindWidget extends Widget implements IOverlayWidget, IHorizontalSas 		if (e.searchString || e.matchesCount || e.matchesPosition) { 			let showRedOutline = (this._state.searchString.length > 0 && this._state.matchesCount === 0); 			dom.toggleClass(this._domNode, 'no-results', showRedOutline);

You removed an empty line, and added an empty line. I do not realy see a value in that.

georgebatalinski

comment created time in 6 days

Pull request review commentmicrosoft/vscode

search-widget(aria-live) status for results found

 export class FindWidget extends Widget implements IOverlayWidget, IHorizontalSas 		} else { 			label = NLS_NO_RESULTS; 		}-		this._matchesCount.appendChild(document.createTextNode(label));+		let myAlert = document.createElement('div');

Why do we need to introduce a div element? Can you please explain that.

georgebatalinski

comment created time in 6 days

issue commentmicrosoft/vscode

Accessibility improvements for finding in files

@georgebatalinski thanks! I will comment in the PR directly.

Neurrone

comment created time in 6 days

issue commentmicrosoft/vscode

Screen reader doesn't read TreeItems properly

Fancy 🎉

Caitlin-Hennessy

comment created time in 6 days

issue commentmicrosoft/vscode

[Bug] After v1.37 vscode-exploration, workspace layout is breaking when the window is minimized and then restored

I have no clue what is the issue here. Can you please post reproducable steps? Can you reproduce with vscode insiders https://code.visualstudio.com/insiders/

ddzy

comment created time in 6 days

issue commentmicrosoft/vscode-go

Modal popup on compile-time error.

@ramya-rao-a Well if the debug extension can still launch the debugee I would expect it launches. If it can not I would expect a modal popup with the error information. Though this is just my point of view, you can check what other debug extensinos are doing, this does not sound like something specific only to Go.

jeffhoye

comment created time in 6 days

issue closedmicrosoft/vscode-remote-release

"medium" tab label format not respected on reload when editing remotely

The editor.workbench.labelFormat setting, when set to "medium", is supposed to show the relative path to each open tab's file within the tab, after the file basename (see the docs).

This generally works as promised when using the Remote Development Extension. However, when I reload or reopen a workspace that has open tabs, the "medium" value is not respected, and instead the entire absolute file path is shown in the tab. This is frustrating because I generally don't care about most of the absolute path, and it makes the tabs much bigger than necessary.

I first noticed this when sshing from a Mac into a remote Linux machine, and was able to reproduce it fairly minimally using Docker.

I confirmed that it does not happen when working in local workspaces, so I assume it's a problem with the remote development extension set.

  • VSCode Version: 1.36.0
  • Local OS Version: MacOS 10.14.5
  • Remote OS Version: Ubuntu 18.04.2
  • Remote Extension/Connection Type: Docker (also ssh)

Steps to Reproduce:

  1. docker run -it ubuntu --name vscode-test.
  2. Within the container, run mkdir -p /vscode/a/b/ && echo "test" > /vscode/a/b/c.txt
  3. Run "Remote Containers: Attach to Running Container..." in VS Code and select the "vscode-test" container.
  4. Go to settings and change the workbench.editor.labelFormat setting to "medium".
  5. Select "Open Folder" and open the container's /vscode directory.
  6. Open the a/b/c.txt file in a new tab. The tab should read "c.txt a/b", properly displaying the relative path as expected.
  7. Reload the window.
  8. The c.txt tab will now show the entire absolute path after the filename: "c.txt /vscode/a/b".
  9. If you close and reopen the tab, it goes back to normal. (In practice, it's quite annoying to have to close and reopen every tab whenever I reopen a workspace.)

Steps 5-9 are shown here: vscode-bug

<!-- Check to see if the problem is general, with a specific extension, or only happens when remote --> Does this issue occur when you try this locally?: no Does this issue occur when you try this locally and all extensions are disabled?: no

closed time in 6 days

orn688

issue commentmicrosoft/vscode-remote-release

"medium" tab label format not respected on reload when editing remotely

No problem, closing this then. If it works with Docker it should work with ssh, we use the same underlying components. The quick replace is expacted (just the timing when the extension contributinos its label provider with rules for showing remote uris)

orn688

comment created time in 6 days

issue commentmicrosoft/vscode

Copying a file overwrites the original file with an empty file

@thomas-darling can you please try vscode insiders from Thursday and if you can no longer reproduce this issue then I think we are good and we can close this one? Thanks!

thomas-darling

comment created time in 6 days

issue commentmicrosoft/vscode

Smoke test failure for Debug for 1.36.1

This issue happens when the port 3000 is in use. The smoke test sohuld be smarter and not have 3000 hard coded

dbaeumer

comment created time in 7 days

issue commentmicrosoft/vscode

Copying a file overwrites the original file with an empty file

@bpasero this check [here](https://github.com/Microsoft/vscode/blob/680ce7a9610281ec78dead8a618154772deec85f/src/vs/workbench/contrib/files/browser/fileActions.ts#L1027 should prevent the case that it overwrites, but it adds it as a new child of the parent. With this check here

I mean it can happen that I paste file a over a, but that will lead us to create a a copy

thomas-darling

comment created time in 7 days

PR opened microsoft/vscode

Reviewers
folding: introduce foldingEnabled context

Fixes https://github.com/microsoft/vscode/issues/17257

This pr introduces a context foldingEnabled which is true when folding is enabled, and false otherwise. Now all the folding actions are using this context as a precondition. Which results in the fact that they are not present in the command palette when fodling is disabled. I have tested this and it seems to work nicely.

+20 -12

0 comment

1 changed file

pr created time in 7 days

create barnchmicrosoft/vscode

branch : isidorn/foldingContext

created branch time in 7 days

issue commentmicrosoft/vscode-remote-release

"medium" tab label format not respected on reload when editing remotely

I have pushed a commit which should fix this, a couple of days ago. Can you please try with the latest vscode insiders and let us know if the issue gets really fixed for you https://code.visualstudio.com/insiders/

orn688

comment created time in 7 days

issue commentmicrosoft/vscode

Error creating new file from contextual menu

@manu-chroma Do you see this when being in a no folder vscode (purple status bar)? Do you have better reproducable steps? Can you reproduce with vscode insiders https://code.visualstudio.com/insiders/

manu-chroma

comment created time in 7 days

issue commentmicrosoft/vscode

TypeError: Cannot read property 'isReadonly' of undefined

The other error looks related since the same action calls it, will not tackle until it comes back again. Thanks

bpasero

comment created time in 7 days

push eventmicrosoft/vscode

isidor

commit sha 28e07ec523f8fbdda98123b352416114dce0db62

fixes #76768

view details

push time in 7 days

issue closedmicrosoft/vscode

TypeError: Cannot read property 'isReadonly' of undefined

TypeError: Cannot read property 'isReadonly' of undefined
/vs/workbench/contrib/files/browser/fileActions.ts#851:13
at Generator.next ()
/vs/base/common/errors.ts#184:9

closed time in 7 days

bpasero

issue commentmicrosoft/vscode

Problems in the status bar sometimes appear to the left of Source Control, sometimes to the right

I have verified this is no longer happening thus adding a verified label. However I have discovered this git status bar issue while verifying https://github.com/microsoft/vscode/issues/76949

infinnie

comment created time in 7 days

issue openedmicrosoft/vscode

Git status bar contribution shows status for wrong root

  1. Multi root workspace (for example vscode and vscode-docs)
  2. Click on vscode-docs file -> status bar gets nicely updated to show git status for the vscode-docs repo
  3. Click back on a vscode file -> status bar does not get updated 🐛

I can repro 100%

git

created time in 7 days

issue commentmicrosoft/vscode

Unable to open '%A0.txt': URI malformed

I have verified that I can create, open and edit a file %a0.txt. Thus adding verified label.

daimor

comment created time in 7 days

push eventmicrosoft/vscode

isidor

commit sha e01e4f92ee4819e2c469c22ec4dc0f948113f857

fixes #76767

view details

push time in 7 days

issue closedmicrosoft/vscode

TypeError: Cannot read property 'match' of undefined

TypeError: Cannot read property 'match' of undefined
/vs/workbench/contrib/debug/browser/repl.ts#743:63 (countNumberOfLines)
/vs/workbench/contrib/debug/browser/repl.ts#764:19 (getHeight)
/vs/base/browser/ui/tree/abstractTree.ts#172:23 (getHeight)
/vs/base/browser/ui/tree/abstractTree.ts#172:23 (getHeight)
/vs/base/browser/ui/list/listView.ts#300:30
at Array.map ()
/vs/base/browser/ui/list/listView.ts#296:28 (_splice)
/vs/base/browser/ui/list/listView.ts#276:15 (splice)
/vs/base/browser/ui/list/splice.ts#17:34
at Array.forEach ()
/vs/base/browser/ui/list/splice.ts#17:19 (splice)
/vs/base/browser/ui/list/listWidget.ts#1271:56 (fn)
/vs/base/common/event.ts#778:12 (bufferEvents)
/vs/base/browser/ui/list/listWidget.ts#1271:21 (splice)
/vs/base/browser/ui/tree/abstractTree.ts#1091:8 (splice)
/vs/base/browser/ui/tree/indexTreeModel.ts#161:13
at 

closed time in 7 days

bpasero

issue closedmicrosoft/vscode

The backspace key doesn't work except the editor

Issue Type: <b>Bug</b>

Hello, I can use the backspace key in the editor and the search box,but I can't use it in the debug console or the extension store and other input area.If I open a file before,when I type words in the debug console then press the backspace key,then the code in the editor will be deleted.

VS Code version: Code 1.36.0 (0f3794b38477eea13fb47fbe15a42798e6129338, 2019-07-03T13:25:46.372Z) OS version: Windows_NT x64 10.0.16299

<!-- generated by issue reporter -->

closed time in 7 days

zeromniverse

issue commentmicrosoft/vscode

The backspace key doesn't work except the editor

Ok. Thus closing this. If you want you can identify what extension is the cause and you can file na issue against them. Thanks

zeromniverse

comment created time in 7 days

issue commentmicrosoft/vscode

CTRL+SHIFT+E doesn't work when there is an input in focus

I can not reproduce this on my Ubuntu.

@z0al can you reproduce if you use vscode insiders @joaomoreno do you see this? Not sure how it could be connected to the snap package (probably by accident),

z0al

comment created time in 7 days

issue commentmicrosoft/vscode

Explorer: improved copy/paste into another folder

I have updated that title, and closing this one as a duplicate. Thanks!

anthonyvdotbe

comment created time in 7 days

push eventmicrosoft/vscode

isidor

commit sha 139f7de5039512df925887c1f96d9c80085692fc

implicit any casts

view details

push time in 7 days

issue closedmicrosoft/vscode

Toggle sidebar view shortcut

Issue Type: <b>Feature Request</b>

Can CTL+SHIFT+E shortcut toggle the file explorer view?

VS Code version: Code 1.36.0 (0f3794b38477eea13fb47fbe15a42798e6129338, 2019-07-03T13:25:46.372Z) OS version: Windows_NT x64 6.1.7601

<!-- generated by issue reporter -->

closed time in 7 days

Jeffreyfan

issue commentmicrosoft/vscode

Toggle sidebar view shortcut

Not by default, but you can customise this. Open keyboard shorcuts and add this

{
            "key": "ctrl+shift+e",
            "command": "workbench.action.toggleSidebarVisibility",
            "when": "sideBarVisible"
      }
Jeffreyfan

comment created time in 7 days

issue commentmicrosoft/vscode

Allow multiple instances of the File Explorer

Feature request. We do not plan it for the immedaite future, thus assigning to backlog.

1138-4EB

comment created time in 7 days

issue commentmicrosoft/vscode

Render multi-root workspace folders in multiple views

@1138-4EB sure. I have added that label.

Ratismal

comment created time in 7 days

issue closedmicrosoft/vscode

Delete Button not working in the Editor

The delete button seems not be working the latest release for Linux OS (I am using Ubuntu). When selected a file/folder and pressed the delete key to delete it, it wasn't deleted instead the delete key is working as any Alphabetical key or Numeric keys which when pressed tend to search for the named file/folder.

closed time in 8 days

rajatgyl

issue commentmicrosoft/vscode

Delete Button not working in the Editor

Duplicate. Will be fixed in candidate release out soon.

rajatgyl

comment created time in 8 days

issue closedmicrosoft/vscode

A11y_VSCode_ChangingtheUsersettings_ScreenReader: Screen reader does not announce the ordering of items present in the dropdown list of 'Editor: Accessibility Support' combo box.

Environment Details: VSCode Version : 1.36.1 (user setup) OS Version : MacOS Mojave 10.14.5

Additional Details: MAS Violated : MAS 1.3.1 Screen Reader Versions : Voice over

Repro Steps: 1.Open Visual studio code editor. 2.Open the command Pallet by pressing "F1" key and type "setting". 3.Using down-arrow key select user setting. 4.Type the word "Auto " and select one of the suggestion given by the vs code editor. 5.Type the "Tab size" and select the option from the auto suggestion. 6.Start screen reader

Actual: Screen reader does not announce the ordering that is 'auto 1 of 3' for drop down item of 'Editor: Accessibility Support' combo box.

This issue is observed in Mac + Voice over

Expected: Screen reader should announce the proper ordering that is 'auto 1 of 3' for each drop down item of 'Editor: Accessibility Support' combo box.

Recommendations: Refer below link which is repository of bug fixes code snippets: https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx

User Impact: Screen reader users will not get the exact information.

MAS Reference: MAS 1.3.1 - https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4}

Attachment for Reference: A11y_VSCode_ChangingtheUsersettings_ScreenReader.pptx

closed time in 8 days

bhagwatshelke1047

issue commentmicrosoft/vscode

A11y_VSCode_ChangingtheUsersettings_ScreenReader: Screen reader does not announce the ordering of items present in the dropdown list of 'Editor: Accessibility Support' combo box.

That is the native HTML select box. Just how it behaves. Please file issue against Voice Over that they do not read the item order in the HTML native select box.

bhagwatshelke1047

comment created time in 8 days

issue commentmicrosoft/vscode

Screen reader does not announce the expand state of select box

I acknowledge that the 'expanded' state is not properly read out by the screen reader. We only set the collapsed state, however not the expanded state. We are acceptin PRs that fix this. fyi @cleidigh

Code pointer https://github.com/Microsoft/vscode/blob/2467eab1338d03631cb4e11123b4ded84615aa0e/src/vs/base/browser/ui/selectBox/selectBoxCustom.ts#L83

RohitJadhav-TCS

comment created time in 8 days

issue closedmicrosoft/vscode

A11y_VSCode_ProblemPanel_ScreenReader:Screen reader annoucne the error informatin twice

Environment Details: VSCode Version : 1.36.0 OS Version : Win10 Additional Details: MAS Violated : MAS 1.3.1

Repro Steps:

  1. Open Visual studio code editor
  2. Press ctrl+shift+M
  3. Type something in the editer which must be systactically wrong
  4. Remove the line from editor
  5. Listen the announcement of the screen reader while screen reader annoucne about error message.

Actual: Screen reader announcement the information twice.

Expected: Screen reader should annoucne the infromation about error only once.

Recommendations: Refer below link which is repository of bug fixes code snippets: https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx

User Impact: Screen reader will face difficulty to understand the information.

MAS Reference: MAS 1.3.1 - https://microsoft.sharepoint.com/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4}

Attachment For Reference: A11y_VSCode_Output panel_ScreenReader_NoAnnouncementOfStateOfButton.Mp4 Does this issue occur when all extensions are disabled?: Yes A11y_VSCode_ProblemPanel_ScreenReader_AnnoucnementInformatinTwice.pptx

closed time in 8 days

prasadaps

issue commentmicrosoft/vscode

A11y_VSCode_ProblemPanel_ScreenReader:Screen reader annoucne the error informatin twice

Can not reproduce the issue. You might be using JAWS, which we do not support. Also for errors our default accessibility experience is F8 which navigates through all errors nicely

Screenshot 2019-07-08 at 18 17 29

prasadaps

comment created time in 8 days

issue commentmicrosoft/vscode

Allow to get a handler for the default Explorer TreeView

Unfortunetly there is no workaround. We are not exposing the Explorer via the API.

And sorry it is not possible to programmaticly filter the content in the file explorer. It is simply not exposed and this goes with our API rules. More about our approach can be found here https://code.visualstudio.com/api and in some corresponding docs

1138-4EB

comment created time in 8 days

issue commentmicrosoft/vscode

Allow to get a handler for the default Explorer TreeView

This is a fair feature request, however it is not currently on the plan, thus assigning to backlog.

1138-4EB

comment created time in 8 days

issue closedmicrosoft/vscode

A11y_VSCode_ChangingoftheTheme_ScreenReader: Screen reader does not announce the drop down list items of 'select color theme' combo box after selecting them.

Environment Details: VSCode Version : 1.36.1 (user setup) OS Version : MacOS Mojave 10.14.5

Additional Details: MAS Violated : MAS 1.3.1 Screen Reader Versions : Voice over

Repro Steps: 1.Open Visual studio code editor. 2.Open the command Pallet by pressing "F1" key and type "Theme" 3.Using Down arrow key select "Preference colour Theme" and press enter key to select. 4.Using "Up/Down" arrow key select different available theme. 5.Start screen reader.

Actual: Screen reader does not announce the drop down list item names of select 'colour theme combo box 'after selecting them

This issue is observed in Mac + voice over

Expected: Screen reader should announce the drop down item name after selecting it.

Recommendations: Refer below link which is repository of bug fixes code snippets: https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx

User Impact: Screen reader users will not understand currently which theme is selected.

MAS Reference: MAS 1.3.1 - https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4}

Attachment for Reference: A11y_VSCode_ChangingoftheTheme_ScreenReader.pptx

closed time in 8 days

bhagwatshelke1047

issue commentmicrosoft/vscode

A11y_VSCode_ChangingoftheTheme_ScreenReader: Screen reader does not announce the drop down list items of 'select color theme' combo box after selecting them.

Disagree. We read before choosing the theme, not after. The user is aware of what was selected before he choose it since we announce each choice.

If you disagree with me please provide an example of some MS software which reads both before and after user makes a choice. Thanks Closing as invalid

bhagwatshelke1047

comment created time in 8 days

push eventmicrosoft/vscode

isidor

commit sha 9d023edb6b71095e677fa6b9195ca1aac3cf5960

list: add getRole and isChecked to ariaProvider

view details

isidor

commit sha 6b8667ad8824b18d4b85250361a15d6e9fb9c5bb

breakpoints: contribute getRole and isChecked fixes #52390

view details

isidor

commit sha 2467eab1338d03631cb4e11123b4ded84615aa0e

polish

view details

Isidor Nikolic

commit sha 3ea5c9ddbebd8ec68e3b821f9c39c3ec785fde97

Merge pull request #76726 from microsoft/isidorn/listRole list: add getRole and isChecked to ariaProvider

view details

push time in 8 days

issue closedmicrosoft/vscode

Breakpoint checkboxes have wrong role

Environment Details: VSCode Version : 1.24.0 OS Version : HighSierra10.13.5

Additional Details: MAS Violated: MAS 1.3.1 ScreenReader : VoiceOver

Repro Steps:

  1. Launch VS Code while VoiceOver is ON.
  2. Navigate to Activity Bar and select "View Debug " button.
  3. Navigate to "All Exceptions" and "User Handled Exceptions" checkboxes in "Breakpoints" section.

Actual: Screenreader reads the tick boxes as list boxes. The role of the "All Exceptions" and "User Handled Exceptions" controls is incorrect.

Expected: Screenreader should read the proper role of the controls as tickboxes so that proper action can be performed by the user.

Recommendations: Provide proper role to the "All Exceptions" and "User Handled Exceptions" controls as tick boxes.(checkboxes) or, Refer below link which is repository of bug fixes code snippets: https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx

User Impact: The screenreader users will not be able to know the correct role of the controls to perform appropriate actions on the controls present on the screen.

MAS Reference: MAS 1.3.1 - https://microsoft.sharepoint.com/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4}

Attachment For Reference: A11y_VSCode_ViewDebug_VoiceOver_TickboxAsListBox.pptx

Does this issue occur when all extensions are disabled?: Yes

closed time in 8 days

AccessibilityTestingTeam-TCS

delete branch microsoft/vscode

delete branch : isidorn/listRole

delete time in 8 days

PR merged microsoft/vscode

list: add getRole and isChecked to ariaProvider

This PR does the following:

  • Renames lists IAriaSetProvider to IAriaProvider
  • Adds getRole and isChecked optional methods to the IAriaProvider
  • Contributes the getRole and isChecked for the breakpoints view. Such that the breakpoints are now properly annouched as checkmarks.

I have tested this and all works good on my mac.

+25 -12

1 comment

5 changed files

isidorn

pr closed time in 8 days

pull request commentmicrosoft/vscode

list: add getRole and isChecked to ariaProvider

Thanks for the review.

isidorn

comment created time in 8 days

push eventmicrosoft/vscode

isidor

commit sha 2467eab1338d03631cb4e11123b4ded84615aa0e

polish

view details

push time in 8 days

issue commentmicrosoft/vscode

The backspace key doesn't work except the editor

I can not reproduce this. Also please note that the debug console input is only editable while you are debugging Can you reproduce this with vscode insiders? If yes can you please attach a short video showing this https://code.visualstudio.com/insiders/

zeromniverse

comment created time in 8 days

Pull request review commentmicrosoft/vscode

list: add getRole and isChecked to ariaProvider

 export class ListView<T> implements ISpliceable<T>, IDisposable {  		if (!item.row) { 			item.row = this.cache.alloc(item.templateId);-			item.row!.domNode!.setAttribute('role', 'treeitem');+			const role = this.ariaProvider.getRole ? this.ariaProvider.getRole(item.element) : 'treeitem';+			item.row!.domNode!.setAttribute('role', role);+			const checked = this.ariaProvider.isChecked ? this.ariaProvider.isChecked(item.element) : undefined;+			if (checked !== undefined) {

Ack. I was not aware of the difference thus I found this https://stackoverflow.com/questions/4725603/variable-undefined-vs-typeof-variable-undefined

isidorn

comment created time in 8 days

more