profile
viewpoint
Ilya Shabanov ishaba Luxembourg http://ishaba.ru Aesthetic Estetics!

ishaba/plaxmove 30

jquery parallax plugin

ishaba/angular.io 0

Website for Angular 2

ishaba/emotion 0

⚡️ The Next Generation of CSS-in-JS

ishaba/homedir 0

zshkit, gitconfig, sublime settings, iterm2 colors, etc.

ishaba/ishaba.github.io 0

My personal site

ishaba/preact-material-components 0

preact wrapper for "Material Components for the web"

ishaba/react-native-responsive-styles 0

React Native styles that respond to orientation change

startedpmndrs/valtio

started time in 6 days

fork mattdesl/jmonkeyengine

A complete 3D game development suite written purely in Java.

http://jmonkeyengine.org

fork in 6 days

startedytdl-org/youtube-dl

started time in 7 days

startedPaulMaly/perlite

started time in 7 days

starteddsherret/ts-morph

started time in 7 days

issue commentjobtoday/react-native-image-viewing

Swipe-to-close Issue

This should be supported on Android, other packages are able to accomplish this functionality

exneval

comment created time in 10 days

created repositorymattdesl/yyz

created time in 11 days

fork ai/clean-publish

Removing configuration files and fields in package.json before publishing to npm

https://www.npmjs.com/package/clean-publish

fork in 13 days

issue commentjobtoday/react-native-image-viewing

Loading local images

Don't use the object structure and 'uri':

Ex: const imagesSourceLocal = [ require("./../../../assets/imageSamples/image01.jpg"), ]

OrekuD

comment created time in 13 days

issue commentjobtoday/react-native-image-viewing

custom key for renderItem

Line 56 of the ImageViewing.js keyExtractor={(imageSrc) => imageSrc.uri || `${imageSrc}`} is the culprit. You can get around this by setting it to something else I use a property on my object called name which is a unique filename using a timestamp.

This mainly happens when the url/uri is the same or it is the same file. This causes major inefficiency if using uri of base64 since the keys are compared to each other leading to slower load times. A remedy for this would to allow developers to use custom keyextractors or use a uuid generator.

bougieL

comment created time in 15 days

issue commentjobtoday/react-native-image-viewing

custom key for renderItem

Having the same issuse

bougieL

comment created time in 16 days

fork ai/clean-publish

Removing configuration files and fields in package.json before publishing to npm

https://www.npmjs.com/package/clean-publish

fork in 17 days

startedyewstack/yew

started time in 17 days

startedniklasvh/html2canvas

started time in 17 days

issue openedjobtoday/react-native-image-viewing

Feature request

I needed to disable the close button from animating away for my implementation.

If you could add this feature in the next version it would be nice for me to remove the patch-package patch 👍

In ImageViewing.js i added a new prop , hideCloseOnZoom = true and lower I changed toggleBarsVisible(!isScaled); into toggleBarsVisible(hideCloseOnZoom ? !isScaled : true);

`diff --git a/node_modules/react-native-image-viewing/dist/ImageViewing.js b/node_modules/react-native-image-viewing/dist/ImageViewing.js index 0e69005..49df3cc 100644 --- a/node_modules/react-native-image-viewing/dist/ImageViewing.js +++ b/node_modules/react-native-image-viewing/dist/ImageViewing.js @@ -18,7 +18,7 @@ const DEFAULT_BG_COLOR = "#000"; const DEFAULT_DELAY_LONG_PRESS = 800; const SCREEN = Dimensions.get("screen"); const SCREEN_WIDTH = SCREEN.width; -function ImageViewing({ images, imageIndex, visible, onRequestClose, onLongPress = () => { }, onImageIndexChange, animationType = DEFAULT_ANIMATION_TYPE, backgroundColor = DEFAULT_BG_COLOR, presentationStyle, swipeToCloseEnabled, doubleTapToZoomEnabled, delayLongPress = DEFAULT_DELAY_LONG_PRESS, HeaderComponent, FooterComponent, }) { +function ImageViewing({ images, imageIndex, visible, onRequestClose, onLongPress = () => { }, onImageIndexChange, animationType = DEFAULT_ANIMATION_TYPE, backgroundColor = DEFAULT_BG_COLOR, presentationStyle, swipeToCloseEnabled, doubleTapToZoomEnabled, delayLongPress = DEFAULT_DELAY_LONG_PRESS, HeaderComponent, FooterComponent, hideCloseOnZoom = true }) { const imageList = React.createRef(); const [opacity, onRequestCloseEnhanced] = useRequestClose(onRequestClose); const [currentImageIndex, onScroll] = useImageIndexChange(imageIndex, SCREEN); @@ -32,7 +32,7 @@ function ImageViewing({ images, imageIndex, visible, onRequestClose, onLongPress var _a, _b; // @ts-ignore (_b = (_a = imageList) === null || _a === void 0 ? void 0 : _a.current) === null || _b === void 0 ? void 0 : _b.setNativeProps({ scrollEnabled: !isScaled });

  •    toggleBarsVisible(!isScaled);
    
  •    toggleBarsVisible(hideCloseOnZoom ? !isScaled : true);
    
    }, [imageList]); if (!visible) { return null;`

created time in 21 days

issue commentjobtoday/react-native-image-viewing

Images with authorization header is not working on iOS

I don't think this is maintained anymore

linhpa

comment created time in 22 days

PR opened jobtoday/react-native-image-viewing

Allow to not hide bars on zoom

Allow showing a header or footer for a zoomed image

+28 -13

0 comment

3 changed files

pr created time in 25 days

startedgonzaarcr/touchpad-window-switcher-gnome-ext

started time in 25 days

fork mxstbr/nodejs.dev

A new Node.js resource built using Gatsby.js with React.js, TypeScript, Emotion, and Remark.

https://nodejs.dev

fork in a month

issue openedjobtoday/react-native-image-viewing

Images with authorization header is not working on iOS

I want to display a list of authorized images with bearer token. The component works perfectly on Android but it keeps showing loading indicator with black background on iOS. Btw, local images work well. Anyone faces the same issue? Please help me. Thank you. Simulator Screen Shot - iPhone 11 - 2020-10-23 at 14 17 33

created time in a month

startedpostcss/postcss-deno

started time in a month

startedlogux/state

started time in a month

created repositorylogux/state

Tiny state manager with CRDT, cross-tab, and Logux support

created time in a month

startedposva/pinia

started time in a month

issue openedjobtoday/react-native-image-viewing

How to custom button arrow left - right?

I want custom 2 button next and prev image in lib. How to custom? I tried setState imageIndex, but i have problem image hide and show immediately

created time in a month

issue commentjobtoday/react-native-image-viewing

Black image iOS14

I have the same problem.

schumy

comment created time in a month

more