profile
viewpoint

dekorateio/dekorate 340

Tools for generating Kubernetes related manifests.

iocanel/idee 36

Unified way to perform IDE-like tasks across multiple languages and frameworks in Emacs.

iocanel/emacs.d 11

My emacs setup

iocanel/blog 8

iocanel blog code samples

iocanel/presentations 3

A repository for my presnetations

iocanel/doom.d 2

My Emacs Doom setup

iocanel/java2days-sofia-2019 1

Quarkus deep dive lab for Java2Days 2019

push eventiocanel/advent-of-code

Ioannis Canellos

commit sha 6192757c73ec96d732e49214221842fbcec1816d

fix: link to folder instead of doc file

view details

push time in 4 hours

push eventiocanel/advent-of-code

Ioannis Canellos

commit sha dfa8b0888a05fe508cb07eec09a97456248a6a68

doc: add readmes

view details

push time in 4 hours

push eventiocanel/advent-of-code

Ioannis Canellos

commit sha eb850392fcacdc6ae682af3a749e5755fa4652d1

doc: add readmes

view details

push time in 4 hours

push eventiocanel/advent-of-code

Ioannis Canellos

commit sha 546a218bd37ed06cd6ab82023d35e13dcaca034e

doc: add readmes

view details

push time in 4 hours

push eventiocanel/advent-of-code

Ioannis Canellos

commit sha 365c6d6cd6e766e1dab15999ae615ecce86e828e

solution: day02a

view details

Ioannis Canellos

commit sha d3e8bcf854c214eea5724b8cad97b6423cd9de2f

solution: day02b

view details

push time in 6 hours

push eventiocanel/advent-of-code

Ioannis Canellos

commit sha aa043437f5c207caa2dfe2f2d041d5a7ac77f02a

solution: day01a

view details

Ioannis Canellos

commit sha f427fc87b12f4f0c8a4cfb0b5a3f9047d4f27b04

solution: day01b

view details

Ioannis Canellos

commit sha 79e7cf9d5420fd20f360cababd40706ac33d4d6c

solution: day02a

view details

push time in 6 hours

push eventiocanel/advent-of-code

Ioannis Canellos

commit sha c8b387fcdea2208fae5cb05636272d6a30aecd5d

solution: day01a

view details

Ioannis Canellos

commit sha d3cf3cba34ebe6b64327cfab3102a482af3759a2

solution: day01b

view details

push time in 17 hours

pull request commentquarkusio/quarkus

Update kubernetes-client to support EC keys in native image

I'd like to hear from @manusa and @iocanel about this actually.

I don't recall why this part requires BC. I do recall however, that it was meant to be an optional dependency and the absence of it was meant to be handled gracefully. So, if the particular operation shouldn't be using BC, but it does we should report it upstream.

sberyozkin

comment created time in 18 hours

push eventiocanel/advent-of-code

Ioannis Canellos

commit sha 87dcbab3e53a09e10711c12133bc93cdbfe81ac0

solution: day01a

view details

Ioannis Canellos

commit sha d3e0fdddd8d49b5a0fcb1835066c9d94c72d3dd2

solution: day01b

view details

push time in 19 hours

push eventiocanel/advent-of-code

Ioannis Canellos

commit sha c888e76e89e05ec825bae2767a74cee3c08ab24e

solution: day01a

view details

Ioannis Canellos

commit sha 0147bc4657978e4d8e7b569c9e96b6ae65091d65

solution: day01b

view details

push time in 20 hours

create barnchiocanel/advent-of-code

branch : main

created branch time in 20 hours

created repositoryiocanel/advent-of-code

Advent of Code

created time in 20 hours

pull request commentquarkusio/quarkus

Introduce support for auto-magic service binding

@geoand: given that this PR touches kubernetes and kubernetes service binding a review would be welcome. @maxandersen: as we have discussed about this on zulip in the past, it would be nice if you'd have a look.

iocanel

comment created time in a day

push eventioforks/quarkus

Ioannis Canellos

commit sha b14ad98e61e5bd7c4ff59302332690b5fc494eea

refactor: change the id for default services

view details

push time in a day

push eventioforks/quarkus

Ioannis Canellos

commit sha c60e521bd5f3d75f9d2e7b74c15e559796ef8b40

test: add ServiceBindingProcessorTest

view details

Ioannis Canellos

commit sha f02076068ae9f6c5e729e0cfb514c9d3d209918c

refactor: more descriptive names for Service Binding build items

view details

Ioannis Canellos

commit sha d404315d5b6963d2dbc7ec103ac79965bdf05d98

refactor: change the id for default services

view details

push time in a day

push eventioforks/quarkus

Ioannis Canellos

commit sha 1567a16f4a8dca149bc2568ad15e671fbc0a842e

refactor: more descriptive names for Service Binding build items

view details

Ioannis Canellos

commit sha d1d9bedaa472ff024aaf50b9c5e9a25e8e6c8ff1

refactor: change the id for default services

view details

push time in a day

PullRequestReviewEvent

Pull request review commentsnowdrop/vertx-spring-boot

feat: upgrade to vert.x 4

           <groupId>io.vertx</groupId>           <artifactId>vertx-kafka-client</artifactId>         </exclusion>+        <exclusion>

I was about to say that I would rather solve this via dependencyManagement however, using dependencyManagement with scope seems to be a bit controversial so, let's keep it as is.

jacobdotcosta

comment created time in 2 days

Pull request review commentsnowdrop/vertx-spring-boot

feat: upgrade to vert.x 4

 @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) public class AmqpSampleApplicationTest { +    @Autowired+    ApplicationContext context;+     @Autowired     private WebTestClient client; +    @BeforeEach+    public void setup() {+        this.client = WebTestClient.bindToApplicationContext(this.context).build();

If we are to recreate the client before each step, maybe we shouldn't really use @Autowired on it.

jacobdotcosta

comment created time in 2 days

Pull request review commentsnowdrop/vertx-spring-boot

feat: upgrade to vert.x 4

 @EmbeddedKafka(partitions = 1, ports = { 9092 }) public class KafkaSampleApplicationTest { +    @Autowired+    ApplicationContext context;+     @Autowired     private WebTestClient client; +    @BeforeEach+    public void setup() {+        this.client = WebTestClient.bindToApplicationContext(this.context).build();

Same

jacobdotcosta

comment created time in 2 days

Pull request review commentsnowdrop/vertx-spring-boot

feat: upgrade to vert.x 4

           <groupId>io.vertx</groupId>           <artifactId>vertx-kafka-client</artifactId>         </exclusion>+        <exclusion>

Why do we exclude and explicitly add zookeeper at the same time?

jacobdotcosta

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentsnowdrop/vertx-spring-boot

feat: upgrade to vert.x 4

 @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) public class AmqpSampleApplicationTest { +    @Autowired+    ApplicationContext context;+     @Autowired     private WebTestClient client; +    @BeforeEach+    public void setup() {+        this.client = WebTestClient.bindToApplicationContext(this.context).build();

Same

jacobdotcosta

comment created time in 2 days

PullRequestReviewEvent

issue commentdekorateio/dekorate

Override default K8s annotations at Quarkus

@fotisolgr: The recommended approach for Quarkus is to use the quarkus-kubernetes or quarkus-openshfit extensions. Both of them use dekorate under the hood, but they leverage the Quarkus configuration system and thus config properties are slightly different. This should help: https://quarkus.io/guides/deploying-to-kubernetes

fotisolgr

comment created time in 3 days

pull request commentquarkusio/quarkus

Kubernetes extension - Configurable role policies

Checked the implementation again and it's clearer to me what you are doing with cluster-wide and it's not that much of a problem. Still, I prefer if we can work on a config model that makes things clearer.

I need to look at it a bit closer and think about it

heubeck

comment created time in 3 days

Pull request review commentquarkusio/quarkus

Kubernetes extension - Configurable role policies

+import io.dekorate.utils.Serialization

For the biggest part of the kubernetes extension we use standard tests. We only add invoker tests to test aspects that are specific to build tool (e.g. passing options to the maven build etc).

heubeck

comment created time in 6 days

PullRequestReviewEvent
PullRequestReviewEvent

issue commentquarkusio/quarkus

Provide a useful error message when a user is not logged into an OpenShift cluster

FWIW, the quarkus.openshift.namespace is used to set namespace to the target resources. I am not sure if the deployer takes it into consideration and I am not even sure if it needs to (e.g. I am not sure if we need to do something about it, or if setting the namespace in the resources is enough). Still, the end result should be the same: the app deployed to the specified namesapce.

So, from what I read the action items should be:

  • Display a valid error message if connection to a cluster cannot be established.
  • Display a valid error message if target cluster does not match our needs (e.g. we need openshift but cluster is vanilla).
  • Ensure resources are deployed to the right namespace.

Let me pick this up

mkouba

comment created time in 6 days

more