profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/infinite-persistence/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

lbryio/lbry-desktop 3568

A browser and wallet for LBRY, the decentralized, user-controlled content marketplace.

lbryio/lbry-redux 16

Common shared app components for desktop and mobile

infinite-persistence/lbry-android 0

The LBRY Android app

infinite-persistence/lbry-desktop 0

A browser and wallet for LBRY, the decentralized, user-controlled content marketplace.

infinite-persistence/lbry-redux 0

Common shared app components for desktop and mobile

infinite-persistence/lbry.com 0

lbry.com, the website for the LBRY protocol

issue openedlbryio/lbry-desktop

Automatic tracking of `ui.js` size

The current code-splitting is a manual process, where we have to lazy-import and wrap components with <Suspense> -- something which we don't have a habit of doing yet during development due to time constraints. It also requires lots of testing to ensure if the lazy-load did have an impact, doesn't break, etc.

  • It would be nice if we can track the the size of ui.js during each production build, and review it periodically (something like Grafana?), and update the code-splitting work as necessary.

Or any better ideas?

created time in 2 hours

issue openedlbryio/lbry-desktop

Investigate 10MB increase in ui.js (debug) since July

This translates to a ~1MB increase for production build (uncompressed) since July. See if it's anything bad, or require code-splitting.

created time in 2 hours

pull request commentlbryio/lbry-desktop

Send video bitrate and user bandwidth to Watchman

Don't forget to run lint and the auto-formatter, else it will cause unnecessary deltas for the next person :)

mayeaux

comment created time in 2 hours

pull request commentlbryio/lbry-desktop

Embed: add replay button + msg resizing

#7138 Probably need to revert this.

Hm.. why is that? I thought the reload button will be independent.

infinite-persistence

comment created time in 12 hours

delete branch lbryio/lbry-desktop

delete branch : ip/str

delete time in 17 hours

push eventlbryio/lbry-desktop

infinite-persistence

commit sha fcea4005ebffb151a0a654d55861c9df66fed680

Fix incorrect context for 'New' string

view details

push time in 17 hours

PR opened lbryio/lbry-desktop

Fix incorrect context for 'New' string

Screenshot from 2021-09-21 16-48-42

+6 -1

0 comment

1 changed file

pr created time in 18 hours

create barnchlbryio/lbry-desktop

branch : ip/str

created branch time in 18 hours

push eventlbryio/lbry-desktop

infinite-persistence

commit sha a6991f39acdaf247a98b1b7c48a4ea94a86c3246

Embed

view details

infinite-persistence

commit sha 07ce3f76e0069ce928caeca6ce3ad6de7d8195d0

--- changelog

view details

push time in 18 hours

PR opened lbryio/lbry-desktop

Embed: add replay button + msg resizing

Ticket

Closes #7113 embed improvements for peakprosperity

Changes

  • Added a replace button; replaced "Rewatch and Discuss" to "Discuss /".
  • Make the message font size dynamic based on container height, so that it won't clip.

Screenshot from 2021-09-21 16-19-16

+26 -4

0 comment

3 changed files

pr created time in 18 hours

create barnchlbryio/lbry-desktop

branch : ip/embed.replay

created branch time in 18 hours

issue commentlbryio/lbry-desktop

Odysee / desktop code split or other changes

Jotting some notes and questions here:
https://www.notion.so/lbry/Odysee-Desktop-code-split-or-other-changes-7134-6b119946e52b4c72993cf5cccb098685

kauffj

comment created time in 19 hours

issue openedlbryio/lbry-desktop

Minor cleanup: error when trying to play empty Watch Later

With all items removed from Watch Later, click Play or Shuffle Play

Screenshot from 2021-09-21 14-58-33

created time in 20 hours

Pull request review commentlbryio/lbry-desktop

Stream Key Button

+// @flow+import Button from 'component/button';+import React from 'react';++type Props = {+  snackMessage: ?string,+  doToast: ({ message: string }) => void,+  label?: string,+  primaryButton?: boolean,+  name?: string,+};++export default function CopyableText(props: Props) {+  const { doToast, primaryButton = false } = props;++  function showStreamkey() {+    if (document.getElementById('livestream-key').type === 'password') {+      doToast({ message: __('Showing Stream Key') });+      document.getElementById('livestream-key').setAttribute('type', 'text');+      document.getElementById('streamkey-unmask').style.color = 'white';+      document.getElementById('streamkey-unmask').innerText = 'Hide Stream key';+    } else if (document.getElementById('livestream-key').type === 'text') {+      doToast({ message: __('Hiding Stream Key') });

It is not necessary to show a toast for when hiding and showing the key.

GlobalGamer2015

comment created time in 20 hours

Pull request review commentlbryio/lbry-desktop

Stream Key Button

+// @flow+import Button from 'component/button';+import React from 'react';++type Props = {+  snackMessage: ?string,+  doToast: ({ message: string }) => void,+  label?: string,+  primaryButton?: boolean,+  name?: string,+};++export default function CopyableText(props: Props) {+  const { doToast, primaryButton = false } = props;++  function showStreamkey() {+    if (document.getElementById('livestream-key').type === 'password') {+      doToast({ message: __('Showing Stream Key') });+      document.getElementById('livestream-key').setAttribute('type', 'text');+      document.getElementById('streamkey-unmask').style.color = 'white';+      document.getElementById('streamkey-unmask').innerText = 'Hide Stream key';+    } else if (document.getElementById('livestream-key').type === 'text') {+      doToast({ message: __('Hiding Stream Key') });+      document.getElementById('livestream-key').setAttribute('type', 'password');+      document.getElementById('streamkey-unmask').style.color = 'white';+      document.getElementById('streamkey-unmask').innerText = 'Show Stream key';+    }+  }

It's unnecessary to create a separate Component just for unmask functionality, and it is also not the React-way to tweak the DOM directly for something that React supports through States.

  • The button and the unmasking button can be encapsulated within the new copyableStreamkey itself.
  • Optionally, for an even cleaner solution, we don't have to create copyableStreamkey, but augment the original copyableText to support an optional parameter isPassword (or enableMask or something).
GlobalGamer2015

comment created time in 20 hours

Pull request review commentlbryio/lbry-desktop

Stream Key Button

+// @flow+import Button from 'component/button';+import React from 'react';++type Props = {+  snackMessage: ?string,+  doToast: ({ message: string }) => void,+  label?: string,+  primaryButton?: boolean,+  name?: string,+};++export default function CopyableText(props: Props) {+  const { doToast, primaryButton = false } = props;++  function showStreamkey() {+    if (document.getElementById('livestream-key').type === 'password') {+      doToast({ message: __('Showing Stream Key') });+      document.getElementById('livestream-key').setAttribute('type', 'text');+      document.getElementById('streamkey-unmask').style.color = 'white';+      document.getElementById('streamkey-unmask').innerText = 'Hide Stream key';+    } else if (document.getElementById('livestream-key').type === 'text') {+      doToast({ message: __('Hiding Stream Key') });+      document.getElementById('livestream-key').setAttribute('type', 'password');+      document.getElementById('streamkey-unmask').style.color = 'white';+      document.getElementById('streamkey-unmask').innerText = 'Show Stream key';+    }+  }++  return (+    <Button+      button={primaryButton ? 'primary' : 'secondary'}+      label={__('Show Stream key')}+      id="streamkey-unmask"+      name="streamkey-unmask"+      onClick={() => {+        showStreamkey();+      }}+    />

As mentioned in a prior comment, a separate component is not necessary. On top of that, the button location is not ideal, and there is no gap between components. Here's one suggestion:

Untitled

GlobalGamer2015

comment created time in 20 hours

Pull request review commentlbryio/lbry-desktop

Stream Key Button

+// @flow+import * as ICONS from 'constants/icons';+import { FormField } from 'component/common/form';+import Button from 'component/button';+import React, { useRef } from 'react';++type Props = {+  copyable: string,+  snackMessage: ?string,+  doToast: ({ message: string }) => void,+  label?: string,+  primaryButton?: boolean,+  name?: string,+  onCopy?: (string) => string,+};++export default function CopyableText(props: Props) {

Rename to actual function name for clarity

GlobalGamer2015

comment created time in 20 hours

Pull request review commentlbryio/lbry-desktop

Stream Key Button

 This release includes a breaking change that will reset many of your settings. T - Use local file for publishing - Use local file and html5 for video playback - Misc changes needed to make UI compatible with electron.++## [Stream Key Button] - 2021-09-18++### Added++- Stream Key button++### Fixed++- Stream Key is now hidden.

Please remove this, and add your entry at the top (under "[Unreleased for Desktop] > Added"), using the same format as the other entries.

GlobalGamer2015

comment created time in 20 hours

PullRequestReviewEvent
PullRequestReviewEvent

issue closedlbryio/lbry-desktop

"Most supported" tile broken

#7114 support embed preference broke the "Most supported" tile.

Screenshot from 2021-09-20 21-19-24

closed time in a day

infinite-persistence

issue commentlbryio/lbry-desktop

"Most supported" tile broken

Jessop fixed in 7137

infinite-persistence

comment created time in a day

push eventlbryio/lbry-desktop

infinite-persistence

commit sha be10b6b1465b771fd34ec6563a1fee23d0f49964

--- changelog

view details

push time in a day

pull request commentlbryio/lbry-desktop

Fix moderator data misalignment.

This still does not surface any channel-signing issues. Do we want to do that, or is that rare enough to ignore?

infinite-persistence

comment created time in a day

PR opened lbryio/lbry-desktop

Reviewers
Fix moderator data misalignment.

Issue

Closes #7121 Missing mod block option (large number of moderated channels?)

Notes

It was bad to assume channelSignatures would be the same length as the promise result -- any failure in signing would cause a misalignment.

For my case, an accidentally-merged channel couldn't be signed due to a missing private key. I think it's the same for Drew.

+10 -14

0 comment

1 changed file

pr created time in a day

push eventlbryio/lbry-desktop

infinite-persistence

commit sha a199432b5c47be9c1920874104b889bf1e0425a2

Fix view-count showing up in non-Channel pages ## Issue If you navigated to a Channel Page and returned to the homepage (or any page with ClaimPreview), the view-count is shown because we have that data. ## Fix Instead of passing props around through the long "list" component chain (`ChannelContent -> ClaimListDiscover -> ClaimList -> ClaimPreview`) to indicate whether we should display it , just check the pathname at the lowest component level; I believe eventually we would display it everywhere anyways, so this we'll be the easiest to clean up.

view details

infinite-persistence

commit sha 0fc9cb9e73ef69a1814144899015719d936820cd

Disable adv filters in "Find channels to follow" (#7130) ## Issue 7118 advanced filtering adjustments for channel related context

view details

Alexander Schrier

commit sha eca9b2fcbf8c95e61eb585df236174d5b145d214

Fix theater mode layout on small and medium screens (#7108) * Fix theater mode layout on small and medium screens * Make comments expandable on medium screens

view details

jessopb

commit sha 7303abcda6f30e4a74567cfc187acb84d3dbe986

fix (#7137)

view details

jessopb

commit sha 432c40fb0c867598b5724728243aa4bd3ac51950

embed preferred no end (#7138)

view details

infinite-persistence

commit sha 31523d769aae8ce93cc24555957b801fa6cad146

ClaimPreviewTile: render optimization The `Date` object and blocklist arrays causes unnecessary render since their references are always different in the shallow-compare.

view details

infinite-persistence

commit sha 21b27d68aa46456b21bdaf99d72f6fd2755bea0d

Fix moderator data misalignment. ## Issue Closes 7121 Missing mod block option (large number of moderated channels?) ## Notes It was bad to assume `channelSignatures` would be the same length as the promise result -- any failure in signing would cause a misalignment. For my case, an accidentally-merged channel couldn't be signed due to a missing private key. I think it's the same for Drew.

view details

infinite-persistence

commit sha 31ab38c4e6179d0e7c0c3c8bb492df008ff59c68

Livestream category

view details

infinite-persistence

commit sha ca1196503364e6b4b6c4dd34cd9d1fd23428eb40

--- changelog

view details

push time in a day

create barnchlbryio/lbry-desktop

branch : ip/moderator.fix

created branch time in a day

push eventlbryio/lbry-desktop

infinite-persistence

commit sha 31523d769aae8ce93cc24555957b801fa6cad146

ClaimPreviewTile: render optimization The `Date` object and blocklist arrays causes unnecessary render since their references are always different in the shallow-compare.

view details

push time in a day

delete branch lbryio/lbry-desktop

delete branch : ip/ClaimPreview.render

delete time in a day