profile
viewpoint
Trond B. Krokli illfated Advokatfirmaet Suleiman & Co AS Oslo, Norway https://scolaw.no/medarbeidere/trond-borge-krokli/ Computer support & general IT technician

illfated/aowow 0

Database viewer for TrinityCore based on aowow by @LordJZ, based on the JS-Engine of Wowhead

illfated/Hololens 0

Contains documentation for Hololens

illfated/TrinityCore 0

TrinityCore Open Source MMO Framework (master = 8.3.0.34220, 3.3.5 = 3.3.5a.12340)

illfated/why-I-hate-wow-private-servers 0

Reasons why WoW most of private servers sucks

illfated/windows-itpro-docs 0

This is used for contributions to the Windows 10 content for IT professionals on docs.microsoft.com.

illfated/windowsserverdocs 0

Public content repository for Windows Server 2016 content.

PullRequestReviewEvent

pull request commentMicrosoftDocs/windows-itpro-docs

Corrected grammar and misleading information

Practical information: if you add a single line, saying "Closes #8431" to the bottom of your main PR comment, your issue ticket will automatically be closed when this PR gets merged. Example text:

Closes #8431

poortom1004

comment created time in 2 hours

issue openedTrinityCore/TrinityCore

DB/Creature: Gelkis clan centaur Yor <UNUSED> spawned

<!--- () (** Fill in the following fields **) () (you can delete all rows before description and after operating system when creating issue) For SQL fixes: don't modify WDB fields without supply one sniff of those fields (censure guids, character names, anything blizzard can use to identify source) don't use pull requests for sql only fixes, unless it's to fix one existing unable to apply file. don't hardcode guids. don't DELETE + INSERT to update only few fields of one row. don't use database names. don't put ' around numbers. don't put ( ) if they aren't needed. use only 1 DELETE + INSERT when we add multiple items to one table, unless you are scripting multiple creatures. put default values on every new column we want to add on that way we can make smallers inserts. start fix by -- in case some previous sql misses proper ending. DELETE by guid AND entry to be sure we don't delete existing spawns. start sql code with 3 ` sql --->

Description:

  • https://wow.gamepedia.com/Yor_(centaur) <sub>(The subject of this article or section did not make it out of the beta stages of World of Warcraft.)</sub>
  • https://www.wowhead.com/npc=10237/yor
SELECT * FROM `creature` WHERE `ID` IN (SELECT `entry` FROM `creature_template` WHERE `name` LIKE "%unused%");
 guid      id     map  zoneId  areaId  spawnMask  phaseMask  modelid  equipment_id  position_x  position_y  position_z  orientation  spawntimesecs  wander_distance  currentwaypoint  curhealth  curmana  MovementType  npcflag  unit_flags  dynamicflags  ScriptName  VerifiedBuild
-----  ------  ------  ------  ------  ---------  ---------  -------  ------------  ----------  ----------  ----------  -----------  -------------  ---------------  ---------------  ---------  -------  ------------  -------  ----------  ------------  ----------  -------------
74142   10237       1       0       0          1          1        0             0    -2233.71     2662.24     60.8624     0.230543          72000                8                0          0        0             1        0           0             0                        0

The Gelkis Clan Centaur NPC Yor <UNUSED> is spawned, even though most sources say this NPC is a beta appearance. The NPC does not appear to be a valid spawn.

Could this be a result from someone thinking that this NPC had anything to do with Stillpine Ancestor Yor (entry 17393)? (pure speculation from my side)

Expected behaviour:

The NPC should not be spawned in-game, based on 1. the name part <UNUSED> and 2. the pages saying it is not a static spawn or a beta feature.

Steps to reproduce the problem:

  1. .go creature id 10237 to watch the name display in-game
  2. Verify the spawn in DB:
    SELECT * FROM `creature` WHERE `ID` IN (SELECT `entry` FROM `creature_template` WHERE `name` LIKE "%unused%");
    
  3. Check the content of the web pages for Yor (entry 10237) to see if you can find verifiable info that this NPC should be in-game.

Branch(es):

3.3.5 (I don't know the status for the master branch DB)

TC rev. hash/commit:

TrinityCore rev. a183ca5bf5c4 2020-10-20 02:04:01 +0300 (3.3.5 branch) (Win64, Release, Static) Using SSL version: OpenSSL 1.1.1g 21 Apr 2020 (library: OpenSSL 1.1.1g 21 Apr 2020) Using Boost version: 1.73.0 Using MySQL version: 50731 Using CMake version: 3.18.3 Compiled on: Windows 10.0.19041 Automatic database updates are enabled for the following databases: Auth, Characters, World Worldserver listening connections on port 8085 Realmlist (Realm Id: 1) configured in port 8085 VMAPs status: Enabled. LineOfSight: 1, getHeight: 1, indoorCheck: 1 MMAPs status: Enabled maps directory located in ./maps. Total size: 251987687 bytes vmaps directory located in ./vmaps. Total size: 658130721 bytes mmaps directory located in ./mmaps. Total size: 1962379500 bytes Using enUS DBC Locale as default. All available DBC locales: enUS Using World DB: TDB 335.20101

Operating system: CHANGEME OS

<!--- Notes

  • This template is for problem reports. For other types of report, edit it accordingly.
  • For fixes containing C++ changes, create a Pull Request. --->

created time in 3 hours

issue commentMicrosoftDocs/windowsserverdocs

Summary image incorrect

@Deland-Han : Would you be able to confirm if the image in

  • https://docs.microsoft.com/en-us/windows-server/storage/file-server/troubleshoot/detect-enable-and-disable-smbv1-v2-v3#summary-1

uses an incorrect line referring to \HKEY_LOCAL_MACHINE\SYSTEM\ControlSet001\Services\LanmanWorkstation whereas \HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\LanmanWorkstation usually contains identical information?

Maybe this issue is cosmetic and superficial, but I thought I should ask someone who works with this material on a daily basis, just to get feedback on the ticket question above.

mattwoolnough

comment created time in 4 hours

issue commentMicrosoftDocs/windowsserverdocs

sc.exe FAILED 1059 - Circular service dependency

#please-close

edgecase14

comment created time in 4 hours

issue commentMicrosoftDocs/windowsserverdocs

bowser

#please-close

Curtmcgirt

comment created time in 4 hours

delete branch illfated/windowsserverdocs

delete branch : revert-4927-patch-2

delete time in 4 hours

pull request commentMicrosoftDocs/windowsserverdocs

"browser" to replace "bowser" in the disable SMB1 via GPP section

Please see my PR to revert this change.

chadduffey

comment created time in 4 hours

PR opened MicrosoftDocs/windowsserverdocs

Revert ""browser" to replace "bowser" in the disable SMB1 via GPP section"

Reverts MicrosoftDocs/windowsserverdocs#4927

"bowser" is the actual name of the SMB1 service.

+2 -2

0 comment

1 changed file

pr created time in 4 hours

create barnchillfated/windowsserverdocs

branch : revert-4927-patch-2

created branch time in 4 hours

pull request commentMicrosoftDocs/windowsserverdocs

"browser" to replace "bowser" in the disable SMB1 via GPP section

@chadduffey : Have you actually researched this subject? Because I have seen several of these attempts to change the name bowser to "browser" without any real research done beforehand. See some of these search results:

  • https://www.bing.com/search?q=Microsoft+%22bowser%22+SMB1+name+site%3Amicrosoft.com
  • https://github.com/MicrosoftDocs/windowsserverdocs/search?q=bowser+is%3Aissue&type=Issues
  • https://github.com/MicrosoftDocs/windowsserverdocs/search?q=bowser&type=code

If you imply that the word "bowser" is not correct, you need to go back to Windows NT and change things 20 years ago.

chadduffey

comment created time in 4 hours

PullRequestReviewEvent

issue commentMicrosoftDocs/windowsserverdocs

SPN: host or http

Not sure if I understand your issue completely, but have you browsed other sites to see if your problem has been discussed already?

Example:

  • https://social.technet.microsoft.com/Forums/ie/en-US/c51a4b53-80b3-4992-96a0-650e7dfec83b/adfs-configuration-wizard-the-spn-required-for-this-federation-service-is-already-set-on-another?forum=ADFS
aferrillo

comment created time in 6 hours

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

issue commentTrinityCore/TrinityCore

Core/Creature: Temporal(scripted) emote/stand states are not restored after reaching home

Thank you for the clarification. Also, a minor word of advice regarding "temporal" versus 'temporary':

  • https://en.wikipedia.org/wiki/Temporal
  • https://en.wikipedia.org/wiki/Temporary
offl

comment created time in 6 hours

push eventillfated/TrinityCore

funjoker

commit sha c72444c793b7d5773ba528c7cfd93674a44cd96e

DB: 35662 deDE bruteforce

view details

funjoker

commit sha 97e6b5e14fd1d1f77afd56f3f98d5899fa1d5849

DB/Hotfix: Correct primary key in previous sql

view details

funjoker

commit sha 3be4ae5613c84cbba895dbc6319dc7d0039aff0c

DB: 35662 esES bruteforce

view details

funjoker

commit sha cee34a5b13e668581457c81550c4d594305336e6

DB: 35662 esMX bruteforce

view details

funjoker

commit sha 02dad38aa3642988fab8dd1ed7366eb57b104002

DB: 35662 frFR bruteforce

view details

funjoker

commit sha 07d069164735ddd6f6a68c763086acf24bcaa988

DB: 35662 itIT bruteforce

view details

funjoker

commit sha 92208c29d9e3670daf82f75624a79f5c3c23f722

DB: 35662 koKR bruteforce

view details

funjoker

commit sha 140b8cd40ec572e05103335368a09dcdfc2c658d

DB: 35662 ptBR bruteforce

view details

funjoker

commit sha 72f0e9c83a371c26e8b91296f4cb402d1bce6730

DB: 35662 zhCN bruteforce

view details

funjoker

commit sha f01a8f47ac0d8c5458cece9bf090a884db4fe2b7

DB: 35662 zhTW bruteforce

view details

funjoker

commit sha 6fd2b0988cfc779f882b27e98afc15d65a2bda83

DB/Hotfixes: Update base hotfixes to final 35662

view details

funjoker

commit sha f3a09ff11ccd6634320749aac0ad4b99672baed2

DB/Hotfixes: Update deDE hotfixes to final 35662

view details

push time in 8 hours

push eventillfated/TrinityCore

offl

commit sha 0fedd2917f2bdc76aae40e234e029e70d10c6f87

DB/Instance/Gundrak: Update certain scripts, waypoints. Misc fixes

view details

offl

commit sha e3af6c04a46965c294007c5633e1aa6ae4ac772f

DB/Creature: Remove waypoints from members of some formations (Sethekk Halls + Mana Tombs)

view details

Keader

commit sha 5e9a856ad797087e24eb13999f39016dcd3f770c

Game/Player: Fixed Backlash/Backdraft priority (#25564) Update #18516

view details

Keader

commit sha 9f739ceba003506894a40bf7428a33f14ab15b11

sql update

view details

offl

commit sha ea65cf7712a73d97592945b82003b38912655bba

DB/Instance/Vault of Archavon: Update stats

view details

offl

commit sha af39c21e72089a08a065b45b9e68b325b6ce57ad

DB/Creature: Rework Archmage Vargoth's gossip menu handling & add outro event for 'Ar'kelos the Guardian'

view details

offl

commit sha 4df7b2d34b50c8aadd0c980bac3bbd326205c771

DB/Creature: Update Ar'kelos' script, auras & speed

view details

offl

commit sha d47fdeb78283b0fb7c982c2803d4709f7b4a8991

DB/Creature: Update Arcane Vortex's auras & stats & add two missing spawns

view details

offl

commit sha ed3d9b69dda0c58b1079b74db6759934a905f9e0

DB/Creature: Add two missing Steam Cloud

view details

offl

commit sha a183ca5bf5c424c4ac0940542a5b0942f242fb2e

DB/Creature: Remove static spawn of Farahlon Crumbler Summoned by spells only

view details

push time in 9 hours

Pull request review commentMicrosoftDocs/windows-itpro-docs

added intelligence to the sentence

 See the following for more information and allowed parameters:   

2 blank lines after the last text should be enough. I suggest we remove these lines as well.

RAJU2529

comment created time in 9 hours

PullRequestReviewEvent

pull request commentMicrosoftDocs/windows-itpro-docs

BitLocker recovery guide: format & spacing edits

#sign-off

illfated

comment created time in 9 hours

issue commentTrinityCore/TrinityCore

Core/Creature: Temporal(scripted) emote/stand states are not restored after reaching home

Sorry, my mind is a bit slow to see the defined extent of this unwanted behaviour. Is this specific to waypoint path, or does it happen to non-waypoint creatures as well?

offl

comment created time in 9 hours

pull request commentMicrosoftDocs/windows-itpro-docs

added intelligence to the sentence

Thank you for the chuckle I got from reading this PR title out of context. To me, it literally seemed to say "This sentence needs more intelligence." 😄 (Not to mention that it apparently needed more cowbell too... 😉 🤣 ;)

RAJU2529

comment created time in 13 hours

Pull request review commentMicrosoftDocs/windows-itpro-docs

added intelligence to the sentence

 You can also randomize the times when each endpoint checks and downloads protect  4.  Click **Policies** then **Administrative templates**. -5.  Expand the tree to **Windows components > Microsoft Defender Antivirus > Signature Updates** and configure the following settings:+5.  Expand the tree to **Windows components > Microsoft Defender Antivirus > Signature Intelligence Updates** and configure the following settings: -    1.  Double-click the **Specify the interval to check for security intelligence updates** setting and set the option to **Enabled**. Enter the number of hours between updates. Click **OK**.-    2. Double-click the **Specify the day of the week to check for security intelligence updates** setting and set the option to **Enabled**. Enter the day of the week to check for updates. Click **OK**.+    1. Double-click the **Specify the day of the week to check for security intelligence updates** setting and set the option to **Enabled**. Enter the day of the week to check for updates. Click **OK**.+    2. Double-click the **Specify the interval to check for security intelligence updates** setting and set the option to **Enabled**. Enter the number of hours between updates. Click **OK**.  

Sorry, just a very minor nitpick: whitespace removal

    2. Double-click the **Specify the interval to check for security intelligence updates** setting and set the option to **Enabled**. Enter the number of hours between updates. Click **OK**.
RAJU2529

comment created time in 13 hours

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentMicrosoftDocs/windows-itpro-docs

BitLocker recovery guide: format & spacing edits

Thank you very much for going through the text in detail. I must have been skimming the text way too superficially on my own.

illfated

comment created time in 14 hours

push eventillfated/windows-itpro-docs

Trond B. Krokli

commit sha bb9b6d8c41655437c2c0250df483f54ca120161d

Copy edit Word partitioning and missing particle/article "the". Co-authored-by: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>

view details

push time in 14 hours

push eventillfated/windows-itpro-docs

Trond B. Krokli

commit sha b17923a18bac778b43abd7b15764bf149cca84f4

Copy edit Add missing word in text added by previous author. Co-authored-by: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>

view details

push time in 14 hours

push eventillfated/windows-itpro-docs

Trond B. Krokli

commit sha 415d0b866f83ce670d4882a305a71ed1d99e705c

Copy edit Add missing period dot at end of sentence. Co-authored-by: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>

view details

push time in 14 hours

push eventillfated/windows-itpro-docs

Trond B. Krokli

commit sha 0027320431f4aa6429462242dcd016e912bb86c4

copy edit Overlooked typo/redundant word Co-authored-by: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>

view details

push time in 14 hours

PullRequestReviewEvent

issue commentMicrosoftDocs/windowsserverdocs

CA Configuration for non-domain joined computers

😄 👍 Very good, thank you for pointing out that important detail.

Do you have a suggestion for improvement, like an improved phrasing or rewrite of the section in question, so we may resolve the issue for good this time?

csando

comment created time in a day

Pull request review commentMicrosoftDocs/windows-itpro-docs

Published recommended driver block rules from HVCI/10S blocklist

+---+title: Microsoft recommended driver block rules (Windows 10)+description: View a list of recommended block rules to block vulnerable third party drivers discovered by Mirosoft and the security research community.  +keywords:  security, malware, kernel mode, driver+ms.assetid: 8d6e0474-c475-411b-b095-1c61adb2bdbb+ms.prod: w10+ms.mktglfcycl: deploy+ms.sitesec: library+ms.pagetype: security+ms.localizationpriority: medium+audience: ITPro+ms.collection: M365-security-compliance+author: jogeurte+ms.reviewer: isbrahm+ms.author: dansimp+manager: dansimp+ms.date: 10/15/2020+---++# Microsoft recommended driver block rules++**Applies to:**++- Windows 10+- Windows Server 2016 and above++Microsoft has strict requirements for code running in kernel. Consequently, malicious actors are turning to exploit vulnerabilities in legitimate and signed kernel drivers to run malware in kernel. One of the many strengths of the Windows platform is our strong collaboration with independent hardware vendors (IHVs) and OEMs. Mirosoft works closely with our IHVs and security community to ensure the highest level of driver security for our customers and when vulnerabilities in drivers do arise, that they are patched and rolled out to the ecosystem in an expedited manner. Microsoft then adds the vulnerable versions of the drivers to our ecosystem block policy which is applied to the following sets of devices: ++- Hypervisor-protected code integrity (HVCI) enabled devices +- Windows 10S mode devices++Microsoft recommends enabling [HVCI](https://docs.microsoft.com/en-us/windows/security/threat-protection/device-guard/enable-virtualization-based-protection-of-code-integrity) or Windows 10S mode to protect your devices against security threats. If this is not possible, Microsoft recommends blocking the following list of drivers by merging this policy with your existing Windows Defender Application Control policy. Blocking kernel drivers without sufficient testing can result in devices or software to malfunction, and in rare cases, blue screen. It is recommended to first validate this policy in [audit mode](audit-windows-defender-application-control-policies.md) and review the audit block events.+++> [!Note]+> This application list will be updated with the latest vendor information as application vulnerabilities are resolved and new issues are discovered. It is recommended that this policy be first validated in audit mode before rolling the rules into enforcement mode. ++

Redundant blank line, I believe 2 blank lines should be sufficient spacing:

jgeurten

comment created time in a day

PullRequestReviewEvent

pull request commentTrinityCore/TrinityCore

Game/Player: Fixed Backlash/Backdraft priority

Good job, Keader. If you don't mind, I would like to nitpick on a word form you seem to have developed when filling in the PR posts:

Tests performed: builded and tested in game

I recommend using "built and tested in-game", because that is more like standard English (just in case you would like to build and maintain a coherent phrasing for the future). 😉

Keader

comment created time in a day

issue commentwebyog/sqlyog-community

"Copy table..." disabled with read only user

Even though I am not part of the SQLyog team or affiliated in any way (not even an advanced user of SQLyog), I would like to comment based on my previous experiences with GitHub tickets in general.

From what I can tell based on my personal experience, it is usually preferred to post questions in the forum pages instead of a ticket here in this repository. You may want to wait for a reply from the webyog team to see what they recommend doing in your case.

mclaborn

comment created time in a day

pull request commentMicrosoftDocs/windowsserverdocs

ADDS/Azure CLI: Configure DNS & second DC promo

Thank you for the extra information. I was unaware of this change and will now do my best to avoid using the "sign-off" comment unless requested to do so.

illfated

comment created time in a day

pull request commentMicrosoftDocs/windows-itpro-docs

Update credential-guard-requirements.md

I have reduced this PR to only handle missing MarkDown indent marker compatibility spacing. Please use PR #8435 to correct the page title section where the question about Windows 10 versions is handled.

illfated

comment created time in a day

push eventillfated/windows-itpro-docs

Trond B. Krokli

commit sha 8f2c0fe56cd6f668ccd5ea9bbb1b06e3a263b412

Update windows/security/identity-protection/credential-guard/credential-guard-requirements.md Another unneeded blank line added during merge of branch 'public' into PR branch. Line removed.

view details

push time in a day

Pull request review commentMicrosoftDocs/windows-itpro-docs

Credential Guard: Enterprise & Education SKU

 For information about Windows Defender Remote Credential Guard hardware and soft  When Windows Defender Credential Guard is enabled, specific authentication capabilities are blocked, so applications that require such capabilities will break. Applications should be tested prior to deployment to ensure compatibility with the reduced functionality. ->[!WARNING]+

Remove unneeded blank line:

illfated

comment created time in a day

PullRequestReviewEvent

push eventillfated/windows-itpro-docs

Trond B. Krokli

commit sha d09202414096f80cbd1364fccc5d8c1626912c66

Update windows/security/identity-protection/credential-guard/credential-guard-requirements.md Unneeded blank line added during resolve of file conflict, line removed.

view details

push time in a day

Pull request review commentMicrosoftDocs/windows-itpro-docs

Credential Guard: Enterprise & Education SKU

 ms.reviewer:  # Windows Defender Credential Guard: Requirements +

Remove unneeded blank line:

illfated

comment created time in a day

PullRequestReviewEvent

push eventillfated/windows-itpro-docs

Marty Hernandez Avedon

commit sha 935da0cab817be752421fae427198c454f7d0f1b

matching structure of page w mtp version

view details

Marty Hernandez Avedon

commit sha 729662d01c945932df92c0e00c93c7bd8aaeb73d

added link to sync with mtp version of page

view details

Marty Hernandez Avedon

commit sha 5634415d8518ef962a12253a9d6351d14eedc695

added details on gui to sync w mtp version

view details

Marty Hernandez Avedon

commit sha 9ca73b9629fd59f59300d5f00f8d9d7910810c02

added missing links to sync with mtp version of page

view details

Marty Hernandez Avedon

commit sha fd5f4dfaf6188b04ab5800821f156f6c38809353

making link lists more consistent

view details

Marty Hernandez Avedon

commit sha 92beced4d2eb2ea2138de0b486e70283fad66460

added content wholesale from mtp version of best practices

view details

Marty Hernandez Avedon

commit sha de14f98b3255184a699341c44468f650663efe58

added take-actions.md

view details

Marty Hernandez Avedon

commit sha a53c16790e6b829bee9323a472b5391352e49f6d

added extend-data.md

view details

Marty Hernandez Avedon

commit sha 7244f328afef7f3ca6b960d552f34eaa7bc994c5

added function page assignedipaddress

view details

Marty Hernandez Avedon

commit sha 3a46478e468b4b1ba5c1091cacd98b2cfc287a14

added function page fileprofile

view details

schmurky

commit sha fb844b70ab342742e22f7bc7cd203354e1473a84

New firewall best practices page

view details

schmurky

commit sha 56a0c2d27b644c706537689f7258b4c9acd47e83

Update fwall best practices

view details

ImranHabib

commit sha d7f6d7a4ea5a87d31f1815b441d9d796f6e17304

Minor Changes As suggested by the user, I made a few changes to reflect the document more clear and easy to understand. Problem: https://github.com/MicrosoftDocs/windows-itpro-docs/issues/7965

view details

ImranHabib

commit sha cbda416a4b9ecbaea84e38c832775c9ad5529102

Update windows/client-management/connect-to-remote-aadj-pc.md Co-authored-by: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>

view details

MaratMussabekov

commit sha d23fab13bd66bf60a0fb7b5f598a0f2a14be7b62

Update mac-sysext-policies.md

view details

schmurky

commit sha f40e25b7673f8585034dace15d700149f15b5172

Merge branch 'master' into macky-fwbestpractices

view details

schmurky

commit sha d5634c5a702ac92a1428aa88a5aedf957a49b231

Edit best practices doc for fw

view details

schmurky

commit sha 7ab0f90fa09aa252f78ad28891f44173e804c499

Update best practices

view details

VLG17

commit sha 7da8a4741a778ed2f1379b15584e349929eb8366

update description for 0xC000006E https://github.com/MicrosoftDocs/windows-itpro-docs/issues/8219

view details

schmurky

commit sha 80301cd201c34b9ce93b03ebc123a12650a932fa

Update best practices doc

view details

push time in a day

pull request commentMicrosoftDocs/windows-itpro-docs

Credential Guard: Enterprise & Education SKU

Sure thing. Thank you for posting and mentioning the issue. Will fix.

illfated

comment created time in a day

issue commentMicrosoftDocs/windows-itpro-docs

MDATP Evaluation Lab permissions

Very well. I would like to take this small opportunity to explain why your URL did not show up as a link in your main post. Here on GitHub, the URLs do not need to be enclosed in brackets to show up as clickable links, you simply post them as they are (use the Preview feature of a post to see when any URL can be read as a clickable link). I don't know whether you are going to use GitHub for other purposes than posting issues you find, but it may come in handy to read about Git Flavored MarkDown (GFM) to see what you can do when editing a post or comment to add practical code blocks or URLs when adding content examples and references.

dismembered3po

comment created time in a day

issue commentMicrosoftDocs/windows-itpro-docs

Setting update

Just to point out visually which section this is:

  • https://docs.microsoft.com/en-us/windows/security/threat-protection/microsoft-defender-atp/onboarding-endpoint-manager#endpoint-detection-and-response

  1. Select settings as required, then select Next.

    Image of Microsoft Endpoint Manager portal

    [!NOTE] In this instance, this has been auto populated as Microsoft Defender ATP has already been integrated with Intune. For more information on the integration, see Enable Microsoft Defender ATP in Intune. <br>

    Image of Microsoft Endpoint Manager portal

Jlouden9

comment created time in 2 days

Pull request review commentTrinityCore/TrinityCore

Game/Player: Fixed Backlash/Backdraft priority

 void Player::ApplySpellMod(uint32 spellId, SpellModOp op, T& basevalue, Spell* s                 // special case (skip > 10sec spell casts for instant cast setting)                 if (op == SPELLMOD_CASTING_TIME && mod->value <= -100 && basevalue >= T(10000))                     return;+                else if (!Player::HasSpellModApplied(mod, spell))+                {+                    // special case for Surge of Light, don't apply critical chance reduction if other mods not applied (ie procs while casting another spell)+                    // (Surge of Light is the only PCT_MOD on critical chance)+                    if (op == SPELLMOD_CRITICAL_CHANCE)+                        return;+                    // special case for Backdraft, dont' apply GCD reduction if cast time reduction wasn't applied (ie when Backlash is consumed first)

Perhaps even a full edit, for all the details:

                    // Special case for Backdraft: do not apply GCD reduction if cast time reduction was not applied (i.e. when Backlash is consumed first).
Keader

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentTrinityCore/TrinityCore

Core/WorldQuest: Add BFA World Quests system

+/*+ * Copyright (C) 2008-2020 TrinityCore <http://www.trinitycore.org/>+ *+ * This program is free software; you can redistribute it and/or modify it+ * under the terms of the GNU General Public License as published by the+ * Free Software Foundation; either version 2 of the License, or (at your+ * option) any later version.+ *+ * This program is distributed in the hope that it will be useful, but WITHOUT+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for+ * more details.+ *+ * You should have received a copy of the GNU General Public License along+ * with this program. If not, see <http://www.gnu.org/licenses/>.+ */++#include "WorldQuestMgr.h"+#include "ObjectMgr.h"+#include "AchievementMgr.h"+#include "DatabaseEnv.h"+#include "QuestObjectiveCriteriaMgr.h"+#include "Log.h"+#include "Containers.h"+#include "GridNotifiersImpl.h"++WorldQuestMgr::WorldQuestMgr()+{+}++WorldQuestMgr::~WorldQuestMgr()+{+    CleanWorldQuestTemplates();+}++void WorldQuestMgr::CleanWorldQuestTemplates()+{+    std::set<WorldQuestTemplate*> toDeleteTemplates;+    std::set<ActiveWorldQuest*> toDeleteActiveTemplates;++    for (auto expansionTemplates : _worldQuestTemplates)+        for (auto teamTemplates : expansionTemplates.second)+            for (auto itr : teamTemplates.second)+                toDeleteTemplates.insert(itr.second);++    for (auto expansionEmissaryTemplates : _emissaryWorldQuestTemplates)+        for (auto teamEmissaryTemplates : expansionEmissaryTemplates.second)+            for (auto itr : teamEmissaryTemplates.second)+                toDeleteTemplates.insert(itr.second);++    for (auto expansionWorldQuests : _activeWorldQuests)+        for (auto teamWorldQuest : expansionWorldQuests.second)+            for (auto activeWorldQuest : teamWorldQuest.second)+                toDeleteActiveTemplates.insert(activeWorldQuest.second);++    for (auto worldQuest : toDeleteTemplates)+        delete worldQuest;++    for (auto activeWorldQuest : toDeleteActiveTemplates)+        delete activeWorldQuest;++    _worldQuestTemplates.clear();+    _emissaryWorldQuestTemplates.clear();+    _activeWorldQuests.clear();+}++WorldQuestMgr* WorldQuestMgr::instance()+{+    static WorldQuestMgr instance;+    return &instance;+}++void WorldQuestMgr::LoadWorldQuestTemplates()+{+    CleanWorldQuestTemplates();++    QueryResult result = WorldDatabase.Query("SELECT id, duration, variable, value FROM world_quest");+    if (!result)+        return;++    do+    {+        Field* fields       = result->Fetch();+        uint32 questId      = fields[0].GetUInt32();+        Quest const* quest  = sObjectMgr->GetQuestTemplate(questId);++        if (!quest)+        {+            TC_LOG_ERROR("server.loading", "World Quest: %u exist but no quest template found. Skip.", questId);+            continue;+        }++        WorldQuestTemplate* worldQuestTemplate = new WorldQuestTemplate(questId, fields[1].GetUInt32(), fields[2].GetUInt32(), fields[3].GetUInt8());+        AddWorldQuestTemplate(quest, worldQuestTemplate);++    } while (result->NextRow());++    WorldQuestContainer worldQuests = sObjectMgr->GetWorldQuestStore();+    for (auto quests : worldQuests)+    {+        for (uint32 questId : quests.second)+        {+            if (Quest const* quest = sObjectMgr->GetQuestTemplate(questId))+            {+                auto itr = _worldQuestTemplates[quest->GetExpansion()].find(questId);+                if (itr == _worldQuestTemplates[quest->GetExpansion()].end())+                {+                    WorldQuestTemplate* worldQuestTemplate = new WorldQuestTemplate(questId, 7200, 12506, 1);+                    AddWorldQuestTemplate(quest, worldQuestTemplate);+                }+            }+        }+    }++    if (_emissaryWorldQuestTemplates.size() < WORLD_QUEST_EMISSARY)+        TC_LOG_ERROR("server.loading", "World Quest: There is %lu emissary quests but %u needed...", _emissaryWorldQuestTemplates.size(), uint32(WORLD_QUEST_EMISSARY));+}++void WorldQuestMgr::AddWorldQuestTemplate(Quest const* quest, WorldQuestTemplate* worldQuestTemplate)+{+    uint8 questTeamId = GetQuestTeamId(quest);+    uint32 questId = quest->GetQuestId();+    int32 questExpansion = quest->GetExpansion();++    switch (questTeamId)+    {+        case TEAM_NEUTRAL:+        {+            _worldQuestTemplates[questExpansion][TEAM_ALLIANCE][questId] = worldQuestTemplate;+            _worldQuestTemplates[questExpansion][TEAM_HORDE][questId] = worldQuestTemplate;++            if (quest->IsEmissaryQuest())+            {+                _emissaryWorldQuestTemplates[questExpansion][TEAM_ALLIANCE][questId] = worldQuestTemplate;+                _emissaryWorldQuestTemplates[questExpansion][TEAM_HORDE][questId] = worldQuestTemplate;+            }++            break;+        }+        default:+        {+            _worldQuestTemplates[questExpansion][questTeamId][questId] = worldQuestTemplate;++            if (quest->IsEmissaryQuest())+                _emissaryWorldQuestTemplates[questExpansion][questTeamId][questId] = worldQuestTemplate;++            break;+        }+    }+}++void WorldQuestMgr::LoadWorldQuestRewardTemplates()+{+    QueryResult result = WorldDatabase.Query("SELECT id, questType, rewardType - 1 AS rewardType, rewardId, rewardCount, rewardContext FROM world_quest_reward");+    if (!result)+        return;++    do+    {+        Field* fields = result->Fetch();++        WorldQuestReward worldQuestReward = WorldQuestReward(fields[0].GetUInt32(),+                                                             fields[1].GetUInt8(),+                                                             fields[2].GetUInt8(),+                                                             fields[3].GetUInt32(),+                                                             fields[4].GetUInt32(),+                                                             fields[5].GetUInt32());++        _worldQuestRewards[worldQuestReward.Id].push_back(worldQuestReward);+        _worldQuestRewardByQuestInfos[worldQuestReward.QuestType].push_back(worldQuestReward.Id);+    } while (result->NextRow());+}++void WorldQuestMgr::LoadActiveWorldQuests()+{+    // not asynch, only at startup+    CharacterDatabasePreparedStatement* stmt = CharacterDatabase.GetPreparedStatement(CHAR_SEL_WORLD_QUEST);+    PreparedQueryResult result = CharacterDatabase.Query(stmt);++    if (!result)+    {+        TC_LOG_INFO("server.loading", "World Quest: There is no active world quests.");

... or "World Quest: No world quest is currently active." (optional phrasing)

osleyder85

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentTrinityCore/TrinityCore

Core/WorldQuest: Add BFA World Quests system

 namespace WorldPackets          struct WorldQuestUpdateInfo         {-            WorldQuestUpdateInfo(int32 lastUpdate, uint32 questID, uint32 timer, int32 variableID, int32 value) :-                LastUpdate(lastUpdate), QuestID(questID), Timer(timer), VariableID(variableID), Value(value) { }-            int32 LastUpdate;-            uint32 QuestID;-            uint32 Timer;+            int32 LastUpdate = 0;+            uint32 QuestID = 0;+            uint32 Timer = 0;             // WorldState-            int32 VariableID;-            int32 Value;+            int32 VariableID = 0;+            int32 Value = 0;         }; -        class WorldQuestUpdateResponse final : public ServerPacket+        class WorldQuestUpdate final : public ServerPacket         {         public:-            WorldQuestUpdateResponse() : ServerPacket(SMSG_WORLD_QUEST_UPDATE_RESPONSE, 100) { }+            WorldQuestUpdate() : ServerPacket(SMSG_WORLD_QUEST_UPDATE, 100) { }              WorldPacket const* Write() override; -            std::vector<WorldQuestUpdateInfo> WorldQuestUpdates;+            std::vector<WorldPackets::Quest::WorldQuestUpdateInfo> WorldQuestUpdates;+        };++        class QueryQuestReward final : public ClientPacket+        {+        public:+            QueryQuestReward(WorldPacket&& packet) : ClientPacket(CMSG_QUERY_TREASURE_PICKER, std::move(packet)) { }++            void Read() override;++            uint32 QuestID;+            uint32 Unk;+        };++        class QueryQuestRewardResponse final : public ServerPacket+        {+        public:+            QueryQuestRewardResponse() : ServerPacket(SMSG_QUERY_TREASURE_PICKER_RESPONSE) { }++            WorldPacket const* Write() override;++            struct CurrencyReward+            {+                uint32 CurrencyID = 0;+                uint32 Quantity = 0;+            };++            struct ItemReward+            {+                WorldPackets::Item::ItemInstance Item;+                uint32 Quantity = 0;+            };++            uint32 QuestID;+            uint32 Unk1 = 0;

The suggestion above is that Unk1 could be replaced by QuestRewardID (although I don't know if QuestRewardID is implemented as a packet in your system).

osleyder85

comment created time in 3 days

PullRequestReviewEvent

issue commentMicrosoftDocs/windows-itpro-docs

MDATP Evaluation Lab permissions

Fair enough, thanks for confirming. We will just have to wait for someone familiar with the topic, like the document author or the MS Docs technical writers (or possibly other experienced users of the technology) to reply and suggest what needs to be done here.

Please also note that the primary purpose of this repository is to improve the documentation by suggesting improvement changes to the document pages.

dismembered3po

comment created time in 3 days

pull request commentMicrosoftDocs/windows-itpro-docs

added simplifying deployment of SSU link

I don't necessarily have a firm opinion on this added line, only the notion that this type of added documentation is usually listed in some form of "See also:" section or specific "References:" section at the bottom of the page.

I am not sure if the link and text belongs in the currently selected section, so I defer to the document author (Jaime Ondrusek) and our familiar copy reviewer, JohanFreelancer9, to approve and confirm this new content.

RAJU2529

comment created time in 3 days

issue commentMicrosoftDocs/windows-itpro-docs

Referenced link to the "Sample - gather.ps1" has not been tested on Windows 10

GitHub search for related code: https://github.com/search?l=PowerShell&q=%22Gather.ps1%22&type=Code

We might want to check if MDT Standalone operation could be an issue in Windows 10 deployment.

tim-toolman

comment created time in 3 days

issue commentMicrosoftDocs/windows-itpro-docs

Referenced link to the "Sample - gather.ps1" has not been tested on Windows 10

Also documented on the TechNet Gallery page:

Verified on the following platforms

Windows 10 No
Windows Server 2012 No
Windows Server 2012 R2 No
Windows Server 2008 R2 No
Windows Server 2008 No
Windows Server 2003 No
Windows Server 2016 No
Windows 8 Yes
Windows 7 Yes
Windows Vista No
Windows XP No
Windows 2000 No

<sub>This script is tested on these platforms by the author. It is likely to work on other platforms as well. If you try it and find that it works on another platform, please add a note to the script discussion to let others know.</sub>

tim-toolman

comment created time in 3 days

issue commentMicrosoftDocs/windows-itpro-docs

Referenced link to the "Sample - gather.ps1" has not been tested on Windows 10

Points worth of note:

  • https://docs.microsoft.com/en-us/windows/deployment/deploy-windows-mdt/simulate-a-windows-10-deployment-in-a-test-environment?source=docs
  • (2.) Download the sample Gather.ps1 script from the TechNet gallery and copy it to a directory named C:\MDT on PC0001. (https://go.microsoft.com/fwlink/p/?LinkId=619361)
  • The go.microsoft.com URL redirects to https://gallery.technet.microsoft.com/Perform-a-standalone-MDT-227fdcd0
  • Last updated: 4/10/2014 (April 10, 2014) (!)
  • Also worth noting: https://docs.microsoft.com/en-us/teamblog/technet-gallery-retirement (TechNet Gallery Retirement): "We are retiring the TechNet Gallery. Make sure to back up your code. [Learn More]"
tim-toolman

comment created time in 3 days

issue commentMicrosoftDocs/windowsserverdocs

please include all switches

From https://www.windowslatest.com/2019/07/16/microsoft-acknowledges-sfc-error-in-windows-10/ :

Windows Resource Protection found corrupt files but was unable to fix some of them.
For online repairs, details are included in the CBS log file located at 
%windir%\Logs\CBS\CBS.log. For example C:\Windows\Logs\CBS\CBS.log. For offline 
repairs, details are included in the log file provided by the /OFFLOGFILE flag.

By the way, do you have a server scenario from where this issue has occurred? From what I can tell, based on a couple of quick web searches, that issue seems specific to Windows 10 (desktops/laptops/phones) and not necessarily for Windows Server environments.

schnitz76

comment created time in 3 days

issue commentgitextensions/gitextensions

Crash when git is uninstalled

Now that you mention it, it does look quite like you say, because both software install and uninstall procedures usually states that you should close other applications when installing or uninstalling any application.

Just to add my last bit to the ridiculousness of the described situation, the OP statement "Expected behaviour: No crash, just message box about missing Git." makes me visualize Git Extensions getting a "sad face" 😢 while saying "I miss Git. I really do."

NN---

comment created time in 3 days

PullRequestReviewEvent

issue commentTrinityCore/TrinityCore

map, vmap problems

Sorry, I don't know. We must wait for others who are using master branch and a French (frFR) version of the game to see if they get this type of issue, or if any of the real coders have any idea what happens with your extraction process.

firelook

comment created time in 3 days

PullRequestReviewEvent

pull request commentMicrosoftDocs/windows-itpro-docs

Added Server 2019

#sign-off

joinimran

comment created time in 3 days

pull request commentMicrosoftDocs/windows-itpro-docs

Added Server 2019

Thank you for providing the PR. Interesting note about your observed change. Some browsers might display unexpected changes, depending on how well they read GitHub pages.

joinimran

comment created time in 3 days

PullRequestReviewEvent

push eventillfated/TrinityCore

Giacomo Pozzoni

commit sha e3da1ed2455676cfe31757cbd816d92ee1d93a3c

CI/CircleCI: Authenticate to DockerHub when pulling the docker image (#25581) For more information see the following links: - https://www.docker.com/blog/scaling-docker-to-serve-millions-more-developers-network-egress/ - https://docs.docker.com/docker-hub/download-rate-limit/ - https://circleci.com/docs/2.0/private-images/ Add DOCKERHUB_USERNAME and DOCKERHUB_PASSWORD secrets to CircleCI Environment Variables. DOCKERHUB_PASSWORD can be either the password or an access token.

view details

push time in 3 days

issue commentMicrosoftDocs/windows-itpro-docs

Microsoft Intune hyperlink is broken

Just as a side note: I opted for the alternate page https://docs.microsoft.com/mem/intune/fundamentals/ for a simpler overview in my PR #8486 -- feel free to comment & suggest in that page.

jeffreymcclain

comment created time in 3 days

pull request commentMicrosoftDocs/windows-itpro-docs

Manage Windows 10/Intune: MS Intune URLs updated

#sign-off

illfated

comment created time in 3 days

PullRequestReviewEvent

PR opened MicrosoftDocs/windows-itpro-docs

Manage Windows 10/Intune: MS Intune URLs updated

Description:

As reported in issue ticket #8471 (Microsoft Intune hyperlink is broken), Microsoft Intune documentation has beem moved to a directory below /mem/.

Old URL /intune/understand-explore/introduction-to-microsoft-intune (404) New URL: https://docs.microsoft.com/mem/intune/fundamentals/

I also found it necessary to update the MS TechNet link to use their new site: https://techcommunity.microsoft.com/ (old site: blogs.technet.microsoft.com)

The "What is Intune?" URL in the "Related topics" section needed updating too.

Thanks to Jeffrey McClain (@jeffreymcclain) for noticing & reporting the issue.

Additional notes:

I skipped spacing and formatting edits due to the relative importance of the broken links. Please let me know if you prefer to include a thorough review of the spacing and formatting in this document.

Ticket closure or reference:

Closes #8471

+3 -3

0 comment

1 changed file

pr created time in 3 days

push eventillfated/windows-itpro-docs

Trond B. Krokli

commit sha 723b61f31149be04092ccb4a7f632ffe283db75c

Manage Windows 10/Intune: MS Intune URLs updated As reported in issue ticket #8471 (Microsoft Intune hyperlink is broken), Microsoft Intune documentation has beem moved to a directory below /mem/. Old URL /intune/understand-explore/introduction-to-microsoft-intune New URL: https://docs.microsoft.com/mem/intune/fundamentals/ I also found it necessary to update the MS TechNet link to use their new site: https://techcommunity.microsoft.com/ (old site: blogs.technet.microsoft.com) The "What is Intune?" URL in the "Related topics" section needed updating too. Thanks to Jeffrey McClain (jeffreymcclain) for noticing & reporting the issue. Closes #8471

view details

push time in 3 days

push eventillfated/windows-itpro-docs

MaratMussabekov

commit sha 39ef4bc9a1053b5e036bbae7465a94dcd782f707

Update microsoft-defender-atp-mac.md

view details

MaratMussabekov

commit sha 4607899d82de69af92819cff09dd4bfd77c71cdb

Update linux-install-manually.md

view details

MaratMussabekov

commit sha cee429d94e43e66837ff4b4d710461b3cba52f21

Update windows/security/threat-protection/microsoft-defender-atp/microsoft-defender-atp-mac.md Co-authored-by: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>

view details

Marty Hernandez Avedon

commit sha 935da0cab817be752421fae427198c454f7d0f1b

matching structure of page w mtp version

view details

Marty Hernandez Avedon

commit sha 729662d01c945932df92c0e00c93c7bd8aaeb73d

added link to sync with mtp version of page

view details

Marty Hernandez Avedon

commit sha 5634415d8518ef962a12253a9d6351d14eedc695

added details on gui to sync w mtp version

view details

VARADHARAJAN K

commit sha 146fb0e3db1993cd94e73d513bbcb9fabfc4a87f

removed download link, added explanation as per the user report #8242 , so I removed the download link and added an explanation.

view details

Marty Hernandez Avedon

commit sha 9ca73b9629fd59f59300d5f00f8d9d7910810c02

added missing links to sync with mtp version of page

view details

Marty Hernandez Avedon

commit sha fd5f4dfaf6188b04ab5800821f156f6c38809353

making link lists more consistent

view details

MaratMussabekov

commit sha 994a5681699589c5b76f7b6d7c21c46d5ebc037e

Update vpn-conditional-access.md

view details

Marty Hernandez Avedon

commit sha 92beced4d2eb2ea2138de0b486e70283fad66460

added content wholesale from mtp version of best practices

view details

Marty Hernandez Avedon

commit sha de14f98b3255184a699341c44468f650663efe58

added take-actions.md

view details

Marty Hernandez Avedon

commit sha a53c16790e6b829bee9323a472b5391352e49f6d

added extend-data.md

view details

Marty Hernandez Avedon

commit sha 7244f328afef7f3ca6b960d552f34eaa7bc994c5

added function page assignedipaddress

view details

Marty Hernandez Avedon

commit sha 3a46478e468b4b1ba5c1091cacd98b2cfc287a14

added function page fileprofile

view details

schmurky

commit sha fb844b70ab342742e22f7bc7cd203354e1473a84

New firewall best practices page

view details

schmurky

commit sha 56a0c2d27b644c706537689f7258b4c9acd47e83

Update fwall best practices

view details

VARADHARAJAN K

commit sha 3ef62e034a03c7100773f4bdffd0aa561030895d

Update windows/client-management/troubleshoot-tcpip-netmon.md accepted Co-authored-by: Trond B. Krokli <38162891+illfated@users.noreply.github.com>

view details

VARADHARAJAN K

commit sha 3d7029f03d2ceadcfc1bd519dab10f70d27e0a4c

Update windows/client-management/troubleshoot-tcpip-netmon.md accepted Co-authored-by: Trond B. Krokli <38162891+illfated@users.noreply.github.com>

view details

ImranHabib

commit sha d7f6d7a4ea5a87d31f1815b441d9d796f6e17304

Minor Changes As suggested by the user, I made a few changes to reflect the document more clear and easy to understand. Problem: https://github.com/MicrosoftDocs/windows-itpro-docs/issues/7965

view details

push time in 4 days

push eventillfated/Hololens

Evan Miller

commit sha c2c2bf8abf56c9547f1c3f9b3e606de9002c48c6

device owner

view details

Evan Miller

commit sha ff3c551c783a9eae92c3cae8a43e1201b6904938

Create hololens2-options.md

view details

Evan Miller

commit sha 1aa68a96701e955d8b60f506938233972ccc3d6e

Remove en-us s

view details

Evan Miller

commit sha 88ed0e6b1955bae8324d8f0aaf9b6b20662e0c0d

Bullets and links

view details

Evan Miller

commit sha b10c1c90cba776f760ab773a1534a2b256c9c636

taking in some feedback from word

view details

Evan Miller

commit sha 04359e1ad611666d2d8b307cbf1b691d284ada59

Update hololens2-options.md

view details

Evan Miller

commit sha 5d8d6b7958dfdd32afbceb79100f3746ad0d1956

video take 3

view details

Evan Miller

commit sha afab01f2f54649c4c8895a7d041dd5318871b1a7

Info from email add

view details

Evan Miller

commit sha 5ecc864d8b6f63ebcd9806b3bffb226c1e6829db

Merge branch 'master' into evmill-hololens-options

view details

Evan Miller

commit sha c78226e2ea654f289784c4e3b6f9001eaa6edcf7

Update hololens2-options.md

view details

Evan Miller

commit sha c73ed79d07d1c13f9742695821ad4e177f08dee7

Update hololens2-options.md

view details

Evan Miller

commit sha 199d349d4bdb959ca91ad2578fd06e90cc89fad3

Merge branch 'master' into evmill-hololens-options

view details

Evan Miller

commit sha c371bab6c5ba2fd7a5c3fb6586b3a8f093edfd18

Update hololens2-options.md

view details

Evan Miller

commit sha a504508f22ac3828525e9f6dae1ced68782696e4

Update hololens2-options.md

view details

Evan Miller

commit sha a6a02cf67e939f97e4c6299d30ebbe9ac68cd32a

Update hololens2-options.md

view details

Evan Miller

commit sha 6eff55d039e714ad9ba4dfe9018028562c710e73

overviews

view details

Evan Miller

commit sha 8ab71dfba88ae9d45e3582d2b4a3a2a6c1bf3a48

azure credit line

view details

Evan Miller

commit sha c96fadd8e620475dbfcafb72aaace4ca579d9c6a

Update hololens2-options.md

view details

Evan Miller

commit sha 82630512c3fc65ff3bc732e89cf2909a85d6d719

summary of page

view details

Evan Miller

commit sha 7d1873f580367e246826d3aab11804fe7f7532be

Sean's feedback

view details

push time in 4 days

push eventillfated/windowsserverdocs

JohnCobb1

commit sha ed664763d9a29aef66b8848cdd5af816b4fddfbb

Server OS version updates

view details

JohnCobb1

commit sha 59c5467b55631496f9619372e55e9d741263a48f

Updated Server OS version from 2016 to 2019 where needed

view details

JohnCobb1

commit sha ec7f462dee06bdd66e6bc5b255a6ffc1166a02ec

fixed guide title intro text

view details

JohnCobb1

commit sha bba929def88d7d4b80371e8afd8847f19968c1c8

publish date synch

view details

JohnCobb1

commit sha 394802f602e67d849cf867736dbd84aa7b6217cd

updated publish date

view details

John Cobb

commit sha 60eb21bfb67203f01b9adcb41ad424d384154d82

Update WindowsServerDocs/storage/storage-spaces/deploy-storage-spaces-direct.md Co-authored-by: Jason Gerend <JasonGerend@users.noreply.github.com>

view details

John Cobb

commit sha 7fd7df43790d2146e699023ad6dc7ae00bad3c41

Update WindowsServerDocs/storage/storage-spaces/deploy-storage-spaces-direct.md Co-authored-by: Jason Gerend <JasonGerend@users.noreply.github.com>

view details

John Cobb

commit sha 697c3c683c9ea3a38ee196f7784aa3d454c9c9f5

Update WindowsServerDocs/storage/storage-spaces/deploy-storage-spaces-direct.md Co-authored-by: Jason Gerend <JasonGerend@users.noreply.github.com>

view details

Elizabeth Ross

commit sha 0bad7b0f0d0f0228b27c48c9831cda0c215acbd3

fixing formatting and content

view details

Elizabeth Ross

commit sha c834efb27aa6eca06e8f3c64539e549931c383e6

Merge branch 'master' of https://github.com/MicrosoftDocs/windowsserverdocs-pr into update-commands-4

view details

Elizabeth Ross

commit sha f4787fa2faee4f7c95f5ba95b994a0ca9393add3

fixing formatting and content

view details

Elizabeth Ross

commit sha e04c18ecb18ab4ad2935e20bc051cfdab214ed6f

fixing formatting and content

view details

Artem Pronichkin

commit sha 77fe86e1b1b61d2df04f849ef66baa4d8531dfc5

Update guarded-fabric-troubleshoot-hgs.md added one more known issue, symptoms and resolution

view details

Elizabeth Ross

commit sha 4c200f73b600e53074a492c5879ae0c4071d4c08

Merge branch 'master' of https://github.com/MicrosoftDocs/windowsserverdocs-pr into update-commands-4

view details

Elizabeth Ross

commit sha 831e22366f0d2f55250b124fffbc1a9693c3c93f

Merge branch 'master' of https://github.com/MicrosoftDocs/windowsserverdocs-pr into update-commands-4

view details

Heidi Lohr

commit sha fb5e0d51344f769fefa570f2bc22d378dceab539

Added new bullet point about credentials.

view details

Elizabeth Ross

commit sha 6e350e04e00271731f2ea9f0f340c0dba4e7088e

fixing language

view details

Heidi Lohr

commit sha 1c3897c4215c7850a507cb01301d60b53528b179

Updated to CELA-approved phrasing.

view details

Heidi Lohr

commit sha d23d188c8620df875e05548449b48f550dc5bfeb

Merge pull request #1377 from Heidilohr/work-cred-update Added new bullet point about credentials to client "What's New"

view details

Trond B. Krokli

commit sha 92bfd901caedc9076d905942e7ce19b49607c34b

Best Practices Analyzer for Hyper-V: link updated As stated in issue ticket #810 (Link to Best Practices Analyzer is outdated?), the existing Best Practices Analyzer URL links to the 2008 R2 page version. Thanks to olavt for reporting the issue. My suggestion is to replace it with the 2012/2012 R2 page version, even if the new page link also belongs to the /previous-versions/ hierarchy. I have made some effort to locate a similar Windows Server 2016 page, but those are mostly troubleshooting pages only, not general topic documentation pages. Closes #810

view details

push time in 4 days

Pull request review commentMicrosoftDocs/windows-itpro-docs

removed wrong values added correct values

 ADMX Info: <!--/ADMXMapped--> <!--SupportedValues--> Supported values:  --   true - Enable--   false - Disable (Default)+-   0  - Disable

The disabled state is the default state, isn't it?

-   0  - Disable (Default)
RAJU2529

comment created time in 4 days

PullRequestReviewEvent

issue commentMicrosoftDocs/windows-itpro-docs

MDATP Evaluation Lab permissions

Most likely this page:


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

dismembered3po

comment created time in 4 days

issue commentMicrosoftDocs/windows-itpro-docs

Microsoft Intune hyperlink is broken

Good point, the MS Intune pages were moved to the /mem/ directory structure during the last couple of years.

What do you think about using the main MS Intune overview page, https://docs.microsoft.com/mem/intune/?

jeffreymcclain

comment created time in 4 days

Pull request review commentMicrosoftDocs/windows-itpro-docs

Added Server 2019

 ms.custom: asr **Applies to** -   Windows 10 -   Windows Server 2016+-   Windows Server 2019

Codestyle: MarkDown bullet lists only need 1 single space between the bullet marker (hyphen) and its text:

- Windows 10
- Windows Server 2016
- Windows Server 2019
joinimran

comment created time in 4 days

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentMicrosoftDocs/windows-itpro-docs

Published recommended driver block rules from HVCI/10S blocklist

Fair request. One of the MS Docs team members will assign/request the reviewers for you.

jgeurten

comment created time in 4 days

issue commentMicrosoftDocs/windows-itpro-docs

Windows IT Pro Blog attach

Maybe the document is shown differently to me than others. Oh well. I will leave it for Varadharajan to follow up, because I could not find it.

felizondojr

comment created time in 4 days

pull request commentMicrosoftDocs/windowsserverdocs

ADDS/Azure CLI: Configure DNS & second DC promo

Oh. I see. I thought the "sign-off" was meant just to clarify that the PR author has completed all known required tasks and that the PR is ready to be handed over.

illfated

comment created time in 4 days

pull request commentMicrosoftDocs/windowsserverdocs

ADDS/Azure CLI: Configure DNS & second DC promo

#sign-off

illfated

comment created time in 4 days

pull request commentMicrosoftDocs/windowsserverdocs

ADDS/Azure CLI: Configure DNS & second DC promo

OK, fair enough. We may just want the document author's approval for this change, in case the wording needs to be rephrased.

illfated

comment created time in 4 days

PullRequestReviewEvent

PR opened MicrosoftDocs/windowsserverdocs

ADDS/Azure CLI: Configure DNS & second DC promo

As reported in issue ticket #4917 (Configure DNS before configuring the second domain controller), promoting the second server fails with the error message "An active directory domain controller for the domain <testdomain.com> could not be contacted" when trying to promote the second DC before the Configure DNS step has been performed.

Based on this feedback, I propose to move the [Configure DNS] paragraph up to before the [Configure the second Domain Controller] section, as well as adapting the first sentence text accordingly, to match the new sequence.

Thanks to @K-Dela-R for discovering and reporting this live example issue.

Closes #4917

+5 -6

0 comment

1 changed file

pr created time in 4 days

push eventillfated/windowsserverdocs

Trond B. Krokli

commit sha 6341fbd37c8f762372290ef904a7dee56ae5c066

ADDS/Azure CLI: Configure DNS & second DC promo As reported in issue ticket #4917 (Configure DNS before configuring the second domain controller), promoting the second server fails with the error message "An active directory domain controller for the domain <testdomain.com> could not be contacted" when trying to promote the second DC before the Configure DNS step has been performed. Based on this feedback, I propose to move the [Configure DNS] paragraph up to before the [Configure the second Domain Controller] section, as well as adapting the first sentence text accordingly, to match the new sequence. Thanks to K-Dela-R for discovering and reporting this live example issue. Closes #4917

view details

push time in 4 days

PullRequestReviewEvent

issue commentMicrosoftDocs/windows-itpro-docs

Windows IT Pro Blog attach

@felizondojr : Which reference section did you have in mind? The one in the TOC list? If so, do you mean as a document in parallel to the page referenced in this ticket?

felizondojr

comment created time in 4 days

pull request commentMicrosoftDocs/windowsserverdocs

Clarify scheduled task's cadence for SSDs

#sign-off

ChandKV

comment created time in 4 days

PullRequestReviewEvent

pull request commentMicrosoftDocs/windows-itpro-docs

Script improvements

#sign-off

skycommand

comment created time in 4 days

more