profile
viewpoint
Ismael Juma ijuma Confluent San Francisco Bay Area, CA http://blog.juma.me.uk

confluentinc/securing-kafka-blog 40

Secure Kafka cluster (in a VM) for development and testing

ijuma/configgy 21

simple config and logging setup for scala

ijuma/junit_xml_listener 17

Fork from Christoph Henkelmann

ijuma/pad 7

Etherpad Open-Source Repository

ijuma/benchmark 4

A collection of benchmarks

ijuma/misc 3

Miscellaneous

ijuma/byte-buddy 1

Runtime code generation for the Java virtual machine.

ijuma/cglib 1

cglib - Byte Code Generation Library is high level API to generate and transform Java byte code. It is used by AOP, testing, data access frameworks to generate dynamic proxy objects and intercept field access.

ijuma/easymock 1

EasyMock, makes mocking easier since 2001

pull request commentapache/kafka

HOTFIX: Decrease version of grgit to avoid unsupported version error

An alternative is to set the jgit version explicitly. Something like:

    // Override jgit dependency used by grgit and spotless as we appear to auto resolve to 
    // 5.13.0.202109080827-r and the latest version requires java 9.
    // Requires force=true to be used in spotless as reported by ./gradlew buildEnvironment.
    classpath("org.eclipse.jgit:org.eclipse.jgit:$versions.jgit") { force = true }
cadonna

comment created time in 6 days

pull request commentconfluentinc/kafka-rest

Bind NoSchemaRecordSerializer as Singleton.

AbstractConfig has the following constructor:

public AbstractConfig(ConfigDef definition, Map<?, ?> originals, boolean doLog) {

rigelbm

comment created time in 17 days

Pull request review commentapache/kafka

MINOR: Replace EasyMock with Mockito in connect:file

 public void setup() {      @Test     public void testConnectorConfigValidation() {-        replayAll();         List<ConfigValue> configValues = connector.config().validate(sourceProperties);         for (ConfigValue val : configValues) {             assertEquals(0, val.errorMessages().size(), "Config property errors: " + val.errorMessages());         }-        verifyAll();

Don't we need any verify calls here?

dengziming

comment created time in a month

Pull request review commentapache/kafka

MINOR: Replace EasyMock with Mockito in connect:file

 public void testMissingFile() throws InterruptedException {         task.stop();     } +    @Test+    @Disabled

Why did we disable this test?

dengziming

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentapache/kafka

MINOR: Remove topic null check from `TopicIdPartition` and adjust constructor order

Merged to trunk and 3.1 branches.

ijuma

comment created time in a month

push eventapache/kafka

Ismael Juma

commit sha 703d1b8bddbea505ee5d73ac37c18b873c6c12de

MINOR: Remove topic null check from `TopicIdPartition` and adjust constructor order (#11403) `TopicPartition` allows a null `topic` and there are cases where we have a topic id, but no topic name. Even for `TopicIdPartition`, the non null topic name check was only enforced in one constructor. Also adjust the constructor order to move the nullable parameter to the end, update tests and javadoc. Reviewers: David Jacot <djacot@confluent.io>, Luke Chen <showuon@gmail.com>

view details

push time in a month

push eventapache/kafka

Ismael Juma

commit sha b8c3a67012218188330110ce94636b70116131f9

MINOR: Remove topic null check from `TopicIdPartition` and adjust constructor order (#11403) `TopicPartition` allows a null `topic` and there are cases where we have a topic id, but no topic name. Even for `TopicIdPartition`, the non null topic name check was only enforced in one constructor. Also adjust the constructor order to move the nullable parameter to the end, update tests and javadoc. Reviewers: David Jacot <djacot@confluent.io>, Luke Chen <showuon@gmail.com>

view details

push time in a month

PR merged apache/kafka

MINOR: Remove topic null check from `TopicIdPartition` and adjust constructor order

TopicPartition allows a null topic and there are cases where we have a topic id, but no topic name. Even for TopicIdPartition, the non null topic name check was only enforced in one constructor.

Also adjust the constructor order to move the nullable parameter to the end, update tests and javadoc.

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)
+38 -9

4 comments

2 changed files

ijuma

pr closed time in a month

pull request commentapache/kafka

MINOR: Remove topic null check from `TopicIdPartition` and adjust constructor order

@dajac I'll merge after the build completes.

ijuma

comment created time in a month

push eventijuma/kafka

Ismael Juma

commit sha 7ba23533533ea377516b99b89615d54a47def0ee

Minor comment adjustment

view details

push time in a month

push eventapache/kafka

Luke Chen

commit sha 60b18a49aaacc5a2e4a65910ad6cf0626543ddc2

KAFKA-13396: Allow create topic without partition/replicaFactor (#11429) [KIP-464](https://cwiki.apache.org/confluence/display/KAFKA/KIP-464%3A+Defaults+for+AdminClient%23createTopic) (PR: https://github.com/apache/kafka/pull/6728) made it possible to create topics without passing partition count and/or replica factor when using the admin client. We incorrectly disallowed this via https://github.com/apache/kafka/pull/10457 while trying to ensure validation was consistent between ZK and the admin client (in this case the inconsistency was intentional). Fix this regression and add tests for the command lines in quick start (i.e. create topic and describe topic) to make sure it won't be broken in the future. Reviewers: Lee Dongjin <dongjin@apache.org>, Ismael Juma <ismael@juma.me.uk>

view details

push time in a month

pull request commentapache/kafka

KAFKA-13396: allow create topic without partition/replicaFactor

@dajac Makes sense, pushed to trunk, 3.1 and 3.0.

showuon

comment created time in a month

push eventapache/kafka

Luke Chen

commit sha e29c87a1f5652cfcb859046ec8138328444db579

KAFKA-13396: Allow create topic without partition/replicaFactor (#11429) [KIP-464](https://cwiki.apache.org/confluence/display/KAFKA/KIP-464%3A+Defaults+for+AdminClient%23createTopic) (PR: https://github.com/apache/kafka/pull/6728) made it possible to create topics without passing partition count and/or replica factor when using the admin client. We incorrectly disallowed this via https://github.com/apache/kafka/pull/10457 while trying to ensure validation was consistent between ZK and the admin client (in this case the inconsistency was intentional). Fix this regression and add tests for the command lines in quick start (i.e. create topic and describe topic) to make sure it won't be broken in the future. Reviewers: Lee Dongjin <dongjin@apache.org>, Ismael Juma <ismael@juma.me.uk>

view details

push time in a month

push eventapache/kafka

Luke Chen

commit sha 43bcc5682da82a602a4c0a000dc7433d0507b450

KAFKA-13396: Allow create topic without partition/replicaFactor (#11429) [KIP-464](https://cwiki.apache.org/confluence/display/KAFKA/KIP-464%3A+Defaults+for+AdminClient%23createTopic) (PR: https://github.com/apache/kafka/pull/6728) made it possible to create topics without passing partition count and/or replica factor when using the admin client. We incorrectly disallowed this via https://github.com/apache/kafka/pull/10457 while trying to ensure validation was consistent between ZK and the admin client (in this case the inconsistency was intentional). Fix this regression and add tests for the command lines in quick start (i.e. create topic and describe topic) to make sure it won't be broken in the future. Reviewers: Lee Dongjin <dongjin@apache.org>, Ismael Juma <ismael@juma.me.uk>

view details

push time in a month

PR merged apache/kafka

KAFKA-13396: allow create topic without partition/replicaFactor

In https://github.com/apache/kafka/pull/10457/files#r635196307, the reviewer asked if there's a bug that we only check for zookeeper case, I didn't do a well check and directly confirm it. Now, after checking the change history, I found the change is because the KIP-464 (PR: https://github.com/apache/kafka/pull/6728) added default values for partition count and replica factor for createTopic in AdminClient. So it didn't apply for zookeeper option case.

Fix this bug and add tests for the command lines in quick start (i.e. create topic and describe topic), to make sure it won't be broken in the future.

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)
+33 -16

4 comments

2 changed files

showuon

pr closed time in a month

PullRequestReviewEvent

pull request commentapache/kafka

KAFKA-13396: allow create topic without partition/replicaFactor

@showuon we should have this in 3.0.1 too, right?

showuon

comment created time in a month

Pull request review commenteclipse/jetty.project

consumeAll: fail content with static exception

 class AsyncContentProducer implements ContentProducer {     private static final Logger LOG = LoggerFactory.getLogger(AsyncContentProducer.class);+    private static final Throwable UNCONSUMED_CONTENT_EXCEPTION = new IOException("Unconsumed content")+    {+        @Override+        public synchronized Throwable fillInStackTrace()

Sounds good.

lorban

comment created time in a month

PullRequestReviewEvent

Pull request review commenteclipse/jetty.project

consumeAll: fail content with static exception

 class AsyncContentProducer implements ContentProducer {     private static final Logger LOG = LoggerFactory.getLogger(AsyncContentProducer.class);+    private static final Throwable UNCONSUMED_CONTENT_EXCEPTION = new IOException("Unconsumed content")+    {+        @Override+        public synchronized Throwable fillInStackTrace()

What is the reason for the synchronized here?

lorban

comment created time in a month

PullRequestReviewEvent

Pull request review commentapache/kafka

MINOR: Remove topic null check from `TopicIdPartition` and adjust constructor order

 public Uuid topicId() {     }      /**-     * @return the topic name.+     * @return the topic name or null.

Not sure if that adds any value. The topic id is always set, so how is saying "there's only topic id set" helping? Maybe "the topic name or null if it is unknown"?

ijuma

comment created time in a month

PullRequestReviewEvent

Pull request review commentopenjdk/jdk

8275167: x86 intrinsic for unsignedMultiplyHigh

 public static long multiplyHigh(long x, long y) {      * @see #multiplyHigh      * @since 18      */+    @IntrinsicCandidate     public static long unsignedMultiplyHigh(long x, long y) {         // Compute via multiplyHigh() to leverage the intrinsic

This comment seems stale given that this method is also intrinsified.

vamsi-parasa

comment created time in a month

PullRequestReviewEvent

Pull request review commentapache/kafka

KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

 project(':clients') {      compileOnly libs.jacksonDatabind // for SASL/OAUTHBEARER bearer token parsing     compileOnly libs.jacksonJDK8Datatypes+    compileOnly libs.jose4j

Do we want to add a comment like:

// for SASL/OAUTHBEARER bearer token parsing
kirktrue

comment created time in a month

PullRequestReviewEvent
more