profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/hs0210/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

hs0210/ansible 0

Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy and maintain. Automate everything from code deployment to network configuration to cloud management, in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com.

hs0210/baremetal-operator 0

Bare metal host provisioning integration for Kubernetes

hs0210/cni 0

Container Network Interface - networking for Linux containers

hs0210/containerd 0

An open and reliable container runtime

hs0210/containerized-data-importer 0

Data Import Service for kubernetes, designed with kubevirt in mind.

hs0210/coredns 0

CoreDNS is a DNS server that chains plugins

pull request commentopenshift/ironic-image

Enable irmc bios interface

/retest

hs0210

comment created time in 2 days

pull request commentopenshift/ironic-image

Enable irmc bios interface

@elfosardo Done.

hs0210

comment created time in 4 days

push evenths0210/ironic-image

Hu Shuai

commit sha 12debf832910ed8f915cf78a24eb65682065913f

Enable irmc bios interface Signed-off-by: Hu Shuai <hus.fnst@cn.fujitsu.com>

view details

push time in 4 days

pull request commentmetal3-io/baremetal-operator

Fix auto clean failure in preparing state

@dtantsur

Shouldn't we fix the Ironic RAID implementation instead?

After consideration, we came up with two ideas to fix it on ironic side:

  1. Set a time limit for RAID initialization.
    Constrains: The time required for RAID initialization depends on the performance and size of the disk. So it is difficult to calculate an appropriate time limit.
  2. Get the progress of RAID initialization to determine whether it has ended.
    Constrains: This requires each bmc to have related APIs to obtain the RAID initialization progress.

Both the two ways have their constrains, but at present we only think of them to solve this problem on ironic side. Do you have a better idea? If it's really difficult to fix this on ironic side, could we change the phase of automated cleaning like #929 to fix it?

Hellcatlk

comment created time in 5 days

pull request commentopenshift/ironic-image

Enable irmc bios interface

/retest

hs0210

comment created time in 5 days

push evenths0210/terraform-provider-ironic

kirankt

commit sha 5e782ae14bfea9d1e8cb981c9a67386461d04c8a

Add deployment customization via deploy_steps (#52) * Add deploy_steps support * Re-vendor to add support for deploy_steps

view details

Hu Shuai

commit sha 78917d528f2256afc532de7d09230819a1fc66fb

Add raid Signed-off-by: Hu Shuai <hus.fnst@cn.fujitsu.com>

view details

Hu Shuai

commit sha e30cfb179601907422252ebf23bbb446c4711251

Change raid type Signed-off-by: Hu Shuai <hus.fnst@cn.fujitsu.com>

view details

Hu Shuai

commit sha 08f8084191e309b849cb2f542202b4dddd8ce300

Add BIOS Add BIOS manual cleanning. Change type from map to string. Signed-off-by: Hu Shuai <hus.fnst@cn.fujitsu.com>

view details

push time in 8 days

pull request commentopenshift/enhancements

Support RAID and BIOS configuration for baremetal IPI deployments

@hardys @dtantsur I updated the implementation details. PTAL. Because the clean steps of software RAID and hardware RAID are different, if raid field is processed into logicalDisks on the installer side, it will be difficult for terraform-provider-ironic to know whether it is a software RAID or a hardware RAID, so the processing of RAID and BIOS is unified to terraform -provider-ironic side.

hs0210

comment created time in 8 days

push evenths0210/enhancements

Hu Shuai

commit sha 7d2baa83f1575d8fbdb808109db1e63a0ea15be3

Update implementation details Add the implementation of BIOS. Transfer the processing of RAID and BIOS from installer to terraform-provider-ironic. Signed-off-by: Hu Shuai <hus.fnst@cn.fujitsu.com>

view details

push time in 8 days

Pull request review commentopenshift/enhancements

Support RAID and BIOS configuration for baremetal IPI deployments

+---+title: Config-RAID-and-BIOS-for-Baremetal-IPI-deployments+authors:+  - "@fenggw-fnst"+  - "@Hellcatlk"+  - "@hs0210"+  - "@zhouhao3"+  - "@zhu1fei"+reviewers:+  - TBD+approvers:+  - TBD+creation-date: 2021-05-18+last-updated: 2021-05-25+status: provisional+see-also:+  -+replaces:+  -+superseded-by:+  - https://github.com/metal3-io/baremetal-operator/pull/302+---++# Config RAID and BIOS for Baremetal IPI deployments++## Release Signoff Checklist++- [ ] Enhancement is `implementable`+- [ ] Design details are appropriately documented from clear requirements+- [ ] Test plan is defined+- [ ] Operational readiness criteria is defined+- [ ] Graduation criteria for dev preview, tech preview, GA+- [ ] User-facing documentation is created in [openshift-docs](https://github.com/openshift/openshift-docs/)++## Summary++This enhancement proposes to add the support of RAID and BIOS configuration for baremetal IPI deployments.++## Motivation++With the new feature of [RAID configuration](https://github.com/metal3-io/baremetal-operator/pull/292) and the upcoming feature of [BIOS configuration](https://github.com/metal3-io/baremetal-operator/pull/302), openshift already has or will have the ability to configure RAID and BIOS for baremetal.++However, these features only work with a running cluster, users cannot configure desired RAID and BIOS during IPI deployments.++### Goals++- Allow users to manage the RAID and BIOS configuration for control plane hosts during installation.+- IPI deployments can handle the configuration of RAID and BIOS.++### Non-Goals++- Add new or vendor specific options regarding RAID and BIOS.++## Proposal++The configuration of RAID and BIOS is finally handed over to Ironic during the IPI deployments.+1. The user runs `create manifests` and then adds RAID and BIOS fields to the **BMH** created by the installer.+2. The interface to terraform in the installer code parses the BIOS and RAID fields.+3. [Terraform-provider-ironic](https://github.com/openshift-metal3/terraform-provider-ironic) gets the+configuration of RAID and BIOS for control plane hosts and then passes it to Ironic([Baremetal Operator(BMO)](https://github.com/metal3-io/baremetal-operator)+has supported the process of RAID and BIOS for worker nodes).++### User Stories++With the addition of this feature, the users can configure RAID and BIOS in IPI deployments.++### Implementation Details/Notes/Constraints++#### Add two fields++The user runs `create manifests` and then adds RAID and BIOS fields to the **BMH** created by the installer.++```yaml+spec:+  bmc:+    address: <bmc>://<ip-address>+    credentialsName: worker-0-bmc-secret+  bootMACAddress: mac-address+  raid: raid-config+  firmware: bios-config+  ...+```++RAID feature has been implemented in **BMO**, so the *raid* field here is the same as the [BMH](https://github.com/metal3-io/baremetal-operator/blob/399f5ef7ee3831014c1425250bc4fa49641a8709/config/crd/bases/metal3.io_baremetalhosts.yaml).+The *firmware* field is the same as the *spec.firmware* field in **BMH** which is been advancing by [#302](https://github.com/metal3-io/baremetal-operator/pull/302).++#### Process the fields in installer++For control plane hosts, call the `BuildTargetRAIDCfg` method in **BMO** to process the *raid* field into *target_raid_config*, and finally write *target_raid_config* into the ***terraform.baremetal.auto.tfvars.json*** file.++#### Process the fields in terraform-provider-ironic++Add *target_raid_config* and *bios_settings* fields to terraform-provider-ironic API,

Done.

hs0210

comment created time in 8 days

PullRequestReviewEvent

Pull request review commentopenshift/enhancements

Support RAID and BIOS configuration for baremetal IPI deployments

+---+title: Config-RAID-and-BIOS-for-Baremetal-IPI-deployments+authors:+  - "@fenggw-fnst"+  - "@Hellcatlk"+  - "@hs0210"+  - "@zhouhao3"+reviewers:+  - TBD+approvers:+  - TBD+creation-date: 2021-05-18+last-updated: 2021-05-24+status: provisional+see-also:+  - +replaces:+  -+superseded-by:+  - https://github.com/metal3-io/baremetal-operator/pull/302+---++# Config RAID and BIOS for Baremetal IPI deployments++## Release Signoff Checklist++- [ ] Enhancement is `implementable`+- [ ] Design details are appropriately documented from clear requirements+- [ ] Test plan is defined+- [ ] Operational readiness criteria is defined+- [ ] Graduation criteria for dev preview, tech preview, GA+- [ ] User-facing documentation is created in [openshift-docs](https://github.com/openshift/openshift-docs/)++## Summary++This enhancement proposes to add the support of RAID and BIOS configuration for baremetal IPI deployments.++## Motivation++With the new feature of [RAID configuration](https://github.com/metal3-io/baremetal-operator/pull/292) and the upcoming feature of [BIOS configuration](https://github.com/metal3-io/baremetal-operator/pull/302), openshift already has or will have the ability to configure RAID and BIOS for baremetal.++However, these features only work with a running cluster, users cannot configure desired RAID and BIOS during IPI deployments.++### Goals++- Allow users to configure RAID and BIOS in ***install-config.yaml***.+- IPI deployments can handle the configuration of RAID and BIOS.++### Non-Goals++- Add new or vendor specific options regarding RAID and BIOS.++## Proposal++The configuration of RAID and BIOS is finally handed over to Ironic during the IPI deployments.+1. Add two new fields *raid* and *firmware* to *platform.baremetal.hosts* in the [install-config.yaml](https://github.com/openshift/installer/blob/master/data/data/install.openshift.io_installconfigs.yaml) file.+2. Openshift Installer process the field contents into manifests.+3. [Terraform-provider-ironic](https://github.com/openshift-metal3/terraform-provider-ironic) gets the+configuration of RAID and BIOS for master nodes and then passes it to Ironic([Baremetal Operator(BMO)](https://github.com/metal3-io/baremetal-operator)+has supported the process of RAID and BIOS for worker nodes).++### User Stories++With the addition of this feature, the users can configure RAID and BIOS in IPI deployments.++### Implementation Details/Notes/Constraints++#### Add two fields++New *platform.baremetal.hosts* fields called *raid* and *firmware*.++```yaml+platform:+  baremetal:+    ...+    hosts:+      - name: master-0+        role: master+        bmc:+          address: IPAddress+          username: UserName+          password: PassWord+        bootMACAddress: MACAddress+        raid: RAIDConfig+        firmware: BIOSConfig+```++RAID feature has been implemented in **BMO**, so the *raid* field here is the same as the [BMH](https://github.com/metal3-io/baremetal-operator/blob/399f5ef7ee3831014c1425250bc4fa49641a8709/config/crd/bases/metal3.io_baremetalhosts.yaml).+The *firmware* field is the same as the *spec.firmware* field in **BMH** which is been advancing by [#302](https://github.com/metal3-io/baremetal-operator/pull/302).++#### Process the fields in installer++For master nodes, call the `BuildTargetRAIDCfg` method in **BMO** to process the *raid* field into *target_raid_config*, and finally write *target_raid_config* into the ***terraform.baremetal.auto.tfvars.json*** file.++For worker nodes, copy *raid* and *firmware* field to **BMH**.++#### Process the fields in terraform-provider-ironic++Add *target_raid_config* and *bios_settings* fields to terraform-provider-ironic API, +process the two fields by [manual cleaning](https://docs.openstack.org/ironic/latest/admin/cleaning.html#manual-cleaning).++### Risks and Mitigations++TBD++## Design Details++### Test Plan++- Unit tests for determining the configuration of RAID and BIOS passed to Ironic meeting expectations.+- e2e tests for determining the configuration of RAID and BIOS configured during the IPI deployments.

https://opendev.org/openstack/sushy-tools has rudimentary BIOS support, we can use it for some basic testing probably.

@dtantsur Thanks for your advice.

hs0210

comment created time in 8 days

PullRequestReviewEvent

push evenths0210/enhancements

Hu Shuai

commit sha 21e65ee98fd8da9b0fd55a15bb7a6a62446a6069

Update implementation details Add the implementation of BIOS. Transfer the processing of RAID and BIOS from installer to terraform-provider-ironic. Signed-off-by: Hu Shuai <hus.fnst@cn.fujitsu.com>

view details

push time in 8 days

pull request commentopenshift/ironic-image

Enable irmc bios interface

@elfosardo Thanks, done.

hs0210

comment created time in 11 days

PR opened openshift/ironic-image

Enable irmc bios interface

I will pick up the upstream PRs after that has been merged, and will add that commits into this one. URL of upstream PRs are as follows.

  • https://github.com/metal3-io/ironic-image/pull/286

Therefore, please pend the review of this PR.

Signed-off-by: Hu Shuai hus.fnst@cn.fujitsu.com

+2 -2

0 comment

1 changed file

pr created time in 11 days

create barnchhs0210/ironic-image

branch : work

created branch time in 11 days

push evenths0210/ansible-collection-for-fos

Hu Shuai

commit sha a5f6c04b49834134bd04758159f81fdfd0cba4c9

del Signed-off-by: Hu Shuai <hus.fnst@cn.fujitsu.com>

view details

push time in 16 days

push evenths0210/fujitsu.fos

Hu Shuai

commit sha 835b330f3ccad761125954efe134025010f72230

Update workflow add ansible 2.12 Run unit tests for all Python versions --> only python 3.9 Signed-off-by: Hu Shuai <hus.fnst@cn.fujitsu.com>

view details

push time in 23 days

PR opened hs0210/dellemc.os10

add ansible 2.11 2.12

Signed-off-by: Hu Shuai hus.fnst@cn.fujitsu.com

+12 -0

0 comment

2 changed files

pr created time in 23 days

create barnchhs0210/dellemc.os10

branch : work

created branch time in 23 days

push evenths0210/fujitsu.fos

Hu Shuai

commit sha 5ff42f00d050e37b38bda923d49fb7237b25b77b

Update workflow add ansible 2.12 Run unit tests for all Python versions --> only python 3.8 Signed-off-by: Hu Shuai <hus.fnst@cn.fujitsu.com>

view details

push time in 23 days

PR opened hs0210/fujitsu.fos

Update workflow

Signed-off-by: Hu Shuai hus.fnst@cn.fujitsu.com

+3 -1

0 comment

1 changed file

pr created time in 23 days

push evenths0210/hello-world

Hu Shuai

commit sha b10ba4bcb452dbcec36600cd9d8535b4f24c9c6b

remove test.txt Signed-off-by: Hu Shuai <hus.fnst@cn.fujitsu.com>

view details

Hu Shuai

commit sha 7f556ea9377c5485391659694e876a214801006e

Modify Jenkinsfile Signed-off-by: Hu Shuai <hus.fnst@cn.fujitsu.com>

view details

Hu Shuai

commit sha bdbfb71fcfbe0b82569563f0010fca325f00b8cb

Merge pull request #16 from hs0210/work Work

view details

push time in 24 days

PR merged hs0210/hello-world

Work
+1 -6

0 comment

2 changed files

hs0210

pr closed time in 24 days

PR opened hs0210/hello-world

Work
+1 -6

0 comment

2 changed files

pr created time in 24 days

push evenths0210/hello-world

Hu Shuai

commit sha 7f556ea9377c5485391659694e876a214801006e

Modify Jenkinsfile Signed-off-by: Hu Shuai <hus.fnst@cn.fujitsu.com>

view details

push time in 24 days

create barnchhs0210/fujitsu.fos

branch : work

created branch time in 24 days

push evenths0210/hello-world

Hu Shuai

commit sha 3bea2c0e24d65e6fbe9d6553ecad3bb7503eebb1

add 2.txt Signed-off-by: Hu Shuai <hus.fnst@cn.fujitsu.com>

view details

Hu Shuai

commit sha dd4c5d2726cf966b65eb2a60aafaae7296e9db07

Merge pull request #14 from hs0210/work Work

view details

Hu Shuai

commit sha 96bef6b54e1ff84a65493955c45be721e52d9ed7

Merge pull request #15 from hs0210/work add 1.txt

view details

Hu Shuai

commit sha b10ba4bcb452dbcec36600cd9d8535b4f24c9c6b

remove test.txt Signed-off-by: Hu Shuai <hus.fnst@cn.fujitsu.com>

view details

push time in 24 days