profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/hjmjohnson/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Hans Johnson hjmjohnson The University of Iowa Iowa City, IA http://www.medicine.uiowa.edu/psychiatry/sinapse/ My research interest involves accelerating discovery through the efficient analysis of large scale, heterogeneous data with modern High Performance Computing.

ANTsX/ANTs 734

Advanced Normalization Tools (ANTs)

HBClab/NiBetaSeries 24

Nipype implementation of BetaSeries Correlations (Beta)

hjmjohnson/DTIPrep 4

DTIPrep

ericpahl/decision-tree-cart 1

Simple implementation of CART algorithm to train decision trees

hjmjohnson/BRAINS4 1

BRAINS4

hjmjohnson/CMake 1

CMake, the cross-platform, open-source build system.

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

push eventhjmjohnson/ITK

Hans Johnson

commit sha ab9ea6cc4cf6e0f088da13d155ad02d4b0112652

ENH: Use language features directly without macro #define ITK_DEPRECATED_MSG(MSG) [[deprecated(MSG)]] #define ITK_NOEXCEPT noexcept

view details

push time in 7 days

push eventhjmjohnson/ITK

Hans Johnson

commit sha 2bc1446efab4e38481b33f8c23272c96278c5938

ENH: Use language features directly without macro #define ITK_DEPRECATED_MSG(MSG) [[deprecated(MSG)]] #define ITK_NOEXCEPT noexcept

view details

push time in 7 days

push eventhjmjohnson/ITK

Dženan Zukić

commit sha 769981b974b458dec052faaf06c9fb1c371b8692

COMP: Update KWStyle's version to avoid compile errors with C++23

view details

Tom Birdsong

commit sha 7f1469270aa34bb885259d9549271880881fa2d6

BUG: Resolve warnings with MakeIndex and MakePoint Resolves nightly exotic build warnings relating to itk::Index and itk::Point initialization by relying on itk::MakeIndex and itk::MakePoint helpers. Build information: Site: RogueResearch7 Build Name: Mac10.11-AppleClang-dbg-x86_64-static Build Time: 2021-07-14 05:03:37 Warnings resolved: warning: suggest braces around initialization of subobject [-Wmissing-braces]

view details

Matt McCormick

commit sha 642d7cf198e3320f55bfb036722b82ded5e2ab1b

Merge pull request #2646 from tbirdso/exotic-warnings

view details

VXL Maintainers

commit sha afa97fa43b523f30c24dad1cb26c35d29c084c49

VXL 2021-07-15 (d8888fd5) Code extracted from: https://github.com/vxl/vxl.git at commit d8888fd569207d21a634bd998401143c714810d5 (master).

view details

Dženan Zukić

commit sha 30e01b44a11a9cd317baf278499429cf3dcd5ec3

Merge branch 'upstream-VXL' into updateVNL # By VXL Maintainers * upstream-VXL: VXL 2021-07-15 (d8888fd5)

view details

Dženan Zukić

commit sha d3e151f09d04830c8ef6ac2f2b104d247ffb99f3

ENH: Remove WriteCompilerDetectionHeader This is a follow-up to and partial reversal of #2464. Closes #2465. We now require C++14, which includes all of the granular C++11 features which used to be detected before.

view details

Niels Dekker

commit sha 558ea67a35eba3a71c2d1766b8f0ebc4b47beb29

STYLE: Remove `Make` functions from itk::GTest::TypedefsAndConstructors Removed the `Make` functions from the namespace `itk::GTest::TypedefsAndConstructors` as they are superseded by: pull request https://github.com/InsightSoftwareConsortium/ITK/pull/2633 commit 8aed68490b733ba45b36b2e8e84e99980db45948 "ENH: Add MakePoint, MakeVector, MakeIndex, MakeSize function templates" Adjusted itkGoogleTest.cxx accordingly.

view details

Dženan Zukić

commit sha 9c0adc4a6d55b94912d70594f35dbf11d5f3ba3f

Merge pull request #2647 from dzenanz/updateVNL

view details

Dženan Zukić

commit sha 9d474f9d2ed9368e0a86616886e79c918585b74e

Merge branch 'cmake320policies'

view details

push time in 7 days

push eventhjmjohnson/ITK

Niels Dekker

commit sha 558ea67a35eba3a71c2d1766b8f0ebc4b47beb29

STYLE: Remove `Make` functions from itk::GTest::TypedefsAndConstructors Removed the `Make` functions from the namespace `itk::GTest::TypedefsAndConstructors` as they are superseded by: pull request https://github.com/InsightSoftwareConsortium/ITK/pull/2633 commit 8aed68490b733ba45b36b2e8e84e99980db45948 "ENH: Add MakePoint, MakeVector, MakeIndex, MakeSize function templates" Adjusted itkGoogleTest.cxx accordingly.

view details

Dženan Zukić

commit sha 9c0adc4a6d55b94912d70594f35dbf11d5f3ba3f

Merge pull request #2647 from dzenanz/updateVNL

view details

Dženan Zukić

commit sha 9d474f9d2ed9368e0a86616886e79c918585b74e

Merge branch 'cmake320policies'

view details

Hans Johnson

commit sha 4082664f2adce8e9eee7ea69524a06b19c53d8fb

ENH: Use language features directly without macro #define ITK_DEPRECATED_MSG(MSG) [[deprecated(MSG)]]

view details

Hans Johnson

commit sha 2a61ccada1060c640c5b80573fa804fe19a7a293

ENH: Use language features directly without macro #define ITK_NOEXCEPT noexcept

view details

Hans Johnson

commit sha f6c2a9c0e5132108aaad183c2cf12bf8ecdecea3

ENH: Use language features directly without macro

view details

push time in 8 days

PullRequestReviewEvent

PR opened InsightSoftwareConsortium/ITK

WIP. Cmake320policies use language directly Extends #2573

This is final completion of work dependant on #2573

+2832 -508

0 comment

45 changed files

pr created time in 8 days

create barnchhjmjohnson/ITK

branch : cmake320policies-use-language-directly

created branch time in 8 days

create barnchBRAINSia/ITK

branch : cmake320policies-use-language-directly

created branch time in 8 days

create barnchBRAINSia/ITK

branch : cmake320policies

created branch time in 8 days

PullRequestReviewEvent

push eventInsightSoftwareConsortium/ITK

Niels Dekker

commit sha 558ea67a35eba3a71c2d1766b8f0ebc4b47beb29

STYLE: Remove `Make` functions from itk::GTest::TypedefsAndConstructors Removed the `Make` functions from the namespace `itk::GTest::TypedefsAndConstructors` as they are superseded by: pull request https://github.com/InsightSoftwareConsortium/ITK/pull/2633 commit 8aed68490b733ba45b36b2e8e84e99980db45948 "ENH: Add MakePoint, MakeVector, MakeIndex, MakeSize function templates" Adjusted itkGoogleTest.cxx accordingly.

view details

push time in 8 days

PR merged InsightSoftwareConsortium/ITK

Reviewers
STYLE: Remove `Make` functions from itk::GTest::TypedefsAndConstructors area:Core type:Style type:Testing

Removed the Make functions from the namespace itk::GTest::TypedefsAndConstructors as they are superseded by:

pull request https://github.com/InsightSoftwareConsortium/ITK/pull/2633 commit 8aed68490b733ba45b36b2e8e84e99980db45948 "ENH: Add MakePoint, MakeVector, MakeIndex, MakeSize function templates"

Adjusted itkGoogleTest.cxx accordingly.

+15 -75

1 comment

2 changed files

N-Dekker

pr closed time in 8 days

PullRequestReviewEvent

push eventBRAINSia/BRAINSTools

Hans Johnson

commit sha c891b91a3baeda5e4473a1209ef5adde8c7f9308

ENH: Updating version to v5.5.0

view details

Hans Johnson

commit sha 13c1c097bf5eac605a87925837fc6d5556844499

ENH: Use modernized oneTBB cmake compatible build oneTBB now supports building with cmake compatible build system!

view details

Hans Johnson

commit sha d51308b9a828ee8954c7c65ddfe53c7f3af9ffb9

BUG: ITK_DIR was not set correctly Need to find the ITKConfig.cmake files from the intenally specified path. Fixes ANTs builds where external ITK was found incorrectly found.

view details

Hans Johnson

commit sha 9df09345c23543a60bdd9cd90b4b784ffb619d06

STYLE: Match ITK style for C++ version support comment

view details

Hans Johnson

commit sha 8d9187b5dfe9f8c931f08b3262a9f4a73b2ca21e

ENH: Update to C++14 support for ITK

view details

Hans Johnson

commit sha b2c90cb9893cededa136711eec80987d8410ba04

ENH: Update to latest TBB build with cmake.

view details

push time in 8 days

PR opened ANTsX/ANTs

Fix mismatch ambiguous size compilation error

Address compilation issues related to updated version of ITK.

ITK is supporting C++14, and tightening implicit conversion ambiguities. These changes affect some coding practices that are not recommended.

+360 -345

0 comment

59 changed files

pr created time in 8 days

push eventANTsX/ANTs

Hans Johnson

commit sha c0620bcedcf34147cc9c3f072b0a09339a2f0fd8

COMPL Place WriteImage function in ANTs namespace The WriteImage function conflicts with the same named itk::WriteImage function. Dis-ambiguate by using the ANTs namespace.

view details

push time in 8 days

PullRequestReviewEvent

Pull request review commentInsightSoftwareConsortium/ITK

ENH: fix Python multi-processing hang on unix

 ThreadPool::~ThreadPool()   } } +void+ThreadPool::atfork_prepare()+{+  printf("In ThreadPool::atfork_prepare");+  m_PimplGlobals->m_ThreadPoolInstance->CleanUp();+}++void+ThreadPool::atfork_resume()+{+  printf("In ThreadPool::atfork_resume");

Debugging comments should be removed.

dzenanz

comment created time in 8 days

Pull request review commentInsightSoftwareConsortium/ITK

ENH: fix Python multi-processing hang on unix

 ThreadPool::~ThreadPool()   } } +void+ThreadPool::atfork_prepare()+{+  printf("In ThreadPool::atfork_prepare");

Debugging comments should be removed.

dzenanz

comment created time in 8 days

PullRequestReviewEvent

create barnchANTsX/ANTs

branch : fix-mismatch-ambiguous-size-compilation-error

created branch time in 8 days

push eventvxl/vxl

Dženan Zukić

commit sha d8888fd569207d21a634bd998401143c714810d5

BUG: fix a crash due to null pointer dereference This would happen in ITK, in Modules\Numerics\Statistics\include\itkGaussianMixtureModelComponent.hxx at line m_Covariance.SetIdentity(); and in a few other places too. See: https://open.cdash.org/viewTest.php?onlyfailed&buildid=7341011 List of tests that Completed (SEGFAULT) copy-pasted here in case of link rot: itkExpectationMaximizationMixtureModelEstimatorTest itkGaussianMixtureModelComponentTest itkImageClassifierFilterTest itkSampleClassifierFilterTest7 The bug was introduced by c6c899aaf9cbf7ccabfca1ba35b2248fb611ffbc.

view details

push time in 8 days

PR merged vxl/vxl

BUG: fix a crash due to null pointer dereference

This would happen in ITK, in Modules\Numerics\Statistics\include\itkGaussianMixtureModelComponent.hxx at line m_Covariance.SetIdentity(); and in a few other places too. See: https://open.cdash.org/viewTest.php?onlyfailed&buildid=7341011 List of tests that Completed (SEGFAULT) copy-pasted here in case of link rot:

itkExpectationMaximizationMixtureModelEstimatorTest itkGaussianMixtureModelComponentTest itkImageClassifierFilterTest itkSampleClassifierFilterTest7

The bug was introduced by c6c899aaf9cbf7ccabfca1ba35b2248fb611ffbc.

+8 -4

1 comment

1 changed file

dzenanz

pr closed time in 8 days

PullRequestReviewEvent

push eventBRAINSia/BRAINSTools

Andras Lasso

commit sha f9b19dc9424122ab95646d71f9dc425d5aed1079

DOC: Update documentation URLs in XML files Slicer module documentation is being moved from Slicer wiki to slicer.readthedocs.io. CLI module descriptor XML files are updated accordingly. Fixed some typos and removed extra spaces to fix automatically generated documentation formatting.

view details

Kian Weimer

commit sha 8b026e003bd029b9ab84bf7f5f8354dca160e93e

ENH: Replaced integer cast rounding methods with built in rounding functions. Using `(int)(double_expression + 0.5)` to round can be inaccurate and slow. Similar usages have been replaced with `lround`. This implements the bugprone-incorrect-roundings clang-tidy check. -"Casting (double + 0.5) to integer leads to incorrect rounding; consider using lround (#include <cmath>) instead"

view details

Kian Weimer

commit sha 8e626c73cb8dee18ce6a33ec5bff10be7a4ebac8

ENH: Surrounded macro replacement arguments with parenthesis. It is recommended to surround macro arguments in the replacement list with parenthesis. This ensures that the argument value is calculated properly. This implements the bugprone-macro-parentheses clang-tidy check. -”Macro argument should be enclosed in parentheses"

view details

Kian Weimer

commit sha 5ff1389845d0ab45045e6a678ea4efbdcd476731

ENH: Converted intervision to float division when used in a float context. In one case, the result of an interger division is stored into a floating point variable. This has been changed to float division to preserve precision. This implements the bugprone-integer-division clang-tidy check. -"Result of integer division used in a floating point context; possible loss of precision"

view details

Hans Johnson

commit sha 2f25fe8cf60446c0a2cd6647aebfaf2a067c7388

ENH: Updating version to v5.5.0

view details

Hans Johnson

commit sha 02b1239b9bcb6786da881af8436a9eec19147a17

ENH: Use modernized oneTBB cmake compatible build oneTBB now supports building with cmake compatible build system!

view details

Hans Johnson

commit sha 004c38283d19aefb7f89200895b4071036c98699

BUG: ITK_DIR was not set correctly Need to find the ITKConfig.cmake files from the intenally specified path. Fixes ANTs builds where external ITK was found incorrectly found.

view details

Hans Johnson

commit sha d5f8de962b8ce8f0bee7f8baf84e8702dae8dfba

STYLE: Match ITK style for C++ version support comment

view details

Hans Johnson

commit sha 7ba2d662ba1848d5839fa07d71f7425a77e7a233

ENH: Update to C++14 support for ITK

view details

Hans Johnson

commit sha 8fcf8038541fbcfab7c363d6c386c2b558ac5fd9

ENH: Update to latest TBB build with cmake.

view details

push time in 9 days

push eventBRAINSia/ITK

Matt McCormick

commit sha 59ed43b1272b038c7095e418cae563387cb2fc0b

ENH: Module configuration exec to import This is a simplication that continues the integration of WrapITK into ITK. The use of `exec` is a security faux pas, and the use of importlib instead helps analysis tools like PyInstaller understand dependencies. The use of WRAPITK_PYTHON_PATH has not been tested or supported since the WrapITK integration and is removed. Base on Python test runtimes, this change is also slightly (1%) faster.

view details

Brad King

commit sha e0cd16a3c57fc0f00dd1d9465fa716044204ea09

ENH: Update to newer third-party update script from CMake Use the CMake `Utilities/Scripts/update-third-party.bash` as of commit `693f4c70ff`. Manually preserve ITK's change from commit 5dccc2207e (BUG: Do not gpg sign third party updates, 2018-11-19, v5.0b02~82^2~1).

view details

KWSys Upstream

commit sha 84dc94c226591fad842bf3e8e5baa666bf3d461a

KWSys 2021-02-10 (dda7a943) Code extracted from: https://gitlab.kitware.com/utils/kwsys.git at commit dda7a943856ad22e374a9b0434727285461770a6 (master). Upstream Shortlog ----------------- Change-Id: I5f5512038564cee939bd703e9b7b5350e4d82525

view details

Sean McBride

commit sha 8b21c336d8ce057fd6df42dabce25d8b822d5b66

Merge branch 'upstream-KWSys' into update-kwsys-2021-02-10 # By KWSys Upstream * upstream-KWSys: KWSys 2021-02-10 (dda7a943)

view details

Matt McCormick

commit sha 3cef6d4ff58c6ba38da93d48418114756bdb1328

Merge pull request #2291 from bradking/update-third-party ENH: Update to newer third-party update script from CMake

view details

Dženan Zukić

commit sha 2cdc2b402673d3b4fc74225d1a220760e8d5ebbd

ENH: supporting multi-channel tensors as inputs and outputs in Python

view details

Dženan Zukić

commit sha 41f4951f6b84cf8e24fe7e4fc7e8ec05f65d9f9d

Merge remote-tracking branch 'remotes/bradking/update-third-party'

view details

Dženan Zukić

commit sha 58d757c4afa7cf707e0063ae89c95f784de0d7f9

ENH: use master branch of GoogleTest until a stable version is released

view details

GoogleTest Upstream

commit sha 2ad0bea3c24174a426a807d2a540a71ada5581d8

GoogleTest 2021-02-05 (f3ef7e17) Run the UpdateFromUpstream.sh script to extract upstream GoogleTest using the following shell commands. $ git archive --prefix=upstream-googletest/ f3ef7e17 -- CMakeLists.txt googletest/CMakeLists.txt googletest/cmake googletest/src googletest/include | tar x https://github.com/google/googletest/compare/703bd9caab50b139428cea1aaff9974ebee5742e...f3ef7e173fd0853069f16c4b5afc7e80a350604b Change-Id: Ia788d70f8e926f7c5d1141d96e550e9909b8fa6b

view details

Dženan Zukić

commit sha 214be5ec49a80f5812c02f65e818f9cdcac424c5

Merge branch 'upstream-googletest' into updateGTest

view details

Dženan Zukić

commit sha bddc08cede051aa6ae962f6a42defde00063d228

ENH: manually update minimum CMake version to 2.8.12 to avoid warning CMake Deprecation Warning at Modules/ThirdParty/GoogleTest/src/itkgoogletest/CMakeLists.txt:4 (cmake_minimum_required): Compatibility with CMake < 2.8.12 will be removed from a future version of CMake. CMake Deprecation Warning at Modules/ThirdParty/MINC/src/libminc/CMakeLists.txt:25 (CMAKE_MINIMUM_REQUIRED): Compatibility with CMake < 2.8.12 will be removed from a future version of CMake.

view details

Matt McCormick

commit sha 35d3e2d8642d7dd74cfbd03e2ceb0e90f0c0f3f9

Merge pull request #2166 from dzenanz/multiChannelTensors

view details

Matt McCormick

commit sha 05861bdedac504891f3cc5247876df2d5fe3e8bb

Merge pull request #2292 from seanm/update-kwsys-2021-02-10

view details

Matt McCormick

commit sha 0353b17f36a18254a9779687b8673a0f48155117

Merge branch 'release'

view details

Matt McCormick

commit sha 2e4cb2670538ce3befe4a0e7dd35752ab2290f19

ENH: xarray_from_image "c" coords uint32 type uint64 is unnecessary and in a JavaScript environment is not currently supported on the Safari browser.

view details

Sean McBride

commit sha 1562d26709c4d3100365f5305a43b584f2215e82

COMP: Remove prohibition against building Universal Binaries on macOS Cherry picked f1b469d16026973ace04e05bd4d2f3325660fac2 from HDF5

view details

Sean McBride

commit sha f5fd16e68a6de32047d4140f71ec58aef05283eb

DOC: Removed obsolete readme info regarding updating HDF5

view details

Matt McCormick

commit sha 7585cc3375149d1159e9c2dc9e2b0eec104ef36e

Merge pull request #2296 from seanm/release-HDF5-universal-binary

view details

Sean McBride

commit sha f9610760bf0afcfccb92f996bfbff16d6eb5ad99

COMP: remove invalid double underscore usage Changed: __itk_control_word to: _itk_control_word

view details

Matt McCormick

commit sha 1dfb661325bd7b2f56a128e31c2888db810abb97

Merge pull request #2295 from thewtex/coords-32-bit-int ENH: xarray_from_image "c" coords uint32 type

view details

push time in 9 days

push eventBRAINSia/BRAINSTools

Kian Weimer

commit sha 5ff1389845d0ab45045e6a678ea4efbdcd476731

ENH: Converted intervision to float division when used in a float context. In one case, the result of an interger division is stored into a floating point variable. This has been changed to float division to preserve precision. This implements the bugprone-integer-division clang-tidy check. -"Result of integer division used in a floating point context; possible loss of precision"

view details

push time in 10 days