profile
viewpoint

microsoft/pyright 5391

Static type checker for Python

microsoft/sarif-sdk 61

.NET code and supporting files for working with the 'Static Analysis Results Interchange Format' (SARIF, see https://github.com/oasis-tcs/sarif-spec)

heejaechang/arcade 0

Tools that provide common build infrastructure for multiple .NET Foundation projects.

heejaechang/AspNetCore-Tooling 0

Tools for ASP.NET Core apps, such as MSBuild targets, Visual Studio extensions, and command line tools. (Open issues on https://github.com/aspnet/AspNetCore/issues)

heejaechang/docs 0

This repository contains .NET Documentation.

heejaechang/dotnet-ci 0

Repository containing scripting for the dotnet-ci Jenkins instance.

heejaechang/format 0

Home for the dotnet-format command

heejaechang/libopenshot 0

This repo is the primary development home for libopenshot. OpenShot Library (libopenshot) is an open-source project dedicated to delivering high quality video editing, animation, and playback solutions to the world. API currently supports C++, Python, and Ruby.

heejaechang/libopenshot-audio 0

This repo is the primary development home for libopenshot-audio. OpenShot Audio Library (libopenshot-audio) is a program that allows the high-quality editing and playback of audio, and is based on the amazing JUCE library.

heejaechang/omnisharp-roslyn 0

OmniSharp based on roslyn workspaces

issue commentmicrosoft/pylance-release

Go to symbol in Workspace very slow and lists non-workspace objects

should "go to symbol" index libraries as well?

robintw

comment created time in 2 days

issue commentmicrosoft/pylance-release

Auto-import doesn't work

it depends, for example, if you have 2 files open, and one of the files have gc used, then completion will have "gc" in the other file. if you have "import statement" in a current file that implicitly imports "gc", then "gc" will show up in completion.

otherwise, completion could have too many entries from all library files accessible from the current file. currently, code action can be used for this situation, and then related libraries will start to show up in auto import.

but that being said, we can improve auto-import behavior based on feedbacks.

imankulov

comment created time in 2 days

issue commentmicrosoft/pylance-release

Docstrings

so, I see signature help shows doc string. since you didn't try hover, I am not sure about hover. so I guess you are talking about completion?

for completion tooltip, can you give a pause after typing T or meth so that vscode doesn't cancel tooltip out before it showing it?

Samrose-Ahmed

comment created time in 2 days

issue commentmicrosoft/pylance-release

Auto-import doesn't work

unlike code action, since auto import shows up in completion list, we try not to include all possible identifiers in the completion. we only show ones already have used. we could tweak this behavior. but that is our current behavior.

that being said, we can improve code action to show it at the identifier edges.

imankulov

comment created time in 2 days

issue commentmicrosoft/pylance-release

Docstrings

FYI, you can see docstrings shows up, completion, signature help, hover

docstring

Samrose-Ahmed

comment created time in 4 days

issue commentmicrosoft/pylance-release

Improve auto import for common abbreviations

just FYI, abbr is not supported in auto-import, but code action supports those.

abbr

MarcSkovMadsen

comment created time in 4 days

fork heejaechang/pylance-release

Documentation and issues for Pylance

fork in 4 days

issue commentmicrosoft/pyright

Cannot find module 'worker_threads' in v1.1.46

let me make "IsMainThread" to be indirect so that people can use it without requiring worker_thread.

Borda

comment created time in 8 days

PR opened microsoft/pyright

added more logging and fixed hover bug
+422 -499

0 comment

9 changed files

pr created time in 9 days

push eventheejaechang/pyright

HeeJae Chang

commit sha 24cd043ac318a6943ddbde1352035c350b0be335

added more logging and fixed hover bug

view details

push time in 9 days

create barnchheejaechang/pyright

branch : latest625

created branch time in 9 days

issue commentmicrosoft/pyright

Consider supporting "PYTHONCASEOK"

tagging @MikhailArkhipov

heejaechang

comment created time in 19 days

issue commentmicrosoft/pyright

Consider supporting "PYTHONCASEOK"

opened a request based on some question from @MikhailArkhipov

heejaechang

comment created time in 22 days

issue openedmicrosoft/pyright

Consider supporting "PYTHONCASEOK"

Is your feature request related to a problem? Please describe. supporting PEP 235 (https://www.python.org/dev/peps/pep-0235/) on import errors.

Describe the solution you'd like looking at code, it looks like implementation always try to preserve casing from file system and let file system decides case sensitive-ness when finding modules (file name, folder name). if pyright supports, PEP 235, it probably need some way to treat case sensitive file system like case insensitive so it can find import name with different casing.

created time in 22 days

issue commentmicrosoft/vscode-languageserver-node

WorkDoneProgressServerReporter not exported

tagging @dbaeumer

heejaechang

comment created time in 24 days

issue openedmicrosoft/vscode-languageserver-node

WorkDoneProgressServerReporter not exported

it looks like WorkDoneProgressServerReporter is not exported. only WorkDoneProgressReporter is exported even if createWorkDoneProgress return ServerReporter.

created time in 24 days

issue openedmicrosoft/pyright

reported diagnostic span is wrong

Describe the bug sometimes, usually the very first time, squiggle span (diagnostic span) on an identifier is 1 off.

To Reproduce paste this code in latest pyright

a = pd

see squiggle image

Expected behavior span should cover whole identifier "pd"

VS Code extension or command-line extension

created time in a month

fork heejaechang/winget-cli

Windows Package Manager CLI (aka winget)

fork in a month

startedmicrosoft/winget-cli

started time in a month

startedmicrosoft/PowerToys

started time in a month

fork heejaechang/PowerToys

Windows system utilities to maximize productivity

fork in a month

issue openedmicrosoft/pyright

auto importing exposing "lib.site-packages"

Describe the bug See this test "https://github.com/microsoft/pyright/blob/master/server/src/tests/fourslash/completions.autoimport.Lib.Found.duplication.fourslash.ts#L36" for more detail.

Basically, when auto import adding a module, in a certain condition, it exposes lib.site-packages.

To Reproduce See the test above for repro steps

Expected behavior Rather than "from lib.site-packages import xxx", it should just add "import xxx"

Screenshots or Code

VS Code extension or command-line vscode extensions

created time in 2 months

push eventmicrosoft/pyright

Heejae Chang

commit sha 8e32a2d345f9cc8974596c230a6d24a9e9a32bbd

Introduced UnboundVariable and UndefinedVariable diagnostic rules and refactored auto import and add tests (#663)

view details

push time in 2 months

PR merged microsoft/pyright

Introduced UnboundVariable and UndefinedVariable diagnostic rules and…

… refactored "auto import" code.

Also, unit tests covering auto imports are added.

+636 -232

1 comment

24 changed files

heejaechang

pr closed time in 2 months

pull request commentmicrosoft/pyright

Introduced UnboundVariable and UndefinedVariable diagnostic rules and…

will check in once test passes.

heejaechang

comment created time in 2 months

PR opened microsoft/pyright

Introduced UnboundVariable and UndefinedVariable diagnostic rules and…

… refactored "auto import" code.

Also, unit tests covering auto imports are added.

+636 -232

0 comment

24 changed files

pr created time in 2 months

push eventheejaechang/pyright

HeeJae Chang

commit sha ed2d925d2c44ee8377f17a62ecc17d5ba42c475a

Introduced UnboundVariable and UndefinedVariable diagnostic rules and refactored auto import and add tests

view details

push time in 2 months

create barnchheejaechang/pyright

branch : autoImport

created branch time in 2 months

push eventmicrosoft/pyright

Heejae Chang

commit sha 714b5acef134d433c427ffb2d32258d80add3c5c

prevent rename from changing library code (#647)

view details

push time in 2 months

PR merged microsoft/pyright

prevent rename from changing library code

changes also have some refactorings and unit tests as well.

+626 -143

0 comment

20 changed files

heejaechang

pr closed time in 2 months

PR opened microsoft/pyright

prevent rename from changing library code
+626 -143

0 comment

20 changed files

pr created time in 2 months

push eventheejaechang/pyright

HeeJae Chang

commit sha b64cd348aa44eab2cf31f72e6773695019db055e

prevent rename from changing library code

view details

push time in 2 months

create barnchheejaechang/pyright

branch : renameLibrary

created branch time in 2 months

issue openedmicrosoft/pyright

renaming third party code/typestubs

Describe the bug rename sometime changes third party or typestub code

To Reproduce a.py

from testLib1 import Test1 as t1

a = t1()

testLib1/init.py

class Test1:
    pass

rename t1 to t2.

Expected behavior only t1 is renamed to t2.

but Test1 is also renamed to t2.

VS Code extension or command-line latest pyright on vscode extension

Additional context renaming t1 to t2 affecting Test1 is also a bug. but Test1 ever changed by rename seems to be another bug. rename should not ever change code in third party library or typestub.

created time in 2 months

issue openedmicrosoft/pyright

renaming import alias changes typename as well

Describe the bug renaming import alias changes type name as well

To Reproduce

from testLib1 import Test1 as t1

a = t1()

rename t1 to t2 at t1()

Expected behavior t1 on import statement and t1 on t1() is renamed to t2

VS Code extension or command-line latest pyright extension on vscode

Additional context if I do "FAR" on t1, it finds this

image

it looks like code doesn't distinguish alias symbol with actual symbol it is aliasing.

created time in 2 months

push eventmicrosoft/pyright

Heejae Chang

commit sha dfa5dc39d2945096bc34528f952717cb30a8c0c3

fix crash due to exception on bg and etc (#634) this PR also includes changes where we set completion as completion after a few characters once completion is up

view details

push time in 2 months

PR merged microsoft/pyright

fix crash due to exception on bg and etc

this PR also includes changes where we set completion as completion after a few characters once completion is up

+32 -7

0 comment

2 changed files

heejaechang

pr closed time in 2 months

PR opened microsoft/pyright

fix crash due to exception on bg and etc

this PR also includes changes where we set completion as completion after a few characters once completion is up

+32 -7

0 comment

2 changed files

pr created time in 2 months

push eventheejaechang/pyright

HeeJae Chang

commit sha 9ee51ec30a192a4d553a760b0722e7d796d1b748

fix crash due to exception on bg and etc this PR also includes changes where we set completion as completion after a few characters once completion is up

view details

push time in 2 months

create barnchheejaechang/pyright

branch : fixCrash

created branch time in 2 months

issue commentmicrosoft/pyright

"A request has failed" in VS Code extension

Let me make it not to crash first.

letmaik

comment created time in 2 months

issue commentmicrosoft/vscode

proper support of cancellation in resolveCompletionItem

I see. probably due to "https://github.com/microsoft/vscode-languageserver-node/issues/615" not returning error but return item.

it just got fixed, so that might be the root cause then.

heejaechang

comment created time in 2 months

issue commentmicrosoft/vscode

proper support of cancellation in resolveCompletionItem

hmmm.. code seems changed. it now uses await rather than .then(...)

the code I shared used ".then" without error handling part. with await, I guess as long as resolveCompletionItem promise reject, things will work as expected?

https://github.com/microsoft/vscode/commit/8f1b2e565797929d8e8fd772ed35fa202ac76567#diff-bf62e0eff390ee2bc5596fbc5b6bf2e7L904

heejaechang

comment created time in 3 months

issue commentmicrosoft/vscode-languageserver-node

cancellation support on resolver

root cause - https://github.com/microsoft/vscode/issues/95485

heejaechang

comment created time in 3 months

issue openedmicrosoft/vscode

proper support of cancellation in resolveCompletionItem

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->

  • VSCode Version: 1.44.0
  • OS Version: 1909

Steps to Reproduce:

  1. install python 3.7+
  2. python -m pip install pandas
  3. clone https://github.com/microsoft/pyright
  4. open vscode with pyright repo root
  5. run "pyright client"
  6. type "import pandas as pd"
  7. in next line, type "pd.read_c"
  8. wait tooltip for read_csv from completion list
  9. while it is calculating (resolveCompletionItem call), move to other completion item causing resolveCompletionItem call to be cancelled.

<!-- Launch with code --disable-extensions to check. --> Does this issue occur when all extensions are disabled?: No

..

issue seems with this code https://github.com/microsoft/vscode/blob/master/src/vs/workbench/api/common/extHostLanguageFeatures.ts#L889

this resolveCompletionItem call seems to not handle cancellation properly. so even if cancellation happened, it just take whatever result it got and cache it causing until next (new) completion list, tooltip is lost for one that got cancelled.

created time in 3 months

issue commentmicrosoft/vscode-languageserver-node

cancellation support on resolver

hmm.. lsp seems handling it correctly, but it is vscode ignoring error call..

heejaechang

comment created time in 3 months

issue openedmicrosoft/vscode-languageserver-node

cancellation support on resolver

resolver has cancellation token but if that cancellation is reported, then lsp client hold onto wrong information.

https://github.com/microsoft/vscode-languageserver-node/blob/master/client/src/client.ts#L1530

basically, if the given error is cancellation, client.logFailedXXX will skip logging, and return original item back causing client to cache that item and cancellation is silently ignored.

after that, client will never ask back that completion item leaving completion in broken state.

I think lsp should properly handle cancellation.

created time in 3 months

PR merged microsoft/pyright

Reviewers
moving analysis to background thread and add cancellation support and…

… etc

tagging @MikhailArkhipov

+1494 -407

0 comment

27 changed files

heejaechang

pr closed time in 3 months

push eventmicrosoft/pyright

Heejae Chang

commit sha 385d89eb6c9668881dd134e50580ebc49f828c7c

moving analysis to background thread and add cancellation support and etc (#624)

view details

push time in 3 months

create barnchheejaechang/pyright

branch : background

created branch time in 3 months

issue openedmicrosoft/vscode-js-debug

"Node debugging auto-attaches to all Node sub-processes" seems not working

I tried the latest js-debug (https://marketplace.visualstudio.com/items?itemName=ms-vscode.js-debug-nightly&ssr=false#overview) with this repo (https://github.com/microsoft/pyright)

ran "Pyright Language Client" and expected all node processes to be automatically attached. but it didn't.

that's fine, so I attached to the server node manually using "Pyright Language Server" launch config. that worked. but it didn't show worker_threads (nodejs).

that seems to be another bug? or am I doing something wrong?

created time in 3 months

push eventheejaechang/vscode-python

HeeJae Chang

commit sha c131cad05d0087d19b8f7a7f46923a1456e2f596

fix wrong formatting

view details

push time in 3 months

Pull request review commentmicrosoft/vscode-python

Add cancellation support to node based python LS server

+/*+ * cancellationUtils.ts+ * Copyright (c) Microsoft Corporation.+ * Licensed under the MIT license.+ *+ * Helper methods around cancellation+ */++import { randomBytes } from 'crypto';+import * as fs from 'fs';+import * as os from 'os';+import * as path from 'path';+import {+    MessageConnection,+    CancellationReceiverStrategy,+    CancellationSenderStrategy,+    CancellationStrategy,+    Disposable

and I need the skip news label stuff?

heejaechang

comment created time in 3 months

Pull request review commentmicrosoft/vscode-python

Add cancellation support to node based python LS server

+/*+ * cancellationUtils.ts+ * Copyright (c) Microsoft Corporation.+ * Licensed under the MIT license.+ *+ * Helper methods around cancellation+ */++import { randomBytes } from 'crypto';+import * as fs from 'fs';+import * as os from 'os';+import * as path from 'path';+import {+    MessageConnection,+    CancellationReceiverStrategy,+    CancellationSenderStrategy,+    CancellationStrategy,+    Disposable

will do.

heejaechang

comment created time in 3 months

pull request commentmicrosoft/vscode-python

Add cancellation support to node based python LS server

@karthiknadig can you take a look?

heejaechang

comment created time in 3 months

push eventheejaechang/vscode-python

Don Jayamanne

commit sha f8f9b86508d5fe8c034bb210dc99fc74e4d165ae

Revert "Remove ipywidgets (#9253)" (#9751) This reverts commit 43d30fddc2ea6e65513898e551d427967c3282b1. For #3429

view details

Don Jayamanne

commit sha 164727a4e989d2f53778338ce04f55f5fad9ecec

Add support for ipywidgets (#10606) * Widgets * Fixes * Misc * Crap * Include requirejs

view details

Don Jayamanne

commit sha d4c3132475805a0cd4104200c6a2d9a08460faff

Add ipywidget deps to main package.json and update builds(#10615)

view details

Don Jayamanne

commit sha 6141edb50d8e6c3e8a47e5fc814e8b684902950c

Fixes a few linter and compiler issues (#10616)

view details

Don Jayamanne

commit sha 3c6f0091f41befcf57c2a72f6c277262c8de578d

Hide raw text if output is an ipywidget (#10620)

view details

Don Jayamanne

commit sha 40e0bda93861e900a88c942a635f804b849dff58

Merge branch 'master' into ds/ipyWidgets * master: Fix merge issue Move redux logging to a different file (#10605) Disable custom editor API (#10604) Ensure local host only if connection not available (#10600) Delegate management of notebooks (creation and disposing) to I… (#10568) Refactor to accommodate upstream VSCode API changes (#10569) Use a single notebook beetween multiple native editors (#10514) Add support for synchronising edits between two nb editors of… (#10189) Fix tests in ds/custom_editor branch (#10512) Fix linter Reimplement custom editor using new API

view details

Don Jayamanne

commit sha 265cb61f98efed5fc896816366b3b01a59506349

Add support for moving/collapsing cells with ipywidget output (#10624) * Support collpasing/moving ipywidget output cells * Fix

view details

Don Jayamanne

commit sha 739f8c0c73c735bb4726b368aa6adc0913eee8ac

Remove post office methods from root state (#10627)

view details

Don Jayamanne

commit sha d95970f52b22d670b30d6a7a0794584c70e5fd3d

Ensure functional tests run even without ipywidgets (#10628)

view details

Rich Chiodo

commit sha fd8fab29879b6be3f55b5bc00c7acc9a4f5879f6

Rework notebook startup to be in the INotebookProvider (#10642) * Initial concept building * Disable UI for progress too * Fix functional tests * Fix hygiene * Review feedback * Fix hygiene * Fix unit tests * Fix sonar bug

view details

Rich Chiodo

commit sha 3eedc2137037b21a22f34baa10e46dcb47fbef35

Get ipywidgets working everywhere (#10653)

view details

Don Jayamanne

commit sha b248deb4e1181910f77f9d990cce4b0c639b416d

Add ability to DS notebook tests within a headless browser (#10657) * Add ability to launch DS ui in browser in tests * Address code review comments * Dump screenshots in temp dir * Ignore windows * Additional launch config * Added comments

view details

Don Jayamanne

commit sha aaae5ca80d29f09512d95d8505131478d002d961

Merge branch 'master' into ds/ipyWidgets * master: Turning new debugger experiment on for all users and reload experiment for 20% of users (#10674) Disable blank issues (#10678) update mockito and minor test updates (#10671) Fix save on old editor (#10665) Job names were invalid (#10646) Telemetry updates (#10631) Remote session shutdownAll is killing all sessions (#10621)

view details

Don Jayamanne

commit sha 9fd67d3bed3fb40e6d604fa4e18adaf8c5c0bb31

Add basic UI tests for notebook (with ipywidgets) (#10675) * Added some basic UI tests for notebook * Added a simple widget test * News * Rename * Oops * More tests

view details

Don Jayamanne

commit sha 702c8ce2b45e46beb4947c95cdab6b7c6511cfda

Ensure ipywidgets are synced between editors (#10717) * Ensure ipywidgets are synced between editors * Address code review comments * Refactor

view details

Don Jayamanne

commit sha 239f516e59db24f4319b36712c15b82cc89e5679

Lazyload jupyter services (#10724)

view details

Don Jayamanne

commit sha 89aa7032edaa69dfd5f13bea8e1edaaae82c4f53

Add more UI widget tests for ipywidgets (#10735) * Add more tests * ipyvolume and pythreejs tests

view details

Don Jayamanne

commit sha e1b4e671720392aea61ac6b6fb14fd3b7ba9e74f

White background for output cells with ipywidgets (#10750) For #9517

view details

Don Jayamanne

commit sha 3e8761b3bdb625961af65527d4566d2c42a47f29

Add ability to run record and reply DS UI tests without real j… (#10748) * Add ability to run UI tests without real jupyter

view details

Don Jayamanne

commit sha f5cef34aca5c5b28c6f36494993ae8bbd677c840

Add ui tests for beakerx and bqplot widgets (#10755) * Add ui tests for beakerx and bqplot widgets * Bug fixes

view details

push time in 3 months

issue commentmicrosoft/vscode

Add an API to mark specific signature help parameters as active, replace top-level activeParameter

current protocol looks like it assumes there will be only 1 signature that matches what user is writing and supposed to set that signature as active signature and use active parameter only for active signature.

meaning, if users uses up and down key to cycle through signatures, it should not use active parameter info except the active signature (no highlight except active signature in another word)

but current behavior seems a bit off since it uses active parameter info for other signatures making it to highlight wrong parameters.

and that seems like a bug that needed to be fixed.

..

now, a feature request. when user is typing, it is very common the partially written code is ambiguous and could be matched to multiple signatures. so rather than having just one active signatures, it feels like we should have multiple active signature candidates with its own active parameter. and when user cycle through signatures, editor highlight possible matching signatures and active parameters on those signatures among all signatures.

how it gets actually implemented or added to protocol is implementation detail, but the experience seems to be something can be considered?

jakebailey

comment created time in 3 months

pull request commentmicrosoft/vscode-python

moved vscode-languageclient/server to latest released version (client - 6.1.3, server - 6.1.1)

@karthiknadig I don't have access to check this in? can you merge it for me?

heejaechang

comment created time in 3 months

issue commentmicrosoft/vs-streamjsonrpc

support new CancellationStrategy capability added to vscode-jsonrpc in StreamjsonRpc

Ya. we need this to connect our python language server to VS. I will talk to Tina on LanguageClient part.

heejaechang

comment created time in 3 months

more