profile
viewpoint
Hennadii Stepanov hebasto Bitcoin Core Ukraine https://bitcoincore.org/ gpg:D1DBF2C4B96F2DEBF4C16654410108112E7EA81F donate:bc1qmec89kth5f8j0d2ee8fk4whnk8w75xlfjpdhjc (please note that GitHub Sponsors is not available in Ukraine)

hebasto/bitcoin 5

Bitcoin Core integration/staging tree

hebasto/bitcoin-donations 2

Support bitcoin developers so they can focus on building our future.

hebasto/bips 0

Bitcoin Improvement Proposals

hebasto/bitcoin-config-help 0

The output of ./configure --help

hebasto/bitcoin-core-guix-builds 0

Bitcoin Core Guix Builds

hebasto/bitcoin-core-notes 0

The Bitcoin Core Developer Notes

hebasto/bitcoin-transaction-explorer 0

Simple and pure block explorer you can run on top of a full node

hebasto/bitcoinbook 0

Mastering Bitcoin 2nd Edition - Programming the Open Blockchain

hebasto/docs 0

External documentation related to Bitcoin Core

pull request commentbitcoin-core/gui

Add direction and type columns to peers window

https://github.com/jonatack/gui/compare/add-peers-dir-and-type-columns...luke-jr:tmp_gui_peers_dir_arrows is now translation-friendly...

I'm still weak concept nack on inbound/outbound as strings in the table. I think it's worse than the status quo, so would rather this not be merged as-is.

jonatack

comment created time in an hour

pull request commentbitcoin-core/gui

Do not block GUI thread in RPCConsole

ACK 38efc5a11294ac56a9a098139813b94faf3979e9, Tested on macOS 11.1 with Qt 5.15.2

Confirming that I can replicate the bug described in #53 on master.

Confirming that this PR allows me to shutdown the GUI right after calling gettxoutsetinfo both in the Console Window and through bitcoin-cli gettxoutsetinfo after running the GUI with the -server option.

Confirming that I can replicate the issue laid out by @jonasschnelli comment about generate. There is no longer a generate command available in the Console Window, instead I replicated with bitcoin-cli -generate 10000 after running bitcoin-qt with -server. But, this bug is meant to be fixed by #123.

hebasto

comment created time in an hour

pull request commentbitcoin-core/gui

Add direction and type columns to peers window

Something I didn't get to yet - was to separate the uncomment and give it its own column. This could be very useful for some other ideas Ive been thinking about.

jonatack

comment created time in 2 hours

pull request commentbitcoin-core/gui

Add direction and type columns to peers window

I propose that further refinements be done in a follow-up (not by me ;).

jonatack

comment created time in 3 hours

pull request commentbitcoin-core/gui

Add direction and type columns to peers window

This current PR with 2 ACKs is my preferred version among the various proposals I have seen.

jonatack

comment created time in 3 hours

pull request commentbitcoin-core/gui

Add direction and type columns to peers window

@jonatack @hebasto

This worked for me...

https://github.com/bitcoin-core/gui/pull/135/files#diff-e721b02fefce2a90ae95da0841adfdcc610ffccf93236ef236f81c1baead8e01R163

Most of the issues you may run into - I already figured out...

https://github.com/bitcoin-core/gui/pull/135

jonatack

comment created time in 3 hours

push eventbitcoin-core/gui

William Casarin

commit sha 933ab8a720cb9b3341adec4109cffb6dc5b322a5

build: detect sys/sdt.h for eBPF tracing

view details

William Casarin

commit sha 22eb7930a6ae021438aa0b8e750170534944f296

tracing: add tracing framework Signed-off-by: William Casarin <jb55@jb55.com>

view details

Wladimir J. van der Laan

commit sha 43f3ada27b835e6b198f9a669e4955d06f5c4d08

Merge #19866: eBPF Linux tracepoints 22eb7930a6ae021438aa0b8e750170534944f296 tracing: add tracing framework (William Casarin) 933ab8a720cb9b3341adec4109cffb6dc5b322a5 build: detect sys/sdt.h for eBPF tracing (William Casarin) Pull request description: Instead of writing ad-hoc logging everywhere (eg: #19509), we can take advantage of linux user static defined traces, aka. USDTs ( not the stablecoin :sweat_smile: ) The linux kernel can hook into these tracepoints at runtime, but otherwise they have little to no performance impact. Traces can pass data which can be printed externally via tools such as bpftrace. For example, here's one that prints incoming and outgoing network messages: # Examples ## Network Messages ``` #!/usr/bin/env bpftrace BEGIN { printf("bitcoin net msgs\n"); @start = nsecs; } usdt:./src/bitcoind:net:push_message { $ip = str(arg0); $peer_id = (int64)arg1; $command = str(arg2); $data_len = arg3; $data = buf(arg3,arg4); $t = (nsecs - @start) / 100000; printf("%zu outbound %s %s %zu %d %r\n", $t, $command, $ip, $peer_id, $data_len, $data); @outbound[$command]++; } usdt:./src/bitcoind:net:process_message { $ip = str(arg0); $peer_id = (int64)arg1; $command = str(arg2); $data_len = arg3; $data = buf(arg3,arg4); $t = (nsecs - @start) / 100000; printf("%zu inbound %s %s %zu %d %r\n", $t, $command, $ip, $peer_id, $data_len, $data); @inbound[$ip, $command]++; } ``` $ sudo bpftrace netmsg.bt output: https://jb55.com/s/b11312484b601fb3.txt if you look at the bottom of the output you can see a histogram of all the messages grouped by message type and IP. nice! ## IBD Benchmarking ``` #!/usr/bin/env bpftrace BEGIN { printf("IBD to 500,000 bench\n"); } usdt:./src/bitcoind:CChainState:ConnectBlock { $height = (uint32)arg0; if ($height == 1) { printf("block 1 found, starting benchmark\n"); @start = nsecs; } if ($height >= 500000) { @end = nsecs; @duration = @end - @start; exit(); } } END { printf("duration %d ms\n", @duration / 1000000) } ``` This one hooks into ConnectBlock and prints the IBD time to height 500,000 starting from the first call to ConnectBlock Userspace static tracepoints give lots of flexibility without invasive logging code. It's also more flexible than ad-hoc logging code, allowing you to instrument many different aspects of the system without having to enable per-subsystem logging. Other ideas: tracepoints for lock contention, threads, what else? Let me know what ya'll think and if this is worth adding to bitcoin. ## TODO - [ ] docs? - [x] Integrate systemtap-std-dev/libsystemtap into build (provides the <sys/sdt.h> header) - [x] ~dtrace macos support? (is this still a thing?)~ going to focus on linux for now ACKs for top commit: laanwj: Tested ACK 22eb7930a6ae021438aa0b8e750170534944f296 0xB10C: Tested ACK 22eb7930a6ae021438aa0b8e750170534944f296 Tree-SHA512: 69242242112b679c8a12a22b3bc50252c305894fb3055ae6e13d5f56221d858e58af1d698af55e23b69bdb7abedb5565ac6b45fa5144087b77a17acd04646a75

view details

push time in 3 hours

push eventbitcoin-core/gui

Andrew Chow

commit sha 42bb1ea363286b088257cabccb686ef1887c1d3b

gitian: install signapple in gitian-osx-signer.yml

view details

Andrew Chow

commit sha 95b06d21852b28712db6c710e420a58bdc1a0944

gitian: use signapple to apply the MacOS code signature

view details

Andrew Chow

commit sha f55eed251488d70d5e2e3a2965a4f8ec0c476853

gitian: use signapple to create the MacOS code signature

view details

Andrew Chow

commit sha 2c403279e2f0f7c8c27c56d4e7b0573c59571f0a

gitian: Remove codesign_allocate and pagestuff from MacOS build

view details

Wladimir J. van der Laan

commit sha f7fd76bcc0f55e4bc0d3cafd69bab4a56e882973

Merge #20880: gitian: Use custom MacOS code signing tool 2c403279e2f0f7c8c27c56d4e7b0573c59571f0a gitian: Remove codesign_allocate and pagestuff from MacOS build (Andrew Chow) f55eed251488d70d5e2e3a2965a4f8ec0c476853 gitian: use signapple to create the MacOS code signature (Andrew Chow) 95b06d21852b28712db6c710e420a58bdc1a0944 gitian: use signapple to apply the MacOS code signature (Andrew Chow) 42bb1ea363286b088257cabccb686ef1887c1d3b gitian: install signapple in gitian-osx-signer.yml (Andrew Chow) Pull request description: The MacOS code signing issues that were encountered during the 0.21.0 release cycle have shown that it is necessary for us to use a code signing tool for which the source code is available and modifiable by us. Given that there appears to not be such a tool available, I have written such a tool, [signapple](https://github.com/achow101/signapple), that we can use. This tool is able to create a valid MacOS code signature, detach it in a way that we were doing previously, and attach it to the unsigned binary. This tool can also verify that the signature is correct. This PR implements the usage of that tool in the gitian build for the code signed MacOS binary. The code signer will use this tool to create the detached signature. Gitian builders will use this tool to apply the detached signature. The `gitian-osx-signer.yml` descriptor has been modified to install this tool so that the `detached-sig-apply.sh` script can use it. Additionally, the `codesign_allocate` and `pagestuff` tools are no longer necessary so they are no longer added to the tarball used in code signing. Lastly, both the `detached-sig-create.sh` and `detached-sig-apply.sh` scripts are made to be significantly less complex and to not do unexpected things such as unpacking an already unpacked tarball. The detached code signature that signapple creates is almost identical to that which we were previously creating. The only difference is that the cpu architecture name is included in the extension (e.g. we have `bitcoin-qt.x86_64sign` instead of `bitcoin-qt.sign`). This was done in order to support signing universal binaries which we may want to do in the future. However signapple can still apply existing code signatures as it will accept the `.sign` extension. If it is desired, it can be modified to produce signatures with just the `.sign` extension. However I do not think it is necessary to maintain compatibility with the old process. ACKs for top commit: laanwj: Code review ACK 2c403279e2f0f7c8c27c56d4e7b0573c59571f0a Tree-SHA512: 2a0e01e9133f8859b9de26e7e8fe1d2610d2cbdee2845e6008b12c083c7e3622cbb2d9b83c50a269e2c3074ab95914a8225d3cd4108017f58b77a62bf10951e0

view details

push time in 3 hours

Pull request review commentbitcoin-core/gui

Added icon policy documentation

+# Icon policy
+This document provides guidelines for contributing icons to Bitcoin Core.
+
+
+## Preparing Icons
+Both an icon source file, in Scalable Vector Graphics (SVG) format, and an optimized production file, in Portable Network Graphics (PNG) format, are required for 
+each icon.
+
+#### SVG Source File
+SVGs are used as source files because they can scale while retaining image quality, but are not used in production due to limited application support.
+In the event that different-sized production (PNG) icons are required, they can be generated from the associated SVG source file in a vector-based tool such as:
+Inkspace, Adobe Illustrator, Figma, Sketch, or Adobe XD.

I would suggest dropping "such as: Inkspace, Adobe Illustrator, Figma, Sketch, or Adobe XD" to avoid update maintenance and review effort over time on this.

Bosch-0

comment created time in 5 hours

pull request commentbitcoin-core/gui

Add direction and type columns to peers window

I think it depends on your window size state which since #165 is now stored and recalled, so (I believe) this is not an issue after the first resize to your preferred state.

jonatack

comment created time in 5 hours

push eventbitcoin-core/gui

Hennadii Stepanov

commit sha d9392b724cae53b7a16fa5f84ebe152eea496502

script: Improve robustness of bitcoind.service on startup

view details

Hennadii Stepanov

commit sha 601778c3107adbd8d96eb0bb5c16a9d0a4b81594

script: Add Documentation key to bitcoind.service

view details

Hennadii Stepanov

commit sha 9d026546778629472574b26fa73338efc63d02da

doc: Fix systemd spelling and link to doc/init.md See https://www.freedesktop.org/wiki/Software/systemd/

view details

Wladimir J. van der Laan

commit sha ca8218301b375aecb07ecf3f697d4828ea7f513f

Merge #20884: script: Improve robustness of bitcoind.service on startup 9d026546778629472574b26fa73338efc63d02da doc: Fix systemd spelling and link to doc/init.md (Hennadii Stepanov) 601778c3107adbd8d96eb0bb5c16a9d0a4b81594 script: Add Documentation key to bitcoind.service (Hennadii Stepanov) d9392b724cae53b7a16fa5f84ebe152eea496502 script: Improve robustness of bitcoind.service on startup (Hennadii Stepanov) Pull request description: If network interfaces are not properly up the following happens: ``` ... 2021-01-08T10:17:11Z scheduler thread start 2021-01-08T10:17:11Z libevent: getaddrinfo: address family for nodename not supported 2021-01-08T10:17:11Z Binding RPC on address 127.0.0.1 port 8332 failed. 2021-01-08T10:17:11Z HTTP: creating work queue of depth 16 2021-01-08T10:17:11Z Using random cookie authentication. 2021-01-08T10:17:11Z Generated RPC authentication cookie /var/lib/bitcoind/.cookie 2021-01-08T10:17:11Z HTTP: starting 2 worker threads 2021-01-08T10:17:11Z init message: Loading banlist... 2021-01-08T10:17:11Z SetNetworkActive: true 2021-01-08T10:17:11Z Error: Cannot resolve -externalip address: <EDITED> 2021-01-08T10:17:11Z Shutdown: In progress... 2021-01-08T10:17:11Z scheduler thread exit 2021-01-08T10:17:11Z Shutdown: done ``` This PR improves robustness on startup in such cases in documented way: https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/ Also minor doc improvements are added. ACKs for top commit: Sjors: ACK 9d02654 practicalswift: ACK 9d026546778629472574b26fa73338efc63d02da: patch looks correct darosior: ACK 9d026546778629472574b26fa73338efc63d02da -- been using the first patch too Tree-SHA512: 38294f5682c09e6ea9008de7d7459098c920cf1b98ad8ef8a5d2ca01f2f781c0fec5591dc40ef36eeb19d94991b0c7fb7cb38c4e716bc7219875c9bcd0a55e1b

view details

push time in 5 hours

pull request commentbitcoin-core/gui

Add direction and type columns to peers window

I don't like the text form... As-is, IIRC this creates horizontal scrolling because it doesn't all fit in the window.

jonatack

comment created time in 6 hours

Pull request review commentbitcoin-core/gui

Added icon policy documentation

+# Icon policy
+This document provides guidelines for contributing icons to Bitcoin Core.
+
+
+## Preparing Icons
+Both an icon source file, in Scalable Vector Graphics (SVG) format, and an optimized production file, in Portable Network Graphics (PNG) format, are required for 
+each icon.
+
+#### SVG Source File
+SVGs are used as source files because they can scale while retaining image quality, but are not used in production due to limited application support.
+In the event that different-sized production (PNG) icons are required, they can be generated from the associated SVG source file in a vector-based tool such as:
+Inkspace, Adobe Illustrator, Figma, Sketch, or Adobe XD.

Figma is non-free and definitely not preferred...

Actually, the preferred tool (rsvg-convert) isn't even listed right now!

Bosch-0

comment created time in 6 hours

push eventbitcoin-core/gui

MarcoFalke

commit sha fa1d5e51374bce9607b429836bbd3fe059e3c78c

test: Fix get_previous_releases.py for aarch64

view details

Wladimir J. van der Laan

commit sha 991e612c3bb38e8ada88f29d469b3eb00416eb01

Merge #20955: test: Fix get_previous_releases.py for aarch64 fa1d5e51374bce9607b429836bbd3fe059e3c78c test: Fix get_previous_releases.py for aarch64 (MarcoFalke) Pull request description: Otherwise it will fail with "Not sure which binary to download..." ACKs for top commit: laanwj: Code review ACK fa1d5e51374bce9607b429836bbd3fe059e3c78c Tree-SHA512: 0db71e898a431665757ce835016a4e05c629a95abc4a2951eac9bd9b5876ec3dc3d6f156d58565e2bcdf918cde4f2649183d4a58038ac13c705a7e914c0094d1

view details

push time in 6 hours

pull request commentbitcoin-core/gui

Add direction and type columns to peers window

Thanks @luke-jr for the proposals and to @jarolrod for the screenshot renderings (a thought, no need to hide addresses if you test on signet or testnet, and signet starts up the fastest of all the chains.)

  • I agree the direction column should be next to the type and network (but no strong opinion on placement of the address column; maybe after the network column would be better)
  • The direction header could be shortened to "Dir", or "<->" like in -netinfo, or use icons/symbols to represent <->
  • The column header and column values are trivial to change and I suggest leaving that for a follow-up (not by me ;)

This has 2 tested ACKs; @luke-jr if you could ACK as well this could go in and open the door for your proposed follow-up.

jonatack

comment created time in 6 hours

pull request commentbitcoin-core/gui

Add direction and type columns to peers window

Screenshot is taken from Luke-jr's branch

I guess we should get some designer opinion on this: @Bosch-0 what do you think about this icon vs inbound/outbound text.

I think this idea has a lot of potential, but as this iteration I would still vote for inbound/outbound text. I think it's more informative and fits in better with translations. Also I think Direction and Type should remain adjacent. Screen Shot 2021-01-18 at 12 40 44 PM

jonatack

comment created time in 7 hours

push eventbitcoin-core/gui

fanquake

commit sha 2c010b9c56f069efad2b2c10bffaef4ed059736e

add std::atomic include to bitcoin-util.cpp

view details

fanquake

commit sha 54ce4fac80689621dcbcc76169b2b00b179ee743

build: improve macro for testing -latomic requirement riscv builds are currently failing because -latomic isn't being linked against, when it is needed: ```bash /home/ubuntu/build/bitcoin/distsrc-riscv64-linux-gnu/src/bitcoin-util.cpp:98: undefined reference to `__atomic_exchange_1' ``` This exteneds our macro to ensure that -latomic is linked against when required.

view details

Wladimir J. van der Laan

commit sha c763cacb883c77f7b8baf1b913a73943cf7c2180

Merge #20938: build: fix linking against -latomic when building for riscv 54ce4fac80689621dcbcc76169b2b00b179ee743 build: improve macro for testing -latomic requirement (fanquake) 2c010b9c56f069efad2b2c10bffaef4ed059736e add std::atomic include to bitcoin-util.cpp (fanquake) Pull request description: Since the merge of #19937, riscv builds have been failing, due to a link issue with [`std::atomic_exchange`](https://en.cppreference.com/w/cpp/atomic/atomic_exchange) in `bitcoin-util`: ```bash CXXLD bitcoin-util bitcoin_util-bitcoin-util.o: In function `grind_task': /home/ubuntu/build/bitcoin/distsrc-riscv64-linux-gnu/src/bitcoin-util.cpp:98: undefined reference to `__atomic_exchange_1' collect2: error: ld returned 1 exit status ``` We have a [macro](https://github.com/bitcoin/bitcoin/blob/master/build-aux/m4/l_atomic.m4) that tries to determine when `-latomic` is required, however it doesn't quite work well enough, as it's currently determining it isn't needed: ```bash ./autogen.sh ./configure --prefix=/home/ubuntu/bitcoin/depends/riscv64-linux-gnu ... checking whether std::atomic can be used without link library... yes ``` This PR adds a call to `std::atomic_exchange` to the macro, which will get us properly linked against `-latomic` on riscv: ```bash checking whether std::atomic can be used without link library... no checking whether std::atomic needs -latomic... yes ``` Also adds an `<atomic>` include to `bitcoin-util.cpp`. ACKs for top commit: laanwj: Tested ACK 54ce4fac80689621dcbcc76169b2b00b179ee743 Tree-SHA512: 963c875097ee96b131163ae8109bcf8fecf4451d20faa2f3d223f9938ea3d8d1ed5604e12ad82c2b4b1c605fd293a9b6b08fefc00dd3e68d09c49e95029c6f50

view details

push time in 7 hours

pull request commentbitcoin-core/gui

Add direction and type columns to peers window

There, how does this look? https://github.com/jonatack/gui/compare/add-peers-dir-and-type-columns...luke-jr:tmp_gui_peers_dir_arrows

jonatack

comment created time in 7 hours

Pull request review commentbitcoin-core/gui

Added icon policy documentation

+# Icon policy
+This document provides guidelines for contributing icons to Bitcoin Core.
+
+
+## Preparing Icons
+Both an icon source file, in Scalable Vector Graphics (SVG) format, and an optimized production file, in Portable Network Graphics (PNG) format, are required for 
+each icon.
+
+#### SVG Source File
+SVGs are used as source files because they can scale while retaining image quality, but are not used in production due to limited application support.
+In the event that different-sized production (PNG) icons are required, they can be generated from the associated SVG source file in a vector-based tool such as:
+Inkspace, Adobe Illustrator, Figma, Sketch, or Adobe XD.

I don't think we HAVE to remove the non-free tools, but maybe mention that Figma is the preferred tool?

Bosch-0

comment created time in 8 hours

issue openedbitcoin-core/gui

Receive addresses are shown in random order

Using v0.20.1 on Windows

When using the menu item for Window -> Receiving addresses

It looks like I'm shown 22 addresses by default. But it seems these addresses in random order? Isn't it better to have them listed in order based on their derivation path? At least then its consistent with how most other wallets do it when cross checking to verify

created time in a day

pull request commentbitcoin-core/gui

Add direction and type columns to peers window

I suppose we could also do icons with an arrow and tiny in/out text under it

jonatack

comment created time in a day

issue commentbitcoin-core/gui

No GUI loading at all, completely blank but core running.

So sorry for long reply I havent tried since but will try this week.

On Sun, 17 Jan 2021, 18:04 Jarol Rodriguez, notifications@github.com wrote:

Note to self: QPainter::begin: Paint device returned engine == 0, type: 2 is the internal flag Pixmap = 0x02. Issue should be related to QPixmap https://doc.qt.io/qt-5/qpixmap.html, will investigate.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bitcoin-core/gui/issues/175#issuecomment-761853705, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZPKQ5VZG6U4M2US7MSI7DS2MRBFANCNFSM4VRZTZCA .

shaun-ba

comment created time in a day

pull request commentbitcoin-core/gui

Add direction and type columns to peers window

I was thinking something more like this:

jonatack/gui@add-peers-dir-and-type-columns...luke-jr:tmp_gui_peers_dir_arrows

Below is a screenshot of what your branch looks like for me, font issue with the arrows. Anyways, my vote is still for inbound/outbound lukejr-arrows

jonatack

comment created time in a day

issue commentbitcoin-core/gui

No GUI loading at all, completely blank but core running.

Note to self: QPainter::begin: Paint device returned engine == 0, type: 2 is the internal flag Pixmap = 0x02. Issue should be related to QPixmap, will investigate.

shaun-ba

comment created time in a day

issue commentbitcoin-core/gui

No GUI loading at all, completely blank but core running.

@shaun-ba is it still the case that you cannot start bitcoin-qt on your LC49RG90SSUXEN monitor?

shaun-ba

comment created time in a day

pull request commentbitcoin-core/gui

Add direction and type columns to peers window

I was thinking something more like this:

https://github.com/jonatack/gui/compare/add-peers-dir-and-type-columns...luke-jr:tmp_gui_peers_dir_arrows

jonatack

comment created time in a day

push eventbitcoin-core/gui

fanquake

commit sha c061800bb17ce8005ac7b189135dd7e95155e7de

build: fix RELOC_SECTION security check for bitcoin-util The binutils we use for gitian builds strips the reloc section from Windows binaries, which breaks ASLR. As a temporary workaround, export main(). This is the same workaround as #18702 (bitcoin-cli), and will fix the currently failing security check: ```bash + make -j1 -C src check-security make: Entering directory '/home/ubuntu/build/bitcoin/distsrc-x86_64-w64-mingw32/src' Checking binary security... bitcoin-util.exe: failed RELOC_SECTION make: *** [check-security] Error 1 ``` Relevant upstream issue: https://sourceware.org/bugzilla/show_bug.cgi?id=19011

view details

Wladimir J. van der Laan

commit sha 7acda55c4fa611481979a41dfd5ca016bb535409

Merge #20939: build: fix RELOC_SECTION security check for bitcoin-util c061800bb17ce8005ac7b189135dd7e95155e7de build: fix RELOC_SECTION security check for bitcoin-util (fanquake) Pull request description: The binutils we use for gitian builds strips the reloc section from Windows binaries, which breaks ASLR. As a temporary workaround, export main(). This is the same workaround as #18702 (bitcoin-cli), and will fix the currently failing security check: ```bash + make -j1 -C src check-security make: Entering directory '/home/ubuntu/build/bitcoin/distsrc-x86_64-w64-mingw32/src' Checking binary security... bitcoin-util.exe: failed RELOC_SECTION make: *** [check-security] Error 1 ``` Relevant upstream issue: https://sourceware.org/bugzilla/show_bug.cgi?id=19011 ACKs for top commit: dongcarl: ACK c061800bb17ce8005ac7b189135dd7e95155e7de laanwj: ACK c061800bb17ce8005ac7b189135dd7e95155e7de Tree-SHA512: a1a4da0b2cddfc377190b9044a04f42a859ca79f11ce2c2ab4c3d066a2786c34d5446d75f8eec634f308d2d3349ebbd7c9f76dcaebeeb28e471c829851592367

view details

push time in a day

push eventbitcoin-core/gitian.sigs

eriknylund

commit sha a4421bd6b1ae02a1c639d62f3ca8cf3bbf6b7e7d

Add eriknylund 0.21.0 code signed signatures

view details

MarcoFalke

commit sha b759ad21f861737c5bf12e607b8c78085812bc72

Merge pull request #1535 from eriknylund/eriknylund-0.21.0-signed Add eriknylund 0.21.0 code signed signatures

view details

push time in 2 days

more