profile
viewpoint
Holger Benl hbenl Munich, Germany

firefox-devtools/vscode-firefox-debug 273

VS Code Debug Adapter for Firefox

hbenl/vscode-test-explorer 177

The VS Code Test Explorer extension

hbenl/vscode-mocha-test-adapter 65

Mocha Test Adapter for the VS Code Test Explorer

hbenl/vscode-example-test-adapter 18

An example TestAdapter extension for the VS Code Test Explorer

hbenl/vscode-jasmine-test-adapter 17

Jasmine Test Adapter for the VS Code Test Explorer

hbenl/mpc-js-node 16

A javascript client library for the Music Player Daemon

hbenl/vscode-test-adapter-api 10

Test Adapter API for the VS Code Test Explorer

hbenl/vscode-test-explorer-liveshare 10

Use the Test Explorer in your Visual Studio Live Share session

hbenl/mpc-js-core 7

mpc.js is a javascript client library for the Music Player Daemon.

hbenl/vscode-mocha-docker-example 3

An example project for running mocha tests in a docker container using the Mocha Test Explorer for VS Code

PR opened RecordReplay/gecko-dev

More fixes for the stacking algorithm (devtools#4706)

I have made 2 changes to get the algorithm closer to the spec:

  • I've implemented the "pseudo stacking contexts" described in the spec (see the comment added in the commit)
  • the root element of a stacking context is now stacked behind all of its children, including those with negative z-index
+25 -18

0 comment

1 changed file

pr created time in a day

create barnchRecordReplay/gecko-dev

branch : hbenl/devtools-issue-4706

created branch time in a day

PullRequestReviewEvent

Pull request review commentRecordReplay/devtools

Specify the sources to be searched

 const formatMatchesBySource = (matches, sourcesById) => {     .map(([sourceId, matches]) => [sourcesById[sourceId], matches])     .filter(([source]) => !!source); -  const sorted = sortBy(filteredResults, ([source]) => [source.isOriginal ? 0 : 1, source.url]);-  return sorted.map(([source, matches]) => formatSourceMatches(source, matches));+  return filteredResults.map(([source, matches]) => formatSourceMatches(source, matches)); };  export async function search(query, sourcesById, updateResults) {   trackEvent("project_search.search"); +  let sourceIds = [];+  for (const sourceId in sourcesById) {+    if (ThreadFront.isMinifiedSource(sourceId)) {+      continue;+    }+    const correspondingSourceId = ThreadFront.getCorrespondingSourceIds(sourceId)[0];+    if (correspondingSourceId !== sourceId) {+      continue;+    }+    const source = sourcesById[sourceId];+    if (isThirdParty(source)) {+      continue;+    }+    sourceIds.push(sourceId);+  }+  sourceIds = sortBy(sourceIds, sourceId => {+    const source = sourcesById[sourceId];+    return [source.isOriginal ? 0 : 1, source.url];+  });   updateResults(() => ({ status: "LOADING", query, matchesBySource: [] }));

Done

hbenl

comment created time in 2 days

push eventhbenl/webreplay-devtools

Holger Benl

commit sha 35c1e3c6ea20dc634fd7484479911e3a5fbb13d5

Specify the sources to be searched

view details

push time in 2 days

push eventhbenl/webreplay-devtools

Holger Benl

commit sha 24eadddf76a5962199c419f5db1638fd29c01f62

Fix warning message from react

view details

Jaril

commit sha 1b3184217899bde69139cd689f10fae0c0e280ee

Add more trackers for mixpanel (#4716) * Track the user's first login in mixpanel * Add a mixpanel tracker to record whether a user is inspecting their authored replay

view details

Jaril

commit sha 956b6d195a74e98a843b1c25d87cef07e06a1c64

Event link (#4713) * Add a link from an event timeline event to the corresponding callback function * Add an experimental pref for event link * Fix typescript

view details

Jaril

commit sha bb8a8d3c8d23d23bbb59be4389c64d6001b538f4

Make sure that class names are being displayed in the outline view (#4701)

view details

Ryan Duffy

commit sha 035e85a1db9a68241c6328d7181b67d3d493f2b7

Add message of the day to new tab page (#4651) * Add message of the day to new tab page * add spacing

view details

Holger Benl

commit sha 89aa60f1b468c2d0453011eda6bc575817e3879f

Clear highlighter on seek (#4565)

view details

Brian Hackett

commit sha 7b961a6d6f258c5a0ec0e8fc2a67ceb8a699f142

Log loaded regions to console (#4719)

view details

Jason Laster

commit sha cfb001e8858d70a4329b6d432698a9797bfda033

Only render a panel if it is selected (#4721)

view details

Jaril

commit sha 4c0bec3c48265fd6e82edb63b846b96570049f07

Add a white background to the privacy modal (#4723)

view details

Jaril

commit sha e4097745bc5bc8a91fc59551bd81985fd928a787

Fix react framework events for React v17 (#4724)

view details

Ryan Duffy

commit sha 0fac68ea31fe5e654857818de833324c4021a2f2

Add Org-specific settings to Team Settings Modal (#4704) * UI Seems close to done * Gray out based on org or not org * Get MOTD from the backend * This is erroring because of a missing column * working updates * undo package lock change * remove unused graphql * fix type error * add preview link * fix width of motd on new-tab * add debounce state hook * add noopener Co-authored-by: Josh Morrow <josh@jcmorrow.com>

view details

Ryan Duffy

commit sha 8eb99b35d0e35a3f18b578f9574144646373620b

Disable making recordings public when disabled by org (#4718) * UI Seems close to done * Gray out based on org or not org * Get MOTD from the backend * This is erroring because of a missing column * working updates * undo package lock change * remove unused graphql * fix type error * add preview link * fix width of motd on new-tab * Disable public toggle for orgs with feature flag set * PHide UI elements to make recordings public for workspaces with that disabled * toggle public when switching to my lib or an org when flag is set * add debounce state hook * add noopener * hide upload edit button when the user cannot edit * add storybook stories Co-authored-by: Josh Morrow <josh@jcmorrow.com>

view details

Ryan Duffy

commit sha b308bbf93ccbba9d2836b61b453f70a01857143d

Add team logo (#4727) * Add team logo * add logo to library view * reduce max image size * use new mutation for logo

view details

Ryan Duffy

commit sha c9d1c7dbc87c6a5d9270e9100b1cb6190dd18e4a

Fix moving from my library (#4728)

view details

push time in 2 days

PullRequestReviewEvent

delete branch hbenl/webreplay-devtools

delete branch : issue-4565

delete time in 3 days

push eventRecordReplay/devtools

Holger Benl

commit sha 89aa60f1b468c2d0453011eda6bc575817e3879f

Clear highlighter on seek (#4565)

view details

push time in 3 days

issue closedRecordReplay/devtools

Elements Panel - highlighter should clear on seek

Description: The highlighter does not clear when you seek with the global timeline

closed time in 3 days

jasonLaster

create barnchhbenl/webreplay-devtools

branch : issue-4565

created branch time in 3 days

issue commentRecordReplay/devtools

Elements Panel steals keyboard arrow events from the comments pane

It's not the Elements panel that's doing the stealing but the ReactDevTools panel, see https://app.replay.io/recording/5895bcc2-c7d2-47c5-8456-597198e3993d We probably didn't notice this before because the global keydown event listener is only registered when ReactDevTools is rendered and in the past we only rendered it when it was visible. But since #4537 we're always rendering it (even if it's disabled in the user's settings). We could fix this by asking the ReactDevTools developers to not register their event listener on the document node or by putting ReactDevTools in an iframe.

jasonLaster

comment created time in 3 days

push eventhbenl/webreplay-devtools

Holger Benl

commit sha ca066ec34853d7a4b0b3f584fc9d56c158b66fb1

Specify the sources to be searched

view details

push time in 4 days

PR opened RecordReplay/devtools

Specify the sources to be searched

Needs RecordReplay/backend#3773 to be deployed first.

+32 -13

0 comment

2 changed files

pr created time in 4 days

create barnchhbenl/webreplay-devtools

branch : search-sources

created branch time in 4 days

delete branch hbenl/webreplay-devtools

delete branch : request-table-key

delete time in 4 days

push eventRecordReplay/devtools

Holger Benl

commit sha 24eadddf76a5962199c419f5db1638fd29c01f62

Fix warning message from react

view details

push time in 4 days

create barnchhbenl/webreplay-devtools

branch : request-table-key

created branch time in 4 days

push eventhbenl/webreplay-devtools

Jaril

commit sha ac2d13b016e13347974c7ccfc17fda6dfe96b59b

Defensively check replay session (#4695)

view details

Jason Laster

commit sha 6066b66b22320dfff668e23ef59423adcee9f04f

Outline: refactor outline view (#4673) * Outline: refactor outline view * Fix classes Co-authored-by: Jaril <jarilvalenciano@gmail.com>

view details

Jaril

commit sha 4abc40264b85dcf608a93ddf058f51f01e3fdbdb

Make the experimental user settings pane consistent with the notification preferences (#4658) * Simplify the experiments tab in user settings * Clean up SettingsModal * Bring back descriptions * Review changes

view details

Josh Morrow

commit sha 4596ef0246305bbb8e51c92d26fbcac3ea47738f

Make the plan detail page dynamic (#4654) * Add some super basic tests * Most of the way there There was definitely a smaller change in here somewhere, but I think this sets us up for some more changes down the road here. * Add some storybook * Fix typecheck * remove console.log * rename method Co-authored-by: Ryan Duffy <ryan@replay.io>

view details

Ryan Duffy

commit sha cf0b5d48b8e4819e49871b25e38d249e5448c84b

Enable maintenance mode (#4707)

view details

Ryan Duffy

commit sha adf0f850becf5ec2454d9561893bea34837a2fc2

Revert "Enable maintenance mode (#4707)" (#4708) This reverts commit cf0b5d48b8e4819e49871b25e38d249e5448c84b.

view details

Jon Bell

commit sha 5cde42c87ee7a18294661f77881c374f34b98f3b

Removing “loading events…” (#4693) * Removing “loading events…” * Remove unused code Co-authored-by: Jaril <jarilvalenciano@gmail.com>

view details

push time in 4 days

push eventhbenl/webreplay-devtools

Jaril

commit sha 1d16cbbe124013859dde3f24eb20c878d812cc86

Add more full text search mixpanel trackers (#4649)

view details

Dan Miller

commit sha e74aabdd20bf411deb4b686e06149efd34425063

Make playwright an optional dependency so npm install completes on M1 macs (#4650)

view details

Jaril

commit sha eabde86c17e8545a0c84096967d74376083606c4

Make sure we only fire events when hovering in the editor (#4652)

view details

Jaril

commit sha 5babb7efe885bb3b34cd8c2bb33949e49e3a1374

Make the Public Access button not selectable (#4661)

view details

Jaril

commit sha 262380de09e1b3e3d8518ef73402ec13886b3786

Cleanup keyboard shortcuts and add a toggle sidebar shortcut (#4619)

view details

Jaril

commit sha 971317d5973d740bdf4381b5665c8daab46a8384

Open the search panel when the user clicks on the Find in Files shortcut (#4662)

view details

Jaril

commit sha a7f5480a46c7763bdae5a44bad1994517fc429a9

Make sure the last comment always has a border and isn't rounded off (#4657)

view details

Jaril

commit sha 533ab232da1e988d240c546e64eeede0d78e3a59

Don't show the red events timeline when there are no events (#4656)

view details

Jaril

commit sha 21eea8dc9d3e8329c958a7abef6425ff674fa464

Have the shortcut width adjust on resize (#4655)

view details

Jaril

commit sha 482ee1acafa53c58979e900ef4ac1418b694bdf2

Refactor codemirror events (#4659) * Refactor codemirror events * Fix trackers

view details

Jaril

commit sha d768d6e5cb4f467e05ef5edcb070392c78e02fc1

Reorganize the way we do the edit-save-success breakpoint nag flow (#4669)

view details

Ryan Duffy

commit sha 87f58cd371c0dd0106f895db88f3fe12bb14cca6

Validate auth without the redirect (#4689)

view details

Ryan Duffy

commit sha cdc5ce4f2033fe121c8bd95a1d4d9a4cb022b5d1

Enforce org features for user (#4690) * Handle disabled user library * remove apiKey feature * handle disabled user api keys * disable api keys when library feature is disabled * shift unshift * fix up type errors

view details

Jaril

commit sha b24c4318d4d8b98d0b412ec378122279697f61e5

Clean up loading screens (#4610) * Refactor changes * Show bubbles behind our loading screens * Make the TOS screen and launch screen used bubbles

view details

Jaril

commit sha f55fce360fb49c44ebdfae689dd66c0108e6f4b7

Fix BlankScreen references (#4696)

view details

Jaril

commit sha 9735e280e303a5764ff36a94e68cb98eb0c3470a

Fix the breakpoint panel's empty state (#4699)

view details

Jaril

commit sha 2d3cea9819ae1726937db7f547ee4393eefb5f1d

Track when users are trying to view a private replay in Mixpanel (#4702)

view details

push time in 5 days

push eventRecordReplay/gecko-dev

Holger Benl

commit sha 6c6e9afdc9a7909d2e88382cb3a440b741d747ad

Add workaround for auth errors

view details

Holger Benl

commit sha 3faa1e070311557a94349ccdbe0110d3528e8d07

Merge pull request #603 from RecordReplay/hbenl/auth-error-workaround Workaround for auth errors

view details

push time in 5 days

delete branch RecordReplay/gecko-dev

delete branch : hbenl/auth-error-workaround

delete time in 5 days

PR merged RecordReplay/gecko-dev

Workaround for auth errors

I had an idea how we can make the auth issue after browser updates less severe: when the user clicks the "REC" button but isn't authenticated (no token or an expired token) we send him to the signin page, just as clicking the "SIGN IN" button does. The only remaining issue would be that the browser should have shown the "SIGN IN" button instead of the "REC" button, so it's confusing for the user that he is sent to the signin page instead of starting a recording.

+23 -14

2 comments

1 changed file

hbenl

pr closed time in 5 days

pull request commentRecordReplay/gecko-dev

Workaround for auth errors

Also, note that I haven't tested this patch yet.

hbenl

comment created time in 10 days

pull request commentRecordReplay/gecko-dev

Workaround for auth errors

(see also #601)

hbenl

comment created time in 10 days

PR opened RecordReplay/gecko-dev

Workaround for auth errors

I had an idea how we can make the auth issue after browser updates less severe: when the user clicks the "REC" button but isn't authenticated (no token or an expired token) we send him to the signin page, just as clicking the "SIGN IN" button does. The only remaining issue would be that the browser should have shown the "SIGN IN" button instead of the "REC" button, so it's confusing for the user that he is sent to the signin page instead of starting a recording.

+23 -14

0 comment

1 changed file

pr created time in 10 days

more