profile
viewpoint
Harry Fei harryfei Trantect Nanjing China Thinking

harryfei/alchemy 2

A card game name alchemy

harryfei/actualvim 0

Sublime Text 3 input mode powered by Vim itself

harryfei/alchemyDesgin 0

alchemyDesgin

harryfei/auto-pairs 0

Vim plugin, insert or delete brackets, parens, quotes in pair

harryfei/blog_os 0

Writing an OS in Rust

harryfei/common-elements 0

Common/Reusable/Small web components to help building complex web components.

harryfei/contrib 0

This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core. Consider creating a new repo instead.

harryfei/coursera-university-of-washington 0

University of Washington

harryfei/dataset-popular 0

A dataset of popular pages (taken from <dir.yahoo.com>) with manually marked up semantic blocks.

startedtikv/agatedb

started time in 2 days

startediqlusioninc/abscissa

started time in 15 days

startedbkolobara/async-wormhole

started time in 15 days

startedgoogle/encrypted-bigquery-client

started time in 19 days

startedCryptDB/cryptdb

started time in 20 days

pull request commentharryfei/which-rs

Remove thiserror crate

Sorry, so late to response on this. How much time does thiserror's compilation cost in your case?

Bzomak

comment created time in 23 days

startedsobolevn/awesome-cryptography

started time in 25 days

startedzerodb/zerodb

started time in 25 days

startedjonaschn/awesome-he

started time in 25 days

startedhermitcore/rusty-hermit

started time in a month

startedchriskiehl/Gooey

started time in 2 months

startedmullvad/mullvadvpn-app

started time in 2 months

issue closedsigp/lighthouse

Illegal instruction (core dumped)

Description

Illegal instruction (core dumped) when using docker image sigp/lighthouse:latest

Version

lighhouse v0.2.8-638daa8 sigp/lighthouse:latest

My /etc/cpuinfo

vendor_id	: GenuineIntel
cpu family	: 6
model		: 69
model name	: Intel(R) Core(TM) i3-4010U CPU @ 1.70GHz
stepping	: 1
microcode	: 0x10
cpu MHz		: 1622.159
cache size	: 3072 KB
physical id	: 0
siblings	: 4
core id		: 0
cpu cores	: 2
apicid		: 0
initial apicid	: 0
fpu		: yes
fpu_exception	: yes
cpuid level	: 13
wp		: yes
flags		: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid sse4_1 sse4_2 x2apic movbe popcnt aes xsave avx f16c rdrand lahf_lm abm cpuid_fault epb invpcid_single pti tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid xsaveopt dtherm ida arat pln pts
vmx flags	: vnmi preemption_timer invvpid ept_x_only ept_ad ept_1gb flexpriority tsc_offset vtpr mtf vapic ept vpid unrestricted_guest ple
bugs		: cpu_meltdown spectre_v1 spectre_v2 spec_store_bypass l1tf mds swapgs itlb_multihit srbds
bogomips	: 3393.42
clflush size	: 64
cache_alignment	: 64
address sizes	: 39 bits physical, 48 bits virtual
power management:

processor	: 1
vendor_id	: GenuineIntel
cpu family	: 6
model		: 69
model name	: Intel(R) Core(TM) i3-4010U CPU @ 1.70GHz
stepping	: 1
microcode	: 0x10
cpu MHz		: 1670.186
cache size	: 3072 KB
physical id	: 0
siblings	: 4
core id		: 0
cpu cores	: 2
apicid		: 1
initial apicid	: 1
fpu		: yes
fpu_exception	: yes
cpuid level	: 13
wp		: yes
flags		: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid sse4_1 sse4_2 x2apic movbe popcnt aes xsave avx f16c rdrand lahf_lm abm cpuid_fault epb invpcid_single pti tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid xsaveopt dtherm ida arat pln pts
vmx flags	: vnmi preemption_timer invvpid ept_x_only ept_ad ept_1gb flexpriority tsc_offset vtpr mtf vapic ept vpid unrestricted_guest ple
bugs		: cpu_meltdown spectre_v1 spectre_v2 spec_store_bypass l1tf mds swapgs itlb_multihit srbds
bogomips	: 3393.42
clflush size	: 64
cache_alignment	: 64
address sizes	: 39 bits physical, 48 bits virtual
power management:

processor	: 2
vendor_id	: GenuineIntel
cpu family	: 6
model		: 69
model name	: Intel(R) Core(TM) i3-4010U CPU @ 1.70GHz
stepping	: 1
microcode	: 0x10
cpu MHz		: 1696.159
cache size	: 3072 KB
physical id	: 0
siblings	: 4
core id		: 1
cpu cores	: 2
apicid		: 2
initial apicid	: 2
fpu		: yes
fpu_exception	: yes
cpuid level	: 13
wp		: yes
flags		: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid sse4_1 sse4_2 x2apic movbe popcnt aes xsave avx f16c rdrand lahf_lm abm cpuid_fault epb invpcid_single pti tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid xsaveopt dtherm ida arat pln pts
vmx flags	: vnmi preemption_timer invvpid ept_x_only ept_ad ept_1gb flexpriority tsc_offset vtpr mtf vapic ept vpid unrestricted_guest ple
bugs		: cpu_meltdown spectre_v1 spectre_v2 spec_store_bypass l1tf mds swapgs itlb_multihit srbds
bogomips	: 3393.42
clflush size	: 64
cache_alignment	: 64
address sizes	: 39 bits physical, 48 bits virtual
power management:

processor	: 3
vendor_id	: GenuineIntel
cpu family	: 6
model		: 69
model name	: Intel(R) Core(TM) i3-4010U CPU @ 1.70GHz
stepping	: 1
microcode	: 0x10
cpu MHz		: 1620.213
cache size	: 3072 KB
physical id	: 0
siblings	: 4
core id		: 1
cpu cores	: 2
apicid		: 3
initial apicid	: 3
fpu		: yes
fpu_exception	: yes
cpuid level	: 13
wp		: yes
flags		: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid sse4_1 sse4_2 x2apic movbe popcnt aes xsave avx f16c rdrand lahf_lm abm cpuid_fault epb invpcid_single pti tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid xsaveopt dtherm ida arat pln pts
vmx flags	: vnmi preemption_timer invvpid ept_x_only ept_ad ept_1gb flexpriority tsc_offset vtpr mtf vapic ept vpid unrestricted_guest ple
bugs		: cpu_meltdown spectre_v1 spectre_v2 spec_store_bypass l1tf mds swapgs itlb_multihit srbds
bogomips	: 3393.42
clflush size	: 64
cache_alignment	: 64
address sizes	: 39 bits physical, 48 bits virtual
power management:

closed time in 2 months

harryfei

issue commentsigp/lighthouse

Illegal instruction (core dumped)

Resolved with latest docker image.

harryfei

comment created time in 2 months

issue openedsigp/lighthouse

Illegal instruction (core dumped)

Description

Illegal instruction (core dumped) when using docker image sigp/lighthouse:latest

Version

lighhouse v0.2.8-638daa8 sigp/lighthouse:latest

My /etc/cpuinfo

vendor_id	: GenuineIntel
cpu family	: 6
model		: 69
model name	: Intel(R) Core(TM) i3-4010U CPU @ 1.70GHz
stepping	: 1
microcode	: 0x10
cpu MHz		: 1622.159
cache size	: 3072 KB
physical id	: 0
siblings	: 4
core id		: 0
cpu cores	: 2
apicid		: 0
initial apicid	: 0
fpu		: yes
fpu_exception	: yes
cpuid level	: 13
wp		: yes
flags		: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid sse4_1 sse4_2 x2apic movbe popcnt aes xsave avx f16c rdrand lahf_lm abm cpuid_fault epb invpcid_single pti tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid xsaveopt dtherm ida arat pln pts
vmx flags	: vnmi preemption_timer invvpid ept_x_only ept_ad ept_1gb flexpriority tsc_offset vtpr mtf vapic ept vpid unrestricted_guest ple
bugs		: cpu_meltdown spectre_v1 spectre_v2 spec_store_bypass l1tf mds swapgs itlb_multihit srbds
bogomips	: 3393.42
clflush size	: 64
cache_alignment	: 64
address sizes	: 39 bits physical, 48 bits virtual
power management:

processor	: 1
vendor_id	: GenuineIntel
cpu family	: 6
model		: 69
model name	: Intel(R) Core(TM) i3-4010U CPU @ 1.70GHz
stepping	: 1
microcode	: 0x10
cpu MHz		: 1670.186
cache size	: 3072 KB
physical id	: 0
siblings	: 4
core id		: 0
cpu cores	: 2
apicid		: 1
initial apicid	: 1
fpu		: yes
fpu_exception	: yes
cpuid level	: 13
wp		: yes
flags		: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid sse4_1 sse4_2 x2apic movbe popcnt aes xsave avx f16c rdrand lahf_lm abm cpuid_fault epb invpcid_single pti tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid xsaveopt dtherm ida arat pln pts
vmx flags	: vnmi preemption_timer invvpid ept_x_only ept_ad ept_1gb flexpriority tsc_offset vtpr mtf vapic ept vpid unrestricted_guest ple
bugs		: cpu_meltdown spectre_v1 spectre_v2 spec_store_bypass l1tf mds swapgs itlb_multihit srbds
bogomips	: 3393.42
clflush size	: 64
cache_alignment	: 64
address sizes	: 39 bits physical, 48 bits virtual
power management:

processor	: 2
vendor_id	: GenuineIntel
cpu family	: 6
model		: 69
model name	: Intel(R) Core(TM) i3-4010U CPU @ 1.70GHz
stepping	: 1
microcode	: 0x10
cpu MHz		: 1696.159
cache size	: 3072 KB
physical id	: 0
siblings	: 4
core id		: 1
cpu cores	: 2
apicid		: 2
initial apicid	: 2
fpu		: yes
fpu_exception	: yes
cpuid level	: 13
wp		: yes
flags		: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid sse4_1 sse4_2 x2apic movbe popcnt aes xsave avx f16c rdrand lahf_lm abm cpuid_fault epb invpcid_single pti tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid xsaveopt dtherm ida arat pln pts
vmx flags	: vnmi preemption_timer invvpid ept_x_only ept_ad ept_1gb flexpriority tsc_offset vtpr mtf vapic ept vpid unrestricted_guest ple
bugs		: cpu_meltdown spectre_v1 spectre_v2 spec_store_bypass l1tf mds swapgs itlb_multihit srbds
bogomips	: 3393.42
clflush size	: 64
cache_alignment	: 64
address sizes	: 39 bits physical, 48 bits virtual
power management:

processor	: 3
vendor_id	: GenuineIntel
cpu family	: 6
model		: 69
model name	: Intel(R) Core(TM) i3-4010U CPU @ 1.70GHz
stepping	: 1
microcode	: 0x10
cpu MHz		: 1620.213
cache size	: 3072 KB
physical id	: 0
siblings	: 4
core id		: 1
cpu cores	: 2
apicid		: 3
initial apicid	: 3
fpu		: yes
fpu_exception	: yes
cpuid level	: 13
wp		: yes
flags		: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid sse4_1 sse4_2 x2apic movbe popcnt aes xsave avx f16c rdrand lahf_lm abm cpuid_fault epb invpcid_single pti tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid xsaveopt dtherm ida arat pln pts
vmx flags	: vnmi preemption_timer invvpid ept_x_only ept_ad ept_1gb flexpriority tsc_offset vtpr mtf vapic ept vpid unrestricted_guest ple
bugs		: cpu_meltdown spectre_v1 spectre_v2 spec_store_bypass l1tf mds swapgs itlb_multihit srbds
bogomips	: 3393.42
clflush size	: 64
cache_alignment	: 64
address sizes	: 39 bits physical, 48 bits virtual
power management:

created time in 2 months

startedDushistov/flapigen-rs

started time in 2 months

startedmeilisearch/MeiliSearch

started time in 2 months

startedmicromdm/micromdm

started time in 2 months

startedweslenng/generative-art

started time in 2 months

starteddtolnay/inventory

started time in 2 months

pull request commentremacs/remacs

WIP: Webrender graphic backend (GPU-accelerated Emacs)

Hi I wanted to try this but ./configure --with-webrender said that it wasn't an option.

I cloned the fork and built from there. Is that how I was supposed to do it ?

@dirodriguezm The code is no webrender branch. :)

harryfei

comment created time in 2 months

pull request commentremacs/remacs

WIP: Webrender graphic backend (GPU-accelerated Emacs)

@petr-tik The crash issue related to https://github.com/rust-windowing/glutin/issues/1262

harryfei

comment created time in 2 months

push eventharryfei/remacs

Harry Fei

commit sha 5b32d4cf2c64ec1ab080677cb08585557e9c4ab0

webrender: Add webrender backend file wrterm.h and wrgui.h.

view details

Harry Fei

commit sha 344cf8e594c34c528d60944fb00d9d9279239f6e

webrender: clean wrterm

view details

Harry Fei

commit sha 84ed512fdb39aa9bab189d408240f0d904fbcb34

webrender: minized extern functions

view details

Harry Fei

commit sha fc99755a7e4991874a126731887bd7ec023e048b

webrender: correct comments

view details

Harry Fei

commit sha d925111f0967345ccf4abdbc1efd66a8d09984b4

webrender: add more FRAME_X macros

view details

Harry Fei

commit sha b20279b6fd8143c135b4ecba1f3eaf95de62c490

webrender: add most wenrender stub functions

view details

Harry Fei

commit sha 85ed2fd9470144c567db76b80326cbbc2bd29bdc

webrender: enable x term feature

view details

Harry Fei

commit sha dd2bba14ec1f80308e60644eb1b83b1e2f7f6e73

webrender: add cargo feature flag for webrender build

view details

Harry Fei

commit sha 36aadb4352b8f1183e7d1a2e4603a7b737373bf1

webrender: refactor DispalyInfoRef

view details

Harry Fei

commit sha 3cbd0a7ce8517f1a657ed858275f4557ecc6c462

webrender: fix build window system initialize error

view details

Harry Fei

commit sha dac0f6d9b56c26fa218c58837573e50b1e13939c

webrender: implement `x-open-connection` and `x-create-frame` basic logic

view details

Harry Fei

commit sha ff340fca64c975aa820ce44330a7f99c7734112a

webrender: refactor create frame logic

view details

Harry Fei

commit sha c58dff67bc69cae450254150f78e9df117e6d90c

webrender: add Output releate data struct.

view details

Harry Fei

commit sha 64582899159c6b48dc9593c74c7076474e29d3c4

webrender: implement `x-get-focus-frame`

view details

Harry Fei

commit sha 67a716a95752183b76d527406b2fd177402b30d3

webrender: implement basic `x-create-frame`

view details

Harry Fei

commit sha 2b7680ebf2cc4c309219c67130ab939ddc98f8b6

webrender: implement basic font handlers.

view details

Harry Fei

commit sha a2d965e14c3f8fbcdf7379aff5d9908c9c761e1a

webrender: add frame faces initialization

view details

Harry Fei

commit sha 9c97adff7cf10b44b298f75a2a666d6fe83fa1db

webrender: naive implementation for wr_defined_color

view details

Harry Fei

commit sha a54897695cdb7e8ab3946dbdf94f3e2f3446ab48

webrender: implement default handlers for redisplay_interface

view details

Harry Fei

commit sha ccc9709a078b279e274ceabb1371651141b0b652

webrender: naive implementation for some webrender handlers

view details

push time in 2 months

push eventharryfei/remacs

Harry Fei

commit sha ab193bf46a40ce09835af493ed48e00d752664a2

webrender: add a empty `xw-color-values` lisp function

view details

Harry Fei

commit sha 577c2a78c50afcd4e314b5d56d27d8b7978257e0

webrender: add `x-register-dnd-atom` ad `x-change-window-property`

view details

Harry Fei

commit sha eda023cee8fbb416fe0e9cbc2461a91a47b83497

webrender: add more stub functions for wrterm.

view details

Harry Fei

commit sha 61f7fd9196501a094203086108d0d7176f009032

webrender: add webrender

view details

Harry Fei

commit sha 44f4d076cee6da36e3d7d9fb0625ee01035c8e13

webrender: render basic text

view details

Harry Fei

commit sha c6be98584c710a0d428679e173c2acd7b58ec1fe

webrender: implement more webrender backend functions * `x-display-color-cells` * `x-display-planes` * `x_wm_set_size_hint`

view details

Harry Fei

commit sha df4352561540e5c04c0a50e74a3ae679e11f85d4

webrender: show glyph string color

view details

Harry Fei

commit sha f14885074413b9718dfcc365941289cea28211f3

webrender: fix slant and weight rendering

view details

Harry Fei

commit sha 41bb5c12a0573c179e78809a4f7da89165dd8b8b

webrender: fix non-monospace font rendering

view details

Harry Fei

commit sha f778e811fff47f1c99e991a095405016e3872519

webrender: draw underline

view details

Harry Fei

commit sha 10c88981c1bdf01a1026d0749870ab6cc1da0201

webrender: fix frame column width

view details

Harry Fei

commit sha 9220f9db477c6aacb90b99e1d1f9ee0f1c6a130b

webrender: fix visible height rendering

view details

Harry Fei

commit sha 1d3dde4b39335c6aaf8f1715e8c5de99c4b75010

webrender: fix fringe rendering

view details

Harry Fei

commit sha 945d37b97e1f6e04c76ceb8db11eecaf0e7af8f8

webrender: show vertical window border

view details

Harry Fei

commit sha 98c2c4217aaa35e129aed9333b3f5c7b47e6e7ac

webrender: show right divider

view details

Harry Fei

commit sha fcd2180f7988829858cc15fe3e666659eee3fe8f

webrender: render frame background

view details

Harry Fei

commit sha 5733a755741dac8422f58b4b96f64e0de2be1ba2

webrender: implement `x-display-visual-class`

view details

Harry Fei

commit sha 5118e2bab7ff1db79e6e881303e95d4948811b0a

webrender: implement `x-display-attributes-list`

view details

Harry Fei

commit sha be6781304c94630367e12b6765e0cb3cb74d5f6f

webrender: implement `clear_frame`

view details

Harry Fei

commit sha b2f61552e7b2a4e45593a17bbf7ed582c062d850

webrender: move webrender event loop into a seperated thread

view details

push time in 2 months

pull request commentremacs/remacs

WIP: Webrender graphic backend

@brotzeit I think it will not be very hard to port those code on GUN Emacs master with a official stable rust bindings.

harryfei

comment created time in 2 months

pull request commentremacs/remacs

WIP: Webrender graphic backend

How much effort would it be to put the needed code for this PR on top of current emacs master ?

@brotzeit It has been rebased against master branch :smile:

harryfei

comment created time in 2 months

push eventharryfei/remacs

Harry Fei

commit sha 52fb21ef22de6d9caed46f3252b0abae91d3e57e

webrender: enable x term feature

view details

Harry Fei

commit sha 894022617cf3ccf0c50ec3f01f08a74938536f16

webrender: add cargo feature flag for webrender build

view details

Harry Fei

commit sha e2d5b0b89e1aa6f2862aa617c5ff0243c38621b4

webrender: refactor DispalyInfoRef

view details

Harry Fei

commit sha 043b3b38ad1e71e7c4cb6e13d5bcc8790f0b0082

webrender: fix build window system initialize error

view details

Harry Fei

commit sha ad892e7e64126bfd312f2f6ffe979cd6ec804723

webrender: implement `x-open-connection` and `x-create-frame` basic logic

view details

Harry Fei

commit sha f27abaef5bd6c864dcc577caa1a83a05df6b0713

webrender: refactor create frame logic

view details

Harry Fei

commit sha cf1e1c2e8335f2e935d686b51a8fde6211cafe03

webrender: add Output releate data struct.

view details

Harry Fei

commit sha f6ae33fefdc3184d97a2bd223fec80cce0bbce17

webrender: implement `x-get-focus-frame`

view details

Harry Fei

commit sha 62e267244ca010ce2d054e5a3589d31ec785eace

webrender: implement basic `x-create-frame`

view details

Harry Fei

commit sha 23fdd2111a12889c19a4ce0abd5cf49d7cf34ef3

webrender: implement basic font handlers.

view details

Harry Fei

commit sha 4d513021f1a200bc4ebebb52334e4b1ee16665ca

webrender: add frame faces initialization

view details

Harry Fei

commit sha afc69b19ec75eff7a8f55a5f60ec4e901e236e0d

webrender: naive implementation for wr_defined_color

view details

Harry Fei

commit sha 838668ee36ae6ab75fbf639970155ef385ef5f06

webrender: implement default handlers for redisplay_interface

view details

Harry Fei

commit sha d29c30662fd5a7fbe9e1d06ba2adb8c51561517c

webrender: naive implementation for some webrender handlers

view details

Harry Fei

commit sha cd745c541fbe142b9ab90348afec83611a985232

webrender: add a empty `xw-color-values` lisp function

view details

Harry Fei

commit sha 30b6d65574e9e6040c66566af7d53c05d84f0316

webrender: add `x-register-dnd-atom` ad `x-change-window-property`

view details

Harry Fei

commit sha 5d24e317564b20623710b7d5968627330e37abd9

webrender: add more stub functions for wrterm.

view details

Harry Fei

commit sha 697d55b5cbbbf28be335c320e581dadf9f30caca

webrender: add webrender

view details

Harry Fei

commit sha 0a166341d148bd47d85539e878a9f0a36f8f9de2

webrender: render basic text

view details

Harry Fei

commit sha b174dea91dec17bf190e01baf04e582d56b5fd79

webrender: implement more webrender backend functions * `x-display-color-cells` * `x-display-planes` * `x_wm_set_size_hint`

view details

push time in 2 months

push eventharryfei/remacs

Harry Fei

commit sha 52fb21ef22de6d9caed46f3252b0abae91d3e57e

webrender: enable x term feature

view details

Harry Fei

commit sha 894022617cf3ccf0c50ec3f01f08a74938536f16

webrender: add cargo feature flag for webrender build

view details

Harry Fei

commit sha e2d5b0b89e1aa6f2862aa617c5ff0243c38621b4

webrender: refactor DispalyInfoRef

view details

Harry Fei

commit sha 043b3b38ad1e71e7c4cb6e13d5bcc8790f0b0082

webrender: fix build window system initialize error

view details

Harry Fei

commit sha ad892e7e64126bfd312f2f6ffe979cd6ec804723

webrender: implement `x-open-connection` and `x-create-frame` basic logic

view details

Harry Fei

commit sha f27abaef5bd6c864dcc577caa1a83a05df6b0713

webrender: refactor create frame logic

view details

Harry Fei

commit sha cf1e1c2e8335f2e935d686b51a8fde6211cafe03

webrender: add Output releate data struct.

view details

Harry Fei

commit sha f6ae33fefdc3184d97a2bd223fec80cce0bbce17

webrender: implement `x-get-focus-frame`

view details

Harry Fei

commit sha 62e267244ca010ce2d054e5a3589d31ec785eace

webrender: implement basic `x-create-frame`

view details

Harry Fei

commit sha 23fdd2111a12889c19a4ce0abd5cf49d7cf34ef3

webrender: implement basic font handlers.

view details

Harry Fei

commit sha 4d513021f1a200bc4ebebb52334e4b1ee16665ca

webrender: add frame faces initialization

view details

Harry Fei

commit sha afc69b19ec75eff7a8f55a5f60ec4e901e236e0d

webrender: naive implementation for wr_defined_color

view details

Harry Fei

commit sha 838668ee36ae6ab75fbf639970155ef385ef5f06

webrender: implement default handlers for redisplay_interface

view details

Harry Fei

commit sha d29c30662fd5a7fbe9e1d06ba2adb8c51561517c

webrender: naive implementation for some webrender handlers

view details

Harry Fei

commit sha cd745c541fbe142b9ab90348afec83611a985232

webrender: add a empty `xw-color-values` lisp function

view details

Harry Fei

commit sha 30b6d65574e9e6040c66566af7d53c05d84f0316

webrender: add `x-register-dnd-atom` ad `x-change-window-property`

view details

Harry Fei

commit sha 5d24e317564b20623710b7d5968627330e37abd9

webrender: add more stub functions for wrterm.

view details

Harry Fei

commit sha 697d55b5cbbbf28be335c320e581dadf9f30caca

webrender: add webrender

view details

Harry Fei

commit sha 0a166341d148bd47d85539e878a9f0a36f8f9de2

webrender: render basic text

view details

Harry Fei

commit sha b174dea91dec17bf190e01baf04e582d56b5fd79

webrender: implement more webrender backend functions * `x-display-color-cells` * `x-display-planes` * `x_wm_set_size_hint`

view details

push time in 2 months

create barnchharryfei/remacs

branch : webrender-2

created branch time in 2 months

push eventharryfei/which-rs

Harry Fei

commit sha 3c34de161704600607cb01d0ed7f10901bd99bad

fix build warning

view details

push time in 2 months

push eventharryfei/which-rs

Harry Fei

commit sha 3c34de161704600607cb01d0ed7f10901bd99bad

fix build warning

view details

push time in 2 months

startedheroiclabs/nakama

started time in 2 months

push eventharryfei/which-rs

Harry Fei

commit sha ece4967b2aa4de1ac3c5f7e1cbc5fb8c7d2764ca

fix build warning

view details

push time in 2 months

PR opened remacs/remacs

WIP: Webrender graphic backend

This webrender experimental integration can support my basic editing work. Welcome everyone to try/test it. Currently, it only supports Linux platform(X11 and Wayland).

Build steps:

./configure --with-webrender
make
+6079 -466

0 comment

43 changed files

pr created time in 2 months

push eventharryfei/remacs

Harry Fei

commit sha 09f5bfceae5e97bca8bcb66d6423567610bea797

upgrade `rand` crates version to 0.7.3.

view details

Harry Fei

commit sha 755b41d7136ce47c582bea26faad4d1f9cace9fe

webrender: Add webrender backend file wrterm.h and wrgui.h.

view details

Harry Fei

commit sha c45c8fe431e7d42ae2d9b2602d7f8fdf52a36c30

webrender: clean wrterm

view details

Harry Fei

commit sha 404b0346e8a992fecb496b0d0ccbc734c3a3215f

webrender: minized extern functions

view details

Harry Fei

commit sha b47b028751cab1667c43beb23dd68cd9bda05929

webrender: correct comments

view details

Harry Fei

commit sha cf76a3861fbcde7ab91ace65c6d0bd8efb780053

webrender: add more FRAME_X macros

view details

Harry Fei

commit sha 872206253d96942274fe7162a5d245746a14b9bf

webrender: add most wenrender stub functions

view details

Harry Fei

commit sha 0b713282fa38dfef874b3bd454d58a701439e385

webrender: enable x term feature

view details

Harry Fei

commit sha fb26cd26fc510ee1c3cae1a147bc2d236947e455

webrender: add cargo feature flag for webrender build

view details

Harry Fei

commit sha 34a56490a42d6a0a25e84e44ac80e92fc1ab06a6

webrender: refactor DispalyInfoRef

view details

Harry Fei

commit sha 89295326838add19661042330ea953858cb39ff8

webrender: fix build window system initialize error

view details

Harry Fei

commit sha d1b9372e1df558043b133024e22b45c2b21121fe

webrender: implement `x-open-connection` and `x-create-frame` basic logic

view details

Harry Fei

commit sha c6fc09faec00a9d65d66beda279fec549a6b08ac

webrender: refactor create frame logic

view details

Harry Fei

commit sha 5fc5379c5c243e3df806ee96104270211efdaa2b

webrender: add Output releate data struct.

view details

Harry Fei

commit sha dde01c1de745c22ad5b5f53daa2452d208271f4f

webrender: implement `x-get-focus-frame`

view details

Harry Fei

commit sha dfbc37a9916cb275397742b9f8c97fb8d5f381fa

webrender: implement basic `x-create-frame`

view details

Harry Fei

commit sha 3ae019496aa24573d19906dd0bbdd9f5054679cc

webrender: implement basic font handlers.

view details

Harry Fei

commit sha 4d8411b8945b295da76c537100b7a07f4333bd34

webrender: add frame faces initialization

view details

Harry Fei

commit sha 08fd1391f29e1b99f8ce4d745fe38c066f814024

webrender: naive implementation for wr_defined_color

view details

Harry Fei

commit sha 4cab867c8ac87bf2bbaa40737e161ba1993ad185

webrender: implement default handlers for redisplay_interface

view details

push time in 2 months

push eventharryfei/which-rs

Harry Fei

commit sha 8e09dc068df8d65cd1a37de8b2e157d21b498c12

fix build warning

view details

push time in 2 months

create barnchharryfei/which-rs

branch : fix-build-warning

created branch time in 2 months

created tagharryfei/which-rs

tag4.0.2

A Rust equivalent of Unix command "which".

created time in 2 months

push eventharryfei/remacs

Harry Fei

commit sha c0a72816edc9707b2a93d3eb905aa281bdf4a206

add title

view details

Harry Fei

commit sha e67661708082091238382f1f7e23abf3b02f917a

add selectable channel

view details

push time in 2 months

push eventharryfei/remacs

Harry Fei

commit sha ee678ca51a4ac7ee5a9c03c1cbf634ef86ec10f9

preserve frame output pixel when rendering

view details

push time in 2 months

push eventharryfei/remacs

Harry Fei

commit sha f9804fe3a8d8ba72c6cad8ec782966f30ad81139

webrender: make webrender resizable

view details

push time in 2 months

push eventharryfei/remacs

Daniel Brooks

commit sha 4fa83185834d76441d8741cdf69058d8526a1216

add a test for at least one aspect of store_symval_forwarding

view details

Sean Perry

commit sha 3a7e0de0575a2dbda29e45b86772e344c2c2dabb

add a test for at least one aspect of store_symval_forwarding add a test for at least one aspect of store_symval_forwarding

view details

Simon Pugnet

commit sha 51b7cfa2e8bc53ce1f379ca6941dba6fff005082

Modifies Dockerfiles for current Rust toolchain This commit changes all Dockerfiles so that the nightly-2020-04-07 Rust toolchain is used since this was changed in 5b59c0f77113a1330853cff077a08f00c8f7fc88. Without this change, building via a Docker container fails due to the Rust toolchain incompatibility.

view details

Sean Perry

commit sha 82ceb3399dc8b768679ac0f8df8b86b4e24745d8

Merge pull request #1577 from polaris64/master Modifies Dockerfiles for current Rust toolchain

view details

Jonas Bernoulli

commit sha dabedee6610df62bbb7cd18119e03b6a1975876c

Wrap lines in README.md

view details

Sean Perry

commit sha 872ca47cc22c5ee12cc23e4f88a14141b315be35

Merge pull request #1579 from tarsius/wrap Wrap lines in README.md

view details

Harry Fei

commit sha 2a815af04ae01c4d3b1e887dbf59a97a4913d616

upgrade `rand` crates version to 0.7.3.

view details

Harry Fei

commit sha 29d4de01e0a7a9db60b4e36c8279dafb766eb0ba

Add webrender backend file wrterm.h and wrgui.h.

view details

Harry Fei

commit sha af386053a93629df868580c79e40c31a284a7ed3

clean wrterm

view details

Harry Fei

commit sha cc70d4c8b94c068a691875f866e461060c775457

minized extern functions

view details

Harry Fei

commit sha 4c1a3ad936e7070fc1cb723ac76dfadcaab821ae

correct comments

view details

Harry Fei

commit sha 34d80ec6d84d8d5157c5f269b531118245cb49bd

add more FRAME_X macros

view details

Harry Fei

commit sha 9682e74e0bb63b37ff9ae1919ec433aef4336ae1

add most wenrender stub functions

view details

Harry Fei

commit sha 9d5e96f50b299347171fe7bfe8df637b30c8bd59

enable x term feature

view details

Harry Fei

commit sha cc48cb5d40b4715bd01fb07fad6ae6af7c8a7e1c

add cargo feature flag for webrender build

view details

Harry Fei

commit sha 02f4326854e99c8cfe9e1a585b0ebdbc270be20d

refactor DispalyInfoRef

view details

Harry Fei

commit sha 89132928f09170a5c95a809cf00fc305b48c304c

fix build window system initialize error

view details

Harry Fei

commit sha 2cf998f574be473c5add0d0bded27e519602ca49

implement `x-open-connection` and `x-create-frame` basic logic

view details

Harry Fei

commit sha a872fae43ba7ac444bc245abc45a946cdef9c5c3

refactor create frame logic

view details

Harry Fei

commit sha 19bc87118c24e3c1aa2ab4e62421b781a63a574b

add Output releate data struct.

view details

push time in 2 months

push eventharryfei/remacs

Harry Fei

commit sha a4bc8d4c27e2cc8d3c619fd294718cd234b8e062

Add webrender backend file wrterm.h and wrgui.h.

view details

Harry Fei

commit sha 17bc3d81b28c353d3c32fbe393054aeaf23f542e

clean wrterm

view details

Harry Fei

commit sha 6d9049ba4d52665247b60c3bb589bfcdc43f69f9

minized extern functions

view details

Harry Fei

commit sha b9e045e1e56648edda7129fdd9d36814d296eac5

correct comments

view details

Harry Fei

commit sha 5de232e63ee1a4cdf450d2f1b9379314b761df42

add more FRAME_X macros

view details

Harry Fei

commit sha 49bcb1e3cd46ef41e6c1370d4e9ec7701059b8be

add most wenrender stub functions

view details

Harry Fei

commit sha 17ae8d95803d5f668f56ee943844709e6ef4c8e8

enable x term feature

view details

Harry Fei

commit sha a963a0e4051dede5f1349dd0d7082d7203cdf469

add cargo feature flag for webrender build

view details

Harry Fei

commit sha 96973a88d24d6234971a7feb8b88bd870f3e8e48

refactor DispalyInfoRef

view details

Harry Fei

commit sha f13e43ba67db5ff55b1c2d0632ea556b796ac4fa

fix build window system initialize error

view details

Harry Fei

commit sha 06fbdfe608ae1f27a7aa1e6986e39d14a6750631

implement `x-open-connection` and `x-create-frame` basic logic

view details

Harry Fei

commit sha b93813620bc123dac540f3d0848348cc863cd9b3

refactor create frame logic

view details

Harry Fei

commit sha 9077139b39b891f21efb423ff79b889317ddeda3

add Output releate data struct.

view details

Harry Fei

commit sha 1143367d995663d7e925c2909f9475bfccc3879f

implement `x-get-focus-frame`

view details

Harry Fei

commit sha 925b51b2703dd8197410cba263ea499ca12eb608

implement basic `x-create-frame`

view details

Harry Fei

commit sha 1bf6fabd62dea0eea03bbc447c7990af0acc65ef

implement basic font handlers.

view details

Harry Fei

commit sha 687153804b898525baf068c0fdc4d5dcddf3c99b

add frame faces initialization

view details

Harry Fei

commit sha 7a3815d3b54e6d8a10a76c45d5a2bf5329104385

naive implementation for wr_defined_color

view details

Harry Fei

commit sha d98f0dddb2b082c9001a2a74f8c56521487cd22f

implement default handlers for redisplay_interface

view details

Harry Fei

commit sha abf69a78372611d1e0e47454331388b745508874

naive implementation for some webrender handlers

view details

push time in 2 months

push eventharryfei/remacs

Harry Fei

commit sha a718bf89cff9ddf9736a2e5cb32e97278c3d9f4f

implement `clear_frame`

view details

Harry Fei

commit sha fd4fcbb007368b866f69f7fd8397c205b34eb354

tmp thread

view details

Harry Fei

commit sha c4dbf84594df729a9d0691a1fe1638272e1576e3

implement keyboard

view details

Harry Fei

commit sha 18f4efc2bdc2388152051343021c465633690434

speedup keyboard intput

view details

Harry Fei

commit sha faf86f4f954583f93c8fdc70b9cca56a70a6a375

add `scroll_run_hook`

view details

Harry Fei

commit sha c27cdb183d36fac11b609a8023ffb8b0b5634b84

fix dashed font name matching issue on Linux platform

view details

Harry Fei

commit sha 50cbc77c02efb17053051c139932c5104a819f09

webrender: show window cursor

view details

Harry Fei

commit sha 4c26a9d22b9ae024e339783196e3eff107aaea10

implement `after_update_window_line`

view details

Harry Fei

commit sha e99142923494a638f3251a3d5a818ca4e4edb9c7

implement `stretch_string`

view details

Harry Fei

commit sha 1fbe15ebbce0d531705082bebb33aa2c3fff1ea5

add `x_own_selection_internal` and `x_get_selection_internal`.

view details

Harry Fei

commit sha 19e487ec55d7d9f16b542f5d52971a422347d548

webrender: make webrender resizable

view details

push time in 2 months

push eventharryfei/remacs

Harry Fei

commit sha 38a9145eda74c4a6b2f1d287d9798e3686660a27

try: implement scroll run

view details

Harry Fei

commit sha e189f7d70ed1c74819f3a4b39aa76db7fd4119a8

implement keyboard

view details

Harry Fei

commit sha 242e965e64bbf80e422b733175997570f44b37bf

support more keyboard key

view details

Harry Fei

commit sha e496e51d9a115a58c53c60c5c2933020649271f7

webrender: show window cursor

view details

Harry Fei

commit sha 7571ef78767be97e36783fc5ddc1cc8b827fe450

implement `after_update_window_line`

view details

Harry Fei

commit sha dc740b5e7b2b8f467f1a8758ff6b8594f41d7100

implement `stretch_string`

view details

Harry Fei

commit sha ba3f00ef810e27ee0c68b1f5a16b24c3c506fbe9

add `x_own_selection_internal` and `x_get_selection_internal`.

view details

Harry Fei

commit sha 67cd3b277ec2b0648209b332378d0b355b63f39c

webrender: make webrender resizable

view details

push time in 2 months

push eventharryfei/remacs

Harry Fei

commit sha aa4492ad4a7d4d66993677572a76682f02159a00

webrender: show window cursor

view details

Harry Fei

commit sha 157580d9fda0f83e6cdc8ba13426df1d58b46796

implement `after_update_window_line`

view details

Harry Fei

commit sha 11b1719c64e459b4b52498163775e94a2d806569

implement `stretch_string`

view details

Harry Fei

commit sha 3c7d47c6c34be706c21ae9cd717f4b71783e1008

add `x_own_selection_internal` and `x_get_selection_internal`.

view details

Harry Fei

commit sha 47829c0fb675fe63684caf1f4f7da066b54a3bec

temp fix black screen

view details

Harry Fei

commit sha 95b1c67f13cf28b14222b440b4f6cd27a3ddaf84

webrender: make webrender resizable

view details

push time in 2 months

push eventharryfei/remacs

Harry Fei

commit sha 2e533d628602ae6bd473b72ae28394bf7ad93a32

tmp thread

view details

Harry Fei

commit sha 4c80fb56463fa68e076980ba8b16e5e11b61c839

temp keyboard

view details

Harry Fei

commit sha ac872e2668a6a571fac4210bec0faa3d7c5c0a9e

add `scroll_run_hook`

view details

Harry Fei

commit sha 1e480eb37505cc4c407783ac323e36eabade0954

fix dashed font name matching issue on Linux platform

view details

Harry Fei

commit sha 1549bddf93076ebea1e4aa450b2b240d57a64221

try speedup keyboard intput

view details

Harry Fei

commit sha db2e5aab9667a872cd1a047e82860d4f8ef70836

try: implement scroll run

view details

Harry Fei

commit sha 7c34f5783e4fd26bb9df884bb9968cefbc9f5f06

implement keyboard

view details

Harry Fei

commit sha e4b3ee6466051954d9f50dec8116ba2f39e87dad

support more keyboard key

view details

Harry Fei

commit sha 50d0c364d3ce2894ebcfacca0cb6b0426e864453

webrender: show window cursor

view details

Harry Fei

commit sha ce3332ccb5c41ba2d3e5f7212555f0ba9756f7c2

implement `after_update_window_line`

view details

Harry Fei

commit sha 40d58e8c2f69e719808ede5bc09933fd406f5e42

implement `stretch_string`

view details

Harry Fei

commit sha d39a498c6e4eadbde3ae07d32515880bfda326e1

add `x_own_selection_internal` and `x_get_selection_internal`.

view details

Harry Fei

commit sha 8bcc6c92f85f089eeef2052426197bd996ba4517

temp fix black screen

view details

Harry Fei

commit sha 0bf5b3e8d91f6206c7bd5699993be2b76cc47478

webrender: make webrender resizable

view details

Harry Fei

commit sha 48972a1983766d0ee14f57e2bb39efa3608c4a1b

fix highlight frame

view details

push time in 2 months

push eventharryfei/remacs

Harry Fei

commit sha 0180d8c4d2782b9b72539e3263d9b2db35144529

implement keyboard

view details

Harry Fei

commit sha 9af3b4ddfb13724e14486eb5014f43bac98baf74

support more keyboard key

view details

Harry Fei

commit sha e768f969f0e42c39a6ace13e17eb6990780d3c8a

webrender: show window cursor

view details

Harry Fei

commit sha 6fed3768656f4b74933c559afa2d10740d07d634

implement `after_update_window_line`

view details

Harry Fei

commit sha 0593e9e23807fece981b68e268df033eb8dab73c

implement `stretch_string`

view details

Harry Fei

commit sha 71ccbe291c4be3b6597104d0a6199bf77ec5dc75

add `x_own_selection_internal` and `x_get_selection_internal`.

view details

Harry Fei

commit sha 4397bd67c86219c09a7eb54b856a635e5c45bb02

temp fix black screen

view details

Harry Fei

commit sha bd140fd864388396385eb18a369b89a6af3536eb

webrender: make webrender resizable

view details

Harry Fei

commit sha 8820621f0d4cebbb8837147abfffe42b4e0eb1b6

fix highlight frame

view details

push time in 2 months

push eventharryfei/remacs

Harry Fei

commit sha 22522910ab2d3814ea6ce907f43763872e2d7119

tmp thread

view details

Harry Fei

commit sha 075c165d5e22bdf238d41b718fee9fd0c6ced259

temp keyboard

view details

Harry Fei

commit sha 608908155b16ae2ab06103064262b1844b4297eb

add `scroll_run_hook`

view details

Harry Fei

commit sha a80363ec98c31dc713013e952032bc6b84918e01

fix dashed font name matching issue on Linux platform

view details

Harry Fei

commit sha 2364426644665989318572bdeca1176f2b870826

try speedup keyboard intput

view details

Harry Fei

commit sha 392c1a6b075fb52a36140a4decef2f6e74c9dbde

try: implement scroll run

view details

Harry Fei

commit sha 5908991c5f62d6bedc58cbf2db57c57d4de60f40

implement keyboard

view details

Harry Fei

commit sha bc8bcb1689559c478b2ebbf0812a57875acbfbbd

support more keyboard key

view details

Harry Fei

commit sha 1a520aedaff78e95aabd28ba4a87e1eb59dcf0bc

webrender: show window cursor

view details

Harry Fei

commit sha 20ee986900cae23920a183b7558b003ba37940ae

implement `after_update_window_line`

view details

Harry Fei

commit sha 319b396dc2fbd6aca17062cc7df186ad8f38f6b7

implement `stretch_string`

view details

Harry Fei

commit sha afde305708cbcfe2bae6022b10c99d675911cea9

add `x_own_selection_internal` and `x_get_selection_internal`.

view details

Harry Fei

commit sha b5661ab5a8511d352de8ea6a359874108ef5ce43

temp fix black screen

view details

Harry Fei

commit sha 372b2176a09a1d41a349315d01ac16e3d277164e

webrender: make webrender resizable

view details

Harry Fei

commit sha 457c03f58e5a12955d89704e8c67738d83abb85c

fix highlight frame

view details

push time in 2 months

issue commentTrantect/win_driver_example

ICE "data-layout... differs from LLVM default"

We use rustc +nightly -Z unstable-options --print target-spec-json --target x86_64-unknown-linux-gnu to generate the x86_64-kernel-windows-msvc.json (with fixing some necessary fields). I think you can replace data-layout value to the expected one e-m:w-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128.

PeterGV

comment created time in 3 months

pull request commentharryfei/which-rs

Support symlinked executables on Windows

@fdncred Yeah, I released 4.0.2 on crates.io. Just forget to create 4.0.1 tag on GH. :smile:

charlespierce

comment created time in 3 months

push eventharryfei/which-rs

Atul Bhosale

commit sha fba9ccf6ad485cecaeec58575c86d9bcfab3701d

Add cargo fmt to travis build config

view details

Harry Fei

commit sha f79d01ce1dff56f466999dd39dccf4a1f359f517

Merge pull request #26 from Atul9/add-cargofmt-to-travis-config Add cargo fmt to travis build config

view details

push time in 3 months

pull request commentharryfei/which-rs

Add cargo fmt to travis build config

Thanks.

Atul9

comment created time in 3 months

pull request commentharryfei/which-rs

Support symlinked executables on Windows

@fdncred Done already. :smile:

charlespierce

comment created time in 3 months

push eventharryfei/which-rs

Harry Fei

commit sha b5ab0940278ff0e5a5f864a4138098f5fbd9d868

bump version to 4.0.2

view details

push time in 3 months

pull request commentharryfei/which-rs

Support symlinked executables on Windows

I will publish the new version.

charlespierce

comment created time in 3 months

push eventharryfei/which-rs

Charles Pierce

commit sha 3b9f37a3a01436198c59ee780f0d87ad74beaef5

Support symlinked executables on Windows

view details

Harry Fei

commit sha 5dad17ec2f21a7f0a2998688d92cd2b81df0ad8b

Merge pull request #25 from charlespierce/windows_symlinks Support symlinked executables on Windows

view details

push time in 3 months

PR merged harryfei/which-rs

Support symlinked executables on Windows

Info

The fix to support Windows Reparse Points in #23 inadvertently resulted in actual Windows symlinks being skipped. Since fs::symlink_metadata doesn't traverse symlinks, calling it on a symlink will result in is_file being false, cause which to incorrectly ignore the symlink.

Changes

  • Added an additional check for is_symlink in the Windows branch of the ExistedChecker, which correctly includes actual symlinks as well as potentially executable.

Tested

  • Created a symlink to a .exe file locally (following these steps) and confirmed that this change can detect the linked executable.
  • Created a symlink to a directory and confirmed that which still correctly detects directories aren't executable.

Note

+6 -3

3 comments

1 changed file

charlespierce

pr closed time in 3 months

pull request commentharryfei/which-rs

Support symlinked executables on Windows

Sorry, I missed this PR. Is it a break change? Should I increase the major number when publish the new version?

charlespierce

comment created time in 3 months

startedkompics/kompact

started time in 3 months

more