profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/guewen/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Guewen Baconnier guewen @qoqa Lausanne

damdam-s/connector-magento 0

Connect Odoo with Magento

grindtildeath/sale-workflow 0

Odoo Sales, Workflow and Organization

grindtildeath/wms 0

Warehouse Management System for advance logistic with Odoo

guewen/account-analytic 0

Odoo Account Analytic Related Addons

pull request commentcamptocamp/marabunta

terere

🤨

leemannd

comment created time in 2 hours

issue commentOCA/connector

Use of 'should_import' leads to failed sync

I suppose you could override the run method and do your check before calling super?

Reading the code, l agree the role of _should_import is not obvious. It's role is to tell if the exporter should schedule an import of the record, the use case being that the last update (sync date) is earlier than the last update date on the external system and we want to import updated data from it after the export to get the updated values.

An example in _should_import would be to read the update date on the external system's API and compare it with the sync date of the binding.

thomaspaulb

comment created time in 4 days

pull request commentOCA/queue

[IMP] no need for base_sparse_field anymore since 0f5ec1

/ocabot merge patch

nilshamerlinck

comment created time in 5 days

pull request commentOCA/queue

[13.0] Vacuum done jobs in batch

/ocabot merge patch

mlaitinen

comment created time in 5 days

PullRequestReviewEvent

issue closedOCA/queue

[12.0] queue_job, missing _compute_job_function

Hi @guewen,

https://github.com/OCA/queue/blob/d76f43527e14500a9c777890ed9bba4390688f7e/queue_job/models/queue_job.py#L105-L107

seems _compute_job_function is missing on queue_job, should it be added or compute needs to be removed?

closed time in 5 days

GSLabIt

issue commentOCA/queue

[13.0] Concurrent update access error when eta undefined.

The channel name channel='root.module_registry triggers a doubt. Is the job doing something related to the door registry? Such as updating or installing modules? When doing so, odoo would invalidate the registry, which is used by the job mechanic...

mads-vkd

comment created time in 5 days

issue commentOCA/queue

[13.0] Concurrent update access error when eta undefined.

IIRC, the number of try may ignore the max when the job is retried because of a concurrency error. Do you get this behavior with all the job methods? Or only this one? If so, what is the content of the method executed by the job?

mads-vkd

comment created time in 5 days

pull request commentOCA/queue

[14.0][MIG] - queue_job_subscribe

What is this error?

/ocabot merge nobump

sbejaoui

comment created time in 5 days

Pull request review commentOCA/l10n-switzerland

[12.0][ADD] module l10n_ch_delivery_carrier_label_quickpac

+# Copyright 2021 Camptocamp SA+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).+import base64++from odoo import _, api, models+from odoo.exceptions import UserError++from ..quickpac.web_service import QuickpacWebService+++class StockPicking(models.Model):+    _inherit = "stock.picking"++    @api.multi+    @api.onchange("carrier_id")+    def onchange_carrier_id(self):+        for picking in self:+            partner = picking.partner_id+            delivery_type = picking.carrier_id.delivery_type+            if delivery_type != "quickpac" or not partner:+                continue+            service = QuickpacWebService(picking.company_id)+            if not service.is_deliverable_zipcode(partner.zip):+                raise UserError(+                    _("This partner is undeliverable (invalid zipcode).")+                )

I think it is not a good idea to block the selection of the delivery method at this point. A given ZIP can be invalid today, but valid in 3 days (or valid today and invalid in 3 days), so if a user sets the delivery method some days before the delivery, IMO they should be able to select it (which can be a default value or set from the sale order BTW) whatever. Only the generation of the label should actually be prevented if the ZIP is not valid.

StephaneMangin

comment created time in 7 days

PullRequestReviewEvent

issue commentOCA/connector

Unittests Fail with Dependant Modules to be tested

If you don't want this behavior, you should use the SavepointComponentCase. The ComponentRegistryCase excludes the current addon components so you can load only the component you want to test. It is widely used in the core tests for instance. But for an implementation, you may not need it at all.

agenterp

comment created time in 13 days

pull request commentOCA/queue

[IMP] queue_job: Add cancelled state to queue.job

/ocabot merge minor

hbrunn

comment created time in 18 days

pull request commentOCA/queue

[IMP] queue_job: allow to change jobs to paused channel

Thanks for the proposal!

A question for my understanding, as I see you propose a default root.pause channel which is a nice idea for UX, did you check if we are able to pause another channel by setting a capacity of 0 in the jobrunner's config?

E.g. if I put

  • root:4,root.foo:2,root.bar:0, is root.bar paused?
  • root:4,root.foo:2,root.bar:0,root.bar.baz:2 are both root.bar and root.baz paused?
fernandahf

comment created time in 18 days

pull request commentOCA/queue

[13.0][IMP] queue_job current company

Hi, maybe I don't get the use case properly, but I'm not sure to agree with:

using a serialized context is not in opposition with this solution as the key allowed_company_ids is not always in the context

If the job was called synchronously like a normal method, and the allowed_company_ids was not in the context, you would have the same issue then? So it means the issue is on the caller not setting it. I don't see why calling asynchronously would need to have a different behavior? And if the caller did set allowed_company_ids then if we store the context, we'll have it automatically.

acsonefho

comment created time in 18 days

push eventOCA/connector

Guewen Baconnier

commit sha 28220fd2a4a4ae29b7d84d50b20f5e03e2fdd2b3

rebuild pages at ec6ffb5 on branch 11.0

view details

push time in 19 days

pull request commentOCA/connector

11.0 backport pull 387

/ocabot merge minor

Yep 👍

agenterp

comment created time in 19 days

pull request commentOCA/queue

[12.0] Fix field channel_method_name is not computed

/ocabot merge patch

guewen

comment created time in 21 days

PullRequestReviewEvent

pull request commentOCA/connector

11.0 backport pull 387

flake8 fails because of

connector/components/synchronizer.py:164:58: W291 trailing whitespace
connector/components/synchronizer.py:352:70: W291 trailing whitespace

I can't see why pylint fails, but maybe the failure is actually only because of flake8?

agenterp

comment created time in 22 days

push eventguewen/queue

Guewen Baconnier

commit sha eae4e313669c1545cf3fa55a082ee1aa3f776268

Add a smart button to open all the jobs of a graph

view details

Guewen Baconnier

commit sha c6294f012b36c3de66a0c9d561485451b87ae2ec

Fix duplicate label

view details

Guewen Baconnier

commit sha bdcf8ad3da22b03c2b473e80d1ec721f0112da96

Fix graph widget now showing title as HTML From https://visjs.github.io/vis-network/examples/network/other/html-in-titles.html

view details

Guewen Baconnier

commit sha 5a0c50b9a14b1626030282aab64c1c8d44c410b6

Improve graph widget performance When showing large graphs, like 300 jobs (not really a real life case maybe), the graph takes a dozen of seconds to render. Disabling the stabilization helps a lot.

view details

Guewen Baconnier

commit sha 180d84286af5132cafa68ca58cbb024263d3cb40

Escape strings passed to the graph js widget

view details

Guewen Baconnier

commit sha becefb5904ab11a2e3efec8eb293e31123f13bc8

Fix lint

view details

push time in 25 days

pull request commentOCA/connector

11.0 backport pull 387

The linter may be a new check, could you add # pylint: disable=E8102 on the cr.commit() lines as it was done in more recent versions, so the build is green? https://github.com/OCA/connector/blob/9f04ca1897991ef639d0be6f8f48cea805314871/connector/components/synchronizer.py#L165

agenterp

comment created time in 25 days

Pull request review commentOCA/queue

[DRAFT][12.0] Add graph of dependencies between jobs

                         />                     <field name="state"                         widget="statusbar"-                        statusbar_visible="pending,enqueued,started,done"+                        statusbar_visible="wait_dependencies,pending,enqueued,started,done"                         statusbar_colors='{"failed":"red","done":"green"}'/>                 </header>                 <sheet>+                    <div class="oe_button_box" name="button_box">+                        <button+                            name="open_graph_jobs"+                            type="object"+                            class="oe_stat_button"+                            icon="fa-pencil-square-o"

The sitemap is great, thanks!

guewen

comment created time in 25 days

PullRequestReviewEvent

pull request commentOCA/queue

[12.0] Fix field channel_method_name is not computed

It's related to https://github.com/odoo/odoo/pull/75387

guewen

comment created time in a month

pull request commentOCA/queue

[12.0] Fix field channel_method_name is not computed

/ocabot merge patch

guewen

comment created time in a month

issue commentOCA/queue

[12.0] queue_job, missing _compute_job_function

Hi, thanks, see #357, waiting for reviews 🙂

GSLabIt

comment created time in a month

PullRequestReviewEvent

Pull request review commentOCA/server-auth

[FIX] auth_totp: Issues #163 and #187

 def unquote(cls, value):   class AuthTotp(Home):+     @http.route()     def web_login(self, *args, **kwargs):-        response = super(AuthTotp, self).web_login(*args, **kwargs)-+        if request.params.get('login') and request.params.get('password'):+            User = request.env["res.users"]+            uid = User.sudo().authenticate(+                request.params.get('db'),+                request.params.get('login'),+                request.params.get('password'),+                {}+            )+            if uid:+                user = User.browse(uid).sudo()+                if user.mfa_enabled:+                    return self.redirect(http)

Maybe you are right @leemannd that it should be redirected to /auth_totp/login because it happens when the secured cookie is expired.

max3903

comment created time in a month

PullRequestReviewEvent