profile
viewpoint

Blockstream/docs 6

Blockstream product documentation

grubles/lightning-charge 2

A simple drop-in solution for accepting lightning payments

grubles/nanotip 1

:zap: Lightning Tip Box :zap:

grubles/slate 1

Beautiful static documentation for your API

grubles/spruned 1

A Bitcoin lightweight pseudonode with RPC that can fetch any block or transaction

grubles/txtenna-python 1

Python based version of txtenna that can send and receive Bitcoin transactions via a local txtenna-server

grubles/bitcoin 0

Bitcoin Core integration/staging tree

grubles/bitcoin-images 0

This repository contains some useful Docker images.

grubles/btcpayserver 0

A cross platform, self-hosted server compatible with Bitpay API

grubles/docs 0

Blockstream product documentation

PR closed shesek/spark-wallet

make client module build independently

in clean environment:

cd spark-wallet/client && PATH=$PATH:./node_modules/.bin/ ./build.sh
+ shopt -s extglob
+ : dist
+ : production
+ : web
+ export BUILD_TARGET
+ export NODE_ENV
++ node -p 'require("../package").version'
+ export VERSION=0.2.16
+ VERSION=0.2.16
+ rm -rf 'dist/*'
+ mkdir -p dist dist/lib dist/fonts dist/swatch
+ [[ -d node_modules ]]
+ cp -r www/favicon.ico www/manifest www/notification.png dist/
+ cp -r 'fonts/node_modules/typeface-*' dist/fonts/
cp: cannot stat 'fonts/node_modules/typeface-*': No such file or directory

this fixes that.

CI failing addressed in #170

+26 -1

5 comments

3 changed files

Legogris

pr closed time in 15 minutes

pull request commentshesek/spark-wallet

make client module build independently

For Spark's docker image, I'm using npm config set unsafe-perm true, which I find preferable to adding --unsafe-perm to npm install because it only affects the Docker environment and doesn't use unsafe perms when I'm running build.sh directly on my host.

Could you do this in your Dockerfile too?

Make sense! Closing this in favor of #169

Legogris

comment created time in 15 minutes

pull request commentshesek/spark-wallet

fix: CI install recent jdk8 deb9u1 version

Thanks!

I don't think Dependabot will work for apt packages installed in a Dockerfile, will it?

Wasn't sure actually - you're right but there's an open ticket for it: https://github.com/dependabot/dependabot-core/issues/2129

Legogris

comment created time in 17 minutes

pull request commentshesek/spark-wallet

fix: CI install recent jdk8 deb9u1 version

Thanks!

I don't think Dependabot will work for apt packages installed in a Dockerfile, will it?

Legogris

comment created time in 44 minutes

push eventshesek/spark-wallet

Robert Edström

commit sha 1548a8e858162c4dfcb4f572a135653f866feab5

fix: CI install recent jdk8 deb9u1 version (#170) https://github.com/shesek/spark-wallet/pull/163

view details

push time in 44 minutes

PR merged shesek/spark-wallet

fix: CI install recent jdk8 deb9u1 version

https://github.com/shesek/spark-wallet/pull/163

@shesek Have you looked at setting up Dependabot on this repo? It makes automated PRs when packages are updated upstream.

+1 -1

0 comment

1 changed file

Legogris

pr closed time in 44 minutes

push eventshesek/spark-wallet

Nadav Ivgi

commit sha 46b789b90f2ac20f869cf1887a10470158435d99

Install @babel/polyfill under client Refs #169

view details

push time in 2 hours

pull request commentshesek/spark-wallet

make client module build independently

@babel/polyfill seems to be the only thing missing to make the client module self-contained - would you agree to containing it here?

Yeah, sure, I can definitely add this to client/package.json if this makes things easier.

the issue had nothing to do with my initial commit. Since i ran this in a docker container as root, postinstall does not execute properly for npm install. I propose using npm --unsafe-perm, which fixes this.

For Spark's docker image, I'm using npm config set unsafe-perm true, which I find preferable to adding --unsafe-perm to npm install because it only affects the Docker environment and doesn't use unsafe perms when I'm running build.sh directly on my host.

Could you do this in your Dockerfile too?

Legogris

comment created time in 2 hours

created repositoryPierreRochard/ln-graph

created time in 9 hours

startedberty/berty

started time in 15 hours

created repositoryapoelstra/filterscreen

created time in 15 hours

issue openedshesek/spark-wallet

Migrate CI

image CI will break soon.

The quick and easy thing would be to switch to travis.com.

Might be worth considering alternatives, the writing is on the wall for Travis IMO. GH Actions maybe?

created time in a day

PR opened shesek/spark-wallet

fix: CI install recent jdk8 deb9u1 version

https://github.com/shesek/spark-wallet/pull/163

@shesek Have you looked at setting up Dependabot on this repo? It makes automated PRs when packages are updated upstream.

+1 -1

0 comment

1 changed file

pr created time in a day

pull request commentshesek/spark-wallet

unconditional npm install in build.sh

@shesek Thanks for following up! Left it in draft last night to come back with a fresh mind before submitting ;)

For context, I am attempting to fix this up for a containerized build for https://github.com/fiatjaf/sparko.

  • @babel/polyfill seems to be the only thing missing to make the client module self-contained - would you agree to containing it here? (maybe sparko should change its Makefile, but I don't see why not make things modular). In general it's a common pattern.
  • the issue had nothing to do with my initial commit. Since i ran this in a docker container as root, postinstall does not execute properly for npm install. I propose using npm --unsafe-perm, which fixes this.

To verify:

docker run --rm -it ubuntu:20.04 /bin/bash -c 'apt update && apt install -y git curl && (curl -sL https://deb.nodesource.com/setup_12.x -o- | bash) && git clone https://github.com/Legogris/spark-wallet.git && cd spark-wallet/client && git checkout fix-font-build && npm run dist'
Legogris

comment created time in a day

pull request commentshesek/spark-wallet

unconditional npm install in build.sh

@Legogris You should not have to install @babel/polyfill under client, it is already dependent on by the main package.

Make sure you run npm install in the main directory first, as described here.

Legogris

comment created time in a day

issue commentshesek/spark-wallet

spark wallet desktop app doesn't match c-lightning values in channel liquidity

What do you see if you enable developer mode (by clicking the version number in the bottom left) and toggle the channel's details?

Check this screenshot I just took https://i.ibb.co/kcCRTsT/image.png

PsySc0rpi0n

comment created time in 2 days

pull request commentshesek/spark-wallet

unconditional npm install in build.sh

Can you try using npm run dist within the client directory? This will setup PATH correctly without having to do it manually, and also ensure that the PWD is the client directory.

I just tried this and it worked:

$ git clone https://github.com/shesek/spark-wallet
$ cd spark-wallet/client
$ npm run dist

Is it possible that you had a previous interrupted installation that left behind an incomplete node_modules directory?

Legogris

comment created time in 2 days

PR opened shesek/spark-wallet

unconditional npm install in build.sh

in clean environment:

cd spark-wallet/client && PATH=$PATH:./node_modules/.bin/ ./build.sh
+ shopt -s extglob
+ : dist
+ : production
+ : web
+ export BUILD_TARGET
+ export NODE_ENV
++ node -p 'require("../package").version'
+ export VERSION=0.2.16
+ VERSION=0.2.16
+ rm -rf 'dist/*'
+ mkdir -p dist dist/lib dist/fonts dist/swatch
+ [[ -d node_modules ]]
+ cp -r www/favicon.ico www/manifest www/notification.png dist/
+ cp -r 'fonts/node_modules/typeface-*' dist/fonts/
cp: cannot stat 'fonts/node_modules/typeface-*': No such file or directory

+1 -1

0 comment

1 changed file

pr created time in 2 days

issue closedshesek/spark-wallet

dupe. please delete

Dupe... Please delete. Sorry

closed time in 2 days

PsySc0rpi0n

issue commentshesek/spark-wallet

spark wallet desktop app doesn't match c-lightning values in channel liquidity

What do you see if you enable developer mode (by clicking the version number in the bottom left) and toggle the channel's details?

PsySc0rpi0n

comment created time in 2 days

issue openedshesek/spark-wallet

spark wallet desktop app doesn't match c-lightning values in channel liquidity

OS version: Debian Burst 64bit Dektop app version: 0.2.17 c-lightning version: v0.9.2-67-gff88308

DESCRIPTION When I run in terminal, the command lightning-cli listpeers I get all the info about open channels, including: "spendable_msat": "614003000msat", "receivable_msat": "58896000msat"

but Spark-Wallet shows different values for these fields: https://i.ibb.co/nLp35jV/image.png

created time in 2 days

issue openedshesek/spark-wallet

desktop app not matching c-lightning values for liquidity

OS version: Debian Burst 64bit Dektop app version: 0.2.17 c-lightning version: v0.9.2-67-gff88308

DESCRIPTION When I run in terminal, the command lightning-cli listpeers I get all the info about open channels, including: "spendable_msat": "614003000msat", "receivable_msat": "58896000msat"

but Spark-Wallet shows different values for this fields: https://i.ibb.co/nLp35jV/image.png

Is this some bug or am I missing anything here?

created time in 2 days

startedsipa/safegcd-bounds

started time in 2 days

startedmikeal/IPSQL

started time in 4 days

startedgoogle/argh

started time in 6 days

fork greenaddress/esp-idf

Espressif IoT Development Framework. Official development framework for ESP32.

fork in 7 days

startedshekohex/flutterust

started time in 7 days

startedsanket1729/elements-miniscript

started time in 7 days

fork greenaddress/qemu_esp32

Add tensilica esp32 cpu and a board to qemu and dump the rom to learn more about esp-idf

fork in 7 days

more