in clean environment:

cd spark-wallet/client && PATH=$PATH:./node_modules/.bin/ ./build.sh
+ shopt -s extglob
+ : dist
+ : production
+ : web
+ export BUILD_TARGET
+ export NODE_ENV
++ node -p 'require("../package").version'
+ export VERSION=0.2.16
+ VERSION=0.2.16
+ rm -rf 'dist/*'
+ mkdir -p dist dist/lib dist/fonts dist/swatch
+ [[ -d node_modules ]]
+ cp -r www/favicon.ico www/manifest www/notification.png dist/
+ cp -r 'fonts/node_modules/typeface-*' dist/fonts/
cp: cannot stat 'fonts/node_modules/typeface-*': No such file or directory

this fixes that.

CI failing addressed in #170

For Spark's docker image, I'm using npm config set unsafe-perm true, which I find preferable to adding --unsafe-perm to npm install because it only affects the Docker environment and doesn't use unsafe perms when I'm running build.sh directly on my host.

Could you do this in your Dockerfile too?

Make sense! Closing this in favor of #169

Thanks!

I don't think Dependabot will work for apt packages installed in a Dockerfile, will it?

Wasn't sure actually - you're right but there's an open ticket for it: https://github.com/dependabot/dependabot-core/issues/2129

Thanks!

I don't think Dependabot will work for apt packages installed in a Dockerfile, will it?

https://github.com/shesek/spark-wallet/pull/163

@shesek Have you looked at setting up Dependabot on this repo? It makes automated PRs when packages are updated upstream.

@babel/polyfill seems to be the only thing missing to make the client module self-contained - would you agree to containing it here?

Yeah, sure, I can definitely add this to client/package.json if this makes things easier.

the issue had nothing to do with my initial commit. Since i ran this in a docker container as root, postinstall does not execute properly for npm install. I propose using npm --unsafe-perm, which fixes this.

For Spark's docker image, I'm using npm config set unsafe-perm true, which I find preferable to adding --unsafe-perm to npm install because it only affects the Docker environment and doesn't use unsafe perms when I'm running build.sh directly on my host.

Could you do this in your Dockerfile too?

CI will break soon.

The quick and easy thing would be to switch to travis.com.

Might be worth considering alternatives, the writing is on the wall for Travis IMO. GH Actions maybe?

https://github.com/shesek/spark-wallet/pull/163

@shesek Have you looked at setting up Dependabot on this repo? It makes automated PRs when packages are updated upstream.

@shesek Thanks for following up! Left it in draft last night to come back with a fresh mind before submitting ;)

For context, I am attempting to fix this up for a containerized build for https://github.com/fiatjaf/sparko.

• @babel/polyfill seems to be the only thing missing to make the client module self-contained - would you agree to containing it here? (maybe sparko should change its Makefile, but I don't see why not make things modular). In general it's a common pattern.
• the issue had nothing to do with my initial commit. Since i ran this in a docker container as root, postinstall does not execute properly for npm install. I propose using npm --unsafe-perm, which fixes this.

To verify:

docker run --rm -it ubuntu:20.04 /bin/bash -c 'apt update && apt install -y git curl && (curl -sL https://deb.nodesource.com/setup_12.x -o- | bash) && git clone https://github.com/Legogris/spark-wallet.git && cd spark-wallet/client && git checkout fix-font-build && npm run dist'

@Legogris You should not have to install @babel/polyfill under client, it is already dependent on by the main package.

Make sure you run npm install in the main directory first, as described here.

What do you see if you enable developer mode (by clicking the version number in the bottom left) and toggle the channel's details?

Check this screenshot I just took https://i.ibb.co/kcCRTsT/image.png

Can you try using npm run dist within the client directory? This will setup PATH correctly without having to do it manually, and also ensure that the PWD is the client directory.

I just tried this and it worked:

$ git clone https://github.com/shesek/spark-wallet
$ cd spark-wallet/client
$ npm run dist

Is it possible that you had a previous interrupted installation that left behind an incomplete node_modules directory?

in clean environment:

cd spark-wallet/client && PATH=$PATH:./node_modules/.bin/ ./build.sh
+ shopt -s extglob
+ : dist
+ : production
+ : web
+ export BUILD_TARGET
+ export NODE_ENV
++ node -p 'require("../package").version'
+ export VERSION=0.2.16
+ VERSION=0.2.16
+ rm -rf 'dist/*'
+ mkdir -p dist dist/lib dist/fonts dist/swatch
+ [[ -d node_modules ]]
+ cp -r www/favicon.ico www/manifest www/notification.png dist/
+ cp -r 'fonts/node_modules/typeface-*' dist/fonts/
cp: cannot stat 'fonts/node_modules/typeface-*': No such file or directory

Dupe... Please delete. Sorry

What do you see if you enable developer mode (by clicking the version number in the bottom left) and toggle the channel's details?

OS version: Debian Burst 64bit Dektop app version: 0.2.17 c-lightning version: v0.9.2-67-gff88308

DESCRIPTION When I run in terminal, the command lightning-cli listpeers I get all the info about open channels, including: "spendable_msat": "614003000msat", "receivable_msat": "58896000msat"

but Spark-Wallet shows different values for these fields: https://i.ibb.co/nLp35jV/image.png

OS version: Debian Burst 64bit Dektop app version: 0.2.17 c-lightning version: v0.9.2-67-gff88308

DESCRIPTION When I run in terminal, the command lightning-cli listpeers I get all the info about open channels, including: "spendable_msat": "614003000msat", "receivable_msat": "58896000msat"

but Spark-Wallet shows different values for this fields: https://i.ibb.co/nLp35jV/image.png

Is this some bug or am I missing anything here?