profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/grindtildeath/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Akim Juillerat grindtildeath @camptocamp Software developer / ERP Integrator @ camptocamp. https://twitter.com/akim_c2c

grindtildeath/docker-odoo-project 1

Base images for Odoo projects

camptocamp/event 0

Event Management addons

grindtildeath/account-analytic 0

Odoo Account Analytic Related Addons

grindtildeath/account-closing 0

Odoo Accountant closing tools

grindtildeath/account-consolidation 0

Odoo Account Consolidation Addons

grindtildeath/account-financial-reporting 0

Financial reports for Odoo

grindtildeath/account-financial-tools 0

Odoo Accountant Financial Tools and Utils

grindtildeath/account-invoice-reporting 0

Odoo Invoicing reports

grindtildeath/account-invoicing 0

Odoo Invoicing Extension Addons

grindtildeath/account-reconcile 0

Odoo Bank Statements Tasks (reconciliation, completion,...)

push eventgrindtildeath/odoo-cloud-platform

Akim Juillerat

commit sha e82fe205a012783a8b63b1ac2d39acd9515bb56e

base_fileurl_field: disable pylint W8106:method-required-super

view details

push time in a month

create barnchcamptocamp/web

branch : merge-branch-2543-12.0.2.2.0

created branch time in 2 months

create barnchcamptocamp/geospatial

branch : merge-branch-2543-12.0.2.2.0

created branch time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentOCA/stock-logistics-workflow

[MIG] stock_partner_delivery_window: Migration to 14.0

+# Copyright 2020 Camptocamp SA+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl)+from collections import defaultdict+from datetime import time++from odoo import _, api, fields, models+from odoo.exceptions import ValidationError+from odoo.tools.misc import format_time++from odoo.addons.partner_tz.tools import tz_utils++WORKDAYS = list(range(5))+++class ResPartner(models.Model):++    _inherit = "res.partner"++    delivery_time_preference = fields.Selection(+        [+            ("anytime", "Any time"),+            ("time_windows", "Fixed time windows"),+            ("workdays", "Weekdays (Monday to Friday)"),+        ],+        string="Delivery time schedule preference",+        default="workdays",

Yes, please cherry-pick https://github.com/OCA/stock-logistics-workflow/pull/862 :pray:

dzungtran89

comment created time in 2 months

create barnchcamptocamp/odoo

branch : 13.0-cherry-pick-branch-2845

created branch time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentOCA/stock-logistics-workflow

[13.0] stock_partner_delivery_window:: Fix default value on delivery_time_preference

Closes: https://github.com/OCA/sale-workflow/issues/1621

grindtildeath

comment created time in 3 months

issue commentOCA/sale-workflow

[13.0] sale_partner_delivery_window: Error on tests

Issue should be fixed with this PR: https://github.com/OCA/stock-logistics-workflow/pull/862

pedrobaeza

comment created time in 3 months

pull request commentOCA/sale-workflow

[13.0] FIXME: test build

@simahawk @pedrobaeza As I understand, the issue is actually this change: https://github.com/OCA/stock-logistics-workflow/commit/13e3613d50c0a68e62051768b914878b2e2ce4c7#diff-fbea30ea878379785066dc89fe393a00ee17bb0a5152638bd5bed547969c1d0dR26

A new default value is set on the fields, but it's not reflected in sale_partner_delivery_window.

We can merge this PR to avoid the issue: https://github.com/OCA/stock-logistics-workflow/pull/862

simahawk

comment created time in 3 months

PR opened OCA/stock-logistics-workflow

[13.0] stock_partner_delivery_window:: Fix default value on delivery_time_preference

The default value introduced by workdays feature breaks the installation of Demo databases as the change is not reflected in sale_partner_delivery_window.

cc @simahawk @pedrobaeza @mmequignon

+1 -1

0 comment

1 changed file

pr created time in 3 months

push eventgrindtildeath/stock-logistics-workflow

Akim Juillerat

commit sha 1c16b10d3eeb3dcaf91f75e4ddeaa5ea267e5b90

stock_partner_delivery_window: Fix default value on delivery_time_preference The default value introduced by workdays feature breaks the installation of Demo databases as the change is not reflected in sale_partner_delivery_window.

view details

push time in 3 months

pull request commentOCA/server-tools

[13.0] [MIG] base_import_module_group

Can you please cherry-pick your commit from https://github.com/OCA/server-tools/pull/2123 instead of having the test added in the migration commit? :pray:

yankinmax

comment created time in 3 months

Pull request review commentOCA/server-tools

[12.0][FIX] base_import_module_group: fix group external id and add test

+# Copyright 2021 Camptocamp SA+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).++from odoo.exceptions import AccessError+from odoo.modules.module import get_resource_path+from odoo.tests.common import SavepointCase+++class TestAccessRights(SavepointCase):+    @classmethod+    def setUpClass(cls):+        super().setUpClass()++        cls.test_user = cls.env["res.users"].create(+            {+                "name": "User",+                "login": "test_user",+                "email": "test_user@example.com",+                "groups_id": [cls.env.ref("base.group_user").id,],  # noqa: E231+            }+        )+        cls.test_admin = cls.env["res.users"].create(+            {+                "name": "Admin",+                "login": "test_admin",+                "email": "test_admin@example.com",+                "groups_id": [cls.env.ref("base.group_system").id,],  # noqa: E231
                "groups_id": [cls.env.ref("base_import_module_group.group_module_import").id,],  # noqa: E231
yankinmax

comment created time in 3 months

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentOCA/server-tools

[13.0] [MIG] base_import_module_group

-# Copyright 2020 Camptocamp SA+# Copyright 2021 Camptocamp SA

Same as above

yankinmax

comment created time in 3 months

PullRequestReviewEvent

Pull request review commentOCA/server-tools

[13.0] [MIG] base_import_module_group

-# Copyright 2020 Camptocamp SA+# Copyright 2021 Camptocamp SA

This shouldn't be changed as the module was created in 2020. You can still change to Copyright 2020-2021 Camptocamp SA if you wish

yankinmax

comment created time in 3 months

PullRequestReviewEvent