profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/gregmagolan/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Greg Magolan gregmagolan Kelowna, British Columbia DevX and Bazel

bazelbuild/rules_nodejs 555

JavaScript and NodeJS rules for Bazel

angular/angular-bazel-example 355

MOVED to the bazel nodejs monorepo 👉

bazelbuild/rules_closure 123

Closure rules for Bazel

gregmagolan/abc-demo-build-with-aot-universal 18

Angular Bazel Closure (ABC) Demo Build with AOT and Universal

alexeagle/monorepo 14

Prototype for a new repo in the angular org

alexeagle/ngcontainer 12

Docker image for running Angular build+test

gregmagolan/angular-bazel-example 4

Demo of building angular with bazel

PullRequestReviewEvent

pull request commentbazelbuild/rules_nodejs

refactor: remove ExternalNpmPackageInfo

I'm going to switch focus to the new rules_nodejs core and start on a greenfield approach for this so we can support more intelligent linking and pnpm style install in the future

gregmagolan

comment created time in 8 days

PR closed bazelbuild/rules_nodejs

Reviewers
refactor: remove ExternalNpmPackageInfo cla: no

4.x WIP

+6638 -4900

3 comments

281 changed files

gregmagolan

pr closed time in 8 days

pull request commentbazelbuild/rules_nodejs

refactor: remove ExternalNpmPackageInfo

Checkmate on this one. Trying to link per top-level node_modules folder runs into too many existing constraints in the legacy require patches, legacy module mappings aspects and in ts_library

gregmagolan

comment created time in 8 days

push eventgregmagolan/rules_nodejs

Greg Magolan

commit sha 37dce5af73aad73bfe0c425cea1fa8a18ba921ad

refactor: remove ExternalNpmPackageInfo modified: packages/concatjs/devserver/concatjs_devserver.bzl

view details

push time in 8 days

push eventgregmagolan/rules_nodejs

alexeagle

commit sha 98d1017aa69e7bfda82c13dae218db5e6c82e304

Update NodeJS Versions

view details

Chris Lloyd

commit sha a3754e32b3f692a40bb8658c2440f98453a5a8a7

Fix typo in stamping docs

view details

Matt Mackay

commit sha 9b454e38f7e2bbc64f75ee9a7dcb6ff45f1c7a12

build: add github action to update esbuild versions

view details

Alan Agius

commit sha bba54943c105a627f870da73b5e2dc3cb05a8253

fix: update `tsutils` to version `3.21.0` `tsetse` - `check-return-value` rule is returning false positives due because the short-circuit code in https://github.com/bazelbuild/rules_nodejs/blob/9b454e38f7e2bbc64f75ee9a7dcb6ff45f1c7a12/third_party/github.com/bazelbuild/rules_typescript/internal/tsetse/rules/check_return_value_rule.ts#L60-L62 is not working as expected for certain usecases. Example: ```ts get content() { try { return expect(harness.readFile(path)).withContext(`With file content for '${path}'`); } catch (e) { if (e.code !== 'ENOENT') { throw e; } // File does not exist so always fail the expectation return createFailureExpectation( expect(''), `Expected file content but file does not exist: '${path}'`, ); } }, ``` WIll cause tsetse to fail with the bellow; ``` ~~~~~~~~~~ packages/angular_devkit/build_angular/src/testing/jasmine-helpers.ts:112:16 - error TS21222: [tsetse] return value is unused. See http://tsetse.info/check-return-value 112 return expect(Buffer.byteLength(harness.readFile(path))).withContext( ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 113 `With file size for '${path}'`, ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 114 ); ```

view details

Matt Mackay

commit sha 08b43804e60cb4913fe6000d1735e9524e8b1009

Update NodeJS Versions (#2906) Co-authored-by: alexeagle <alexeagle@users.noreply.github.com>

view details

Matt Mackay

commit sha 0f171260091a97b9378d6f01432fb2ec92d0fea5

fix: remove dependency on shelljs in esbuild-update script

view details

Alex Eagle

commit sha 52ee4efb7fdf7734e56de01f1e35a33f42c8318b

fix: readme Fix branch used for buildkite status badge

view details

Jason Bedard

commit sha 1b040444254ca6f0ff9af5324961b7bb6bcb1a40

chore(esbuild): rename typescript test to ts_library

view details

Jason Bedard

commit sha b7a2aad7a585d2cf52ea8daecbe7d419694ae6f5

test(esbuild): add ts_project test

view details

Matt Mackay

commit sha acc64f95b31eb28948160e74807da82086bbcaaa

fix: use execSync to call npm

view details

Renovate Bot

commit sha 63f80f6e42b46c054fd5888662b31a1d391635a4

chore: update dependency com_github_mattn_go_isatty to v0.0.14

view details

Sahin Yort

commit sha bda04727cfca9c4d7dd1c8d1f62046b7dad0209f

feat: decouple @bazel/worker from rules_typescript (#2918)

view details

Matt Mackay

commit sha 56b439d40ce7a09b1bc03e63fb552524ad5f74a8

Update esbuild versions (#2923) Co-authored-by: alexeagle <alexeagle@users.noreply.github.com>

view details

Matt Mackay

commit sha 055d6ae9d7d2761e68944744e5375f5589ee1c1c

Update NodeJS Versions (#2924) Co-authored-by: alexeagle <alexeagle@users.noreply.github.com>

view details

Joey Perrott

commit sha 44740dfef1fbe74ff886f5bac84abe5d896a6f90

feat(builtin): add support for using a local .nvmrc file for providing a node version (#2911) Add `use_nvmrc` attribute on `node_repositories` to provide a Label pointing to the local .nvmrc file in the repository.

view details

matthewjh

commit sha c70a07bd3e9b0cd094f82fcb59bfe9c7d0799c0b

fix(typescript): write json srcs to generated tsconfig for resolveJsonModule+composite projects

view details

Alex Eagle

commit sha 148c85b4ddc6d480f0cf4da495f0d40267d23bf2

chore: upgrade rules_go version

view details

Alex Eagle

commit sha a4712db99e5df7700601b60cabe4aad3e1ad1736

refactor: move yarn versions to separate file, mirroring node

view details

alexeagle

commit sha f757c516e017213c979809664d88dc82fb11ad81

Update esbuild versions

view details

Alex Eagle

commit sha 3cfbcd6b5bda67f70d623b3daea8c425ad36d839

chore: accept new esbuild goldens

view details

push time in 8 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentbazelbuild/rules_nodejs

Core: add toolchains

+"Provide convenience repository for the host platform like @nodejs"++load("//nodejs/private:os_name.bzl", "os_name")++PLATFORMS = {+    "darwin_amd64": struct(+        compatible_with = [+            "@platforms//os:macos",+            "@platforms//cpu:x86_64",+        ],+    ),+    "darwin_arm64": struct(+        compatible_with = [+            "@platforms//os:macos",+            "@platforms//cpu:aarch64",+        ],+    ),+    "linux_amd64": struct(+        compatible_with = [+            "@platforms//os:linux",+            "@platforms//cpu:x86_64",+        ],+    ),+    "linux_arm64": struct(+        compatible_with = [+            "@platforms//os:linux",+            "@platforms//cpu:aarch64",+        ],+    ),+    "windows_amd64": struct(+        compatible_with = [+            "@platforms//os:windows",+            "@platforms//cpu:x86_64",+        ],+    ),+    "linux_s390x": struct(+        compatible_with = [+            "@platforms//os:linux",+            "@platforms//cpu:s390x",+        ],+    ),+    "linux_ppc64le": struct(+        compatible_with = [+            "@platforms//os:linux",+            "@platforms//cpu:ppc",+        ],+    ),+}++def _nodejs_host_os_alias_impl(repository_ctx):+    node_repository = "@%s_%s" % (repository_ctx.attr.node_repository, os_name(repository_ctx))++    build_content = """# Generated by node_repositories.bzl

nit: Generated by nodejs/private/nodejs_repo_host_os_alias.bzl

alexeagle

comment created time in 17 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentbazelbuild/rules_nodejs

Core: add toolchains

+"Provide convenience repository for the host platform like @nodejs"++load("//nodejs/private:os_name.bzl", "os_name")++PLATFORMS = {+    "darwin_amd64": struct(+        compatible_with = [+            "@platforms//os:macos",+            "@platforms//cpu:x86_64",+        ],+    ),+    "darwin_arm64": struct(+        compatible_with = [+            "@platforms//os:macos",+            "@platforms//cpu:aarch64",+        ],+    ),+    "linux_amd64": struct(+        compatible_with = [+            "@platforms//os:linux",+            "@platforms//cpu:x86_64",+        ],+    ),+    "linux_arm64": struct(+        compatible_with = [+            "@platforms//os:linux",+            "@platforms//cpu:aarch64",+        ],+    ),+    "windows_amd64": struct(+        compatible_with = [+            "@platforms//os:windows",+            "@platforms//cpu:x86_64",+        ],+    ),+    "linux_s390x": struct(+        compatible_with = [+            "@platforms//os:linux",+            "@platforms//cpu:s390x",+        ],+    ),+    "linux_ppc64le": struct(+        compatible_with = [+            "@platforms//os:linux",+            "@platforms//cpu:ppc",+        ],+    ),+}++def _nodejs_host_os_alias_impl(repository_ctx):+    node_repository = "@%s_%s" % (repository_ctx.attr.node_repository, os_name(repository_ctx))++    build_content = """# Generated by node_repositories.bzl+package(default_visibility = ["//visibility:public"])+# aliases for exports_files+alias(name = "run_npm.sh.template", actual = "{node_repository}//:run_npm.sh.template")+alias(name = "run_npm.bat.template", actual = "{node_repository}//:run_npm.bat.template")+alias(name = "bin/node_repo_args.sh", actual = "{node_repository}//:bin/node_repo_args.sh")+# aliases for other aliases+alias(name = "node_bin", actual = "{node_repository}//:node_bin")+alias(name = "npm_bin", actual = "{node_repository}//:npm_bin")+alias(name = "npx_bin", actual = "{node_repository}//:npx_bin")+alias(name = "yarn_bin", actual = "{node_repository}//:yarn_bin")+alias(name = "node", actual = "{node_repository}//:node")+alias(name = "npm", actual = "{node_repository}//:npm")+alias(name = "yarn", actual = "{node_repository}//:yarn")+alias(name = "npm_node_repositories", actual = "{node_repository}//:npm_node_repositories")+alias(name = "yarn_node_repositories", actual = "{node_repository}//:yarn_node_repositories")+alias(name = "node_files", actual = "{node_repository}//:node_files")+alias(name = "yarn_files", actual = "{node_repository}//:yarn_files")+alias(name = "npm_files", actual = "{node_repository}//:npm_files")+exports_files(["index.bzl"])+""".format(node_repository = node_repository)++    # https://docs.bazel.build/versions/main/skylark/deploying.html#registering-toolchains+    # "+    # Note that in order to resolve toolchains in the analysis phase+    # Bazel needs to analyze all toolchain targets that are registered.+    # Bazel will not need to analyze all targets referenced by toolchain.toolchain attribute.+    # If in order to register toolchains you need to perform complex computation in the repository,+    # consider splitting the repository with toolchain targets+    # from the repository with <LANG>_toolchain targets.+    # Former will be always fetched,+    # and the latter will only be fetched when user actually needs to build <LANG> code.+    # "+    # The "complex computation" in our case is simply downloading the node binaries from nodejs.org.+    # This guidance tells us how to avoid that: we put the toolchain targets in the alias repository+    # with only the toolchain attribute pointing into the platform-specific repositories.+    if repository_ctx.attr.include_toolchain_declarations:+        for [platform, meta] in PLATFORMS.items():+            build_content += """+# This can be registered in the workspace file or passed to --extra_toolchains flag+toolchain(+    name = "{platform}_toolchain",+    exec_compatible_with = {compatible_with},+    target_compatible_with = {compatible_with},+    toolchain = "{node_repository}//:node_toolchain",+    toolchain_type = "@rules_nodejs//nodejs:toolchain_type",+)+""".format(+                platform = platform,+                node_repository = node_repository,+                compatible_with = meta.compatible_with,+            )++    # Base BUILD file for this repository+    repository_ctx.file("BUILD.bazel", build_content)++    # index.bzl file for this repository+    repository_ctx.file("index.bzl", content = """# Generated by node_repositories.bzl+host_platform="{host_platform}"+""".format(host_platform = os_name(repository_ctx)))++nodejs_repo_host_os_alias = repository_rule(+    _nodejs_host_os_alias_impl,+    doc = """Creates a repository with a shorter name meant for the host platform, which contains++    - A BUILD.bazel file declaring aliases to the host platform's node binaries+      and toolchain definitions for all other platforms which can be registered or selected+    - index.bzl containing some constants+    """,+    attrs = {+        "include_toolchain_declarations": attr.bool(+            doc = """The new rules_nodejs workspace declares its toolchains in the alias repo+                but the legacy build_bazel_rules_nodejs workspace does not.""",+        ),+        "node_repository": attr.string(default = "nodejs"),

node_repository_prefix?

alexeagle

comment created time in 17 days

PullRequestReviewEvent

Pull request review commentbazelbuild/rules_nodejs

Core: add toolchains

+"Provide convenience repository for the host platform like @nodejs"++load("//nodejs/private:os_name.bzl", "os_name")++PLATFORMS = {+    "darwin_amd64": struct(+        compatible_with = [+            "@platforms//os:macos",+            "@platforms//cpu:x86_64",+        ],+    ),+    "darwin_arm64": struct(+        compatible_with = [+            "@platforms//os:macos",+            "@platforms//cpu:aarch64",+        ],+    ),+    "linux_amd64": struct(+        compatible_with = [+            "@platforms//os:linux",+            "@platforms//cpu:x86_64",+        ],+    ),+    "linux_arm64": struct(+        compatible_with = [+            "@platforms//os:linux",+            "@platforms//cpu:aarch64",+        ],+    ),+    "windows_amd64": struct(+        compatible_with = [+            "@platforms//os:windows",+            "@platforms//cpu:x86_64",+        ],+    ),+    "linux_s390x": struct(+        compatible_with = [+            "@platforms//os:linux",+            "@platforms//cpu:s390x",+        ],+    ),+    "linux_ppc64le": struct(+        compatible_with = [+            "@platforms//os:linux",+            "@platforms//cpu:ppc",+        ],+    ),+}++def _nodejs_host_os_alias_impl(repository_ctx):+    node_repository = "@%s_%s" % (repository_ctx.attr.node_repository, os_name(repository_ctx))++    build_content = """# Generated by node_repositories.bzl+package(default_visibility = ["//visibility:public"])+# aliases for exports_files+alias(name = "run_npm.sh.template", actual = "{node_repository}//:run_npm.sh.template")+alias(name = "run_npm.bat.template", actual = "{node_repository}//:run_npm.bat.template")+alias(name = "bin/node_repo_args.sh", actual = "{node_repository}//:bin/node_repo_args.sh")+# aliases for other aliases+alias(name = "node_bin", actual = "{node_repository}//:node_bin")+alias(name = "npm_bin", actual = "{node_repository}//:npm_bin")+alias(name = "npx_bin", actual = "{node_repository}//:npx_bin")+alias(name = "yarn_bin", actual = "{node_repository}//:yarn_bin")+alias(name = "node", actual = "{node_repository}//:node")+alias(name = "npm", actual = "{node_repository}//:npm")+alias(name = "yarn", actual = "{node_repository}//:yarn")+alias(name = "npm_node_repositories", actual = "{node_repository}//:npm_node_repositories")+alias(name = "yarn_node_repositories", actual = "{node_repository}//:yarn_node_repositories")+alias(name = "node_files", actual = "{node_repository}//:node_files")+alias(name = "yarn_files", actual = "{node_repository}//:yarn_files")+alias(name = "npm_files", actual = "{node_repository}//:npm_files")+exports_files(["index.bzl"])+""".format(node_repository = node_repository)++    # https://docs.bazel.build/versions/main/skylark/deploying.html#registering-toolchains+    # "+    # Note that in order to resolve toolchains in the analysis phase+    # Bazel needs to analyze all toolchain targets that are registered.+    # Bazel will not need to analyze all targets referenced by toolchain.toolchain attribute.+    # If in order to register toolchains you need to perform complex computation in the repository,+    # consider splitting the repository with toolchain targets+    # from the repository with <LANG>_toolchain targets.+    # Former will be always fetched,+    # and the latter will only be fetched when user actually needs to build <LANG> code.+    # "+    # The "complex computation" in our case is simply downloading the node binaries from nodejs.org.+    # This guidance tells us how to avoid that: we put the toolchain targets in the alias repository+    # with only the toolchain attribute pointing into the platform-specific repositories.+    if repository_ctx.attr.include_toolchain_declarations:+        for [platform, meta] in PLATFORMS.items():+            build_content += """+# This can be registered in the workspace file or passed to --extra_toolchains flag+toolchain(+    name = "{platform}_toolchain",+    exec_compatible_with = {compatible_with},+    target_compatible_with = {compatible_with},+    toolchain = "{node_repository}//:node_toolchain",+    toolchain_type = "@rules_nodejs//nodejs:toolchain_type",+)+""".format(+                platform = platform,+                node_repository = node_repository,+                compatible_with = meta.compatible_with,+            )++    # Base BUILD file for this repository+    repository_ctx.file("BUILD.bazel", build_content)++    # index.bzl file for this repository+    repository_ctx.file("index.bzl", content = """# Generated by node_repositories.bzl

nit: Generated by nodejs/private/nodejs_repo_host_os_alias.bzl

alexeagle

comment created time in 17 days

push eventgregmagolan/rules_nodejs

Jason Bedard

commit sha 1b040444254ca6f0ff9af5324961b7bb6bcb1a40

chore(esbuild): rename typescript test to ts_library

view details

Jason Bedard

commit sha b7a2aad7a585d2cf52ea8daecbe7d419694ae6f5

test(esbuild): add ts_project test

view details

Matt Mackay

commit sha acc64f95b31eb28948160e74807da82086bbcaaa

fix: use execSync to call npm

view details

Renovate Bot

commit sha 63f80f6e42b46c054fd5888662b31a1d391635a4

chore: update dependency com_github_mattn_go_isatty to v0.0.14

view details

Sahin Yort

commit sha bda04727cfca9c4d7dd1c8d1f62046b7dad0209f

feat: decouple @bazel/worker from rules_typescript (#2918)

view details

Matt Mackay

commit sha 56b439d40ce7a09b1bc03e63fb552524ad5f74a8

Update esbuild versions (#2923) Co-authored-by: alexeagle <alexeagle@users.noreply.github.com>

view details

Matt Mackay

commit sha 055d6ae9d7d2761e68944744e5375f5589ee1c1c

Update NodeJS Versions (#2924) Co-authored-by: alexeagle <alexeagle@users.noreply.github.com>

view details

Joey Perrott

commit sha 44740dfef1fbe74ff886f5bac84abe5d896a6f90

feat(builtin): add support for using a local .nvmrc file for providing a node version (#2911) Add `use_nvmrc` attribute on `node_repositories` to provide a Label pointing to the local .nvmrc file in the repository.

view details

matthewjh

commit sha c70a07bd3e9b0cd094f82fcb59bfe9c7d0799c0b

fix(typescript): write json srcs to generated tsconfig for resolveJsonModule+composite projects

view details

Alex Eagle

commit sha 148c85b4ddc6d480f0cf4da495f0d40267d23bf2

chore: upgrade rules_go version

view details

Alex Eagle

commit sha a4712db99e5df7700601b60cabe4aad3e1ad1736

refactor: move yarn versions to separate file, mirroring node

view details

alexeagle

commit sha f757c516e017213c979809664d88dc82fb11ad81

Update esbuild versions

view details

Alex Eagle

commit sha 3cfbcd6b5bda67f70d623b3daea8c425ad36d839

chore: accept new esbuild goldens

view details

Alex Eagle

commit sha 7f85e9f21388f5449daa543b67638c76c56d69d1

refactor: os_name.bzl no longer depends on check_version.bzl Moves closer to throwing away that helper, as skylib has a built-in to assert on the bazel version

view details

Alex Eagle

commit sha 32a14625fe8f576d90fae881b5199a4b27fec367

chore(release): 4.1.0

view details

Alex Eagle

commit sha d0f184fc2699fb03fb4eba18613975478463f462

chore: update lock files for release

view details

Alex Eagle

commit sha a32cf5c0822b4b6bed0806d612a71178d060e8af

feat: introduce "core" package at /nodejs Motivation is described by https://github.com/bazelbuild/rules_nodejs/issues/2892 Some advantages of this approach: - We now follow the style guide at https://docs.bazel.build/versions/main/skylark/deploying.html - Gives us a 'clean room' to eventually reduce the scope of the project. - Allows others to develop their own competing nodejs rules without having to start from scratch. - Allows the user to declare two different node versions since they control the name of the external repository we create

view details

push time in 17 days

PullRequestReviewEvent

push eventgregmagolan/rules_nodejs

Greg Magolan

commit sha 6c64775cacfac352c01f4110af5ab15ae30155c8

refactor: remove ExternalNpmPackageInfo modified: packages/concatjs/devserver/concatjs_devserver.bzl

view details

push time in 21 days

push eventgregmagolan/rules_nodejs

Greg Magolan

commit sha 39ea5212d021797a1531d3f10cfed5b22aad1720

refactor: remove ExternalNpmPackageInfo modified: packages/concatjs/devserver/concatjs_devserver.bzl

view details

push time in 22 days

push eventgregmagolan/rules_nodejs

Greg Magolan

commit sha 97f3bd9fb0875e975fcc9763e778d874a0692546

refactor: remove ExternalNpmPackageInfo modified: packages/concatjs/devserver/concatjs_devserver.bzl

view details

push time in 22 days

push eventgregmagolan/rules_nodejs

Greg Magolan

commit sha 2d920fceb6e1e7c8079b571f3487aa95727e5e49

refactor: remove ExternalNpmPackageInfo modified: packages/concatjs/devserver/concatjs_devserver.bzl

view details

push time in 22 days

push eventgregmagolan/rules_nodejs

Greg Magolan

commit sha f5924da84ee3c3f73d6d171955f84e573854cb89

refactor: remove ExternalNpmPackageInfo modified: packages/concatjs/devserver/concatjs_devserver.bzl

view details

push time in 22 days

push eventgregmagolan/rules_nodejs

Greg Magolan

commit sha 21cee7edc88d9e2098273eb97cf7fbc39d3bd7df

refactor: remove ExternalNpmPackageInfo modified: packages/concatjs/devserver/concatjs_devserver.bzl

view details

push time in 22 days

push eventgregmagolan/rules_nodejs

WhiteSource Renovate

commit sha f7501d98baeccdb0225e92a6732a2b3b7868b558

chore: update dependency com_google_protobuf to v3.17.0 (#2672)

view details

Alex Eagle

commit sha 58226ba29d159c6991417a5d262102ec4b93cabe

chore: remove file accidentally added by last release

view details

Alex Eagle

commit sha b5967380b454bc07a692aa9fbef1beb6c1b8f093

chore: drop support for Bazel 2.x (#2682) It makes our CI slower to run all examples against all Bazel versions. Other rulesets don't seem to test backcompat at all, so it's hard to imagine anyone is actually running on Bazel 2 and using recent rules releases

view details

Long Ho

commit sha 1ce9dcee917a83143c492feaa63b7e156c1f573c

fix: make generated_file_test `.update`'s visibility same as test rule (#2677)

view details

Alex Eagle

commit sha 99760a5c396226f12972d549c3b39ad8b4fe222b

fix(builtin): write stdout/stderr to correct path under chdir (#2681) fixes #2680

view details

Jason Bedard

commit sha a655fcc059fef9ea1b64cae77628c5caa9aa512f

chore(typescript): upgrade testing typescript to 4.1 (#2679)

view details

Jason Bedard

commit sha 23e79e866a09164d4bc393b0b02bb65822356912

chore(esbuild): remove use of deprecated NpmPackageInfo (#2683)

view details

Paul Gschwendtner

commit sha 4487698cf5c69e994df3d799691bfed47c9bfe18

fix(builtin): generated nodejs repository for windows references non-existent file The generated NodeJS repository for windows. e.g. `@nodejs_windows_amd64` references a non-existent file that is supposed to be the Yarn script. The `yarn.cmd` file is located under `bin/` in the extracted Yarn archive, and not at the top-level. This currently breaks integration tests in the Angular framework due to the following error when the following target is referenced: `@nodejs//:yarn_bin`. ``` missing input file 'external/nodejs_windows_amd64/bin/yarnpkg/yarn.cmd', owner: '@nodejs_windows_amd64//:bin/yarnpkg/yarn.cmd' ```

view details

Paul Gschwendtner

commit sha b06ad1348700df816b4bd5e19b78db8057150bf0

Add integration test to ensure @nodejs repository is valid

view details

Alex Eagle

commit sha 574b59c2ee411d857850c959c9eb063031146a4d

point to new docsite

view details

Alex Eagle

commit sha c123b961d494edbdbd015e76c15103ab97f3d170

Update index.md Fixes #2686

view details

Matt Mackay

commit sha 7af40ec08e176723d8567fb6b686590f359e4f49

Update NodeJS Versions (#2687)

view details

Jason Bedard

commit sha 82ef1a163cb13bd3514f4255f4d7e614d4752f06

fix(esbuild): provide JSModuleInfo of output bundle (#2685)

view details

WhiteSource Renovate

commit sha 2feebeb2dc49dfe1cd8b26d7fdfec667125c3230

chore: update io_bazel_rules_docker commit hash to 0652537 (#2689)

view details

WhiteSource Renovate

commit sha 98ace2ed6738889b96c80c8f27920c2e8bf534a5

chore: update dependency com_google_protobuf to v3.17.1 (#2693)

view details

Matt Mackay

commit sha f320ef0dac084b63f92e5ba7444ef6ee12b64309

fix(esbuild): update update script file paths after removal of _README.md (#2695)

view details

WhiteSource Renovate

commit sha 57c919d0f3a1cc5e5f320ebe6f28f54d88bee8ec

chore: update dependency bazel_toolchains to v4.1.0 (#2690)

view details

WhiteSource Renovate

commit sha c483e18fef36d386094abf1ebe6474649a8d962b

chore: update io_bazel_rules_docker commit hash to e170149 (#2694)

view details

Moritz Kiefer

commit sha 51d9ab575f68df7d51734de9d2b4294739a63d18

Fix copy_file on Windows (#2697) In general you cannot rely on mkdir and cp being in path here and this below up for us on CI. Given that this is a repository rule you also cannot rely on something like rules_posix to resolve them otherwise so this PR hacks around this in a rather crude but working way.

view details

Alex Eagle

commit sha fcdcf637be3eb603a13b15555e225341ffa8b43d

feat(builtin): document how nodejs_binary#entry_point can use a direc… (#2579) * feat(builtin): document how nodejs_binary#entry_point can use a directory * refactor: rename to directory_entry_point per discussion * refactor: make the feature more general, suitable to upstream to bazel-skylib

view details

push time in 22 days

push eventgregmagolan/rules_nodejs

Greg Magolan

commit sha dfab3237e4c04c4408e90c65a440fa4b8a9124e2

refactor: remove ExternalNpmPackageInfo modified: packages/concatjs/devserver/concatjs_devserver.bzl

view details

push time in 22 days

push eventgregmagolan/rules_nodejs

Greg Magolan

commit sha 65af02a0a876e8bd16ff6f9ca6394ba55fa67c65

refactor: remove ExternalNpmPackageInfo modified: packages/concatjs/devserver/concatjs_devserver.bzl

view details

push time in 22 days

push eventgregmagolan/rules_nodejs

Greg Magolan

commit sha f82060cd25ab8da3e205a9406e438f31cb10e66c

refactor: remove ExternalNpmPackageInfo modified: packages/concatjs/devserver/concatjs_devserver.bzl

view details

push time in 22 days

push eventgregmagolan/rules_nodejs

Greg Magolan

commit sha 0bbcf9c612eb58680c566976b5a0f92389af85e1

refactor: remove ExternalNpmPackageInfo

view details

push time in 22 days

push eventgregmagolan/rules_nodejs

Matt Mackay

commit sha 3b37b3ab90d997601ba99d5822c36f3aadb058d1

chore(esbuild): update versions used

view details

Matt Mackay

commit sha c48189993acb1177170a26f8d7664b514ff9f291

Update NodeJS Versions (#2855)

view details

Alex Eagle

commit sha 5852aa796cde56d48e15d9f1aabbe0461563fa2e

chore: remove version checking from @bazel/worker This package is meant to be a utility required by code outside our repo, on its own release cadence. For example, rules_sass has a sass worker program that depends on @bazel/worker. This means that new major releases of rules_nodejs will likely be used with an older version of @bazel/worker. We intend for the worker package to be quite stable across releases, so the check for matching major versions just makes upgrades very difficult, with no benefit. Fixes #2807

view details

Alex Eagle

commit sha 20f90c515ef0b63ef2512f9d1877e002fe61654a

fix(typescript): document tsc_test for typecheck-only

view details

Alex Eagle

commit sha 4929f8a3db2934f02e042faaebeb64e353f4a83e

chore: suppress //internal/npm_install/test:test_yarn_directory_artifacts on Windows It started failing and we don't know why

view details

Matt Mackay

commit sha 99d3177136c7fc02b7c1edde2fb7b60e53fc9333

docs(typescript): update typescript docs

view details

Matt Mackay

commit sha c95d9caec79b4b8dae173c8d569499b59b4983bb

feat(esbuild): add support for plugins via supplying a configuration file (#2840)

view details

Tiago Costa

commit sha 32551a56ff48bee8ddd10ff39d2d7aa01f47ebd0

fix(builtin): correctly calculate pkg._directDependency when a mapped node_module is used

view details

Duarte Nunes

commit sha 9771b7452021bdb906ccc11dbfd76128a04f042b

fix: remove current directory prefix when running from execroot Fixes a regression where $PWD was included in the MAIN variable when FROM_EXECROOT is defined.

view details

Yuchao

commit sha b453b61ee97876b457767564dd9fbebc62c925b7

chore: remove jest-haste-map patch

view details

Alex Eagle

commit sha 25a08c509e4cb58615a3d1fdb040467d52a6c15c

chore: upgrade babel

view details

Matt Mackay

commit sha 5551bffca5d9c03af559da7617dcb8caf3af65e2

feat(esbuild): add support for plugins via supplying a configuration file

view details

Matt Mackay

commit sha 413f73db9381ddf547b139829b8504ad97480d22

feat(esbuild): support stamping via config file

view details

Alex Eagle

commit sha 211c40482af3b8779da2ca0a4dbd84c98905a80a

chore: fix type assertions when using newer node typings

view details

Alex Eagle

commit sha 804e55fa28bc83596f59a4fc2c5e9c3494f82aaa

chore: update defaults to latest node/yarn versions fixes #2755

view details

Alex Eagle

commit sha 74c0dacd9e7176971596ed9a4dc7c25f37714ea7

chore(release): 4.0.0-rc.0

view details

Alex Eagle

commit sha d043647bb9329b41b8e87cad1a11caf4c00f3c46

chore: update lock files for release

view details

Matt Mackay

commit sha 53f1d5efef8bfc8285c64c307535235cad2ac35b

chore(esbuild): remove todo comment that no longer applies

view details

Alex Eagle

commit sha 9392527dd052a51d9714429de5392fc1555b80a5

chore: update lock files for release

view details

Alex Eagle

commit sha eb1ffa50cabcc7e98013cac289f7d09ba9e66813

chore: turn on streaming test output for examples Should help us debug why it's timing out only on CI 4.x branch

view details

push time in 22 days

PR opened bazelbuild/rules_nodejs

fix: ci

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

  • [ ] Bugfix
  • [ ] Feature (please, look at the "Scope of the project" section in the README.md file)
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] Other... Please describe:

What is the current behavior?

<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • [ ] Yes
  • [ ] No

<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->

Other information

+74 -0

0 comment

1 changed file

pr created time in a month

create barnchgregmagolan/rules_nodejs

branch : 4.x_ci_fix

created branch time in a month