profile
viewpoint

gouravnema/heap 1

Heap is a simple key value pair store written in PHP. This uses filesystem for storing key values. all keys are files and content of file is value which keys holds.

gouravnema/avatarify 0

Avatars for Zoom, Skype and other video-conferencing apps.

gouravnema/bwip-js 0

Barcode Writer in Pure JavaScript

gouravnema/draw.io 0

Source to www.draw.io

gouravnema/EnvayaSMS 0

Simple SMS and MMS gateway running on Android

gouravnema/generators 0

[ Javascript - ES6 ] Concepts in generators

gouravnema/glup_transpile 0

setting up gulp to transpile es6

gouravnema/hamster 0

GNOME time tracker

Pull request review commentrazorpay/go-financial

increase test coverage

 func PlotRows(rows []Row, fileName string) error { 		panic(err) 	} 	filePath := path.Join(completePath, fileName)-	f, _ := os.Create(fmt.Sprintf("%s.html", filePath))-	if err := bar.Render(f); err != nil {+	f, err := os.Create(fmt.Sprintf("%s.html", filePath))+	if err != nil {+		return err+	}+	defer func() {+		err = f.Close()+	}()+	if writer == nil {+		writer = f+	}

if you find better approach, open to that as well.

gyanesh-m

comment created time in 2 days

Pull request review commentrazorpay/go-financial

increase test coverage

 func PlotRows(rows []Row, fileName string) error { 		panic(err) 	} 	filePath := path.Join(completePath, fileName)-	f, _ := os.Create(fmt.Sprintf("%s.html", filePath))-	if err := bar.Render(f); err != nil {+	f, err := os.Create(fmt.Sprintf("%s.html", filePath))+	if err != nil {+		return err+	}+	defer func() {+		err = f.Close()+	}()+	if writer == nil {+		writer = f+	}

there's issue in this approach. first time file will be opened and set to writer. next time, same writer is being used which may not work. (file doesn't exist etc). instead move this in unexported method. accept io.Writer as func param. in unit test, pass fake io.writer to this unexported method. from PlotRows pass real file io.Writer.

gyanesh-m

comment created time in 2 days

push eventrazorpay/go-financial

Gyanesh Malhotra

commit sha a049255ff1aedeabeae21db66f5c8abf80cbe73c

update go mod and sum.

view details

push time in 3 days

PR opened razorpay/go-financial

increase test coverage
+143 -3

0 comment

4 changed files

pr created time in 3 days

create barnchrazorpay/go-financial

branch : update-tests

created branch time in 3 days

push eventrazorpay/payment-button-wordpress-plugin

ChetanGN

commit sha d1b6b9bc104f90703a4a08c2106a0d0299800ce0

Fix the file path and version bump to 1.1

view details

push time in 14 days

Pull request review commentrazorpay/payment-button-wordpress-plugin

Added extra param to pass the plugin details to payment button js file

 public function load_razorpay_block()                 ) 
             );
 
+            $mod_version = get_plugin_data(plugin_dir_path(__DIR__) . 'razorpay-payment-buttons.php')['Version'];

Directory path is not coming correctly so plugin version is not fetched It's working fine after changing the below code. $mod_version = get_plugin_data(FILE)['Version'];

ChetanGN

comment created time in 15 days

create barnchrazorpay/payment-button-wordpress-plugin

branch : param-add-js

created branch time in 15 days

issue commentrazorpay/go-financial

port rest of the numpy-financial functions

Hey @lakshaytalkstocomputer, we have added contribution guidelines.

krantideep95

comment created time in 20 days

push eventrazorpay/go-financial

Gyanesh Malhotra

commit sha 12af7e815771c2e801251ef0d27813a528dd8046

Update docs (#5) * add changelog, contributing file & update readme. * add makefile. * address pr comment.

view details

push time in 20 days

delete branch razorpay/go-financial

delete branch : update-docs

delete time in 20 days

PR merged razorpay/go-financial

Reviewers
Update docs
+64 -1

0 comment

4 changed files

gyanesh-m

pr closed time in 20 days

push eventrazorpay/go-financial

Gyanesh Malhotra

commit sha b6f5ca7ad93f6fa2f353439b460b396a62ea5291

address pr comment.

view details

push time in 20 days

Pull request review commentrazorpay/go-financial

Update docs

+# How to contribute++Thank you for your interest in contribution to go-financial.+Here's the recommended process of contribution.++++If you've changed APIs, update the documentation.+Make sure your code lints.+Issue that pull request!+1. Fork the repo and create your branch from master.+1. hack, hack, hack.+1. If you've added code that should be tested, add tests.

"If the functions are exported, make sure they are documented with examples"

gyanesh-m

comment created time in 20 days

PR opened razorpay/go-financial

Reviewers
Update docs
+63 -1

0 comment

4 changed files

pr created time in 20 days

push eventrazorpay/go-financial

Gyanesh Malhotra

commit sha 141a57cffe2fc1f022aa14bbf265a52d84413abe

add makefile.

view details

push time in 20 days

create barnchrazorpay/go-financial

branch : update-docs

created branch time in 20 days

issue commentrazorpay/go-financial

port rest of the numpy-financial functions

@krantideep95 Hey I have added nper function and before proceeding further I wanted to have it reviewed to know that I am on right path. Since there is no contribution guideline, should I just create pull request? P.S This is my first open source contribution, please let me know if there are issues.

krantideep95

comment created time in 22 days

issue commentrazorpay/go-financial

port rest of the numpy-financial functions

Hey! Any contribution guidelines?

krantideep95

comment created time in 22 days

push eventrazorpay/go-financial

Gyanesh Malhotra

commit sha 6d04495e6bc7a1d98a519974ec59dd33e5cb1080

Update Readme (#4) * update readme.md. * Fix formatting for PPmt. * revert GenerateTable formatting.

view details

push time in 22 days

delete branch razorpay/go-financial

delete branch : update-pkg

delete time in 22 days

PR merged razorpay/go-financial

Reviewers
Update Readme
+356 -37

0 comment

1 changed file

gyanesh-m

pr closed time in 22 days

PR opened razorpay/go-financial

Update Readme
+356 -37

0 comment

1 changed file

pr created time in 23 days

push eventrazorpay/go-financial

Gyanesh Malhotra

commit sha a6e4765599f5f1cc47b9a9fc4965efefa244a00b

revert GenerateTable formatting.

view details

push time in 23 days

push eventrazorpay/go-financial

Gyanesh Malhotra

commit sha f1496eef887597465ab4dbb7d9b75516fa7f6cbb

Fix formatting for PPmt.

view details

push time in 23 days

create barnchrazorpay/go-financial

branch : update-pkg

created branch time in 23 days

issue openedrazorpay/go-financial

port rest of the numpy-financial functions

documentation for the remaining functions available at https://numpy.org/doc/stable/reference/routines.financial.html

created time in 24 days

created tagrazorpay/go-financial

tagv0.1.0

A go port of numpy-financial functions and more.

created time in 24 days

release razorpay/go-financial

v0.1.0

released time in 24 days

more