profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/gottesmm/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Michael Gottesman gottesmm Apple, Inc. San Francisco, CA

llvm/llvm-project 8535

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies. Note: the repository does not accept github pull requests at this moment. Please submit your patches at http://reviews.llvm.org.

gottesmm/swift 2

The Swift Programming Language

gottesmm/llvm 0

Mirror of official llvm git repository located at http://llvm.org/git/llvm. Updated every five minutes.

gottesmm/magit-gh-pulls 0

Magit plugin for dealing with GitHub pull requests

gottesmm/swift-corelibs-foundation 0

The Foundation Project, providing core utilities, internationalization, and OS independence

Pull request review commentapple/swift

[DNM] Placeholder types: take two

 Expr *ExprRewriter::coerceToType(Expr *expr, Type toType,                                  Optional<Pattern*> typeFromPattern) {   auto &ctx = cs.getASTContext(); +  // Diagnose conversions to invalid function types that couldn't be performed+  // beforehand because of placeholders.+  if (auto *fnTy = toType->getAs<FunctionType>()) {+    auto contextTy = cs.getContextualType(expr);+    if (cs.getConstraintLocator(locator)->isForContextualType() &&+        contextTy && contextTy->hasPlaceholder()) {+      TypeChecker::diagnoseInvalidFunctionType(fnTy, expr->getLoc(), None, dc,+                                               None);

🤞

Jumhyn

comment created time in an hour

pull request commentapple/swift

Add support to skip watchOS 32-bit simulator by default

@swift-ci test macOS

shahmishal

comment created time in an hour

pull request commentapple/swift

Add support to skip watchOS 32-bit simulator by default

@swift-ci smoke test Linux

shahmishal

comment created time in an hour

push eventapple/swift

Mishal Shah

commit sha 3e81252f00961968b9589e0c83e572cb1b4cb303

Disable test to verify watchOS host tests are skipped (76823842)

view details

push time in an hour

Pull request review commentapple/swift

[DNM] Placeholder types: take two

 Expr *ExprRewriter::coerceToType(Expr *expr, Type toType,                                  Optional<Pattern*> typeFromPattern) {   auto &ctx = cs.getASTContext(); +  // Diagnose conversions to invalid function types that couldn't be performed+  // beforehand because of placeholders.+  if (auto *fnTy = toType->getAs<FunctionType>()) {+    auto contextTy = cs.getContextualType(expr);+    if (cs.getConstraintLocator(locator)->isForContextualType() &&+        contextTy && contextTy->hasPlaceholder()) {+      TypeChecker::diagnoseInvalidFunctionType(fnTy, expr->getLoc(), None, dc,+                                               None);

Ok! I’ll give that a shot and see if there’s any unexpected fallout.

Jumhyn

comment created time in 2 hours

pull request commentapple/swift

Add support to skip watchOS 32-bit simulator by default

Build failed Swift Test OS X Platform Git Sha - df28939255e45326189ee956ce9c088665c91f24

shahmishal

comment created time in 3 hours

pull request commentapple/swift

C++ Interop: fix crash for Swift extensions of C++ classes declared in namespaces

@swift-ci please smoke test macOS

egorzhdan

comment created time in 3 hours

Pull request review commentapple/swift

[DNM] Placeholder types: take two

 Expr *ExprRewriter::coerceToType(Expr *expr, Type toType,                                  Optional<Pattern*> typeFromPattern) {   auto &ctx = cs.getASTContext(); +  // Diagnose conversions to invalid function types that couldn't be performed+  // beforehand because of placeholders.+  if (auto *fnTy = toType->getAs<FunctionType>()) {+    auto contextTy = cs.getContextualType(expr);+    if (cs.getConstraintLocator(locator)->isForContextualType() &&+        contextTy && contextTy->hasPlaceholder()) {+      TypeChecker::diagnoseInvalidFunctionType(fnTy, expr->getLoc(), None, dc,+                                               None);

Frankly I'm not sure exactly why it wasn't made to fail, I'd suggest you try to return ErrorType wrapping fnTy for cases when diagnoseInvalidFunctionType would produce an error in resolveASTFunctionType (so that code completion would still have access to underlying type) and return nullptr in coerceToType.

Jumhyn

comment created time in 4 hours

pull request commentapple/swift

Add support to skip watchOS 32-bit simulator by default

00:03:20.860 + ./utils/python_lint.py
00:03:25.777 ./test/attr/Inputs/access-note-gen.py:28:10: E127 continuation line over-indented for visual indent
00:03:25.777 ./test/attr/Inputs/access-note-gen.py:29:10: E127 continuation line over-indented for visual indent

Not related to this PR

shahmishal

comment created time in 4 hours

pull request commentapple/swift

Add support to skip watchOS 32-bit simulator by default

@swift-ci Python lint

shahmishal

comment created time in 5 hours

pull request commentapple/swift

Add support to skip watchOS 32-bit simulator by default

@swift-ci test macOS

shahmishal

comment created time in 5 hours

pull request commentapple/swift

Add support to skip watchOS 32-bit simulator by default

@swift-ci smoke test Linux

shahmishal

comment created time in 5 hours

PR opened apple/swift

Add support to skip watchOS 32-bit simulator by default
+28 -0

0 comment

4 changed files

pr created time in 5 hours

create barnchapple/swift

branch : skip-32bit-watchos-sim

created branch time in 5 hours

pull request commentapple/swift

[DiagnosticQol][SR-14505] Use DeclDescriptive kind in missing return data flow diagnostics

@swift-ci Please smoke test

LucianoPAlmeida

comment created time in 5 hours

push eventapple/swift

Mishal Shah

commit sha 3fd82a182b1bdf33cd0079e28fb62ecbf8ba2273

[5.5] Add support for release/5.5 branch in update-checkout script

view details

Mishal Shah

commit sha 3b3f173ebde6e3b723ce9c81c10ae7b7c881f37b

Merge pull request #36950 from apple/shahmishal/5.5-support-new-branch [5.5] Add support for release/5.5 branch in update-checkout script

view details

push time in 5 hours

delete branch apple/swift

delete branch : shahmishal/5.5-support-new-branch

delete time in 5 hours

push eventapple/swift

Richard Wei

commit sha adb916849d1eb3e8d14b5e611aa757fee8cc1cd7

[AutoDiff] [AST] Handle null decl in 'printDifferentiableAttrArguments'. `DeclAttribute::print()` accepts null decls and has a null default argument. A segfault was triggered in SourceKitService because `printDifferentiableAttrArguments()` took a null decl and deferenced it. This patch makes `printDifferentiableAttrArguments()` handle null decls — if the decl is null, we do not print the differentiability parameters or the `where` clause. I have not added a unit test however because I haven't been able to reproduce it independently. This will be done later as this change is low-risk. Resolves rdar://76095289.

view details

Richard Wei

commit sha f17142883421ec0a240dd7d2208dd4dd79aec612

Merge pull request #36954 from rxwei/76095289

view details

swift_jenkins

commit sha 8a34f2907c7f22a95d7cd83557435a25398e8e12

Merge remote-tracking branch 'origin/main' into next

view details

push time in 9 hours

push eventapple/swift

Richard Wei

commit sha adb916849d1eb3e8d14b5e611aa757fee8cc1cd7

[AutoDiff] [AST] Handle null decl in 'printDifferentiableAttrArguments'. `DeclAttribute::print()` accepts null decls and has a null default argument. A segfault was triggered in SourceKitService because `printDifferentiableAttrArguments()` took a null decl and deferenced it. This patch makes `printDifferentiableAttrArguments()` handle null decls — if the decl is null, we do not print the differentiability parameters or the `where` clause. I have not added a unit test however because I haven't been able to reproduce it independently. This will be done later as this change is low-risk. Resolves rdar://76095289.

view details

Richard Wei

commit sha f17142883421ec0a240dd7d2208dd4dd79aec612

Merge pull request #36954 from rxwei/76095289

view details

push time in 9 hours

PR merged apple/swift

[AutoDiff] [AST] Handle null decl in 'printDifferentiableAttrArguments'.

DeclAttribute::print() accepts null decls and has a null default argument. A segfault was triggered in SourceKitService because printDifferentiableAttrArguments took a null decl and deferenced it. This patch makes printDifferentiableAttrArguments() handle null decls — if the decl is null, we do not print the differentiability parameters or the where clause.

I have not added a unit test however because I haven't been able to reproduce it independently. This will be done later as this change is low-risk.

Resolves rdar://76095289.

+18 -11

2 comments

1 changed file

rxwei

pr closed time in 9 hours

push eventapple/swift

Michael Gottesman

commit sha 90c0bf6e14b3d87e445f07fba63ff5e2c96e066d

[gardening] Remove an unnecessary bounds check on a container. As suggested by @atrick in review feedback in #36913.

view details

Michael Gottesman

commit sha 7345fd8e47f3b5ca6861eb34586d3283d56d6c4a

Merge pull request #36924 from gottesmm/pr-9a40bc50803b002b698f4b755a1f07fdaf6bd02d [gardening] Remove an unnecessary bounds check on a container.

view details

swift_jenkins

commit sha 80a677fde5949ed2c76a698f8ffe6a50bd258856

Merge remote-tracking branch 'origin/main' into next

view details

push time in 9 hours

pull request commentapple/swift

[DiagnosticQol][SR-14505] Use DeclDescriptive kind in missing return data flow diagnostics

@swift-ci Please smoke test

LucianoPAlmeida

comment created time in 10 hours

pull request commentapple/swift

[DiagnosticQol][SR-14505] Use DeclDescriptive kind in missing return data flow diagnostics

@swift-ci Please smoke test

LucianoPAlmeida

comment created time in 12 hours

pull request commentapple/swift

Fix long-standing soundness hole in rethrows checking

Instead of an underscored attribute, we could instead formalize it by introducing a new rethrows(unsafe) spelling in the function signature.

This would make sense to me—that, or some scoped bridging mechanism to allow an engineer to say "I'm going to call an intermediate function that can't throw an error itself (e.g. because it's @convention(c)), but which may need to catch an error thrown by the passed closure. Trust me." Which is of course what the new attribute does, but having a with-like function might be better from a readability standpoint (and would allow us to limit the scope of such behaviour to a specific subsection of the rethrowing function's body rather than the whole body.)

If nothing else, we could reserve the @_rethrowsUnchecked attribute for this with-like function only and tell everyone else to call it and not use the attribute directly.

slavapestov

comment created time in 12 hours

Pull request review commentapple/swift

Fix long-standing soundness hole in rethrows checking

 SIMPLE_DECL_ATTR(reasync, AtReasync,   ABIBreakingToAdd | ABIBreakingToRemove | APIBreakingToAdd | APIBreakingToRemove,   110) +SIMPLE_DECL_ATTR(_rethrowsUnchecked, RethrowsUnchecked,

It would be valuable to land this attribute before the checker changes so that code that relies on the current behaviour (such as DispatchQueue) has an opportunity to migrate.

slavapestov

comment created time in 12 hours

Pull request review commentapple/swift

[DNM] Placeholder types: take two

 Expr *ExprRewriter::coerceToType(Expr *expr, Type toType,                                  Optional<Pattern*> typeFromPattern) {   auto &ctx = cs.getASTContext(); +  // Diagnose conversions to invalid function types that couldn't be performed+  // beforehand because of placeholders.+  if (auto *fnTy = toType->getAs<FunctionType>()) {+    auto contextTy = cs.getContextualType(expr);+    if (cs.getConstraintLocator(locator)->isForContextualType() &&+        contextTy && contextTy->hasPlaceholder()) {+      TypeChecker::diagnoseInvalidFunctionType(fnTy, expr->getLoc(), None, dc,+                                               None);

Got it, makes sense. Yeah, you're right that to do this we'll have to have diagnoseInvalidFunctionType indicate failure.

Looking back at the "old" implementation, it looks like during type resolution we diagnosed these invalid types but didn't fail resolution, so presumably those invalid function types are getting applied to the AST. Do you think it makes sense to fail the application in all cases? I.e., remove the diagnoseInvalidFunctionType check from TypeResolver::resolveASTFunctionType and perform it only in coerceToType for all function types (not just those that had a placeholder), and fail coercion if so?

Jumhyn

comment created time in 13 hours

pull request commentapple/swift

[DiagnosticQol][SR-14505] Use DeclDescriptive kind in missing return data flow diagnostics

@swift-ci Please smoke test

LucianoPAlmeida

comment created time in 14 hours

Pull request review commentapple/swift

[DiagnosticQol][SR-14505] Use DeclDescriptive kind in missing return data flow diagnostics

 func testSR13753() {     //expected-warning@-1{{variable is unused}}   } }++// SR-14505+struct SR14505 {+    let b = true+    var x: Int {+        if b {+            return 0+        }+    } // expected-error {{missing return in a getter expected to return 'Int'}}++    var y: Int {+        get {+            if b {+                return 0+            }+        } // expected-error {{missing return in a getter expected to return 'Int'}}+        set {}+    } +}++class SR14505_C {+  static let a = false+  let b = true++  func method() -> Int {+    if b {+      return 0+    }+  } // expected-error {{missing return in a instance method expected to return 'Int'}}

It make sense to remove the article, thanks @harlanhaskins :)

LucianoPAlmeida

comment created time in 14 hours

PR opened apple/swift

[docs] Add short note about dynamic subclassing and KVO

<!-- What's in this pull request? --> This PR adds short documentation on dynamic subclassing and KVO. This documentation is based on an article here: https://www.mikeash.com/pyblog/friday-qa-2009-01-23.html

<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: --> Resolves SR-14199.

<!-- Before merging this pull request, you must run the Swift continuous integration tests. For information about triggering CI builds via @swift-ci, see: https://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci

Thank you for your contribution to Swift! -->

+25 -4

0 comment

4 changed files

pr created time in 18 hours