profile
viewpoint

google/re2 4991

RE2 is a fast, safe, thread-friendly alternative to backtracking regular expression engines like those used in PCRE, Perl, and Python. It is a C++ library.

googleapis/google-api-go-client 2374

Auto-generated Google APIs for Go.

googleapis/google-cloud-go 2289

Google Cloud Client Libraries for Go.

protocolbuffers/protobuf-go 431

Go support for Google's protocol buffers

pull request commentgolang/go

crypto/tls: returns a copy of c or nil if c is nil while using tls.Config.Clone()

Message from Dave Cheney:

Patch Set 1: Code-Review-1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/246637. After addressing review feedback, remember to publish your drafts!

sillydong

comment created time in 2 hours

pull request commentgolang/go

crypto/tls: returns a copy of c or nil if c is nil while using tls.Config.Clone()

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: A maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11 or adds a tag like "wait-release", it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/246637. After addressing review feedback, remember to publish your drafts!

sillydong

comment created time in 2 hours

issue commentgolang/go

Fix nil panic while doing http.Transport Clone()

Change https://golang.org/cl/246637 mentions this issue: crypto/tls: returns a copy of c or nil if c is nil while using tls.Config.Clone()

sillydong

comment created time in 2 hours

pull request commentgolang/go

crypto/tls: returns a copy of c or nil if c is nil while using tls.Config.Clone()

This PR (HEAD: 8f9a7b84cb722ed0d3d5d746bce3717f01721216) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/246637 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

sillydong

comment created time in 2 hours

issue commentgolang/go

cmd/compile: optimize unsigned comparisons with zero/one

Change https://golang.org/cl/246617 mentions this issue: cmd/compile: optimize unsigned comparisons to 0/1

josharian

comment created time in 6 hours

issue commentgolang/go

x/build/maintner/maintnerd/maintapi/version: support parsing all Go version tags, remove allocations

Change https://golang.org/cl/246597 mentions this issue: cmd/release: start using FreeBSD 11.2 builders for Go 1.15 RC 2+

dmitshur

comment created time in 7 hours

issue commentgolang/go

x/build/cmd/release: update to freebsd-{amd64,386}-11_2 builder for 1.15 RC 2+

Change https://golang.org/cl/246597 mentions this issue: cmd/release: start using FreeBSD 11.2 builders for Go 1.15 RC 2+

dmitshur

comment created time in 7 hours

issue commentgolang/go

x/tools/internal/imports: automatically update stdlib index every major release

Change https://golang.org/cl/246581 mentions this issue: internal/imports: update stdlib index for 1.15

smasher164

comment created time in 8 hours

push eventgolang/tools

Heschi Kreinick

commit sha 6c149bb5ef0db65038b2abbe6c6d0128f2f2cd90

internal/lsp/cache: store parseGoHandles parseGoHandles have lifetimes separate from the packages they belong to. For example, a package may be invalidated by a change to one of its files, but we still want to retain the parse results for all the rest. Track them explicitly. Change-Id: I03a4ffe283bf2b252d2d838bdb2cf332cd981075 Reviewed-on: https://go-review.googlesource.com/c/tools/+/245059 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org>

view details

push time in 10 hours

issue commentgolang/go

pkgsite: various UI cleanups due to new fixed header on details page

Change https://golang.org/cl/246580 mentions this issue: content/static/css: hide search text in header on small viewports

andybons

comment created time in 10 hours

issue commentgolang/go

pkgsite: various UI cleanups due to new fixed header on details page

Change https://golang.org/cl/246578 mentions this issue: content/static/css: preserve casing of version in fixed header

andybons

comment created time in 10 hours

issue commentgolang/go

pkgsite: various UI cleanups due to new fixed header on details page

Change https://golang.org/cl/246577 mentions this issue: content/static/css: update target padding and restrict to details pages

andybons

comment created time in 10 hours

issue closedgolang/go

x/pkgsite: anchor links sometimes do not work

Sometimes when visiting an anchor link, you will not be taken directly to that heading.

For example, visiting https://pkg.go.dev/cloud.google.com/go/storage?tab=doc#hdr-ACLs will take you to the correct heading, but refreshing the page will not. This behavior is not reliably reproducible.

/cc @andybons @spf13

closed time in 10 hours

julieqiu

push eventgolang/pkgsite

Andrew Bonventre

commit sha d1e38062776c768a8f2fd4390ab7151785d756e7

content/static/css: constrain fixed position hack to mobile Safari overflow: auto was fixing an issue relating to the overflow menu in the fixed header on iOS, but was causing a bunch of other issues. Notably, the scrollbar was underneath the fixed header and anchor links did not behave as expected. Only set this on mobile Safari (where these issues don’t present themselves; I’m sure others will pop up but they’re at least restricted to mobile Safari). Updates golang/go#40504 Fixes golang/go#40552 Fixes golang/go#40556 Change-Id: Ib7e108672d6897421faefa3a0b45cc6d7835bb15 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/246478 Run-TryBot: Andrew Bonventre <andybons@golang.org> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Julie Qiu <julie@golang.org>

view details

push time in 10 hours

issue closedgolang/go

x/pkgsite: back button does not change view after following link within page

What did you do?

  • Navigate to any package page, for example, https://pkg.go.dev/net/http?tab=doc
  • Click a link to an anchor within the page from the left sidebar, for example, https://pkg.go.dev/net/http?tab=doc#Request
  • Click the browser's back button.

What did you expect to see?

After clicking the back button, the browser view should be at the top of the page, where it started.

What did you see instead?

The view actually moves down a little bit, so the heading type Request is obscured by the sticky header.

If I scroll first before clicking the back button, then the browser's view does not change.

In both cases, the URL changes in the address bar, and a dot is shown next to Overview in the left side bar, as I would expect.

closed time in 10 hours

jayconrod

push eventgolang/go

Cherry Zhang

commit sha b85033d153835c45cd4ee51046a34c1dac52f0e0

[dev.link] cmd/link: fix pclntab symbol handling on AIX On AIX, container symbols are handled in a weird way (unlike other platforms): the outer symbol needs to have size (but still no data), and the inner symbols must not be in the symbol table (otherwise it overlaps with the outer symbol, which the system linker doesn't like). As of CL 241598, pclntab becomes a container symbol. We need to follow the rule above for AIX. Fix AIX build. Change-Id: Ie2515a4cabbd8cf3f6d3868643a28f64ca3365a2 Reviewed-on: https://go-review.googlesource.com/c/go/+/246479 Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Jeremy Faller <jeremy@golang.org>

view details

push time in 11 hours

push eventgolang/tools

Danish Dua

commit sha 5a22b632c5de95bde241c5faab365d9aaf928c06

internal/lsp: refactor line folding range code This CL removes duplicate code in lineFoldingRange function under lsp/source/folding_range.go and generally improves code quality. Fixes bug with composite literal folding where gopls was folding literals with braces on the same line as end token (paranthesis/braces). Change-Id: I742f285d866d72a243129c0aef0935fe2a1ad0dd Reviewed-on: https://go-review.googlesource.com/c/tools/+/245757 Reviewed-by: Heschi Kreinick <heschi@google.com>

view details

push time in 12 hours

issue commentgolang/vscode-go

process: update the language client to v7.0.0

Change https://golang.org/cl/246557 mentions this issue: package.json: upgrade vscode-languageclient to use 7.0.0-next*

hyangah

comment created time in 12 hours

push eventgolang/tools

Heschi Kreinick

commit sha c9619e8fac0c794c0683e392d8728c5de9edf4bb

internal/lsp: separate LSP files from FS files FileHandle currently includes LSP-level information about Version and Session. That's dangerous, because the cache operates in terms of URIs and content only -- we explicitly want to share results across sessions and versions if they happen to be the same. Split the LSP information into separate types, VersionedFileHandle and VersionedFileIdentity. Change-Id: I158646b783375b58245468599301e2a29c657e71 Reviewed-on: https://go-review.googlesource.com/c/tools/+/245058 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>

view details

push time in 13 hours

push eventgolang/tools

Heschi Kreinick

commit sha 39fdd541e6713605ef4dbc6fc9cd9157f70ca528

internal/lsp: move builtin package to Snapshot The builtin package was the one special case where we parsed Go outside the context of a Snapshot. Move it up. Change-Id: I1f4bb536adb40019e0ea9c5c89f38b15737abb8c Reviewed-on: https://go-review.googlesource.com/c/tools/+/245057 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>

view details

push time in 13 hours

push eventgolang/tools

Heschi Kreinick

commit sha 412b8bda491ceac80bee26e093f0996ee9bac50c

internal/lsp/cache: ref-count snapshots To manually collect cache entries, we need to know when a snapshot is idle. Add a reference count in the form of a WaitGroup and keep track of its uses. The pattern is that any time a snapshot is returned, it comes with a release function that decrements the ref count. Almost all uses of a snapshot originate in a user-facing request, handled in beginFileRequest. There it's mostly an exercise in passing Snapshots around instead of Views. In the other places I took the path of least resistance. For file modifications I tried to minimize the amount of code that needed to deal with snapshots. For diagnostics I just acquired the snapshot at the diagnostics call. Change-Id: Id48a2df3acdd97f27d905e2c2be23072f28f196b Reviewed-on: https://go-review.googlesource.com/c/tools/+/241837 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>

view details

push time in 13 hours

issue closedgolang/go

x/pkgsite: Examples render teardown code

<!-- Please answer these questions before submitting your issue. Thanks! -->

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/deanishe/awgo?tab=doc#example-Config.To

What is your user agent?

Firefox

<!-- You can find your user agent here: https://www.whatismybrowser.com/detect/what-is-my-user-agent -->

Screenshot

<!-- Please paste a screenshot of the page. -->

go-pkg

godoc.org

godoc

What did you do?

<!-- If possible, provide a recipe for reproducing the error. -->

Add teardown code to an example after the // Output: stanza.

What did you expect to see?

No teardown code (i.e. godoc.org behaviour).

What did you see instead?

Teardown code. As it's presented as part of the example body, and not after the test output as it actually appears in the source code, I believe it may confuse readers.

closed time in 13 hours

deanishe

push eventgolang/pkgsite

Jonathan Amsterdam

commit sha 82d7e825f835eedb25decb1b48f6588d055474af

internal/fetch/dochtml/internal/render: drop example cleanup code Consider any code after the last "// Output:" comment to be "cleanup" code and omit it from the example. Fixes golang/go#40517. Change-Id: I17e0b6859d188192cf1f2eb851d8d8888229ff63 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/246241 Reviewed-by: Julie Qiu <julie@golang.org>

view details

push time in 13 hours

issue commentgolang/go

x/pkgsite: Examples render teardown code

Change https://golang.org/cl/246241 mentions this issue: internal/fetch/dochtml/internal/render: drop example cleanup code

deanishe

comment created time in 13 hours

push eventgolang/website

Jay Conrod

commit sha c1742b35e9dcced5ddef6bfb8e00b91294e1970e

content/static/doc: set proper header ids in module documentation Previously, we used a separate <a> tag before the header. Headers had temporary ids, and the table of contents linked to those. With this change, the header elements themselves will have ids. For golang/go#33637 Change-Id: Ia79048f0db7cc4e8eac3bb5641278acd354fca01 Reviewed-on: https://go-review.googlesource.com/c/website/+/244766 Reviewed-by: Michael Matloob <matloob@golang.org>

view details

push time in 13 hours

push eventgolang/website

Jay Conrod

commit sha a7ab0d77db120befd4cff91e4e0a2fd6ff09bfab

content/static/doc: add module documentation on GOPATH compatibility For golang/go#33637 Change-Id: I839a4075df8494389a69416e49e0fdc0ac812818 Reviewed-on: https://go-review.googlesource.com/c/website/+/244417 Run-TryBot: Jay Conrod <jayconrod@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Michael Matloob <matloob@golang.org>

view details

push time in 13 hours

push eventgolang/website

Jay Conrod

commit sha 30a909d998cb68f2dada200bd533fad6eb532944

content/static/doc: add module documentation on module cache For golang/go#33637 Change-Id: I58300dfe59b5e4e3cb118fd07f5a00419acc07b8 Reviewed-on: https://go-review.googlesource.com/c/website/+/242318 Run-TryBot: Jay Conrod <jayconrod@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Michael Matloob <matloob@golang.org>

view details

push time in 13 hours

issue commentgolang/go

x/pkgsite: anchor links sometimes do not work

Change https://golang.org/cl/246478 mentions this issue: content/static/css: update CSS to only overflow: auto on mobile

julieqiu

comment created time in 13 hours

issue commentgolang/go

x/pkgsite: back button does not change view after following link within page

Change https://golang.org/cl/246478 mentions this issue: content/static/css: update CSS to only overflow: auto on mobile

jayconrod

comment created time in 13 hours

issue commentgolang/go

pkgsite: various UI cleanups due to new fixed header on details page

Change https://golang.org/cl/246478 mentions this issue: content/static/css: update CSS to only overflow: auto on mobile

andybons

comment created time in 13 hours

push eventgolang/website

Katie Hockman

commit sha d81f613c3ab2d595d6e1df5f6a8f0d44aa447f08

internal/history: document upcoming Go 1.14.7 and Go 1.13.15 security releases They have been pre-announced¹. ¹ https://groups.google.com/d/msg/golang-announce/_ulYYcIWg3Q/9zUUX8a9AQAJ Change-Id: I2356a20be683b4ec8cad2825d33bd118c66be7ee Reviewed-on: https://go-review.googlesource.com/c/website/+/246500 Run-TryBot: Katie Hockman <katie@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Alexander Rakoczy <alex@golang.org>

view details

push time in 14 hours

push eventgolang/go

Cherry Zhang

commit sha f204ca305128ad1b500d3ba77aebf5509509a8fc

[dev.link] cmd/link: drop hash maps after loading The hash maps are used to deduplicate hashed symbols. Once we loaded all the symbols, we no longer need the hash maps. Drop them. Linking cmd/compile, name old live-B new live-B delta Loadlib_GC 13.1M ± 0% 11.3M ± 0% -13.62% (p=0.008 n=5+5) Change-Id: I4bb1f84e1111a56d9e777cd6a68f7d974b60e321 Reviewed-on: https://go-review.googlesource.com/c/go/+/245721 Reviewed-by: Jeremy Faller <jeremy@golang.org>

view details

Cherry Zhang

commit sha db924fd99e85e483def6dec1847d9527a93aaafb

[dev.link] cmd/compile, cmd/link: generate itablink at link time Currently, at compile time, for each itab symbol, we create an "itablink" symbol which holds solely the address of the itab symbol. At link time, all the itablink symbols are grouped together to form the itablinks slice. This CL removes the itablink symbols, and directly generate the itablinks slice in the linker. This removes a number of symbols, which are dupOK and generally have long names. And also removes a special handling of itablink symbols in the deadcode pass which iterates through all symbols. Change-Id: I475c3c8899e9fbeec9abc7647b1e4a69aa5c3c5a Reviewed-on: https://go-review.googlesource.com/c/go/+/245901 Reviewed-by: Jeremy Faller <jeremy@golang.org>

view details

Cherry Zhang

commit sha 5c9b540378ed81fd45cc13f0a610bb29140e28ff

[dev.link] cmd/internal/goobj: delete old object file reader Change-Id: Ieebab205e2cea2b4665c830b7424d543812787ff Reviewed-on: https://go-review.googlesource.com/c/go/+/246441 Reviewed-by: Austin Clements <austin@google.com> Reviewed-by: Jeremy Faller <jeremy@golang.org>

view details

push time in 14 hours

push eventgolang/go

push time in 14 hours

push eventgolang/go

Cherry Zhang

commit sha f204ca305128ad1b500d3ba77aebf5509509a8fc

[dev.link] cmd/link: drop hash maps after loading The hash maps are used to deduplicate hashed symbols. Once we loaded all the symbols, we no longer need the hash maps. Drop them. Linking cmd/compile, name old live-B new live-B delta Loadlib_GC 13.1M ± 0% 11.3M ± 0% -13.62% (p=0.008 n=5+5) Change-Id: I4bb1f84e1111a56d9e777cd6a68f7d974b60e321 Reviewed-on: https://go-review.googlesource.com/c/go/+/245721 Reviewed-by: Jeremy Faller <jeremy@golang.org>

view details

push time in 14 hours

push eventgolang/go

Cherry Zhang

commit sha 69748f0ce4faf850a2e25641aed23e646556d616

[dev.link] cmd/compile, cmd/link: reference type symbol of defined type by index The type descriptor symbol of a defined (named) type (and pointer to it) is defined only in the package that defines the type. It is not dupOK, unlike other type descriptors. So it can be referenced by index. Currently it is referenced by name for cross-package references, because the index is not exported and so not known to the referencing package. This CL passes the index through the export data, so the symbol can be referenced by index, and does not need to be looked up by name. This also makes such symbol references consistent: it is referenced by index within the defining package and also cross- package, which makes it easier for content hashing (in later CLs). One complication is that we need to set flags on referenced symbols (specifically, the UsedInIface flag). Before, they are non-package refs, which naturally carry flags in the object file. For indexed refs, we currently don't put their flags in the object file. Introduce a new block for this. Change-Id: I8126f8e318ac4e6609eb2ac136201fd6c264c256 Reviewed-on: https://go-review.googlesource.com/c/go/+/245718 Reviewed-by: Jeremy Faller <jeremy@golang.org>

view details

Cherry Zhang

commit sha cecb7a1cf31e8d8991669208e584269db32066c9

[dev.link] cmd/compile, cmd/link: make itab symbols content-addressable Extend the content-addressable symbol mechanism to itab symbols. Itab symbols require global uniqueness (as at run time we compare pointers), so it needs to be reliably deduplicated. Currently the content hash depends on symbol name expansion, so we can only do this when all Go packages are built with know package paths. Fall back to checking names if any Go package is built with unknown package path. Change-Id: Icf5e8873755050c20e5fc6549f6de1c883254c89 Reviewed-on: https://go-review.googlesource.com/c/go/+/245719 Reviewed-by: Jeremy Faller <jeremy@golang.org>

view details

push time in 14 hours

push eventgolang/sys

Tobias Klauser

commit sha 64077c9b5642ac67ce07bc05738eb432a9029f93

unix: add Faccessat2 and use it in Faccessat if available Linux kernel 5.8 added the faccessat2 syscall taking a flags argument. Attempt to use it in Faccessat and fall back to the existing implementation mimicking glibc faccessat. Tested on Debian Buster with manually built Linux kernel 5.8 Suggested by Ian Lance Taylor. Change-Id: Ia14f744a63dde7ff2dea34935cabc62937de9cb5 Reviewed-on: https://go-review.googlesource.com/c/sys/+/246537 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

push time in 14 hours

issue commentgolang/vscode-go

settings: support predefined variables in go.toolsEnvVars

Change https://golang.org/cl/246519 mentions this issue: src/goEnv.ts: readd go.toolsEnvVars variable substitution

edp1096

comment created time in 14 hours

issue commentgolang/vscode-go

`goroot` variable interpolation stopped working

Change https://golang.org/cl/246518 mentions this issue: src/goMain.ts: reinstate the goroot var interpolation

mgood

comment created time in 14 hours

issue commentgolang/go

x/website: Improve "getting started" experience with simplified install steps and tutorials.

Change https://golang.org/cl/246499 mentions this issue: content/static/doc: improve getting started docs with install topic and tutorials

stevetraut

comment created time in 14 hours

issue commentgolang/go

x/pkgsite: examples missing playground links

Change https://golang.org/cl/246498 mentions this issue: content/static: fix css padding for playground examples

myitcv

comment created time in 14 hours

push eventgolang/gofrontend

Ian Lance Taylor

commit sha 7f0d3834ac40cf3bcbeb9b13926ab5ccb2523537

internal/syscall/unix: correct ia64 syscall numbers Per Andreas Schwab. Change-Id: Ib3e0b17722ce24001aa46a4f0ae36865a228b084 Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/246264 Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

push time in 17 hours

push eventgolang/go

Jeremy Faller

commit sha e4e1c6a7aff04a61a202ed1b331ffdfdff5a77cf

[dev.link] add compilation unit index to func Not used yet, but add the compilation unit for a function to func. Change-Id: I7c43fa9f1da044ca63bab030062519771b9f4418 Reviewed-on: https://go-review.googlesource.com/c/go/+/244547 Run-TryBot: Jeremy Faller <jeremy@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Austin Clements <austin@google.com> Reviewed-by: Cherry Zhang <cherryyz@google.com>

view details

push time in 17 hours

push eventgolang/go

Jeremy Faller

commit sha 89cf569a45f035bae45553f399880b92ede65f38

[dev.link] move FuncID creation into the compiler/assembler Leaving creation of the funcID till the linker requires the linker to load the function and file names into memory. Moving these into the compiler/assembler prevents this. This work is a step towards moving all func metadata into the compiler. Change-Id: Iebffdc5a909adbd03ac263fde3f4c3d492fb1eac Reviewed-on: https://go-review.googlesource.com/c/go/+/244024 Run-TryBot: Jeremy Faller <jeremy@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com> Reviewed-by: Austin Clements <austin@google.com>

view details

push time in 17 hours

push eventgolang/pkgsite

Julie Qiu

commit sha f7906b062e0a7de44b5a0727b6c81c941127ed09

internal/frontend: add version type metric A metric is added to determine the number of requests that are made to @latest, @master, or a specific semantic version. This metric is used to get better insight into the type of requests that are being made to the details endpoint. The version type tag for frontend fetch is removed, since this data isn't useful. Change-Id: Ib89acb69297430acd3722bb805456d8ebb30730c Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/246397 Reviewed-by: Jonathan Amsterdam <jba@google.com>

view details

push time in 17 hours

push eventgolang/pkgsite

Julie Qiu

commit sha 2e0825b49fa6ea21f9619efc78cd6d88d5c4ce1d

internal/fetch/dochtml: add Package Files to sidenav Change-Id: I0d7bbc470adf4974c5ede6d97ce8d2f52aa2a68c Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/246438 Run-TryBot: Julie Qiu <julie@golang.org> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Andrew Bonventre <andybons@golang.org>

view details

push time in 17 hours

push eventgolang/pkgsite

Julie Qiu

commit sha 2f05667100f64b3f857ba2e288efd6577e8cbd4d

internal/frontend: enqueue tasks in serveDetails using separate context When calling ScheduleFetch in serveDetails, it is possible that the request ends and the context is canceled, before the goroutine finishes enqueuing a task to the frontend fetch task queue. A context.Background with a timeout is used instead. Change-Id: Iee6909c1318c618e4ad3a275d281274c0be87355 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/246217 Run-TryBot: Julie Qiu <julie@golang.org> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>

view details

push time in 17 hours

push eventgolang/gofrontend

Ian Lance Taylor

commit sha 82a0db12bcb205748a5319b03e070d5502246ba7

internal/syscall/unix: define copyFileRangeTrap for all architectures Change-Id: If385a266f4aa7c5903d6c3ce51fafddc2286cf8d Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/246363 Reviewed-by: Cherry Zhang <cherryyz@google.com>

view details

push time in 18 hours

issue closedgolang/go

cmd/compile: for range loop reading past slice end [1.14 backport]

@randall77 requested issue #40367 to be considered for backport to the next 1.14 minor release.

@gopherbot, please open backport issues for 1.14 and 1.13.

closed time in 19 hours

gopherbot

issue commentgolang/go

cmd/compile: for range loop reading past slice end [1.14 backport]

Closed by merging 739b9d5afe04b16a3726475c2ae2a136d3920477 to release-branch.go1.14.

gopherbot

comment created time in 19 hours

issue closedgolang/go

cmd/compile: for range loop reading past slice end [1.13 backport]

@randall77 requested issue #40367 to be considered for backport to the next 1.13 minor release.

@gopherbot, please open backport issues for 1.14 and 1.13.

closed time in 19 hours

gopherbot

issue commentgolang/go

cmd/compile: for range loop reading past slice end [1.13 backport]

Closed by merging 5ebdfd905d8f2d70601aa11212d579fa60abdb0f to release-branch.go1.13.

gopherbot

comment created time in 19 hours

push eventgolang/go

Keith Randall

commit sha 5ebdfd905d8f2d70601aa11212d579fa60abdb0f

[release-branch.go1.13] cmd/compile: don't addLocalInductiveFacts if there is no direct edge from if block to phi block Currently in addLocalInductiveFacts, we only check whether direct edge from if block to phi block exists. If not, the following logic will treat the phi block as the first successor, which is wrong. This patch makes prove pass more conservative, so we disable some cases in test/prove.go. We will do some optimization in the following CL and enable these cases then. Fixes #40500. Change-Id: I27cf0248f3a82312a6f7dabe11c79a1a34cf5412 Reviewed-on: https://go-review.googlesource.com/c/go/+/244579 Reviewed-by: Zach Jones <zachj1@gmail.com> Reviewed-by: Keith Randall <khr@golang.org> Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-on: https://go-review.googlesource.com/c/go/+/245957 Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org>

view details

push time in 20 hours

push eventgolang/go

Keith Randall

commit sha 739b9d5afe04b16a3726475c2ae2a136d3920477

[release-branch.go1.14] cmd/compile: don't addLocalInductiveFacts if there is no direct edge from if block to phi block Currently in addLocalInductiveFacts, we only check whether direct edge from if block to phi block exists. If not, the following logic will treat the phi block as the first successor, which is wrong. This patch makes prove pass more conservative, so we disable some cases in test/prove.go. We will do some optimization in the following CL and enable these cases then. Fixes #40501. Change-Id: I27cf0248f3a82312a6f7dabe11c79a1a34cf5412 Reviewed-on: https://go-review.googlesource.com/c/go/+/244579 Reviewed-by: Zach Jones <zachj1@gmail.com> Reviewed-by: Keith Randall <khr@golang.org> Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-on: https://go-review.googlesource.com/c/go/+/245958 Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org>

view details

push time in 20 hours

push eventgolang/sys

Tobias Klauser

commit sha fd5f0c170ac37caeac837d96642d00a0b2807478

unix: update Dockerfile to Linux 5.8 Change-Id: If6643e7e092c5d482f9cefe838640ebcec22188e Reviewed-on: https://go-review.googlesource.com/c/sys/+/246417 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Matt Layher <mdlayher@gmail.com>

view details

push time in 20 hours

created taggolang/vscode-go

tagv0.16.0

Go extension for VS Code

created time in 20 hours

push eventgolang/vscode-go

Hana (Hyang-Ah) Kim

commit sha 634aa30f2431036fa929c18108d932cd532c4041

[release] CHANGELOG.md: v0.16.0 release note Change-Id: I1ece25f677a2cf4e343002b1e44a4a5f9bd297d4 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/245777 Reviewed-by: Brayden Cloud <bcloud@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> (cherry picked from commit c22bbe54ba13c1498f77a66f251bf868f7d1eacf) Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/245899 Reviewed-by: Rebecca Stambler <rstambler@golang.org>

view details

push time in 20 hours

push eventgolang/pkgsite

Julie Qiu

commit sha 31bd5da44364476734f62492f03d0c5add25a61c

content: change "POPULAR SEARCHES" to "EXAMPLE SEARCHES" The searches listed on the homepage are example searches, not necessarily the most popular. The caption is changed accordingly. Change-Id: Ife71e2b8856b45526a5cd88c2214c0bd06dbf6af Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/246439 Reviewed-by: Jamal Carvalho <jamal@golang.org>

view details

push time in 20 hours

created taggolang/tools

taggopls/v0.4.4

[mirror] Go Tools

created time in 20 hours

push eventgolang/pkgsite

Julie Qiu

commit sha 6770e0a2cd0ca8ae46c67e63d30850bdf7d53c2f

content: display documentation source files A section for package files containing links to the source code files was added in CL 240007. These will now be displayed on pkg.go.dev. For golang/go#37863 Change-Id: I35a7e74f631aa1f8c0a9775b0d721e7646843291 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/246437 Reviewed-by: Jonathan Amsterdam <jba@google.com>

view details

push time in 21 hours

issue commentgolang/go

x/pkgsite: missing source files listing

Change https://golang.org/cl/246437 mentions this issue: content: display documentation source files

tooolbox

comment created time in 21 hours

push eventgolang/pkgsite

Miguel Acero

commit sha cd125992647c1090daf10ac29b3673ec29e399ab

internal/frontend: add metrics for playground share requests A metric is added for everytime a request is sent to play.golang.org. The request status code will be used and is useful to have better visibility on how many users click the new playground "play" button. For golang/go#36865 Change-Id: I243efe5b3d8724fa6bdd60d332e2932925ffe094 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/245898 Reviewed-by: Jonathan Amsterdam <jba@google.com>

view details

push time in 21 hours

issue commentgolang/go

crypto/tls: cleanup handshake state

Change https://golang.org/cl/246263 mentions this issue: crypto/tls: delete one useless judge statement.

FiloSottile

comment created time in a day

pull request commentgolang/crypto

Use correct default hashes and default ciphers when no preferences given

Message from Andrey Borodin:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/224857. After addressing review feedback, remember to publish your drafts!

x4m

comment created time in a day

pull request commentgolang/go

cmd/go: use the correct linker config in the buildID hash

Message from Alex Opie:

Patch Set 2:

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/243557. After addressing review feedback, remember to publish your drafts!

lxop

comment created time in a day

pull request commentgolang/go

Update go_spec.html

Message from Ian Lance Taylor:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/246238. After addressing review feedback, remember to publish your drafts!

AlphaHot

comment created time in 2 days

issue commentgolang/go

x/tools/gopls: improve completion in binary expressions

Change https://golang.org/cl/246362 mentions this issue: internal/lsp/source: don't prefer bool candidates in bool exprs

muirdm

comment created time in 2 days

issue commentgolang/go

encoding/base64: decoder output depends on chunking of underlying reader

Change https://golang.org/cl/246377 mentions this issue: encoding/base64: fix base64 encoding when stream input comes

AxbB36

comment created time in 2 days

pull request commentgolang/lint

lint: add test for invalid package names

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: A maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/246361. After addressing review feedback, remember to publish your drafts!

unkiwii

comment created time in 2 days

pull request commentgolang/lint

lint: add test for invalid package names

This PR (HEAD: 9b12c090b39617039e8597a8cabcfa011f1ae4f5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/lint/+/246361 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

unkiwii

comment created time in 2 days

pull request commentgolang/go

Update go_spec.html

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: A maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11 or adds a tag like "wait-release", it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/246238. After addressing review feedback, remember to publish your drafts!

AlphaHot

comment created time in 2 days

pull request commentgolang/go

Update go_spec.html

This PR (HEAD: be05dea4bd7bcf40b22746e190067e6d61a7472c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/246238 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

AlphaHot

comment created time in 2 days

issue closedgolang/go

x/sys/windows/svc/example: does not start

<!-- Please answer these questions before submitting your issue. Thanks! For questions please use one of our forums: https://github.com/golang/go/wiki/Questions -->

What version of Go are you using (go version)?

<pre> $ go version go version go1.14.4 windows/amd64 </pre>

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

<details><summary><code>go env</code> Output</summary><br><pre> $ go env set GO111MODULE= set GOARCH=amd64 set GOBIN= set GOCACHE=C:\Users\chris.macklin\AppData\Local\go-build set GOENV=C:\Users\chris.macklin\AppData\Roaming\go\env set GOEXE=.exe set GOFLAGS= set GOHOSTARCH=amd64 set GOHOSTOS=windows set GOINSECURE= set GONOPROXY= set GONOSUMDB= set GOOS=windows set GOPATH=C:\Users\chris.macklin\go set GOPRIVATE= set GOPROXY=https://proxy.golang.org,direct set GOROOT=c:\go set GOSUMDB=sum.golang.org set GOTMPDIR= set GOTOOLDIR=c:\go\pkg\tool\windows_amd64 set GCCGO=gccgo set AR=ar set CC=gcc set CXX=g++ set CGO_ENABLED=1 set GOMOD=C:\Users\chris.macklin\Downloads\sys\go.mod set CGO_CFLAGS=-g -O2 set CGO_CPPFLAGS= set CGO_CXXFLAGS=-g -O2 set CGO_FFLAGS=-g -O2 set CGO_LDFLAGS=-g -O2 set PKG_CONFIG=pkg-config set GOGCCFLAGS=-m64 -mthreads -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=C:\Users\CHRIS~1.MAC\AppData\Local\Temp\go-build041286302=/tmp/go-build -gno-record-gcc-switches

</pre></details>

What did you do?

<!-- If possible, provide a recipe for reproducing the error. A complete runnable program is good. A link on play.golang.org is best. -->

  • Cloned https://github.com/golang/sys
  • $ go build .\windows\svc\example
  • $ example.exe debug
  • $ example.exe install
  • $ example.exe start

What did you expect to see?

From the debug invocation, beeping and logging to the command line.

From the start invocation, the service starts, beeps periodically, and logs "beep" at info level to the event log.

What did you see instead?

The debug invocation runs correctly, logs to the command line, and beeps.

The start invocation returns no error, but the service fails to start.

"starting myservice service" is logged to the Application event log at info level. "The my service service terminated unexpectedly." is logged to the System event log at error level.

Trying to start the service from the GUI service manager provides the same error.

closed time in 2 days

macklin-10x

push eventgolang/sys

Alex Brainman

commit sha 4b90ce9b60b31bd0d0cbceb17532b5c810912f88

windows/svc: align stack in servicemain before calling syscall I noticed that we call syscall in servicemain without aligning stack. That is against Windows rules, so align the stack as required. I tried running this code with specifically non-aligned stack (I aligned stack, and then subtracted 1 from SP) on my Windows 10 to test this change. But it makes no difference on my Windows 10 PC - I built and run golang.org/x/sys/windows/svc/example, and it runs successfully regardless of stack alignment. But alignment might make difference on other computers. Maybe fixes golang/go#40160 Change-Id: I351f7f730fba4aa6dc409a79de4ad737b4a0a7d4 Reviewed-on: https://go-review.googlesource.com/c/sys/+/246317 Run-TryBot: Alex Brainman <alex.brainman@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

push time in 2 days

issue commentgolang/go

x/tools/gopls: completing inside `new()` suggests keywords first

Change https://golang.org/cl/246360 mentions this issue: internal/lsp/source: improve unnamed type completion

muirdm

comment created time in 2 days

issue commentgolang/go

x/tools/gopls: improve completion to builtin types

Change https://golang.org/cl/246360 mentions this issue: internal/lsp/source: improve unnamed type completion

muirdm

comment created time in 2 days

push eventgolang/go

Keith Randall

commit sha f92337422ef2ca27464c198bb3426d2dc4661653

runtime/race: fix ppc64le build The .syso test also fails for ppc64le. Not sure why. For now, just disable the test for that architecture. The test really only needs to run on a single builder of any arch. Change-Id: I346cdc01ada09d43c4c504fbc30be806f59d5422 Reviewed-on: https://go-review.googlesource.com/c/go/+/246358 Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

push time in 2 days

push eventgolang/gofrontend

Ian Lance Taylor

commit sha 2c390ba951e83b547f6387cc9e19436c085b3775

libgo: update to go1.15rc1 Change-Id: Iab1ff0b7d52efdb3310c859605d2cfc75c1a903e Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/245157 Reviewed-by: Cherry Zhang <cherryyz@google.com>

view details

push time in 3 days

issue commentgolang/go

proposal: crypto/tls: add (*tls.Conn).HandshakeContext and add context to ClientHelloInfo, CertificateRequestInfo

Change https://golang.org/cl/246338 mentions this issue: DO NOT REVIEW: crypto/tls: add HandshakeContext method to Conn

johanbrandhorst

comment created time in 3 days

pull request commentgolang/mobile

cmd/gomobile: fix ndkRoot for updated NDK location

Message from Hajime Hoshi:

Patch Set 5:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/244057. After addressing review feedback, remember to publish your drafts!

federicobond

comment created time in 3 days

push eventgolang/mobile

Hajime Hoshi

commit sha 973feb4309de5c3aad0553fc987d76abf1fa58f7

cmd/gomobile: skip TestWriter TestWriter is flaky and often fails on the trybots. Skip this as a tentative solution. Updates golang/go#40290 Change-Id: I3a8aa74fb6cb727a216da4046edaa159f9aa2dc3 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/243839 Run-TryBot: Hajime Hoshi <hajimehoshi@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>

view details

push time in 3 days

push eventgolang/image

Nigel Tao

commit sha 972c09e46d762a13c1a3c48b1fa9b87e2c537805

font/sfnt: fix Font.GlyphBounds with truncated hmtx table Thanks to Joe Blubaugh for the suggestion. Change-Id: I27cb776614b5a4a0d023755f01b4db06e3d9a1c5 Reviewed-on: https://go-review.googlesource.com/c/image/+/244997 Run-TryBot: Nigel Tao <nigeltao@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Nigel Tao <nigeltao@golang.org>

view details

push time in 3 days

issue commentgolang/go

Post handshake authentication with the TLS 1.3 client

Change https://golang.org/cl/246337 mentions this issue: crypto/tls: support post-handshake client authentication

skyfmmf

comment created time in 3 days

issue commentgolang/go

x/sys/windows/svc/example: does not start

Change https://golang.org/cl/246317 mentions this issue: windows/svc: align stack in servicemain before calling syscall

macklin-10x

comment created time in 3 days

push eventgolang/go

Keith Randall

commit sha e49b2308a523c3bb69753caee2eacce41f097039

runtime/race: rebuild some .syso files to remove getauxval dependency We can't depend on getauxval because it only exists in glibc >= 2.16. Tsan has been updated to avoid that dependency (https://reviews.llvm.org/D84859). This CL rebuilds the affected .syso files, and adds a test to make sure we don't regress. Fixes #37485 Change-Id: I891f54d28ec0d7da50a8df1adadc76dd6e7ab3e0 Reviewed-on: https://go-review.googlesource.com/c/go/+/246258 Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Dmitry Vyukov <dvyukov@google.com>

view details

push time in 3 days

issue closedgolang/go

runtime/race: race_linux_amd64.syso now depends on glibc 2.16

What version of Go are you using (go version)?

<pre> $ go version go version go1.13.8 linux/amd64 </pre>

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

<details><summary><code>go env</code> Output</summary><br><pre> $ go env GO111MODULE="" GOARCH="amd64" GOBIN="" GOCACHE="/home/vagrant/.cache/go-build" GOENV="/home/vagrant/.config/go/env" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="linux" GONOPROXY="" GONOSUMDB="" GOOS="linux" GOPATH="/home/vagrant/go" GOPRIVATE="" GOPROXY="https://proxy.golang.org,direct" GOROOT="/opt/golang1.13/lib/golang" GOSUMDB="sum.golang.org" GOTMPDIR="" GOTOOLDIR="/opt/golang1.13/lib/golang/pkg/tool/linux_amd64" GCCGO="gccgo" AR="ar" CC="gcc" CXX="g++" CGO_ENABLED="1" GOMOD="" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build152338807=/tmp/go-build" </pre></details>

What did you do?

I am attempting to build go 1.14 for our internal, EL6-based distribution. 1.12 and 1.13 work fine, but 1.14 fails any time it tries to build with -race with the following:

<pre> ld: race_linux_amd64.syso: in function __sanitizer::ReExec()': gotsan.cpp:(.text+0x1873c): undefined reference togetauxval' collect2: error: ld returned 1 exit status FAIL flag [build failed] FAIL net [build failed] FAIL os [build failed] FAIL os/exec [build failed] FAIL encoding/gob [build failed] FAIL </pre>

It appears that race_linux_amd64.syso now has a dependency on glibc 2.16, whereas previous versions were built against glibc 2.12. This does not appear to be documented anywhere.

I do not have access to a system with the requisite LLVM dependencies to build a new race_linux_amd64.syso, but it would be great if that new dependency could be changed.

What did you expect to see?

A successful build

What did you see instead?

Failed self-tests

closed time in 3 days

Roguelazer

issue commentgolang/go

x/tools/gopls: no completion for function literal in parameter

Change https://golang.org/cl/246262 mentions this issue: internal/lsp/source: improve func literal completions

stamblerre

comment created time in 3 days

push eventgolang/go

Robert Griesemer

commit sha ead7e9b351a1cd336da7b22c1ceb16fa82ca04bd

[dev.go2go] cmd/compile/internal/syntax: add more parser tests Updated existing tests to more closely match the go/types tests; added *B.go2 versions for some tests, using [] for type parameters. Change-Id: Ie7cfd9f5515f541d9422a2b2ab8a5d3e02d0499a Reviewed-on: https://go-review.googlesource.com/c/go/+/246261 Run-TryBot: Robert Griesemer <gri@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Robert Griesemer <gri@golang.org>

view details

push time in 3 days

push eventgolang/go

Robert Griesemer

commit sha c77c3236b1d64e99db05059c2a7eed8a8623e3fd

[dev.go2go] cmd/compile/internal/types2: remove most token.Token dependencies The remaining uses of token.Token are needed for the go/constant API. Change-Id: I5dc8be1fae16217433da1acb5606fd1d7b8eea54 Reviewed-on: https://go-review.googlesource.com/c/go/+/246257 Reviewed-by: Robert Griesemer <gri@golang.org>

view details

Robert Griesemer

commit sha 417abfbaf15b0b8679807c1e5e18cf15cc468f93

[dev.go2go] cmd/compile/internal/syntax: accept [] for type parameter lists Still missing: - embedded []-instantiated types in interfaces - *B.go2 tests which exist for go/types Change-Id: I3dd115fcd67f725144062c90550a91fcded1cbe2 Reviewed-on: https://go-review.googlesource.com/c/go/+/246259 Reviewed-by: Robert Griesemer <gri@golang.org>

view details

Robert Griesemer

commit sha d8b0f3b91f317e186b3bfb7453c64fd4ac9c5eac

[dev.go2go] go/parser: p.T(P) is a valid instantiated parameter type (fix bug) The existing code didn't accept an instantiated imported (qualified) type as type for a regular function parameter. Also: Simplified logic around use of typeContext flag when []'s are used for type parameters. Change-Id: Ic6c60e943344a976f5b8546c8a378ebd32a82d90 Reviewed-on: https://go-review.googlesource.com/c/go/+/246260 Run-TryBot: Robert Griesemer <gri@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Robert Griesemer <gri@golang.org>

view details

push time in 3 days

push eventgolang/go

Toshihiro Shiino

commit sha 10523c0efb908ab0ff4872a2e9e91b314d3d46ed

doc/go1.15: fix a few trivial inconsistencies For #37419 Change-Id: I8ede539df5d5344aeb44ba1a7e2383363d92157f Reviewed-on: https://go-review.googlesource.com/c/go/+/245977 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>

view details

push time in 3 days

issue commentgolang/go

x/build/cmd/relui: create proof of concept for release automation

Change https://golang.org/cl/246298 mentions this issue: cmd/relui: add persistence to development database

toothrot

comment created time in 4 days

issue commentgolang/vscode-go

gopls: append completions not being shown

Change https://golang.org/cl/246297 mentions this issue: src/goLanguageServer.ts: handle missing filterText in completion items

stamblerre

comment created time in 4 days

push eventgolang/go

Cherry Zhang

commit sha 847b9be3f62c7c93d3faf34577675e97176f6f7d

[dev.link] cmd/link: make symbol attribute setting more reliable For dupOK symbols, their attributes should be OR'd. Most of the attributes are expected to be set consistently across multiple definitions, but UsedInIface must be OR'd, and for alignment we need to pick the largest one. Currently the attributes are not always OR'd, depending on addSym returning true or false. This doesn't cause any real problem, but it would be a problem if we make type descriptor symbols content-addressable. This CL removes the second result of addSym, and lets preloadSyms always set the attributes. Also removes the alignment handling on addSym, handles it in preloadSyms only. Change-Id: I06b3f0adb733f6681956ea9ef54736baa86ae7bc Reviewed-on: https://go-review.googlesource.com/c/go/+/245720 Reviewed-by: Jeremy Faller <jeremy@golang.org>

view details

push time in 4 days

issue commentgolang/go

runtime/race: race_linux_amd64.syso now depends on glibc 2.16

Change https://golang.org/cl/246258 mentions this issue: runtime/race: rebuild some .syso files to remove getauxval dependency

Roguelazer

comment created time in 4 days

push eventgolang/go

Ian Lance Taylor

commit sha 9591515f515a76f627bc1cfc6d71f98f43526faf

runtime, sync: add copyright headers to new files For #38029 Change-Id: I71de2b66c1de617d32c46d4f2c1866f9ff1756ec Reviewed-on: https://go-review.googlesource.com/c/go/+/244631 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Dan Scales <danscales@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>

view details

Ian Lance Taylor

commit sha 8696ae82c94f0a7707cbbbdf2cec44e93edf5b23

syscall: use correct file descriptor in dup2 fallback path This fixes a mistake in CL 220422. This changes code that is only executed on Linux kernel versions earlier than 2.6.27. Change-Id: I01280184f4d7b75e06387c38f1891e8f0a81f793 Reviewed-on: https://go-review.googlesource.com/c/go/+/244630 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>

view details

Cherry Zhang

commit sha 19a932ceb8dc0059754e1f986c86daba3a4fb14e

cmd/link: don't mark shared library symbols reachable unconditionally During the transitioning period, we mark symbols from Go shared libraries reachable unconditionally. That might be useful when there was still a large portion of the linker using sym.Symbols, and only reachable symbols were converted to sym.Symbols. Marking them reachable brings them to the dynamic symbol table, even if they are not needed, increased the binary size unexpectedly. That time has passed. Now we largely operate on loader symbols, and it is not needed to mark them reachable anymore. Fixes #40416. Change-Id: I1e2bdb93a960ba7dc96575fabe15af93d8e95329 Reviewed-on: https://go-review.googlesource.com/c/go/+/244839 Run-TryBot: Cherry Zhang <cherryyz@google.com> Reviewed-by: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>

view details

Keith Randall

commit sha c4fed25553ee266ed9cb3a98e7a33a82af110ed4

cmd/compile: add floating point load+op operations to addressing modes pass They were missed as part of the refactoring to use a separate addressing modes pass. Fixes #40426 Change-Id: Ie0418b2fac4ba1ffe720644ac918f6d728d5e420 Reviewed-on: https://go-review.googlesource.com/c/go/+/244859 Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>

view details

Michael Pratt

commit sha 85afa2eb190d5d1a06584803bde4b4ee9b0e79b0

runtime: ensure startm new M is consistently visible to checkdead If no M is available, startm first grabs an idle P, then drops sched.lock and calls newm to start a new M to run than P. Unfortunately, that leaves a window in which a G (e.g., returning from a syscall) may find no idle P, add to the global runq, and then in stopm discover that there are no running M's, a condition that should be impossible with runnable G's. To avoid this condition, we pre-allocate the new M ID in startm before dropping sched.lock. This ensures that checkdead will see the M as running, and since that new M must eventually run the scheduler, it will handle any pending work as necessary. Outside of startm, most other calls to newm/allocm don't have a P at all. The only exception is startTheWorldWithSema, which always has an M if there is 1 P (i.e., the currently running M), and if there is >1 P the findrunnable spinning dance ensures the problem never occurs. This has been tested with strategically placed sleeps in the runtime to help induce the correct race ordering, but the timing on this is too narrow for a test that can be checked in. Fixes #40368 Change-Id: If5e0293a430cc85154b7ed55bc6dadf9b340abe2 Reviewed-on: https://go-review.googlesource.com/c/go/+/245018 Run-TryBot: Michael Pratt <mpratt@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Austin Clements <austin@google.com>

view details

Michael Anthony Knyszek

commit sha 6b4dcf19fa493905689dedc27f2232b74c366057

runtime: hold sched.lock over globrunqputbatch in runqputbatch globrunqputbatch should never be called without sched.lock held. runqputbatch's documentation even says it may acquire sched.lock in order to call it. Fixes #40457. Change-Id: I5421b64f1da3a6087dfebbef7203db0c95d213a8 Reviewed-on: https://go-review.googlesource.com/c/go/+/245377 Run-TryBot: Michael Knyszek <mknyszek@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Michael Pratt <mpratt@google.com> Reviewed-by: Cherry Zhang <cherryyz@google.com> Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

Michael Munday

commit sha 54e75e8f9db09868db61f97edb98ace3aab7234f

crypto/ed25519: remove s390x KDSA implementation This reverts CL 202578 and CL 230677 which added an optimization to use KDSA when available on s390x. Inconsistencies have been found between the two implementations in their handling of certain edge cases. Since the Go 1.15 release is extremely soon it seems prudent to remove this optimization for now and revisit it in a future release. Fixes #40475. Change-Id: Ifb2ed9b9e573784df57383671f1c29d8abae90d4 Reviewed-on: https://go-review.googlesource.com/c/go/+/245497 Run-TryBot: Michael Munday <mike.munday@ibm.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ruixin(Peter) Bao <ruixin.bao@ibm.com> Reviewed-by: Filippo Valsorda <filippo@golang.org>

view details

Cholerae Hu

commit sha 7f8608047644ca34bad1728d5e2dbef041a1b3f2

cmd/compile: don't addLocalInductiveFacts if there is no direct edge from if block to phi block Currently in addLocalInductiveFacts, we only check whether direct edge from if block to phi block exists. If not, the following logic will treat the phi block as the first successor, which is wrong. This patch makes prove pass more conservative, so we disable some cases in test/prove.go. We will do some optimization in the following CL and enable these cases then. Fixes #40367. Change-Id: I27cf0248f3a82312a6f7dabe11c79a1a34cf5412 Reviewed-on: https://go-review.googlesource.com/c/go/+/244579 Reviewed-by: Zach Jones <zachj1@gmail.com> Reviewed-by: Keith Randall <khr@golang.org> Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>

view details

Katie Hockman

commit sha 10374e2435687a27ac99b2a19284f1aa0c7dc338

testing: fix quotation marks Change-Id: I4b816e26718ef5521afba2b200a6333373b09c58 Reviewed-on: https://go-review.googlesource.com/c/go/+/245136 Run-TryBot: Katie Hockman <katie@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

Michael Anthony Knyszek

commit sha b56791cdea5caa87ffcd585d29c294bd3d08a06a

runtime: validate candidate searchAddr in pageAlloc.find Currently pageAlloc.find attempts to find a better estimate for the first free page in the heap, even if the space its looking for isn't necessarily going to be the first free page in the heap (e.g. if npages >= 2). However, in doing so it has the potential to return a searchAddr candidate that doesn't actually correspond to mapped memory, but this candidate might still be adopted. As a result, pageAlloc.alloc's fast path may look at unmapped summary memory and segfault. This case is rare on most operating systems since the heap is kept fairly contiguous, so the chance that the candidate searchAddr discovered is unmapped is fairly low. Even so, this is totally possible and outside the user's control when it happens (in fact, it's likely to happen consistently for a given user on a given system). Fix this problem by ensuring that our candidate always points to mapped memory. We do this by looking at mheap's arenas structure first. If it turns out our candidate doesn't correspond to mapped memory, then we look at inUse to round up the searchAddr to the next mapped address. While we're here, clean up some documentation related to searchAddr. Fixes #40191. Change-Id: I759efec78987e4a8fde466ae45aabbaa3d9d4214 Reviewed-on: https://go-review.googlesource.com/c/go/+/242680 Run-TryBot: Michael Knyszek <mknyszek@google.com> Reviewed-by: Austin Clements <austin@google.com> Reviewed-by: Michael Pratt <mpratt@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>

view details

Matthew Dempsky

commit sha 7388956b76ce15a11346cebefcf6193db044caaf

cmd/cgo: fix mangling of enum and union types Consider this test package: package p // enum E { E0 }; // union U { long x; }; // void f(enum E e, union U* up) {} import "C" func f() { C.f(C.enum_E(C.E0), (*C.union_U)(nil)) } In Go 1.14, cgo translated this to (omitting irrelevant details): type _Ctype_union_U [8]byte func f() { _Cfunc_f(uint32(_Ciconst_E0), (*[8]byte)(nil)) } func _Cfunc_f(p0 uint32, p1 *[8]byte) (r1 _Ctype_void) { ... } Notably, _Ctype_union_U was declared as a defined type, but uses were being rewritten into uses of the underlying type, which matched how _Cfunc_f was declared. After CL 230037, cgo started consistently rewriting "C.foo" type expressions as "_Ctype_foo", which caused it to start emitting: type _Ctype_enum_E uint32 type _Ctype_union_U [8]byte func f() { _Cfunc_f(_Ctype_enum_E(_Ciconst_E0), (*_Ctype_union_U)(nil)) } // _Cfunc_f unchanged Of course, this fails to type-check because _Ctype_enum_E and _Ctype_union_U are defined types. This CL changes cgo to emit: type _Ctype_enum_E = uint32 type _Ctype_union_U = [8]byte // f unchanged since CL 230037 // _Cfunc_f still unchanged It would probably be better to fix this in (*typeConv).loadType so that cgo generated code uses the _Ctype_foo aliases too. But as it wouldn't have any effect on actual compilation, it's not worth the risk of touching it at this point in the release cycle. Updates #39537. Fixes #40494. Change-Id: I88269660b40aeda80a9a9433777601a781b48ac0 Reviewed-on: https://go-review.googlesource.com/c/go/+/246057 Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

Cherry Zhang

commit sha c4ee16eda9734503a48d614e445b5d18ea94eb04

[dev.link] all: merge branch 'master' into dev.link Clean merge. Change-Id: If78d97b9ac69511e4de7aa9532257d4fabebdcbc

view details

push time in 4 days

issue commentgolang/go

runtime: revert Linux signal stack mlock workaround

Change https://golang.org/cl/246200 mentions this issue: runtime: revert signal stack mlocking

aclements

comment created time in 4 days

issue commentgolang/go

runtime: remove the mlock hack in Go 1.15

Change https://golang.org/cl/246200 mentions this issue: runtime: revert signal stack mlocking

DanielShaulov

comment created time in 4 days

issue commentgolang/go

runtime: memory corruption on Linux 5.2+

Change https://golang.org/cl/246200 mentions this issue: runtime: revert signal stack mlocking

aclements

comment created time in 4 days

issue commentgolang/go

runtime: corrupt binary export data seen after signal preemption CL

Change https://golang.org/cl/246200 mentions this issue: runtime: revert signal stack mlocking

mvdan

comment created time in 4 days

issue commentgolang/go

runtime: mlock of signal stack failed: 12

Change https://golang.org/cl/246200 mentions this issue: runtime: revert signal stack mlocking

karalabe

comment created time in 4 days

push eventgolang/proposal

Katie Hockman

commit sha 572fea69936c3f25a99860fce22aeb23a3263ca3

design/draft-fuzzing.md: update f.Fuzz to include testing.T This change also adds a `-fuzztime` flag for `go test`, and an open issue for custom generators. Change-Id: Ifef7e56e10cb5b3e1ff71e952c47f18fc0747114 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/245117 Reviewed-by: Katie Hockman <katie@golang.org>

view details

push time in 4 days

more