profile
viewpoint

google/accompanist 4022

A collection of extension libraries for Jetpack Compose

google/addlicense 441

A program which ensures source code files have copyright license headers by scanning directory patterns recursively

google/adiantum 431

Adiantum and HPolyC specification and test vectors

google/acme 376

A simple ACME command line tool without 3rd party deps!

google/access-bridge-explorer 89

Explore accessibility tree of Java Access Bridge enabled applications

issue commentgoogle/site-kit-wp

Implement new Idea Hub prompt banner and widget notification

@felixarntz – thoughts about @asvinb 's comment here? Can we maybe change the IH widget to not match the height of the adjacent widget?

felixarntz

comment created time in a few seconds

fork ltrgoddard/earthengine-api

Python and JavaScript bindings for calling the Earth Engine API.

fork in a few seconds

issue openedgoogle/diff-match-patch

Request for code review

Hi,

I yesterday ran into a problem that my diff implementation (adopted from the internet) in some cases actually doesn't work reliably.

Suppose I have a bit stream of zeros and ones, called simply "mine" (99658 bits) and "theirs" (99655 bits). These represent low-level magnetic information of two full revolutions of one and the same track on a 2DD floppy (nominally 100,000 bits).

Apart from being of different lengths (theirs being by three bits shorter than mine), there is also a difference in the middle - 34,425-th bit is different, thanks to magnetic deterioration. Otherwise, the two bit streams are identical.

image

image

image

My implementation of the diff algorithm produces the following script that transforms mine into theirs (unlike the numbering in OpenOffice Calc, the numbering of bits is zero-based, hence off by 1). The first two seem to successfully deal with the difference in the middle. The latter two fail to remove the tail three extra bits in mine.

  • insertion of 1 bit from theirs at 34424 into mine at 34424,
  • deletion of 1 bit from mine at 34424,
  • deletion of 1 bit from mine at 99646,
  • deletion of 1 bit from mine at 99650.

Because I've exhausted all my skills, I would like to ask if anyone could check my implementation of the diff algorithm and eventually fix the bug that's inside. Although I read Mr.Myers's paper "An O(ND) Difference Algorithm and its Variations," I'm not much more clever than before. The diff algorithm is implemented here (circa 100 lines of actual code): https://github.com/tomas-nestorovic/RIDE/blob/master/Main/src/Diff.h

MANY THANKS IN ADVANCE FOR ANY RESPONSES! :-)

created time in a few seconds

pull request commentgoogle/site-kit-wp

Add new format to BannerNotification

@asvinb would you please address the merge conflicts? Apologies for the delay here.

Also, any idea why there is such an increase in the bundles shown above? Several of them are showing +50kB which I wouldn't expect here.

asvinb

comment created time in 2 minutes

issue commentgoogle/docsy

Error Generating site when using Docsy as a module

With github submodules I have the same problem that I'll get problems with rendering, the sidebar shows a navbar from a different part of the website (blog?) that I am on, the main page is not rendering at all (apart from header) and some other pages (eg. the blog) are also not rendering. I have the same setup with the language folder

ITblacksheep

comment created time in 3 minutes

startedgoogle/go-github

started time in 4 minutes

startedgoogle/tree-math

started time in 6 minutes

startedgoogle/flax

started time in 6 minutes

startedgoogle/zx

started time in 6 minutes

startedgoogle/flexbox-layout

started time in 6 minutes

fork zhouxiaomao/gopacket

Provides packet processing capabilities for Go

fork in 7 minutes

push eventgoogle/or-tools

Corentin Le Molgat

commit sha 0ba757d7b368dc3bb232ee62e6e188a188183856

use filelineiter from ortools/util

view details

Corentin Le Molgat

commit sha 3cc01f2a2964b4c03907f9cf0cb67e1372f43b83

fixup export sync

view details

Corentin Le Molgat

commit sha d0a38f7ab920e3a69c2216334202dc08f76d2bd1

sync glop

view details

Corentin Le Molgat

commit sha d5f19bc4fd593ed88a2c79aa7cb56fccb9404e83

sync lp_data

view details

Corentin Le Molgat

commit sha 8e2887bc68aeda33a5ae7086d79502d0d87ee40c

sync math_opt

view details

push time in 8 minutes

PullRequestReviewEvent

issue commentgoogle/cadvisor

'Race condition' and 'failed to fetch hugetlb info' errors in Raspbian

Seeing the same on RaspberryPi3.

eruizc-dev

comment created time in 8 minutes

Pull request review commentgoogle/web-stories-wp

Allow completely disabling/hiding default templates

 function PageTemplatesPane(props) {     setNextTemplatesToFetch,   ]); -  const handleToggle = () => {-    setShowDefaultTemplates(!showDefaultTemplates);-    localStore.setItemByKey(LOCAL_STORAGE_KEY, !showDefaultTemplates);+  const handleToggle = (event, menuItem) => {+    const value = menuItem === 'default';

Since it's not really a toggle, might be good to rename it just for readability, e.g. handleSelect. WDYT?

spacedmonkey

comment created time in 22 minutes

Pull request review commentgoogle/web-stories-wp

Allow completely disabling/hiding default templates

 function PageTemplatesPane(props) {     setNextTemplatesToFetch,   ]); -  const handleToggle = () => {-    setShowDefaultTemplates(!showDefaultTemplates);-    localStore.setItemByKey(LOCAL_STORAGE_KEY, !showDefaultTemplates);+  const handleToggle = (event, menuItem) => {+    const value = menuItem === 'default';
    const value = menuItem === DEFAULT;
spacedmonkey

comment created time in 25 minutes

Pull request review commentgoogle/web-stories-wp

Allow completely disabling/hiding default templates

 function LeftRail() {                       numNewTemplates                     )                   : label;++              const isTemplatesEnabled =

Should this be renamed to isTemplatesDisabled? Also, could this be moved to the line right after {PRIMARY_PATHS.map(({ Icon, ...path }) => { to return null as soon as possible?

spacedmonkey

comment created time in 10 minutes

PullRequestReviewEvent
PullRequestReviewEvent

issue commentgoogle/site-kit-wp

Modify REST permission checks for some endpoints to be available to shared dashboard viewers

@aaemnnosttv My thinking was basically that for now VIEW_POSTS_INSIGHTS would follow the same logic that VIEW_DASHBOARD would use. Which technically would mean we can just scratch that capability entirely, but I think it makes sense to have a distinct capability for viewing Site Kit data "in general", e.g. in other areas than the dashboard. The requirements for that could also be different at some point.

aaemnnosttv

comment created time in 8 minutes

startedgoogle/go-cloud

started time in 9 minutes

fork alexseres/googletest

GoogleTest - Google Testing and Mocking Framework

https://google.github.io/googletest/

fork in 9 minutes

Pull request review commentgoogle/iree-llvm-sandbox

Fix build/test failures around WalkStage

+set(LLVM_OPTIONAL_SOURCES

You can add PARTIAL_SOURCES_INTENDED to add_mlir_library and avoid listing all files here (or, better, have one library per directory).

matthias-springer

comment created time in 10 minutes

Pull request review commentgoogle/iree-llvm-sandbox

Fix build/test failures around WalkStage

 LogicalResult mlir::vector_ext::maskVectorPredicateOps(   SmallVector<Value, 8> activeMasks;   activeMasks.push_back(Value()); -  genericWalk(op, [&](Operation *op, const WalkStage &stage) {+  // Gather ops for deletion after the walk.+  SmallVector<Operation *> erasedOps;++  op->walk([&](Operation *op, const WalkStage &stage) {     if (auto predOp = dyn_cast<PredicateOp>(op))-      maskPredicateOp(builder, predOp, activeMasks, stage);+      maskPredicateOp(builder, predOp, activeMasks, stage, erasedOps);     else-      maskGenericOp(builder, op, activeMasks.back(), stage);+      maskGenericOp(builder, op, activeMasks.back(), stage, erasedOps);   }); +  // Erase ops.+  for (Operation *op : erasedOps)+    op->erase();+   return success(); }  /// Masking strategy that only masks vector transfer operations and operations /// with side effects. Non-side-effecting ops are left unmasked. void mlir::vector_ext::maskGenericOpWithSideEffects(     OpBuilder &builder, Operation *op, Value activeMask,-    const WalkStage &stage) {+    const WalkStage &stage, SmallVector<Operation *> &erasedOps) {

SmallVectorImpl, no need to tie a specific size

matthias-springer

comment created time in 10 minutes

PullRequestReviewEvent
PullRequestReviewEvent

PR opened google/it-cert-automation-practice

Username can't start with . or _

Closes: #1 Updated validations.py python script. Fixed the behavior of validate_user function in validations.py.

Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

  • [ ] Tests pass
  • [ ] Appropriate changes to README are included in PR
+6 -1

0 comment

1 changed file

pr created time in 11 minutes

startedgoogle/skywater-pdk

started time in 12 minutes

created taggoogle/iree

tagcandidate-20220118.21

👻

created time in 12 minutes

more