profile
viewpoint
Geoffry Song goffrie Dropbox San Francisco

dropbox/fast_rsync 355

An optimized implementation of librsync in pure Rust.

goffrie/lalr 3

CFGs to LALR(1) parse tables

goffrie/gnarly 1

gnarly is not a roguelike (yet).

goffrie/grapher 1

2D/3D expression plotter

goffrie/arc-swap 0

Support atomic operations on Arc itself

goffrie/bytes 0

Utilities for working with bytes

goffrie/cargo 0

The Rust package manager

goffrie/cfg-if 0

A if/elif-like macro for Rust #[cfg] statements

goffrie/coffee-source-map 0

Implementation of v3 sourcemaps in coffee-script.

Pull request review commentdropbox/pb-jelly

Fix an issue with err_if_default_or_unknown codegen.

 impl ::pb_jelly::Message for TestMessage3ErrIfDefaultEnumOneof {         }       }     }-    match something {-      Some(v) => self.something = v,-      None => return Err(::std::io::Error::new(::std::io::ErrorKind::InvalidInput, "err_if_default_or_unknown 'something' had no value while parsing message pbtest.TestMessage3ErrIfDefaultEnumOneof")),-    }     Ok(())

This illustrates the fix. It is very finicky, since observing the bug relies on having random leaked values from the field ordering.

goffrie

comment created time in 4 days

PullRequestReviewEvent

push eventdropbox/pb-jelly

Geoffry Song

commit sha df97a5a75fb3b632991f631b0b9559369950de1f

Add a regression test.

view details

Geoffry Song

commit sha f7a49d049e62135d27ce19d4da5d248ff1ff35d7

Fix an issue with err_if_default_or_unknown codegen.

view details

push time in 4 days

pull request commentdropbox/pb-jelly

Fix an issue with err_if_default_or_unknown codegen.

I can't run the tests in this repo at all so I can't write a regression test, but I don't think one would be helpful anyway as the bug has a very particular shape that I wouldn't expect to resurface.

goffrie

comment created time in 4 days

PR opened dropbox/pb-jelly

Fix an issue with err_if_default_or_unknown codegen.

typ was being used before being calculated, so it was reading the type of some random other field.

+1 -1

0 comment

1 changed file

pr created time in 4 days

create barnchdropbox/pb-jelly

branch : err_if_default_or_unknown

created branch time in 4 days

release dropbox/fast_rsync

v0.1.3

released time in 6 days

created tagdropbox/fast_rsync

tagv0.1.3

An optimized implementation of librsync in pure Rust.

created time in 6 days

push eventdropbox/fast_rsync

Geoffry Song

commit sha e7b16376be5b891ecca6d44bd1f02ec2b3b20273

(cargo-release) version 0.1.3

view details

Geoffry Song

commit sha 63004bd11d4d30981229811210bd005332b60d89

(cargo-release) start next development iteration 0.1.4-alpha.0

view details

push time in 6 days

delete branch dropbox/fast_rsync

delete branch : simd

delete time in 6 days

push eventdropbox/fast_rsync

Geoffry Song

commit sha a41349ffe7c8a34177d6c63e532b321bc6332f48

Update to packed_simd 0.3.4.

view details

push time in 6 days

PR merged dropbox/fast_rsync

Update to packed_simd 0.3.4.
+13 -6

0 comment

3 changed files

goffrie

pr closed time in 6 days

PR opened dropbox/fast_rsync

Update to packed_simd 0.3.4.
+13 -6

0 comment

3 changed files

pr created time in 6 days

create barnchdropbox/fast_rsync

branch : simd

created branch time in 6 days

startedantoyo/rustc_codegen_gcc

started time in 15 days

startedruma/ruma

started time in 15 days

startedrust-lang/rustfix

started time in 15 days

startedubnt-intrepid/polyfuse

started time in 15 days

startedmaidsafe/crdt_tree

started time in 15 days

PR opened tokio-rs/loom

Fix module comment for lazy_static

Looks like a copy/paste error.

+1 -1

0 comment

1 changed file

pr created time in 15 days

push eventgoffrie/loom

Geoffry Song

commit sha b5d26ff3370417d838f74c2d5b638e734e43daf6

Fix module comment for lazy_static Looks like a copy/paste error.

view details

push time in 15 days

fork goffrie/loom

Concurrency permutation testing tool for Rust.

fork in 15 days

issue commentrust-analyzer/rust-analyzer

Panic in ast_transform

I can reproduce with:

trait Test {
    fn foo(&self, x: crate) {}
}
impl Test for () {
    <|>
}

and then selecting the "Implement default members" assist.

matklad

comment created time in 22 days

pull request commentsigp/lighthouse

Wallet creation: Make mnemonic length configurable, default to 24 words.

Signed :)

goffrie

comment created time in 24 days

push eventgoffrie/lighthouse

Geoffry Song

commit sha 771adc1f450e289cfe8ea716236b6c416e0cebd5

Wallet creation: Make mnemonic length configurable, default to 24 words. `lighthouse account_manager wallet create` now generates a 24-word mnemonic. The user can override this by passing `--mnemonic-length 12` (or another legal bip39 length).

view details

push time in 24 days

PR opened sigp/lighthouse

Wallet creation: Make mnemonic length configurable, default to 24 words.

Issue Addressed

Fixes #1665.

Proposed Changes

lighthouse account_manager wallet create now generates a 24-word mnemonic. The user can override this by passing --mnemonic-length 12 (or another legal bip39 length).

Additional Info

CLI --help:

        --mnemonic-length <MNEMONIC_LENGTH>       The number of words to use for the mnemonic phrase. [default: 24]

In case of an invalid argument:

% lighthouse account_manager wallet create --mnemonic-length 25
error: Invalid value for '--mnemonic-length <MNEMONIC_LENGTH>': Mnemonic length must be one of 12, 15, 18, 21, 24
+40 -12

0 comment

4 changed files

pr created time in 24 days

create barnchgoffrie/lighthouse

branch : mnemonic-length

created branch time in 24 days

fork goffrie/lighthouse

Rust Ethereum 2.0 Client

fork in 24 days

push eventgoffrie/rust-gurobi

Geoffry Song

commit sha e88f77cb6bd609a21d298a85c2581a9770ca981e

cargo fix

view details

Geoffry Song

commit sha 8e834f40693ddbb7af31f33ce99f3bdc3d2d03fb

Fix inlines

view details

Geoffry Song

commit sha 90fa04fb934622b42adad16b65230fcc9ae910d1

s/Inconsitent/Inconsistent/

view details

push time in a month

push eventgoffrie/rust-gurobi

Geoffry Song

commit sha b7ba0176e58f6fdd9d4b600ba3e8f34ce50352df

Add VarType::SemiCont and SemiInt.

view details

Geoffry Song

commit sha 016422a7fb02ff36457fff8dfef1b570e2530fb2

Fix clippy #[allow]s.

view details

push time in a month

fork goffrie/rust-gurobi

Unofficial Rust API for Gurobi Optimizer

https://crates.io/crates/gurobi

fork in a month

release dropbox/fast_rsync

v0.1.2

released time in a month

created tagdropbox/fast_rsync

tagv0.1.2

An optimized implementation of librsync in pure Rust.

created time in a month

push eventdropbox/fast_rsync

Geoffry Song

commit sha 46e14d9259ff5c32a85b2f046d14b569066f096d

(cargo-release) version 0.1.2

view details

Geoffry Song

commit sha a97af0172a64ec4b5960c658765fbb0446c75afe

(cargo-release) start next development iteration 0.1.3-alpha.0

view details

push time in a month

push eventdropbox/fast_rsync

Geoffry Song

commit sha 447fe65d16cababe3473196850ccdbfd482b278f

Update Cargo.lock

view details

push time in a month

delete branch dropbox/fast_rsync

delete branch : aarch64

delete time in a month

push eventdropbox/fast_rsync

Geoffry Song

commit sha da8e9bb5f1e725102f5e9eddf828c07802c75fa0

Update librsync pin to support aarch64-apple-darwin

view details

push time in a month

create barnchdropbox/fast_rsync

branch : aarch64

created branch time in a month

push eventgoffrie/librsync-rs

Geoffry Song

commit sha 56e7646d133c3174656b66c61f6259d6154a8873

Update to include https://github.com/mbrt/librsync/pull/1

view details

push time in a month

push eventgoffrie/librsync-rs

Michele Bertasi

commit sha 09c9cd438e49a38f0be25cb5cc4ea17c7bb8b7d8

Formatting.

view details

Michele Bertasi

commit sha 180b815b0ea955ec94869808c1bbb7b09a6ca27c

Upgrade to rust 2018.

view details

Michele Bertasi

commit sha 67df1f5b1bef8516b945a8f3ddb6725c84c25922

Upgrade librsync-sys.

view details

dependabot-preview[bot]

commit sha 8bf5b8dcdf4f52368ac69649a240bc3a36a5e390

Update log requirement from 0.3 to 0.4 Updates the requirements on [log](https://github.com/rust-lang/log) to permit the latest version. - [Release notes](https://github.com/rust-lang/log/releases) - [Changelog](https://github.com/rust-lang/log/blob/master/CHANGELOG.md) - [Commits](https://github.com/rust-lang/log/compare/env_logger-0.3.3...0.4.8) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Michele Bertasi

commit sha f200eb263b58af6025df76fabbed4e543d77542f

Upgrade logger.

view details

dependabot-preview[bot]

commit sha 148ef3b39139d1016c4beb587b0643acd466a948

Bump libc from 0.2.4 to 0.2.68 in /librsync-sys Bumps [libc](https://github.com/rust-lang/libc) from 0.2.4 to 0.2.68. - [Release notes](https://github.com/rust-lang/libc/releases) - [Commits](https://github.com/rust-lang/libc/compare/0.2.4...0.2.68) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Michele Bertasi

commit sha c3dd5f260e035ffdd5926c9a4b354f6c6ad71e07

Drop Appveyor. It's a pain to maintain and nobody needs it.

view details

Geoffry Song

commit sha 390bb760b54c2afe4b7d576e7b802ad89ba8b71a

Merge remote-tracking branch 'origin/master' into master

view details

push time in a month

delete branch dropbox/fast_rsync

delete branch : not-simd

delete time in a month

push eventdropbox/fast_rsync

Geoffry Song

commit sha dbe6d917498091bed1454e8c36e30e00d4443755

Fall back to non-SIMD on non-x86 architectures.

view details

push time in a month

push eventdropbox/fast_rsync

Geoffry Song

commit sha 56ff8932092be7b4c97d02504889fd0d15c6ea40

Fall back to non-SIMD on non-x86 architectures.

view details

push time in a month

PR opened dropbox/fast_rsync

Fall back to non-SIMD on non-x86 architectures.
+138 -113

0 comment

3 changed files

pr created time in a month

create barnchdropbox/fast_rsync

branch : not-simd

created branch time in a month

issue closedNixOS/nixpkgs

discord: Frequent segmentation faults in libappindicator

Describe the bug Discord crashes intermittently (maybe every 30 minutes) for me. This is especially noticeable when in a voice room, but I think it happens independently of that.

To Reproduce Steps to reproduce the behavior:

  1. Leave Discord running for a long period of time.
  2. Observe that Discord segfaults.

Additional context Stack trace in libappindicator-gtk3:

(gdb) bt
#0  0x00007f09f8fa015b in status_icon_changes () from /nix/store/s20y6yrgbrr1p5h70ydwim8z1q9niizk-libappindicator-gtk3-12.10.0/lib/libappindicator3.so
#1  0x00007f0a1ad94ec2 in g_closure_invoke () from /nix/store/mazsps24z01540n3g01m8yf52wm6avkd-glib-2.64.4/lib/libgobject-2.0.so.0
#2  0x00007f0a1ada7dc4 in signal_emit_unlocked_R () from /nix/store/mazsps24z01540n3g01m8yf52wm6avkd-glib-2.64.4/lib/libgobject-2.0.so.0
#3  0x00007f0a1adb2fef in g_signal_emit_valist () from /nix/store/mazsps24z01540n3g01m8yf52wm6avkd-glib-2.64.4/lib/libgobject-2.0.so.0
#4  0x00007f0a1adb397f in g_signal_emit () from /nix/store/mazsps24z01540n3g01m8yf52wm6avkd-glib-2.64.4/lib/libgobject-2.0.so.0
#5  0x00007f09f8f9f1d6 in app_indicator_set_icon_full () from /nix/store/s20y6yrgbrr1p5h70ydwim8z1q9niizk-libappindicator-gtk3-12.10.0/lib/libappindicator3.so

The rest of the stack has no symbols at all.

This has also been reported at https://www.reddit.com/r/linuxquestions/comments/fprclz/discord_segmentation_fault/ with the workaround being to remove libappindicator.

The crashes only started recently, presumably when #91375 landed.

Notify maintainers @ldesgoui @MP2E @tadeokondrak @benley

Metadata

 - system: `"x86_64-linux"`
 - host os: `Linux 5.4.57, NixOS, 20.09pre237781.32b46dd897a (Nightingale)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.7`
 - channels(goffrie): `"home-manager, nixpkgs-20.09pre238508.729e7295cf7"`
 - channels(root): `"nixos-20.09pre237781.32b46dd897a"`
 - nixpkgs: `/home/goffrie/.nix-defexpr/channels/nixpkgs`

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

closed time in 2 months

goffrie

issue commentNixOS/nixpkgs

discord: Frequent segmentation faults in libappindicator

Yup, this is working for me now too. Thanks everyone!

goffrie

comment created time in 2 months

issue commentNixOS/nixpkgs

discord: Frequent segmentation faults in libappindicator

Sorry, I (mostly) don't use my NixOS machine on weekdays, so I'll find out tomorrow :)

On Fri., Aug. 28, 2020, 09:37 Jon, notifications@github.com wrote:

@goffrie https://github.com/goffrie does it work with the above command I gave?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NixOS/nixpkgs/issues/96063#issuecomment-682848350, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJO2TS263J6VSKPFPE4CCDSC7MN3ANCNFSM4QIQISGA .

goffrie

comment created time in 2 months

issue commentNixOS/nixpkgs

discord: Frequent segmentation faults in libappindicator

Nice, that worked for me (though I needed another patch to get things building).

goffrie

comment created time in 2 months

issue openedNixOS/nixpkgs

discord: Frequent segmentation faults in libappindicator

Describe the bug Discord crashes intermittently (maybe every 30 minutes) for me. This is especially noticeable when in a voice room, but I think it happens independently of that.

To Reproduce Steps to reproduce the behavior:

  1. Leave Discord running for a long period of time.
  2. Observe that Discord segfaults.

Additional context Stack trace in libappindicator-gtk3:

(gdb) bt
#0  0x00007f09f8fa015b in status_icon_changes () from /nix/store/s20y6yrgbrr1p5h70ydwim8z1q9niizk-libappindicator-gtk3-12.10.0/lib/libappindicator3.so
#1  0x00007f0a1ad94ec2 in g_closure_invoke () from /nix/store/mazsps24z01540n3g01m8yf52wm6avkd-glib-2.64.4/lib/libgobject-2.0.so.0
#2  0x00007f0a1ada7dc4 in signal_emit_unlocked_R () from /nix/store/mazsps24z01540n3g01m8yf52wm6avkd-glib-2.64.4/lib/libgobject-2.0.so.0
#3  0x00007f0a1adb2fef in g_signal_emit_valist () from /nix/store/mazsps24z01540n3g01m8yf52wm6avkd-glib-2.64.4/lib/libgobject-2.0.so.0
#4  0x00007f0a1adb397f in g_signal_emit () from /nix/store/mazsps24z01540n3g01m8yf52wm6avkd-glib-2.64.4/lib/libgobject-2.0.so.0
#5  0x00007f09f8f9f1d6 in app_indicator_set_icon_full () from /nix/store/s20y6yrgbrr1p5h70ydwim8z1q9niizk-libappindicator-gtk3-12.10.0/lib/libappindicator3.so

The rest of the stack has no symbols at all.

This has also been reported at https://www.reddit.com/r/linuxquestions/comments/fprclz/discord_segmentation_fault/ with the workaround being to remove libappindicator.

The crashes only started recently, presumably when #91375 landed.

Notify maintainers @ldesgoui @MP2E @tadeokondrak @benley

Metadata

 - system: `"x86_64-linux"`
 - host os: `Linux 5.4.57, NixOS, 20.09pre237781.32b46dd897a (Nightingale)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.7`
 - channels(goffrie): `"home-manager, nixpkgs-20.09pre238508.729e7295cf7"`
 - channels(root): `"nixos-20.09pre237781.32b46dd897a"`
 - nixpkgs: `/home/goffrie/.nix-defexpr/channels/nixpkgs`

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

created time in 2 months

issue commentrust-lang/rust

#[track_caller] functions don't track location when called from an inlined function

#72121 has landed and this indeed appears to be fixed:

     Created binary (application) `main` package
     Created library `lib` package
   Compiling lib v0.1.0 (/tmp/lib)
   Compiling main v0.1.0 (/tmp/main)
    Finished dev [unoptimized + debuginfo] target(s) in 0.33s
     Running `target/debug/main`
thread 'main' panicked at 'assertion failed: false', /tmp/lib/src/lib.rs:3:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Vlad-Shcherbina

comment created time in 2 months

fork goffrie/rust-memchr

An implementation of memchr in Rust, with optional libc bindings.

fork in 3 months

more