profile
viewpoint

goddenrich/concourse-phabricator-pr 2

Still in early development! Provides a phabricator pull request resource for concourse CI.

goddenrich/local-network-monitoring 2

Monitor your network and internet speed with Docker & Prometheus

goddenrich/vim-plz 2

a vim plugin for the please build system

goddenrich/concourse-tutorial 0

Learn to use https://concourse-ci.org with this linear sequence of tutorials. Learn each concept that builds on the previous concept.

goddenrich/git-resource 0

tracks commits in a branch of a Git repository

goddenrich/go-junit 0

🐜 Go library for ingesting JUnit XML reports with an io.Reader

issue commentthought-machine/please

VSCode integration with source jars

Cool, thanks @Tatskaari, that's a nice feature!

Anton-Rodionov

comment created time in 12 hours

Pull request review commentthought-machine/please

feat: better colour display with light colours schemes like Solarized Light

 <h3>[Display]</h3>       <li><b>SystemStats</b> (bool)<br/> 	Whether or not to show basic system resource usage in the interactive display.         Defaults to <code>False</code>.</li>++      <li><b>ColoursScheme</b> (bool)<br/>

nit: (bool) should be (string)

sfirmery

comment created time in 20 hours

Pull request review commentthought-machine/please

feat: better colour display with light colours schemes like Solarized Light

 type Configuration struct { 		GitFunctions     bool `help:"Activates built-in functions git_branch, git_commit, git_show and git_state. If disabled they will not be usable at parse time."` 	} `help:"The [parse] section in the config contains settings specific to parsing files."` 	Display struct {-		UpdateTitle bool `help:"Updates the title bar of the shell window Please is running in as the build progresses. This isn't on by default because not everyone's shell is configured to reset it again after and we don't want to alter it forever."`-		SystemStats bool `help:"Whether or not to show basic system resource usage in the interactive display. Has no effect without that configured."`-		MaxWorkers  int  `help:"Maximum number of worker rows to display at any one time."`+		UpdateTitle   bool   `help:"Updates the title bar of the shell window Please is running in as the build progresses. This isn't on by default because not everyone's shell is configured to reset it again after and we don't want to alter it forever."`+		SystemStats   bool   `help:"Whether or not to show basic system resource usage in the interactive display. Has no effect without that configured."`+		MaxWorkers    int    `help:"Maximum number of worker rows to display at any one time."`+		ColoursScheme string `help:"Shell colours scheme mode, dark or light. Defaults to dark"`

nit: ColourScheme

sfirmery

comment created time in 20 hours

issue commentthought-machine/please

Document releases

Hahah that post was such a flop :broken_heart:

Yeah actually that would be great! I'm thinking I also want a home for generic "blogs" where I doing feature write-ups. For example I'm currently working on redoing how we build Go code to better support modules. Jetbrains have a generic blog feed where they post their newslettersas well as this sort of writeup:

https://blog.jetbrains.com

I think I'm going to aim to do the same.

msiebuhr

comment created time in a day

issue openedthought-machine/please

Please does not preserve file modes

I have the following rule:

def folder_files(name, srcs, directory_name, mode = "644", visibility = None):
    genrule(
        name = name,
        srcs = srcs,
        output_dirs = ["_out"],
        cmd = [
            f"mkdir -p _out/{directory_name}",
            f"install -m {mode} $SRCS _out/{directory_name}",
        ],
        visibility = visibility,
    )

With mode = "0775" it produces files with the following modes:

-rwxr-xr-x 1 suhr users     90984 Nov 30 13:23 clusterdb
-rwxr-xr-x 1 suhr users     99712 Nov 30 13:23 createuser
-rwxr-xr-x 1 suhr users     90216 Nov 30 13:23 dropuser
-rwxr-xr-x 1 suhr users    163784 Nov 30 13:23 initdb

But the Please output produces files with this modes:

.r--r--r--  90k suhr 30 ноя 13:22 clusterdb
.r--r--r--  99k suhr 30 ноя 13:22 createuser
.r--r--r--  90k suhr 30 ноя 13:22 dropuser
.r--r--r-- 163k suhr 30 ноя 13:22 initdb

created time in a day

issue openedthought-machine/please

Document releases

I've been poking around with using please for a small-ish Go project, and ended up finding the release docs a quite useful source of information (ex. https://please.build/milestones/15.9.0.html). Yet I only found it through a lucky break with Hacker News.

It would be obvious to provide a link from, say https://github.com/thought-machine/please/releases/tag/v15.9.0 (which also has quite different release notes), but a "news" or "releases" section on https://please.build/ would also be nice.

created time in a day

issue closedthought-machine/please

Request failed trying to access 15.8.3-beta1 page

Whilst upgrading, experienced a timeout trying to access https://please.build/milestones/15.8.3-beta1.html Logs:

10:26:37.809 WARNING: Upgrading to Please version 15.8.3-beta1 (currently 15.6.0)
10:27:07.815   ERROR: request failed: [error Head "https://please.build/milestones/15.8.3-beta1.html": dial tcp 13.249.11.44:443: i/o timeout method HEAD url https://please.build/milestones/15.8.3-beta1.html]
10:27:38.816   ERROR: request failed: [error Head "https://please.build/milestones/15.8.3-beta1.html": dial tcp 13.249.11.129:443: i/o timeout method HEAD url https://please.build/milestones/15.8.3-beta1.html]

closed time in 2 days

jamesjarvis

issue commentthought-machine/please

Request failed trying to access 15.8.3-beta1 page

Looks as if it was intermittent, as I did not have any other issues than this one occurrence 👍

jamesjarvis

comment created time in 2 days

PR opened thought-machine/please

feat: better colour display with light colours schemes like Solarized Light

With light colours schemes like "Solarized Light", things displayed in white are not easily readable.

Add a Display.ColoursScheme config parameter. When set to light, white and grey colours are inverted in interactive display.

+22 -3

0 comment

3 changed files

pr created time in 3 days

push eventthought-machine/please

Peter Ebden

commit sha 94cbc86a9a65793c786b21cd7d1e65b03f27a4e6

Download files properly for plz test --shell (#1403)

view details

push time in 4 days

PR merged thought-machine/please

Download files properly for plz test --shell

Just doesn't work right now :(

+20 -10

0 comment

2 changed files

peterebden

pr closed time in 4 days

push eventthought-machine/please

Jonathan Poole

commit sha a105def0e44e2db748b000bd1723946a93134eab

Fix outputs check to use .Outputs() rather than the private field (#1404)

view details

push time in 4 days

issue closedthought-machine/please

lstat: no such file or directory

% plz build //src/bin:binaries
Build stopped after 13.13s. 1 target failed:
    //src/bin:binaries
lstat plz-out/gen/src/bin/initdb/initdb: no such file or directory

Additional info: //src/bin/initdb compiles and produces plz-out/gen/src/bin/initdb/initdb. And //src/bin:binaries is the following rule:

filegroup(
    name = "binaries",
    srcs = [
        "//src/bin/initdb",
        "//src/bin/pg_archivecleanup",
        "//src/bin/pg_basebackup:binaries",
        "//src/bin/pg_config",
        "//src/bin/pg_controldata",
        "//src/bin/pg_ctl",
        "//src/bin/pg_dump:binaries",
        "//src/bin/pg_resetwal",
        "//src/bin/pg_rewind",
        "//src/bin/pg_test_fsync",
        "//src/bin/pg_test_timing",
        "//src/bin/pg_waldump",
        "//src/bin/pgbench",
        "//src/bin/psql",
        "//src/bin/scripts",
    ],
    visibility = ["PUBLIC"],
)

Please version: 15.9.1

closed time in 4 days

suhr

PR opened thought-machine/please

Download files properly for plz test --shell

Just doesn't work right now :(

+20 -10

0 comment

2 changed files

pr created time in 4 days

created tagthought-machine/please

tagv15.9.2-beta.1

High-performance extensible build system for reproducible multi-language builds.

created time in 5 days

release thought-machine/please

v15.9.2-beta.1

released time in 5 days

push eventthought-machine/please

Peter Ebden

commit sha 050a716986e2d21f5af5b62e52d01872d3420ca5

Provide a more limited environment when building output links (#1401) * Provide a more limited environment when building output links * Pass correct var * Revert "Pass correct var" This reverts commit 42a8f9280124bec3457f5d119b3628403b15a2c5.

view details

push time in 5 days

PR merged thought-machine/please

Provide a more limited environment when building output links

BuildEnvironment requires locating tools, which might not necessarily be available locally. It seems like that should not be available in these links anyway - typically you just want variables like $PKG.

+7 -7

0 comment

3 changed files

peterebden

pr closed time in 5 days

push eventthought-machine/please

Peter Ebden

commit sha eb89055bc8292739554dda682d3fd70e62b67e1e

Limit downloading of packages for subinclude (#1402)

view details

push time in 5 days

PR merged thought-machine/please

Limit downloading of packages for subinclude

This is unnecessary - it is handled by WaitForBuiltTarget which ensures the proximate target is downloaded. We don't need to fetch every transitive target that needs to be built for a subinclude as well.

+1 -2

0 comment

1 changed file

peterebden

pr closed time in 5 days

PR opened thought-machine/please

Limit downloading of packages for subinclude

This is unnecessary - it is handled by WaitForBuiltTarget which ensures the proximate target is downloaded. We don't need to fetch every transitive target that needs to be built for a subinclude as well.

+1 -2

0 comment

1 changed file

pr created time in 5 days

PR opened thought-machine/please

Provide a more limited environment when building output links

BuildEnvironment requires locating tools, which might not necessarily be available locally. It seems like that should not be available in these links anyway - typically you just want variables like $PKG.

+7 -7

0 comment

3 changed files

pr created time in 6 days

push eventthought-machine/please

Peter Ebden

commit sha 8f737f06a70a83c60a458f611fbe45139ed6d5d2

Pre-set the empty blob into the "existing blobs" map (#1397) * Pre-set the empty blob into the "existing blobs" map * why oh why did emacs not gofmt this for me

view details

push time in 6 days

PR merged thought-machine/please

Pre-set the empty blob into the "existing blobs" map

Only makes a small difference but it's basically free; we can easily make 10-20 requests for the empty blob before we get a response telling us it exists, so might as well skip those.

+9 -6

0 comment

1 changed file

peterebden

pr closed time in 6 days

created tagthought-machine/please

tagv15.9.1

High-performance extensible build system for reproducible multi-language builds.

created time in 6 days

release thought-machine/please

v15.9.1

released time in 6 days

more