ggilmore ( Geoffrey Gilmore )

[x] Redact username and password from repository "Settings > Remote repository URL"
[x] Handle interactive password input: https://stackoverflow.com/questions/44471749/golang-enter-ssh-sudo-password-on-prompt-or-exit
[x] Tests

+278 -17

6 commit in sourcegraph/sourcegraph/tree/jc/perforce-sync-depot sourcegraph/sourcegraph/tree/main

3 comments

8 changed files

unknwon

pr closed time in an hour

pull request commentsourcegraph/sourcegraph

gitserver: able to clone and fetch Perforce depots

Thanks everyone, merging 🎉

unknwon

comment created time in an hour

PR opened sourcegraph/sourcegraph

search: refactor URL parsing to be done globally

Previously, we were doing parsing of the search URL (query, pattern type, etc) all over the place in lots of different components. The goal of this PR is to consolidate it to two places:

SourcegraphWebApp does the initial parsing and stores the parsed items in its state, which can be modified with setters passed onto child components
Layout handles updating the parsed items
- This must be done in a component other than SourcegraphWebApp since SourcegraphWebApp does not have access to the Location object coming from the router, and thus can't react to URL changes. Layout is the highest level componen within the router, so I though it would be best to put it there
- Feedback requested: I can alternatively put everything in Layout, or have a different way to handle this globally if anyone has a better suggestion.

This PR eliminates all uses of parseSearchURL, parseSearchURLQuery, parseSearchURLPatternType, parseSearchURLVersionContext and searchURLIsCaseSensitive with the following exceptions:

parseSearchURL is used in Layout and SourcegraphWebApp as the basis of this refactor
SearchResults and SearchResultsList were not modified, as this is legacy code that we intend to remove once streaming search is mature enough.
SearchConsolePage as not modified as this is still experimental code
A single use of parseSearchURLPatternType remains in settings.ts to handle default pattern type user setting
parseSearchURLQuery is used to parse user's search history for the RepositoriesPanel

+130 -94

2 commit in sourcegraph/sourcegraph/tree/jp/parserefactor sourcegraph/sourcegraph/tree/main

0 comment

10 changed files

pr created time in an hour

create barnchsourcegraph/sourcegraph

branch : jp/parserefactor

created branch time in an hour

pull request commentsourcegraph/sourcegraph

Add support for Gerrit code views

The next issue that I'm working on is fixing the handling of an apparent DOM difference when switching between unified and side-by-side diff views, and I think there also might be a DOM difference when syntax highlighting is turned off in the Gerrit diff settings. This affects the DOM functions that access a line's number and the diff part (head or base).

Here is a Gerrit change that is convenient for testing: https://gerrit.sgdev.org/c/src-cli/+/41

marekweb

comment created time in 2 hours

push eventsourcegraph/sourcegraph

Joel Kwartler

commit sha 18d6f79c5a099a3f186f55791c6bdff06fdb9404

copied patch from gitlab issue (#17587) Patching an issue with the new GitLab UI, with thanks to GitLab for the original patch

view details

push time in 2 hours

delete branch sourcegraph/sourcegraph

delete branch : gitlab-integration-patch

delete time in 2 hours

PR merged sourcegraph/sourcegraph

Copied patch from gitlab issue

See this for context and this for confirmation that this patch should solve the issue.

+3 -3

1 commit in sourcegraph/sourcegraph/tree/gitlab-integration-patch sourcegraph/sourcegraph/tree/main

1 comment

1 changed file

Joelkw

pr closed time in 2 hours

PR opened sourcegraph/about

Add link to design workflow from eng onboarding

@AlicjaSuska and I were chatting and thought we should add this to eng onboarding so all engineers are aware of how they can request or track design work.

I think it applies to more than just frontend engineers since we encourage all of our engineers to take active roles in surfacing design issues, and because someone may be working on the backend that's dependent on a frontend design or is requested to comment on a design and they need to know what "stage" the design is in. I think that this section is a good place to link from if we agree that we want to include this at the onboarding level.

+1 -0

1 commit in sourcegraph/about/tree/add-design-workflow-eng-onboarding sourcegraph/about/tree/main

0 comment

1 changed file

pr created time in 2 hours

create barnchsourcegraph/about

branch : add-design-workflow-eng-onboarding

created branch time in 2 hours

push eventsourcegraph/about

Joel Kwartler

commit sha e2b268c84cca30ea2efb996c5cb871df2aace4da

Add note about hiring to code insights org chart #2395 So it's clear on the org page as well (which pulls from this page). @felixfbecker I discussed with @jeanduplessis this week and we think it makes sense that as soon as we make our first full-time hire, we become a separate team (separate retro/standup etc) so I removed the sentence about the web team parenting us.

view details

push time in 2 hours

delete branch sourcegraph/about

delete branch : code-insights-org-tweak

delete time in 2 hours

PR merged sourcegraph/about

Add note about hiring to code insights org chart

So it's clear on the org page as well (which pulls from this page).

@felixfbecker I discussed with @jeanduplessis this week and we think it makes sense that as soon as we make our first full-time hire, we become a separate team (separate retro/standup etc) so I removed the sentence about the web team parenting us.

+1 -4

1 commit in sourcegraph/about/tree/code-insights-org-tweak sourcegraph/about/tree/main

1 comment

1 changed file

Joelkw

pr closed time in 2 hours

issue commentsourcegraph/sourcegraph

Show both "current monthly users" and "total users" in the admin UI

@AlicjaSuska I echo what Dan said – I think the word "monthly" might otherwise confuse more than clarify given that we bill based on max. (Also, if it's "monthly" then this have to reset every single month and start counting up to be truthful? The customer doesn't need that.) I didn't expect there to be too much and just wanted to get your confirmation on these changes – my apologies if the word "monthly" in my issue title added more confusion (I am also learning a bit about how we bill from what Dan posted).

So I think Z currently used / Y remaining (X maximum ever used) works fine given this, unless there's another reason @AlicjaSuska that isn't clear?

Joelkw

comment created time in 3 hours

push eventsourcegraph/deploy-sourcegraph-docker

Renovate Bot

commit sha f92e2292ed873a5303e353132eb7808fa16878cc

chore(deps): update github.com/sourcegraph/sourcegraph/enterprise/dev/ci/images commit hash to 5e15b04

view details

push time in 3 hours

push eventalumxi22/teptour

Kyle Miller

commit sha a26c03631a3f7c36b6cfcdd0a50a6f7293d70a0c

Squashed 'textadv-js/' changes from 93dc561..a971d9b a971d9b should check whether already open first when opening git-subtree-dir: textadv-js git-subtree-split: a971d9b48a9f6b30355392ee0baf82fed6c552f1

view details

Kyle Miller

commit sha 8ceac18e69213e45574b0e6b06ba474fccfb5f4b

Merge commit 'a26c03631a3f7c36b6cfcdd0a50a6f7293d70a0c'

view details

push time in 3 hours

push eventalumxi22/teptour

Kyle Miller

commit sha 46959256bdca0a779ce2c79c0d8a966b3d48f545

added old-teptour-remaining to keep track of what's been ported

view details

push time in 3 hours

push eventsourcegraph/sourcegraph

Stephen Gutekanst

commit sha e44e1b2ae7163ed54790cf47e3efa5e432517098

fixup Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>

view details

push time in 3 hours

push eventsourcegraph/sourcegraph

Stephen Gutekanst

commit sha 701851aedb688d82f36a59d42680282507f9e2c4

update MigrateDB callers (+ more type safety) Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>

view details

push time in 3 hours

pull request commentsourcegraph/sourcegraph

internal/db: do not run TimescaleDB migrations against singleton database

Thanks for the effort here, @slimsag! Separating the codeintel db and the frontend db is a very very low priority at this point as it only affects dev and we have checks on startup to ensure it doesn't actually happen.

This PR really minimizes additional muck so I think we can 🚀 with this guy now.

slimsag

comment created time in 3 hours

Pull request review commentsourcegraph/sourcegraph

internal/db: do not run TimescaleDB migrations against singleton database

 func TestMigrations(t *testing.T) { 	db := dbtesting.GetDB(t)  	migrate := func() {-		for _, databaseName := range dbconn.DatabaseNames {-			if err := dbconn.MigrateDB(db, databaseName); err != nil {-				t.Errorf("error running initial migrations: %s", err)-			}+		if err := dbconn.MigrateDB(db, dbconn.Frontend); err != nil {+			t.Errorf("error running initial migrations: %s", err)+		}+		if err := dbconn.MigrateDB(db, dbconn.CodeIntel); err != nil {+			t.Errorf("error running initial migrations: %s", err) 		} 	} -	for _, databaseName := range dbconn.DatabaseNames {-		t.Run(databaseName, func(t *testing.T) {+	for _, database := range []*dbconn.Database{+		dbconn.Frontend,+		dbconn.CodeIntel,+	} {

Yeah I think this is worlds better than tacking a third one on and doing retroactive edge case fixes.

slimsag

comment created time in 3 hours

Pull request review commentsourcegraph/sourcegraph

internal/db: do not run TimescaleDB migrations against singleton database

 func emptyDBPreserveSchema(t testing.TB, d *sql.DB) { 	}  	var conds []string-	for _, migrationTable := range dbconn.MigrationTables {-		conds = append(conds, fmt.Sprintf("table_name != '%s'", migrationTable))-	}+	conds = append(conds, fmt.Sprintf("table_name != '%s'", dbconn.Frontend.MigrationsTable))

lol but what if code intel wants a legit table named codeinsights_schema_migrations????

slimsag

comment created time in 3 hours

Pull request review commentsourcegraph/sourcegraph

internal/db: do not run TimescaleDB migrations against singleton database

 func TestMigrations(t *testing.T) { 	db := dbtesting.GetDB(t)  	migrate := func() {-		for _, databaseName := range dbconn.DatabaseNames {-			if err := dbconn.MigrateDB(db, databaseName); err != nil {-				t.Errorf("error running initial migrations: %s", err)-			}+		if err := dbconn.MigrateDB(db, dbconn.Frontend); err != nil {+			t.Errorf("error running initial migrations: %s", err)+		}+		if err := dbconn.MigrateDB(db, dbconn.CodeIntel); err != nil {+			t.Errorf("error running initial migrations: %s", err) 		} 	} -	for _, databaseName := range dbconn.DatabaseNames {-		t.Run(databaseName, func(t *testing.T) {+	for _, database := range []*dbconn.Database{+		dbconn.Frontend,+		dbconn.CodeIntel,+	} {

Note: Still using a few lists like this in some places to use "the same DB for frontend and codeintel" but I will start fixing that in subsequent PRs where I aim to add code-insights-equivilents to these locations.

For now, it at least makes this "we use multiple DBs here which is kinda clunky" clear & explicit

slimsag

comment created time in 3 hours

pull request commentsourcegraph/sourcegraph

internal/db: do not run TimescaleDB migrations against singleton database

@efritz PTAL, I think this is likely a better step in the right direction?

slimsag

comment created time in 3 hours

push eventsourcegraph/sourcegraph

Stephen Gutekanst

commit sha 22634277aafb7a831aa8030364803e72ea9de8d8

internal/database: make "single database" usage explicit Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>

view details

push time in 3 hours