profile
viewpoint

firefox-devtools/devtools-bug-finder 24

Find easy and mentored devtools bugs

gabrielluong/coding-interview-university 1

A complete computer science study plan to become a software engineer.

gabrielluong/android-components 0

A collection of Android libraries to build browsers or browser-like applications.

gabrielluong/application-services 0

Firefox Application Services

gabrielluong/awesome-computer-vision 0

A curated list of awesome computer vision resources

gabrielluong/awesome-machine-learning 0

A curated list of awesome Machine Learning frameworks, libraries and software.

gabrielluong/browser-extensions 0

Kozmos' Browser Extensions

issue openedmozilla-mobile/fenix

Replace home_show_all_button_text with fx_mobile_text_color_action color token

We can replace home_show_all_button_text (https://searchfox.org/mozilla-mobile/search?q=home_show_all_button_text&path=) with the fx_mobile_text_color_action color token since it is used for Text Links

created time in 17 hours

PullRequestEvent

PR closed mozilla-mobile/fenix

For #22698 - Remove unused mozac_browser_menu_item_switch.xml resource needs:review

Fixed #22698

Pull Request checklist

<!-- Before submitting the PR, please address each item -->

  • [ ] Tests: This PR includes thorough tests or an explanation of why it does not
  • [ ] Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • [ ] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture
+0 -33

0 comment

2 changed files

gabrielluong

pr closed time in 17 hours

PR closed mozilla-mobile/fenix

Reviewers
For #22694 - Remove primary_text_dark_theme usage needs:review

Fixes #22694

Pull Request checklist

<!-- Before submitting the PR, please address each item -->

  • [ ] Tests: This PR includes thorough tests or an explanation of why it does not
  • [ ] Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • [ ] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture
+17 -18

0 comment

5 changed files

gabrielluong

pr closed time in 17 hours

push eventgabrielluong/fenix

Noah Bond

commit sha 73cfd0b1457956f8e518be198f8a9786102bfce9

For #22691 - Add Composables for Primary and Secondary text

view details

Mozilla L10n Automation Bot

commit sha 1d5f7db7c724c0642d3c30b4d1ace7aaf51ac5b7

Import l10n.

view details

push time in 17 hours

Pull request review commentmozilla-mobile/fenix

For #22694 - Remove primary_text_dark_theme usage

         android:lineSpacingExtra="2dp"         android:maxLines="2"         android:textAppearance="@style/HeaderTextStyle"-        android:textColor="@color/primary_text_dark_theme"-        app:drawableTint="@color/primary_text_dark_theme"+        android:textColor="@color/photonLightGrey05"

By static, I mean they are inlined or hard coded to one particular color.

gabrielluong

comment created time in 19 hours

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentmozilla-mobile/fenix

For #22694 - Remove primary_text_dark_theme usage

      <!-- Search Widget -->     <color name="search_widget_background">@color/inset_normal_theme</color>-    <color name="search_widget_mic_fill_color">@color/primary_text_dark_theme</color>-    <color name="search_widget_text">@color/primary_text_dark_theme</color>+    <color name="search_widget_mic_fill_color">@color/photonLightGrey05</color>+    <color name="search_widget_text">@color/fx_mobile_text_color_primary</color>      <!-- Reader View colors -->-    <color name="mozac_feature_readerview_text_color">@color/primary_text_dark_theme</color>+    <color name="mozac_feature_readerview_text_color">@color/fx_mobile_text_color_primary</color>      <!-- Tab Counter colors -->-    <color name="mozac_ui_tabcounter_default_tint">@color/primary_text_dark_theme</color>-    <color name="mozac_ui_tabcounter_default_text">@color/primary_text_dark_theme</color>+    <color name="mozac_ui_tabcounter_default_tint">@color/photonLightGrey05</color>

I suspect we might want to use fx_mobile_text_color_primary here, but opting out for the time being until working with the design tokens become clearer. I can confidently say the other variables should use fx_mobile_text_color_primary since they are all relate to text.

gabrielluong

comment created time in 19 hours

Pull request review commentmozilla-mobile/fenix

For #22694 - Remove primary_text_dark_theme usage

      <!-- Search Widget -->     <color name="search_widget_background">@color/inset_normal_theme</color>-    <color name="search_widget_mic_fill_color">@color/primary_text_dark_theme</color>-    <color name="search_widget_text">@color/primary_text_dark_theme</color>+    <color name="search_widget_mic_fill_color">@color/photonLightGrey05</color>

It's unclear to me what design token should be used for search_widget_mic_fill_color and mozac_ui_tabcounter_default_tint. So, I am leaving it as photonLightGrey05

gabrielluong

comment created time in 19 hours

PullRequestReviewEvent

Pull request review commentmozilla-mobile/fenix

For #22694 - Remove primary_text_dark_theme usage

         android:text="@string/preference_enhanced_tracking_protection_explanation_title"         android:textAlignment="viewStart"         android:textAppearance="@style/Header16TextStyle"-        android:textColor="@color/primary_text_dark_theme"+        android:textColor="@color/photonLightGrey05"

Same as above.

gabrielluong

comment created time in 20 hours

PullRequestReviewEvent

Pull request review commentmozilla-mobile/fenix

For #22694 - Remove primary_text_dark_theme usage

             android:layout_marginEnd="32dp"             android:lineSpacingExtra="2dp"             android:text="@string/cfr_message"-            android:textColor="@color/primary_text_dark_theme"+            android:textColor="@color/photonLightGrey05"

Same as above

gabrielluong

comment created time in 20 hours

PullRequestReviewEvent

Pull request review commentmozilla-mobile/fenix

For #22694 - Remove primary_text_dark_theme usage

         android:lineSpacingExtra="2dp"         android:maxLines="2"         android:textAppearance="@style/HeaderTextStyle"-        android:textColor="@color/primary_text_dark_theme"-        app:drawableTint="@color/primary_text_dark_theme"+        android:textColor="@color/photonLightGrey05"

Opted to inline photonLightGrey05 since the colors in the background are static and does not depend on a dark/light theme.

gabrielluong

comment created time in 20 hours

PullRequestReviewEvent

PR opened mozilla-mobile/fenix

For #22694 - Remove primary_text_dark_theme usage

Fixes #22694

Pull Request checklist

<!-- Before submitting the PR, please address each item -->

  • [ ] Tests: This PR includes thorough tests or an explanation of why it does not
  • [ ] Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • [ ] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture
+17 -18

0 comment

5 changed files

pr created time in 20 hours

create barnchgabrielluong/fenix

branch : 22694

created branch time in 20 hours

PR opened mozilla-mobile/fenix

For #22698 - Remove unused mozac_browser_menu_item_switch.xml resource needs:review

Fixed #22698

Pull Request checklist

<!-- Before submitting the PR, please address each item -->

  • [ ] Tests: This PR includes thorough tests or an explanation of why it does not
  • [ ] Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • [ ] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture
+0 -33

0 comment

2 changed files

pr created time in 20 hours

create barnchgabrielluong/fenix

branch : 22698

created branch time in 20 hours

issue openedmozilla-mobile/fenix

Remove unused mozac_browser_menu_item_switch.xml resource

<issue
    id="UnusedResources"
    message="The resource `R.layout.mozac_browser_menu_item_switch` appears to be unused"
    errorLine1="&lt;Switch xmlns:android=&quot;http://schemas.android.com/apk/res/android&quot;"
    errorLine2="^">
    <location
        file="src/main/res/layout/mozac_browser_menu_item_switch.xml"
        line="5"
        column="1"/>
</issue>

created time in 20 hours

PullRequestEvent

PR closed mozilla-mobile/fenix

For #22696 - Remove unused tab_header.xml resource needs:review

Fixed #22696

Pull Request checklist

<!-- Before submitting the PR, please address each item -->

  • [ ] Tests: This PR includes thorough tests or an explanation of why it does not
  • [ ] Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • [ ] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture
+2 -93

0 comment

3 changed files

gabrielluong

pr closed time in 20 hours

push eventgabrielluong/fenix

Gabriel Luong

commit sha ee051bbcf32643352fdb0832ee6c33badbff3170

For #22696 - Remove unused tab_header.xml resource

view details

push time in 21 hours

PR opened mozilla-mobile/fenix

For #22696 - Remove unused tab_header.xml resource needs:review

Fixed #22696

Pull Request checklist

<!-- Before submitting the PR, please address each item -->

  • [ ] Tests: This PR includes thorough tests or an explanation of why it does not
  • [ ] Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • [ ] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture
+2 -93

0 comment

3 changed files

pr created time in 21 hours

create barnchgabrielluong/fenix

branch : 22696

created branch time in 21 hours

issue openedmozilla-mobile/fenix

Remove unused tab_header resource

From lint-baseline

<issue
    id="UnusedResources"
    message="The resource `R.layout.tab_header` appears to be unused"
    errorLine1="&lt;androidx.constraintlayout.widget.ConstraintLayout"
    errorLine2="^">
    <location
        file="src/main/res/layout/tab_header.xml"
        line="5"
        column="1"/>
</issue>

created time in a day

PullRequestReviewEvent
more