profile
viewpoint
Pig Fang g-plane Honoka Tech LTD Kaiping, Guangdong, China https://gplane.win Student / Metro Fan / Minecraft

issue commenteslint/eslint

implicit-arrow-linebreak doesn't enforce closing paren location

Thanks for this issue.

I think this is expected, because the parens are parts of your arrow function body, and this rule only cares the first token of the body, not the parens.

willlma

comment created time in 30 minutes

startedekmett/lens

started time in 10 hours

pull request commenteslint/eslint

Chore: Add a script for testing with more control

Should we add --reporter=progress?

fa93hws

comment created time in 19 hours

pull request commenteslint/eslint

Docs: Fixes object type for `rules` in "Use a Plugin"

It will be better to do that.

daisy-develops

comment created time in 4 days

delete branch eslint/website

delete branch : handle-crash

delete time in 5 days

delete branch eslint/website

delete branch : hide-popovers

delete time in 5 days

delete branch eslint/website

delete branch : parser-es11

delete time in 5 days

issue commenteslint/eslint

SVG with "viewBox" in .vue with pug

Thanks for this issue.

It seems that this issue is related to eslint-plugin-vue, so we advise you to open issue at their repository.

eafomi4ev

comment created time in 5 days

issue commenteslint/eslint

Show release dates or release versions of rules in documentation

Thanks for this issue.

First, out release note will introduce new rules when new version of ESLint was released, so you can read it to know about changes of ESLint core rules. Second, each release of ESLint contains a Git tag. With version control, you can check the history of a rule.

helmbold

comment created time in 6 days

startedbloc97/Anime4K

started time in 6 days

pull request commenteslint/website

Fix: deselect all doesn't deselect all checkboxes in ESLint demo

Tip: You can preview the website with the changes you made via Netlify.

mdjermanovic

comment created time in 7 days

pull request commenteslint/eslint

Fix: Change "Code Conventions" link in pull-requests.md

While I'm not opposed to this changes, that link isn't broken.

gamtiq

comment created time in 7 days

issue commenteslint/eslint

overrides extends not working

You should extend from that preset (It may be plugin:jest/all for your case); otherwise ESLint won't read that preset and check your code.

viT-1

comment created time in 7 days

PR closed eslint/eslint

rule proposal triage

<!-- ESLint adheres to the JS Foundation Code of Conduct. -->

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update [ ] Bug fix (template) [ ] New rule (template) X [ ] Changes an existing rule (template) [ ] Add autofixing to a rule [ ] Add a CLI option [ ] Add something to the core [ ] Other, please explain:

<!-- If the item you've checked above has a template, please paste the template questions below and answer them. (If this pull request is addressing an issue, you can just paste a link to the issue here instead.) -->

<!-- Please ensure your pull request is ready:

- Read the pull request guide (https://eslint.org/docs/developer-guide/contributing/pull-requests)
- Include tests for this change
- Update documentation for this change (if appropriate)

-->

<!-- The following is required for all pull requests: -->

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

+3 -2

2 comments

1 changed file

KomalShahzadi

pr closed time in 7 days

pull request commenteslint/eslint

rule proposal

Thanks for your contribution. However, if you want to propose a new rule, please file a new issue here and fill out our template.

Thanks for your participation of ESLint.

KomalShahzadi

comment created time in 7 days

issue commenteslint/eslint

eslint will timeout and stack trace when node_modules have too many files

You may try:

"standard": {
  "ignore": [
    "**/node_modules/**"
  ]
}

Ref: https://github.com/standard/standard-engine/blob/f2f766e64a6f4b18c2d07e150ba0fbccc56bc0ca/index.js#L22

zhangyuang

comment created time in 7 days

issue commenteslint/eslint

eslint will timeout and stack trace when node_modules have too many files

Thanks for this issue.

By default, ESLint will ignore the node_modules directory. Can you show us your ESLint configuration and your .eslintignore? Thanks.

zhangyuang

comment created time in 7 days

startedfirefox-devtools/vscode-firefox-debug

started time in 7 days

Pull request review commenteslint/website

Update: handle crashes and report invalid autofix in ESLint demo

+import React from "react";++export default function BugReport(props) {+    return (+        <div className="alert report-message-alert alert-danger">+            <div>+                {props.message}+            </div>+            <div>+                Please submit a bug report at:+            </div>+            <div>+                <a href="https://github.com/eslint/eslint/issues">https://github.com/eslint/eslint/issues</a>

Yes, they'll be redirected to login page.

mdjermanovic

comment created time in 7 days

Pull request review commenteslint/website

Update: handle crashes and report invalid autofix in ESLint demo

+import React from "react";++export default function BugReport(props) {+    return (+        <div className="alert report-message-alert alert-danger">+            <div>+                {props.message}+            </div>+            <div>+                Please submit a bug report at:+            </div>+            <div>+                <a href="https://github.com/eslint/eslint/issues">https://github.com/eslint/eslint/issues</a>

Should we point it to "New Issue" page directly instead of issues list?

mdjermanovic

comment created time in 7 days

issue commenteslint/eslint

The "sort-imports" rule does not handle module-specifier-only imports.

That's a limitation of static analysis, and ESLint isn't able to know whether a module has side effects or not.

theengineear

comment created time in 8 days

issue commenteslint/eslint

The "sort-imports" rule does not handle module-specifier-only imports.

Actually, different imports order may cause different behaviors. For example,

// a.js
console.log('a')

export default 'a'
// b.js
console.log('b')

export default 'b'

If we import a.js before b.js like this:

import './a.js'
import './b.js'

Console will output:

a
b

However,

import './b.js'
import './a.js'

Console will output:

b
a
theengineear

comment created time in 8 days

issue commenteslint/eslint

The "sort-imports" rule does not handle module-specifier-only imports.

Thanks for this report.

This is an expected behavior. The sort-imports rule doesn't check the import source.

theengineear

comment created time in 8 days

issue commenteslint/eslint

It doesn't work on vscode when upgrading from eslint5 to eslint6

Closing now, since it's not an issue from ESLint itself.

zhanyuzhang

comment created time in 8 days

issue closedeslint/eslint

It doesn't work on vscode when upgrading from eslint5 to eslint6

It doesn't work on vscode when upgrading from eslint5 to eslint6.

closed time in 8 days

zhanyuzhang

issue commenteslint/eslint

It doesn't work on vscode when upgrading from eslint5 to eslint6

What problem have you encountered? Also, can you try running ESLint at CLI? If it works at CLI, this problem may be from "vscode-eslint".

zhanyuzhang

comment created time in 8 days

pull request commenteslint/eslint

Updated README.md

Do we really need this changes?

shanuksha

comment created time in 8 days

push eventbs-community/blessing-skin-server

Pig Fang

commit sha facc043df7334bb2b9272074f7c289d7f54f1e2a

Upgrade dependencies

view details

push time in 9 days

push eventbs-community/blessing-skin-server

Pig Fang

commit sha c424465321551d4f41bb04d1c7232d422b3024b5

Fix locale detection

view details

push time in 10 days

startedAkryum/awesomejs.dev

started time in 12 days

issue commenteslint/eslint

keyword-spacing else ghost default

Thanks for this issue.

It seems that you've set after: false in your configuration, while you're reporting about the before option.

LJNeon

comment created time in 13 days

issue commenteslint/eslint

Linting Errors Still Throw Exit Code 0

Thanks for this issue.

It seems that you were running ESLint by a custom JavaScript file you wrote, right?

magnanimus1994

comment created time in 13 days

startedcolin-kiegel/rust-pretty-assertions

started time in 16 days

startediptv-org/iptv

started time in 16 days

PR opened eslint/website

Chore: fix badge URL

The repository name has been changed before, which caused invalid badge URL. This PR fixes it.

+1 -1

0 comment

1 changed file

pr created time in 16 days

create barncheslint/website

branch : fix-badge

created branch time in 16 days

issue commenteslint/eslint

TypeError: Cannot read property 'substring' of undefined

@jurgisrudaks If you've confirmed this isn't an ESLint issue, you can close this issue.

jurgisrudaks

comment created time in 16 days

issue commenteslint/eslint

Rule tester output not applying all fixes

If it works as intended, there may be nothing should be changed.

armano2

comment created time in 17 days

pull request commenteslint/eslint

Chore: Format style guide links so they can be clicked

Feel free to do it!

ivandotv

comment created time in 17 days

issue commentbs-community/bs-integration-for-wordpress

Plugin Database Access Denied Error

If you WordPress server and MySQL server aren't on the same host, you may configure your MySQL to make it allow to accept external connections.

iqmal25

comment created time in 17 days

issue commenteslint/eslint

[6.5.0] `no-useless-rename` with `babel-eslint` crash at rest properties

Off topic:

@kaicataldo Maybe it can be done at https://github.com/babel/babel-eslint/pull/785 .

jakeleventhal

comment created time in 17 days

Pull request review commenteslint/eslint

Update: no-useless-rename also reports default values (fixes #12301)

 module.exports = {                 return;             } -            const properties = node.properties;--            for (let i = 0; i < properties.length; i++) {-                if (properties[i].shorthand) {-                    continue;-                }+            for (const property of node.properties) {                  /**-                 * If an ObjectPattern property is computed, we have no idea-                 * if a rename is useless or not. If an ObjectPattern property-                 * lacks a key, it is likely an ExperimentalRestProperty and-                 * so there is no "renaming" occurring here.+                 * Properties using shorthand syntax and rest elements can not be renamed.+                 * If the property is computed, we have no idea if a rename is useless or not.                  */-                if (properties[i].computed || !properties[i].key) {+                if (property.shorthand || property.type === "RestElement" || property.computed) {                     continue;                 } -                if (properties[i].key.type === "Identifier" && properties[i].key.name === properties[i].value.name ||-                        properties[i].key.type === "Literal" && properties[i].key.value === properties[i].value.name) {-                    reportError(properties[i], properties[i].key, properties[i].value, "Destructuring assignment");+                const key = (property.key.type === "Identifier" && property.key.name) || (property.key.type === "Literal" && property.key.value);

Please track this issue: #12335 .

kaicataldo

comment created time in 18 days

issue commenteslint/website

Demo: Rule select-all checkbox does not deselect all rules

I also encountered this problem.

platinumazure

comment created time in 18 days

issue commenteslint/eslint

Bug when upgrading from 6.4.0 to 6.5.0

I've tested with different parsers. Here is result:

Parser Did it work?
espree Yes
babel-eslint@9 No
babel-eslint@10 No
babel-eslint@11 No
jakeleventhal

comment created time in 18 days

issue commenteslint/eslint

Bug when upgrading from 6.4.0 to 6.5.0

Thanks for this issue.

Can you minimize your code example to help us ensure which part caused the bug? Thanks.

jakeleventhal

comment created time in 18 days

pull request commenteslint/eslint

Chore: Format style guide links so they can be clicked

We can use colon.

Screenshots: 图片

图片

Links can be detected properly.

ivandotv

comment created time in 18 days

issue commenteslint/eslint

Vscode and atom highlight locations are unexpected when end location is not provided

Maybe we can modify rules, because this can benefit formatters as well. However, I'm not sure how formatters behave when reporting those rules.

golopot

comment created time in 18 days

IssuesEvent

issue commenteslint/eslint

Exemption for for...of unused variable.

Oh, it seems reasonable. Sorry.

dimaqq

comment created time in 19 days

issue commenteslint/eslint

`no-warning-comments` should include the comment itself in the report (UX only)

We need at least 3 upvotes from @eslint/eslint-team to accept this enhancement.

fregante

comment created time in 19 days

startedtailwindcss/tailwindcss

started time in 19 days

issue commenteslint/eslint

`no-restricted-imports`: disable comments do not work for individual named imports

I can reproduce this bug at our ESLint Demo.

I think the rule should only report the restricted items. For the example from @OliverJAsh , the rule should report zip only.

OliverJAsh

comment created time in 19 days

issue commenteslint/eslint

`prefer-named-capture-group` should be disabled when using `.test()` or `.replace()`

Thanks for this issue.

Personally, I think this is expected. You're using regular expressions groups, but you aren't going to capture anything, so this rule suggests you adding prefix ?: which means using groups without capturing.

fregante

comment created time in 19 days

issue closedeslint/eslint

Exemption for for...of unused variable.

In similar vein to for...in https://github.com/eslint/eslint/issues/2342 Should there be similar exemption for [async] for...of?

What rule do you want to change? no-unused-vars

Does this change cause the rule to produce more or fewer warnings? fewer warnings

How will the change be implemented? (New option, new default behavior, etc.)? I don't know

Please provide some example code that this change will affect:

async function forever(x) {
  for await (const unused of x) {
    void unused;
  }
}

forever(monitor_network());

What does the rule currently do for this code? Line 42: 'unused' is defined but never used no-unused-vars

What will the rule do after it's changed? Nothing

Are you willing to submit a pull request to implement this change? This seems tricky...

closed time in 19 days

dimaqq

issue commenteslint/eslint

Exemption for for...of unused variable.

Closing this issue as it looks like the question has been answered. Please feel free to visit us in the ESLint Gitter if you have any other issues!

dimaqq

comment created time in 19 days

create barnchg-plane/which-canteen-should-we-go-to

branch : master

created branch time in 20 days

created repositoryg-plane/which-canteen-should-we-go-to

Which canteen should we go to?

created time in 20 days

issue commenteslint/eslint

[no-path-concat] overlooks template literals

I'm :+1: on transferring this rule to eslint-plugin-node.

mysticatea

comment created time in 20 days

issue commentbuntis/buntis

Move CI to GitHub Actions or Azure Pipelines

I can, but it seems that GitHub Actions isn't enabled for this organization.

g-plane

comment created time in 22 days

startedresume/resume.github.com

started time in 23 days

issue openedbuntis/buntis

Move CI to GitHub Actions or Azure Pipelines

GitHub Actions and Azure Pipelines are completely free for open source projects, while CircleCI has limitation that we only can run no more than 1000 minutes per month.

created time in 23 days

startedmeriyah/meriyah

started time in 23 days

startedbuntis/buntis

started time in 23 days

issue commenteslint/eslint

Add reportDisableDirectives config/CLI option

Thanks for this new issue.

There is an ESLint plugin which is related to ESLint comments and you may take a look. However, I'm not sure if that plugin can satisfy your request.

galvarez421

comment created time in 23 days

IssuesEvent

issue commenteslint/eslint

brace-style 1tbs with allowSingleLine should not allow else on separate line

Thanks for this issue.

However, allowSingleLine doesn't mean enforceSingleLine. That is, you can put them in one line, but not forced.

kardasis

comment created time in 24 days

issue commenteslint/eslint

Add option for groups to `sort-keys`

Thanks for this issue.

Personally, I think this feature can be implemented in @typescript-eslint/plugin instead of ESLint core.

timolins

comment created time in 24 days

startedprimer/css

started time in 25 days

startedMrTJP/ProjectRed

started time in 25 days

startedprimer/components

started time in 25 days

push eventbs-community/blessing-skin-server

Pig Fang

commit sha 55b9b5ad9e2417145e3c5af23b57aaf8f2410e70

Replace node-sass with dart-sass

view details

push time in a month

push eventbs-community/blessing-skin-server

Pig Fang

commit sha 74452a70dea623cb5d57c2b7ffe0af12644d79d6

Fix loading style when development

view details

Pig Fang

commit sha c0d6256efd87e0cb47cbff30a7fb9da0048685e7

Fix webpack-dev-server

view details

Pig Fang

commit sha 5b8e344ce92ba7794305632a8e51ffad2f84fd2a

Upgrade front-end building related dependencies

view details

Pig Fang

commit sha 4be0e0e4e1a1bc9d8a35f334fdebe8a04e0eb54d

Add notice about hot reload

view details

push time in a month

startedmicrosoft/cascadia-code

started time in a month

startedegoist/native-toast

started time in a month

push eventbs-community/blessing-skin-server

Pig Fang

commit sha 2a2491ac93512ab6a487fcd45eaf0cab46883d04

Do not extract `Switch` component

view details

push time in a month

push eventbs-community/blessing-skin-server

Pig Fang

commit sha d232bb4672a8dfaa3a8c85d1c284a2c738ce9080

Remove unused code

view details

Pig Fang

commit sha bb898ea2e44db5fe23a2a0a01082732e3c18ce35

Use `message` to report plugin errors Instead of `notification`

view details

push time in a month

push eventbs-community/blessing-skin-server

Pig Fang

commit sha 84f760d9309093a430a231d47feaa2032b63625d

Remove unused code

view details

Pig Fang

commit sha 82140b689307de5c6f6c8459dbedcfe56b4935a8

Blade -> Twig (almost finished)

view details

push time in a month

push eventbs-community/blessing-skin-server

Pig Fang

commit sha 3b1866ffba32dad50c8d46870fbb29639dc850d5

Blade -> Twig

view details

push time in a month

push eventbs-community/blessing-skin-server

Pig Fang

commit sha c2f4d3a008419b75ad5286f675c60e55635c8190

Fix PHP check

view details

Pig Fang

commit sha 146c12f26e50723d260563fb865f46317fc8af1c

Restructure tests

view details

push time in a month

push eventbs-community/blessing-skin-server

Pig Fang

commit sha 9403ae356ddd9d673e8cf39b8a13009c342b7655

Blade -> Twig (wip)

view details

push time in a month

push eventbs-community/blessing-skin-plugin-docs

Pig Fang

commit sha c2585eb1f4ed134160bdff6ea08422a37f5ce100

Update helpers.md

view details

push time in a month

push eventbs-community/blessing-skin-plugin-docs

Pig Fang

commit sha 3d8717762abed4e5a39ebbc414306a5aac54e074

Update migration.md

view details

push time in a month

push eventbs-community/blessing-skin-server

Pig Fang

commit sha 19efd013f6758a84ff4cde4f88fa9c36174233ba

Tweak mocks

view details

push time in a month

push eventbs-community/blessing-skin-server

Pig Fang

commit sha f51e2d7b9d25ca9403fe6fa7ee7339f0d41774b6

Tweak CI

view details

push time in a month

push eventbs-community/blessing-skin-server

Pig Fang

commit sha 4a9af2d5df7da590752411285c0d9ffc3751f86d

Refactor retrieving assets

view details

push time in a month

push eventbs-community/blessing-skin-plugin-docs

Pig Fang

commit sha 9618a012bd4c7801fafb4b083ee867aaedd8bfa2

Update migration.md

view details

push time in a month

push eventbs-community/blessing-skin-plugin-docs

Pig Fang

commit sha 68935040b525e6027ca809172427f8dd4f2c4c01

Update bootstrap.md

view details

push time in a month

push eventbs-community/blessing-skin-server

Pig Fang

commit sha 792062451ab0ae06ed35295a0d337bae2a16663e

Remove priority due to changes from Laravel 5.4

view details

push time in a month

push eventbs-community/blessing-skin-server

Pig Fang

commit sha 93a7bae30d2f28143caf5a1dafe65db64dfa0933

Fix catching cipher exception

view details

push time in a month

push eventbs-community/blessing-skin-plugins

Pig Fang

commit sha f24aff75d9391b5bdd4bf043698a8f08d2fe346f

[insider] fix

view details

push time in a month

pull request commenteslint/eslint

Update: Add enforceForSwitchCase option to use-isnan

About Number.isNaN, a rule like prefer-number-isnan may be useful?

@mysticatea There are also something like preferring parseInt to Number.parseInt and preferring parseFloat to Number.parseFloat, so that rule shouldn't be only for Number.isNaN.

mdjermanovic

comment created time in a month

push eventbs-community/blessing-skin-plugin-docs

Pig Fang

commit sha 01b82f6254290cfbd574c6fe9e72090ca1b02ff1

Update migration.md

view details

push time in a month

push eventbs-community/blessing-skin-plugin-docs

Pig Fang

commit sha bf8bdad20c4367db79fc13a41d8ed005c8c78e4a

Update helpers.md

view details

push time in a month

push eventbs-community/blessing-skin-plugin-docs

Pig Fang

commit sha 66b64168a88e70c19071532dd3796284a7598980

Update helpers.md

view details

push time in a month

push eventbs-community/blessing-skin-server

Pig Fang

commit sha acde755e43c89676c246a50500948783f6df966d

Update release script

view details

push time in a month

push eventbs-community/blessing-skin-server

Pig Fang

commit sha 5fc2b2f612a122a558677ad7bb15a1837244d126

Fix release script

view details

push time in a month

push eventbs-community/blessing-skin-server

Pig Fang

commit sha 5fc2b2f612a122a558677ad7bb15a1837244d126

Fix release script

view details

push time in a month

push eventbs-community/blessing-skin-server

Pig Fang

commit sha 8552d2f7b59bd07455e6786569147b994d74047b

Add a new env item for webpack

view details

Pig Fang

commit sha 88a89684902ef9e99507c1706fb2518f91f3302b

Add dump server for development

view details

Pig Fang

commit sha 2d30deb279c6eea5e26c60ca31e6b8254ae1cea6

Update sponsor

view details

Pig Fang

commit sha 53781536e78b7809d3d1d0f8ed343c41cbc1ff9f

Some fields at admin panel shouldn't be sortable

view details

Pig Fang

commit sha 9cd46fdbafbc76832c8594080966f1c2aff0c746

Add missing l10n text (fix #83)

view details

Pig Fang

commit sha d41bbe201c21f08d3550c1e23d5ba78644d660ed

Don't log when testing

view details

Pig Fang

commit sha 80cc47279f0828caad083121e8dcf413846d64c6

`config.blade.php` as default config view file name.

view details

Pig Fang

commit sha 160dc3e877981ae32b3dfe788a34a7317543aea6

Update deps

view details

dependabot[bot]

commit sha 61d5ebe17260033f5af80ae48f0c5c867ce5dce7

Bump lodash from 4.17.10 to 4.17.11 (#86) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.10 to 4.17.11. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.10...4.17.11) Signed-off-by: dependabot[bot] <support@github.com>

view details

Pig Fang

commit sha a0daad44d99bde9bd6cdcceec6a019c7054b04cc

Update readme

view details

Pig Fang

commit sha 67bcfc65a58d19cd1d3fbca70b01f65549e6c0cf

Refactor user model

view details

Pig Fang

commit sha 73beea6af4e0ac274d8425ae2e32efb8ce2a29c4

Tweak

view details

Pig Fang

commit sha 3f4837bb3501c3690d06011c2baca9857b6f59d7

Refactor user model

view details

Pig Fang

commit sha 2731225f4e80f4fad798560c8d1c3efe9bcf6b13

Fix comment

view details

Pig Fang

commit sha 744964424e251d5caff86306d985b8a11aee8fbf

Remove docker script

view details

Pig Fang

commit sha 07d08c7ad8b2d0f008ec48c37af8d2c08ca9e143

Use Azure Pipelines

view details

Pig Fang

commit sha c5da87b681fcfb7957952223cef5d34cc5edbc6e

Update release script

view details

Pig Fang

commit sha d8eb04dc180b1653fb03fbb0e36f2c47bbeb5348

Update release script

view details

Pig Fang

commit sha 5fab37624812ba74e269486197ccc5c42f9dc924

Update release script

view details

Pig Fang

commit sha 7929de789115bc5b3c9546a19497ca280eeddb5a

Use lower case for hashing

view details

push time in a month

push eventbs-community/blessing-skin-server

Pig Fang

commit sha f2afe728e714551addc0455a7f7853c47c7a94c8

Update release script

view details

Pig Fang

commit sha 2f774d91111aed1a6cba74656bdec203144972ef

Bump version to 5.0.0-beta.1

view details

push time in a month

more