profile
viewpoint
Frederik Wallner fwal Dooer AB Stockholm, Sweden http://frederikwallner.com Head of Mobile @ Dooer AB

retrohacker/getos 66

A Node.js module that returns the OS/Distribution name of the environment you are working on

fwal/setup-swift 48

GitHub Action that setup a Swift environment

fwal/danger-jazzy 4

Check for undocumented symbols using danger and jazzy

fwal/gostart 2

Basic skeleton for go web apps

fwal/danger-favro 1

A Danger plugin that detect Favro cards referenced

fwal/DangerJazzy 1

Danger plugin for Jazzy, written in Swift

applyrics/applyrics-gem 0

Manage your localization with confidence.

Dooer/apollo-codegen 0

:pencil2: Generate API code or type annotations based on a GraphQL schema and query documents

Dooer/apollo-ios 0

📱 A GraphQL client for iOS, written in Swift

fwal/apollo-android 0

:pager: A strongly-typed, caching GraphQL client for Android and the JVM

delete branch fwal/setup-swift

delete branch : dependabot/npm_and_yarn/prettier-2.2.0

delete time in a day

PR closed fwal/setup-swift

Reviewers
Bump prettier from 2.1.2 to 2.2.0 dependencies javascript

Bumps prettier from 2.1.2 to 2.2.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/prettier/prettier/releases">prettier's releases</a>.</em></p> <blockquote> <h1>2.2.0</h1> <p><a href="https://github.com/prettier/prettier/compare/2.1.2...2.2.0">diff</a></p> <p>🔗 <a href="https://prettier.io/blog/2020/11/20/2.2.0.html">Release Notes</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/prettier/prettier/blob/master/CHANGELOG.md">prettier's changelog</a>.</em></p> <blockquote> <h1>2.2.0</h1> <p><a href="https://github.com/prettier/prettier/compare/2.1.2...2.2.0">diff</a></p> <p>🔗 <a href="https://prettier.io/blog/2020/11/20/2.2.0.html">Release Notes</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/prettier/prettier/commit/42b2195e713236f2d43dd95add7301d63f7f6b0c"><code>42b2195</code></a> Release 2.2.0</li> <li><a href="https://github.com/prettier/prettier/commit/9bc90cfe7d2b1531ae1249baffe43ed318bd12a4"><code>9bc90cf</code></a> Update to typescript 4.1.2 (<a href="https://github-redirect.dependabot.com/prettier/prettier/issues/9725">#9725</a>)</li> <li><a href="https://github.com/prettier/prettier/commit/002dc6c45fd3f57d29e3f051e4a6362d32a8842f"><code>002dc6c</code></a> Extract <code>printStatementSequence</code>, <code>printMemberExpression</code>, and <code>printBlock</code> (...</li> <li><a href="https://github.com/prettier/prettier/commit/92d31d1b30ceeda381164dc1ae26b5bc0eefe8a5"><code>92d31d1</code></a> Extract <code>printAssignment</code>, <code>printBinaryishExpression</code>, and <code>printComment</code> (<a href="https://github-redirect.dependabot.com/prettier/prettier/issues/9">#9</a>...</li> <li><a href="https://github.com/prettier/prettier/commit/05236cf64dca26a308dc4f928c61713e0b5e7dc5"><code>05236cf</code></a> Extract printInterface and printCallExpression (<a href="https://github-redirect.dependabot.com/prettier/prettier/issues/9715">#9715</a>)</li> <li><a href="https://github.com/prettier/prettier/commit/c03a38e8de078eaa50385842258969a2ceeb2986"><code>c03a38e</code></a> Extract function related functions (<a href="https://github-redirect.dependabot.com/prettier/prettier/issues/9721">#9721</a>)</li> <li><a href="https://github.com/prettier/prettier/commit/87dab58b3ac41d57ae9232187490085d37cb660e"><code>87dab58</code></a> Extract printClass and printTypeParameters (<a href="https://github-redirect.dependabot.com/prettier/prettier/issues/9713">#9713</a>)</li> <li><a href="https://github.com/prettier/prettier/commit/b12e869333b6361a766d4e4bc8c94299040c0936"><code>b12e869</code></a> Extract JSX related print functions (<a href="https://github-redirect.dependabot.com/prettier/prettier/issues/9714">#9714</a>)</li> <li><a href="https://github.com/prettier/prettier/commit/7acaa554e92330fabae038b73048efc5384df65f"><code>7acaa55</code></a> Build(deps-dev): Bump rollup from 2.33.2 to 2.33.3 (<a href="https://github-redirect.dependabot.com/prettier/prettier/issues/9717">#9717</a>)</li> <li><a href="https://github.com/prettier/prettier/commit/ca9aac8997eb1221c6a91505e8d7a2945284d8d4"><code>ca9aac8</code></a> Build(deps-dev): Bump webpack from 5.5.0 to 5.5.1 in /website (<a href="https://github-redirect.dependabot.com/prettier/prettier/issues/9716">#9716</a>)</li> <li>Additional commits viewable in <a href="https://github.com/prettier/prettier/compare/2.1.2...2.2.0">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+6 -5994

1 comment

2 changed files

dependabot[bot]

pr closed time in a day

pull request commentfwal/setup-swift

Bump prettier from 2.1.2 to 2.2.0

Superseded by #157.

dependabot[bot]

comment created time in a day

PR opened fwal/setup-swift

Bump prettier from 2.1.2 to 2.2.1

Bumps prettier from 2.1.2 to 2.2.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/prettier/prettier/releases">prettier's releases</a>.</em></p> <blockquote> <h2>2.2.1</h2> <p><a href="https://github.com/prettier/prettier/blob/master/CHANGELOG.md#221">🔗 Changelog</a></p> <h1>2.2.0</h1> <p><a href="https://github.com/prettier/prettier/compare/2.1.2...2.2.0">diff</a></p> <p>🔗 <a href="https://prettier.io/blog/2020/11/20/2.2.0.html">Release Notes</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/prettier/prettier/blob/master/CHANGELOG.md">prettier's changelog</a>.</em></p> <blockquote> <h1>2.2.1</h1> <p><a href="https://github.com/prettier/prettier/compare/2.2.0...2.2.1">diff</a></p> <h4>Fix formatting for AssignmentExpression with ClassExpression (<a href="https://github-redirect.dependabot.com/prettier/prettier/pull/9741">#9741</a> by <a href="https://github.com/sosukesuzuki">@sosukesuzuki</a>)</h4> <!-- raw HTML omitted --> <pre lang="js"><code>// Input module.exports = class A extends B { method() { console.log("foo"); } }; <p>// Prettier 2.2.0 module.exports = class A extends ( B ) { method() { console.log("foo"); } };</p> <p>// Prettier 2.2.1 module.exports = class A extends B { method() { console.log("foo"); } }; </code></pre></p> <h1>2.2.0</h1> <p><a href="https://github.com/prettier/prettier/compare/2.1.2...2.2.0">diff</a></p> <p>🔗 <a href="https://prettier.io/blog/2020/11/20/2.2.0.html">Release Notes</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/prettier/prettier/commit/326543f9082d6d77dec634914c8d4daa8525c7eb"><code>326543f</code></a> Release 2.2.1</li> <li><a href="https://github.com/prettier/prettier/commit/81bfd3ffc72d3c971e3b6962157a90c8bf12be50"><code>81bfd3f</code></a> Fix changelog to old format</li> <li><a href="https://github.com/prettier/prettier/commit/b46710f2d9cd53a83ac615d68b6b2f20ae600493"><code>b46710f</code></a> Fix formatting for AssignmentExpression with ClassExpression (<a href="https://github-redirect.dependabot.com/prettier/prettier/issues/9741">#9741</a>)</li> <li><a href="https://github.com/prettier/prettier/commit/114fe2e6cc0864e9f9e9f24379aaf424be8b3e7a"><code>114fe2e</code></a> Fix typo</li> <li><a href="https://github.com/prettier/prettier/commit/81303dab8c85765ae87b9921536cde8954d37a9f"><code>81303da</code></a> Docs: Add missing <code>meriyah</code> parser</li> <li><a href="https://github.com/prettier/prettier/commit/28cc1908fd8fd1d8d62b62ce55d735325dd5f118"><code>28cc190</code></a> Clean changelog_unreleased</li> <li><a href="https://github.com/prettier/prettier/commit/d2b9b083ca0c4a2d918cf3a4918e3b39ac189d70"><code>d2b9b08</code></a> Add 2.2 blog post (<a href="https://github-redirect.dependabot.com/prettier/prettier/issues/9589">#9589</a>)</li> <li><a href="https://github.com/prettier/prettier/commit/2d9897a6b8589088ace0f53728f391ecd13b0d36"><code>2d9897a</code></a> Update dependents count</li> <li><a href="https://github.com/prettier/prettier/commit/117583991c12a77fcd77d01d407a03a1ce8f2362"><code>1175839</code></a> Git blame ignore 2.2.0</li> <li><a href="https://github.com/prettier/prettier/commit/cf354c205de9841a2d306387473dac369359ca2b"><code>cf354c2</code></a> Bump Prettier dependency to 2.2.0</li> <li>Additional commits viewable in <a href="https://github.com/prettier/prettier/compare/2.1.2...2.2.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+6 -5994

0 comment

2 changed files

pr created time in a day

create barnchfwal/setup-swift

branch : dependabot/npm_and_yarn/prettier-2.2.1

created branch time in a day

startedSupereg/secure-video-specification

started time in a day

issue commentdanger/swift

cannot find type 'Process' in scope when compiling

XCode 12.0.0

The CI step in question looks like this:

swift package generate-xcodeproj
swift package update
xcodebuild build -sdk iphoneos -scheme 'LuboTvOSNetworkingKit-Package'
xcodebuild test -destination 'name=iPhone 8' -scheme 'LuboTvOSNetworkingKit-Package' -enableCodeCoverage YES -derivedDataPath .build/derivedData | xcpretty && exit ${PIPESTATUS[0]}
mkaminow

comment created time in a day

issue commentdanger/swift

cannot find type 'Process' in scope when compiling

Which environment are you using on CI?

mkaminow

comment created time in 2 days

issue commentdanger/swift

Bitrise ENV set https URL faling

This feels like it needs more info to be understood, can you write a more detailed issue please?

Smitesh-P

comment created time in 2 days

created tagfwal/setup-swift

tagv1.4.0

GitHub Action that setup a Swift environment

created time in 4 days

release fwal/setup-swift

v1.4.0

released time in 4 days

push eventfwal/setup-swift

Frederik Wallner

commit sha 9d933212bbf81b8769da6b1ca57c9779ff012517

Use v1-next instead of master

view details

dependabot[bot]

commit sha 0d72e98d1bb75b8c4512d86111815a6c71224e50

Bump @types/node from 14.14.5 to 14.14.10 Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.14.5 to 14.14.10. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 4 days

push eventfwal/setup-swift

Frederik Wallner

commit sha 9d933212bbf81b8769da6b1ca57c9779ff012517

Use v1-next instead of master

view details

dependabot[bot]

commit sha 05b02dd1493caac7ab8bb49757c3afd39a6cad3c

Bump prettier from 2.1.2 to 2.2.0 Bumps [prettier](https://github.com/prettier/prettier) from 2.1.2 to 2.2.0. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/master/CHANGELOG.md) - [Commits](https://github.com/prettier/prettier/compare/2.1.2...2.2.0) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 4 days

push eventfwal/setup-swift

Frederik Wallner

commit sha 9d933212bbf81b8769da6b1ca57c9779ff012517

Use v1-next instead of master

view details

dependabot[bot]

commit sha 70811c23a14d281a617af14d2b7a2e1cc4307aa0

Bump @actions/tool-cache from 1.6.0 to 1.6.1 Bumps [@actions/tool-cache](https://github.com/actions/toolkit/tree/HEAD/packages/tool-cache) from 1.6.0 to 1.6.1. - [Release notes](https://github.com/actions/toolkit/releases) - [Changelog](https://github.com/actions/toolkit/blob/main/packages/tool-cache/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/tool-cache) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 4 days

issue commenttuist/XcodeProj

How to see instance of .xcodeproj in debugger

I once have used the Ruby project https://github.com/CocoaPods/Xcodeproj to open a project file, clone an existing target, change build steps and other things and then save the project. This was quite difficult for me, a mixture of not knowing well the xcodeproj file format, the object representation of that file in that Ruby library and the programming language itself. So I had to use a number of println to understand how the objects looked like before and after manipulation.

I've now done a spike on Tuist to see whether Tuist is useful for my team. As Tuist is already doing some "magic" I would like to have the fallback method to additionally manipulate the project files. Writing a script is easier while having a debugger.

carsten-wenderdel

comment created time in 5 days

issue closedtuist/XcodeProj

How to add Capabilities?

Is there any way to add the Xcode capabilities?

closed time in 5 days

vvnasina

issue commenttuist/XcodeProj

How to add Capabilities?

@vvnasina capabilities are entitlements, and editing those is outside the scope of this library. Bear in mind that entitlements is a property list file that you can read and write using the standard library

vvnasina

comment created time in 5 days

issue commenttuist/XcodeProj

PreAction scripts are not properly escaped

Hey @mobileben. Thanks for reporting this! Unfortunately, we can prioritize fixing this but if you'd like to go ahead and fix the issue yourself you are welcome to do. I'll happily review it.

mobileben

comment created time in 5 days

issue closedtuist/XcodeProj

How to add/remote framework for target

func addFramework(name: String, to target: PBXTarget) {
    if let phase = getBuildPhase(for: "Frameworks", in: target) as? PBXFrameworksBuildPhase {
        let element = PBXFileElement(sourceTree: .buildProductsDir, path: "\(name).framework", name: "\(name).framework")
        let file = PBXBuildFile(file: element)
        phase.files?.append(file)
    }
}

Not work, the project filechangs:

"TEMP_DE02C97D-35B4-4B31-8562-343C44F8E473" /* (null) in Frameworks */,

closed time in 5 days

purkylin

push eventtuist/XcodeProj

Pedro Piñera

commit sha a8cef4417ef3a23e54fb2ffe3bab6ca7f72266ba

Updated CHANGELOG

view details

push time in 5 days

pull request commenttuist/XcodeProj

[Fix] JSON decoder not properly decoding `defaultConfigurationIsVisible` in some projects

Thanks for fixing this @tjwio 🙏

tjwio

comment created time in 5 days

push eventtuist/XcodeProj

Tim Wong

commit sha c686cdc8f6ce31e3a47734688b3cb86160ddd2b0

[Fix] JSON decoder not properly decoding `defaultConfigurationIsVisible` in some projects (#593) * test * one more test * fix * Fix tests * reset resolved Co-authored-by: Tim Wong <twong@snapchat.com>

view details

push time in 5 days

PR merged tuist/XcodeProj

[Fix] JSON decoder not properly decoding `defaultConfigurationIsVisible` in some projects

Resolves https://github.com/tuist/xcodeproj/issues/592

Short description 📝

This PR should fix decoding defaultConfigurationIsVisible (and other booleans) of multiple types of encoding (ie. plist encoded which encodes to a proper boolean or a normal pbxproj which encodes into a string).

Solution 📦

Try decoding it as a string like before, then an int, then a boolean and finally return nil if it cannot. Notice each try is marked with try? so it doesn't actually throw in case there is a type mismatch.

Implementation 👩‍💻👨‍💻

  • [X] Fix decoder process for booleans
  • [X] Test out in both pbxproj formats
+7 -2

1 comment

1 changed file

tjwio

pr closed time in 5 days

issue closedtuist/XcodeProj

JSON decoder not properly decoding `defaultConfigurationIsVisible` in some projects

Context 🕵️‍♀️

Some of our projects generated via BUCK have a plist encoding so the property looks like:

<key>defaultConfigurationIsVisible</key>
<false/>

instead of something like:

defaultConfigurationIsVisible = 0;

This causes the JSON encoder to encode the property as a boolean instead of a string, so the JSON decoder fails to decode that boolean properly since it thinks it's a string

What 🌱

This error is thrown when trying to decode defaultConfigurationIsVisible

error: typeMismatch(Swift.String, Swift.DecodingError.Context(codingPath: [CodingKeys(stringValue: "defaultConfigurationIsVisible", intValue: nil)], debugDescription: "Expected to decode String but found a number instead.", underlyingError: nil))

Proposal 🎉

https://github.com/tuist/XcodeProj/pull/593

closed time in 5 days

tjwio

issue commenttuist/XcodeProj

How to see instance of .xcodeproj in debugger

Hey @carsten-wenderdel would you mind sharing your use-case? I'm not sure I understand why you need to have XcodeProj in LLDB.

carsten-wenderdel

comment created time in 5 days

PR closed tuist/XcodeProj

iOS Support

Short description 📝

For iOS Application Unit Tests is necessary to verify pbxproj setup. In our case we have unit tests run on each Pull Request and some of build settings is necessary to be unmodified (Code Signing, Active Compilation Conditions, Optimisation Levels etc)

Solution 📦

Add iOS support

+10 -2

2 comments

4 changed files

azonov

pr closed time in 5 days

pull request commenttuist/XcodeProj

iOS Support

Hey @azonov. I don't think XcodeProj should have support for iOS because it's not a dependency that you include in the app. If what you'd like to do is to lint your projects, I'd recommend creating your own Swift CLI script that has XcodeProj as a dependency and that you run from your CI pipeline.

azonov

comment created time in 5 days

pull request commenttuist/XcodeProj

iOS Support

Codecov Report

Merging #595 (fd36f8f) into main (82bf5ef) will increase coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #595      +/-   ##
==========================================
+ Coverage   84.24%   84.27%   +0.03%     
==========================================
  Files         154      154              
  Lines        8663     8610      -53     
==========================================
- Hits         7298     7256      -42     
+ Misses       1365     1354      -11     
Impacted Files Coverage Δ
Sources/XcodeProj/Extensions/Path+Extras.swift 87.09% <ø> (ø)
Sources/XcodeProj/Extensions/String+md5.swift 6.94% <100.00%> (+1.02%) :arrow_up:
...ests/Objects/Project/PBXProjIntegrationTests.swift 98.80% <100.00%> (+0.10%) :arrow_up:
Sources/XcodeProj/Errors/Errors.swift 23.61% <0.00%> (-12.50%) :arrow_down:
Sources/XcodeProj/Scheme/XCScheme.swift 53.73% <0.00%> (-7.47%) :arrow_down:
Sources/XcodeProj/Objects/Project/PBXObjects.swift 77.00% <0.00%> (-1.93%) :arrow_down:
Sources/XcodeProj/Utils/CommentedString.swift 92.75% <0.00%> (-0.40%) :arrow_down:
...es/XcodeProj/Objects/Project/PBXObjectParser.swift 90.16% <0.00%> (-0.16%) :arrow_down:
Sources/XcodeProj/Utils/ReferenceGenerator.swift 92.89% <0.00%> (-0.04%) :arrow_down:
Sources/XcodeProj/Utils/Decoders.swift 100.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 82bf5ef...fd36f8f. Read the comment docs.

azonov

comment created time in 5 days

PR opened tuist/XcodeProj

iOS Support

Short description 📝

For iOS Application Unit Tests is necessary to verify pbxproj setup. In our case we have unit tests run on each Pull Request and some of build settings is necessary to be unmodified (Code Signing, Active Compilation Conditions, Optimisation Levels etc)

Solution 📦

Add iOS support

+10 -2

0 comment

4 changed files

pr created time in 5 days

push eventfwal/setup-swift

Frederik Wallner

commit sha 3f3f6832c315576c9fac258e6059a413c827141c

Run more often and test both v1 and main

view details

dependabot[bot]

commit sha 0a3e4cbae37b99eac368a6354d2a482d3401bb43

Bump prettier from 2.1.2 to 2.2.0 Bumps [prettier](https://github.com/prettier/prettier) from 2.1.2 to 2.2.0. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/master/CHANGELOG.md) - [Commits](https://github.com/prettier/prettier/compare/2.1.2...2.2.0) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 5 days

more