profile
viewpoint

coolljt0725/docker2oci 16

A tool convert docker image to oci image

fuweid/Awesome-Networking 1

A curated list of awesome networking libraries, resources and shiny things

fuweid/2019-talks 0

Slides and links for 2019 talks

fuweid/accelerated-container-image 0

accelerated-container-image

fuweid/amazon-ecr-containerd-resolver 0

The Amazon ECR containerd resolver is an implementation of a containerd Resolver and Fetcher that can pull images from and push images to Amazon ECR using the Amazon ECR API instead of the Docker Registry API.

fuweid/aufs 0

AUFS Snapshotter for containerd

fuweid/bbolt 0

An embedded key/value database for Go.

fuweid/bcc 0

BCC - Tools for BPF-based Linux IO analysis, networking, monitoring, and more

fuweid/bench-fmountat 0

fmountat vs rmountat

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

push eventfuweid/containerd

Wei Fu

commit sha 1e07a57aaa8e84d0ab2cb17437e03fce73952ce9

feature: support image pull progress timeout Kubelet sends the PullImage request without timeout, because the image size is unknown and timeout is hard to defined. The pulling request might run into 0B/s speed, if containerd can't receive any packet in that connection. For this case, the containerd should cancel the PullImage request. Although containerd provides ingester manager to track the progress of pulling request, for example `ctr image pull` shows the console progress bar, it needs more CPU resources to open/read the ingested files to get status. In order to support progress timeout feature with lower overhead, this patch uses http.RoundTripper wrapper to track active progress. That wrapper will increase active-request number and return the countingReadCloser wrapper for http.Response.Body. Each bytes-read can be count and the active-request number will be descreased when the countingReadCloser wrapper has been closed. For the progress tracker, it can check the active-request number and bytes-read at intervals. If there is no any progress, the progress tracker should cancel the request. NOTE: For each blob data, the containerd will make sure that the content writer is opened before sending http request to the registry. Therefore, the progress reporter can rely on the active-request number. fixed: #4984 Signed-off-by: Wei Fu <fuweid89@gmail.com>

view details

push time in 5 days

push eventfuweid/containerd

haoyun

commit sha fa6759ae5378e5332f4ef5d4f2baca2bdef48115

fix: server error return Signed-off-by: haoyun <yun.hao@daocloud.io>

view details

Fu Wei

commit sha b6b8facf15564cae080e2bd74bbb25c90eb83cab

Merge pull request #6272 from jonyhy96/fix-error-return

view details

Nashwan Azhari

commit sha cb1359fa8b129778db5f1fa339b588f86734b02b

Integration: Remove explicit version passing to `azure/CLI`. In the Windows CI's periodic runs the `azure/CLI` GitHub action library is leveraged to run various Azure-related commands. To avoid possible desyncing between the auth libraries of `azure/Login` and `azure/CLI` as described [here](https://github.com/Azure/cli/issues/56#issuecomment-958705517), this patch neglects to pass an explicit `azcliversion` to `azure/CLI` in order to have it default to the Azure CLI version set up by `azure/Login`. Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>

view details

Takumasa Sakao

commit sha 2b28dd363bfd1d83c8aa43cd989731058f7a1a52

Fix wrong make target on documentation Signed-off-by: Takumasa Sakao <sakataku7@gmail.com>

view details

Phil Estes

commit sha 51e60404aec6f6646d65e8ba0e821e2aed7ca3ef

Merge pull request #6276 from sachaos/feature/fix-wrong-document-about-make-install-deps Fix wrong make target on documentation

view details

Shiming Zhang

commit sha 9dfbcbbc481076a8ae8d81c654ff452334e049fb

content/local: Close the file if Seek fails Signed-off-by: Shiming Zhang <wzshiming@foxmail.com>

view details

Phil Estes

commit sha 72384a6531bf309d5238712607058bbca4d09755

Merge pull request #6268 from aznashwan/windows-ci-autodetect-az-cli Integration: Remove explicit version passing to `azure/CLI`.

view details

Maksym Pavlenko

commit sha cf6f19cea0030dbf21716602a612168db7cad551

Merge pull request #6280 from wzshiming/fix/close-with-seek-fail content/local: Close the file if Seek fails

view details

haoyun

commit sha 507bfc91ba5537c7275633cdca49326540d80e49

feat: skip ci for fork Signed-off-by: haoyun <yun.hao@daocloud.io>

view details

Phil Estes

commit sha 0a284fcdbc459aff76230ed980a0e27f69340096

Merge pull request #6284 from jonyhy96/feat-ci-skip-fork feat: skip ci for fork

view details

Samuel Karp

commit sha 9a994877cc6e380cff6793a0b0d8c134eb37a1e4

docs: fix RELEASES.md gRPC API anchor Signed-off-by: Samuel Karp <skarp@amazon.com>

view details

Samuel Karp

commit sha 3d318b3bb42c81b20e1643dd2265146c1e728fec

docs: mark 1.4 as Extended Signed-off-by: Samuel Karp <skarp@amazon.com>

view details

Akihiro Suda

commit sha ff1a105d7f18808520b6fe26e1b54beb92c8378b

Merge pull request #6287 from samuelkarp/1.4-extended-docs releases: mark 1.4 as Extended

view details

Wei Fu

commit sha 8de1117c99fd35b13c6c5105f52f4adca6114717

integration: add stats result in error message ``` // from https://github.com/containerd/containerd/pull/6150#issuecomment-974747473 container_stats_test.go:364: Error Trace: container_stats_test.go:364 Error: Received unexpected error: unexpected stats length github.com/containerd/containerd/integration.TestContainerListStatsWithIdSandboxIdFilter.func4 /home/runner/work/containerd/containerd/integration/container_stats_test.go:371 github.com/containerd/containerd/integration.Eventually /home/runner/work/containerd/containerd/integration/main_test.go:324 github.com/containerd/containerd/integration.TestContainerListStatsWithIdSandboxIdFilter /home/runner/work/containerd/containerd/integration/container_stats_test.go:364 testing.tRunner /opt/hostedtoolcache/go/1.17.3/x64/src/testing/testing.go:1259 runtime.goexit /opt/hostedtoolcache/go/1.17.3/x64/src/runtime/asm_amd64.s:1581 Test: TestContainerListStatsWithIdSandboxIdFilter ``` Add stats result for the purpose of debug. Signed-off-by: Wei Fu <fuweid89@gmail.com>

view details

push time in 5 days

push eventfuweid/containerd

Wei Fu

commit sha 1b759bd4dbfcb7e64a0b1378c922a7f77f7ad1b0

feature: support image pull progress timeout Kubelet sends the PullImage request without timeout, because the image size is unknown and timeout is hard to defined. The pulling request might run into 0B/s speed, if containerd can't receive any packet in that connection. For this case, the containerd should cancel the PullImage request. Although containerd provides ingester manager to track the progress of pulling request, for example `ctr image pull` shows the console progress bar, it needs more CPU resources to open/read the ingested files to get status. In order to support progress timeout feature with lower overhead, this patch uses http.RoundTripper wrapper to track active progress. That wrapper will increase active-request number and return the countingReadCloser wrapper for http.Response.Body. Each bytes-read can be count and the active-request number will be descreased when the countingReadCloser wrapper has been closed. For the progress tracker, it can check the active-request number and bytes-read at intervals. If there is no any progress, the progress tracker should cancel the request. NOTE: For each blob data, the containerd will make sure that the content writer is opened before sending http request to the registry. Therefore, the progress reporter can rely on the active-request number. fixed: #4984 Signed-off-by: Wei Fu <fuweid89@gmail.com>

view details

push time in 5 days

push eventfuweid/containerd

Wei Fu

commit sha 81a23972519c92bac47c44c55abf3f5713456e91

feature: support image pull progress timeout Kubelet sends the PullImage request without timeout, because the image size is unknown and timeout is hard to defined. The pulling request might run into 0B/s speed, if containerd can't receive any packet in that connection. For this case, the containerd should cancel the PullImage request. Although containerd provides ingester manager to track the progress of pulling request, for example `ctr image pull` shows the console progress bar, it needs more CPU resources to open/read the ingested files to get status. In order to support progress timeout feature with lower overhead, this patch uses http.RoundTripper wrapper to track active progress. That wrapper will increase active-request number and return the countingReadCloser wrapper for http.Response.Body. Each bytes-read can be count and the active-request number will be descreased when the countingReadCloser wrapper has been closed. For the progress tracker, it can check the active-request number and bytes-read at intervals. If there is no any progress, the progress tracker should cancel the request. NOTE: For each blob data, the containerd will make sure that the content writer is opened before sending http request to the registry. Therefore, the progress reporter can rely on the active-request number. fixed: #4984 Signed-off-by: Wei Fu <fuweid89@gmail.com>

view details

push time in 5 days

push eventfuweid/containerd

Wei Fu

commit sha 70e628b3f3fc98d9570dbf65ee145d8cf77c95e6

feature: support image pull progress timeout Kubelet sends the PullImage request without timeout, because the image size is unknown and timeout is hard to defined. The pulling request might run into 0B/s speed, if containerd can't receive any packet in that connection. For this case, the containerd should cancel the PullImage request. Although containerd provides ingester manager to track the progress of pulling request, for example `ctr image pull` shows the console progress bar, it needs more CPU resources to open/read the ingested files to get status. In order to support progress timeout feature with lower overhead, this patch uses http.RoundTripper wrapper to track active progress. That wrapper will increase active-request number and return the countingReadCloser wrapper for http.Response.Body. Each bytes-read can be count and the active-request number will be descreased when the countingReadCloser wrapper has been closed. For the progress tracker, it can check the active-request number and bytes-read at intervals. If there is no any progress, the progress tracker should cancel the request. NOTE: For each blob data, the containerd will make sure that the content writer is opened before sending http request to the registry. Therefore, the progress reporter can rely on the active-request number. fixed: #4984 Signed-off-by: Wei Fu <fuweid89@gmail.com>

view details

push time in 5 days

pull request commentcontainerd/containerd

integration: add stats result in error message

    default: === Failed
    default: === FAIL: . TestContentClient/CommitErrorState (10.31s)
    default:     testsuite.go:118: Cleanup failed: unknown
    default:         github.com/containerd/containerd/errdefs.init
    default:         	/vagrant/errdefs/errors.go:43
    default:         runtime.doInit
    default:         	/usr/local/go/src/runtime/proc.go:6498
    default:         runtime.doInit
    default:         	/usr/local/go/src/runtime/proc.go:6475
    default:         runtime.doInit
    default:         	/usr/local/go/src/runtime/proc.go:6475
    default:         runtime.doInit
    default:         	/usr/local/go/src/runtime/proc.go:6475
    default:         runtime.doInit
    default:         	/usr/local/go/src/runtime/proc.go:6475
    default:         runtime.doInit
    default:         	/usr/local/go/src/runtime/proc.go:6475
    default:         runtime.main
    default:         	/usr/local/go/src/runtime/proc.go:238
    default:         runtime.goexit
    default:         	/usr/local/go/src/runtime/asm_amd64.s:1581
    default:         unlinkat /var/lib/containerd-test/io.containerd.content.v1.content/ingest/9101c5f249b4cb38a50dddda86a787c09f31099573c87c525fc50774ac21d05d: directory not empty
    default:         github.com/containerd/containerd/errdefs.FromGRPC
    default:         	/vagrant/errdefs/grpc.go:107
    default:         github.com/containerd/containerd/content/proxy.(*proxyContentStore).Abort
    default:         	/vagrant/content/proxy/content_store.go:187
    default:         github.com/containerd/containerd/integration/client.newContentStore.func2
    default:         	/vagrant/integration/client/content_test.go:61
    default:         github.com/containerd/containerd/content/testsuite.makeTest.func1.1
    default:         	/vagrant/content/testsuite/testsuite.go:117
    default:         github.com/containerd/containerd/content/testsuite.makeTest.func1
    default:         	/vagrant/content/testsuite/testsuite.go:138
    default:         testing.tRunner
    default:         	/usr/local/go/src/testing/testing.go:1259
    default:         runtime.goexit
    default:         	/usr/local/go/src/runtime/asm_amd64.s:1581
    default:         failed to abort c1-commiterror-state
    default:         github.com/containerd/containerd/integration/client.newContentStore.func2
    default:         	/vagrant/integration/client/content_test.go:62
    default:         github.com/containerd/containerd/content/testsuite.makeTest.func1.1
    default:         	/vagrant/content/testsuite/testsuite.go:117
    default:         github.com/containerd/containerd/content/testsuite.makeTest.func1
    default:         	/vagrant/content/testsuite/testsuite.go:138
    default:         testing.tRunner
    default:         	/usr/local/go/src/testing/testing.go:1259
    default:         runtime.goexit
    default:         	/usr/local/go/src/runtime/asm_amd64.s:1581
fuweid

comment created time in 5 days

push eventfuweid/containerd

Wei Fu

commit sha 7d996ecfd941e16fbc37d40e99430866d3ad2d31

feature: Support image pull progress timeout Kubelet sends the PullImage request without timeout, because the image size is unknown and timeout is hard to defined. The pulling request might run into 0B/s speed, if containerd can't receive any packet in that connection. For this case, the containerd should cancel the PullImage request. Although containerd provides ingester manager to track the progress of pulling request, for example `ctr image pull` shows the console progress bar, it needs more CPU resources to open/read the ingested files to get status. In order to support progress timeout feature with lower overhead, this patch uses http.RoundTripper wrapper to track active progress. That wrapper will increase active-request number and return the countingReadCloser wrapper for http.Response.Body. Each bytes-read can be count and the active-request number will be descreased when the countingReadCloser wrapper has been closed. For the progress tracker, it can check the active-request number and bytes-read at intervals. If there is no any progress, the progress tracker should cancel the request. NOTE: For each blob data, the containerd will make sure that the content writer is opened before sending http request to the registry. Therefore, the progress reporter can rely on the active-request number. fixed: #4984 Signed-off-by: Wei Fu <fuweid89@gmail.com>

view details

push time in 5 days

push eventfuweid/containerd

haoyun

commit sha fa6759ae5378e5332f4ef5d4f2baca2bdef48115

fix: server error return Signed-off-by: haoyun <yun.hao@daocloud.io>

view details

Fu Wei

commit sha b6b8facf15564cae080e2bd74bbb25c90eb83cab

Merge pull request #6272 from jonyhy96/fix-error-return

view details

Nashwan Azhari

commit sha cb1359fa8b129778db5f1fa339b588f86734b02b

Integration: Remove explicit version passing to `azure/CLI`. In the Windows CI's periodic runs the `azure/CLI` GitHub action library is leveraged to run various Azure-related commands. To avoid possible desyncing between the auth libraries of `azure/Login` and `azure/CLI` as described [here](https://github.com/Azure/cli/issues/56#issuecomment-958705517), this patch neglects to pass an explicit `azcliversion` to `azure/CLI` in order to have it default to the Azure CLI version set up by `azure/Login`. Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>

view details

Takumasa Sakao

commit sha 2b28dd363bfd1d83c8aa43cd989731058f7a1a52

Fix wrong make target on documentation Signed-off-by: Takumasa Sakao <sakataku7@gmail.com>

view details

Phil Estes

commit sha 51e60404aec6f6646d65e8ba0e821e2aed7ca3ef

Merge pull request #6276 from sachaos/feature/fix-wrong-document-about-make-install-deps Fix wrong make target on documentation

view details

Shiming Zhang

commit sha 9dfbcbbc481076a8ae8d81c654ff452334e049fb

content/local: Close the file if Seek fails Signed-off-by: Shiming Zhang <wzshiming@foxmail.com>

view details

Phil Estes

commit sha 72384a6531bf309d5238712607058bbca4d09755

Merge pull request #6268 from aznashwan/windows-ci-autodetect-az-cli Integration: Remove explicit version passing to `azure/CLI`.

view details

Maksym Pavlenko

commit sha cf6f19cea0030dbf21716602a612168db7cad551

Merge pull request #6280 from wzshiming/fix/close-with-seek-fail content/local: Close the file if Seek fails

view details

haoyun

commit sha 507bfc91ba5537c7275633cdca49326540d80e49

feat: skip ci for fork Signed-off-by: haoyun <yun.hao@daocloud.io>

view details

Phil Estes

commit sha 0a284fcdbc459aff76230ed980a0e27f69340096

Merge pull request #6284 from jonyhy96/feat-ci-skip-fork feat: skip ci for fork

view details

Samuel Karp

commit sha 9a994877cc6e380cff6793a0b0d8c134eb37a1e4

docs: fix RELEASES.md gRPC API anchor Signed-off-by: Samuel Karp <skarp@amazon.com>

view details

Samuel Karp

commit sha 3d318b3bb42c81b20e1643dd2265146c1e728fec

docs: mark 1.4 as Extended Signed-off-by: Samuel Karp <skarp@amazon.com>

view details

Akihiro Suda

commit sha ff1a105d7f18808520b6fe26e1b54beb92c8378b

Merge pull request #6287 from samuelkarp/1.4-extended-docs releases: mark 1.4 as Extended

view details

Wei Fu

commit sha f6f243eaff3fa2a8507071258b83a585c31dbff3

feature: Support image pull progress timeout Kubelet sends the PullImage request without timeout, because the image size is unknown and timeout is hard to defined. The pulling request might run into 0B/s speed, if containerd can't receive any packet in that connection. For this case, the containerd should cancel the PullImage request. Although containerd provides ingester manager to track the progress of pulling request, for example `ctr image pull` shows the console progress bar, it needs more CPU resources to open/read the ingested files to get status. In order to support progress timeout feature with lower overhead, this patch uses http.RoundTripper wrapper to track active progress. That wrapper will increase active-request number and return the countingReadCloser wrapper for http.Response.Body. Each bytes-read can be count and the active-request number will be descreased when the countingReadCloser wrapper has been closed. For the progress tracker, it can check the active-request number and bytes-read at intervals. If there is no any progress, the progress tracker should cancel the request. NOTE: For each blob data, the containerd will make sure that the content writer is opened before sending http request to the registry. Therefore, the progress reporter can rely on the active-request number. fixed: #4984 Signed-off-by: Wei Fu <fuweid89@gmail.com>

view details

push time in 5 days

pull request commentcontainerd/containerd

ctr/snapshots/diff: show media-type in stderr

@estesp @dmcgowan sorry for late reply. I agreed to remove the output. It seems that it is not necessary. Updated.

fuweid

comment created time in 5 days

push eventfuweid/containerd

Wei Fu

commit sha 6681cc4b943439bb788d6ac968d875cf93bc8b84

ctr/snapshots/diff: don't show the media-type in output By default, diff subcommand will print tar(.gz) on stdout. If we print the media-type in stdout, the output will create invalid tar(.gz) data. ``` // before ➜ containerd git:(move_stdout_to_stderr) sudo ctr snapshot diff sha256:9f54eef412758095c8079ac465d494a2872e02e90bf1fb5f12a1641c0d1bb78b > /tmp/1.tar ➜ containerd git:(move_stdout_to_stderr) file /tmp/1.tar /tmp/1.tar: data // after change ➜ containerd git:(move_stdout_to_stderr) make bin/ctr + bin/ctr ➜ containerd git:(move_stdout_to_stderr) sudo bin/ctr snapshot diff sha256:9f54eef412758095c8079ac465d494a2872e02e90bf1fb5f12a1641c0d1bb78b > /tmp/2.tar ➜ containerd git:(move_stdout_to_stderr) file /tmp/2.tar /tmp/2.tar: gzip compressed data, original size modulo 2^32 75155456 ``` Signed-off-by: Wei Fu <fuweid89@gmail.com>

view details

push time in 5 days

startedengula/engula

started time in 5 days

startedalibaba/hybridnet

started time in 10 days

push eventcontainerd/containerd

haoyun

commit sha fa6759ae5378e5332f4ef5d4f2baca2bdef48115

fix: server error return Signed-off-by: haoyun <yun.hao@daocloud.io>

view details

Fu Wei

commit sha b6b8facf15564cae080e2bd74bbb25c90eb83cab

Merge pull request #6272 from jonyhy96/fix-error-return

view details

push time in 11 days

PR merged containerd/containerd

fix: server error return needs-ok-to-test

The return error should ber.err

+1 -1

2 comments

1 changed file

jonyhy96

pr closed time in 11 days

PullRequestReviewEvent

pull request commentcontainerd/containerd

feature: Support image pull progress timeout

time="2021-11-21T03:34:25.856933279Z" level=error msg="unable to migrate tasks" error="failed to remove `state` dir: remove /run/containerd-test/io.containerd.runtime-shim.v2.shim: directory not empty"

From action log: https://pipelines.actions.githubusercontent.com/G4SighzWVVZ6vsyiz7FFMFjLjRzveJHseEnVyibkSq87Cl2x4O/_apis/pipelines/1/runs/8986/signedlogcontent/72?urlExpires=2021-11-21T03%3A50%3A54.3262074Z&urlSigningMethod=HMACV1&urlSignature=Yu4AYbMFTGtGyfclQDJaPDDL6zh32xBb20utU%2BCf5aI%3D

fuweid

comment created time in 12 days

PR opened containerd/containerd

ctr/snapshots/diff: show media-type in stderr

By default, diff subcommand will print tar(.gz) on stdout. If we print the media-type in stdout, the output will create invalid tar(.gz) data.

// before
➜  containerd git:(move_stdout_to_stderr) sudo ctr snapshot diff sha256:9f54eef412758095c8079ac465d494a2872e02e90bf1fb5f12a1641c0d1bb78b > /tmp/1.tar
➜  containerd git:(move_stdout_to_stderr) file /tmp/1.tar
/tmp/1.tar: data

// after change
➜  containerd git:(move_stdout_to_stderr) make bin/ctr
+ bin/ctr
➜  containerd git:(move_stdout_to_stderr) sudo bin/ctr snapshot diff sha256:9f54eef412758095c8079ac465d494a2872e02e90bf1fb5f12a1641c0d1bb78b > /tmp/2.tar
media-type: application/vnd.oci.image.layer.v1.tar+gzip

➜  containerd git:(move_stdout_to_stderr) file /tmp/2.tar
/tmp/2.tar: gzip compressed data, original size modulo 2^32 75155456

Signed-off-by: Wei Fu fuweid89@gmail.com

+1 -1

0 comment

1 changed file

pr created time in 12 days

create barnchfuweid/containerd

branch : move_stdout_to_stderr

created branch time in 12 days

PR opened containerd/containerd

integration: add stats result in error message
// from  https://github.com/containerd/containerd/pull/6150#issuecomment-974747473

container_stats_test.go:364:
        	Error Trace:	container_stats_test.go:364
        	Error:      	Received unexpected error:
        	            	unexpected stats length
        	            	github.com/containerd/containerd/integration.TestContainerListStatsWithIdSandboxIdFilter.func4
        	            		/home/runner/work/containerd/containerd/integration/container_stats_test.go:371
        	            	github.com/containerd/containerd/integration.Eventually
        	            		/home/runner/work/containerd/containerd/integration/main_test.go:324
        	            	github.com/containerd/containerd/integration.TestContainerListStatsWithIdSandboxIdFilter
        	            		/home/runner/work/containerd/containerd/integration/container_stats_test.go:364
        	            	testing.tRunner
        	            		/opt/hostedtoolcache/go/1.17.3/x64/src/testing/testing.go:1259
        	            	runtime.goexit
        	            		/opt/hostedtoolcache/go/1.17.3/x64/src/runtime/asm_amd64.s:1581
        	Test:       	TestContainerListStatsWithIdSandboxIdFilter

Add stats result for the purpose of debug.

Signed-off-by: Wei Fu fuweid89@gmail.com

+1 -1

0 comment

1 changed file

pr created time in 12 days

create barnchfuweid/containerd

branch : enhance_test_case

created branch time in 12 days

push eventfuweid/containerd

Olli Janatuinen

commit sha 2a81c9f6771eb8c94c7979cc8f2683e2b780d432

CRI: Support enable_unprivileged_icmp and enable_unprivileged_ports options Signed-off-by: Olli Janatuinen <olli.janatuinen@gmail.com>

view details

haoyun

commit sha 547040cd5b7df652e8af46e5034adbe2130a01f1

feat:support custom callopts on client side Signed-off-by: haoyun <yun.hao@daocloud.io>

view details

Justin Terry

commit sha 63895de45578272b1c7bca89c2b1265070f113b9

Add support for TMP override on toml When running containerd as a service it may be hard to override the TMP location of the process. This is especially true on Windows when running containerd in SCM. This change allows you to set the 'temp' location in the config.toml when the service starts up that overrides its TEMP/TMP/TMPDIR usage. This is helpful on Linux as well but it primarily solves the performance issue on Windows when running containerd across volumes. IE: If you configure your data/root paths on a volume other than the SystemDrive the snapshotter does a temporary unpack on the SystemDrive and then has to copy contents of that data to the snapshot folder on the destination volume. By alinging the tmp with the destination it is a simple move operation instead of a copy operation. Signed-off-by: Justin Terry <jlterry@amazon.com>

view details

haoyun

commit sha f8d734e406c3f7cf84b3689486a07f31df8152e8

fix: make max recv/send msg size setting default Signed-off-by: haoyun <yun.hao@daocloud.io>

view details

Michael Crosby

commit sha aa2733c202077e8f0b4ca23f09e0e806d7980234

Merge pull request #6170 from olljanat/default-sysctls CRI: Support enable_unprivileged_icmp and enable_unprivileged_ports options

view details

Derek McGowan

commit sha 5df9ec366595f8fdd9c0220b8c8a7a3247e1602e

Update release name to use consistent format Signed-off-by: Derek McGowan <derek@mcg.dev>

view details

Derek McGowan

commit sha f5863e22f419f9c59ed11e3919863b6cbabce085

Update API version in go.mod Signed-off-by: Derek McGowan <derek@mcg.dev>

view details

Derek McGowan

commit sha 674b94c42bc0bf43c12cd90f5673e0639de063da

Prepare release notes for v1.6.0-beta.3 Signed-off-by: Derek McGowan <derek@mcg.dev>

view details

Maksym Pavlenko

commit sha af93ea7f1e7706132843a0104e9628d8c093f74a

Merge pull request #6241 from jterry75/main Add support for TMP override on toml

view details

wanglei01

commit sha 5f293d9ac42a645e50d21ea2e872de9b1e823e64

[CRI] Fix panic when registry.mirrors use localhost When containerd use this config: ``` [plugins."io.containerd.grpc.v1.cri".registry.mirrors] [plugins."io.containerd.grpc.v1.cri".registry.mirrors."localhost:5000"] endpoint = ["http://localhost:5000"] ``` Due to the `newTransport` function does not initialize the `TLSClientConfig` field. Then use `TLSClientConfig` to cause nil pointer dereference Signed-off-by: wanglei <wllenyj@linux.alibaba.com>

view details

Fu Wei

commit sha 69822aa936a1068b331f63c910fa8a3983f31d96

Merge pull request #6258 from wllenyj/fix-registry-panic

view details

Derek McGowan

commit sha db9c6fc72276a93baa056e30fb8c30ec3b86f7a2

Merge pull request #6254 from jonyhy96/feat-support-callopts feat:support custom callopts on client side

view details

Derek McGowan

commit sha 1a88cf5242445657258e0c744def5017d7cfb492

Merge pull request #6267 from dmcgowan/prepare-v1.6.0-beta.3 Prepare release notes for v1.6.0-beta.3

view details

Wei Fu

commit sha 73b9bdeb484f33c5afe10a3a155b3a6080b56240

feature: Support image pull progress timeout Kubelet sends the PullImage request without timeout, because the image size is unknown and timeout is hard to defined. The pulling request might run into 0B/s speed, if containerd can't receive any packet in that connection. For this case, the containerd should cancel the PullImage request. Although containerd provides ingester manager to track the progress of pulling request, for example `ctr image pull` shows the console progress bar, it needs more CPU resources to open/read the ingested files to get status. In order to support progress timeout feature with lower overhead, this patch uses http.RoundTripper wrapper to track active progress. That wrapper will increase active-request number and return the countingReadCloser wrapper for http.Response.Body. Each bytes-read can be count and the active-request number will be descreased when the countingReadCloser wrapper has been closed. For the progress tracker, it can check the active-request number and bytes-read at intervals. If there is no any progress, the progress tracker should cancel the request. NOTE: For each blob data, the containerd will make sure that the content writer is opened before sending http request to the registry. Therefore, the progress reporter can rely on the active-request number. fixed: #4984 Signed-off-by: Wei Fu <fuweid89@gmail.com>

view details

push time in 12 days

pull request commentcontainerd/containerd

feature: Support image pull progress timeout

=== Failed
=== FAIL: gc/scheduler TestTrigger (0.01s)
    scheduler_test.go:135: GC wait timed out
    container_stats_test.go:364: 
        	Error Trace:	container_stats_test.go:364
        	Error:      	Received unexpected error:
        	            	unexpected stats length
        	            	github.com/containerd/containerd/integration.TestContainerListStatsWithIdSandboxIdFilter.func4
        	            		/home/runner/work/containerd/containerd/integration/container_stats_test.go:371
        	            	github.com/containerd/containerd/integration.Eventually
        	            		/home/runner/work/containerd/containerd/integration/main_test.go:324
        	            	github.com/containerd/containerd/integration.TestContainerListStatsWithIdSandboxIdFilter
        	            		/home/runner/work/containerd/containerd/integration/container_stats_test.go:364
        	            	testing.tRunner
        	            		/opt/hostedtoolcache/go/1.17.3/x64/src/testing/testing.go:1259
        	            	runtime.goexit
        	            		/opt/hostedtoolcache/go/1.17.3/x64/src/runtime/asm_amd64.s:1581
        	Test:       	TestContainerListStatsWithIdSandboxIdFilter

It seems there are two flaky test cases.

fuweid

comment created time in 12 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

pull request commentcontainerd/containerd

feat: add timeout for bolt open

But for the timeout value, it is hard to make it right. It depends on IO/Memeory/CPU pressures. That is why I don't suggest to add timeout here.

@fuweid If I understand it right, with timeout change, containerd will stuck on bolt.Open and eventually will return an error. In this case systemd will be able to restart it, same way as with signal? But we'll get a clear reason of what went wrong.

systemd has default timeout(=90s maybe longer) if it doesn't receive ready notification.

Checked the boltdb.flock. It uses LOCK_NB and will fast return error ideally. Agree that timeout error can show the flock is hold by other process. To be honest, this timeout setting makes containerd so hard to deploy with. How to parameterize the timeout is a question, because we don't know what will happen when restarting containerd in high load. Maybe we can make default value is no timeout and let ops admin to make a call.

Just my two cents.

jonyhy96

comment created time in 14 days

more