profile
viewpoint
Frieder Bluemle friederbluemle @walmartlabs Santa Clara, CA

fbluemle/android-quality-template 8

A sample project that illustrates integration of code quality tools.

friederbluemle/analytics-android 1

The hassle-free way to add analytics to your Android app.

fbluemle/sampleapp-react-native 0

A sample React Native app with simple CI integrations

friederbluemle/.tmux 0

🇫🇷 Oh My Tmux! Pretty & versatile tmux configuration / customization made with ❤️

create barnchfriederbluemle/toolbar-android

branch : update-project

created branch time in 7 hours

push eventfriederbluemle/react-native

Samuel Susla

commit sha 34ff9b7259e77f271c156bd75b837d4890ba9c81

Add view hierarchy drawings to tests Summary: Changelog: [Internal] Add view hierachy drawings to tests to make it easier to picture view hierarchy. The sketches do not reflect sizing but relationship among the views. I removed unnecessary reset of transform value to identity matrix. Reviewed By: JoshuaGross, shergin Differential Revision: D22456267 fbshipit-source-id: 480d0b938ffd0281fc94148570c412b0fcc22f42

view details

Héctor Ramos

commit sha 120ff7ccdebebdf814e478259ba1e4a8ef6f513e

Disable Detox tests on Circle CI (#29329) Summary: Disabling Detox tests on Circle CI as the `test_ios_detox*` tests have been broken for a while. Changelog: [Internal] Test Plan: Verified these no longer trigger on Circle CI Reviewed By: cpojer Differential Revision: D22476861 Pulled By: hramos fbshipit-source-id: 3d46786cd7d088d363409e4d35a327e3e997a227

view details

Dan Abramov

commit sha ac87e90fa517676440c1adf9575cb48f90de8069

Update React Hooks rule Summary: Includes better support for optional chaining. Changelog: [General][Changed] - Updated the React Hooks ESLint Plugin Reviewed By: rickhanlonii, trueadm Differential Revision: D22479305 fbshipit-source-id: 08740449ea797ce0971ccae358eb7de1ae102d7d

view details

Rick Hanlon

commit sha 8e6e83be0cf232aa299e64367fb223e4ce28d512

Switch to react-shallow-renderer Summary: Replace react-test-renderer/shallow with react-shallow-renderer. We should follow up with teams to remove these tests because they will no longer be supported. I would have just removed them but test like `BillingReauthorizeCreditCardContainer-test` seem important. Changelog: [Internal] Reviewed By: cpojer Differential Revision: D22225642 fbshipit-source-id: a6bd559311422cb14576a574165ed7dc0279919d

view details

push time in 12 hours

push eventfriederbluemle/vscode-docs

Frieder Bluemle

commit sha 17296d7837ecf1900491c78f0602f5a38eb52bc3

Fix capitalization of GitHub org `github.com/Microsoft` -> `github.com/microsoft`

view details

Greg Van Liew

commit sha f413a540e02051961967c65e7d3877480fd6bca8

Fix date typo in the event mention

view details

Greg Van Liew

commit sha 4c338753168bd2ec76335c4f236038bbb26022f1

Merge pull request #3851 from friederbluemle/fix-caps Fix capitalization of GitHub org

view details

Greg Van Liew

commit sha 4ccdad4db8b455235b427317571d06d71c8696b1

Remote step-by-step remote tutorials

view details

Greg Van Liew

commit sha 04709a3ced6f9c96d65c2ef89f61ceaf197a9e50

Add Notebook API and events to sitemap

view details

João Moreno

commit sha 3167c0a716468a9a51e1a5b9cf1b4b34bafe9dd4

Update v1_47.md

view details

João Moreno

commit sha 9925c6659ddc4a48747f79896faaa98bf16788e7

Update v1_47.md

view details

UcheNkadiCode

commit sha 444c2961d81c8bbe7dbae7772699d3c32c35b5f8

added clarity to location of the inspectMode property

view details

Greg Van Liew

commit sha f12fc01ff340dc60fe31b25321b1e0214a0d3ce3

Merge pull request #3862 from ucheNkadiCode/nodeRevision added clarity to location of the inspectMode property

view details

push time in 16 hours

delete branch friederbluemle/vscode-docs

delete branch : fix-caps

delete time in 16 hours

push eventfriederbluemle/wide-github

Frieder Bluemle

commit sha 1eb469077ae6e5261753f9d36227ba2fff00120b

Fix GitHub spelling

view details

Jacob Wirth

commit sha 01d4f99cfa1b501687f5f675129422eea8083877

Merge pull request #59 from friederbluemle/fix-typos Fix GitHub spelling

view details

push time in 16 hours

delete branch friederbluemle/wide-github

delete branch : fix-typos

delete time in 16 hours

push eventfriederbluemle/reactotron

joe goodall

commit sha 24d7ad805900fafab76bc764860a0c054e6f4ba2

Update plugin-redux-saga.md (#1190)

view details

push time in 16 hours

push eventfriederbluemle/react-native-code-push

Frieder Bluemle

commit sha 6ae9392d81eb5a8377664681da7ca673e630c481

Fix capitalization of GitHub org (#1888)

view details

Igor Krasavin

commit sha 69fe187be22b9b919baa81db1809ffe771c2de45

Update docs for using video component (#1900)

view details

push time in 16 hours

push eventfriederbluemle/ernnavigation-api-impl-native

Deepu Ganapathiyadan

commit sha 72537a0c8592c2ab9f7d71c1065d0795ab89d12b

Remove ComponentAsOverlay interface This is now replaced with NavigationRouteHandler for a more reusable approach

view details

@Deepu

commit sha 3ccb0c5d7844771f40b4e8c3a36e4bde521b107d

Merge pull request #127 from deepueg/remove-overlay-interface Remove ComponentAsOverlay interface

view details

Deepu Ganapathiyadan

commit sha a00d982918f03602c34f592711ec7a0765add1de

Remove root view instance reference from fragment delegate

view details

Deepu Ganapathiyadan

commit sha 142a6c277ee45f9e08f258118a1b3f2206d93740

Add UI flow to validate custom fragment implementation

view details

@Deepu

commit sha 7911314ef2b2a5212f9190ea641d63bbd410f852

Merge pull request #128 from deepueg/fix-view-instance Fix view instance

view details

Deepu Ganapathiyadan

commit sha 60595eabc5a0649b7e0afb1e2216792d63c2478e

v1.4.6

view details

push time in 16 hours

push eventfriederbluemle/electrode-native

Benoit Lemaire

commit sha 57640cad746d2b8eba60157de09236d07a5a801d

Fix hermes default version for RN63+

view details

Benoit Lemaire

commit sha 9a9004091a590384f1db8831bd2e4dbe8119cc95

Merge pull request #1690 from belemaire/fix-hermes-versionrn63 Fix hermes default version for RN63+

view details

push time in 16 hours

push eventfriederbluemle/vscode-react-native

Frieder Bluemle

commit sha f6fb2d2adc2271ddeb5737d81bbbd05f2e623c96

Fix capitalization of GitHub org (#1324)

view details

push time in 18 hours

delete branch friederbluemle/rushstack

delete branch : fix-caps

delete time in 18 hours

push eventfriederbluemle/rushstack

David Michon

commit sha 439f3ace62a95be77164c6415876beaaa6d6e0c9

Initial iteration of ModuleMinifierPlugin

view details

David Michon

commit sha 4619ec7e33dbbc637e34c97a3afe6dc8530dae80

Define basic Minifier implementations

view details

David Michon

commit sha a1221dfc55c235b0ce2383c755a2b933fbb89c9e

Remove unnecessary namespace import

view details

David Michon

commit sha afa6338e6ae2418a1da77cc5ad2c099a60105434

Add copyright headers

view details

David Michon

commit sha 00b2967010086e14e2d7ba025a8769262c47f7d7

Refactor, add examples

view details

David Michon

commit sha 7df5c7e5849a996474106eaacb55e62922905d48

Tweak dependencies

view details

David Michon

commit sha 427399b211d909634b116b84e9c25a4bb9449edd

Move RequestShortener tampering to stableids

view details

David Michon

commit sha ac84bc8e8f517521d2e038c69976c3da6a94014e

Fix Named modules

view details

David Michon

commit sha 755943d74fab6eee4b8f96a3ad7359c7d3ec73fb

Stop minifying non-js assets

view details

David Michon

commit sha 419d7643428223fe32bf7aa4305e58a5ea8b7a13

Use in loc example

view details

David Michon

commit sha 1aba06347d793c1da2d88d577a049e6cc71f7721

Revise minified identifier, attribution

view details

David Michon

commit sha 002a4e2b13c23168ad2cb2470955c1a5b30e13a6

Update comments

view details

David Michon

commit sha 66d2a6843c3d4ba71cb931807e494c086d5da18a

Add source map support

view details

David Michon

commit sha 2d9783c5a8e492e280c84b55832c7afe65493f39

Fix rehydrate for leading commas

view details

David Michon

commit sha 9419c6c4c305588ab568ef745170281de44489a6

Control source maps enabling

view details

David Michon

commit sha 6540c73054227c1f4aba87181b18072af4f52362

Refine source maps

view details

David Michon

commit sha 4a5a3f735b8b5b1e273929cb15f99db0c6b5e0b3

Use module minifier in scenario 2

view details

David Michon

commit sha 0013e0edaf9236e64ccd700e6b5e70a7ebbf82ae

Tune displayed sources in maps

view details

David Michon

commit sha c52083e1444fe2b18044699dbe7c76073cca221f

Publish module-minifier-plugin

view details

David Michon

commit sha 507b2ae4840663eda1debc6891ecb3d1666e4322

Refine source maps for discoverability

view details

push time in 18 hours

pull request commentmicrosoft/rushstack

Fix capitalization of GitHub org

@octogonz Haha, well it's something that's still contained in many repos, and a remnant from the time when the Microsoft GitHub org still contained upper-case characters. It just sticks out like a sore thumb ;)

Rebased the branch.

friederbluemle

comment created time in 20 hours

push eventfriederbluemle/rushstack

Pete Gonzalez

commit sha 6ca1618e244fa5ebbb6071fc11b9389025a12187

Upgrade Rush

view details

Pete Gonzalez

commit sha 431fcd9ba9cddc294c87fdb48e5762de14eb57ee

Delete some deadwood files

view details

adventure-yunfei

commit sha 9ac8a2e29f9ecb372e01ba073b627e3c2a48e6a8

fix case: export { default } from "foo";

view details

Pete Gonzalez

commit sha 162da7d4075365079c146a25fe83fb0af3cab807

Merge pull request #2013 from microsoft/octogonz/rush-5.28.0 Upgrade to Rush 5.28.0

view details

Pete Gonzalez

commit sha acbdf9a54c545fe50f43a1da19979b0b47d780b2

Add a unit test that repros issue #2014

view details

Pete Gonzalez

commit sha 5ab7be928d841761a0d472f1f957e7ebeb9f5482

Test @adventure-yunfei's approach

view details

Pete Gonzalez

commit sha 64bff06a4cafbd88e71ffbbb36e26e6658761cd8

Improved solution: use _makeUniqueNames() to rename "default"

view details

Pete Gonzalez

commit sha c18c9d33fc54881f5dd60b9cd904dd4af5e44162

rush change

view details

Pete Gonzalez

commit sha 8b7e463a3b526d34b5cbdb9015408f6ed94f4b73

Merge pull request #2016 from adventure-yunfei/fix/reexport-default

view details

Rushbot

commit sha 994869c2aa408dff8ee33d80df5c1c2b63493d4b

Deleting change files and updating change logs for package updates.

view details

Rushbot

commit sha e072acfacdb3979b55f5f4f7e5ebd2e53b6a2c31

Applying package updates.

view details

Frieder Bluemle

commit sha 2f9bc7e8b5a49026a00affd98a59d5758752aacb

Fix capitalization of GitHub org `github.com/Microsoft` -> `github.com/microsoft`

view details

push time in 20 hours

push eventfriederbluemle/rushstack

Pete Gonzalez

commit sha 6ca1618e244fa5ebbb6071fc11b9389025a12187

Upgrade Rush

view details

Pete Gonzalez

commit sha 431fcd9ba9cddc294c87fdb48e5762de14eb57ee

Delete some deadwood files

view details

adventure-yunfei

commit sha 9ac8a2e29f9ecb372e01ba073b627e3c2a48e6a8

fix case: export { default } from "foo";

view details

Pete Gonzalez

commit sha 162da7d4075365079c146a25fe83fb0af3cab807

Merge pull request #2013 from microsoft/octogonz/rush-5.28.0 Upgrade to Rush 5.28.0

view details

Pete Gonzalez

commit sha acbdf9a54c545fe50f43a1da19979b0b47d780b2

Add a unit test that repros issue #2014

view details

Pete Gonzalez

commit sha 5ab7be928d841761a0d472f1f957e7ebeb9f5482

Test @adventure-yunfei's approach

view details

Pete Gonzalez

commit sha 64bff06a4cafbd88e71ffbbb36e26e6658761cd8

Improved solution: use _makeUniqueNames() to rename "default"

view details

Pete Gonzalez

commit sha c18c9d33fc54881f5dd60b9cd904dd4af5e44162

rush change

view details

Pete Gonzalez

commit sha 8b7e463a3b526d34b5cbdb9015408f6ed94f4b73

Merge pull request #2016 from adventure-yunfei/fix/reexport-default

view details

Rushbot

commit sha 994869c2aa408dff8ee33d80df5c1c2b63493d4b

Deleting change files and updating change logs for package updates.

view details

Rushbot

commit sha e072acfacdb3979b55f5f4f7e5ebd2e53b6a2c31

Applying package updates.

view details

push time in 21 hours

push eventfriederbluemle/react-native

Jordan Brown

commit sha a5151c2b5f6f03896eb7d9df873c5f61a706f055

Deploy 0.129 to xplat/js Summary: Changelog: [Internal] Deploy 0.129 to xplat allow-large-files Reviewed By: dsainati1 Differential Revision: D22439823 fbshipit-source-id: 60edf32abcb6e134363cee9ec9b23657a8fe0fae

view details

Eloy Durán

commit sha ffa3d7f638c820dc208320193e6ba65667d751eb

Build macOS framework and add CocoaPods podspec (#285) Summary: Supersedes https://github.com/facebook/hermes/issues/239 Currently used in our macOS fork of React Native https://github.com/microsoft/react-native-macos/pull/473. (Although we’re using a build of Hermes v0.4.1, as we’re at RN 0.62.0.) * On Apple platforms build a [dynamic] framework bundle when `HERMES_BUILD_APPLE_FRAMEWORK` is set. When set to `FALSE` it will produce a `dylib`, like previously. Defaults to `TRUE`. * On Apple platforms create a debugging symbols bundle. * Add `HERMES_ENABLE_FUZZING`, which is enabled by default. * Add `HERMES_ENABLE_TEST_SUITE`, which is enabled by default. * Add a CocoaPods podspec that can build from source or use a binary. A standalone macOS app that pulls in Hermes as a CocoaPods pod can be found here https://github.com/alloy/TestHermesMaster. ## Framework variant (default) ``` $ ./src/utils/build/configure.py --distribute --cmake-flags='-DCMAKE_INSTALL_PREFIX:PATH=../destroot_release' build $ cd build && ninja install && cd .. $ tree destroot_release/ destroot_release/ ├── Library │ └── Frameworks │ ├── hermes.framework │ │ ├── Headers -> Versions/Current/Headers │ │ ├── Resources -> Versions/Current/Resources │ │ ├── Versions │ │ │ ├── 0 │ │ │ │ ├── Headers │ │ │ │ │ ├── CompileJS.h │ │ │ │ │ ├── DebuggerAPI.h │ │ │ │ │ ├── Public │ │ │ │ │ │ ├── Buffer.h │ │ │ │ │ │ ├── CrashManager.h │ │ │ │ │ │ ├── CtorConfig.h │ │ │ │ │ │ ├── DebuggerTypes.h │ │ │ │ │ │ ├── GCConfig.h │ │ │ │ │ │ ├── GCTripwireContext.h │ │ │ │ │ │ └── RuntimeConfig.h │ │ │ │ │ ├── SynthTrace.h │ │ │ │ │ ├── SynthTraceParser.h │ │ │ │ │ ├── TraceInterpreter.h │ │ │ │ │ ├── TracingRuntime.h │ │ │ │ │ ├── hermes.h │ │ │ │ │ └── hermes_tracing.h │ │ │ │ ├── Resources │ │ │ │ │ └── Info.plist │ │ │ │ └── hermes │ │ │ └── Current -> 0 │ │ └── hermes -> Versions/Current/hermes │ └── hermes.framework.dSYM │ └── Contents │ ├── Info.plist │ └── Resources │ └── DWARF │ └── hermes ├── bin │ ├── hbcdump │ ├── hdb │ ├── hermes │ ├── hermesc │ └── hvm └── include ├── hermes │ ├── CompileJS.h │ ├── DebuggerAPI.h │ ├── Public │ │ ├── Buffer.h │ │ ├── CrashManager.h │ │ ├── CtorConfig.h │ │ ├── DebuggerTypes.h │ │ ├── GCConfig.h │ │ ├── GCTripwireContext.h │ │ └── RuntimeConfig.h │ ├── SynthTrace.h │ ├── SynthTraceParser.h │ ├── TraceInterpreter.h │ ├── TracingRuntime.h │ ├── hermes.h │ └── hermes_tracing.h └── jsi ├── JSIDynamic.h ├── decorator.h ├── instrumentation.h ├── jsi-inl.h ├── jsi.h ├── jsilib.h └── threadsafe.h ``` # dylib variant ``` $ ./src/utils/build/configure.py --distribute --cmake-flags='-DHERMES_BUILD_APPLE_FRAMEWORK:BOOLEAN=false -DCMAKE_INSTALL_PREFIX:PATH=../destroot_release' build $ cd build && ninja install && cd .. $ tree destroot_release/ destroot_release/ ├── bin │ ├── hbcdump │ ├── hdb │ ├── hermes │ ├── hermesc │ └── hvm ├── include │ ├── hermes │ │ ├── CompileJS.h │ │ ├── DebuggerAPI.h │ │ ├── Public │ │ │ ├── Buffer.h │ │ │ ├── CrashManager.h │ │ │ ├── CtorConfig.h │ │ │ ├── DebuggerTypes.h │ │ │ ├── GCConfig.h │ │ │ ├── GCTripwireContext.h │ │ │ └── RuntimeConfig.h │ │ ├── SynthTrace.h │ │ ├── SynthTraceParser.h │ │ ├── TraceInterpreter.h │ │ ├── TracingRuntime.h │ │ ├── hermes.h │ │ └── hermes_tracing.h │ └── jsi │ ├── JSIDynamic.h │ ├── decorator.h │ ├── instrumentation.h │ ├── jsi-inl.h │ ├── jsi.h │ ├── jsilib.h │ └── threadsafe.h └── lib ├── libhermes.dylib └── libhermes.dylib.dSYM └── Contents ├── Info.plist └── Resources └── DWARF └── libhermes.dylib ``` Pull Request resolved: https://github.com/facebook/hermes/pull/285 Reviewed By: willholen Differential Revision: D22398354 Pulled By: mhorowitz fbshipit-source-id: 732524275cf273866171fc6e2ac2acb062185fbd

view details

Rick Hanlon

commit sha f28c7505fa5b4a7ddf1e9311d38dfcd15e8953a2

Fix LogBox.ignoreAllLogs used with no argument (#29310) Summary: When you call `LogBox.ignoreAllLogs()` it should ignore logs. This fixes a bug that made this equivalent to `LogBox.ignoreAllLogs(false)` ## Changelog [General] [Fixed] - LogBox.ignoreAllLogs() should ignore logs Pull Request resolved: https://github.com/facebook/react-native/pull/29310 Test Plan: Added tests Reviewed By: TheSavior Differential Revision: D22448436 Pulled By: rickhanlonii fbshipit-source-id: 6ba12b9d9c1f29cf3ac503946ac5ca0097425a7a

view details

Santiago Alfonso Muñoz Rodriguez

commit sha 193003926132407fdf65be1729b080db620548f2

Move CameraRoll Android files to FB Internal Summary: Changelog: [Lean Core][Android] Removed CameraRoll from RN Android Reviewed By: RSNara Differential Revision: D22410115 fbshipit-source-id: 5cdb5b87a7bf5b4a8a4c2953c14ba3751b125d07

view details

Tim Yung

commit sha ae193942feaaacb6511d198c0199bfc3b7bfdbfd

RN: Remove `fbjs/{keyMirror,keyOf}` Dependencies Summary: Removes `fbjs/keyMirror` and `fbjs/keyOf` call sites from React Native. Changelog: [Internal] Reviewed By: cpojer Differential Revision: D22438238 fbshipit-source-id: 0f84b6e9d81811f95a2a24886f38ad16b8e6e74f

view details

Tim Yung

commit sha caf010914c5b3124d76562e624dd4936c96f049c

RN: Remove `fbjs/performanceNow` Dependency Summary: Replaces `fbjs/performanceNow` call sites in React Native with `performance.now`. We did not originally polyfill this in `InitializeCore`, but now we do (and back it with a proper `nativePerformanceNow` implementation). Also, added the missing polyfill to our Jest setup. Changelog: [Internal] Reviewed By: cpojer Differential Revision: D22445948 fbshipit-source-id: dcfd9867c050617f6e2a3d0a1eb6f48a44771dda

view details

Ramanpreet Nara

commit sha e549f6984e2125969fd11a5b8f4e2df866ac0495

Gate TurboModule eager initialization Summary: TurboModule eager initialization is a bit dangerous if we get it wrong, which we did (twice): T69449176. This diff gates TurboModule eager init behind a MC, so that we can control (i.e: turn off/on, and do gradually rollout of) TurobModule eager initialization in isolation from the larger TurboModules experiment. Changelog: [Internal] Reviewed By: PeteTheHeat Differential Revision: D22460359 fbshipit-source-id: 3b8dce0529f1739bd68b8b16d6a28aa572d82c2c

view details

Joshua Gross

commit sha 3503d722a18dc6c0781232e164c82b8097786082

Fix race between teardown and PreAllocateView/CreateView MountItem creation Summary: Commits can happen during navigation/teardown which creates mount items. If we throw an exception during teardown because we expect the Context to still be around, we crash too often. Instead, I will rely on logic in FabricUIManager to ignore queued MountItems if we try to execute them after the surface has been torn down; and we move the IllegalStateException to actual execution of the mount item in case there's an edge-case we're missing. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D22470102 fbshipit-source-id: ad98c03994969a3c3f300d6551e90b6516ed2d8b

view details

David Vacca

commit sha d5bc0a7bff36f6ed4a7b4a71b9e4bcef6bccdf01

Fix inconsistency on AndroidTextInput view configs Summary: BubblingEventTypes are inconsistent between AndroidTextInputViewConfig.js and ReactTextInputManager.java, this diff fixes this inconsistency changelog: [internal] Reviewed By: JoshuaGross Differential Revision: D22470096 fbshipit-source-id: 3940dcc0ae67a42ac070c06ec2d54bc365eab6b7

view details

push time in a day

push eventfriederbluemle/electrode-native

Benoit Lemaire

commit sha 9a40b32836e00829eb362a5782a81f35d87893d3

Fix hermes binary name for hermes 0.5.0+

view details

Benoit Lemaire

commit sha a9f433e36aa6b333747500556f20b4678fb39076

Merge pull request #1691 from belemaire/fix-hermes-binary-name Fix hermes binary name for hermes 0.5.0+

view details

Benoit Lemaire

commit sha b40499aee8a5ceec1e7b6c78ed0463a60d4e7b89

:white_check_mark: Regenerate system test fixtures for RN 0.63.0

view details

Benoit Lemaire

commit sha 24ffdad5bfe5855fb25a73e4985588fedb727cd9

Merge pull request #1692 from belemaire/regen-st-rn63 Regenerate system test fixtures for RN 0.63.0

view details

push time in a day

PR opened react-native-community/react-native-video

Fix ESLint and enable basic CI

This enables a basic CI using GitHub Actions. Currently it runs yarn lint to check for lint errors.

ci

The rest of the changes are mostly automated lint fixes (yarn lint --fix).

<sub><sup>Once approved, please use a normal GitHub merge (i.e. NO rebase/squash merge) to integrate the commit(s) from the PR head branch. The changes are broken up into meaningful, atomic commits, and my branch should already be up-to-date with the latest base branch. If it isn't, or if you want me to change anything, please let me know, and I will update the branch as soon as possible. Thank you!</sup></sub>

+97 -89

0 comment

9 changed files

pr created time in a day

push eventfriederbluemle/react-native-video

Frieder Bluemle

commit sha 86d46c1ef75d1836c8b18ed883eace36310c2158

Remove duplicate LICENSE

view details

Frieder Bluemle

commit sha 6e00a3797ee0ff68d3e1c9a94e3097408e231dcd

Fix react-native peer deps

view details

Frieder Bluemle

commit sha 6ae4aceab70782dbfeb0987b278a07cfa293e675

Fix ESLint setup and errors

view details

Frieder Bluemle

commit sha ac141c946b78abe1e1e37a8d4750ebc72b9a6e20

Enable basic GitHub Actions CI

view details

push time in a day

create barnchfriederbluemle/react-native-video

branch : update-project

created branch time in a day

push eventfriederbluemle/electrode-native

Benoit Lemaire

commit sha c6d2ed5828581c47253974b3eaaf995b497dba60

Add svg import support

view details

Benoit Lemaire

commit sha 140b4808a3582df0150b1ffe7c691d6e2aae8442

Merge pull request #1683 from belemaire/svg Add svg import support

view details

Benoit Lemaire

commit sha fa03695dcfb5e8bb02f72fdf3deedc906e5d3db3

:bug: Fix a bug causing local miniapps to be included twice in container

view details

Benoit Lemaire

commit sha 52cc420cd3924902f521fc5dcf7a5374bc294436

Merge pull request #1685 from belemaire/fix-multi-local-miniapps Fix a bug causing local miniapps to be included twice in container

view details

Benoit Lemaire

commit sha b10eaae82750209ea8391ab033294f6bfa6a760c

:bug: Fix platform config set command for object values

view details

Benoit Lemaire

commit sha d337bd3b2e7327e103e2eb77b67ae42b96d07461

Merge pull request #1684 from belemaire/fix-set-config-object Fix "platform config set" command for object values

view details

Frieder Bluemle

commit sha dd6d66ff0425ca0ac44b6e244ad20b842d27fd78

Revert "Set Android container Gradle plugin to 3.5.2" This reverts commit 36b9472cc027955674dbe856ef78934d22881e8a.

view details

Frieder Bluemle

commit sha 26f3f9c74c91469ed08128ab45aa55df7fcee6f4

Set default Android Gradle plugin to 3.4.2

view details

Frieder Bluemle

commit sha 2d4575f4be645331d2a40c5cbb443e9c4d4f111a

Merge pull request #1682 from friederbluemle/container-gradle-version

view details

Benoit Lemaire

commit sha 1682cc7d6d98c6f7aa7c15f92186f9b5b1f17a98

Keep cauldron repositories sorted

view details

Benoit Lemaire

commit sha a192658be2794c5b25d1577b877a7fe336bc5e6a

Merge pull request #1686 from belemaire/cauldron-repo-sorted Keep cauldron repositories sorted

view details

Benoit Lemaire

commit sha 9a356d4b9898418d825f961abbf2e7d854fefe87

Guarantee miniapps import order in composite

view details

Benoit Lemaire

commit sha 674050fe1b164072bd9186fef1b58b64e40ade35

Merge pull request #1687 from belemaire/guarantee-composite-import-order Guarantee miniapps import order in composite

view details

Benoit Lemaire

commit sha 7c8c96c08105c6c935ea2e32dff3137097d83418

Set default hermes version for RN63+

view details

Benoit Lemaire

commit sha 89f0102efba3db019e44e6b4f8aa662c1aa12d38

Merge pull request #1688 from belemaire/bump-hermes-for-rn63 Set default hermes version for RN63+

view details

Jeffrey Wang

commit sha 6197479287f18cc92ce680bde7f7166a36efce89

Remove strong references for delegates

view details

Jeffrey Wang

commit sha 540e43adf4b2bec783d248dcdd6fda3f1fc6826a

Merge pull request #1689 from jw2175/riskyCode Remove strong references for delegates

view details

Benoit Lemaire

commit sha 9a40b32836e00829eb362a5782a81f35d87893d3

Fix hermes binary name for hermes 0.5.0+

view details

Benoit Lemaire

commit sha a9f433e36aa6b333747500556f20b4678fb39076

Merge pull request #1691 from belemaire/fix-hermes-binary-name Fix hermes binary name for hermes 0.5.0+

view details

Benoit Lemaire

commit sha b40499aee8a5ceec1e7b6c78ed0463a60d4e7b89

:white_check_mark: Regenerate system test fixtures for RN 0.63.0

view details

push time in 2 days

pull request commentelectrode-io/electrode-native

Fix hermes default version for RN63+

Haha I think we've had a similar one before? Good that there are some tests now 👍

belemaire

comment created time in 2 days

delete branch friederbluemle/vscode-react-native

delete branch : fix-caps

delete time in 2 days

pull request commentmicrosoft/vscode-docs

Fix capitalization of GitHub org

Resolved conflicts, rebased, and addressed comment.

friederbluemle

comment created time in 2 days

push eventfriederbluemle/vscode-docs

Ornella

commit sha 79f61d22bdfd9112fd2feb8719589591abf18144

Add 1.47 release notes placeholder

view details

Ornella

commit sha 4ced3afd76101496456f0e4e9bd4bd4de38434d1

Fix description

view details

Ornella

commit sha 44fe2dbc0a62b82bed2ba94657741d786d5a8c0a

Fix date and issue link

view details

Dirk Baeumer

commit sha d8ff7e4c4277c6778f5e94b77c0d617f619389b7

Mention PR

view details

Dirk Baeumer

commit sha a66d72746c380cc0006aa59a0f0ca8f2ca169796

Mention PR

view details

Dirk Baeumer

commit sha a1bdd46b4d0e3532b55f7f0d032d67cac72c6a1d

Mention PR

view details

Dirk Baeumer

commit sha 18c967545a2e5f97591ea7a6cbf709ea2a5ad8be

Mention PR

view details

Ornella

commit sha 17cc815d226420a28c888e3e5a2f7e23a8023f70

Add June iteration plan

view details

Ornella

commit sha 90518eb6f3d9df5633c3c2db58c7f8ba63f62059

Update 1.47 macOS keybindings

view details

Greg Van Liew

commit sha 7e1b0e1954dd3ccfa4b813e3f9c054ad5ec6e90a

Merge branch 'master' into vnext

view details

Dirk Baeumer

commit sha a8329dac643719d2b7b4f9fbdcd1890b7f57e8be

Mention PR

view details

Dirk Baeumer

commit sha 99dce6a96287acce9f84802910a2dc98ac416fa9

Mention PR

view details

Greg Van Liew

commit sha 68b5545e41cbc3070dfbed71c5cf42556a48f82b

Update 1.47 Windows keybindings

view details

Jackson Kearl

commit sha b2162c763d8c502049b2f2f835fb96da48995646

Add first pass of ContentProvider example/samples

view details

Jackson Kearl

commit sha 2f37afdd7b3e5b142606d0677917f15b982b8613

Add toc entry

view details

Jackson Kearl

commit sha 00d34ccf96826d95252026f2d5fc30a58bc92e93

Wording

view details

Jackson Kearl

commit sha 11b9f8805414cac9b630ad567793e7748cef928b

Spelling

view details

Jackson Kearl

commit sha 48120482c4966f264b57c0aa4e89c4aad31499ba

Wording

view details

Jackson Kearl

commit sha 07da230fe72fc84d08135da3c2b2f4ca9b6371e8

Flesh out Parts of a Notebook

view details

Jackson Kearl

commit sha 751b69633538a80cc6f5c871f8c884674323b4ed

Updates to overview

view details

push time in 2 days

push eventfriederbluemle/vscode-docs

Ornella

commit sha 79f61d22bdfd9112fd2feb8719589591abf18144

Add 1.47 release notes placeholder

view details

Ornella

commit sha 4ced3afd76101496456f0e4e9bd4bd4de38434d1

Fix description

view details

Ornella

commit sha 44fe2dbc0a62b82bed2ba94657741d786d5a8c0a

Fix date and issue link

view details

Dirk Baeumer

commit sha d8ff7e4c4277c6778f5e94b77c0d617f619389b7

Mention PR

view details

Dirk Baeumer

commit sha a66d72746c380cc0006aa59a0f0ca8f2ca169796

Mention PR

view details

Dirk Baeumer

commit sha a1bdd46b4d0e3532b55f7f0d032d67cac72c6a1d

Mention PR

view details

Dirk Baeumer

commit sha 18c967545a2e5f97591ea7a6cbf709ea2a5ad8be

Mention PR

view details

Ornella

commit sha 17cc815d226420a28c888e3e5a2f7e23a8023f70

Add June iteration plan

view details

Ornella

commit sha 90518eb6f3d9df5633c3c2db58c7f8ba63f62059

Update 1.47 macOS keybindings

view details

Greg Van Liew

commit sha 7e1b0e1954dd3ccfa4b813e3f9c054ad5ec6e90a

Merge branch 'master' into vnext

view details

Dirk Baeumer

commit sha a8329dac643719d2b7b4f9fbdcd1890b7f57e8be

Mention PR

view details

Dirk Baeumer

commit sha 99dce6a96287acce9f84802910a2dc98ac416fa9

Mention PR

view details

Greg Van Liew

commit sha 68b5545e41cbc3070dfbed71c5cf42556a48f82b

Update 1.47 Windows keybindings

view details

Jackson Kearl

commit sha b2162c763d8c502049b2f2f835fb96da48995646

Add first pass of ContentProvider example/samples

view details

Jackson Kearl

commit sha 2f37afdd7b3e5b142606d0677917f15b982b8613

Add toc entry

view details

Jackson Kearl

commit sha 00d34ccf96826d95252026f2d5fc30a58bc92e93

Wording

view details

Jackson Kearl

commit sha 11b9f8805414cac9b630ad567793e7748cef928b

Spelling

view details

Jackson Kearl

commit sha 48120482c4966f264b57c0aa4e89c4aad31499ba

Wording

view details

Jackson Kearl

commit sha 07da230fe72fc84d08135da3c2b2f4ca9b6371e8

Flesh out Parts of a Notebook

view details

Jackson Kearl

commit sha 751b69633538a80cc6f5c871f8c884674323b4ed

Updates to overview

view details

push time in 2 days

pull request commentmicrosoft/vscode-docs

Fix capitalization of GitHub org

Hi @friederbluemle Thank you for the PR. MicrosoftDocs is correctly cased so please revert those changes. MicrosoftDocs/vsonline

Nice catch! I'll fix it.

friederbluemle

comment created time in 2 days

pull request commentelectrode-io/electrode-native-manifest

Add react-native-video support

Thanks @belemaire - Yeah, I've seen the section in their readme, and had similar thoughts.

I was able to successfully run a test miniapp locally that plays a video. It uses the manifest as in this PR (i.e. using the Android MediaPlayer based player). However, when using the exoplayer variant config, container generation fails. I haven't dug into the details yet.

I guess a bigger question (not just for this library, also for camera and potentially others) is: How do we decide what the "default" is. In this case, I'm leaning towards the "older" Android MediaPlayer based player, simply because it's in the default "android" folder, and that's also what you'll get with RN autolinking, as well as manual linking. I could add a config-exoplayer.json as an alternative... In the future, do you think we should we have an easy way for ERN users to select a different variant (without requiring a whole manifest override)?

friederbluemle

comment created time in 2 days

push eventfriederbluemle/electrode-native-manifest

Benoit Lemaire

commit sha 0cf327c52722dc848ace4abbfc27b3a20e1cde75

Add react-native 0.63.0+ iOS config

view details

Benoit Lemaire

commit sha caacd330e3b8d455321a77290058ff7ae54e3eae

Merge pull request #178 from belemaire/add-rn63-ios-config Add react-native 0.63.0+ iOS config

view details

Benoit Lemaire

commit sha 0aa3488cace7be66407a5ffc4c6326ce8549f239

Remove Flipper from react-native 0.62.0+ Podfile

view details

Benoit Lemaire

commit sha 5062b10e4addb376abd09b43d4d06b9398d93366

Merge pull request #179 from belemaire/remove-flipper-rn62 Remove Flipper from react-native 0.62.0+ Podfile

view details

Benoit Lemaire

commit sha eb5f47edc6c4763830a90122e01e8dcbf44f9a55

Update development ern version to use RN 0.63.0

view details

Frieder Bluemle

commit sha 5b70bfe95b86cf1d802a9678f566082ff8d0af33

Add react-native-video support

view details

push time in 2 days

push eventfriederbluemle/electrode-native-manifest

Benoit Lemaire

commit sha 0cf327c52722dc848ace4abbfc27b3a20e1cde75

Add react-native 0.63.0+ iOS config

view details

Benoit Lemaire

commit sha caacd330e3b8d455321a77290058ff7ae54e3eae

Merge pull request #178 from belemaire/add-rn63-ios-config Add react-native 0.63.0+ iOS config

view details

Benoit Lemaire

commit sha 0aa3488cace7be66407a5ffc4c6326ce8549f239

Remove Flipper from react-native 0.62.0+ Podfile

view details

Benoit Lemaire

commit sha 5062b10e4addb376abd09b43d4d06b9398d93366

Merge pull request #179 from belemaire/remove-flipper-rn62 Remove Flipper from react-native 0.62.0+ Podfile

view details

Benoit Lemaire

commit sha eb5f47edc6c4763830a90122e01e8dcbf44f9a55

Update development ern version to use RN 0.63.0

view details

push time in 2 days

push eventfriederbluemle/electrode-native

Benoit Lemaire

commit sha 7c8c96c08105c6c935ea2e32dff3137097d83418

Set default hermes version for RN63+

view details

Benoit Lemaire

commit sha 89f0102efba3db019e44e6b4f8aa662c1aa12d38

Merge pull request #1688 from belemaire/bump-hermes-for-rn63 Set default hermes version for RN63+

view details

Jeffrey Wang

commit sha 6197479287f18cc92ce680bde7f7166a36efce89

Remove strong references for delegates

view details

Jeffrey Wang

commit sha 540e43adf4b2bec783d248dcdd6fda3f1fc6826a

Merge pull request #1689 from jw2175/riskyCode Remove strong references for delegates

view details

push time in 2 days

push eventfriederbluemle/exoplayer

andrewlewis

commit sha 28c5fa665f00bd1d16ee067474df2908b20a2f52

Improve ImaAdsLoaderTest ad duration handling Previously the fake ads loader listener would always pass the same ad durations to the fake player, but actually the known ad durations can change during playback. Make the fake behavior more realistic by only exposing durations for ads that have loaded. PiperOrigin-RevId: 314956223

view details

andrewlewis

commit sha 5d74fced1d261ff63b1868e317262e5e96fda89d

Add tests for resuming ad playbacks This is in preparation for refactoring the logic to support not playing an ad before the resume position (optionally). PiperOrigin-RevId: 315431483

view details

andrewlewis

commit sha 80f4197e0fc0a673f873a47eaaadfa4c58b181d7

Separate ads rendering and AdsManager init In a later change it will be necessary to be able to destroy the ads manager if all ads are skipped while creating ads rendering settings. This change prepares for doing that by not having the ads manager passed into the method (so the caller can null or initialize it). PiperOrigin-RevId: 315488830

view details

olly

commit sha e5ec8e6b474cd7e00719fdf986f2ec655bc5a866

Prevent shutter closing for within-window seeks to unprepared periods Issue: #5507 PiperOrigin-RevId: 315512207

view details

andrewlewis

commit sha e261b8d0ef8e0d35b3f4ec2d936ba08ce8a6d151

Allow skipping the ad before the start position PiperOrigin-RevId: 315867160

view details

andrewlewis

commit sha 8ab3fab4c13f247128ff125fe4c9615f050faf51

Fix catch type in ImaAdsLoader defensive checks PiperOrigin-RevId: 316079131

view details

andrewlewis

commit sha f1197d8af34f6b88d4b4dd908c7b57273be3c349

Handle errors in all VideoAdPlayer callbacks Some but not all VideoAdPlayer callbacks from the IMA SDK included defensive handling of unexpected cases. Add the remaining ones. Issue: #7492 PiperOrigin-RevId: 316082651

view details

andrewlewis

commit sha 1ce040003a3c385b0279ce6964aca07e881e1f38

Add AdPlaybackState toString This is useful for debugging both in tests and via logging. PiperOrigin-RevId: 316102968

view details

ibaker

commit sha a0e90ce1fff7dbe681c8e27ca094812799e74e35

Pull IMA cuePoints -> adGroupTimesUs logic into a helper class We're then able to use this same helper class from tests, to avoid running into spurious failures caused by long microseconds being round-tripped through float seconds. PiperOrigin-RevId: 316435084

view details

olly

commit sha 6e1c1973091cd59ae5536372699cd3b4b4f17ed3

Add MIME types for which every sample is known to be a sync sample. - Leaving the TODO, since there are still MIME types we're unsure about. - Removing AAC because xHE-AAC does not have this property. We may re-add it with an additional profile check to exclude xHE-AAC in the future. PiperOrigin-RevId: 316715147

view details

andrewlewis

commit sha 5fd287b340ba2c1e81c234831e6bda9347c0f644

Move IMA SDK callbacks into inner class The release() method was added in the recent IMA API changes for preloading and now 'collides' with the ExoPlayer AdsLoader release method. This led to all ads completing being treated as a call to completely release the ads loader, which meant that the ad playback state was not updated on resuming after all ads had completed, which in turn led to playback getting stuck buffering on returning from the background after all ads played. Move the IMA callbacks into an inner class to avoid this. Issue: #7508 PiperOrigin-RevId: 316834561

view details

andrewlewis

commit sha fc76dbfad4d2264ca4136c5545f5e82615ddfceb

Remove some ad playback state change requirements Ads can appear due to asynchronous ad tag requests completing after earlier ads in a pod have loaded, so remove the requirement that the ad count can't change. The MediaPeriodQueue should handling discarding buffered content if an ad appears before already buffered content, so I think this case is actually handled correctly by the core player already. Also remove the requirement that an ad URI can't change. This is a defensive measure for now, but it's likely that a later fix in the IMA SDK for an issue where loadAd is not called after preloading then seeking before a preloaded ad plays will result in loadAd being called more than once, and I think it's possible that the second call to loadAd may have a different URI. Because the ad URI should only change after an intermediate seek to another MediaPeriod, there shouldn't be any problems with buffered data not getting discarded. Issue: #7477 PiperOrigin-RevId: 316871371

view details

andrewlewis

commit sha 49951d4f8755245a8c8f8914cdc440ac7e9663be

Workaround unexpected discard of preloaded ad After an ad pod coming up has preloaded, if the user seeks before it plays we get pauseAd/stopAd called for that ad pod. Also, the ad will not load again. Work around this unexpected behavior by handling pauseAd/stopAd and discarding the ad. In future, it's likely that the IMA SDK will stop calling those methods, and will loadAd again for the preloaded ad that was unexpectedly discarded. This change should be compatible with that, because the ad won't be discarded any more due to not calling stopAd. Issue: #7492 PiperOrigin-RevId: 316873699

view details

Oliver Woodman

commit sha 99c03052784589cc8b25ce11e74a8b76a04b4fb6

Fix release notes

view details

olly

commit sha f39a65cb66a7cb79e2552513a146082d4f39a5cb

Bump version to 2.11.6 PiperOrigin-RevId: 316949571

view details

andrewlewis

commit sha 0ffe74707647aef90ba9d16ade156384e9f2586b

Fix incorrect rounding of ad cue points We currently get float ad cue points from IMA, but store these as longs in microseconds. The cast from double to long would take the floor of the value, which could lead to stored ad cue points being off-by-one. Use Math.round to avoid this. ImaAdsLoader also has code to map a double AdPodInfo position (which should match a cue point) onto the corresponding ad group index by searching the long ad cue points. Match the calculation used where we map float cue points, including narrowing the position to a float first to avoid regressions if IMA SDK behavior changes to represent positions in more than float precision later, and also remove the requirement that the ad positions match exactly as a defensive measure. PiperOrigin-RevId: 317607017

view details

andrewlewis

commit sha df10fdf773fae4715eed7593c04856b4fdc1e14f

Fix handling of postrolls preloading The IMA SDK now preloads postrolls which is great as we no longer need to rely on detecting buffering at the end of the stream to trigger playing postrolls. Add in the required logic to detect the period transition to playing the postroll. Issue: #7518 PiperOrigin-RevId: 317610682

view details

andrewlewis

commit sha 67c99e1d1146ddddec14cc6811775f0d483cd4d5

Fix resuming postrolls Postrolls would be skipped because the period duration wasn't know at the moment of resuming playback after backgrounding, so the position wouldn't be resolved to resume the postroll ad. We have the period duration stored in the AdPlaybackState, so we can use that directly. Issue: #7518 PiperOrigin-RevId: 317830418

view details

Oliver Woodman

commit sha 1a5b304b1faf244ea91e2b2aca8ea241aa237dd1

Merge pull request #7517 from google/dev-v2-r2.11.6 r2.11.6

view details

andrewlewis

commit sha ce8bb2680213da567798affe96bfdd6ca643f91b

Fix postroll content complete notifications On reaching the end of the content we would notify content complete and skip unplayed ads, causing a timeline change. That timeline change was handled in a way that caused a further timeline change in the 2.11.6 release, where we don't yet deduplicate no-op Timeline changes, causing repeated timeline changes indefinitely. At tip-of-tree, the timeline wouldn't refresh repeatedly. However the code for sending content complete at the point of transitioning to play a preloaded postroll ad was not correct in that it didn't mark previous ads as skipped. Instead they happened to be marked as skipped later on due to the timeline change handling content completion code triggering again. Fix this by only marking ads as skipped when content completes once, to avoid the duplicate timeline change, and moving the skipped ad marking so it happens in the same place as notifying content complete. PiperOrigin-RevId: 318454908

view details

push time in 2 days

Pull request review commentelectrode-io/electrode-native-manifest

Add react-native 0.63.0+ iOS config

+platform :ios, '10.0'

😲

belemaire

comment created time in 2 days

Pull request review commentelectrode-io/ern-container-transformer-build-config

Improve xcconfig file update

 import { readFile, writeFile, exists } from './fs-async' +

Minor: Double blank line here

belemaire

comment created time in 3 days

Pull request review commentelectrode-io/ern-container-transformer-build-config

Improve xcconfig file update

 export default class XCConfig {    * @param buildSettings The build settings to write to set in the xcconfig file    * @returns The buildSettings object that was provided to the method    */-  public async setBuildSettings(buildSettings: object): Promise<object> {-    const configFileContent = Object.keys(buildSettings)-      .map(k => `${k} = ${buildSettings[k]}`)-      .join('\n')-    await writeFile(this.filePath, configFileContent)-    return buildSettings-  }--  /**-   * Add or update existing build setting in the xcconfig file.-   * This method will only add new settings in the xcconfig file and-   * path existing ones. It will leave other settings untouched.-   * This is a non desctructing patching method.-   * If the xcconfig file does not exist, it will be created.-   * @param buildSettings The build settings to write to set in the xcconfig file-   * @returns The settings of the updated xcconfig file, as an object-   */-  public async addOrUpdateBuildSettings(-    newBuildSettings: object-  ): Promise<object> {-    if (!(await exists(this.filePath))) {-      return this.setBuildSettings(newBuildSettings)+  public async setBuildSettings(buildSettings: BuildSettings): Promise<BuildSettings> {+    let configFileContent = (await exists(this.filePath)) ? (await readFile(this.filePath)).toString() : ''+    if (configFileContent.length !== 0 && configFileContent[configFileContent.length-1] !== '\n') {+      // Make sure that we have a new line at end of file for proper appending

:) :+1:

belemaire

comment created time in 3 days

Pull request review commentitsnubix/react-native-video-controls

check for and set rate prop update in componentWillReceiveProps

 export default class VideoPlayer extends Component {             })         } +    	if (this.state.rate !== nextProps.rate) {+      	   this.setState({+        	rate: nextProps.rate+      	   });+    	}

These 5 lines contain a mix of spaces and tabs. Please replace with spaces only (like the rest of the file)

joeyscarim

comment created time in 3 days

push eventfriederbluemle/android-media-controller

Frieder Bluemle

commit sha f6152afe603a3d85e19084bb8a123a46e63cb3b4

Update .gitignore and ProGuard template

view details

Frieder Bluemle

commit sha 488ad187c7ca680ce28a8f44ba90c3f89a1459ae

Update Gradle Wrapper to 5.6.4

view details

Frieder Bluemle

commit sha 6e4a94c497cc0ac25af829db79cb064414698b61

Update Kotlin plugin and build scripts

view details

Lady Nicole

commit sha cce593b6ca8627c1a87dec135de42f8b42fe5758

Merge pull request #15 from friederbluemle/update-project Update Gradle Wrapper and build scripts

view details

push time in 3 days

delete branch friederbluemle/android-media-controller

delete branch : update-project

delete time in 3 days

push eventfriederbluemle/ApplicationInsights-node.js

Frieder Bluemle

commit sha f843973866b6966e96ad884bca746a99930eec91

Fix capitalization of GitHub org (#653)

view details

push time in 3 days

delete branch friederbluemle/ApplicationInsights-node.js

delete branch : fix-caps

delete time in 3 days

push eventfriederbluemle/react-native-video-controls

Frieder Bluemle

commit sha 890d2dab7c03c2fa7d8d09551912ac8f2fd4527e

Update .gitignore

view details

Frieder Bluemle

commit sha c2ac3a25e6caf7828a3f615b31b430102e1c8440

Add lint script

view details

Frieder Bluemle

commit sha 80f3d479971e5800fb596a1523d3a2f89a8a4b21

Fix Lint errors

view details

Frieder Bluemle

commit sha 7c045dab76e1961941c7c5927317be8d8492952f

Enable basic GitHub Actions CI

view details

Kyle Milloy

commit sha 2081b10573285e44b061a39994f58c7c894c30e9

Merge pull request #184 from friederbluemle/update-project Add lint script, enable basic CI

view details

push time in 3 days

delete branch friederbluemle/react-native-video-controls

delete branch : update-project

delete time in 3 days

push eventfriederbluemle/react-native

Hein Rutjes

commit sha cfa42605989eee5a9de42bdb1259fb7f4d9451fb

Add support for shadowColor on Android (API >= 28) (#28650) Summary: This PR adds support for the `shadowColor` style on Android. This is possible as of Android P using the `setOutlineAmbientShadowColor` and `setOutlineSpotShadowColor` View methods. The actual rendered color is a multiplication of the color-alpha, shadow-effect and elevation-value. ## Changelog `[Android] [Added] - Add support for shadowColor on API level >= 28` Pull Request resolved: https://github.com/facebook/react-native/pull/28650 Test Plan: - Only execute code on Android P - Added Android `BoxShadow` tests to RNTester app ![image](https://user-images.githubusercontent.com/6184593/79457137-fe627c80-7fef-11ea-8e88-3d9423a4f264.png) Reviewed By: mdvacca Differential Revision: D21125479 Pulled By: shergin fbshipit-source-id: 14dcc023977d7a9d304fabcd3c90bcf34482f137

view details

Ramanpreet Nara

commit sha e206e34175c091a753c0e733abeda41b662241d4

Add a warning if TurboModule init uses dispatch_sync for main queue Summary: When you require a TurboModule on thread that isn't the main thread, but the TurboModule requires main queue setup, we are forced to `dispatch_sync` the set up to the main queue. This is hazardous, because it can lead to deadlocks. Therefore, I'm migrating over a warning from the legacy infra that warns against this use-case. Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D21654637 fbshipit-source-id: 99dc45708c533603d2111fe6163d40e807d2a513

view details

push time in 3 days

PR opened electrode-io/electrode-native-manifest

Add react-native-video support

This adds support for react-native-video.

The only thing that a bit odd is that the project contains both an android and an android-exoplayer directory. I'll do some more quick testing around this and it should be ready for merge.

+47 -0

0 comment

2 changed files

pr created time in 3 days

push eventfriederbluemle/electrode-native-manifest

Frieder Bluemle

commit sha 0c5b0c91459d202d2895bf8b2124c4ceaa0c80e7

Add react-native-video support

view details

push time in 3 days

create barnchfriederbluemle/electrode-native-manifest

branch : add-rn-video

created branch time in 3 days

push eventfriederbluemle/electrode-native-manifest

Benoit Lemaire

commit sha b323e503f46e79a560a4a43b8f1321b791dada11

Add 0.42.x version entry

view details

Benoit Lemaire

commit sha 0c24e37a1bc1f0527d0190cabc709d2a71c3701b

Merge pull request #176 from belemaire/0.42 Add 0.42.x version entry

view details

push time in 3 days

delete branch friederbluemle/standardnotes-mobile

delete branch : theme-preference

delete time in 3 days

delete branch friederbluemle/standardnotes-mobile

delete branch : 004-refactor

delete time in 3 days

delete branch friederbluemle/standardnotes-mobile

delete branch : 004

delete time in 3 days

push eventfriederbluemle/vscode-react-native

JiglioNero

commit sha 3ea567c8ebd4d3fedd6d5724b770e071bbd97dc2

Add solution of entry point not exist error for Expo on macOS to Known issues for master branch (#1338) * Add solution of entry point not exist error for Expo on macOS to Known issues (#1337) * add lines to content of metro.config.json in smoke tests and add description of error to known issues in readme * Update README.md Co-authored-by: Yuri Skorokhodov <v-yuskor@microsoft.com> * Update test/smoke/package/src/helpers/setupEnvironmentHelper.ts Co-authored-by: Yuri Skorokhodov <v-yuskor@microsoft.com> * Update test/smoke/package/src/helpers/setupEnvironmentHelper.ts Co-authored-by: Yuri Skorokhodov <v-yuskor@microsoft.com> Co-authored-by: Yuri Skorokhodov <v-yuskor@microsoft.com> * Apply suggestions from code review Co-authored-by: RedMickey <33267199+RedMickey@users.noreply.github.com> Co-authored-by: Yuri Skorokhodov <v-yuskor@microsoft.com> Co-authored-by: RedMickey <33267199+RedMickey@users.noreply.github.com>

view details

push time in 3 days

push eventfriederbluemle/vscode-react-native

JiglioNero

commit sha 3ea567c8ebd4d3fedd6d5724b770e071bbd97dc2

Add solution of entry point not exist error for Expo on macOS to Known issues for master branch (#1338) * Add solution of entry point not exist error for Expo on macOS to Known issues (#1337) * add lines to content of metro.config.json in smoke tests and add description of error to known issues in readme * Update README.md Co-authored-by: Yuri Skorokhodov <v-yuskor@microsoft.com> * Update test/smoke/package/src/helpers/setupEnvironmentHelper.ts Co-authored-by: Yuri Skorokhodov <v-yuskor@microsoft.com> * Update test/smoke/package/src/helpers/setupEnvironmentHelper.ts Co-authored-by: Yuri Skorokhodov <v-yuskor@microsoft.com> Co-authored-by: Yuri Skorokhodov <v-yuskor@microsoft.com> * Apply suggestions from code review Co-authored-by: RedMickey <33267199+RedMickey@users.noreply.github.com> Co-authored-by: Yuri Skorokhodov <v-yuskor@microsoft.com> Co-authored-by: RedMickey <33267199+RedMickey@users.noreply.github.com>

view details

Frieder Bluemle

commit sha cb8367ea2cee6c69592350f5395da6f8889acab5

Fix capitalization of GitHub org

view details

push time in 3 days

PR opened microsoft/vscode-docs

Fix capitalization of GitHub org

github.com/Microsoft -> github.com/microsoft

+2998 -2998

0 comment

184 changed files

pr created time in 3 days

create barnchfriederbluemle/vscode-docs

branch : fix-caps

created branch time in 3 days

PR opened microsoft/rushstack

Reviewers
Fix capitalization of GitHub org

github.com/Microsoft -> github.com/microsoft

+10 -10

0 comment

6 changed files

pr created time in 3 days

fork friederbluemle/rushstack

Monorepo for tools developed by the Rush Stack community

https://rushstack.io/

fork in 3 days

PR opened microsoft/vscode-debugadapter-node

Fix capitalization of GitHub org

github.com/Microsoft -> github.com/microsoft

+18 -18

0 comment

9 changed files

pr created time in 3 days

create barnchfriederbluemle/vscode-debugadapter-node

branch : fix-caps

created branch time in 3 days

fork friederbluemle/vscode-debugadapter-node

Debug adapter protocol and implementation for VS Code.

fork in 3 days

fork friederbluemle/TACO

Tools for Apache Cordova

fork in 3 days

PR opened microsoft/vscode-uri

Fix capitalization of GitHub org

github.com/Microsoft -> github.com/microsoft

+6 -6

0 comment

3 changed files

pr created time in 3 days

create barnchfriederbluemle/vscode-uri

branch : fix-caps

created branch time in 3 days

fork friederbluemle/vscode-uri

The URI implementation that is used in VS Code and its extensions.

fork in 3 days

PR opened microsoft/ApplicationInsights-node.js

Fix capitalization of GitHub org

github.com/Microsoft -> github.com/microsoft

+15 -15

0 comment

5 changed files

pr created time in 3 days

push eventfriederbluemle/ApplicationInsights-node.js

Frieder Bluemle

commit sha 897de5c82a46ebc0e8973f6f5d2f62e824f55ecb

Fix capitalization of GitHub org `github.com/Microsoft` -> `github.com/microsoft`

view details

push time in 3 days

push eventfriederbluemle/ApplicationInsights-node.js

Frieder Bluemle

commit sha 2ba067c605d91a16c5bcbe7a8ffdda6187235771

Fix capitalization of GitHub org

view details

push time in 3 days

create barnchfriederbluemle/ApplicationInsights-node.js

branch : fix-caps

created branch time in 3 days

push eventfriederbluemle/react-native

Ramanpreet Nara

commit sha 5c24746a4837b785fa18831a3740a3a5bdd1f304

Correct JSRequireEnding marker start in RCTModuleData gatherConstants Summary: `RCTModuleData gatherConstants` is [used by `RCTModuleData exportedConstants` to compute and return the constants exported to JS](https://fburl.com/diffusion/ssg4jbeu). However, `RCTModuleData gatherConstants` is also [used by `RCTCxxBridge` to pre-compute NativeModule constants during bridge startup](https://fburl.com/diffusion/nfmjc1ke). Therefore, since `RCTModuleData gatherConstants` can be used outside the context of a JS require, we cannot start the JSRequireEnding marker inside `RCTModuleData gatherConstants` directly. This diff moves the body of `RCTModuleData gatherConstants` into `gatherConstantsAndSignalJSRequireEnding:(BOOL)startMarkers`: - `RCTModuleData gatherConstants` calls `RCTModuleData gatherConstantsAndSignalJSRequireEnding:NO` - `RCTModuleData exportedConstants` calls `RCTModuleData gatherConstantsAndSignalJSRequireEnding:YES`. **Note:** This is okay, because `RCTModuleData exportedConstants` is only called inside `RCTNativeModule::getConstants()`. This should make sure that we don't start the JSRequireEnding marker outside of a JS require. Reviewed By: PeteTheHeat Differential Revision: D22371889 fbshipit-source-id: de17b857259572fb0f840a22072a16b5e465cabd

view details

Ramanpreet Nara

commit sha 103c863eaa325b191107e58d59c64243f67d37cd

Eagerly initialize TurboModules before executing JS bundle Summary: ## Context 1. In FBReactModule jsExecutorForBridge, we asynchronously initialize a list of TurboModules on the main queue: https://fburl.com/diffusion/i56wi3px 2. After initializing the bridge, we start executing the JS bundle, here: https://github.com/facebook/react-native/blob/e23e9328aa164d0a70fe4f16042c982e7801d924/React/CxxBridge/RCTCxxBridge.mm#L414-L417. Since bridge initialization knows nothing about TurboModule eager initialization, this happens concurrently with 1, and starts requiring NativeModules/TurboModules on the JS thread. ## The Race 1. Both the main thread and the JS thread race to create a TurboModule that requires main queue setup. 2. The JS thread wins, and starts creating the TurboModule. Meanwhile, the main thread blocks, waiting on a signal here, in RCTTurboModuleManager: https://github.com/facebook/react-native/blob/e23e9328aa164d0a70fe4f16042c982e7801d924/ReactCommon/turbomodule/core/platform/ios/RCTTurboModuleManager.mm#L430 3. The JS thread tries to dispatch_sync to the main queue to setup the TurboModule because the TurboModule requires main queue setup, here: https://github.com/facebook/react-native/blob/e23e9328aa164d0a70fe4f16042c982e7801d924/ReactCommon/turbomodule/core/platform/ios/RCTTurboModuleManager.mm#L402 4. We deadlock. ## The fix Succinctly, NativeModule eager initialization finishes before execute the JS bundle, but TurboModule initialization doesn't. This diff corrects that mistake. The changes in this diff: 1. The RN application via the TurboModuleManager delegate can now optionally provide the names of all eagerly initialized TurboModules by implementing two methods `getEagerInitModuleNames`, `getEagerInitMainQueueModuleNames`. 2. The TurboModuleManager grabs these two lists from the delegate, and exposes them to its owner via the `RCTTurboModuleRegistry` protocol. 3. The RCTCxxBridge, which already owns a `id<RCTTurboModuleRegistry>` object, uses it to eagerly initialize the TurboModules in these two lists with the correct timing requirements. This is exactly how we implement eager initialization in Android. **Note:** Right now, phase one and two of TurboModule eager initialization happen after phase one and two of NativeModule eager initialization. We could make the timing even more correct by initializing the TurboModules at the exact same time we initialize the NativeModules. However, that would require a bit more surgery on the bridge, and the bridge delegate. I think this is good enough for now. Changelog: [iOS][Fixed] - Fix TurboModule eager init race Reviewed By: PeteTheHeat Differential Revision: D22406171 fbshipit-source-id: 4715be0bceb478a8e4aa206180c0316eaaf287e8

view details

Ramanpreet Nara

commit sha a27c295f5338cd7f68a6601b928f109574b91dc7

Rename RCTTurboModuleLookupDelegate to RCTTurboModuleRegistry Summary: ## Why? 1. RCTTurboModuleLookupDelegate sounds a bit nebulous. 2. In JS and Java, we use a `TurboModuleRegistry` interface to require TurboModules. So, this diff will make JS, Java, and ObjC consistent. Changelog: [Internal] Reviewed By: PeteTheHeat Differential Revision: D22405754 fbshipit-source-id: 30c85c246b39d198c5b8c6ca4432a3196ca0ebfd

view details

Ramanpreet Nara

commit sha e96f1e1d830d20f88f020afa9a34a8f3b710b30e

Refactor: Attach TurboModuleRegistry to bridge in FBReactModule Summary: The changes in this diff are inconsequential. Just thought it was weird that TurboModuleManager was responsible for assigning itself to the bridge. Seems like that should be done by an entity that owns both the bridge and the TurboModuleManager. Changelog: [Internal] Reviewed By: PeteTheHeat Differential Revision: D22406172 fbshipit-source-id: cb32f097f4d377a3b85a6d165b7b06be8e6a185b

view details

push time in 3 days

push eventfriederbluemle/electrode-native

Benoit Lemaire

commit sha 9a356d4b9898418d825f961abbf2e7d854fefe87

Guarantee miniapps import order in composite

view details

Benoit Lemaire

commit sha 674050fe1b164072bd9186fef1b58b64e40ade35

Merge pull request #1687 from belemaire/guarantee-composite-import-order Guarantee miniapps import order in composite

view details

push time in 3 days

PR opened itsnubix/react-native-video-controls

Add lint script, enable basic CI

Four quick commits here, adding a lint script calling the (already existing!) ESLint installation. Also fixed two minor lint errors in a separate commit.

Finally, added a minimal GitHub Actions CI, which runs lint with every pull request and merge to master.

ci

<sub><sup>Once approved, please use a normal GitHub merge (i.e. NO rebase/squash merge) to integrate the commit(s) from the PR head branch. The changes are broken up into meaningful, atomic commits, and my branch should already be up-to-date with the latest base branch. If it isn't, or if you want me to change anything, please let me know, and I will update the branch as soon as possible. Thank you!</sup></sub>

+31 -4

0 comment

6 changed files

pr created time in 3 days

create barnchfriederbluemle/react-native-video-controls

branch : update-project

created branch time in 3 days

fork friederbluemle/mobile

Standard Notes for iOS and Android - https://standardnotes.org

fork in 4 days

push eventfriederbluemle/copay

Gustavo Maximiliano Cortez

commit sha 9981d081e7feb5d9677c85d9cbf1c838e15dfabe

fix(home): update exchange rates and price on events resume/focus

view details

Gabriel Masclef

commit sha 8d71cf45176221ebff6d504d55987b0098b43cb6

Fix: dont remove needsBackup flag when testnet is created

view details

Gustavo Maximiliano Cortez

commit sha 54be6b8852ce5ea6adaaddb20b413ab5fe58552c

fix(coinbase): adds destrination_tag for xrp transactions

view details

Gustavo Maximiliano Cortez

commit sha 3d50cfd3a4215e937f436045942594583d4c884c

Merge pull request #10959 from Gamboster/fix/needsBackupTestnet Fix: don't remove needsBackup flag when testnet is created

view details

Gabriel Edgardo Bazán

commit sha 9c2140afd0873d2211c6b6504568c62a7386dc66

Merge pull request #10947 from cmgustavo/bug/update-home-prices-01 fix(home): update exchange rates and price on events resume/focus

view details

Gabriel Edgardo Bazán

commit sha c69281279e78179574314c5b9acac956eab1fe63

Merge pull request #10961 from cmgustavo/bug/coinbase-xrp-01 fix(coinbase): adds destrination_tag for xrp transactions

view details

Gustavo Maximiliano Cortez

commit sha 9d8c00a3e9d03e9aa9ed0cf9c405e276352cb66f

fix(desktop): adds padding-bottom on wallets view

view details

Gustavo Maximiliano Cortez

commit sha 3d6dcf2cb401636b53aa6bdc129b435a6e0acca8

fix(home-balance): Refresh balance when switching on from settings. Fix isoCode

view details

Gustavo Maximiliano Cortez

commit sha 03c475d63f6813eacb560e60132e3b59c7117b0f

fix(home): align arrows

view details

Gustavo Maximiliano Cortez

commit sha b786990793ff168feb67a918726a3ce34525a50a

ref(biometric): replace old biometric cordova plugin by a new one

view details

Gabriel

commit sha fdbfc6aaff733b685e93ba09794a27570f9cb397

Merge pull request #10963 from cmgustavo/bug/desktop-scanner-button-01 fix(desktop): adds padding-bottom on wallets view

view details

Gabriel

commit sha ed89b7ee760dd4fd26483b1c2b9536a674b91955

Merge pull request #10967 from cmgustavo/bug/home-arrows-01 fix(home): align arrows

view details

Marty Alcala

commit sha 27a58c7e74b52c541e76426a800f0a3b39441b23

use bitpay id email as gift card receipt email if connected

view details

Gustavo Maximiliano Cortez

commit sha d3f0dae2c742e1769d8547f8297f4173044615f3

Merge pull request #10968 from msalcala11/fix/email-prompt Use BitPay account email as gift card receipt email if connected

view details

Marty Alcala

commit sha 71bc56d52c12fc63d675aea118314fcda3c1a63c

implement new shop page design

view details

Gustavo Maximiliano Cortez

commit sha 474b80d0fd2264a0d8fbe4e34d716ecb51c57355

Merge pull request #10966 from msalcala11/categories Shop Page Redesign

view details

Gabriel

commit sha b91408998d92c588e1e9bf613c49b2fb0df2f195

Merge pull request #10965 from cmgustavo/bug/home-balance-01 fix(home-balance): Refresh balance when switching on from settings. F…

view details

Marty Alcala

commit sha a6f5f4f6127657c93e42b9067bac0c4670c0ae4d

update recently purchased gift cards list immediately after each new gift card purchase

view details

Gustavo Maximiliano Cortez

commit sha b84879571fbc5b9ea105edb0c61afdb49662b279

Merge pull request #10976 from msalcala11/fix-recently-purchased Fix recently purchased gift card updates

view details

johnathan White

commit sha 72b2114459258bb6f2f67296159b31abf9c7b6f1

added handler for debit card redirection if app freshly installed and opened via card fast track intent

view details

push time in 4 days

push eventfriederbluemle/react-native

Valentin Shergin

commit sha f2fdc1a5dfd5fe03b42d46978edc68f4a3fc0e1f

Fabric: Simplifying RCTPerformMountInstructions Summary: This diff inlines all mount-instruction functions into a single one - RCTPerformMountInstructions. The main purpose is to reduce the number of calls to `RCTComponentViewRegistry` for some instructions. E.g., before the change, the `Insert` (or `Update`) instruction had seven identical calls to the registry. That's not a huge deal but there is no need to pay for it either. Maybe it can save us a couple of milliseconds during TTI. The code of those functions is quite straight-forward, so this change probably even improves readability. Changelog: [Internal] Fabric-specific internal change. Reviewed By: sammy-SC Differential Revision: D22402987 fbshipit-source-id: 043a4114ba42622e9ed226f4d5e41ed45c1b066c

view details

Devon Deonarine

commit sha 8c42c019772ba373030558fdbc15b2470f1d7137

Fix debugging on android for 0.63 (#29204) Summary: Currently on react native 0.63-rc.0 and 0.63-rc.1 enabling debugging throws an exception. It looks like something may have been missed in unregistering JSDevSupport in this commit c20963e ![crash](https://user-images.githubusercontent.com/14797029/85500252-2acae400-b5b1-11ea-938a-674b55e649b2.gif) This should fix https://github.com/facebook/react-native/issues/28746 and https://github.com/facebook/react-native/issues/29136 ## Changelog [Android] [Fixed] - Fix crash when enabling debug Pull Request resolved: https://github.com/facebook/react-native/pull/29204 Test Plan: To recreate the bug: npx react-native init RN063 --version 0.63.0-rc.1 react-native start react-native run-android Enable debug mode from react native dev menu After this commit, the crash no longer occurs ![non crash](https://user-images.githubusercontent.com/14797029/85500241-269ec680-b5b1-11ea-8cfe-85bfda4dd222.gif) Reviewed By: TheSavior Differential Revision: D22395406 Pulled By: RSNara fbshipit-source-id: 046df77ae1c1de96870fb46f409d59e7d6a68c0d

view details

Joshua Gross

commit sha 90287ca5364d6ee8a3e4f50afe6d1256c21a65e3

Make ShadowTreeRegistry `remove` API safer Summary: Currently the `remove` API returns an owned unique_ptr of the removed ShadowTree but it's not used anywhere, so we can simplify the API. Because of that change, we can make the API safe even if the SurfaceId has already been removed. For context, on Android there is a race between RootView.unmountReactApplication and C++ teardown which removes all SurfaceIds. This currently causes a crash, but after this diff the 2nd call to `remove` for a given SurfaceId will noop. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D22416471 fbshipit-source-id: dbba44c276aab8e81097b92a89e0becdcb7b28ba

view details

push time in 4 days

push eventfriederbluemle/gh-search-cli

dependabot-preview[bot]

commit sha 80c07b9f0e1dc35140020cbf161009d036c8f4c1

Bump @oclif/plugin-help from 3.0.0 to 3.1.0 Bumps [@oclif/plugin-help](https://github.com/oclif/plugin-help) from 3.0.0 to 3.1.0. - [Release notes](https://github.com/oclif/plugin-help/releases) - [Changelog](https://github.com/oclif/plugin-help/blob/master/CHANGELOG.md) - [Commits](https://github.com/oclif/plugin-help/compare/v3.0.0...v3.1.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha 9a94fb90519e6fc5316daed55a29be302c897b48

Bump mocha from 7.1.2 to 8.0.1 Bumps [mocha](https://github.com/mochajs/mocha) from 7.1.2 to 8.0.1. - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md) - [Commits](https://github.com/mochajs/mocha/compare/v7.1.2...v8.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha dfc233ca359582418b34cb808629cc4ec0d9798a

Bump @types/sinon from 9.0.0 to 9.0.4 Bumps [@types/sinon](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/sinon) from 9.0.0 to 9.0.4. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/sinon) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha 13198ef38c0f1adef85e5517e1d39b7830ebcf7b

Bump @oclif/test from 1.2.5 to 1.2.6 Bumps [@oclif/test](https://github.com/oclif/test) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/oclif/test/releases) - [Changelog](https://github.com/oclif/test/blob/master/CHANGELOG.md) - [Commits](https://github.com/oclif/test/compare/v1.2.5...v1.2.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha a7bdac4e1c32accf1f5438c934e3c9ec3038be79

Bump @oclif/parser from 3.8.4 to 3.8.5 Bumps [@oclif/parser](https://github.com/oclif/parser) from 3.8.4 to 3.8.5. - [Release notes](https://github.com/oclif/parser/releases) - [Changelog](https://github.com/oclif/parser/blob/master/CHANGELOG.md) - [Commits](https://github.com/oclif/parser/compare/v3.8.4...v3.8.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha 2a5cf84825d9d86bf1b58adba7482d54fdf95278

Bump ts-node from 8.10.1 to 8.10.2 Bumps [ts-node](https://github.com/TypeStrong/ts-node) from 8.10.1 to 8.10.2. - [Release notes](https://github.com/TypeStrong/ts-node/releases) - [Commits](https://github.com/TypeStrong/ts-node/compare/v8.10.1...v8.10.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha 0061b9b3d52cbf98d11f8ae620c8d91eed7b42a0

Bump @types/node from 14.0.1 to 14.0.13 Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.0.1 to 14.0.13. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha c957d83b3d808a57f33baad542d8c35bc3ce62b2

Bump @types/fs-extra from 8.1.0 to 9.0.1 Bumps [@types/fs-extra](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/fs-extra) from 8.1.0 to 9.0.1. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/fs-extra) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha 529fff7a883c039eb9427c72c9e3d1e1affccdfa

Bump typescript from 3.9.2 to 3.9.5 Bumps [typescript](https://github.com/Microsoft/TypeScript) from 3.9.2 to 3.9.5. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/compare/v3.9.2...v3.9.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha 22fc9c25adce9c0066fa2d7d39f68192a8bbf8a2

Bump nyc from 15.0.1 to 15.1.0 Bumps [nyc](https://github.com/istanbuljs/nyc) from 15.0.1 to 15.1.0. - [Release notes](https://github.com/istanbuljs/nyc/releases) - [Changelog](https://github.com/istanbuljs/nyc/blob/master/CHANGELOG.md) - [Commits](https://github.com/istanbuljs/nyc/compare/v15.0.1...v15.1.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha 3f728b5050294437b4361c90719977a5addbbbb5

Bump chalk from 4.0.0 to 4.1.0 Bumps [chalk](https://github.com/chalk/chalk) from 4.0.0 to 4.1.0. - [Release notes](https://github.com/chalk/chalk/releases) - [Commits](https://github.com/chalk/chalk/compare/v4.0.0...v4.1.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha cdb5c6e5d21b29cbca628ac1a51e687e46e147d6

Bump globby from 11.0.0 to 11.0.1 Bumps [globby](https://github.com/sindresorhus/globby) from 11.0.0 to 11.0.1. - [Release notes](https://github.com/sindresorhus/globby/releases) - [Commits](https://github.com/sindresorhus/globby/compare/v11.0.0...v11.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha fbfd9e18248eeff659cf2295f1dcf255f25741a8

Bump eslint-config-oclif-typescript from 0.1.0 to 0.2.0 Bumps [eslint-config-oclif-typescript](https://github.com/oclif/eslint-config-oclif-typescript) from 0.1.0 to 0.2.0. - [Release notes](https://github.com/oclif/eslint-config-oclif-typescript/releases) - [Changelog](https://github.com/oclif/eslint-config-oclif-typescript/blob/master/CHANGELOG.md) - [Commits](https://github.com/oclif/eslint-config-oclif-typescript/compare/v0.1.0...v0.2.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha cfdb256d94cc9b25d016902b3b034fa5c69fd657

Bump fs-extra from 9.0.0 to 9.0.1 Bumps [fs-extra](https://github.com/jprichardson/node-fs-extra) from 9.0.0 to 9.0.1. - [Release notes](https://github.com/jprichardson/node-fs-extra/releases) - [Changelog](https://github.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md) - [Commits](https://github.com/jprichardson/node-fs-extra/compare/9.0.0...9.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

push time in 4 days

pull request commentmicrosoft/vscode-react-native

Fix capitalization of GitHub org

Hi @SounD120 - Thanks for the reminder! I resolved the conflicts and rebased the branch.

friederbluemle

comment created time in 4 days

push eventfriederbluemle/vscode-react-native

JiglioNero

commit sha 3f049718b2a6450008aab050f39fdb9f7cd741bd

Update Expo documentation (#1251)

view details

Yuri Skorokhodov

commit sha 9fd770e7a5f51ddaea6fa8c6a54d11d79ac93988

Prepare for 0.15.0 (#1255)

view details

JiglioNero

commit sha ad1307ba5c8111492b8ed1ca046ccc584cd4cbc5

Migrate unit tests to vscode-test (#1256)

view details

RedMickey

commit sha 0c81f718dafeaf76778f119f5f49cda6963ccc26

Fix security vulnerabilities (#1253) * Fix vulnerabilities

view details

JiglioNero

commit sha 294ec6b46582d42eb432c6a291bc67a28808fcb9

Fix fonts usage for Expo 37 (#1260)

view details

JiglioNero

commit sha 573224fabbc391a9ddc4e9d8a68ecedc16f27ed5

Fix runOptions check for packager (#1264) * add check run options * remove font fix for expo 37 from changelog

view details

RedMickey

commit sha b85586fbeeba71b77e99b0a3bf49ef72f95b27a7

Increase packager starting time and fix handling of StatusBar items click (#1268) * Increase packager starting time and fix PackagerStatusIndicator

view details

Yuri Skorokhodov

commit sha e76d63ba5fb350a62edba201347e491efe329691

Update Expo app template code (#1279) * bugfix: change Expo app template code * bugfix: add timeout before checking that dev menu is being clicked

view details

Antón Molleda

commit sha cf67a95d58b9842df22c311957ef227813071aed

feat: issue templates (#1277)

view details

Max von Webel

commit sha 60a092c1e94fe2bc93b2b1cfc1ba834018ca5995

Fix links in Table of Contents, typo (#1284)

view details

JiglioNero

commit sha 35d8a668e0c1bb65c63a6ae4b36b70483dd4b860

Update smoke tests docs (#1281)

view details

Yuri Skorokhodov

commit sha 6340e8b597b4926f54e83c9fc22c970cdbba6bf1

Update extension license to MIT (#1286)

view details

Yuri Skorokhodov

commit sha 36e1bd98b78031cee4b8917b0cd77765d2556f9d

Prepare for 0.16.0 (#1287)

view details

JiglioNero

commit sha b5999289daa32938260d26f1fd0276edc6835d23

Smoke tests migration to vscode 1.45.1 (#1290) * merge quickaccess and quickopen * add runDebugScenario to quickaccess * fix waitForTab wethod * use aria-label for waitForTab * searching Expo QR Code readonly * Update test/smoke/automation/src/code.ts Co-authored-by: RedMickey <33267199+RedMickey@users.noreply.github.com> * Update test/smoke/automation/src/code.ts Co-authored-by: RedMickey <33267199+RedMickey@users.noreply.github.com> * Delete yarn.lock * change field for searching in selectTab * add access modifiers fro functions in quickaccess Co-authored-by: Yuri Skorokhodov <v-yuskor@microsoft.com> Co-authored-by: RedMickey <33267199+RedMickey@users.noreply.github.com>

view details

Yuri Skorokhodov

commit sha 022b0688e25de612c11fd73fbd57263e2657f64f

Add status badges (#1304)

view details

dependabot[bot]

commit sha fc7330974e30c8a352f2c1aadf1a5cffc73860a8

Bump websocket-extensions from 0.1.3 to 0.1.4 in /test/smoke/package (#1310) Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](https://github.com/faye/websocket-extensions-node/compare/0.1.3...0.1.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

JiglioNero

commit sha 90d151176518d426875fba71cc79be9cba58072d

Eslint migration (#1315) * Initial eslint configuration * lint changes * fix camel case * update pachage-lock and delete tslint.json * disable prefer-rest-params * add eslint task to smoke gulp, add rules for semicolons and do some autofixes * fix in smoke tests * remove tslint from smoke package.json * fix rule for delimeters * small fix * remove redunant ignore patterns Co-authored-by: Yuri Skorokhodov <v-yuskor@microsoft.com>

view details

RedMickey

commit sha 305d77de618087d06fb463c37d49ed8b069bbf35

Add prompt functionality to promote RNT-preview extension (#1309) * Implement Experiment Service * Implement sending of errors to telemetry * Adapt experiment service to bundling

view details

RedMickey

commit sha f4f2d271a4edf6e8f241d06226c8833f979dada6

Implement launch of experiment service (#1322)

view details

Yuri Skorokhodov

commit sha 10e2def9ea1eb4a50af0e98a0e1eef02a489af42

Fix errors in case of spaces in adb path from local.properties (#1326) * Add tests

view details

push time in 4 days

push eventfriederbluemle/react-native-website

Bartosz Kaszubowski

commit sha e8159edbb038c72a1544c9e2c3d22221092f77ea

fix Android ripple property on the Pressable page (#1969)

view details

cpojer

commit sha af18c1dcf6757a8903896c548dd55c81ed0c219b

Black Lives Matter banner

view details

Christoph Nakazawa

commit sha 491131c37ab4049768acd0531ee85fb275c868a8

Update website/static/css/homepage/HeaderHero.css Co-authored-by: Ricky <rickhanlonii@gmail.com>

view details

Christoph Nakazawa

commit sha 20b92a935d7c485d9e94453243980a77ddd680f6

Merge pull request #1971 from cpojer/master

view details

Ricky

commit sha 34cd6e05d7a147c447557bf53c2acdc3009cd009

We can do better - show banner on every page. (#1972)

view details

Ricky

commit sha 5b0ba3cbb7f7e7dcb8778d980458e9147cfa4ae8

Fix banner links not clickable on mobile (#1974)

view details

Bartosz Kaszubowski

commit sha 2efa3fff23e35e27ec7ecbf55bc6943e2efc6435

small tweaks for the BLM banner (#1973)

view details

Bartosz Kaszubowski

commit sha b94ade01d013c44d9ebfd5474f3973b20e1dfd1e

fix overlap and pointer events issue on mobile (#1978)

view details

Bartosz Kaszubowski

commit sha 138c05feaaa9814a11aa1865030376c71b4a9b29

add twitter badge to the README (#1963)

view details

Bartosz Kaszubowski

commit sha c1e141e31c0e4b8b685766f61768327d822664fc

mimic more reactjs.org BLM banner style, add grayscale

view details

dependabot[bot]

commit sha 1f1f743be4538a99e104efcd20d7bbb0cd71473c

Bump websocket-extensions from 0.1.3 to 0.1.4 in /website (#1982)

view details

Bartosz Kaszubowski

commit sha 464399355ba1df51b182b89b4d4515bb399bced5

remove the grayscale filter, fixes #1983

view details

Steel Brain

commit sha a9d5c493025fd66ab24eba19f0b05e48be5a1d9c

Fix broken link in Hermes (#1984)

view details

Sunny Luo

commit sha 95f2285ba523f487cf93ec263c4109a361c2d54c

Modify animated example code to match comments (#1987)

view details

David Holland

commit sha 8a924532155f19420be755b115cb568816004f8e

Fixed grammatical issues (#1990)

view details

Sunny Luo

commit sha b665e598fd47d69b4ebb5175790e787a28684225

Fix wrong endBlock in text.md (#1991)

view details

Michal

commit sha 1b146d75a3da9c16a96b1bed6aa5b20fc1d58875

fix: update installation instructions (#1989)

view details

Rogi Solorzano

commit sha 38a22f472bf451b9f1ec2ed2af3d05d829dec2a0

Fixed DrawerLayoutAndroid padding syntax which was causing the Expo Snack to crash (#1995)

view details

Tim Pap

commit sha f4d74cfb47463f081dda42745303199cfb9c3f9e

Docs: Update react-native-unimodules link (#1994) The react-native-unimodules link is updated. The current repo has been deprecated in favor of expo/expo monorepo

view details

Nayan Shinde

commit sha 4aa9331412184abc1e75bfc2f2d02f3be0bc6afa

Bug Fix #1993 (#1996)

view details

push time in 4 days

push eventfriederbluemle/react-native

almouro

commit sha f23feced42abd1d18a12e413bf79a51bead61379

Fix font variant crash on Android < 4.4 (#29176) Summary: In RN 0.62 support for `fontVariant` was added on Android. Using that prop crashes the app on Android below KitKat (4.3 and below) To reproduce just add any Text with the `fontVariant` styling prop in the app: ```js <Text style={{fontVariant: ['tabular-nums']}}>This will crash</Text> ``` It will crash any device running Android below KitKat with the error: ![image](https://user-images.githubusercontent.com/4534323/85073452-18206b80-b1bb-11ea-8d7e-96f27fa1a320.png) This is caused by `java.utils.Objects` only being available on Android 4.4+ ## Changelog [Android] [Fixed] - Fix font variant crash on Android < 4.4 Pull Request resolved: https://github.com/facebook/react-native/pull/29176 Test Plan: [TextUtils.equals](https://developer.android.com/reference/android/text/TextUtils#equals) was added as soon as API level 1, so no compatibility issue here. Tested on Emulator running Android 4.1, no crash anymore. I've searched for other occurences of `java.utils.Objects` in the project, and this was the only one, so no need to remove other occurences ✅ Reviewed By: JoshuaGross Differential Revision: D22337316 Pulled By: mdvacca fbshipit-source-id: 5507b21b237a725d596d47b5c01e269895b16d4a

view details

Valentin Shergin

commit sha 26d8d4173581541d137a30c2bbe4d996888c49c9

Fabric: More asserts in iOS mounting infra Summary: The change contains a bunch of additional asserts that verify some assumptions on which mounting relies on. Working on the previous diffs I realized that it's very easy to broke those and then spend hours trying to understand what exactly went wrong. Changelog: [Internal] Fabric-specific internal change. Reviewed By: sammy-SC Differential Revision: D22324087 fbshipit-source-id: 1152c40248885d02bde62a493a574868c3732273

view details

Valentin Shergin

commit sha 3c69a9eb4b53c5f1b6f480cf96d88df27bb596f1

Fabric: `display: none` nodes do not create views anymore Summary: This introduces a new shadow node trait (`Hidden`) which disables emitting ShadowVides for such nodes and all their descendants. Changelog: [Internal] Fabric-specific internal change. Reviewed By: sammy-SC Differential Revision: D22134220 fbshipit-source-id: 8ea1fc3186019005ad687eacaca0ba4a4d8343dc

view details

Valentin Shergin

commit sha 4776ebd7c3678494b97933bf8f50f54de4877646

Fabric: A demo in RNTester for `display: none` Summary: An interactive demo that stress-tests the `display: none` feature. Changelog: [Internal] Fabric-specific internal change. Reviewed By: mdvacca Differential Revision: D22336304 fbshipit-source-id: 43855e979d45b4bdfdcf82f6b805a4f4af868368

view details

Héctor Ramos

commit sha e255748d12df334bd35d8096e970141bafac886b

Codegen: Enable generation of ObjC FBReactNativeSpec with CocoaPods Summary: Build `FBReactNativeSpec.h` and `FBReactNativeSpec-generated.mm` using the new codegen script whenever the workspace is created using CocoaPods if the `USE_CODEGEN` envvar is set to 1. Effectively makes use of the new codegen integration in CocoaPods opt-in. The `USE_CODEGEN` envvar check should be removed when the generated files are removed from source control, at which point use of the new codegen in CocoaPods will be necessary. ``` cd RNTester USE_CODEGEN=1 pod install ``` Changelog: [Internal] Reviewed By: RSNara Differential Revision: D22250128 fbshipit-source-id: 8f06bf1424ca2e003ecfd032ec03d7896569f9bd

view details

Héctor Ramos

commit sha 7e7706cb7daf72541a378d40304ec2b990565ee5

Codegen: Generate ObjC structs for type aliases Summary: **Motivation:** Match the old codegen's behavior when generating structs for type alias derived objects. **Problem description:** Take, for example, the following spec: ``` export type MyTypeAlias = { /* ... */ } export interface Spec extends TurboModule { // ... +myMethod: (paramName: MyTypeAlias) => void; // ... } ``` The codegen needs to generate a struct to expose the properties of the type alias object. The codegen was producing the following output: ``` - (void)myMethod:(JS::MyModule::SpecMyMethodParamName &)paramName; ``` ...which does not match the output from the original codegen: ``` - (void)myMethod:(JS::MyModule::MyTypeAlias &)paramName; ``` The original codegen generates a struct using the type alias name, while the new codegen was generating a struct that uses a combination of the property and parameter names. Now that type alias names are exposed in the schema, the new codegen can match the original codegen's behavior. **De-duplication of structs:** Prior to these changes, type aliases were expanded into regular object types. This meant that any spec that used a type alias more than once would lead to redundant structs getting created. With these changes, we only generate the one struct per type alias, matching the old codegen. **Expansion of type aliases:** A new type was introduced in D22200700 (https://github.com/facebook/react-native/commit/e261f022fe6a7653b79330f878fed143725f5324), TypeAliasTypeAnnotation: ``` export type TypeAliasTypeAnnotation = $ReadOnly<{| type: 'TypeAliasTypeAnnotation', name: string, |}>; ``` This type may now appear in several locations where a `{| type: 'ObjectTypeAnnotation', properties: [] |}` otherwise would have been used. A `getTypeAliasTypeAnnotation` function is introduced which, given an alias name and an array of aliases provided by the module, will produce the actual object type annotation for the given property parameter. Changelog: [Internal] Reviewed By: RSNara Differential Revision: D22244323 fbshipit-source-id: 125fbf0d6d887bd05a99bf8b81b30bdda4f1682b

view details

Dulmandakh

commit sha e559aee64275126eaa135486e6bf09138be70f4d

bump gradle to 6.5 (#29043) Summary: Bump Gradle to 6.5 or latest version. ## Changelog [Android] [Changed] - bump Gradle to 6.5 Pull Request resolved: https://github.com/facebook/react-native/pull/29043 Test Plan: RNTester builds and run as expected Reviewed By: JoshuaGross Differential Revision: D22337424 Pulled By: mdvacca fbshipit-source-id: 4d089a5edfac6672276572fae2a1a7a236142985

view details

Christoph Nakazawa

commit sha e881b244ca60adeb003c7af2b8e8b55f0cabf503

Remove JSDeltaBundleClient Summary: This was an experiment that never shipped. In the meantime we built Fast Refresh which obviates the need to complicate how we load and store bundles on device. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D22330994 fbshipit-source-id: 5a623b2611dd2622f17dd83ed35ef05c3100e40d

view details

Jiayan Zhuang

commit sha ffa07254de914f7876a17ec2d1ecac1dc10b116a

Build the framework for RCTParagraphComponentAccessibilityProvider Summary: Changelog: [iOS][Added] - This is the first step to build RCTParagraphComponentAccessibilityProvider. The main idea of RCTParagraphComponentAccessibilityProvider is to provide an array of accessible elements for the AttributedString in PCTParagraphComponentView. Reviewed By: sammy-SC Differential Revision: D22214855 fbshipit-source-id: 69d47555e86452620f89a4b2e21ed6065c8e669c

view details

Samuel Susla

commit sha 40f37b986b9dda4a08b50702513676e50ea16aaa

Temporarily disable support for transformations in findNodeAtPoint infrastructure Summary: Changelog: [Internal] FindNoteAtPoint takes transformations into account. There is however a problem with how transformation in ScrollView. In ScrollViewShadowNode, getTransform is overriden. In the override we apply `Transform::Translate(-contentOffset.x, -contentOffset.y, 0)`, this means that ScrollView has moved by {-x,-y}. However this is only true for its children, not for scroll view itself. This trips off findNodeAtPoint and if you scroll more than than screen's height, point will not be evaluated as inside ScrollView. Until we can figure out how to deal with this properly, I think it is better to disable it as usage of JS Inspector is more common in ScrollViews than it is with transformed views. Reviewed By: shergin Differential Revision: D22332779 fbshipit-source-id: f48c9ae67a595e6954c2b70fb287db7f8c74378b

view details

Jiayan Zhuang

commit sha 8fb1bb8da70c6003614dc7959193e546ba89d560

Add accessibilityRole to TextAttributes Summary: Changelog: [Internal] - The accessibilityRole will be used to specially distinguish normal fragments and fragments with embedded link, which is helpful when building accessibilityElement. According to this document: https://reactnative.dev/docs/accessibility, the accessibilityRole is a common accessibility props that could be inherited, and this is why I add accessibilityRole to the TextAttributes. Reviewed By: sammy-SC Differential Revision: D22249140 fbshipit-source-id: 408b4415bf44539d8671d3d98f1ec06f8035baf6

view details

David Vacca

commit sha c4de0c7a0ab5042424b70f06e1e4195a12706cc4

Move ART out of OSS Summary: ART has been moved out of OSS, but I created the fabric implementation in github repo, this diff migrates the Fabric ART implementation to FB repository again changelog: [Internal] Reviewed By: shergin Differential Revision: D22352930 fbshipit-source-id: 1125d3f27b98be783529134de0d3fbcf1b01a6f4

view details

Christoph Nakazawa

commit sha 6d6c68c2c639b6473e049f7d916690b92e921c7e

"The Metro Server" -> Metro Summary: Pet Peeve: Metro is a brand name. You don't say "the Metro server" just like you don't say "the iPhone phone". This is a leftover from when it used to be called "the packager server". Note: It makes sense to refer to "the Metro server" when talking about it in the context of Metro's features, like if you are discussing "Metro's bundling" and "Metro's server". However, when talking about the tool itself, just Metro is enough. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D22330966 fbshipit-source-id: 667618363c641884df543d88cac65d1e44956ad3

view details

Christoph Nakazawa

commit sha b2c775ca7a1cecfaf8f5bb357c09b357096d8a7b

Small cleanup of package.json Summary: `babel/runtime` is not directly required by RN. Changelog: [Internal] Reviewed By: rubennorte Differential Revision: D22374323 fbshipit-source-id: 269de51ceb53ef101cef70f2d410181fc2300514

view details

Samuel Susla

commit sha 42c8dead621c80f25ef0980466e0ff7902af2913

Restore contentOffset from state if necesarry Summary: Changelog: [Internal] When JS Inspector is activated, ScrollView is unmounted and then mounted again with same state. ScrollView's content offset was being set to 0 inside `[RCTScrollViewComponentView prepareForRecycle]` during unmount but when it is mounted again, we ignored value inside state. Reviewed By: shergin Differential Revision: D22333125 fbshipit-source-id: f232dc95b695605f4819f29d8e0bf14b2f3e9150

view details

Valentin Shergin

commit sha 4716d2282ee06b6e1b1e04abcc50154017adf7c4

Fabric: Fixes in computing visible frame in `RCTScrollViewComponentView` Summary: This refined algorithm now takes a zoom/scale into account and deals with `contentInset` properly. Changelog: [Internal] Fabric-specific internal change. Reviewed By: sammy-SC Differential Revision: D22382482 fbshipit-source-id: 7e9d34d3bababf68e624c045c308957e7e5c9d84

view details

Amir Shalem

commit sha 8a14b9819320c3062b5013025c10be27e6481784

Don't call config->setLogger(nullptr) directly to avoid having no logger at all Summary: Changelog: [Internal][Yoga] Don't call config->setLogger(nullptr) directly to avoid having no logger at all Broken in D14151037 (https://github.com/facebook/react-native/commit/dc7dce130beef647b3c3d5d25d067c3557b84214) when it started calling ``` config->setLogger(nullptr); ``` instead of going thru ``` YGConfigSetLogger(config, nullptr); ``` which does the right thing by setting the logger to its default value: https://www.internalfb.com/intern/diffusion/FBS/browsefile/master/xplat/yoga/yoga/Yoga.cpp?commit=835911317e8b3cf7da1866e40e1c79cda0690136&lines=4320-4330 Also by default YogaConfig always have a logger: https://www.internalfb.com/intern/diffusion/FBS/browsefile/master/xplat/yoga/yoga/Yoga.cpp?commit=835911317e8b3cf7da1866e40e1c79cda0690136&lines=335-343 Reviewed By: SidharthGuglani Differential Revision: D22387459 fbshipit-source-id: 4da91da87a696d38cc9d8db2acb5845d29398adb

view details

Jimmy Zhang

commit sha 3d882495d5e4415c2ebb8f4280e18e16025e0736

Check whether packager is running in RCTBundleURLProvider for saved JSLocation Summary: Changelog: Adding packager running check when RCTBundleURLProvider is returning JSLocation, this prevents an invalid address from being returned which might cause various issues. Reviewed By: cpojer Differential Revision: D22390156 fbshipit-source-id: a20dbf63103158a34cbf6dc0ae8349b2f9e5b0a8

view details

Jiayan Zhuang

commit sha 10a800da251e90bdf9bbc531075cad7e9c658765

Complete the basic RCTParagraphComponentAccessibilityProvider Summary: Changelog: [Internal] - add the first accessibilityElement Reviewed By: shergin Differential Revision: D22249310 fbshipit-source-id: e0f1920377eb9d7a22737cf7437b1c5bd7195c5d

view details

Jiayan Zhuang

commit sha 96708d58e4b413032f4e5ffcc71e8da67ef99ea0

Add getRectWithAttributedString() to RCTTextLayoutManager Summary: Changelog: [iOS][Added] - `getRectWithAttributedString()` aims to get the rect of the fragment with embedded link, which is necessary when building the `accessibilityElement`. In this function, we first enumerate attributedString to find the range of fragments whose `accessibilityRole` is @"link". Then we calculate the rect of the fragment and send to the block and we would define what to do in the block in `RCTParagraphComponentAccessibilityProvider`. Reviewed By: shergin Differential Revision: D22286733 fbshipit-source-id: 4d11cb54375a4e9e72869e646fcb484de089b14b

view details

push time in 4 days

push eventfriederbluemle/wide-github

Frieder Bluemle

commit sha 1eb469077ae6e5261753f9d36227ba2fff00120b

Fix GitHub spelling

view details

push time in 5 days

push eventfriederbluemle/ernnavigation-api-impl-native

Deepu Ganapathiyadan

commit sha bfdc60dd777cbba5ae839bde5e9aadf65d242ba9

Allow RN component to handle back even if the nav bar is hidden

view details

@Deepu

commit sha 1a98a2afdc065ea279205568d737b646d172e900

Merge pull request #126 from deepueg/add-back-handle Allow RN component to handle back even if the nav bar is hidden

view details

Deepu Ganapathiyadan

commit sha 1ee28b69ef9186980761d5d8af538d7eccffef92

v1.4.5

view details

push time in 5 days

push eventfriederbluemle/sampleapp-android

Frieder Bluemle

commit sha 429062843e8ecf52747ff698cd3db1324982011d

Update Android Gradle plugin to 3.6.3

view details

Frieder Bluemle

commit sha 0c12840adb1dc71e26824e821a4066e78d67ffed

Update CircleCI config

view details

Frieder Bluemle

commit sha 420f01f4a55d385e16c15c140c9efb2d6a869181

Merge pull request #16 from friederbluemle/update-gradle-plugin

view details

Frieder Bluemle

commit sha 731e3c8107d67e61f0051a9927db67ba96238c64

[commit 4951]

view details

push time in 5 days

push eventfriederbluemle/mqb-pm

Frieder Bluemle

commit sha 4d0381bd1d296fb889a9ab6db389c499ffa4671d

Update Android Gradle plugin to 3.6.3

view details

push time in 5 days

delete branch friederbluemle/mqb-pm

delete branch : update-deps

delete time in 5 days

pull request commentgooglesamples/android-media-controller

Update Gradle Wrapper and build scripts

Rebased and resolved conflicts, updated PR description.

friederbluemle

comment created time in 5 days

push eventfriederbluemle/android-media-controller

Leo Neat

commit sha 28bc4cea13c59b73e9139148b062fb9a7caf423b

Add bottom navigation menu

view details

Leo Neat

commit sha a70ce840cc6fdc43070e072cea9183870a5deb07

Formatting

view details

Leo Neat

commit sha f3b492d23dc2bb64314227e0307027f06a94d27e

Formatting modified: mediacontroller/build.gradle

view details

Leo Neat

commit sha 61bbdc29867260cb76b2a4b2884709029c986770

Cleaning up

view details

Leo Neat

commit sha 3ab5f4249ab3c4e56d9323c423f9fbdfded32503

Cleaning up

view details

Leo Neat

commit sha 6017322cf108e705df331dd129ed4a36e544f0cf

Nicole's comments

view details

Lady Nicole

commit sha 0f5565aa1308500e03819a3e7e9acd71392d525b

Merge pull request #16 from Leo-Neat/new-menu [UI] Add bottom navigation menu

view details

Leo Neat

commit sha 789baf4eae43c691449c1418d4abd0063c081468

Format

view details

Leo Neat

commit sha 360cb251157bbff267fdfdff8dd80cb38ea5f27d

Adding test Suite UI

view details

Leo Neat

commit sha 05c432fcb9930e3ff3052f64ca4c23ec4a696d9c

Adding results

view details

Leo Neat

commit sha 973bcce9acc1e81cf6f5761fab758f68d86bb133

Adding results dialog

view details

Leo Neat

commit sha 20051f33407f676817bddd42239f673f5e4d6e06

Test suites

view details

Leo Neat

commit sha f27285c41ac19969ee5230e7af7c0bb3fd338696

Removing unecessary test suite stuff

view details

Leo Neat

commit sha d309ed65d639ec7b72df9f4620fa602a59e7effd

Removing unecessary test suite stuff

view details

Leo Neat

commit sha 7860fbf23ac96cbb2223e3675dc3d7905d0660bf

explicit imports

view details

Leo Neat

commit sha 38fbb08719c5b91a5eb4784c2fec32a154e6e38f

Merge pull request #17 from Leo-Neat/logging [Infra] Map logs to test runs

view details

Leo Neat

commit sha 40df73f4a184995683d9e11be0a1e4943c3fb7c9

Working test suites

view details

Leo Neat

commit sha 6b33fc9ecae51f8f61665fdc65e0c5b9fad8acc9

Test suites working with not using configurable tests

view details

Leo Neat

commit sha 5a34a664d406908b0148491dff758879a98cb94a

Adding xml

view details

Leo Neat

commit sha 6c97eb927f2ea46795685d1a7f8fda105dca3602

Resolve merge conflicts

view details

push time in 5 days

push eventfriederbluemle/react-native-vector-icons

Hampus Tågerud

commit sha b4fb74443bd3ffe118129717534e52c691f9d055

Update FontAwesome 5 to 5.13.0 (#1165)

view details

Hampus Tågerud

commit sha 20932103da49604635e5ce98d7b65f2b1438a6d4

Support autolinking when downloading FontAwesome5 Pro fonts (#1166)

view details

ДимкаРеактнативный

commit sha 9e9bae974e8c471a346b22413dbd1111a0d8fe0c

Add Fontisto to README (#1161)

view details

Andrei Alecu

commit sha 39e02767a65579fd05cc1b3bb65cd9d23035f4ae

Update MaterialCommunityIcons to 5.3.45 (#1184) * update MaterialCommunityIcons to 5.3.45 * update readme

view details

Akin Williams

commit sha 459abaf43f375cf77f6d978511f0f3e795fd2008

Upgrade IonIcons to v5.0.1. (#1176) Revert ttf font name from 'fontcustom' to Ionicons. Backwards compatibility: add platform prefixes: "md-" & "ios-"

view details

Joel Arvidsson

commit sha b4fdc6b116820d2a677c5d8568417b93c29c2540

Release 6.7.0

view details

Joel Arvidsson

commit sha 4872d2b9f26e928d8af0c31ecad691b94dcf1dad

Remove ToolbarAndroid (#1195)

view details

Rui Ying

commit sha 3919cfedb590283e6524b0eb44cd24db4c5e699c

Fix temporary directory for icon images on mac catalyst (#1151)

view details

Joel Arvidsson

commit sha 708e7ff8d696fa5fe969f46592f30f7503f37886

Bump IconExplorer to RN 0.62.2

view details

Joel Arvidsson

commit sha bc9d7e4db79788b0a01a1ba9e4dea6be7fc87efe

Bump directory dependencies

view details

dependabot[bot]

commit sha 11cb4fdf8882405e3ee34f0b2c60ccaef169b6e6

Bump websocket-extensions from 0.1.3 to 0.1.4 in /directory (#1181) Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](https://github.com/faye/websocket-extensions-node/compare/0.1.3...0.1.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

Joel Arvidsson

commit sha 22296f8aaa7edaa512b8ca85f7cd103abca472bb

Bump eslint and plugins

view details

Joel Arvidsson

commit sha e43bdab13bd57ae001a22fcb125c8170260a9636

Bump nodejs version on travis to 12

view details

Joel Arvidsson

commit sha 428f09ae28d98150bc2a7b4926c076bf3c9e5064

Release 7.0.0

view details

push time in 5 days

push eventfriederbluemle/android-media-controller

Chenjie Wei

commit sha 83a77ea9e4c3e1a966d28a394b1551b9f3928c05

Add new connection to media browse tree with extra SUGGESTED flag

view details

Chenjie Wei

commit sha 57f95490b124e2e46e3b08e001f5e4e00f829fcf

Uncomment TV activity due to local test

view details

Lady Nicole

commit sha 076effc6dc62a7cb547177ccc52e471b7dc16775

Merge pull request #26 from cwei789/media-browse-tree-extra-suggested Add connection to media browse tree with extra SUGGESTED flag

view details

push time in 5 days

push eventfriederbluemle/aa-phenotype-patcher

Frieder Bluemle

commit sha 34e716d194ff76b753e8eda16c73bc2df6b61ed2

Update .gitignore and remove ignored files

view details

Frieder Bluemle

commit sha f8f5f871895696bd6695c492156550f85061a4a7

Fix file endings and whitespace errors

view details

Frieder Bluemle

commit sha 8ad687abadae0cce86a24d71a4a6f03eb313292e

Update Gradle Wrapper to 4.10.3

view details

Frieder Bluemle

commit sha d5705e64505cc5aacb7522fbc46b2fd1a5804a62

Enable basic GitHub Actions CI

view details

push time in 5 days

push eventfriederbluemle/wide-github

Frieder Bluemle

commit sha 805a4d512f6752f1b389b1b626420ee211d67711

Fix GitHub spelling

view details

push time in 5 days

PR opened xthexder/wide-github

Fix GitHub spelling

Small PR with a minor capitalization fix: Github -> GitHub

+5 -5

0 comment

2 changed files

pr created time in 5 days

create barnchfriederbluemle/wide-github

branch : fix-typos

created branch time in 5 days

fork friederbluemle/wide-github

Change all github repository pages to be full width and dynamically sized.

fork in 5 days

fork friederbluemle/aasdk

Library to build AndroidAuto headunit emulator

fork in 5 days

more