profile
viewpoint

frehner/phaser-subspace 3

Just playing around - learning phaser by building a subspace continuum clone

frehner/matchismo 1

iOS Swift Program. Was assigned as homework for my IS 543 Swift iOS development class.

frehner/babel-plugin-react-emoji-a11y 0

A babel plugin that will take any emojis not wrapped in <span> and wrap them, with correct a11y attributes

frehner/badges 0

The definitive rendering collection of badges

frehner/cdnjs 0

The #1 free and open source CDN built to make life easier for developers.

frehner/cp-dotfiles 0

Some dotfile setups for people who want a jump start on things like vim and tmux.

frehner/create-react-app 0

Create React apps with no build configuration.

frehner/csswg-drafts 0

CSS Working Group Editor Drafts

frehner/drake 0

Drake's Place

issue commentjoeldenning/import-map-overrides

Race condition between application code and import map overrides

Something is still not all the way there at the time init is called.

window.addEventListener("import-map-overrides:init", () => {
  console.log("init");
  check();
});

setTimeout( () => {
  console.log("200ms");
  check();
}, 200);

function check() {
  try {
    console.log("config file: ", System.resolve("config-file"));
  } catch (e) {
    console.log("config file not resolved");
  }
}

Screenshot from 2021-01-23 21-51-24

brandones

comment created time in 6 hours

pull request commentsingle-spa/import-map-deployer

Fixes AWS cache control order issue

Released in https://github.com/single-spa/import-map-deployer/releases/tag/v3.2.1

mellis481

comment created time in 10 hours

release single-spa/import-map-deployer

v3.2.1

released time in 10 hours

push eventsingle-spa/import-map-deployer

Joel Denning

commit sha 7577d8ce3f7bc0028d7733eed5b5634944caaa74

v3.2.1

view details

push time in 10 hours

created tagsingle-spa/import-map-deployer

tagv3.2.1

A manifest deployment service for sofe/import maps

created time in 10 hours

PR merged single-spa/import-map-deployer

Fixes AWS cache control order issue

This solves the problem where someone could set cacheControl in the config but it would be overridden by s3.putObject.CacheControl if that were also set.

+30 -18

2 comments

4 changed files

mellis481

pr closed time in 10 hours

push eventsingle-spa/import-map-deployer

Mike Ellis

commit sha c1911fd06066ba03595f4d1cb0e32079994c8013

Fixes AWS cache control order issue (#91) * Fixes AWS cache control order issue * Improves default * Adds missing ; * Eslint fix

view details

push time in 10 hours

push eventsingle-spa/single-spa.js.org

daniloesk

commit sha 7fd9228abf036f74cf200fb4365f38f94a7cf956

Repository with some Angular examples (#398)

view details

push time in 10 hours

PR merged single-spa/single-spa.js.org

Repository with some Angular examples

Reference to community Angular examples including the main repository and the three most relevant examples so far.

+5 -0

0 comment

1 changed file

daniloesk

pr closed time in 10 hours

PR opened single-spa/single-spa.js.org

Repository with some Angular examples

Reference to community Angular examples including the main repository and the three most relevant examples so far.

+5 -0

0 comment

1 changed file

pr created time in 11 hours

pull request commentsingle-spa/import-map-deployer

Fixes AWS cache control order issue

Did you close this and reopen for a reason? Is it ready to merge? If so i'll publish a patch

Nope. Bumped it in my phone.

mellis481

comment created time in 13 hours

pull request commentsingle-spa/import-map-deployer

Fixes AWS cache control order issue

Did you close this and reopen for a reason? Is it ready to merge? If so i'll publish a patch

mellis481

comment created time in 15 hours

PullRequestEvent

PR closed single-spa/import-map-deployer

Fixes AWS cache control order issue

This solves the problem where someone could set cacheControl in the config but it would be overridden by s3.putObject.CacheControl if that were also set.

+30 -18

0 comment

4 changed files

mellis481

pr closed time in 15 hours

issue commentsingle-spa/import-map-deployer

Add cache control configuration option

@mellis481 it looks like i misremembered the code we had in s3 - yes it looks like we do pass through the s3 options. Not sure why that didn't work for you.

I actually think I had a syntax issue. It should work and FWIW it would actually override the cacheControl config value if you also supplied s3.putObject.CacheControl (for AWS only of course). Not sure if this is a concern. If so, we'd just want to move the CacheControl set line in s3.js below the s3Object spreading.

mellis481

comment created time in a day

pull request commentsingle-spa/single-spa-layout

Fix unmounting of application error parcels. Resolves #105.

I finished the test refactor - it exposed some bugs! I'm no longer emulating single-spa's behavior by firing events, but rather letting single-spa fire the events itself. And that exposed some things.

joeldenning

comment created time in a day

push eventsingle-spa/single-spa-layout

Joel Denning

commit sha 4b130f658290d253791936bbeb1ed144e153e57a

Fix install

view details

push time in a day

push eventsingle-spa/single-spa-layout

Joel Denning

commit sha a2a5838e8a45a3e4ff971b44517fc1c0383410ae

Wherever i was

view details

Joel Denning

commit sha 1ab264b2d86122bab9af270222f334b0cd702959

Merge branch 'issue-105-refactor' into issue-105

view details

Joel Denning

commit sha a1956ad218599f2135ec1eac07825b3caee1414b

Refactor and fixes

view details

push time in a day

pull request commentsingle-spa/single-spa

Allow apps in LOAD_ERROR status to be unloaded.

<!-- head-commit-sha=ba2f5c4912851569f9bcd46f9523b7ba73278c87 --> <!-- Generated by @jsenv/file-size-impact --> <h4>File size impact</h4>

<details> <summary>dist (+1,404 bytes)</summary>

<h6>Overall impact on <bold>dist</bold> files size</h6> <table> <thead> <tr> <th nowrap>Diff</th> <th nowrap>master</th> <th nowrap>after merge</th> </tr> </thead> <tbody> <tr> <td nowrap>+1,404</td> <td nowrap>325,232</td> <td nowrap>326,636</td> </tr> </tbody> </table>

<h6>Detailed impact on <bold>dist</bold> files size</h6> <table> <thead> <tr> <th nowrap>File</th> <th nowrap>Diff</th> <th nowrap>master</th> <th nowrap>after merge</th> <th nowrap>Event</th> </tr> </thead> <tbody> <tr> <td nowrap rowspan="1">lib/es2015/single-spa.dev.js</td> <td nowrap>+180</td> <td nowrap>55,090</td> <td nowrap>55,270</td> <td nowrap rowspan="1">changed</td> </tr> <tr> <td nowrap rowspan="1">lib/es2015/single-spa.min.js</td> <td nowrap>+135</td> <td nowrap>18,264</td> <td nowrap>18,399</td> <td nowrap rowspan="1">changed</td> </tr> <tr> <td nowrap rowspan="1">lib/esm/single-spa.dev.js</td> <td nowrap>+178</td> <td nowrap>58,811</td> <td nowrap>58,989</td> <td nowrap rowspan="1">changed</td> </tr> <tr> <td nowrap rowspan="1">lib/esm/single-spa.min.js</td> <td nowrap>+136</td> <td nowrap>20,395</td> <td nowrap>20,531</td> <td nowrap rowspan="1">changed</td> </tr> <tr> <td nowrap rowspan="1">lib/system/single-spa.dev.js</td> <td nowrap>+240</td> <td nowrap>68,553</td> <td nowrap>68,793</td> <td nowrap rowspan="1">changed</td> </tr> <tr> <td nowrap rowspan="1">lib/system/single-spa.min.js</td> <td nowrap>+153</td> <td nowrap>20,422</td> <td nowrap>20,575</td> <td nowrap rowspan="1">changed</td> </tr> <tr> <td nowrap rowspan="1">lib/umd/single-spa.dev.js</td> <td nowrap>+212</td> <td nowrap>63,041</td> <td nowrap>63,253</td> <td nowrap rowspan="1">changed</td> </tr> <tr> <td nowrap rowspan="1">lib/umd/single-spa.min.js</td> <td nowrap>+170</td> <td nowrap>20,656</td> <td nowrap>20,826</td> <td nowrap rowspan="1">changed</td> </tr> </tbody> </table>

<h6>Impact on <bold>dist</bold> files cache</h6> <p>8 files in you users cache are now outdated because their content have changed.</p> <table> <thead> <tr> <th nowrap>Bytes outdated</th> </tr> </thead> <tbody> <tr> <td nowrap>325,232</td> </tr> </tbody> </table> </details> <sub> Generated by <a href="https://github.com/jsenv/jsenv-file-size-impact">file size impact</a> during <a href="https://github.com/single-spa/single-spa/actions/runs/505116469">file-size-impact#505116469</a> </sub>

joeldenning

comment created time in a day

PR opened single-spa/single-spa

Allow apps in LOAD_ERROR status to be unloaded.

According to https://single-spa.js.org/docs/api#handling-load_error-status-to-retry-module, you can call unloadApplication when an application is in LOAD_ERROR status to make it unload. However, that actually was not the case!! 😱

This PR fixes that.

+44 -2

0 comment

2 changed files

pr created time in a day

create barnchsingle-spa/single-spa

branch : unload-fix

created branch time in a day

push eventsingle-spa/single-spa-layout

Joel Denning

commit sha aeea23decfeb93ff599710001854f2c2491f18a9

Fix import issues in webpack 5. Resolves #107. (#108) * Fix import issues. Resolves #107. * Fix

view details

Joel Denning

commit sha bf9eb4b2ad6641052657ec9b0aa693f98f44544d

1.3.1

view details

Joel Denning

commit sha d4f018dd7168008347af68e36106434f98d66329

Switch to Github workflows (#111) * Switch to Github workflows * Format * Fix build

view details

Joel Denning

commit sha 7b68d380689cf51a0ba7f167506bb915d0b9cea3

Merge branch 'main' into issue-105

view details

push time in a day

push eventsingle-spa/single-spa-layout

Joel Denning

commit sha d4f018dd7168008347af68e36106434f98d66329

Switch to Github workflows (#111) * Switch to Github workflows * Format * Fix build

view details

push time in a day

PR merged single-spa/single-spa-layout

Switch to Github workflows

Travis is slow and rate limiting open source.

+32 -21

0 comment

5 changed files

joeldenning

pr closed time in a day

push eventsingle-spa/single-spa-layout

Joel Denning

commit sha 9ad29a45bfdc3d315d3b16ba37035b405e5b1e7b

Fix build

view details

push time in a day

push eventsingle-spa/single-spa-layout

Joel Denning

commit sha 08c81486047b9be3d48564e9b428157cf2a7c267

Format

view details

push time in a day

PR opened single-spa/single-spa-layout

Switch to Github workflows

Travis is slow and rate limiting open source.

+29 -19

0 comment

3 changed files

pr created time in a day

create barnchsingle-spa/single-spa-layout

branch : github-workflow

created branch time in a day

startedsingle-spa/single-spa-css

started time in a day

more