Thanks friends. So for clarity, can we say this: Fastify first serializes the data and then validates it? (I'm assuming this because if the data would have gone through ajv first, it would have thrown, which is not the case here.)

https://www.fastify.io/docs/latest/Validation-and-Serialization/ While reading it at least I got intuition that first fastify first validates and then serializes. Because, throughout the docs serialization comes second to validation.

What are you trying to achieve or the steps to reproduce?

I have a single POST endpoint

  fastify.post('/register', {
    schema: {
      summary: 'Register a new user',
      description: "Use this route to register a new user",
      tags: ['user'],
      body: {
        type: 'object',
        required: ['name'],
        properties: {
          name: {
            type: 'string'
          },
        },
        errorMessage: {
          required: {
            name: 'Your name is required',
          }
        }
      },
    }

I call the endpoint without providing a name

What was the result you received?

I got this response body should have required property 'name'

What did you expect?

the expected result to get my custom error message Your name is required

Context

based on the docs

add custom error messages for each property of a schema by supplying custom AJV options.

const fastify = Fastify({
  ajv: {
    customOptions: { jsonPointers: true },
    plugins: [
      require('ajv-errors')
    ]
  }
})

because , I use a ready generated template from Fastify-cli looks I have to pass these options within the command (Reference) but , there's no a clear way to pass these ajv options within Fastify-cli

• node version: 10.15.1
• fastify version: >=3.0.0
• os: Mac
• fastify-cli version:2.7.0

I think issue here with default AJV settings in fastify: it enabled coercion hence ajv coerce null on input to 0, you need to disable it

@jackcmeyer @blestab any clue?

The Fastify serializer is fast-json-stringify: it is not a validator in any form or fashion: it assumes you are generating is correct. It does all it can to make the data you are passing conform to the schema, e.g. coercing null to 0. If it's not possible to shape the data, it will throw: however it is very lenient and not spec-compliant.

This is useful to remove unwanted fields and make sure the output conforms to a given output. It's also faster than JSON.stringify.

🐛 Bug Report

• [ ] Tests pass even if they fail
• [ ] The tests fail. Understand why

Reference: https://github.com/HospitalRun/hospitalrun-frontend/runs/974788560?check_suite_focus=true#step:8:138

Cc @fox1t

Once we do this, we'll ping the authors of every open pr (again, like we did when we switched from next to master) to let them know that they need to rebase on a new branch (with zero breaking changes in this case).

Renaming a branch will: Re-target any open pull requests

Not even sure it is necessary

Those references need to be changed: https://github.com/fastify/fastify/blob/master/.github/workflows/website.yml#L6 https://github.com/fastify/fastify/blob/master/.github/workflows/package-manager-ci.yml#L6

The tooling provided by github is going to do all the rebasing automatically, it would also allow the old references to continue working. We can also wait for Node.js core to switch for example and validate the approach.

@jsumners I don't agree, if you are maintaining a fork for a pr changing the base branch is the same as changing it when targeting the wrong branch or when we switch from next to master. Once we do this, we'll ping the authors of every open pr (again, like we did when we switched from next to master) to let them know that they need to rebase on a new branch (with zero breaking changes in this case).

This is just a solution in search of a problem. And implementing it is going to cause problems for everyone who has the code forked.

Hi can you help fastify.route execute the function twice

I can't understand why the function is executed 2 times. I posted the entire function in which this error occurs. I would be very grateful for your help!

• node version: v14.15.1
• fastify version: >=3.9.1
• os: Windows
• any other relevant information:

**code debug link to video -> https://drive.google.com/file/d/1dYCk3QgAx36nAF2UGKByDgH7dip-xDnP/view?usp=sharing

Photo link controller https://drive.google.com/file/d/1EJ4imtJYGrPfDWoDBMpVJtwMj1yxjrhf/view?usp=sharing https://drive.google.com/file/d/1raJCmlqESeiGzAYcTc0tuqMMuxcWaRPJ/view?usp=sharing https://drive.google.com/file/d/1rn5e0AdfJIlliCOKzwOth94Hd0HEG_G9/view?usp=sharing

Please share the code and context in the issue.

Hi thanks for the answer solved the problem :_) in preHandler it was necessary to pass done

@Skn0tt double onRoute was called when prefixTrailingSlash was set to both. However, this behavior was neither expected (or at least I think so, coz single route definition triggering two onRoute) nor documented. Hence, we removed this double trigger.

Go for it!

As titled. It should not be a problem here, but the documentation build should be updated.

Related: https://github.com/github/renaming

/cc @lmammino

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/fastify/fastify/blob/master/CONTRIBUTING.md

By making a contribution to this project, I certify that:

• (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

• (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

• (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

• (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

Fix #97

Checklist

• [x] run npm run test and npm run benchmark
• [x] tests and/or benchmarks are included
• [x] commit message and code follows the Developer's Certification of Origin and the Code of conduct

🐛 Bug Report

Fastify 3.10, together with the use of prefixes, breaks fastify-websocket.

fastify.register(
  (fastify, opts, done) => {
    fastify.get("/", { websocket: true }, (connection, req) => {
      connection.socket.send("This works");
    });

    done();
  },
  { prefix: "/activity" }
);

To Reproduce

• Clone https://github.com/Skn0tt/fastify-websocket-3.10-repro
• Run index.js
• Connect to ws://localhost:3000/activity

Your Environment

• node version: 15.3
• fastify version: >=3.10
• os: Mac

Some ideas as to what may be causing this

Prior to 3.10, this line was called twice per route:

https://github.com/fastify/fastify-websocket/blob/99c94a003da2353c1f482301027166e64e743582/index.js#L36

That's why this lines makes sure to ignore one of them:

https://github.com/fastify/fastify-websocket/blob/99c94a003da2353c1f482301027166e64e743582/index.js#L42

Now with 3.10, the onRoute is called only once, and all of the routes are effectively ignored.

originally encountered in https://github.com/quirrel-dev/quirrel/issues/49

Nope, in a real world application you should use lock files, so this wouldn't impact you until you want to upgrade.

This was caused by: https://github.com/fastify/fastify/pull/2782/files. We had a few bugs in other plugins because it was called twice.

(Note that the change in Fastify was not causing any tests failures here).

cc @salmanm

Please share the code and context in the issue.

Hi can you help fastify.route execute the function twice

I can't understand why the function is executed 2 times. I posted the entire function in which this error occurs. I would be very grateful for your help!

• node version: v14.15.1
• fastify version: >=3.9.1
• os: Windows
• any other relevant information:

**code debug link to video -> https://drive.google.com/file/d/1dYCk3QgAx36nAF2UGKByDgH7dip-xDnP/view?usp=sharing

Photo link controller https://drive.google.com/file/d/1EJ4imtJYGrPfDWoDBMpVJtwMj1yxjrhf/view?usp=sharing https://drive.google.com/file/d/1raJCmlqESeiGzAYcTc0tuqMMuxcWaRPJ/view?usp=sharing https://drive.google.com/file/d/1rn5e0AdfJIlliCOKzwOth94Hd0HEG_G9/view?usp=sharing