profile
viewpoint
Forrest Hayes forresthayes forresthayes.dev Web developer, Open-Source Contributor, and RedwoodJS Core Community member

forresthayes/awesome-redwood 0

A community-driven collection of Redwood related plugins, config, themes, build scripts, tutorials, podcasts, and more.

forresthayes/bank_account 0

A bank account simulation exercise from Exercism.io

forresthayes/complete-intro-to-containers 0

The Complete Intro to Containers! As taught on Frontend Masters.

forresthayes/complete-intro-to-linux-and-the-cli 0

🐧 The Complete Intro to Linux and the Command Line, as taught for Frontend Masters

forresthayes/create-redwood-app 0

Template for `yarn create redwood-app`

forresthayes/dictionary 0

An app for selecting a word at random from a word list file.

forresthayes/elixirschool 0

Premier destination to learn and master the Elixir programming language

forresthayes/example-blog 0

Example Blog app written with Redwood

Pull request review commentredwoodjs/redwoodjs.com

Docs: TypeScript docs updates

 Create a `./web/tsconfig.json` file:     "paths": {       "src/*": ["./src/*"]     },-    "typeRoots": ["../.redwood"]+    "typeRoots": ["../.redwood"],+    "types": []   },-  "include": ["src"],+  "include": ["src"] } ```  You should now have type definitions, you can rename your files from `.js` to `.ts`, and the files that contain JSX to `.tsx`. +#### Getting types for `jest` in test files++If you're adding tests, you'll want to include the types for `jest` in your `tsconfig`.++```diff+-"types": []++"types": ["jest"]+```++Currently, these are added to `node_modules` by `@redwoodjs/core` and the above approach should just work. If this is not the case, you can `npm i -D @types/jest` in the `web` folder and they will resolve.

@Burnsy Thanks for the feedback! This is under the WEB section, but I guess it wouldn't hurt to add additional clarification language?

It might be a good idea to just add in a quick cli generator for tsconfigs that adds to the root and extends in the respective directories for overrides? I'm not sure if that's already a thing in the TS support meta tracker though.

msutkowski

comment created time in 4 hours

delete branch redwoodjs/redwood

delete branch : dependabot/npm_and_yarn/testing-library/react-11.2.3

delete time in 7 hours

pull request commentredwoodjs/redwood

Bump @testing-library/react from 11.2.2 to 11.2.3

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

dependabot[bot]

comment created time in 7 hours

PR closed redwoodjs/redwood

Bump @testing-library/react from 11.2.2 to 11.2.3 dependencies

Bumps @testing-library/react from 11.2.2 to 11.2.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/testing-library/react-testing-library/releases"><code>@testing-library/react's releases</code></a>.</em></p> <blockquote> <h2>v11.2.3</h2> <h2><a href="https://github.com/testing-library/react-testing-library/compare/v11.2.2...v11.2.3">11.2.3</a> (2021-01-07)</h2> <h3>Bug Fixes</h3> <ul> <li>Return type of unmount is <code>void</code> (<a href="https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/857">#857</a>) (<a href="https://github.com/testing-library/react-testing-library/commit/1389f094748991b3a900e2fcc9f4bf21df212da9">1389f09</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/testing-library/react-testing-library/commit/deafd51bc20209612674dbdaba920750c1d6352e"><code>deafd51</code></a> docs: add sanchit121 as a contributor (<a href="https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/858">#858</a>)</li> <li><a href="https://github.com/testing-library/react-testing-library/commit/1389f094748991b3a900e2fcc9f4bf21df212da9"><code>1389f09</code></a> fix: Return type of unmount is <code>void</code> (<a href="https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/857">#857</a>)</li> <li><a href="https://github.com/testing-library/react-testing-library/commit/64a8b9c2f30922d362028d9c6a31543c1874d1c7"><code>64a8b9c</code></a> chore: update all deps (<a href="https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/842">#842</a>)</li> <li><a href="https://github.com/testing-library/react-testing-library/commit/03bea9fd76349f458b6aff7b472acefe1879375f"><code>03bea9f</code></a> chore: Add 'Cancel Previous Runs' step (<a href="https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/840">#840</a>)</li> <li>See full diff in <a href="https://github.com/testing-library/react-testing-library/compare/v11.2.2...v11.2.3">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+6 -6

1 comment

3 changed files

dependabot[bot]

pr closed time in 7 hours

PR closed redwoodjs/redwood

[meta] Testing workflows
+2 -0

2 comments

1 changed file

pi0neerpat

pr closed time in 7 hours

pull request commentredwoodjs/redwood

[meta] Testing workflows

:)

pi0neerpat

comment created time in 7 hours

pull request commentredwoodjs/redwood

[meta] Testing workflows

📦 PR Packages

<details><summary>Click to Show Package Download Links</summary>

https://rw-pr-redwoodjs-com.s3.amazonaws.com/1665/create-redwood-app-0.23.0-3f951f8.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1665/redwoodjs-api-0.23.0-3f951f8.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1665/redwoodjs-api-server-0.23.0-3f951f8.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1665/redwoodjs-auth-0.23.0-3f951f8.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1665/redwoodjs-cli-0.23.0-3f951f8.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1665/redwoodjs-core-0.23.0-3f951f8.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1665/redwoodjs-dev-server-0.23.0-3f951f8.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1665/redwoodjs-eslint-config-0.23.0-3f951f8.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1665/redwoodjs-eslint-plugin-redwood-0.23.0-3f951f8.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1665/redwoodjs-forms-0.23.0-3f951f8.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1665/redwoodjs-internal-0.23.0-3f951f8.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1665/redwoodjs-router-0.23.0-3f951f8.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1665/redwoodjs-structure-0.23.0-3f951f8.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1665/redwoodjs-testing-0.23.0-3f951f8.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1665/redwoodjs-web-0.23.0-3f951f8.tgz </details>

Install this PR by running yarn rw upgrade --pr 1665:0.23.0-3f951f8

pi0neerpat

comment created time in 7 hours

PR opened redwoodjs/redwood

[meta] Testing workflows
+2 -0

0 comment

1 changed file

pr created time in 7 hours

issue commentredwoodjs/redwood

[RFC] Support for additional sides

I have an additional use case for this feature. I am doing some funky stuff with the router to accept routes via a wildcard subdomain and an "app" domain.

const Routes = () => {
  const subdomain = useSubdomain()

  if (subdomain == "app") {
    return (
      <Router>
        .... admin app routes on app.domain.com
      </Router>
    )
  }else{
    return (
      <Router>
        .... portal app routes on *.domain.com
      </Router>
    )
  }
}

After chatting with @Tobbe about my use case and showing him some issues I've noticed with the router and multiple flashes on render, he suspected it may be due to the way I set up the router.

So this seems like a great solution for this, where I would be able to have two web sides.

peterp

comment created time in 7 hours

issue openedredwoodjs/redwood

Using file access for Vercel deployment

Problem

When using libraries that need file access, there is no supported way to do this with Vercel + Redwood. Typically the use case here is templating libraries that initialize with a template directory of files, which the serverless functions need access to.

Attempts to make this work

Using the following vercel config option - https://vercel.com/knowledge/how-can-i-use-files-in-serverless-functions. By including the following vercel.json config

{
    "functions": {
        "api/src/functions/*.js": {
             "includeFiles": "api/src/templates/**"
        }
     }
}

However, you get an error. I've tried many different patterns but they all seem to fail with the following message

Error: The pattern "api/src/functions/*.js" defined infunctionsdoesn't match any Serverless Functions inside theapidirectory. Learn More: https://vercel.link/unmatched-function-pattern

The following repo can be used to reproduce the issue - https://github.com/viperfx/redwood-fs-vercel-bug

Vercel's response

After getting in touch with Vercel, and providing them with a repo to reproduce the issue, eventually, I got a reply from an engineer.

Checking this issue with one of our engineers, Vercel can't support "includeFiles" with Redwood at the moment. The way Redwood is configured is that it will bundle the dependencies together and all required files at build-time. Requiring a file at runtime will not work unless the file is also bundled in the function at the build-phase.

Checking the Redwood documentation and code-base, it appears you can't run this code either on AWS Lambda or Netlify, as it is a framework limitation.

References

Known workaround for Netlify - https://community.redwoodjs.com/t/how-can-i-read-and-bundle-a-non-js-or-ts-file-from-my-netlify-function/1021/11

created time in 7 hours

Pull request review commentredwoodjs/redwood

[Draft] Getting started with prerender

+import { useMemo } from 'react'++/* Web side prerender utils, to be used on the browser */++export const isPrerendering = (): boolean => {+  return !!global?.__REDWOOD_PRERENDER_MODE

Haha, sure. I'm not use the ?? syntax, but happy to change it.

dac09

comment created time in 8 hours

Pull request review commentredwoodjs/redwoodjs.com

Docs: TypeScript docs updates

 Create a `./web/tsconfig.json` file:     "paths": {       "src/*": ["./src/*"]     },-    "typeRoots": ["../.redwood"]+    "typeRoots": ["../.redwood"],+    "types": []   },-  "include": ["src"],+  "include": ["src"] } ```  You should now have type definitions, you can rename your files from `.js` to `.ts`, and the files that contain JSX to `.tsx`. +#### Getting types for `jest` in test files++If you're adding tests, you'll want to include the types for `jest` in your `tsconfig`.++```diff+-"types": []++"types": ["jest"]+```++Currently, these are added to `node_modules` by `@redwoodjs/core` and the above approach should just work. If this is not the case, you can `npm i -D @types/jest` in the `web` folder and they will resolve.

also might be worth saying tsconfig in web or api as we make two and you want to make sure they put it in the right place.

msutkowski

comment created time in 12 hours

push eventredwoodjs/redwood

Peter Pistorius

commit sha 771298cae4959ce3482cc4532c47b7b43003aece

Remove yarn install from script.

view details

Peter Pistorius

commit sha 9c09743cf15cfba658d7866f65a169ff0f512f16

Test bumping packages. Nice!

view details

push time in 13 hours

push eventredwoodjs/redwood

Peter Pistorius

commit sha 12cc80773e74fff1cdcd41fa4100043e4a2e3ecc

Remove extension. Makes for nicer commands.

view details

Peter Pistorius

commit sha 322b35e2266d6d5f0da9d25c492008137cd80090

Make the update script work.

view details

Peter Pistorius

commit sha 28e863129f5b6f02dc71b443cb0f5100cc563571

Clean up output.

view details

push time in 15 hours

push eventredwoodjs/redwood

Peter Pistorius

commit sha 85eac87d1f99d272b12f15a411f70733158dbe6d

Make crwa ignore template in build:watch.

view details

Peter Pistorius

commit sha 5840247eeefa3330bd41a2e415a00f093118ce54

Ignore changes to crwa template directory.

view details

push time in 16 hours

pull request commentredwoodjs/redwood

Draft script to update all packages

Good point @thedavidprice I can run yarn install too so that we can bump the yarn.lock file!

peterp

comment created time in 16 hours

issue closedredwoodjs/redwood

Why the default template is not in the monorepo?

Having to coordinate changes between the core and default template can be tricky. Why the template is in a separate repo?

If it's for making it easier to download during redwood init, we can solve that with a GitHub Action that publishes a tarball from the monorepo that only includes the template for the init script to download.

closed time in 16 hours

mohsen1

issue commentredwoodjs/redwood

Why the default template is not in the monorepo?

This is closed by #1637

mohsen1

comment created time in 16 hours

startedMarceloAlves/redwoodjs-react-query-provider

started time in 16 hours

pull request commentredwoodjs/redwood

Bump @testing-library/react from 11.2.2 to 11.2.3

📦 PR Packages

<details><summary>Click to Show Package Download Links</summary>

https://rw-pr-redwoodjs-com.s3.amazonaws.com/1663/create-redwood-app-0.23.0-82d4777.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1663/redwoodjs-api-0.23.0-82d4777.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1663/redwoodjs-api-server-0.23.0-82d4777.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1663/redwoodjs-auth-0.23.0-82d4777.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1663/redwoodjs-cli-0.23.0-82d4777.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1663/redwoodjs-core-0.23.0-82d4777.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1663/redwoodjs-dev-server-0.23.0-82d4777.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1663/redwoodjs-eslint-config-0.23.0-82d4777.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1663/redwoodjs-eslint-plugin-redwood-0.23.0-82d4777.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1663/redwoodjs-forms-0.23.0-82d4777.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1663/redwoodjs-internal-0.23.0-82d4777.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1663/redwoodjs-router-0.23.0-82d4777.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1663/redwoodjs-structure-0.23.0-82d4777.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1663/redwoodjs-testing-0.23.0-82d4777.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1663/redwoodjs-web-0.23.0-82d4777.tgz </details>

Install this PR by running yarn rw upgrade --pr 1663:0.23.0-82d4777

dependabot[bot]

comment created time in 16 hours

PR opened redwoodjs/redwood

Bump @testing-library/react from 11.2.2 to 11.2.3

Bumps @testing-library/react from 11.2.2 to 11.2.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/testing-library/react-testing-library/releases"><code>@testing-library/react's releases</code></a>.</em></p> <blockquote> <h2>v11.2.3</h2> <h2><a href="https://github.com/testing-library/react-testing-library/compare/v11.2.2...v11.2.3">11.2.3</a> (2021-01-07)</h2> <h3>Bug Fixes</h3> <ul> <li>Return type of unmount is <code>void</code> (<a href="https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/857">#857</a>) (<a href="https://github.com/testing-library/react-testing-library/commit/1389f094748991b3a900e2fcc9f4bf21df212da9">1389f09</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/testing-library/react-testing-library/commit/deafd51bc20209612674dbdaba920750c1d6352e"><code>deafd51</code></a> docs: add sanchit121 as a contributor (<a href="https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/858">#858</a>)</li> <li><a href="https://github.com/testing-library/react-testing-library/commit/1389f094748991b3a900e2fcc9f4bf21df212da9"><code>1389f09</code></a> fix: Return type of unmount is <code>void</code> (<a href="https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/857">#857</a>)</li> <li><a href="https://github.com/testing-library/react-testing-library/commit/64a8b9c2f30922d362028d9c6a31543c1874d1c7"><code>64a8b9c</code></a> chore: update all deps (<a href="https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/842">#842</a>)</li> <li><a href="https://github.com/testing-library/react-testing-library/commit/03bea9fd76349f458b6aff7b472acefe1879375f"><code>03bea9f</code></a> chore: Add 'Cancel Previous Runs' step (<a href="https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/840">#840</a>)</li> <li>See full diff in <a href="https://github.com/testing-library/react-testing-library/compare/v11.2.2...v11.2.3">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+6 -6

0 comment

3 changed files

pr created time in 16 hours

pull request commentredwoodjs/redwood

Draft script to update all packages

Nice!

Do you think the template/ now needs to include yarn.lock? Either during the CRWA installation process or manually afterward, folks are going to run yarn install eventually, which will create it at that time.

peterp

comment created time in 21 hours

startedtheacodes/Winterbloom_Castor_and_Pollux

started time in a day

pull request commentredwoodjs/redwood

Draft script to update all packages

📦 PR Packages

<details><summary>Click to Show Package Download Links</summary>

https://rw-pr-redwoodjs-com.s3.amazonaws.com/1662/create-redwood-app-0.23.0-0f5a7b3.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1662/redwoodjs-api-0.23.0-0f5a7b3.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1662/redwoodjs-api-server-0.23.0-0f5a7b3.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1662/redwoodjs-auth-0.23.0-0f5a7b3.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1662/redwoodjs-cli-0.23.0-0f5a7b3.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1662/redwoodjs-core-0.23.0-0f5a7b3.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1662/redwoodjs-dev-server-0.23.0-0f5a7b3.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1662/redwoodjs-eslint-config-0.23.0-0f5a7b3.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1662/redwoodjs-eslint-plugin-redwood-0.23.0-0f5a7b3.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1662/redwoodjs-forms-0.23.0-0f5a7b3.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1662/redwoodjs-internal-0.23.0-0f5a7b3.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1662/redwoodjs-router-0.23.0-0f5a7b3.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1662/redwoodjs-structure-0.23.0-0f5a7b3.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1662/redwoodjs-testing-0.23.0-0f5a7b3.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1662/redwoodjs-web-0.23.0-0f5a7b3.tgz </details>

Install this PR by running yarn rw upgrade --pr 1662:0.23.0-0f5a7b3

peterp

comment created time in a day

PR opened redwoodjs/redwood

Draft script to update all packages

This will update all the ./packages/* with lerna, and then will update the package.json files in create redwood app's template.

./tasks/update-package-version.js <version>

beep...
boop...

We can trigger this script when we tag this repo, which will allow us to automate publishing packages.

+36 -0

0 comment

1 changed file

pr created time in a day

create barnchredwoodjs/redwood

branch : pp-add-task-to-update-all-versions

created branch time in a day

issue openedredwoodjs/redwood

Write script to update packages version

  • [ ] Write a script that bumps the version with `./tasks/increment-version <number>
  • [ ] Once it's bumped by Lerna update ./packages/create-redwood-app/template/

created time in a day

pull request commentredwoodjs/redwood

Vendor create app template

Ah lol, you're right. Maybe we need some TENET action. I'll write a script that updates this and the other packages.

pepibumur

comment created time in a day

PR closed redwoodjs/redwoodjs.com

Add tailwind setup prompt

Just bumped into this today while setting up the tutorial. Tailwind styling was not showing up in storybook, because it wasn't set up yet for my project.

Its not shipped yarn create redwood-app X so it needs to be explicitly set up somewhere

+9 -1

3 comments

1 changed file

pi0neerpat

pr closed time in a day

more