profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/flouthoc/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

containers/podman 10324

Podman: A tool for managing OCI containers and pods.

containers/buildah 4491

A tool that facilitates building OCI images.

containers/crun 1191

A fast and lightweight fully featured OCI runtime and C library for running containers

flouthoc/calc.asm 566

Arithmetic calculator in x86 assembly

flouthoc/blinkTitle.js 113

Is a Pure Javascript Implementation of TitleBar Alert or Notification.It Can Perform Blinking of Html Titlebar When Required.

flouthoc/envelop.c 81

:ocean: Thread-less, event-loop based tiny http-server from scratch using epoll. Learning Purpose.

flouthoc/buha.js 29

Browser based Strictly ordered Task Queue for Sync/Async Javascript Functions

flouthoc/aku 26

Aku - Toy Backtesting/Trading Engine

flouthoc/commitchart-flutter 11

Implementation of Github Commit Chart in Flutter. [MIT License]

Pull request review commentcontainers/podman

volume: Add support for overlay on named volumes

 func finalizeMounts(ctx context.Context, s *specgen.SpecGenerator, rt *libpod.Ru 	}  	for _, v := range s.Volumes {-		if err = parse.ValidateVolumeCtrDir(v.Dest); err != nil {-			return nil, nil, nil, err+		// check if named volume has to be overlayed+		overlayFlag := false+		for _, o := range v.Options {+			if o == "O" {+				overlayFlag = true+			} 		}-		cleanDestination := filepath.Clean(v.Dest)-		if _, ok := unifiedVolumes[cleanDestination]; ok {-			return nil, nil, nil, errors.Wrapf(errDuplicateDest, "conflict in specified volumes - multiple volumes at %q", cleanDestination)++		if overlayFlag {+			vol, err := rt.LookupVolume(v.Name)+			if err != nil {+				return nil, nil, nil, err+			}+			mountPoint, err := vol.MountPoint()+			if err != nil {+				return nil, nil, nil, err+			}+			newOverlayVol := new(specgen.OverlayVolume)

this updated in latest commit.

flouthoc

comment created time in an hour

push eventflouthoc/podman

Daniel J Walsh

commit sha 74ad05396b7c988856c3c2d3af88f3725ef29775

Add podman machine init --now option Once we have this option, the new documentation from users becomes a little simpler. brew install podman podman machine init --now podman run ... --now option is based off of `systemctl enable XYZ.service --now` [NO TESTS NEEDED] The infrastructure has not been setup yet to test podman machine init. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

view details

Giuseppe Scrivano

commit sha 4caca0969863f5b8d13ff377ed1cc24d4033ed1a

utils: raise warning only on cgroupv2 if it is not running on cgroup v2, print only a debug message since rootless users cannot create the cgroup. commit 9c1e27fdd536f6026efe3da4360755a3e9135ca8 introduced the regression. [NO TESTS NEEDED] Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

view details

Giuseppe Scrivano

commit sha eea5d251267d070d7920008056e3e4d603cae204

utils: return error message from StartTransientUnit Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

view details

Paul Holzinger

commit sha cf28dab9f10d346dea07f7f6306b9701858d5268

podman machine: use gvproxy for host.containers.internal Let the gvproxy dns server handle the host.containers.internal entry. Support for this is already added to gvproxy. [1] To make sure the container uses the dns response from gvproxy we should not add host.containers.internal to /etc/hosts in this case. [NO TESTS NEEDED] podman machine has no tests :/ Fixes #11642 [1] https://github.com/containers/gvisor-tap-vsock/commit/1108ea45162281046d239047a6db9bc187e64b08 Signed-off-by: Paul Holzinger <pholzing@redhat.com>

view details

Paul Holzinger

commit sha 5242030ac275e497b6b91186bb6305b5cb40c96a

compat API: /images/json prefix image id with sha256 Docker adds the `sha256:` prefix to the image ID, so our compat endpoint has to do this as well. Fixes #11623 Signed-off-by: Paul Holzinger <pholzing@redhat.com>

view details

cdoern

commit sha cb077c968de08c98eda023f5eeefc7d9d8e79231

Created MapOptions for PodCreate MapOptions take the pod and container create options, assigning matching values from infra back to the pod for the Libpod API. This function, unlike the previous one, does not require any manual additions when new options are added since it uses the structs JSON tags, this is a more modular approach. Signed-off-by: cdoern <cdoern@redhat.com>

view details

OpenShift Merge Robot

commit sha b906ecbb5bc887f5123a0f61a5a51782aa34357f

Merge pull request #11648 from giuseppe/raise-move-process-to-scope-only-with-cgroupv2 utils: raise warning only on cgroupv2

view details

Valentin Rothberg

commit sha 92ee2f372ba06ec7c09008d9a28e4c9ce35bf51a

remote untag: support digests Fix a bug when remotely untagging an image via tag@digest. The digest has been lost in the remote client and hence led to a wrong behaviour on the server. Fixes: #11557 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

view details

Valentin Rothberg

commit sha 50981245706f7ab8dd57ddaf7efb39a171bbd97b

vendor c/common@main Finalizes the linked BZ to fix passing down custom authfiles during auto updates. Also fixes the if-newer pull policy. [NO TESTS NEEDED] for now validated manually. There's a TODO to add a new system test that I did not find time for before PTO. BZ: bugzilla.redhat.com/show_bug.cgi?id=2000943 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

view details

OpenShift Merge Robot

commit sha f7d7fc2c8c70ca36cf2e9441cd1a8c40c042ba11

Merge pull request #11651 from vrothberg/fix-11557 remote untag: support digests

view details

OpenShift Merge Robot

commit sha cc6a85bcde1e7068105502dbc21afbb51b3e70d5

Merge pull request #11652 from vrothberg/vendor-common vendor c/common@main

view details

Urvashi Mohnani

commit sha 665b451e51584b06c6be561bdd49259ea71f4094

[CI:DOCS] Add link to skopeo delete in podman rmi Add a note pointing to skopeo delete for when users want to delete an image in a remote registry. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>

view details

Daniel J Walsh

commit sha 3221f50a4582153fa65be4f9493739e1e0ed1c33

Add podman image/container inspect man pages [NO TESTS NEEDED] since this is really a docs change. Concludes: https://github.com/containers/podman/pull/11620 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

view details

Daniel J Walsh

commit sha b74edfb0a1bf5a27a3bba884a0e2275d2f281a65

Add support for retrieving system service --timeout Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

view details

OpenShift Merge Robot

commit sha 8ccaebb853a53877a5ac446af5bb5892019565ce

Merge pull request #11661 from umohnani8/docs [CI:DOCS] Add link to skopeo delete in podman rmi

view details

OpenShift Merge Robot

commit sha 4cdffd07142c4362e9c2efdb841b286d6cd4f2b8

Merge pull request #11656 from Luap99/compat-id compat API: /images/json prefix image id with sha256

view details

OpenShift Merge Robot

commit sha b700fe22fdb3b25d6eef2f9ccff8fe39eadd3979

Merge pull request #11644 from rhatdan/now Add podman machine init --now option

view details

OpenShift Merge Robot

commit sha a2b367414394e069a7560dc7e189af035abf0973

Merge pull request #11649 from Luap99/machine-dns podman machine: use gvproxy for host.containers.internal

view details

OpenShift Merge Robot

commit sha fff178fe517406f61fc6ddad00312ee7282e0174

Merge pull request #11601 from cdoern/mapOptions Created MapOptions for PodCreate

view details

OpenShift Merge Robot

commit sha 791458605af79e17e12a5a56fff30742ea0ff310

Merge pull request #11630 from rhatdan/timeout Add support for retrieving system service --timeout

view details

push time in an hour

Pull request review commentcontainers/podman

volume: Add support for overlay on named volumes

 func finalizeMounts(ctx context.Context, s *specgen.SpecGenerator, rt *libpod.Ru 	}  	for _, v := range s.Volumes {-		if err = parse.ValidateVolumeCtrDir(v.Dest); err != nil {-			return nil, nil, nil, err+		// check if named volume has to be overlayed+		overlayFlag := false+		for _, o := range v.Options {+			if o == "O" {+				overlayFlag = true+			} 		}-		cleanDestination := filepath.Clean(v.Dest)-		if _, ok := unifiedVolumes[cleanDestination]; ok {-			return nil, nil, nil, errors.Wrapf(errDuplicateDest, "conflict in specified volumes - multiple volumes at %q", cleanDestination)++		if overlayFlag {+			vol, err := rt.LookupVolume(v.Name)+			if err != nil {+				return nil, nil, nil, err+			}+			mountPoint, err := vol.MountPoint()+			if err != nil {+				return nil, nil, nil, err+			}+			newOverlayVol := new(specgen.OverlayVolume)

ps: we had a discussion and current blocker is guarantee is removed if user is using a overlayed named volume and lower is removed. cc @mheon

flouthoc

comment created time in 17 hours

PullRequestReviewEvent

issue commentcontainers/buildah

bud: permit turning off the history

Yes since its optional on image-spec i guess we can also have it as optional https://github.com/opencontainers/image-spec/blob/main/config.md#properties

dilyanpalauzov

comment created time in 17 hours

pull request commentcontainers/buildah

build: Cleanup and remount `/run` directory with every RUN step

cc @nalind

flouthoc

comment created time in 18 hours

Pull request review commentcontainers/podman

volume: Add support for overlay on named volumes

 func finalizeMounts(ctx context.Context, s *specgen.SpecGenerator, rt *libpod.Ru 	}  	for _, v := range s.Volumes {-		if err = parse.ValidateVolumeCtrDir(v.Dest); err != nil {-			return nil, nil, nil, err+		// check if named volume has to be overlayed+		overlayFlag := false+		for _, o := range v.Options {+			if o == "O" {+				overlayFlag = true+			} 		}-		cleanDestination := filepath.Clean(v.Dest)-		if _, ok := unifiedVolumes[cleanDestination]; ok {-			return nil, nil, nil, errors.Wrapf(errDuplicateDest, "conflict in specified volumes - multiple volumes at %q", cleanDestination)++		if overlayFlag {+			vol, err := rt.LookupVolume(v.Name)+			if err != nil {+				return nil, nil, nil, err+			}+			mountPoint, err := vol.MountPoint()+			if err != nil {+				return nil, nil, nil, err+			}+			newOverlayVol := new(specgen.OverlayVolume)

@mheon so whenever it is mounted as overlay its not added to the list of unifiedVolumes but i can confirm if there are any race conditions.

flouthoc

comment created time in 19 hours

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentcontainers/podman

volume: Add support for overlay on named volumes

 func finalizeMounts(ctx context.Context, s *specgen.SpecGenerator, rt *libpod.Ru 	}  	for _, v := range s.Volumes {-		if err = parse.ValidateVolumeCtrDir(v.Dest); err != nil {-			return nil, nil, nil, err+		// check if named volume has to be overlayed+		overlayFlag := false+		for _, o := range v.Options {+			if o == "O" {+				overlayFlag = true+			} 		}-		cleanDestination := filepath.Clean(v.Dest)-		if _, ok := unifiedVolumes[cleanDestination]; ok {-			return nil, nil, nil, errors.Wrapf(errDuplicateDest, "conflict in specified volumes - multiple volumes at %q", cleanDestination)++		if overlayFlag {+			vol, err := rt.LookupVolume(v.Name)+			if err != nil {+				return nil, nil, nil, err+			}+			mountPoint, err := vol.MountPoint()+			if err != nil {+				return nil, nil, nil, err+			}+			newOverlayVol := new(specgen.OverlayVolume)

@mheon oh this happens when user specifically adds :O with the named volume for instance podman container run -v example:/example:O busybox sh -c 'ls /example' in all the cases :O is not configured for named volume it only happens when user explicitly specifies so in such cases named volume is only mounted as overlay inside container and not processed as a regular volume. So this keeps original named volume intact.

flouthoc

comment created time in 19 hours

Pull request review commentcontainers/podman

volume: Add support for overlay on named volumes

 func finalizeMounts(ctx context.Context, s *specgen.SpecGenerator, rt *libpod.Ru 	}  	for _, v := range s.Volumes {-		if err = parse.ValidateVolumeCtrDir(v.Dest); err != nil {-			return nil, nil, nil, err+		// check if named volume has to be overlayed+		overlayFlag := false

@rhatdan apart from this, check happens in specgen but not at any other place. Initially i wanted to do this when specgen creation happens but we cannot transform named volume to overlay in specgen since we need access to runtime for mountPoint.

So after specgen creation this is the second place i dont think any another place has this check.

flouthoc

comment created time in 19 hours

PullRequestReviewEvent

push eventflouthoc/podman

Aditya Rajan

commit sha 78e2bf30b6ec7a787fbe2cca620c529424a65d33

volume: Add support for overlay on named volumes Following PR allows containers to create and mount overlays on top of named volumes instead of mounting actual volumes via already documented `:O`. Signed-off-by: Aditya Rajan <arajan@redhat.com>

view details

push time in a day

pull request commentcontainers/crun

utils: add new function safe_readlinkat

LGTM. I think clang-format is needed.

giuseppe

comment created time in a day

push eventflouthoc/podman

Aditya Rajan

commit sha 81f4b84d6b3ca3f4edb1697d424581c1dca29382

volume: Add support for overlay on named volumes Following PR allows containers to create and mount overlays on top of named volumes instead of mounting actual volumes via already documented `:O`. Signed-off-by: Aditya Rajan <arajan@redhat.com>

view details

push time in a day

issue commentcontainers/podman

`:O` option is silently ignored on named volumes.

@tomprince Could you please try above PR it adds support for creating overlay on top of named volumes.

tomprince

comment created time in a day

pull request commentcontainers/buildah

build: Cleanup and remount `/run` directory with every RUN step

@rhatdan I think /etc is not a problem for the issue which @cgwalters created since other directory are already part of expected file structure instead of /run but sure we can clean up those as well if its needed. @cgwalters could you please confirm ?

flouthoc

comment created time in a day

PR opened containers/podman

volume: Add support for overlay on named volumes

Following PR allows containers to create and mount overlays on top of named volumes instead of mounting actual volumes via already documented :O.

Closes: https://github.com/containers/podman/issues/11640

+59 -6

0 comment

2 changed files

pr created time in a day

create barnchflouthoc/podman

branch : named-volume-overlay

created branch time in a day

push eventflouthoc/podman

Giuseppe Scrivano

commit sha 44abc17977165ceb6b7d84efe4b9c62c8fbb2ac1

libpod: honor --cgroups=split also with pods Honor --cgroups=split also when the container is running in a pod. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

view details

cdoern

commit sha 84005330aa3d25cf6134fffc1bf20354d4a3dd85

Pod Volumes Support added support for the --volume flag in pods using the new infra container design. users can specify all volume options they can with regular containers resolves #10379 Signed-off-by: cdoern <cdoern@redhat.com>

view details

Anders F Björklund

commit sha 38c5f6721f9aa2dc2aea751c2e22afd4d9e370b5

Show variant and codename of the distribution Along with the name (id) and the version(_id) But only show the information if is available Examples: Fedora CoreOS, Ubuntu Focal [NO TESTS NEEDED] Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>

view details

Nalin Dahyabhai

commit sha 5dbf3ee7aeef6e2aca5512b3ad8684610080d421

build: take advantage of --platform lists The builder can take a list of platforms in the Platforms field of its BuildOptions argument, and we should definitely take advantage of that. The `bud-multiple-platform-values` test from buildah exercises support for this, so [NO TESTS NEEDED] Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>

view details

Jelle van der Waa

commit sha 9b04e17893dbf91326c0f68ce7627d7bb07cf515

api: handle nil pointer dereference in rest endpoints When `?all=garbage` is passed to an API endpoint schema validation fails and err is nil. Wrapf uses err to create an error message causing a nil pointer dereference. Signed-off-by: Jelle van der Waa <jvanderwaa@redhat.com>

view details

Aditya Rajan

commit sha 222b62e7b0b8b8e5ac69b776d7024c63d620b29b

vendor: Bump github.com/containers/buildah from 1.22.3 to 1.23.0 [NO TESTS NEEDED] Signed-off-by: Aditya Rajan <arajan@redhat.com>

view details

Paul Holzinger

commit sha 5cafb6d18d317153e3b44683f5dab18f9936a393

Fix example in podman machine init man page Fixes #11582 Signed-off-by: Paul Holzinger <pholzing@redhat.com>

view details

Aditya Rajan

commit sha d0c605cd3da07175478b5c3947056856558be9f7

build: mirror --authfile to filesystem if pointing to FD instead of file Following commit makes sure that podman mirrors --authfile to a temporary file in filesystem if arg is pointing to an FD instead of actual file as FD can be only consumed once. Reference: * https://github.com/containers/buildah/pull/3498 * https://github.com/containers/buildah/issues/3070 [NO TESTS NEEDED] Signed-off-by: Aditya Rajan <arajan@redhat.com>

view details

Aditya Rajan

commit sha 962675c1482abc3a8458ef060552687a784282a6

build.bats: fix copy tests after containers/buildah#3486 Fix copy tests after https://github.com/containers/buildah/pull/3486 [NO TESTS NEEDED] Signed-off-by: Aditya Rajan <arajan@gmail.com>

view details

OpenShift Merge Robot

commit sha 07e9bf340a83ecb7174e32fb565826c21a9a91ca

Merge pull request #11586 from Luap99/doc [CI:DOCS] Fix example in podman machine init man page

view details

OpenShift Merge Robot

commit sha aff64dda65514064ccbf7fcaf78293e111539eb6

Merge pull request #11574 from nalind/buildah-platforms build: take advantage of --platform lists

view details

OpenShift Merge Robot

commit sha 10873c6f494fbc7a43365000f6f9702c21741077

Merge pull request #11578 from jelly/handle_nil_pointer_deref api: handle nil pointer dereference in api endpoints

view details

OpenShift Merge Robot

commit sha 4dd7bfdfaa3adf95af39fd45f74d49cea0c80064

Merge pull request #11556 from afbjorklund/distribution-info Show variant and codename of the distribution

view details

OpenShift Merge Robot

commit sha 4b6ffda31c258aadcbc6171a7dd745d0fb17393c

Merge pull request #11409 from cdoern/podVolumes Pod Volumes Support

view details

OpenShift Merge Robot

commit sha 81f41ca0d2a0acd9896bb60b1096baa236725dec

Merge pull request #11585 from flouthoc/bump-buildah-1-23-0 vendor: Bump github.com/containers/buildah from 1.22.3 to 1.23.0

view details

Paul Holzinger

commit sha 0b1c45bc542636d48abcc3980baa02b9a65f57a9

container runlabel remove image tag from name When no name is given for podman container runlabel it will default to the image base name. However this can contain a tag. Since podman does not accept container names with a colon the run command will fail if it contains something like `podman run --name NAME ...`. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2004263 Signed-off-by: Paul Holzinger <pholzing@redhat.com>

view details

Daniel J Walsh

commit sha 3e77f960f65687dcb1d571ebe70278028c6de441

Set default storage from containers.conf for temporary images Fixes: https://github.com/containers/podman/issues/11107 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

view details

OpenShift Merge Robot

commit sha c0cde378298bd8d5183155c8f62aae574be069eb

Merge pull request #11567 from giuseppe/cgroups-split-with-pods libpod: honor --cgroups=split also with pods

view details

Paul Holzinger

commit sha aa7bc4e37168e4cdb4469ba8b728d7f5157e46b5

network create: validate the input subnet Check that the given subnet does not conflict with existing ones (other configs or host interfaces). Signed-off-by: Paul Holzinger <pholzing@redhat.com>

view details

Paul Holzinger

commit sha 24bec9a76bcc2d8e93670047ed0ee8c16d9d7620

default network: do not validate the used subnets The default network should not be validated against used subnets, we have to ensure that this network can always be created even when a subnet is already used on the host. This could happen if you run a container on this net, then the cni interface will be created on the host and "block" this subnet from being used again. Therefore the next podman command tries to create the default net again and it would fail because it thinks the network is used on the host. Signed-off-by: Paul Holzinger <pholzing@redhat.com>

view details

push time in a day

startedintel/cri-resource-manager

started time in a day

startedrust-osdev/x86_64

started time in a day

push eventcontainers/crun

Дилян Палаузов

commit sha ef24f0ce81657f9548b71e0c65cec90818e0c322

README.md: ./configure.sh → ./configure

view details

flouthoc

commit sha ac77b44f6539cbe9b03d2f036cec829146cd4e83

Merge pull request #730 from dilyanpalauzov/main README.md: ./configure.sh → ./configure

view details

push time in a day

PullRequestReviewEvent

startedtikv/raft-engine

started time in 2 days

issue commentcontainers/podman

`:O` option is silently ignored on named volumes.

I'll check this.

tomprince

comment created time in 2 days

issue commentcontainers/buildah

bud: permit turning off the history

@dilyanpalauzov Please correct me if i am wrong your intention is to reduce size of tar by removing history from config ?

dilyanpalauzov

comment created time in 2 days

pull request commentcontainers/buildah

build: Cleanup `/run` directory after every RUN step

/hold

flouthoc

comment created time in 2 days

issue commentcontainers/buildah

`podman build` adds `/run` files in generated layers

@cgwalters Could you please try above PR please.

cgwalters

comment created time in 2 days